Line data Source code
1 : pub mod chaos_injector;
2 : mod context_iterator;
3 : pub(crate) mod safekeeper_reconciler;
4 : mod safekeeper_service;
5 :
6 : use std::borrow::Cow;
7 : use std::cmp::Ordering;
8 : use std::collections::{BTreeMap, HashMap, HashSet};
9 : use std::error::Error;
10 : use std::num::NonZeroU32;
11 : use std::ops::{Deref, DerefMut};
12 : use std::path::PathBuf;
13 : use std::str::FromStr;
14 : use std::sync::Arc;
15 : use std::time::{Duration, Instant};
16 :
17 : use anyhow::Context;
18 : use context_iterator::TenantShardContextIterator;
19 : use control_plane::storage_controller::{
20 : AttachHookRequest, AttachHookResponse, InspectRequest, InspectResponse,
21 : };
22 : use diesel::result::DatabaseErrorKind;
23 : use futures::StreamExt;
24 : use futures::stream::FuturesUnordered;
25 : use http_utils::error::ApiError;
26 : use hyper::Uri;
27 : use itertools::Itertools;
28 : use pageserver_api::controller_api::{
29 : AvailabilityZone, MetadataHealthRecord, MetadataHealthUpdateRequest, NodeAvailability,
30 : NodeRegisterRequest, NodeSchedulingPolicy, NodeShard, NodeShardResponse, PlacementPolicy,
31 : ShardSchedulingPolicy, ShardsPreferredAzsRequest, ShardsPreferredAzsResponse,
32 : TenantCreateRequest, TenantCreateResponse, TenantCreateResponseShard, TenantDescribeResponse,
33 : TenantDescribeResponseShard, TenantLocateResponse, TenantPolicyRequest,
34 : TenantShardMigrateRequest, TenantShardMigrateResponse,
35 : };
36 : use pageserver_api::models::{
37 : self, DetachBehavior, LocationConfig, LocationConfigListResponse, LocationConfigMode,
38 : PageserverUtilization, SecondaryProgress, ShardParameters, TenantConfig,
39 : TenantConfigPatchRequest, TenantConfigRequest, TenantLocationConfigRequest,
40 : TenantLocationConfigResponse, TenantShardLocation, TenantShardSplitRequest,
41 : TenantShardSplitResponse, TenantSorting, TenantTimeTravelRequest,
42 : TimelineArchivalConfigRequest, TimelineCreateRequest, TimelineCreateResponseStorcon,
43 : TimelineInfo, TopTenantShardItem, TopTenantShardsRequest,
44 : };
45 : use pageserver_api::shard::{
46 : ShardCount, ShardIdentity, ShardNumber, ShardStripeSize, TenantShardId,
47 : };
48 : use pageserver_api::upcall_api::{
49 : ReAttachRequest, ReAttachResponse, ReAttachResponseTenant, ValidateRequest, ValidateResponse,
50 : ValidateResponseTenant,
51 : };
52 : use pageserver_client::{BlockUnblock, mgmt_api};
53 : use reqwest::{Certificate, StatusCode};
54 : use safekeeper_api::models::SafekeeperUtilization;
55 : use safekeeper_reconciler::SafekeeperReconcilers;
56 : use tokio::sync::TryAcquireError;
57 : use tokio::sync::mpsc::error::TrySendError;
58 : use tokio_util::sync::CancellationToken;
59 : use tracing::{Instrument, debug, error, info, info_span, instrument, warn};
60 : use utils::completion::Barrier;
61 : use utils::generation::Generation;
62 : use utils::id::{NodeId, TenantId, TimelineId};
63 : use utils::sync::gate::Gate;
64 : use utils::{failpoint_support, pausable_failpoint};
65 :
66 : use crate::background_node_operations::{
67 : Drain, Fill, MAX_RECONCILES_PER_OPERATION, Operation, OperationError, OperationHandler,
68 : };
69 : use crate::compute_hook::{self, ComputeHook, NotifyError};
70 : use crate::drain_utils::{self, TenantShardDrain, TenantShardIterator};
71 : use crate::heartbeater::{Heartbeater, PageserverState, SafekeeperState};
72 : use crate::id_lock_map::{
73 : IdLockMap, TracingExclusiveGuard, trace_exclusive_lock, trace_shared_lock,
74 : };
75 : use crate::leadership::Leadership;
76 : use crate::metrics;
77 : use crate::node::{AvailabilityTransition, Node};
78 : use crate::pageserver_client::PageserverClient;
79 : use crate::peer_client::GlobalObservedState;
80 : use crate::persistence::split_state::SplitState;
81 : use crate::persistence::{
82 : AbortShardSplitStatus, ControllerPersistence, DatabaseError, DatabaseResult,
83 : MetadataHealthPersistence, Persistence, ShardGenerationState, TenantFilter,
84 : TenantShardPersistence,
85 : };
86 : use crate::reconciler::{
87 : ReconcileError, ReconcileUnits, ReconcilerConfig, ReconcilerConfigBuilder, ReconcilerPriority,
88 : attached_location_conf,
89 : };
90 : use crate::safekeeper::Safekeeper;
91 : use crate::scheduler::{
92 : AttachedShardTag, MaySchedule, ScheduleContext, ScheduleError, ScheduleMode, Scheduler,
93 : };
94 : use crate::tenant_shard::{
95 : IntentState, MigrateAttachment, ObservedState, ObservedStateDelta, ObservedStateLocation,
96 : ReconcileNeeded, ReconcileResult, ReconcileWaitError, ReconcilerStatus, ReconcilerWaiter,
97 : ScheduleOptimization, ScheduleOptimizationAction, TenantShard,
98 : };
99 :
100 : const WAITER_FILL_DRAIN_POLL_TIMEOUT: Duration = Duration::from_millis(500);
101 :
102 : // For operations that should be quick, like attaching a new tenant
103 : const SHORT_RECONCILE_TIMEOUT: Duration = Duration::from_secs(5);
104 :
105 : // For operations that might be slow, like migrating a tenant with
106 : // some data in it.
107 : pub const RECONCILE_TIMEOUT: Duration = Duration::from_secs(30);
108 :
109 : // If we receive a call using Secondary mode initially, it will omit generation. We will initialize
110 : // tenant shards into this generation, and as long as it remains in this generation, we will accept
111 : // input generation from future requests as authoritative.
112 : const INITIAL_GENERATION: Generation = Generation::new(0);
113 :
114 : /// How long [`Service::startup_reconcile`] is allowed to take before it should give
115 : /// up on unresponsive pageservers and proceed.
116 : pub(crate) const STARTUP_RECONCILE_TIMEOUT: Duration = Duration::from_secs(30);
117 :
118 : /// How long a node may be unresponsive to heartbeats before we declare it offline.
119 : /// This must be long enough to cover node restarts as well as normal operations: in future
120 : pub const MAX_OFFLINE_INTERVAL_DEFAULT: Duration = Duration::from_secs(30);
121 :
122 : /// How long a node may be unresponsive to heartbeats during start up before we declare it
123 : /// offline.
124 : ///
125 : /// This is much more lenient than [`MAX_OFFLINE_INTERVAL_DEFAULT`] since the pageserver's
126 : /// handling of the re-attach response may take a long time and blocks heartbeats from
127 : /// being handled on the pageserver side.
128 : pub const MAX_WARMING_UP_INTERVAL_DEFAULT: Duration = Duration::from_secs(300);
129 :
130 : /// How often to send heartbeats to registered nodes?
131 : pub const HEARTBEAT_INTERVAL_DEFAULT: Duration = Duration::from_secs(5);
132 :
133 : /// How long is too long for a reconciliation?
134 : pub const LONG_RECONCILE_THRESHOLD_DEFAULT: Duration = Duration::from_secs(120);
135 :
136 : #[derive(Clone, strum_macros::Display)]
137 : enum TenantOperations {
138 : Create,
139 : LocationConfig,
140 : ConfigSet,
141 : ConfigPatch,
142 : TimeTravelRemoteStorage,
143 : Delete,
144 : UpdatePolicy,
145 : ShardSplit,
146 : SecondaryDownload,
147 : TimelineCreate,
148 : TimelineDelete,
149 : AttachHook,
150 : TimelineArchivalConfig,
151 : TimelineDetachAncestor,
152 : TimelineGcBlockUnblock,
153 : DropDetached,
154 : DownloadHeatmapLayers,
155 : }
156 :
157 : #[derive(Clone, strum_macros::Display)]
158 : enum NodeOperations {
159 : Register,
160 : Configure,
161 : Delete,
162 : }
163 :
164 : /// The leadership status for the storage controller process.
165 : /// Allowed transitions are:
166 : /// 1. Leader -> SteppedDown
167 : /// 2. Candidate -> Leader
168 : #[derive(
169 : Eq,
170 : PartialEq,
171 : Copy,
172 : Clone,
173 : strum_macros::Display,
174 0 : strum_macros::EnumIter,
175 : measured::FixedCardinalityLabel,
176 : )]
177 : #[strum(serialize_all = "snake_case")]
178 : pub(crate) enum LeadershipStatus {
179 : /// This is the steady state where the storage controller can produce
180 : /// side effects in the cluster.
181 : Leader,
182 : /// We've been notified to step down by another candidate. No reconciliations
183 : /// take place in this state.
184 : SteppedDown,
185 : /// Initial state for a new storage controller instance. Will attempt to assume leadership.
186 : #[allow(unused)]
187 : Candidate,
188 : }
189 :
190 : pub const RECONCILER_CONCURRENCY_DEFAULT: usize = 128;
191 : pub const PRIORITY_RECONCILER_CONCURRENCY_DEFAULT: usize = 256;
192 :
193 : // Depth of the channel used to enqueue shards for reconciliation when they can't do it immediately.
194 : // This channel is finite-size to avoid using excessive memory if we get into a state where reconciles are finishing more slowly
195 : // than they're being pushed onto the queue.
196 : const MAX_DELAYED_RECONCILES: usize = 10000;
197 :
198 : // Top level state available to all HTTP handlers
199 : struct ServiceState {
200 : leadership_status: LeadershipStatus,
201 :
202 : tenants: BTreeMap<TenantShardId, TenantShard>,
203 :
204 : nodes: Arc<HashMap<NodeId, Node>>,
205 :
206 : safekeepers: Arc<HashMap<NodeId, Safekeeper>>,
207 :
208 : safekeeper_reconcilers: SafekeeperReconcilers,
209 :
210 : scheduler: Scheduler,
211 :
212 : /// Ongoing background operation on the cluster if any is running.
213 : /// Note that only one such operation may run at any given time,
214 : /// hence the type choice.
215 : ongoing_operation: Option<OperationHandler>,
216 :
217 : /// Queue of tenants who are waiting for concurrency limits to permit them to reconcile
218 : delayed_reconcile_rx: tokio::sync::mpsc::Receiver<TenantShardId>,
219 : }
220 :
221 : /// Transform an error from a pageserver into an error to return to callers of a storage
222 : /// controller API.
223 0 : fn passthrough_api_error(node: &Node, e: mgmt_api::Error) -> ApiError {
224 0 : match e {
225 0 : mgmt_api::Error::SendRequest(e) => {
226 0 : // Presume errors sending requests are connectivity/availability issues
227 0 : ApiError::ResourceUnavailable(format!("{node} error sending request: {e}").into())
228 : }
229 0 : mgmt_api::Error::ReceiveErrorBody(str) => {
230 0 : // Presume errors receiving body are connectivity/availability issues
231 0 : ApiError::ResourceUnavailable(
232 0 : format!("{node} error receiving error body: {str}").into(),
233 0 : )
234 : }
235 0 : mgmt_api::Error::ReceiveBody(err) if err.is_decode() => {
236 0 : // Return 500 for decoding errors.
237 0 : ApiError::InternalServerError(anyhow::Error::from(err).context("error decoding body"))
238 : }
239 0 : mgmt_api::Error::ReceiveBody(err) => {
240 0 : // Presume errors receiving body are connectivity/availability issues except for decoding errors
241 0 : let src_str = err.source().map(|e| e.to_string()).unwrap_or_default();
242 0 : ApiError::ResourceUnavailable(
243 0 : format!("{node} error receiving error body: {err} {}", src_str).into(),
244 0 : )
245 : }
246 0 : mgmt_api::Error::ApiError(StatusCode::NOT_FOUND, msg) => {
247 0 : ApiError::NotFound(anyhow::anyhow!(format!("{node}: {msg}")).into())
248 : }
249 0 : mgmt_api::Error::ApiError(StatusCode::SERVICE_UNAVAILABLE, msg) => {
250 0 : ApiError::ResourceUnavailable(format!("{node}: {msg}").into())
251 : }
252 0 : mgmt_api::Error::ApiError(status @ StatusCode::UNAUTHORIZED, msg)
253 0 : | mgmt_api::Error::ApiError(status @ StatusCode::FORBIDDEN, msg) => {
254 : // Auth errors talking to a pageserver are not auth errors for the caller: they are
255 : // internal server errors, showing that something is wrong with the pageserver or
256 : // storage controller's auth configuration.
257 0 : ApiError::InternalServerError(anyhow::anyhow!("{node} {status}: {msg}"))
258 : }
259 0 : mgmt_api::Error::ApiError(status @ StatusCode::TOO_MANY_REQUESTS, msg) => {
260 0 : // Pass through 429 errors: if pageserver is asking us to wait + retry, we in
261 0 : // turn ask our clients to wait + retry
262 0 : ApiError::Conflict(format!("{node} {status}: {status} {msg}"))
263 : }
264 0 : mgmt_api::Error::ApiError(status, msg) => {
265 0 : // Presume general case of pageserver API errors is that we tried to do something
266 0 : // that can't be done right now.
267 0 : ApiError::Conflict(format!("{node} {status}: {status} {msg}"))
268 : }
269 0 : mgmt_api::Error::Cancelled => ApiError::ShuttingDown,
270 0 : mgmt_api::Error::CreateClient(e) => ApiError::InternalServerError(anyhow::anyhow!(e)),
271 : }
272 0 : }
273 :
274 : impl ServiceState {
275 0 : fn new(
276 0 : nodes: HashMap<NodeId, Node>,
277 0 : safekeepers: HashMap<NodeId, Safekeeper>,
278 0 : tenants: BTreeMap<TenantShardId, TenantShard>,
279 0 : scheduler: Scheduler,
280 0 : delayed_reconcile_rx: tokio::sync::mpsc::Receiver<TenantShardId>,
281 0 : initial_leadership_status: LeadershipStatus,
282 0 : reconcilers_cancel: CancellationToken,
283 0 : ) -> Self {
284 0 : metrics::update_leadership_status(initial_leadership_status);
285 0 :
286 0 : Self {
287 0 : leadership_status: initial_leadership_status,
288 0 : tenants,
289 0 : nodes: Arc::new(nodes),
290 0 : safekeepers: Arc::new(safekeepers),
291 0 : safekeeper_reconcilers: SafekeeperReconcilers::new(reconcilers_cancel),
292 0 : scheduler,
293 0 : ongoing_operation: None,
294 0 : delayed_reconcile_rx,
295 0 : }
296 0 : }
297 :
298 0 : fn parts_mut(
299 0 : &mut self,
300 0 : ) -> (
301 0 : &mut Arc<HashMap<NodeId, Node>>,
302 0 : &mut BTreeMap<TenantShardId, TenantShard>,
303 0 : &mut Scheduler,
304 0 : ) {
305 0 : (&mut self.nodes, &mut self.tenants, &mut self.scheduler)
306 0 : }
307 :
308 : #[allow(clippy::type_complexity)]
309 0 : fn parts_mut_sk(
310 0 : &mut self,
311 0 : ) -> (
312 0 : &mut Arc<HashMap<NodeId, Node>>,
313 0 : &mut Arc<HashMap<NodeId, Safekeeper>>,
314 0 : &mut BTreeMap<TenantShardId, TenantShard>,
315 0 : &mut Scheduler,
316 0 : ) {
317 0 : (
318 0 : &mut self.nodes,
319 0 : &mut self.safekeepers,
320 0 : &mut self.tenants,
321 0 : &mut self.scheduler,
322 0 : )
323 0 : }
324 :
325 0 : fn get_leadership_status(&self) -> LeadershipStatus {
326 0 : self.leadership_status
327 0 : }
328 :
329 0 : fn step_down(&mut self) {
330 0 : self.leadership_status = LeadershipStatus::SteppedDown;
331 0 : metrics::update_leadership_status(self.leadership_status);
332 0 : }
333 :
334 0 : fn become_leader(&mut self) {
335 0 : self.leadership_status = LeadershipStatus::Leader;
336 0 : metrics::update_leadership_status(self.leadership_status);
337 0 : }
338 : }
339 :
340 : #[derive(Clone)]
341 : pub struct Config {
342 : // All pageservers managed by one instance of this service must have
343 : // the same public key. This JWT token will be used to authenticate
344 : // this service to the pageservers it manages.
345 : pub pageserver_jwt_token: Option<String>,
346 :
347 : // All safekeepers managed by one instance of this service must have
348 : // the same public key. This JWT token will be used to authenticate
349 : // this service to the safekeepers it manages.
350 : pub safekeeper_jwt_token: Option<String>,
351 :
352 : // This JWT token will be used to authenticate this service to the control plane.
353 : pub control_plane_jwt_token: Option<String>,
354 :
355 : // This JWT token will be used to authenticate with other storage controller instances
356 : pub peer_jwt_token: Option<String>,
357 :
358 : /// Where the compute hook should send notifications of pageserver attachment locations
359 : /// (this URL points to the control plane in prod). If this is None, the compute hook will
360 : /// assume it is running in a test environment and try to update neon_local.
361 : pub compute_hook_url: Option<String>,
362 :
363 : /// Prefix for storage API endpoints of the control plane. We use this prefix to compute
364 : /// URLs that we use to send pageserver and safekeeper attachment locations.
365 : /// If this is None, the compute hook will assume it is running in a test environment
366 : /// and try to invoke neon_local instead.
367 : ///
368 : /// For now, there is also `compute_hook_url` which allows configuration of the pageserver
369 : /// specific endpoint, but it is in the process of being phased out.
370 : pub control_plane_url: Option<String>,
371 :
372 : /// Grace period within which a pageserver does not respond to heartbeats, but is still
373 : /// considered active. Once the grace period elapses, the next heartbeat failure will
374 : /// mark the pagseserver offline.
375 : pub max_offline_interval: Duration,
376 :
377 : /// Extended grace period within which pageserver may not respond to heartbeats.
378 : /// This extended grace period kicks in after the node has been drained for restart
379 : /// and/or upon handling the re-attach request from a node.
380 : pub max_warming_up_interval: Duration,
381 :
382 : /// How many normal-priority Reconcilers may be spawned concurrently
383 : pub reconciler_concurrency: usize,
384 :
385 : /// How many high-priority Reconcilers may be spawned concurrently
386 : pub priority_reconciler_concurrency: usize,
387 :
388 : /// How many API requests per second to allow per tenant, across all
389 : /// tenant-scoped API endpoints. Further API requests queue until ready.
390 : pub tenant_rate_limit: NonZeroU32,
391 :
392 : /// The size at which an unsharded tenant should be split (into 8 shards). This uses the logical
393 : /// size of the largest timeline in the shard (i.e. max_logical_size).
394 : ///
395 : /// None or 0 disables auto-splitting.
396 : ///
397 : /// TODO: consider using total logical size of all timelines instead.
398 : pub split_threshold: Option<u64>,
399 :
400 : // TODO: make this cfg(feature = "testing")
401 : pub neon_local_repo_dir: Option<PathBuf>,
402 :
403 : // Maximum acceptable download lag for the secondary location
404 : // while draining a node. If the secondary location is lagging
405 : // by more than the configured amount, then the secondary is not
406 : // upgraded to primary.
407 : pub max_secondary_lag_bytes: Option<u64>,
408 :
409 : pub heartbeat_interval: Duration,
410 :
411 : pub address_for_peers: Option<Uri>,
412 :
413 : pub start_as_candidate: bool,
414 :
415 : pub http_service_port: i32,
416 :
417 : pub long_reconcile_threshold: Duration,
418 :
419 : pub use_https_pageserver_api: bool,
420 :
421 : pub use_https_safekeeper_api: bool,
422 :
423 : pub ssl_ca_cert: Option<Certificate>,
424 :
425 : pub timelines_onto_safekeepers: bool,
426 : }
427 :
428 : impl From<DatabaseError> for ApiError {
429 0 : fn from(err: DatabaseError) -> ApiError {
430 0 : match err {
431 0 : DatabaseError::Query(e) => ApiError::InternalServerError(e.into()),
432 : // FIXME: ApiError doesn't have an Unavailable variant, but ShuttingDown maps to 503.
433 : DatabaseError::Connection(_) | DatabaseError::ConnectionPool(_) => {
434 0 : ApiError::ShuttingDown
435 : }
436 0 : DatabaseError::Logical(reason) | DatabaseError::Migration(reason) => {
437 0 : ApiError::InternalServerError(anyhow::anyhow!(reason))
438 : }
439 : }
440 0 : }
441 : }
442 :
443 : enum InitialShardScheduleOutcome {
444 : Scheduled(TenantCreateResponseShard),
445 : NotScheduled,
446 : ShardScheduleError(ScheduleError),
447 : }
448 :
449 : pub struct Service {
450 : inner: Arc<std::sync::RwLock<ServiceState>>,
451 : config: Config,
452 : persistence: Arc<Persistence>,
453 : compute_hook: Arc<ComputeHook>,
454 : result_tx: tokio::sync::mpsc::UnboundedSender<ReconcileResultRequest>,
455 :
456 : heartbeater_ps: Heartbeater<Node, PageserverState>,
457 : heartbeater_sk: Heartbeater<Safekeeper, SafekeeperState>,
458 :
459 : // Channel for background cleanup from failed operations that require cleanup, such as shard split
460 : abort_tx: tokio::sync::mpsc::UnboundedSender<TenantShardSplitAbort>,
461 :
462 : // Locking on a tenant granularity (covers all shards in the tenant):
463 : // - Take exclusively for rare operations that mutate the tenant's persistent state (e.g. create/delete/split)
464 : // - Take in shared mode for operations that need the set of shards to stay the same to complete reliably (e.g. timeline CRUD)
465 : tenant_op_locks: IdLockMap<TenantId, TenantOperations>,
466 :
467 : // Locking for node-mutating operations: take exclusively for operations that modify the node's persistent state, or
468 : // that transition it to/from Active.
469 : node_op_locks: IdLockMap<NodeId, NodeOperations>,
470 :
471 : // Limit how many Reconcilers we will spawn concurrently for normal-priority tasks such as background reconciliations
472 : // and reconciliation on startup.
473 : reconciler_concurrency: Arc<tokio::sync::Semaphore>,
474 :
475 : // Limit how many Reconcilers we will spawn concurrently for high-priority tasks such as tenant/timeline CRUD, which
476 : // a human user might be waiting for.
477 : priority_reconciler_concurrency: Arc<tokio::sync::Semaphore>,
478 :
479 : /// Queue of tenants who are waiting for concurrency limits to permit them to reconcile
480 : /// Send into this queue to promptly attempt to reconcile this shard next time units are available.
481 : ///
482 : /// Note that this state logically lives inside ServiceState, but carrying Sender here makes the code simpler
483 : /// by avoiding needing a &mut ref to something inside the ServiceState. This could be optimized to
484 : /// use a VecDeque instead of a channel to reduce synchronization overhead, at the cost of some code complexity.
485 : delayed_reconcile_tx: tokio::sync::mpsc::Sender<TenantShardId>,
486 :
487 : // Process shutdown will fire this token
488 : cancel: CancellationToken,
489 :
490 : // Child token of [`Service::cancel`] used by reconcilers
491 : reconcilers_cancel: CancellationToken,
492 :
493 : // Background tasks will hold this gate
494 : gate: Gate,
495 :
496 : // Reconcilers background tasks will hold this gate
497 : reconcilers_gate: Gate,
498 :
499 : /// This waits for initial reconciliation with pageservers to complete. Until this barrier
500 : /// passes, it isn't safe to do any actions that mutate tenants.
501 : pub(crate) startup_complete: Barrier,
502 : }
503 :
504 : impl From<ReconcileWaitError> for ApiError {
505 0 : fn from(value: ReconcileWaitError) -> Self {
506 0 : match value {
507 0 : ReconcileWaitError::Shutdown => ApiError::ShuttingDown,
508 0 : e @ ReconcileWaitError::Timeout(_) => ApiError::Timeout(format!("{e}").into()),
509 0 : e @ ReconcileWaitError::Failed(..) => ApiError::InternalServerError(anyhow::anyhow!(e)),
510 : }
511 0 : }
512 : }
513 :
514 : impl From<OperationError> for ApiError {
515 0 : fn from(value: OperationError) -> Self {
516 0 : match value {
517 0 : OperationError::NodeStateChanged(err) | OperationError::FinalizeError(err) => {
518 0 : ApiError::InternalServerError(anyhow::anyhow!(err))
519 : }
520 0 : OperationError::Cancelled => ApiError::Conflict("Operation was cancelled".into()),
521 : }
522 0 : }
523 : }
524 :
525 : #[allow(clippy::large_enum_variant)]
526 : enum TenantCreateOrUpdate {
527 : Create(TenantCreateRequest),
528 : Update(Vec<ShardUpdate>),
529 : }
530 :
531 : struct ShardSplitParams {
532 : old_shard_count: ShardCount,
533 : new_shard_count: ShardCount,
534 : new_stripe_size: Option<ShardStripeSize>,
535 : targets: Vec<ShardSplitTarget>,
536 : policy: PlacementPolicy,
537 : config: TenantConfig,
538 : shard_ident: ShardIdentity,
539 : preferred_az_id: Option<AvailabilityZone>,
540 : }
541 :
542 : // When preparing for a shard split, we may either choose to proceed with the split,
543 : // or find that the work is already done and return NoOp.
544 : enum ShardSplitAction {
545 : Split(Box<ShardSplitParams>),
546 : NoOp(TenantShardSplitResponse),
547 : }
548 :
549 : // A parent shard which will be split
550 : struct ShardSplitTarget {
551 : parent_id: TenantShardId,
552 : node: Node,
553 : child_ids: Vec<TenantShardId>,
554 : }
555 :
556 : /// When we tenant shard split operation fails, we may not be able to clean up immediately, because nodes
557 : /// might not be available. We therefore use a queue of abort operations processed in the background.
558 : struct TenantShardSplitAbort {
559 : tenant_id: TenantId,
560 : /// The target values from the request that failed
561 : new_shard_count: ShardCount,
562 : new_stripe_size: Option<ShardStripeSize>,
563 : /// Until this abort op is complete, no other operations may be done on the tenant
564 : _tenant_lock: TracingExclusiveGuard<TenantOperations>,
565 : }
566 :
567 : #[derive(thiserror::Error, Debug)]
568 : enum TenantShardSplitAbortError {
569 : #[error(transparent)]
570 : Database(#[from] DatabaseError),
571 : #[error(transparent)]
572 : Remote(#[from] mgmt_api::Error),
573 : #[error("Unavailable")]
574 : Unavailable,
575 : }
576 :
577 : struct ShardUpdate {
578 : tenant_shard_id: TenantShardId,
579 : placement_policy: PlacementPolicy,
580 : tenant_config: TenantConfig,
581 :
582 : /// If this is None, generation is not updated.
583 : generation: Option<Generation>,
584 :
585 : /// If this is None, scheduling policy is not updated.
586 : scheduling_policy: Option<ShardSchedulingPolicy>,
587 : }
588 :
589 : enum StopReconciliationsReason {
590 : ShuttingDown,
591 : SteppingDown,
592 : }
593 :
594 : impl std::fmt::Display for StopReconciliationsReason {
595 0 : fn fmt(&self, writer: &mut std::fmt::Formatter) -> std::fmt::Result {
596 0 : let s = match self {
597 0 : Self::ShuttingDown => "Shutting down",
598 0 : Self::SteppingDown => "Stepping down",
599 : };
600 0 : write!(writer, "{}", s)
601 0 : }
602 : }
603 :
604 : pub(crate) enum ReconcileResultRequest {
605 : ReconcileResult(ReconcileResult),
606 : Stop,
607 : }
608 :
609 : #[derive(Clone)]
610 : struct MutationLocation {
611 : node: Node,
612 : generation: Generation,
613 : }
614 :
615 : #[derive(Clone)]
616 : struct ShardMutationLocations {
617 : latest: MutationLocation,
618 : other: Vec<MutationLocation>,
619 : }
620 :
621 : #[derive(Default, Clone)]
622 : struct TenantMutationLocations(BTreeMap<TenantShardId, ShardMutationLocations>);
623 :
624 : impl Service {
625 0 : pub fn get_config(&self) -> &Config {
626 0 : &self.config
627 0 : }
628 :
629 : /// Called once on startup, this function attempts to contact all pageservers to build an up-to-date
630 : /// view of the world, and determine which pageservers are responsive.
631 : #[instrument(skip_all)]
632 : async fn startup_reconcile(
633 : self: &Arc<Service>,
634 : current_leader: Option<ControllerPersistence>,
635 : leader_step_down_state: Option<GlobalObservedState>,
636 : bg_compute_notify_result_tx: tokio::sync::mpsc::Sender<
637 : Result<(), (TenantShardId, NotifyError)>,
638 : >,
639 : ) {
640 : // Startup reconciliation does I/O to other services: whether they
641 : // are responsive or not, we should aim to finish within our deadline, because:
642 : // - If we don't, a k8s readiness hook watching /ready will kill us.
643 : // - While we're waiting for startup reconciliation, we are not fully
644 : // available for end user operations like creating/deleting tenants and timelines.
645 : //
646 : // We set multiple deadlines to break up the time available between the phases of work: this is
647 : // arbitrary, but avoids a situation where the first phase could burn our entire timeout period.
648 : let start_at = Instant::now();
649 : let node_scan_deadline = start_at
650 : .checked_add(STARTUP_RECONCILE_TIMEOUT / 2)
651 : .expect("Reconcile timeout is a modest constant");
652 :
653 : let observed = if let Some(state) = leader_step_down_state {
654 : tracing::info!(
655 : "Using observed state received from leader at {}",
656 : current_leader.as_ref().unwrap().address
657 : );
658 :
659 : state
660 : } else {
661 : self.build_global_observed_state(node_scan_deadline).await
662 : };
663 :
664 : // Accumulate a list of any tenant locations that ought to be detached
665 : let mut cleanup = Vec::new();
666 :
667 : // Send initial heartbeat requests to all nodes loaded from the database
668 : let all_nodes = {
669 : let locked = self.inner.read().unwrap();
670 : locked.nodes.clone()
671 : };
672 : let (mut nodes_online, mut sks_online) =
673 : self.initial_heartbeat_round(all_nodes.keys()).await;
674 :
675 : // List of tenants for which we will attempt to notify compute of their location at startup
676 : let mut compute_notifications = Vec::new();
677 :
678 : // Populate intent and observed states for all tenants, based on reported state on pageservers
679 : tracing::info!("Populating tenant shards' states from initial pageserver scan...");
680 : let shard_count = {
681 : let mut locked = self.inner.write().unwrap();
682 : let (nodes, safekeepers, tenants, scheduler) = locked.parts_mut_sk();
683 :
684 : // Mark nodes online if they responded to us: nodes are offline by default after a restart.
685 : let mut new_nodes = (**nodes).clone();
686 : for (node_id, node) in new_nodes.iter_mut() {
687 : if let Some(utilization) = nodes_online.remove(node_id) {
688 : node.set_availability(NodeAvailability::Active(utilization));
689 : scheduler.node_upsert(node);
690 : }
691 : }
692 : *nodes = Arc::new(new_nodes);
693 :
694 : let mut new_sks = (**safekeepers).clone();
695 : for (node_id, node) in new_sks.iter_mut() {
696 : if let Some((utilization, last_seen_at)) = sks_online.remove(node_id) {
697 : node.set_availability(SafekeeperState::Available {
698 : utilization,
699 : last_seen_at,
700 : });
701 : }
702 : }
703 : *safekeepers = Arc::new(new_sks);
704 :
705 : for (tenant_shard_id, observed_state) in observed.0 {
706 : let Some(tenant_shard) = tenants.get_mut(&tenant_shard_id) else {
707 : for node_id in observed_state.locations.keys() {
708 : cleanup.push((tenant_shard_id, *node_id));
709 : }
710 :
711 : continue;
712 : };
713 :
714 : tenant_shard.observed = observed_state;
715 : }
716 :
717 : // Populate each tenant's intent state
718 : let mut schedule_context = ScheduleContext::default();
719 : for (tenant_shard_id, tenant_shard) in tenants.iter_mut() {
720 : if tenant_shard_id.shard_number == ShardNumber(0) {
721 : // Reset scheduling context each time we advance to the next Tenant
722 : schedule_context = ScheduleContext::default();
723 : }
724 :
725 : tenant_shard.intent_from_observed(scheduler);
726 : if let Err(e) = tenant_shard.schedule(scheduler, &mut schedule_context) {
727 : // Non-fatal error: we are unable to properly schedule the tenant, perhaps because
728 : // not enough pageservers are available. The tenant may well still be available
729 : // to clients.
730 : tracing::error!("Failed to schedule tenant {tenant_shard_id} at startup: {e}");
731 : } else {
732 : // If we're both intending and observed to be attached at a particular node, we will
733 : // emit a compute notification for this. In the case where our observed state does not
734 : // yet match our intent, we will eventually reconcile, and that will emit a compute notification.
735 : if let Some(attached_at) = tenant_shard.stably_attached() {
736 : compute_notifications.push(compute_hook::ShardUpdate {
737 : tenant_shard_id: *tenant_shard_id,
738 : node_id: attached_at,
739 : stripe_size: tenant_shard.shard.stripe_size,
740 : preferred_az: tenant_shard
741 : .preferred_az()
742 0 : .map(|az| Cow::Owned(az.clone())),
743 : });
744 : }
745 : }
746 : }
747 :
748 : tenants.len()
749 : };
750 :
751 : // Before making any obeservable changes to the cluster, persist self
752 : // as leader in database and memory.
753 : let leadership = Leadership::new(
754 : self.persistence.clone(),
755 : self.config.clone(),
756 : self.cancel.child_token(),
757 : );
758 :
759 : if let Err(e) = leadership.become_leader(current_leader).await {
760 : tracing::error!("Failed to persist self as leader: {e}. Aborting start-up ...");
761 : std::process::exit(1);
762 : }
763 :
764 : let safekeepers = self.inner.read().unwrap().safekeepers.clone();
765 : let sk_schedule_requests =
766 : match safekeeper_reconciler::load_schedule_requests(self, &safekeepers).await {
767 : Ok(v) => v,
768 : Err(e) => {
769 : tracing::warn!(
770 : "Failed to load safekeeper pending ops at startup: {e}." // Don't abort for now: " Aborting start-up..."
771 : );
772 : // std::process::exit(1);
773 : Vec::new()
774 : }
775 : };
776 :
777 : {
778 : let mut locked = self.inner.write().unwrap();
779 : locked.become_leader();
780 :
781 : locked
782 : .safekeeper_reconcilers
783 : .schedule_request_vec(self, sk_schedule_requests);
784 : }
785 :
786 : // TODO: if any tenant's intent now differs from its loaded generation_pageserver, we should clear that
787 : // generation_pageserver in the database.
788 :
789 : // Emit compute hook notifications for all tenants which are already stably attached. Other tenants
790 : // will emit compute hook notifications when they reconcile.
791 : //
792 : // Ordering: our calls to notify_background synchronously establish a relative order for these notifications vs. any later
793 : // calls into the ComputeHook for the same tenant: we can leave these to run to completion in the background and any later
794 : // calls will be correctly ordered wrt these.
795 : //
796 : // Concurrency: we call notify_background for all tenants, which will create O(N) tokio tasks, but almost all of them
797 : // will just wait on the ComputeHook::API_CONCURRENCY semaphore immediately, so very cheap until they get that semaphore
798 : // unit and start doing I/O.
799 : tracing::info!(
800 : "Sending {} compute notifications",
801 : compute_notifications.len()
802 : );
803 : self.compute_hook.notify_background(
804 : compute_notifications,
805 : bg_compute_notify_result_tx.clone(),
806 : &self.cancel,
807 : );
808 :
809 : // Finally, now that the service is up and running, launch reconcile operations for any tenants
810 : // which require it: under normal circumstances this should only include tenants that were in some
811 : // transient state before we restarted, or any tenants whose compute hooks failed above.
812 : tracing::info!("Checking for shards in need of reconciliation...");
813 : let reconcile_tasks = self.reconcile_all();
814 : // We will not wait for these reconciliation tasks to run here: we're now done with startup and
815 : // normal operations may proceed.
816 :
817 : // Clean up any tenants that were found on pageservers but are not known to us. Do this in the
818 : // background because it does not need to complete in order to proceed with other work.
819 : if !cleanup.is_empty() {
820 : tracing::info!("Cleaning up {} locations in the background", cleanup.len());
821 : tokio::task::spawn({
822 : let cleanup_self = self.clone();
823 0 : async move { cleanup_self.cleanup_locations(cleanup).await }
824 : });
825 : }
826 :
827 : tracing::info!(
828 : "Startup complete, spawned {reconcile_tasks} reconciliation tasks ({shard_count} shards total)"
829 : );
830 : }
831 :
832 0 : async fn initial_heartbeat_round<'a>(
833 0 : &self,
834 0 : node_ids: impl Iterator<Item = &'a NodeId>,
835 0 : ) -> (
836 0 : HashMap<NodeId, PageserverUtilization>,
837 0 : HashMap<NodeId, (SafekeeperUtilization, Instant)>,
838 0 : ) {
839 0 : assert!(!self.startup_complete.is_ready());
840 :
841 0 : let all_nodes = {
842 0 : let locked = self.inner.read().unwrap();
843 0 : locked.nodes.clone()
844 0 : };
845 0 :
846 0 : let mut nodes_to_heartbeat = HashMap::new();
847 0 : for node_id in node_ids {
848 0 : match all_nodes.get(node_id) {
849 0 : Some(node) => {
850 0 : nodes_to_heartbeat.insert(*node_id, node.clone());
851 0 : }
852 : None => {
853 0 : tracing::warn!("Node {node_id} was removed during start-up");
854 : }
855 : }
856 : }
857 :
858 0 : let all_sks = {
859 0 : let locked = self.inner.read().unwrap();
860 0 : locked.safekeepers.clone()
861 0 : };
862 0 :
863 0 : tracing::info!("Sending initial heartbeats...");
864 0 : let (res_ps, res_sk) = tokio::join!(
865 0 : self.heartbeater_ps.heartbeat(Arc::new(nodes_to_heartbeat)),
866 0 : self.heartbeater_sk.heartbeat(all_sks)
867 0 : );
868 :
869 0 : let mut online_nodes = HashMap::new();
870 0 : if let Ok(deltas) = res_ps {
871 0 : for (node_id, status) in deltas.0 {
872 0 : match status {
873 0 : PageserverState::Available { utilization, .. } => {
874 0 : online_nodes.insert(node_id, utilization);
875 0 : }
876 0 : PageserverState::Offline => {}
877 : PageserverState::WarmingUp { .. } => {
878 0 : unreachable!("Nodes are never marked warming-up during startup reconcile")
879 : }
880 : }
881 : }
882 0 : }
883 :
884 0 : let mut online_sks = HashMap::new();
885 0 : if let Ok(deltas) = res_sk {
886 0 : for (node_id, status) in deltas.0 {
887 0 : match status {
888 : SafekeeperState::Available {
889 0 : utilization,
890 0 : last_seen_at,
891 0 : } => {
892 0 : online_sks.insert(node_id, (utilization, last_seen_at));
893 0 : }
894 0 : SafekeeperState::Offline => {}
895 : }
896 : }
897 0 : }
898 :
899 0 : (online_nodes, online_sks)
900 0 : }
901 :
902 : /// Used during [`Self::startup_reconcile`]: issue GETs to all nodes concurrently, with a deadline.
903 : ///
904 : /// The result includes only nodes which responded within the deadline
905 0 : async fn scan_node_locations(
906 0 : &self,
907 0 : deadline: Instant,
908 0 : ) -> HashMap<NodeId, LocationConfigListResponse> {
909 0 : let nodes = {
910 0 : let locked = self.inner.read().unwrap();
911 0 : locked.nodes.clone()
912 0 : };
913 0 :
914 0 : let mut node_results = HashMap::new();
915 0 :
916 0 : let mut node_list_futs = FuturesUnordered::new();
917 0 :
918 0 : tracing::info!("Scanning shards on {} nodes...", nodes.len());
919 0 : for node in nodes.values() {
920 0 : node_list_futs.push({
921 0 : async move {
922 0 : tracing::info!("Scanning shards on node {node}...");
923 0 : let timeout = Duration::from_secs(5);
924 0 : let response = node
925 0 : .with_client_retries(
926 0 : |client| async move { client.list_location_config().await },
927 0 : &self.config.pageserver_jwt_token,
928 0 : &self.config.ssl_ca_cert,
929 0 : 1,
930 0 : 5,
931 0 : timeout,
932 0 : &self.cancel,
933 0 : )
934 0 : .await;
935 0 : (node.get_id(), response)
936 0 : }
937 0 : });
938 0 : }
939 :
940 : loop {
941 0 : let (node_id, result) = tokio::select! {
942 0 : next = node_list_futs.next() => {
943 0 : match next {
944 0 : Some(result) => result,
945 : None =>{
946 : // We got results for all our nodes
947 0 : break;
948 : }
949 :
950 : }
951 : },
952 0 : _ = tokio::time::sleep(deadline.duration_since(Instant::now())) => {
953 : // Give up waiting for anyone who hasn't responded: we will yield the results that we have
954 0 : tracing::info!("Reached deadline while waiting for nodes to respond to location listing requests");
955 0 : break;
956 : }
957 : };
958 :
959 0 : let Some(list_response) = result else {
960 0 : tracing::info!("Shutdown during startup_reconcile");
961 0 : break;
962 : };
963 :
964 0 : match list_response {
965 0 : Err(e) => {
966 0 : tracing::warn!("Could not scan node {} ({e})", node_id);
967 : }
968 0 : Ok(listing) => {
969 0 : node_results.insert(node_id, listing);
970 0 : }
971 : }
972 : }
973 :
974 0 : node_results
975 0 : }
976 :
977 0 : async fn build_global_observed_state(&self, deadline: Instant) -> GlobalObservedState {
978 0 : let node_listings = self.scan_node_locations(deadline).await;
979 0 : let mut observed = GlobalObservedState::default();
980 :
981 0 : for (node_id, location_confs) in node_listings {
982 0 : tracing::info!(
983 0 : "Received {} shard statuses from pageserver {}",
984 0 : location_confs.tenant_shards.len(),
985 : node_id
986 : );
987 :
988 0 : for (tid, location_conf) in location_confs.tenant_shards {
989 0 : let entry = observed.0.entry(tid).or_default();
990 0 : entry.locations.insert(
991 0 : node_id,
992 0 : ObservedStateLocation {
993 0 : conf: location_conf,
994 0 : },
995 0 : );
996 0 : }
997 : }
998 :
999 0 : observed
1000 0 : }
1001 :
1002 : /// Used during [`Self::startup_reconcile`]: detach a list of unknown-to-us tenants from pageservers.
1003 : ///
1004 : /// This is safe to run in the background, because if we don't have this TenantShardId in our map of
1005 : /// tenants, then it is probably something incompletely deleted before: we will not fight with any
1006 : /// other task trying to attach it.
1007 : #[instrument(skip_all)]
1008 : async fn cleanup_locations(&self, cleanup: Vec<(TenantShardId, NodeId)>) {
1009 : let nodes = self.inner.read().unwrap().nodes.clone();
1010 :
1011 : for (tenant_shard_id, node_id) in cleanup {
1012 : // A node reported a tenant_shard_id which is unknown to us: detach it.
1013 : let Some(node) = nodes.get(&node_id) else {
1014 : // This is legitimate; we run in the background and [`Self::startup_reconcile`] might have identified
1015 : // a location to clean up on a node that has since been removed.
1016 : tracing::info!(
1017 : "Not cleaning up location {node_id}/{tenant_shard_id}: node not found"
1018 : );
1019 : continue;
1020 : };
1021 :
1022 : if self.cancel.is_cancelled() {
1023 : break;
1024 : }
1025 :
1026 : let client = match PageserverClient::new(
1027 : node.get_id(),
1028 : node.base_url(),
1029 : self.config.pageserver_jwt_token.as_deref(),
1030 : self.config.ssl_ca_cert.clone(),
1031 : ) {
1032 : Ok(client) => client,
1033 : Err(e) => {
1034 : tracing::error!(
1035 : "Failed to create client to detach unknown shard {tenant_shard_id} on pageserver {node_id}: {e}"
1036 : );
1037 : continue;
1038 : }
1039 : };
1040 : match client
1041 : .location_config(
1042 : tenant_shard_id,
1043 : LocationConfig {
1044 : mode: LocationConfigMode::Detached,
1045 : generation: None,
1046 : secondary_conf: None,
1047 : shard_number: tenant_shard_id.shard_number.0,
1048 : shard_count: tenant_shard_id.shard_count.literal(),
1049 : shard_stripe_size: 0,
1050 : tenant_conf: models::TenantConfig::default(),
1051 : },
1052 : None,
1053 : false,
1054 : )
1055 : .await
1056 : {
1057 : Ok(()) => {
1058 : tracing::info!(
1059 : "Detached unknown shard {tenant_shard_id} on pageserver {node_id}"
1060 : );
1061 : }
1062 : Err(e) => {
1063 : // Non-fatal error: leaving a tenant shard behind that we are not managing shouldn't
1064 : // break anything.
1065 : tracing::error!(
1066 : "Failed to detach unknown shard {tenant_shard_id} on pageserver {node_id}: {e}"
1067 : );
1068 : }
1069 : }
1070 : }
1071 : }
1072 :
1073 : /// Long running background task that periodically wakes up and looks for shards that need
1074 : /// reconciliation. Reconciliation is fallible, so any reconciliation tasks that fail during
1075 : /// e.g. a tenant create/attach/migrate must eventually be retried: this task is responsible
1076 : /// for those retries.
1077 : #[instrument(skip_all)]
1078 : async fn background_reconcile(self: &Arc<Self>) {
1079 : self.startup_complete.clone().wait().await;
1080 :
1081 : const BACKGROUND_RECONCILE_PERIOD: Duration = Duration::from_secs(20);
1082 : let mut interval = tokio::time::interval(BACKGROUND_RECONCILE_PERIOD);
1083 : while !self.reconcilers_cancel.is_cancelled() {
1084 : tokio::select! {
1085 : _ = interval.tick() => {
1086 : let reconciles_spawned = self.reconcile_all();
1087 : if reconciles_spawned == 0 {
1088 : // Run optimizer only when we didn't find any other work to do
1089 : self.optimize_all().await;
1090 : }
1091 : // Always attempt autosplits. Sharding is crucial for bulk ingest performance, so we
1092 : // must be responsive when new projects begin ingesting and reach the threshold.
1093 : self.autosplit_tenants().await;
1094 : }
1095 : _ = self.reconcilers_cancel.cancelled() => return
1096 : }
1097 : }
1098 : }
1099 : /// Heartbeat all storage nodes once in a while.
1100 : #[instrument(skip_all)]
1101 : async fn spawn_heartbeat_driver(&self) {
1102 : self.startup_complete.clone().wait().await;
1103 :
1104 : let mut interval = tokio::time::interval(self.config.heartbeat_interval);
1105 : while !self.cancel.is_cancelled() {
1106 : tokio::select! {
1107 : _ = interval.tick() => { }
1108 : _ = self.cancel.cancelled() => return
1109 : };
1110 :
1111 : let nodes = {
1112 : let locked = self.inner.read().unwrap();
1113 : locked.nodes.clone()
1114 : };
1115 :
1116 : let safekeepers = {
1117 : let locked = self.inner.read().unwrap();
1118 : locked.safekeepers.clone()
1119 : };
1120 :
1121 : let (res_ps, res_sk) = tokio::join!(
1122 : self.heartbeater_ps.heartbeat(nodes),
1123 : self.heartbeater_sk.heartbeat(safekeepers)
1124 : );
1125 :
1126 : if let Ok(deltas) = res_ps {
1127 : let mut to_handle = Vec::default();
1128 :
1129 : for (node_id, state) in deltas.0 {
1130 : let new_availability = match state {
1131 : PageserverState::Available { utilization, .. } => {
1132 : NodeAvailability::Active(utilization)
1133 : }
1134 : PageserverState::WarmingUp { started_at } => {
1135 : NodeAvailability::WarmingUp(started_at)
1136 : }
1137 : PageserverState::Offline => {
1138 : // The node might have been placed in the WarmingUp state
1139 : // while the heartbeat round was on-going. Hence, filter out
1140 : // offline transitions for WarmingUp nodes that are still within
1141 : // their grace period.
1142 : if let Ok(NodeAvailability::WarmingUp(started_at)) = self
1143 : .get_node(node_id)
1144 : .await
1145 : .as_ref()
1146 0 : .map(|n| n.get_availability())
1147 : {
1148 : let now = Instant::now();
1149 : if now - *started_at >= self.config.max_warming_up_interval {
1150 : NodeAvailability::Offline
1151 : } else {
1152 : NodeAvailability::WarmingUp(*started_at)
1153 : }
1154 : } else {
1155 : NodeAvailability::Offline
1156 : }
1157 : }
1158 : };
1159 :
1160 : let node_lock = trace_exclusive_lock(
1161 : &self.node_op_locks,
1162 : node_id,
1163 : NodeOperations::Configure,
1164 : )
1165 : .await;
1166 :
1167 : pausable_failpoint!("heartbeat-pre-node-state-configure");
1168 :
1169 : // This is the code path for geniune availability transitions (i.e node
1170 : // goes unavailable and/or comes back online).
1171 : let res = self
1172 : .node_state_configure(node_id, Some(new_availability), None, &node_lock)
1173 : .await;
1174 :
1175 : match res {
1176 : Ok(transition) => {
1177 : // Keep hold of the lock until the availability transitions
1178 : // have been handled in
1179 : // [`Service::handle_node_availability_transitions`] in order avoid
1180 : // racing with [`Service::external_node_configure`].
1181 : to_handle.push((node_id, node_lock, transition));
1182 : }
1183 : Err(ApiError::NotFound(_)) => {
1184 : // This should be rare, but legitimate since the heartbeats are done
1185 : // on a snapshot of the nodes.
1186 : tracing::info!("Node {} was not found after heartbeat round", node_id);
1187 : }
1188 : Err(ApiError::ShuttingDown) => {
1189 : // No-op: we're shutting down, no need to try and update any nodes' statuses
1190 : }
1191 : Err(err) => {
1192 : // Transition to active involves reconciling: if a node responds to a heartbeat then
1193 : // becomes unavailable again, we may get an error here.
1194 : tracing::error!(
1195 : "Failed to update node state {} after heartbeat round: {}",
1196 : node_id,
1197 : err
1198 : );
1199 : }
1200 : }
1201 : }
1202 :
1203 : // We collected all the transitions above and now we handle them.
1204 : let res = self.handle_node_availability_transitions(to_handle).await;
1205 : if let Err(errs) = res {
1206 : for (node_id, err) in errs {
1207 : match err {
1208 : ApiError::NotFound(_) => {
1209 : // This should be rare, but legitimate since the heartbeats are done
1210 : // on a snapshot of the nodes.
1211 : tracing::info!(
1212 : "Node {} was not found after heartbeat round",
1213 : node_id
1214 : );
1215 : }
1216 : err => {
1217 : tracing::error!(
1218 : "Failed to handle availability transition for {} after heartbeat round: {}",
1219 : node_id,
1220 : err
1221 : );
1222 : }
1223 : }
1224 : }
1225 : }
1226 : }
1227 : if let Ok(deltas) = res_sk {
1228 : let mut locked = self.inner.write().unwrap();
1229 : let mut safekeepers = (*locked.safekeepers).clone();
1230 : for (id, state) in deltas.0 {
1231 : let Some(sk) = safekeepers.get_mut(&id) else {
1232 : tracing::info!(
1233 : "Couldn't update safekeeper safekeeper state for id {id} from heartbeat={state:?}"
1234 : );
1235 : continue;
1236 : };
1237 : sk.set_availability(state);
1238 : }
1239 : locked.safekeepers = Arc::new(safekeepers);
1240 : }
1241 : }
1242 : }
1243 :
1244 : /// Apply the contents of a [`ReconcileResult`] to our in-memory state: if the reconciliation
1245 : /// was successful and intent hasn't changed since the Reconciler was spawned, this will update
1246 : /// the observed state of the tenant such that subsequent calls to [`TenantShard::get_reconcile_needed`]
1247 : /// will indicate that reconciliation is not needed.
1248 : #[instrument(skip_all, fields(
1249 : seq=%result.sequence,
1250 : tenant_id=%result.tenant_shard_id.tenant_id,
1251 : shard_id=%result.tenant_shard_id.shard_slug(),
1252 : ))]
1253 : fn process_result(&self, result: ReconcileResult) {
1254 : let mut locked = self.inner.write().unwrap();
1255 : let (nodes, tenants, _scheduler) = locked.parts_mut();
1256 : let Some(tenant) = tenants.get_mut(&result.tenant_shard_id) else {
1257 : // A reconciliation result might race with removing a tenant: drop results for
1258 : // tenants that aren't in our map.
1259 : return;
1260 : };
1261 :
1262 : // Usually generation should only be updated via this path, so the max() isn't
1263 : // needed, but it is used to handle out-of-band updates via. e.g. test hook.
1264 : tenant.generation = std::cmp::max(tenant.generation, result.generation);
1265 :
1266 : // If the reconciler signals that it failed to notify compute, set this state on
1267 : // the shard so that a future [`TenantShard::maybe_reconcile`] will try again.
1268 : tenant.pending_compute_notification = result.pending_compute_notification;
1269 :
1270 : // Let the TenantShard know it is idle.
1271 : tenant.reconcile_complete(result.sequence);
1272 :
1273 : // In case a node was deleted while this reconcile is in flight, filter it out of the update we will
1274 : // make to the tenant
1275 0 : let deltas = result.observed_deltas.into_iter().flat_map(|delta| {
1276 : // In case a node was deleted while this reconcile is in flight, filter it out of the update we will
1277 : // make to the tenant
1278 0 : let node = nodes.get(delta.node_id())?;
1279 :
1280 0 : if node.is_available() {
1281 0 : return Some(delta);
1282 0 : }
1283 0 :
1284 0 : // In case a node became unavailable concurrently with the reconcile, observed
1285 0 : // locations on it are now uncertain. By convention, set them to None in order
1286 0 : // for them to get refreshed when the node comes back online.
1287 0 : Some(ObservedStateDelta::Upsert(Box::new((
1288 0 : node.get_id(),
1289 0 : ObservedStateLocation { conf: None },
1290 0 : ))))
1291 0 : });
1292 :
1293 : match result.result {
1294 : Ok(()) => {
1295 : tenant.apply_observed_deltas(deltas);
1296 : tenant.waiter.advance(result.sequence);
1297 : }
1298 : Err(e) => {
1299 : match e {
1300 : ReconcileError::Cancel => {
1301 : tracing::info!("Reconciler was cancelled");
1302 : }
1303 : ReconcileError::Remote(mgmt_api::Error::Cancelled) => {
1304 : // This might be due to the reconciler getting cancelled, or it might
1305 : // be due to the `Node` being marked offline.
1306 : tracing::info!("Reconciler cancelled during pageserver API call");
1307 : }
1308 : _ => {
1309 : tracing::warn!("Reconcile error: {}", e);
1310 : }
1311 : }
1312 :
1313 : // Ordering: populate last_error before advancing error_seq,
1314 : // so that waiters will see the correct error after waiting.
1315 : tenant.set_last_error(result.sequence, e);
1316 :
1317 : // Skip deletions on reconcile failures
1318 : let upsert_deltas =
1319 0 : deltas.filter(|delta| matches!(delta, ObservedStateDelta::Upsert(_)));
1320 : tenant.apply_observed_deltas(upsert_deltas);
1321 : }
1322 : }
1323 :
1324 : // If we just finished detaching all shards for a tenant, it might be time to drop it from memory.
1325 : if tenant.policy == PlacementPolicy::Detached {
1326 : // We may only drop a tenant from memory while holding the exclusive lock on the tenant ID: this protects us
1327 : // from concurrent execution wrt a request handler that might expect the tenant to remain in memory for the
1328 : // duration of the request.
1329 : let guard = self.tenant_op_locks.try_exclusive(
1330 : tenant.tenant_shard_id.tenant_id,
1331 : TenantOperations::DropDetached,
1332 : );
1333 : if let Some(guard) = guard {
1334 : self.maybe_drop_tenant(tenant.tenant_shard_id.tenant_id, &mut locked, &guard);
1335 : }
1336 : }
1337 :
1338 : // Maybe some other work can proceed now that this job finished.
1339 : //
1340 : // Only bother with this if we have some semaphore units available in the normal-priority semaphore (these
1341 : // reconciles are scheduled at `[ReconcilerPriority::Normal]`).
1342 : if self.reconciler_concurrency.available_permits() > 0 {
1343 : while let Ok(tenant_shard_id) = locked.delayed_reconcile_rx.try_recv() {
1344 : let (nodes, tenants, _scheduler) = locked.parts_mut();
1345 : if let Some(shard) = tenants.get_mut(&tenant_shard_id) {
1346 : shard.delayed_reconcile = false;
1347 : self.maybe_reconcile_shard(shard, nodes, ReconcilerPriority::Normal);
1348 : }
1349 :
1350 : if self.reconciler_concurrency.available_permits() == 0 {
1351 : break;
1352 : }
1353 : }
1354 : }
1355 : }
1356 :
1357 0 : async fn process_results(
1358 0 : &self,
1359 0 : mut result_rx: tokio::sync::mpsc::UnboundedReceiver<ReconcileResultRequest>,
1360 0 : mut bg_compute_hook_result_rx: tokio::sync::mpsc::Receiver<
1361 0 : Result<(), (TenantShardId, NotifyError)>,
1362 0 : >,
1363 0 : ) {
1364 : loop {
1365 : // Wait for the next result, or for cancellation
1366 0 : tokio::select! {
1367 0 : r = result_rx.recv() => {
1368 0 : match r {
1369 0 : Some(ReconcileResultRequest::ReconcileResult(result)) => {self.process_result(result);},
1370 0 : None | Some(ReconcileResultRequest::Stop) => {break;}
1371 : }
1372 : }
1373 0 : _ = async{
1374 0 : match bg_compute_hook_result_rx.recv().await {
1375 0 : Some(result) => {
1376 0 : if let Err((tenant_shard_id, notify_error)) = result {
1377 0 : tracing::warn!("Marking shard {tenant_shard_id} for notification retry, due to error {notify_error}");
1378 0 : let mut locked = self.inner.write().unwrap();
1379 0 : if let Some(shard) = locked.tenants.get_mut(&tenant_shard_id) {
1380 0 : shard.pending_compute_notification = true;
1381 0 : }
1382 :
1383 0 : }
1384 : },
1385 : None => {
1386 : // This channel is dead, but we don't want to terminate the outer loop{}: just wait for shutdown
1387 0 : self.cancel.cancelled().await;
1388 : }
1389 : }
1390 0 : } => {},
1391 0 : _ = self.cancel.cancelled() => {
1392 0 : break;
1393 : }
1394 : };
1395 : }
1396 0 : }
1397 :
1398 0 : async fn process_aborts(
1399 0 : &self,
1400 0 : mut abort_rx: tokio::sync::mpsc::UnboundedReceiver<TenantShardSplitAbort>,
1401 0 : ) {
1402 : loop {
1403 : // Wait for the next result, or for cancellation
1404 0 : let op = tokio::select! {
1405 0 : r = abort_rx.recv() => {
1406 0 : match r {
1407 0 : Some(op) => {op},
1408 0 : None => {break;}
1409 : }
1410 : }
1411 0 : _ = self.cancel.cancelled() => {
1412 0 : break;
1413 : }
1414 : };
1415 :
1416 : // Retry until shutdown: we must keep this request object alive until it is properly
1417 : // processed, as it holds a lock guard that prevents other operations trying to do things
1418 : // to the tenant while it is in a weird part-split state.
1419 0 : while !self.cancel.is_cancelled() {
1420 0 : match self.abort_tenant_shard_split(&op).await {
1421 0 : Ok(_) => break,
1422 0 : Err(e) => {
1423 0 : tracing::warn!(
1424 0 : "Failed to abort shard split on {}, will retry: {e}",
1425 : op.tenant_id
1426 : );
1427 :
1428 : // If a node is unavailable, we hope that it has been properly marked Offline
1429 : // when we retry, so that the abort op will succeed. If the abort op is failing
1430 : // for some other reason, we will keep retrying forever, or until a human notices
1431 : // and does something about it (either fixing a pageserver or restarting the controller).
1432 0 : tokio::time::timeout(Duration::from_secs(5), self.cancel.cancelled())
1433 0 : .await
1434 0 : .ok();
1435 : }
1436 : }
1437 : }
1438 : }
1439 0 : }
1440 :
1441 0 : pub async fn spawn(config: Config, persistence: Arc<Persistence>) -> anyhow::Result<Arc<Self>> {
1442 0 : let (result_tx, result_rx) = tokio::sync::mpsc::unbounded_channel();
1443 0 : let (abort_tx, abort_rx) = tokio::sync::mpsc::unbounded_channel();
1444 0 :
1445 0 : let leadership_cancel = CancellationToken::new();
1446 0 : let leadership = Leadership::new(persistence.clone(), config.clone(), leadership_cancel);
1447 0 : let (leader, leader_step_down_state) = leadership.step_down_current_leader().await?;
1448 :
1449 : // Apply the migrations **after** the current leader has stepped down
1450 : // (or we've given up waiting for it), but **before** reading from the
1451 : // database. The only exception is reading the current leader before
1452 : // migrating.
1453 0 : persistence.migration_run().await?;
1454 :
1455 0 : tracing::info!("Loading nodes from database...");
1456 0 : let nodes = persistence
1457 0 : .list_nodes()
1458 0 : .await?
1459 0 : .into_iter()
1460 0 : .map(|x| Node::from_persistent(x, config.use_https_pageserver_api))
1461 0 : .collect::<anyhow::Result<Vec<Node>>>()?;
1462 0 : let nodes: HashMap<NodeId, Node> = nodes.into_iter().map(|n| (n.get_id(), n)).collect();
1463 0 : tracing::info!("Loaded {} nodes from database.", nodes.len());
1464 0 : metrics::METRICS_REGISTRY
1465 0 : .metrics_group
1466 0 : .storage_controller_pageserver_nodes
1467 0 : .set(nodes.len() as i64);
1468 0 :
1469 0 : tracing::info!("Loading safekeepers from database...");
1470 0 : let safekeepers = persistence
1471 0 : .list_safekeepers()
1472 0 : .await?
1473 0 : .into_iter()
1474 0 : .map(|skp| {
1475 0 : Safekeeper::from_persistence(
1476 0 : skp,
1477 0 : CancellationToken::new(),
1478 0 : config.use_https_safekeeper_api,
1479 0 : )
1480 0 : })
1481 0 : .collect::<anyhow::Result<Vec<_>>>()?;
1482 0 : let safekeepers: HashMap<NodeId, Safekeeper> =
1483 0 : safekeepers.into_iter().map(|n| (n.get_id(), n)).collect();
1484 0 : tracing::info!("Loaded {} safekeepers from database.", safekeepers.len());
1485 :
1486 0 : tracing::info!("Loading shards from database...");
1487 0 : let mut tenant_shard_persistence = persistence.load_active_tenant_shards().await?;
1488 0 : tracing::info!(
1489 0 : "Loaded {} shards from database.",
1490 0 : tenant_shard_persistence.len()
1491 : );
1492 :
1493 : // If any shard splits were in progress, reset the database state to abort them
1494 0 : let mut tenant_shard_count_min_max: HashMap<TenantId, (ShardCount, ShardCount)> =
1495 0 : HashMap::new();
1496 0 : for tsp in &mut tenant_shard_persistence {
1497 0 : let shard = tsp.get_shard_identity()?;
1498 0 : let tenant_shard_id = tsp.get_tenant_shard_id()?;
1499 0 : let entry = tenant_shard_count_min_max
1500 0 : .entry(tenant_shard_id.tenant_id)
1501 0 : .or_insert_with(|| (shard.count, shard.count));
1502 0 : entry.0 = std::cmp::min(entry.0, shard.count);
1503 0 : entry.1 = std::cmp::max(entry.1, shard.count);
1504 0 : }
1505 :
1506 0 : for (tenant_id, (count_min, count_max)) in tenant_shard_count_min_max {
1507 0 : if count_min != count_max {
1508 : // Aborting the split in the database and dropping the child shards is sufficient: the reconciliation in
1509 : // [`Self::startup_reconcile`] will implicitly drop the child shards on remote pageservers, or they'll
1510 : // be dropped later in [`Self::node_activate_reconcile`] if it isn't available right now.
1511 0 : tracing::info!("Aborting shard split {tenant_id} {count_min:?} -> {count_max:?}");
1512 0 : let abort_status = persistence.abort_shard_split(tenant_id, count_max).await?;
1513 :
1514 : // We may never see the Complete status here: if the split was complete, we wouldn't have
1515 : // identified this tenant has having mismatching min/max counts.
1516 0 : assert!(matches!(abort_status, AbortShardSplitStatus::Aborted));
1517 :
1518 : // Clear the splitting status in-memory, to reflect that we just aborted in the database
1519 0 : tenant_shard_persistence.iter_mut().for_each(|tsp| {
1520 0 : // Set idle split state on those shards that we will retain.
1521 0 : let tsp_tenant_id = TenantId::from_str(tsp.tenant_id.as_str()).unwrap();
1522 0 : if tsp_tenant_id == tenant_id
1523 0 : && tsp.get_shard_identity().unwrap().count == count_min
1524 0 : {
1525 0 : tsp.splitting = SplitState::Idle;
1526 0 : } else if tsp_tenant_id == tenant_id {
1527 : // Leave the splitting state on the child shards: this will be used next to
1528 : // drop them.
1529 0 : tracing::info!(
1530 0 : "Shard {tsp_tenant_id} will be dropped after shard split abort",
1531 : );
1532 0 : }
1533 0 : });
1534 0 :
1535 0 : // Drop shards for this tenant which we didn't just mark idle (i.e. child shards of the aborted split)
1536 0 : tenant_shard_persistence.retain(|tsp| {
1537 0 : TenantId::from_str(tsp.tenant_id.as_str()).unwrap() != tenant_id
1538 0 : || tsp.splitting == SplitState::Idle
1539 0 : });
1540 0 : }
1541 : }
1542 :
1543 0 : let mut tenants = BTreeMap::new();
1544 0 :
1545 0 : let mut scheduler = Scheduler::new(nodes.values());
1546 :
1547 : #[cfg(feature = "testing")]
1548 : {
1549 : use pageserver_api::controller_api::AvailabilityZone;
1550 :
1551 : // Hack: insert scheduler state for all nodes referenced by shards, as compatibility
1552 : // tests only store the shards, not the nodes. The nodes will be loaded shortly
1553 : // after when pageservers start up and register.
1554 0 : let mut node_ids = HashSet::new();
1555 0 : for tsp in &tenant_shard_persistence {
1556 0 : if let Some(node_id) = tsp.generation_pageserver {
1557 0 : node_ids.insert(node_id);
1558 0 : }
1559 : }
1560 0 : for node_id in node_ids {
1561 0 : tracing::info!("Creating node {} in scheduler for tests", node_id);
1562 0 : let node = Node::new(
1563 0 : NodeId(node_id as u64),
1564 0 : "".to_string(),
1565 0 : 123,
1566 0 : None,
1567 0 : "".to_string(),
1568 0 : 123,
1569 0 : AvailabilityZone("test_az".to_string()),
1570 0 : false,
1571 0 : )
1572 0 : .unwrap();
1573 0 :
1574 0 : scheduler.node_upsert(&node);
1575 : }
1576 : }
1577 0 : for tsp in tenant_shard_persistence {
1578 0 : let tenant_shard_id = tsp.get_tenant_shard_id()?;
1579 :
1580 : // We will populate intent properly later in [`Self::startup_reconcile`], initially populate
1581 : // it with what we can infer: the node for which a generation was most recently issued.
1582 0 : let mut intent = IntentState::new(
1583 0 : tsp.preferred_az_id
1584 0 : .as_ref()
1585 0 : .map(|az| AvailabilityZone(az.clone())),
1586 0 : );
1587 0 : if let Some(generation_pageserver) = tsp.generation_pageserver.map(|n| NodeId(n as u64))
1588 : {
1589 0 : if nodes.contains_key(&generation_pageserver) {
1590 0 : intent.set_attached(&mut scheduler, Some(generation_pageserver));
1591 0 : } else {
1592 : // If a node was removed before being completely drained, it is legal for it to leave behind a `generation_pageserver` referring
1593 : // to a non-existent node, because node deletion doesn't block on completing the reconciliations that will issue new generations
1594 : // on different pageservers.
1595 0 : tracing::warn!(
1596 0 : "Tenant shard {tenant_shard_id} references non-existent node {generation_pageserver} in database, will be rescheduled"
1597 : );
1598 : }
1599 0 : }
1600 0 : let new_tenant = TenantShard::from_persistent(tsp, intent)?;
1601 :
1602 0 : tenants.insert(tenant_shard_id, new_tenant);
1603 : }
1604 :
1605 0 : let (startup_completion, startup_complete) = utils::completion::channel();
1606 0 :
1607 0 : // This channel is continuously consumed by process_results, so doesn't need to be very large.
1608 0 : let (bg_compute_notify_result_tx, bg_compute_notify_result_rx) =
1609 0 : tokio::sync::mpsc::channel(512);
1610 0 :
1611 0 : let (delayed_reconcile_tx, delayed_reconcile_rx) =
1612 0 : tokio::sync::mpsc::channel(MAX_DELAYED_RECONCILES);
1613 0 :
1614 0 : let cancel = CancellationToken::new();
1615 0 : let reconcilers_cancel = cancel.child_token();
1616 0 :
1617 0 : let heartbeater_ps = Heartbeater::new(
1618 0 : config.pageserver_jwt_token.clone(),
1619 0 : config.ssl_ca_cert.clone(),
1620 0 : config.max_offline_interval,
1621 0 : config.max_warming_up_interval,
1622 0 : cancel.clone(),
1623 0 : );
1624 0 :
1625 0 : let heartbeater_sk = Heartbeater::new(
1626 0 : config.safekeeper_jwt_token.clone(),
1627 0 : config.ssl_ca_cert.clone(),
1628 0 : config.max_offline_interval,
1629 0 : config.max_warming_up_interval,
1630 0 : cancel.clone(),
1631 0 : );
1632 :
1633 0 : let initial_leadership_status = if config.start_as_candidate {
1634 0 : LeadershipStatus::Candidate
1635 : } else {
1636 0 : LeadershipStatus::Leader
1637 : };
1638 :
1639 0 : let this = Arc::new(Self {
1640 0 : inner: Arc::new(std::sync::RwLock::new(ServiceState::new(
1641 0 : nodes,
1642 0 : safekeepers,
1643 0 : tenants,
1644 0 : scheduler,
1645 0 : delayed_reconcile_rx,
1646 0 : initial_leadership_status,
1647 0 : reconcilers_cancel.clone(),
1648 0 : ))),
1649 0 : config: config.clone(),
1650 0 : persistence,
1651 0 : compute_hook: Arc::new(ComputeHook::new(config.clone())),
1652 0 : result_tx,
1653 0 : heartbeater_ps,
1654 0 : heartbeater_sk,
1655 0 : reconciler_concurrency: Arc::new(tokio::sync::Semaphore::new(
1656 0 : config.reconciler_concurrency,
1657 0 : )),
1658 0 : priority_reconciler_concurrency: Arc::new(tokio::sync::Semaphore::new(
1659 0 : config.priority_reconciler_concurrency,
1660 0 : )),
1661 0 : delayed_reconcile_tx,
1662 0 : abort_tx,
1663 0 : startup_complete: startup_complete.clone(),
1664 0 : cancel,
1665 0 : reconcilers_cancel,
1666 0 : gate: Gate::default(),
1667 0 : reconcilers_gate: Gate::default(),
1668 0 : tenant_op_locks: Default::default(),
1669 0 : node_op_locks: Default::default(),
1670 0 : });
1671 0 :
1672 0 : let result_task_this = this.clone();
1673 0 : tokio::task::spawn(async move {
1674 : // Block shutdown until we're done (we must respect self.cancel)
1675 0 : if let Ok(_gate) = result_task_this.gate.enter() {
1676 0 : result_task_this
1677 0 : .process_results(result_rx, bg_compute_notify_result_rx)
1678 0 : .await
1679 0 : }
1680 0 : });
1681 0 :
1682 0 : tokio::task::spawn({
1683 0 : let this = this.clone();
1684 0 : async move {
1685 : // Block shutdown until we're done (we must respect self.cancel)
1686 0 : if let Ok(_gate) = this.gate.enter() {
1687 0 : this.process_aborts(abort_rx).await
1688 0 : }
1689 0 : }
1690 0 : });
1691 0 :
1692 0 : tokio::task::spawn({
1693 0 : let this = this.clone();
1694 0 : async move {
1695 0 : if let Ok(_gate) = this.gate.enter() {
1696 : loop {
1697 0 : tokio::select! {
1698 0 : _ = this.cancel.cancelled() => {
1699 0 : break;
1700 : },
1701 0 : _ = tokio::time::sleep(Duration::from_secs(60)) => {}
1702 0 : };
1703 0 : this.tenant_op_locks.housekeeping();
1704 : }
1705 0 : }
1706 0 : }
1707 0 : });
1708 0 :
1709 0 : tokio::task::spawn({
1710 0 : let this = this.clone();
1711 0 : // We will block the [`Service::startup_complete`] barrier until [`Self::startup_reconcile`]
1712 0 : // is done.
1713 0 : let startup_completion = startup_completion.clone();
1714 0 : async move {
1715 : // Block shutdown until we're done (we must respect self.cancel)
1716 0 : let Ok(_gate) = this.gate.enter() else {
1717 0 : return;
1718 : };
1719 :
1720 0 : this.startup_reconcile(leader, leader_step_down_state, bg_compute_notify_result_tx)
1721 0 : .await;
1722 :
1723 0 : drop(startup_completion);
1724 0 : }
1725 0 : });
1726 0 :
1727 0 : tokio::task::spawn({
1728 0 : let this = this.clone();
1729 0 : let startup_complete = startup_complete.clone();
1730 0 : async move {
1731 0 : startup_complete.wait().await;
1732 0 : this.background_reconcile().await;
1733 0 : }
1734 0 : });
1735 0 :
1736 0 : tokio::task::spawn({
1737 0 : let this = this.clone();
1738 0 : let startup_complete = startup_complete.clone();
1739 0 : async move {
1740 0 : startup_complete.wait().await;
1741 0 : this.spawn_heartbeat_driver().await;
1742 0 : }
1743 0 : });
1744 0 :
1745 0 : Ok(this)
1746 0 : }
1747 :
1748 0 : pub(crate) async fn attach_hook(
1749 0 : &self,
1750 0 : attach_req: AttachHookRequest,
1751 0 : ) -> anyhow::Result<AttachHookResponse> {
1752 0 : let _tenant_lock = trace_exclusive_lock(
1753 0 : &self.tenant_op_locks,
1754 0 : attach_req.tenant_shard_id.tenant_id,
1755 0 : TenantOperations::AttachHook,
1756 0 : )
1757 0 : .await;
1758 :
1759 : // This is a test hook. To enable using it on tenants that were created directly with
1760 : // the pageserver API (not via this service), we will auto-create any missing tenant
1761 : // shards with default state.
1762 0 : let insert = {
1763 0 : match self
1764 0 : .maybe_load_tenant(attach_req.tenant_shard_id.tenant_id, &_tenant_lock)
1765 0 : .await
1766 : {
1767 0 : Ok(_) => false,
1768 0 : Err(ApiError::NotFound(_)) => true,
1769 0 : Err(e) => return Err(e.into()),
1770 : }
1771 : };
1772 :
1773 0 : if insert {
1774 0 : let tsp = TenantShardPersistence {
1775 0 : tenant_id: attach_req.tenant_shard_id.tenant_id.to_string(),
1776 0 : shard_number: attach_req.tenant_shard_id.shard_number.0 as i32,
1777 0 : shard_count: attach_req.tenant_shard_id.shard_count.literal() as i32,
1778 0 : shard_stripe_size: 0,
1779 0 : generation: attach_req.generation_override.or(Some(0)),
1780 0 : generation_pageserver: None,
1781 0 : placement_policy: serde_json::to_string(&PlacementPolicy::Attached(0)).unwrap(),
1782 0 : config: serde_json::to_string(&TenantConfig::default()).unwrap(),
1783 0 : splitting: SplitState::default(),
1784 0 : scheduling_policy: serde_json::to_string(&ShardSchedulingPolicy::default())
1785 0 : .unwrap(),
1786 0 : preferred_az_id: None,
1787 0 : };
1788 0 :
1789 0 : match self.persistence.insert_tenant_shards(vec![tsp]).await {
1790 0 : Err(e) => match e {
1791 : DatabaseError::Query(diesel::result::Error::DatabaseError(
1792 : DatabaseErrorKind::UniqueViolation,
1793 : _,
1794 : )) => {
1795 0 : tracing::info!(
1796 0 : "Raced with another request to insert tenant {}",
1797 : attach_req.tenant_shard_id
1798 : )
1799 : }
1800 0 : _ => return Err(e.into()),
1801 : },
1802 : Ok(()) => {
1803 0 : tracing::info!("Inserted shard {} in database", attach_req.tenant_shard_id);
1804 :
1805 0 : let mut locked = self.inner.write().unwrap();
1806 0 : locked.tenants.insert(
1807 0 : attach_req.tenant_shard_id,
1808 0 : TenantShard::new(
1809 0 : attach_req.tenant_shard_id,
1810 0 : ShardIdentity::unsharded(),
1811 0 : PlacementPolicy::Attached(0),
1812 0 : None,
1813 0 : ),
1814 0 : );
1815 0 : tracing::info!("Inserted shard {} in memory", attach_req.tenant_shard_id);
1816 : }
1817 : }
1818 0 : }
1819 :
1820 0 : let new_generation = if let Some(req_node_id) = attach_req.node_id {
1821 0 : let maybe_tenant_conf = {
1822 0 : let locked = self.inner.write().unwrap();
1823 0 : locked
1824 0 : .tenants
1825 0 : .get(&attach_req.tenant_shard_id)
1826 0 : .map(|t| t.config.clone())
1827 0 : };
1828 0 :
1829 0 : match maybe_tenant_conf {
1830 0 : Some(conf) => {
1831 0 : let new_generation = self
1832 0 : .persistence
1833 0 : .increment_generation(attach_req.tenant_shard_id, req_node_id)
1834 0 : .await?;
1835 :
1836 : // Persist the placement policy update. This is required
1837 : // when we reattaching a detached tenant.
1838 0 : self.persistence
1839 0 : .update_tenant_shard(
1840 0 : TenantFilter::Shard(attach_req.tenant_shard_id),
1841 0 : Some(PlacementPolicy::Attached(0)),
1842 0 : Some(conf),
1843 0 : None,
1844 0 : None,
1845 0 : )
1846 0 : .await?;
1847 0 : Some(new_generation)
1848 : }
1849 : None => {
1850 0 : anyhow::bail!("Attach hook handling raced with tenant removal")
1851 : }
1852 : }
1853 : } else {
1854 0 : self.persistence.detach(attach_req.tenant_shard_id).await?;
1855 0 : None
1856 : };
1857 :
1858 0 : let mut locked = self.inner.write().unwrap();
1859 0 : let (_nodes, tenants, scheduler) = locked.parts_mut();
1860 0 :
1861 0 : let tenant_shard = tenants
1862 0 : .get_mut(&attach_req.tenant_shard_id)
1863 0 : .expect("Checked for existence above");
1864 :
1865 0 : if let Some(new_generation) = new_generation {
1866 0 : tenant_shard.generation = Some(new_generation);
1867 0 : tenant_shard.policy = PlacementPolicy::Attached(0);
1868 0 : } else {
1869 : // This is a detach notification. We must update placement policy to avoid re-attaching
1870 : // during background scheduling/reconciliation, or during storage controller restart.
1871 0 : assert!(attach_req.node_id.is_none());
1872 0 : tenant_shard.policy = PlacementPolicy::Detached;
1873 : }
1874 :
1875 0 : if let Some(attaching_pageserver) = attach_req.node_id.as_ref() {
1876 0 : tracing::info!(
1877 : tenant_id = %attach_req.tenant_shard_id,
1878 : ps_id = %attaching_pageserver,
1879 : generation = ?tenant_shard.generation,
1880 0 : "issuing",
1881 : );
1882 0 : } else if let Some(ps_id) = tenant_shard.intent.get_attached() {
1883 0 : tracing::info!(
1884 : tenant_id = %attach_req.tenant_shard_id,
1885 : %ps_id,
1886 : generation = ?tenant_shard.generation,
1887 0 : "dropping",
1888 : );
1889 : } else {
1890 0 : tracing::info!(
1891 : tenant_id = %attach_req.tenant_shard_id,
1892 0 : "no-op: tenant already has no pageserver");
1893 : }
1894 0 : tenant_shard
1895 0 : .intent
1896 0 : .set_attached(scheduler, attach_req.node_id);
1897 0 :
1898 0 : tracing::info!(
1899 0 : "attach_hook: tenant {} set generation {:?}, pageserver {}",
1900 0 : attach_req.tenant_shard_id,
1901 0 : tenant_shard.generation,
1902 0 : // TODO: this is an odd number of 0xf's
1903 0 : attach_req.node_id.unwrap_or(utils::id::NodeId(0xfffffff))
1904 : );
1905 :
1906 : // Trick the reconciler into not doing anything for this tenant: this helps
1907 : // tests that manually configure a tenant on the pagesrever, and then call this
1908 : // attach hook: they don't want background reconciliation to modify what they
1909 : // did to the pageserver.
1910 : #[cfg(feature = "testing")]
1911 : {
1912 0 : if let Some(node_id) = attach_req.node_id {
1913 0 : tenant_shard.observed.locations = HashMap::from([(
1914 0 : node_id,
1915 0 : ObservedStateLocation {
1916 0 : conf: Some(attached_location_conf(
1917 0 : tenant_shard.generation.unwrap(),
1918 0 : &tenant_shard.shard,
1919 0 : &tenant_shard.config,
1920 0 : &PlacementPolicy::Attached(0),
1921 0 : )),
1922 0 : },
1923 0 : )]);
1924 0 : } else {
1925 0 : tenant_shard.observed.locations.clear();
1926 0 : }
1927 : }
1928 :
1929 0 : Ok(AttachHookResponse {
1930 0 : generation: attach_req
1931 0 : .node_id
1932 0 : .map(|_| tenant_shard.generation.expect("Test hook, not used on tenants that are mid-onboarding with a NULL generation").into().unwrap()),
1933 0 : })
1934 0 : }
1935 :
1936 0 : pub(crate) fn inspect(&self, inspect_req: InspectRequest) -> InspectResponse {
1937 0 : let locked = self.inner.read().unwrap();
1938 0 :
1939 0 : let tenant_shard = locked.tenants.get(&inspect_req.tenant_shard_id);
1940 0 :
1941 0 : InspectResponse {
1942 0 : attachment: tenant_shard.and_then(|s| {
1943 0 : s.intent
1944 0 : .get_attached()
1945 0 : .map(|ps| (s.generation.expect("Test hook, not used on tenants that are mid-onboarding with a NULL generation").into().unwrap(), ps))
1946 0 : }),
1947 0 : }
1948 0 : }
1949 :
1950 : // When the availability state of a node transitions to active, we must do a full reconciliation
1951 : // of LocationConfigs on that node. This is because while a node was offline:
1952 : // - we might have proceeded through startup_reconcile without checking for extraneous LocationConfigs on this node
1953 : // - aborting a tenant shard split might have left rogue child shards behind on this node.
1954 : //
1955 : // This function must complete _before_ setting a `Node` to Active: once it is set to Active, other
1956 : // Reconcilers might communicate with the node, and these must not overlap with the work we do in
1957 : // this function.
1958 : //
1959 : // The reconciliation logic in here is very similar to what [`Self::startup_reconcile`] does, but
1960 : // for written for a single node rather than as a batch job for all nodes.
1961 : #[tracing::instrument(skip_all, fields(node_id=%node.get_id()))]
1962 : async fn node_activate_reconcile(
1963 : &self,
1964 : mut node: Node,
1965 : _lock: &TracingExclusiveGuard<NodeOperations>,
1966 : ) -> Result<(), ApiError> {
1967 : // This Node is a mutable local copy: we will set it active so that we can use its
1968 : // API client to reconcile with the node. The Node in [`Self::nodes`] will get updated
1969 : // later.
1970 : node.set_availability(NodeAvailability::Active(PageserverUtilization::full()));
1971 :
1972 : let configs = match node
1973 : .with_client_retries(
1974 0 : |client| async move { client.list_location_config().await },
1975 : &self.config.pageserver_jwt_token,
1976 : &self.config.ssl_ca_cert,
1977 : 1,
1978 : 5,
1979 : SHORT_RECONCILE_TIMEOUT,
1980 : &self.cancel,
1981 : )
1982 : .await
1983 : {
1984 : None => {
1985 : // We're shutting down (the Node's cancellation token can't have fired, because
1986 : // we're the only scope that has a reference to it, and we didn't fire it).
1987 : return Err(ApiError::ShuttingDown);
1988 : }
1989 : Some(Err(e)) => {
1990 : // This node didn't succeed listing its locations: it may not proceed to active state
1991 : // as it is apparently unavailable.
1992 : return Err(ApiError::PreconditionFailed(
1993 : format!("Failed to query node location configs, cannot activate ({e})").into(),
1994 : ));
1995 : }
1996 : Some(Ok(configs)) => configs,
1997 : };
1998 : tracing::info!("Loaded {} LocationConfigs", configs.tenant_shards.len());
1999 :
2000 : let mut cleanup = Vec::new();
2001 : let mut mismatched_locations = 0;
2002 : {
2003 : let mut locked = self.inner.write().unwrap();
2004 :
2005 : for (tenant_shard_id, reported) in configs.tenant_shards {
2006 : let Some(tenant_shard) = locked.tenants.get_mut(&tenant_shard_id) else {
2007 : cleanup.push(tenant_shard_id);
2008 : continue;
2009 : };
2010 :
2011 : let on_record = &mut tenant_shard
2012 : .observed
2013 : .locations
2014 : .entry(node.get_id())
2015 0 : .or_insert_with(|| ObservedStateLocation { conf: None })
2016 : .conf;
2017 :
2018 : // If the location reported by the node does not match our observed state,
2019 : // then we mark it as uncertain and let the background reconciliation loop
2020 : // deal with it.
2021 : //
2022 : // Note that this also covers net new locations reported by the node.
2023 : if *on_record != reported {
2024 : mismatched_locations += 1;
2025 : *on_record = None;
2026 : }
2027 : }
2028 : }
2029 :
2030 : if mismatched_locations > 0 {
2031 : tracing::info!(
2032 : "Set observed state to None for {mismatched_locations} mismatched locations"
2033 : );
2034 : }
2035 :
2036 : for tenant_shard_id in cleanup {
2037 : tracing::info!("Detaching {tenant_shard_id}");
2038 : match node
2039 : .with_client_retries(
2040 0 : |client| async move {
2041 0 : let config = LocationConfig {
2042 0 : mode: LocationConfigMode::Detached,
2043 0 : generation: None,
2044 0 : secondary_conf: None,
2045 0 : shard_number: tenant_shard_id.shard_number.0,
2046 0 : shard_count: tenant_shard_id.shard_count.literal(),
2047 0 : shard_stripe_size: 0,
2048 0 : tenant_conf: models::TenantConfig::default(),
2049 0 : };
2050 0 : client
2051 0 : .location_config(tenant_shard_id, config, None, false)
2052 0 : .await
2053 0 : },
2054 : &self.config.pageserver_jwt_token,
2055 : &self.config.ssl_ca_cert,
2056 : 1,
2057 : 5,
2058 : SHORT_RECONCILE_TIMEOUT,
2059 : &self.cancel,
2060 : )
2061 : .await
2062 : {
2063 : None => {
2064 : // We're shutting down (the Node's cancellation token can't have fired, because
2065 : // we're the only scope that has a reference to it, and we didn't fire it).
2066 : return Err(ApiError::ShuttingDown);
2067 : }
2068 : Some(Err(e)) => {
2069 : // Do not let the node proceed to Active state if it is not responsive to requests
2070 : // to detach. This could happen if e.g. a shutdown bug in the pageserver is preventing
2071 : // detach completing: we should not let this node back into the set of nodes considered
2072 : // okay for scheduling.
2073 : return Err(ApiError::Conflict(format!(
2074 : "Node {node} failed to detach {tenant_shard_id}: {e}"
2075 : )));
2076 : }
2077 : Some(Ok(_)) => {}
2078 : };
2079 : }
2080 :
2081 : Ok(())
2082 : }
2083 :
2084 0 : pub(crate) async fn re_attach(
2085 0 : &self,
2086 0 : reattach_req: ReAttachRequest,
2087 0 : ) -> Result<ReAttachResponse, ApiError> {
2088 0 : if let Some(register_req) = reattach_req.register {
2089 0 : self.node_register(register_req).await?;
2090 0 : }
2091 :
2092 : // Ordering: we must persist generation number updates before making them visible in the in-memory state
2093 0 : let incremented_generations = self.persistence.re_attach(reattach_req.node_id).await?;
2094 :
2095 0 : tracing::info!(
2096 : node_id=%reattach_req.node_id,
2097 0 : "Incremented {} tenant shards' generations",
2098 0 : incremented_generations.len()
2099 : );
2100 :
2101 : // Apply the updated generation to our in-memory state, and
2102 : // gather discover secondary locations.
2103 0 : let mut locked = self.inner.write().unwrap();
2104 0 : let (nodes, tenants, scheduler) = locked.parts_mut();
2105 0 :
2106 0 : let mut response = ReAttachResponse {
2107 0 : tenants: Vec::new(),
2108 0 : };
2109 :
2110 : // TODO: cancel/restart any running reconciliation for this tenant, it might be trying
2111 : // to call location_conf API with an old generation. Wait for cancellation to complete
2112 : // before responding to this request. Requires well implemented CancellationToken logic
2113 : // all the way to where we call location_conf. Even then, there can still be a location_conf
2114 : // request in flight over the network: TODO handle that by making location_conf API refuse
2115 : // to go backward in generations.
2116 :
2117 : // Scan through all shards, applying updates for ones where we updated generation
2118 : // and identifying shards that intend to have a secondary location on this node.
2119 0 : for (tenant_shard_id, shard) in tenants {
2120 0 : if let Some(new_gen) = incremented_generations.get(tenant_shard_id) {
2121 0 : let new_gen = *new_gen;
2122 0 : response.tenants.push(ReAttachResponseTenant {
2123 0 : id: *tenant_shard_id,
2124 0 : r#gen: Some(new_gen.into().unwrap()),
2125 0 : // A tenant is only put into multi or stale modes in the middle of a [`Reconciler::live_migrate`]
2126 0 : // execution. If a pageserver is restarted during that process, then the reconcile pass will
2127 0 : // fail, and start from scratch, so it doesn't make sense for us to try and preserve
2128 0 : // the stale/multi states at this point.
2129 0 : mode: LocationConfigMode::AttachedSingle,
2130 0 : });
2131 0 :
2132 0 : shard.generation = std::cmp::max(shard.generation, Some(new_gen));
2133 0 : if let Some(observed) = shard.observed.locations.get_mut(&reattach_req.node_id) {
2134 : // Why can we update `observed` even though we're not sure our response will be received
2135 : // by the pageserver? Because the pageserver will not proceed with startup until
2136 : // it has processed response: if it loses it, we'll see another request and increment
2137 : // generation again, avoiding any uncertainty about dirtiness of tenant's state.
2138 0 : if let Some(conf) = observed.conf.as_mut() {
2139 0 : conf.generation = new_gen.into();
2140 0 : }
2141 0 : } else {
2142 0 : // This node has no observed state for the shard: perhaps it was offline
2143 0 : // when the pageserver restarted. Insert a None, so that the Reconciler
2144 0 : // will be prompted to learn the location's state before it makes changes.
2145 0 : shard
2146 0 : .observed
2147 0 : .locations
2148 0 : .insert(reattach_req.node_id, ObservedStateLocation { conf: None });
2149 0 : }
2150 0 : } else if shard.intent.get_secondary().contains(&reattach_req.node_id) {
2151 0 : // Ordering: pageserver will not accept /location_config requests until it has
2152 0 : // finished processing the response from re-attach. So we can update our in-memory state
2153 0 : // now, and be confident that we are not stamping on the result of some later location config.
2154 0 : // TODO: however, we are not strictly ordered wrt ReconcileResults queue,
2155 0 : // so we might update observed state here, and then get over-written by some racing
2156 0 : // ReconcileResult. The impact is low however, since we have set state on pageserver something
2157 0 : // that matches intent, so worst case if we race then we end up doing a spurious reconcile.
2158 0 :
2159 0 : response.tenants.push(ReAttachResponseTenant {
2160 0 : id: *tenant_shard_id,
2161 0 : r#gen: None,
2162 0 : mode: LocationConfigMode::Secondary,
2163 0 : });
2164 0 :
2165 0 : // We must not update observed, because we have no guarantee that our
2166 0 : // response will be received by the pageserver. This could leave it
2167 0 : // falsely dirty, but the resulting reconcile should be idempotent.
2168 0 : }
2169 : }
2170 :
2171 : // We consider a node Active once we have composed a re-attach response, but we
2172 : // do not call [`Self::node_activate_reconcile`]: the handling of the re-attach response
2173 : // implicitly synchronizes the LocationConfigs on the node.
2174 : //
2175 : // Setting a node active unblocks any Reconcilers that might write to the location config API,
2176 : // but those requests will not be accepted by the node until it has finished processing
2177 : // the re-attach response.
2178 : //
2179 : // Additionally, reset the nodes scheduling policy to match the conditional update done
2180 : // in [`Persistence::re_attach`].
2181 0 : if let Some(node) = nodes.get(&reattach_req.node_id) {
2182 0 : let reset_scheduling = matches!(
2183 0 : node.get_scheduling(),
2184 : NodeSchedulingPolicy::PauseForRestart
2185 : | NodeSchedulingPolicy::Draining
2186 : | NodeSchedulingPolicy::Filling
2187 : );
2188 :
2189 0 : let mut new_nodes = (**nodes).clone();
2190 0 : if let Some(node) = new_nodes.get_mut(&reattach_req.node_id) {
2191 0 : if reset_scheduling {
2192 0 : node.set_scheduling(NodeSchedulingPolicy::Active);
2193 0 : }
2194 :
2195 0 : tracing::info!("Marking {} warming-up on reattach", reattach_req.node_id);
2196 0 : node.set_availability(NodeAvailability::WarmingUp(std::time::Instant::now()));
2197 0 :
2198 0 : scheduler.node_upsert(node);
2199 0 : let new_nodes = Arc::new(new_nodes);
2200 0 : *nodes = new_nodes;
2201 : } else {
2202 0 : tracing::error!(
2203 0 : "Reattaching node {} was removed while processing the request",
2204 : reattach_req.node_id
2205 : );
2206 : }
2207 0 : }
2208 :
2209 0 : Ok(response)
2210 0 : }
2211 :
2212 0 : pub(crate) async fn validate(
2213 0 : &self,
2214 0 : validate_req: ValidateRequest,
2215 0 : ) -> Result<ValidateResponse, DatabaseError> {
2216 : // Fast in-memory check: we may reject validation on anything that doesn't match our
2217 : // in-memory generation for a shard
2218 0 : let in_memory_result = {
2219 0 : let mut in_memory_result = Vec::new();
2220 0 : let locked = self.inner.read().unwrap();
2221 0 : for req_tenant in validate_req.tenants {
2222 0 : if let Some(tenant_shard) = locked.tenants.get(&req_tenant.id) {
2223 0 : let valid = tenant_shard.generation == Some(Generation::new(req_tenant.r#gen));
2224 0 : tracing::info!(
2225 0 : "handle_validate: {}(gen {}): valid={valid} (latest {:?})",
2226 : req_tenant.id,
2227 : req_tenant.r#gen,
2228 : tenant_shard.generation
2229 : );
2230 :
2231 0 : in_memory_result.push((
2232 0 : req_tenant.id,
2233 0 : Generation::new(req_tenant.r#gen),
2234 0 : valid,
2235 0 : ));
2236 : } else {
2237 : // This is legal: for example during a shard split the pageserver may still
2238 : // have deletions in its queue from the old pre-split shard, or after deletion
2239 : // of a tenant that was busy with compaction/gc while being deleted.
2240 0 : tracing::info!(
2241 0 : "Refusing deletion validation for missing shard {}",
2242 : req_tenant.id
2243 : );
2244 : }
2245 : }
2246 :
2247 0 : in_memory_result
2248 : };
2249 :
2250 : // Database calls to confirm validity for anything that passed the in-memory check. We must do this
2251 : // in case of controller split-brain, where some other controller process might have incremented the generation.
2252 0 : let db_generations = self
2253 0 : .persistence
2254 0 : .shard_generations(
2255 0 : in_memory_result
2256 0 : .iter()
2257 0 : .filter_map(|i| if i.2 { Some(&i.0) } else { None }),
2258 0 : )
2259 0 : .await?;
2260 0 : let db_generations = db_generations.into_iter().collect::<HashMap<_, _>>();
2261 0 :
2262 0 : let mut response = ValidateResponse {
2263 0 : tenants: Vec::new(),
2264 0 : };
2265 0 : for (tenant_shard_id, validate_generation, valid) in in_memory_result.into_iter() {
2266 0 : let valid = if valid {
2267 0 : let db_generation = db_generations.get(&tenant_shard_id);
2268 0 : db_generation == Some(&Some(validate_generation))
2269 : } else {
2270 : // If in-memory state says it's invalid, trust that. It's always safe to fail a validation, at worst
2271 : // this prevents a pageserver from cleaning up an object in S3.
2272 0 : false
2273 : };
2274 :
2275 0 : response.tenants.push(ValidateResponseTenant {
2276 0 : id: tenant_shard_id,
2277 0 : valid,
2278 0 : })
2279 : }
2280 :
2281 0 : Ok(response)
2282 0 : }
2283 :
2284 0 : pub(crate) async fn tenant_create(
2285 0 : &self,
2286 0 : create_req: TenantCreateRequest,
2287 0 : ) -> Result<TenantCreateResponse, ApiError> {
2288 0 : let tenant_id = create_req.new_tenant_id.tenant_id;
2289 :
2290 : // Exclude any concurrent attempts to create/access the same tenant ID
2291 0 : let _tenant_lock = trace_exclusive_lock(
2292 0 : &self.tenant_op_locks,
2293 0 : create_req.new_tenant_id.tenant_id,
2294 0 : TenantOperations::Create,
2295 0 : )
2296 0 : .await;
2297 0 : let (response, waiters) = self.do_tenant_create(create_req).await?;
2298 :
2299 0 : if let Err(e) = self.await_waiters(waiters, RECONCILE_TIMEOUT).await {
2300 : // Avoid deadlock: reconcile may fail while notifying compute, if the cloud control plane refuses to
2301 : // accept compute notifications while it is in the process of creating. Reconciliation will
2302 : // be retried in the background.
2303 0 : tracing::warn!(%tenant_id, "Reconcile not done yet while creating tenant ({e})");
2304 0 : }
2305 0 : Ok(response)
2306 0 : }
2307 :
2308 0 : pub(crate) async fn do_tenant_create(
2309 0 : &self,
2310 0 : create_req: TenantCreateRequest,
2311 0 : ) -> Result<(TenantCreateResponse, Vec<ReconcilerWaiter>), ApiError> {
2312 0 : let placement_policy = create_req
2313 0 : .placement_policy
2314 0 : .clone()
2315 0 : // As a default, zero secondaries is convenient for tests that don't choose a policy.
2316 0 : .unwrap_or(PlacementPolicy::Attached(0));
2317 :
2318 : // This service expects to handle sharding itself: it is an error to try and directly create
2319 : // a particular shard here.
2320 0 : let tenant_id = if !create_req.new_tenant_id.is_unsharded() {
2321 0 : return Err(ApiError::BadRequest(anyhow::anyhow!(
2322 0 : "Attempted to create a specific shard, this API is for creating the whole tenant"
2323 0 : )));
2324 : } else {
2325 0 : create_req.new_tenant_id.tenant_id
2326 0 : };
2327 0 :
2328 0 : tracing::info!(
2329 0 : "Creating tenant {}, shard_count={:?}",
2330 : create_req.new_tenant_id,
2331 : create_req.shard_parameters.count,
2332 : );
2333 :
2334 0 : let create_ids = (0..create_req.shard_parameters.count.count())
2335 0 : .map(|i| TenantShardId {
2336 0 : tenant_id,
2337 0 : shard_number: ShardNumber(i),
2338 0 : shard_count: create_req.shard_parameters.count,
2339 0 : })
2340 0 : .collect::<Vec<_>>();
2341 :
2342 : // If the caller specifies a None generation, it means "start from default". This is different
2343 : // to [`Self::tenant_location_config`], where a None generation is used to represent
2344 : // an incompletely-onboarded tenant.
2345 0 : let initial_generation = if matches!(placement_policy, PlacementPolicy::Secondary) {
2346 0 : tracing::info!(
2347 0 : "tenant_create: secondary mode, generation is_some={}",
2348 0 : create_req.generation.is_some()
2349 : );
2350 0 : create_req.generation.map(Generation::new)
2351 : } else {
2352 0 : tracing::info!(
2353 0 : "tenant_create: not secondary mode, generation is_some={}",
2354 0 : create_req.generation.is_some()
2355 : );
2356 0 : Some(
2357 0 : create_req
2358 0 : .generation
2359 0 : .map(Generation::new)
2360 0 : .unwrap_or(INITIAL_GENERATION),
2361 0 : )
2362 : };
2363 :
2364 0 : let preferred_az_id = {
2365 0 : let locked = self.inner.read().unwrap();
2366 : // Idempotency: take the existing value if the tenant already exists
2367 0 : if let Some(shard) = locked.tenants.get(create_ids.first().unwrap()) {
2368 0 : shard.preferred_az().cloned()
2369 : } else {
2370 0 : locked.scheduler.get_az_for_new_tenant()
2371 : }
2372 : };
2373 :
2374 : // Ordering: we persist tenant shards before creating them on the pageserver. This enables a caller
2375 : // to clean up after themselves by issuing a tenant deletion if something goes wrong and we restart
2376 : // during the creation, rather than risking leaving orphan objects in S3.
2377 0 : let persist_tenant_shards = create_ids
2378 0 : .iter()
2379 0 : .map(|tenant_shard_id| TenantShardPersistence {
2380 0 : tenant_id: tenant_shard_id.tenant_id.to_string(),
2381 0 : shard_number: tenant_shard_id.shard_number.0 as i32,
2382 0 : shard_count: tenant_shard_id.shard_count.literal() as i32,
2383 0 : shard_stripe_size: create_req.shard_parameters.stripe_size.0 as i32,
2384 0 : generation: initial_generation.map(|g| g.into().unwrap() as i32),
2385 0 : // The pageserver is not known until scheduling happens: we will set this column when
2386 0 : // incrementing the generation the first time we attach to a pageserver.
2387 0 : generation_pageserver: None,
2388 0 : placement_policy: serde_json::to_string(&placement_policy).unwrap(),
2389 0 : config: serde_json::to_string(&create_req.config).unwrap(),
2390 0 : splitting: SplitState::default(),
2391 0 : scheduling_policy: serde_json::to_string(&ShardSchedulingPolicy::default())
2392 0 : .unwrap(),
2393 0 : preferred_az_id: preferred_az_id.as_ref().map(|az| az.to_string()),
2394 0 : })
2395 0 : .collect();
2396 0 :
2397 0 : match self
2398 0 : .persistence
2399 0 : .insert_tenant_shards(persist_tenant_shards)
2400 0 : .await
2401 : {
2402 0 : Ok(_) => {}
2403 : Err(DatabaseError::Query(diesel::result::Error::DatabaseError(
2404 : DatabaseErrorKind::UniqueViolation,
2405 : _,
2406 : ))) => {
2407 : // Unique key violation: this is probably a retry. Because the shard count is part of the unique key,
2408 : // if we see a unique key violation it means that the creation request's shard count matches the previous
2409 : // creation's shard count.
2410 0 : tracing::info!(
2411 0 : "Tenant shards already present in database, proceeding with idempotent creation..."
2412 : );
2413 : }
2414 : // Any other database error is unexpected and a bug.
2415 0 : Err(e) => return Err(ApiError::InternalServerError(anyhow::anyhow!(e))),
2416 : };
2417 :
2418 0 : let mut schedule_context = ScheduleContext::default();
2419 0 : let mut schedule_error = None;
2420 0 : let mut response_shards = Vec::new();
2421 0 : for tenant_shard_id in create_ids {
2422 0 : tracing::info!("Creating shard {tenant_shard_id}...");
2423 :
2424 0 : let outcome = self
2425 0 : .do_initial_shard_scheduling(
2426 0 : tenant_shard_id,
2427 0 : initial_generation,
2428 0 : &create_req.shard_parameters,
2429 0 : create_req.config.clone(),
2430 0 : placement_policy.clone(),
2431 0 : preferred_az_id.as_ref(),
2432 0 : &mut schedule_context,
2433 0 : )
2434 0 : .await;
2435 :
2436 0 : match outcome {
2437 0 : InitialShardScheduleOutcome::Scheduled(resp) => response_shards.push(resp),
2438 0 : InitialShardScheduleOutcome::NotScheduled => {}
2439 0 : InitialShardScheduleOutcome::ShardScheduleError(err) => {
2440 0 : schedule_error = Some(err);
2441 0 : }
2442 : }
2443 : }
2444 :
2445 : // If we failed to schedule shards, then they are still created in the controller,
2446 : // but we return an error to the requester to avoid a silent failure when someone
2447 : // tries to e.g. create a tenant whose placement policy requires more nodes than
2448 : // are present in the system. We do this here rather than in the above loop, to
2449 : // avoid situations where we only create a subset of shards in the tenant.
2450 0 : if let Some(e) = schedule_error {
2451 0 : return Err(ApiError::Conflict(format!(
2452 0 : "Failed to schedule shard(s): {e}"
2453 0 : )));
2454 0 : }
2455 0 :
2456 0 : let waiters = {
2457 0 : let mut locked = self.inner.write().unwrap();
2458 0 : let (nodes, tenants, _scheduler) = locked.parts_mut();
2459 0 : let config = ReconcilerConfigBuilder::new(ReconcilerPriority::High)
2460 0 : .tenant_creation_hint(true)
2461 0 : .build();
2462 0 : tenants
2463 0 : .range_mut(TenantShardId::tenant_range(tenant_id))
2464 0 : .filter_map(|(_shard_id, shard)| {
2465 0 : self.maybe_configured_reconcile_shard(shard, nodes, config)
2466 0 : })
2467 0 : .collect::<Vec<_>>()
2468 0 : };
2469 0 :
2470 0 : Ok((
2471 0 : TenantCreateResponse {
2472 0 : shards: response_shards,
2473 0 : },
2474 0 : waiters,
2475 0 : ))
2476 0 : }
2477 :
2478 : /// Helper for tenant creation that does the scheduling for an individual shard. Covers both the
2479 : /// case of a new tenant and a pre-existing one.
2480 : #[allow(clippy::too_many_arguments)]
2481 0 : async fn do_initial_shard_scheduling(
2482 0 : &self,
2483 0 : tenant_shard_id: TenantShardId,
2484 0 : initial_generation: Option<Generation>,
2485 0 : shard_params: &ShardParameters,
2486 0 : config: TenantConfig,
2487 0 : placement_policy: PlacementPolicy,
2488 0 : preferred_az_id: Option<&AvailabilityZone>,
2489 0 : schedule_context: &mut ScheduleContext,
2490 0 : ) -> InitialShardScheduleOutcome {
2491 0 : let mut locked = self.inner.write().unwrap();
2492 0 : let (_nodes, tenants, scheduler) = locked.parts_mut();
2493 :
2494 : use std::collections::btree_map::Entry;
2495 0 : match tenants.entry(tenant_shard_id) {
2496 0 : Entry::Occupied(mut entry) => {
2497 0 : tracing::info!("Tenant shard {tenant_shard_id} already exists while creating");
2498 :
2499 0 : if let Err(err) = entry.get_mut().schedule(scheduler, schedule_context) {
2500 0 : return InitialShardScheduleOutcome::ShardScheduleError(err);
2501 0 : }
2502 :
2503 0 : if let Some(node_id) = entry.get().intent.get_attached() {
2504 0 : let generation = entry
2505 0 : .get()
2506 0 : .generation
2507 0 : .expect("Generation is set when in attached mode");
2508 0 : InitialShardScheduleOutcome::Scheduled(TenantCreateResponseShard {
2509 0 : shard_id: tenant_shard_id,
2510 0 : node_id: *node_id,
2511 0 : generation: generation.into().unwrap(),
2512 0 : })
2513 : } else {
2514 0 : InitialShardScheduleOutcome::NotScheduled
2515 : }
2516 : }
2517 0 : Entry::Vacant(entry) => {
2518 0 : let state = entry.insert(TenantShard::new(
2519 0 : tenant_shard_id,
2520 0 : ShardIdentity::from_params(tenant_shard_id.shard_number, shard_params),
2521 0 : placement_policy,
2522 0 : preferred_az_id.cloned(),
2523 0 : ));
2524 0 :
2525 0 : state.generation = initial_generation;
2526 0 : state.config = config;
2527 0 : if let Err(e) = state.schedule(scheduler, schedule_context) {
2528 0 : return InitialShardScheduleOutcome::ShardScheduleError(e);
2529 0 : }
2530 :
2531 : // Only include shards in result if we are attaching: the purpose
2532 : // of the response is to tell the caller where the shards are attached.
2533 0 : if let Some(node_id) = state.intent.get_attached() {
2534 0 : let generation = state
2535 0 : .generation
2536 0 : .expect("Generation is set when in attached mode");
2537 0 : InitialShardScheduleOutcome::Scheduled(TenantCreateResponseShard {
2538 0 : shard_id: tenant_shard_id,
2539 0 : node_id: *node_id,
2540 0 : generation: generation.into().unwrap(),
2541 0 : })
2542 : } else {
2543 0 : InitialShardScheduleOutcome::NotScheduled
2544 : }
2545 : }
2546 : }
2547 0 : }
2548 :
2549 : /// Helper for functions that reconcile a number of shards, and would like to do a timeout-bounded
2550 : /// wait for reconciliation to complete before responding.
2551 0 : async fn await_waiters(
2552 0 : &self,
2553 0 : waiters: Vec<ReconcilerWaiter>,
2554 0 : timeout: Duration,
2555 0 : ) -> Result<(), ReconcileWaitError> {
2556 0 : let deadline = Instant::now().checked_add(timeout).unwrap();
2557 0 : for waiter in waiters {
2558 0 : let timeout = deadline.duration_since(Instant::now());
2559 0 : waiter.wait_timeout(timeout).await?;
2560 : }
2561 :
2562 0 : Ok(())
2563 0 : }
2564 :
2565 : /// Same as [`Service::await_waiters`], but returns the waiters which are still
2566 : /// in progress
2567 0 : async fn await_waiters_remainder(
2568 0 : &self,
2569 0 : waiters: Vec<ReconcilerWaiter>,
2570 0 : timeout: Duration,
2571 0 : ) -> Vec<ReconcilerWaiter> {
2572 0 : let deadline = Instant::now().checked_add(timeout).unwrap();
2573 0 : for waiter in waiters.iter() {
2574 0 : let timeout = deadline.duration_since(Instant::now());
2575 0 : let _ = waiter.wait_timeout(timeout).await;
2576 : }
2577 :
2578 0 : waiters
2579 0 : .into_iter()
2580 0 : .filter(|waiter| matches!(waiter.get_status(), ReconcilerStatus::InProgress))
2581 0 : .collect::<Vec<_>>()
2582 0 : }
2583 :
2584 : /// Part of [`Self::tenant_location_config`]: dissect an incoming location config request,
2585 : /// and transform it into either a tenant creation of a series of shard updates.
2586 : ///
2587 : /// If the incoming request makes no changes, a [`TenantCreateOrUpdate::Update`] result will
2588 : /// still be returned.
2589 0 : fn tenant_location_config_prepare(
2590 0 : &self,
2591 0 : tenant_id: TenantId,
2592 0 : req: TenantLocationConfigRequest,
2593 0 : ) -> TenantCreateOrUpdate {
2594 0 : let mut updates = Vec::new();
2595 0 : let mut locked = self.inner.write().unwrap();
2596 0 : let (nodes, tenants, _scheduler) = locked.parts_mut();
2597 0 : let tenant_shard_id = TenantShardId::unsharded(tenant_id);
2598 :
2599 : // Use location config mode as an indicator of policy.
2600 0 : let placement_policy = match req.config.mode {
2601 0 : LocationConfigMode::Detached => PlacementPolicy::Detached,
2602 0 : LocationConfigMode::Secondary => PlacementPolicy::Secondary,
2603 : LocationConfigMode::AttachedMulti
2604 : | LocationConfigMode::AttachedSingle
2605 : | LocationConfigMode::AttachedStale => {
2606 0 : if nodes.len() > 1 {
2607 0 : PlacementPolicy::Attached(1)
2608 : } else {
2609 : // Convenience for dev/test: if we just have one pageserver, import
2610 : // tenants into non-HA mode so that scheduling will succeed.
2611 0 : PlacementPolicy::Attached(0)
2612 : }
2613 : }
2614 : };
2615 :
2616 : // Ordinarily we do not update scheduling policy, but when making major changes
2617 : // like detaching or demoting to secondary-only, we need to force the scheduling
2618 : // mode to Active, or the caller's expected outcome (detach it) will not happen.
2619 0 : let scheduling_policy = match req.config.mode {
2620 : LocationConfigMode::Detached | LocationConfigMode::Secondary => {
2621 : // Special case: when making major changes like detaching or demoting to secondary-only,
2622 : // we need to force the scheduling mode to Active, or nothing will happen.
2623 0 : Some(ShardSchedulingPolicy::Active)
2624 : }
2625 : LocationConfigMode::AttachedMulti
2626 : | LocationConfigMode::AttachedSingle
2627 : | LocationConfigMode::AttachedStale => {
2628 : // While attached, continue to respect whatever the existing scheduling mode is.
2629 0 : None
2630 : }
2631 : };
2632 :
2633 0 : let mut create = true;
2634 0 : for (shard_id, shard) in tenants.range_mut(TenantShardId::tenant_range(tenant_id)) {
2635 : // Saw an existing shard: this is not a creation
2636 0 : create = false;
2637 :
2638 : // Shards may have initially been created by a Secondary request, where we
2639 : // would have left generation as None.
2640 : //
2641 : // We only update generation the first time we see an attached-mode request,
2642 : // and if there is no existing generation set. The caller is responsible for
2643 : // ensuring that no non-storage-controller pageserver ever uses a higher
2644 : // generation than they passed in here.
2645 : use LocationConfigMode::*;
2646 0 : let set_generation = match req.config.mode {
2647 0 : AttachedMulti | AttachedSingle | AttachedStale if shard.generation.is_none() => {
2648 0 : req.config.generation.map(Generation::new)
2649 : }
2650 0 : _ => None,
2651 : };
2652 :
2653 0 : updates.push(ShardUpdate {
2654 0 : tenant_shard_id: *shard_id,
2655 0 : placement_policy: placement_policy.clone(),
2656 0 : tenant_config: req.config.tenant_conf.clone(),
2657 0 : generation: set_generation,
2658 0 : scheduling_policy,
2659 0 : });
2660 : }
2661 :
2662 0 : if create {
2663 : use LocationConfigMode::*;
2664 0 : let generation = match req.config.mode {
2665 0 : AttachedMulti | AttachedSingle | AttachedStale => req.config.generation,
2666 : // If a caller provided a generation in a non-attached request, ignore it
2667 : // and leave our generation as None: this enables a subsequent update to set
2668 : // the generation when setting an attached mode for the first time.
2669 0 : _ => None,
2670 : };
2671 :
2672 0 : TenantCreateOrUpdate::Create(
2673 0 : // Synthesize a creation request
2674 0 : TenantCreateRequest {
2675 0 : new_tenant_id: tenant_shard_id,
2676 0 : generation,
2677 0 : shard_parameters: ShardParameters {
2678 0 : count: tenant_shard_id.shard_count,
2679 0 : // We only import un-sharded or single-sharded tenants, so stripe
2680 0 : // size can be made up arbitrarily here.
2681 0 : stripe_size: ShardParameters::DEFAULT_STRIPE_SIZE,
2682 0 : },
2683 0 : placement_policy: Some(placement_policy),
2684 0 : config: req.config.tenant_conf,
2685 0 : },
2686 0 : )
2687 : } else {
2688 0 : assert!(!updates.is_empty());
2689 0 : TenantCreateOrUpdate::Update(updates)
2690 : }
2691 0 : }
2692 :
2693 : /// For APIs that might act on tenants with [`PlacementPolicy::Detached`], first check if
2694 : /// the tenant is present in memory. If not, load it from the database. If it is found
2695 : /// in neither location, return a NotFound error.
2696 : ///
2697 : /// Caller must demonstrate they hold a lock guard, as otherwise two callers might try and load
2698 : /// it at the same time, or we might race with [`Self::maybe_drop_tenant`]
2699 0 : async fn maybe_load_tenant(
2700 0 : &self,
2701 0 : tenant_id: TenantId,
2702 0 : _guard: &TracingExclusiveGuard<TenantOperations>,
2703 0 : ) -> Result<(), ApiError> {
2704 : // Check if the tenant is present in memory, and select an AZ to use when loading
2705 : // if we will load it.
2706 0 : let load_in_az = {
2707 0 : let locked = self.inner.read().unwrap();
2708 0 : let existing = locked
2709 0 : .tenants
2710 0 : .range(TenantShardId::tenant_range(tenant_id))
2711 0 : .next();
2712 0 :
2713 0 : // If the tenant is not present in memory, we expect to load it from database,
2714 0 : // so let's figure out what AZ to load it into while we have self.inner locked.
2715 0 : if existing.is_none() {
2716 0 : locked
2717 0 : .scheduler
2718 0 : .get_az_for_new_tenant()
2719 0 : .ok_or(ApiError::BadRequest(anyhow::anyhow!(
2720 0 : "No AZ with nodes found to load tenant"
2721 0 : )))?
2722 : } else {
2723 : // We already have this tenant in memory
2724 0 : return Ok(());
2725 : }
2726 : };
2727 :
2728 0 : let tenant_shards = self.persistence.load_tenant(tenant_id).await?;
2729 0 : if tenant_shards.is_empty() {
2730 0 : return Err(ApiError::NotFound(
2731 0 : anyhow::anyhow!("Tenant {} not found", tenant_id).into(),
2732 0 : ));
2733 0 : }
2734 0 :
2735 0 : // Update the persistent shards with the AZ that we are about to apply to in-memory state
2736 0 : self.persistence
2737 0 : .set_tenant_shard_preferred_azs(
2738 0 : tenant_shards
2739 0 : .iter()
2740 0 : .map(|t| {
2741 0 : (
2742 0 : t.get_tenant_shard_id().expect("Corrupt shard in database"),
2743 0 : Some(load_in_az.clone()),
2744 0 : )
2745 0 : })
2746 0 : .collect(),
2747 0 : )
2748 0 : .await?;
2749 :
2750 0 : let mut locked = self.inner.write().unwrap();
2751 0 : tracing::info!(
2752 0 : "Loaded {} shards for tenant {}",
2753 0 : tenant_shards.len(),
2754 : tenant_id
2755 : );
2756 :
2757 0 : locked.tenants.extend(tenant_shards.into_iter().map(|p| {
2758 0 : let intent = IntentState::new(Some(load_in_az.clone()));
2759 0 : let shard =
2760 0 : TenantShard::from_persistent(p, intent).expect("Corrupt shard row in database");
2761 0 :
2762 0 : // Sanity check: when loading on-demand, we should always be loaded something Detached
2763 0 : debug_assert!(shard.policy == PlacementPolicy::Detached);
2764 0 : if shard.policy != PlacementPolicy::Detached {
2765 0 : tracing::error!(
2766 0 : "Tenant shard {} loaded on-demand, but has non-Detached policy {:?}",
2767 : shard.tenant_shard_id,
2768 : shard.policy
2769 : );
2770 0 : }
2771 :
2772 0 : (shard.tenant_shard_id, shard)
2773 0 : }));
2774 0 :
2775 0 : Ok(())
2776 0 : }
2777 :
2778 : /// If all shards for a tenant are detached, and in a fully quiescent state (no observed locations on pageservers),
2779 : /// and have no reconciler running, then we can drop the tenant from memory. It will be reloaded on-demand
2780 : /// if we are asked to attach it again (see [`Self::maybe_load_tenant`]).
2781 : ///
2782 : /// Caller must demonstrate they hold a lock guard, as otherwise it is unsafe to drop a tenant from
2783 : /// memory while some other function might assume it continues to exist while not holding the lock on Self::inner.
2784 0 : fn maybe_drop_tenant(
2785 0 : &self,
2786 0 : tenant_id: TenantId,
2787 0 : locked: &mut std::sync::RwLockWriteGuard<ServiceState>,
2788 0 : _guard: &TracingExclusiveGuard<TenantOperations>,
2789 0 : ) {
2790 0 : let mut tenant_shards = locked.tenants.range(TenantShardId::tenant_range(tenant_id));
2791 0 : if tenant_shards.all(|(_id, shard)| {
2792 0 : shard.policy == PlacementPolicy::Detached
2793 0 : && shard.reconciler.is_none()
2794 0 : && shard.observed.is_empty()
2795 0 : }) {
2796 0 : let keys = locked
2797 0 : .tenants
2798 0 : .range(TenantShardId::tenant_range(tenant_id))
2799 0 : .map(|(id, _)| id)
2800 0 : .copied()
2801 0 : .collect::<Vec<_>>();
2802 0 : for key in keys {
2803 0 : tracing::info!("Dropping detached tenant shard {} from memory", key);
2804 0 : locked.tenants.remove(&key);
2805 : }
2806 0 : }
2807 0 : }
2808 :
2809 : /// This API is used by the cloud control plane to migrate unsharded tenants that it created
2810 : /// directly with pageservers into this service.
2811 : ///
2812 : /// Cloud control plane MUST NOT continue issuing GENERATION NUMBERS for this tenant once it
2813 : /// has attempted to call this API. Failure to oblige to this rule may lead to S3 corruption.
2814 : /// Think of the first attempt to call this API as a transfer of absolute authority over the
2815 : /// tenant's source of generation numbers.
2816 : ///
2817 : /// The mode in this request coarse-grained control of tenants:
2818 : /// - Call with mode Attached* to upsert the tenant.
2819 : /// - Call with mode Secondary to either onboard a tenant without attaching it, or
2820 : /// to set an existing tenant to PolicyMode::Secondary
2821 : /// - Call with mode Detached to switch to PolicyMode::Detached
2822 0 : pub(crate) async fn tenant_location_config(
2823 0 : &self,
2824 0 : tenant_shard_id: TenantShardId,
2825 0 : req: TenantLocationConfigRequest,
2826 0 : ) -> Result<TenantLocationConfigResponse, ApiError> {
2827 : // We require an exclusive lock, because we are updating both persistent and in-memory state
2828 0 : let _tenant_lock = trace_exclusive_lock(
2829 0 : &self.tenant_op_locks,
2830 0 : tenant_shard_id.tenant_id,
2831 0 : TenantOperations::LocationConfig,
2832 0 : )
2833 0 : .await;
2834 :
2835 0 : let tenant_id = if !tenant_shard_id.is_unsharded() {
2836 0 : return Err(ApiError::BadRequest(anyhow::anyhow!(
2837 0 : "This API is for importing single-sharded or unsharded tenants"
2838 0 : )));
2839 : } else {
2840 0 : tenant_shard_id.tenant_id
2841 0 : };
2842 0 :
2843 0 : // In case we are waking up a Detached tenant
2844 0 : match self.maybe_load_tenant(tenant_id, &_tenant_lock).await {
2845 0 : Ok(()) | Err(ApiError::NotFound(_)) => {
2846 0 : // This is a creation or an update
2847 0 : }
2848 0 : Err(e) => {
2849 0 : return Err(e);
2850 : }
2851 : };
2852 :
2853 : // First check if this is a creation or an update
2854 0 : let create_or_update = self.tenant_location_config_prepare(tenant_id, req);
2855 0 :
2856 0 : let mut result = TenantLocationConfigResponse {
2857 0 : shards: Vec::new(),
2858 0 : stripe_size: None,
2859 0 : };
2860 0 : let waiters = match create_or_update {
2861 0 : TenantCreateOrUpdate::Create(create_req) => {
2862 0 : let (create_resp, waiters) = self.do_tenant_create(create_req).await?;
2863 0 : result.shards = create_resp
2864 0 : .shards
2865 0 : .into_iter()
2866 0 : .map(|s| TenantShardLocation {
2867 0 : node_id: s.node_id,
2868 0 : shard_id: s.shard_id,
2869 0 : })
2870 0 : .collect();
2871 0 : waiters
2872 : }
2873 0 : TenantCreateOrUpdate::Update(updates) => {
2874 0 : // Persist updates
2875 0 : // Ordering: write to the database before applying changes in-memory, so that
2876 0 : // we will not appear time-travel backwards on a restart.
2877 0 :
2878 0 : let mut schedule_context = ScheduleContext::default();
2879 : for ShardUpdate {
2880 0 : tenant_shard_id,
2881 0 : placement_policy,
2882 0 : tenant_config,
2883 0 : generation,
2884 0 : scheduling_policy,
2885 0 : } in &updates
2886 : {
2887 0 : self.persistence
2888 0 : .update_tenant_shard(
2889 0 : TenantFilter::Shard(*tenant_shard_id),
2890 0 : Some(placement_policy.clone()),
2891 0 : Some(tenant_config.clone()),
2892 0 : *generation,
2893 0 : *scheduling_policy,
2894 0 : )
2895 0 : .await?;
2896 : }
2897 :
2898 : // Apply updates in-memory
2899 0 : let mut waiters = Vec::new();
2900 0 : {
2901 0 : let mut locked = self.inner.write().unwrap();
2902 0 : let (nodes, tenants, scheduler) = locked.parts_mut();
2903 :
2904 : for ShardUpdate {
2905 0 : tenant_shard_id,
2906 0 : placement_policy,
2907 0 : tenant_config,
2908 0 : generation: update_generation,
2909 0 : scheduling_policy,
2910 0 : } in updates
2911 : {
2912 0 : let Some(shard) = tenants.get_mut(&tenant_shard_id) else {
2913 0 : tracing::warn!("Shard {tenant_shard_id} removed while updating");
2914 0 : continue;
2915 : };
2916 :
2917 : // Update stripe size
2918 0 : if result.stripe_size.is_none() && shard.shard.count.count() > 1 {
2919 0 : result.stripe_size = Some(shard.shard.stripe_size);
2920 0 : }
2921 :
2922 0 : shard.policy = placement_policy;
2923 0 : shard.config = tenant_config;
2924 0 : if let Some(generation) = update_generation {
2925 0 : shard.generation = Some(generation);
2926 0 : }
2927 :
2928 0 : if let Some(scheduling_policy) = scheduling_policy {
2929 0 : shard.set_scheduling_policy(scheduling_policy);
2930 0 : }
2931 :
2932 0 : shard.schedule(scheduler, &mut schedule_context)?;
2933 :
2934 0 : let maybe_waiter =
2935 0 : self.maybe_reconcile_shard(shard, nodes, ReconcilerPriority::High);
2936 0 : if let Some(waiter) = maybe_waiter {
2937 0 : waiters.push(waiter);
2938 0 : }
2939 :
2940 0 : if let Some(node_id) = shard.intent.get_attached() {
2941 0 : result.shards.push(TenantShardLocation {
2942 0 : shard_id: tenant_shard_id,
2943 0 : node_id: *node_id,
2944 0 : })
2945 0 : }
2946 : }
2947 : }
2948 0 : waiters
2949 : }
2950 : };
2951 :
2952 0 : if let Err(e) = self.await_waiters(waiters, SHORT_RECONCILE_TIMEOUT).await {
2953 : // Do not treat a reconcile error as fatal: we have already applied any requested
2954 : // Intent changes, and the reconcile can fail for external reasons like unavailable
2955 : // compute notification API. In these cases, it is important that we do not
2956 : // cause the cloud control plane to retry forever on this API.
2957 0 : tracing::warn!(
2958 0 : "Failed to reconcile after /location_config: {e}, returning success anyway"
2959 : );
2960 0 : }
2961 :
2962 : // Logging the full result is useful because it lets us cross-check what the cloud control
2963 : // plane's tenant_shards table should contain.
2964 0 : tracing::info!("Complete, returning {result:?}");
2965 :
2966 0 : Ok(result)
2967 0 : }
2968 :
2969 0 : pub(crate) async fn tenant_config_patch(
2970 0 : &self,
2971 0 : req: TenantConfigPatchRequest,
2972 0 : ) -> Result<(), ApiError> {
2973 0 : let _tenant_lock = trace_exclusive_lock(
2974 0 : &self.tenant_op_locks,
2975 0 : req.tenant_id,
2976 0 : TenantOperations::ConfigPatch,
2977 0 : )
2978 0 : .await;
2979 :
2980 0 : let tenant_id = req.tenant_id;
2981 0 : let patch = req.config;
2982 0 :
2983 0 : self.maybe_load_tenant(tenant_id, &_tenant_lock).await?;
2984 :
2985 0 : let base = {
2986 0 : let locked = self.inner.read().unwrap();
2987 0 : let shards = locked
2988 0 : .tenants
2989 0 : .range(TenantShardId::tenant_range(req.tenant_id));
2990 0 :
2991 0 : let mut configs = shards.map(|(_sid, shard)| &shard.config).peekable();
2992 :
2993 0 : let first = match configs.peek() {
2994 0 : Some(first) => (*first).clone(),
2995 : None => {
2996 0 : return Err(ApiError::NotFound(
2997 0 : anyhow::anyhow!("Tenant {} not found", req.tenant_id).into(),
2998 0 : ));
2999 : }
3000 : };
3001 :
3002 0 : if !configs.all_equal() {
3003 0 : tracing::error!("Tenant configs for {} are mismatched. ", req.tenant_id);
3004 : // This can't happen because we atomically update the database records
3005 : // of all shards to the new value in [`Self::set_tenant_config_and_reconcile`].
3006 0 : return Err(ApiError::InternalServerError(anyhow::anyhow!(
3007 0 : "Tenant configs for {} are mismatched",
3008 0 : req.tenant_id
3009 0 : )));
3010 0 : }
3011 0 :
3012 0 : first
3013 : };
3014 :
3015 0 : let updated_config = base
3016 0 : .apply_patch(patch)
3017 0 : .map_err(|err| ApiError::BadRequest(anyhow::anyhow!(err)))?;
3018 0 : self.set_tenant_config_and_reconcile(tenant_id, updated_config)
3019 0 : .await
3020 0 : }
3021 :
3022 0 : pub(crate) async fn tenant_config_set(&self, req: TenantConfigRequest) -> Result<(), ApiError> {
3023 : // We require an exclusive lock, because we are updating persistent and in-memory state
3024 0 : let _tenant_lock = trace_exclusive_lock(
3025 0 : &self.tenant_op_locks,
3026 0 : req.tenant_id,
3027 0 : TenantOperations::ConfigSet,
3028 0 : )
3029 0 : .await;
3030 :
3031 0 : self.maybe_load_tenant(req.tenant_id, &_tenant_lock).await?;
3032 :
3033 0 : self.set_tenant_config_and_reconcile(req.tenant_id, req.config)
3034 0 : .await
3035 0 : }
3036 :
3037 0 : async fn set_tenant_config_and_reconcile(
3038 0 : &self,
3039 0 : tenant_id: TenantId,
3040 0 : config: TenantConfig,
3041 0 : ) -> Result<(), ApiError> {
3042 0 : self.persistence
3043 0 : .update_tenant_shard(
3044 0 : TenantFilter::Tenant(tenant_id),
3045 0 : None,
3046 0 : Some(config.clone()),
3047 0 : None,
3048 0 : None,
3049 0 : )
3050 0 : .await?;
3051 :
3052 0 : let waiters = {
3053 0 : let mut waiters = Vec::new();
3054 0 : let mut locked = self.inner.write().unwrap();
3055 0 : let (nodes, tenants, _scheduler) = locked.parts_mut();
3056 0 : for (_shard_id, shard) in tenants.range_mut(TenantShardId::tenant_range(tenant_id)) {
3057 0 : shard.config = config.clone();
3058 0 : if let Some(waiter) =
3059 0 : self.maybe_reconcile_shard(shard, nodes, ReconcilerPriority::High)
3060 0 : {
3061 0 : waiters.push(waiter);
3062 0 : }
3063 : }
3064 0 : waiters
3065 : };
3066 :
3067 0 : if let Err(e) = self.await_waiters(waiters, SHORT_RECONCILE_TIMEOUT).await {
3068 : // Treat this as success because we have stored the configuration. If e.g.
3069 : // a node was unavailable at this time, it should not stop us accepting a
3070 : // configuration change.
3071 0 : tracing::warn!(%tenant_id, "Accepted configuration update but reconciliation failed: {e}");
3072 0 : }
3073 :
3074 0 : Ok(())
3075 0 : }
3076 :
3077 0 : pub(crate) fn tenant_config_get(
3078 0 : &self,
3079 0 : tenant_id: TenantId,
3080 0 : ) -> Result<HashMap<&str, serde_json::Value>, ApiError> {
3081 0 : let config = {
3082 0 : let locked = self.inner.read().unwrap();
3083 0 :
3084 0 : match locked
3085 0 : .tenants
3086 0 : .range(TenantShardId::tenant_range(tenant_id))
3087 0 : .next()
3088 : {
3089 0 : Some((_tenant_shard_id, shard)) => shard.config.clone(),
3090 : None => {
3091 0 : return Err(ApiError::NotFound(
3092 0 : anyhow::anyhow!("Tenant not found").into(),
3093 0 : ));
3094 : }
3095 : }
3096 : };
3097 :
3098 : // Unlike the pageserver, we do not have a set of global defaults: the config is
3099 : // entirely per-tenant. Therefore the distinction between `tenant_specific_overrides`
3100 : // and `effective_config` in the response is meaningless, but we retain that syntax
3101 : // in order to remain compatible with the pageserver API.
3102 :
3103 0 : let response = HashMap::from([
3104 : (
3105 : "tenant_specific_overrides",
3106 0 : serde_json::to_value(&config)
3107 0 : .context("serializing tenant specific overrides")
3108 0 : .map_err(ApiError::InternalServerError)?,
3109 : ),
3110 : (
3111 0 : "effective_config",
3112 0 : serde_json::to_value(&config)
3113 0 : .context("serializing effective config")
3114 0 : .map_err(ApiError::InternalServerError)?,
3115 : ),
3116 : ]);
3117 :
3118 0 : Ok(response)
3119 0 : }
3120 :
3121 0 : pub(crate) async fn tenant_time_travel_remote_storage(
3122 0 : &self,
3123 0 : time_travel_req: &TenantTimeTravelRequest,
3124 0 : tenant_id: TenantId,
3125 0 : timestamp: Cow<'_, str>,
3126 0 : done_if_after: Cow<'_, str>,
3127 0 : ) -> Result<(), ApiError> {
3128 0 : let _tenant_lock = trace_exclusive_lock(
3129 0 : &self.tenant_op_locks,
3130 0 : tenant_id,
3131 0 : TenantOperations::TimeTravelRemoteStorage,
3132 0 : )
3133 0 : .await;
3134 :
3135 0 : let node = {
3136 0 : let mut locked = self.inner.write().unwrap();
3137 : // Just a sanity check to prevent misuse: the API expects that the tenant is fully
3138 : // detached everywhere, and nothing writes to S3 storage. Here, we verify that,
3139 : // but only at the start of the process, so it's really just to prevent operator
3140 : // mistakes.
3141 0 : for (shard_id, shard) in locked.tenants.range(TenantShardId::tenant_range(tenant_id)) {
3142 0 : if shard.intent.get_attached().is_some() || !shard.intent.get_secondary().is_empty()
3143 : {
3144 0 : return Err(ApiError::InternalServerError(anyhow::anyhow!(
3145 0 : "We want tenant to be attached in shard with tenant_shard_id={shard_id}"
3146 0 : )));
3147 0 : }
3148 0 : let maybe_attached = shard
3149 0 : .observed
3150 0 : .locations
3151 0 : .iter()
3152 0 : .filter_map(|(node_id, observed_location)| {
3153 0 : observed_location
3154 0 : .conf
3155 0 : .as_ref()
3156 0 : .map(|loc| (node_id, observed_location, loc.mode))
3157 0 : })
3158 0 : .find(|(_, _, mode)| *mode != LocationConfigMode::Detached);
3159 0 : if let Some((node_id, _observed_location, mode)) = maybe_attached {
3160 0 : return Err(ApiError::InternalServerError(anyhow::anyhow!(
3161 0 : "We observed attached={mode:?} tenant in node_id={node_id} shard with tenant_shard_id={shard_id}"
3162 0 : )));
3163 0 : }
3164 : }
3165 0 : let scheduler = &mut locked.scheduler;
3166 : // Right now we only perform the operation on a single node without parallelization
3167 : // TODO fan out the operation to multiple nodes for better performance
3168 0 : let node_id = scheduler.any_available_node()?;
3169 0 : let node = locked
3170 0 : .nodes
3171 0 : .get(&node_id)
3172 0 : .expect("Pageservers may not be deleted while lock is active");
3173 0 : node.clone()
3174 0 : };
3175 0 :
3176 0 : // The shard count is encoded in the remote storage's URL, so we need to handle all historically used shard counts
3177 0 : let mut counts = time_travel_req
3178 0 : .shard_counts
3179 0 : .iter()
3180 0 : .copied()
3181 0 : .collect::<HashSet<_>>()
3182 0 : .into_iter()
3183 0 : .collect::<Vec<_>>();
3184 0 : counts.sort_unstable();
3185 :
3186 0 : for count in counts {
3187 0 : let shard_ids = (0..count.count())
3188 0 : .map(|i| TenantShardId {
3189 0 : tenant_id,
3190 0 : shard_number: ShardNumber(i),
3191 0 : shard_count: count,
3192 0 : })
3193 0 : .collect::<Vec<_>>();
3194 0 : for tenant_shard_id in shard_ids {
3195 0 : let client = PageserverClient::new(
3196 0 : node.get_id(),
3197 0 : node.base_url(),
3198 0 : self.config.pageserver_jwt_token.as_deref(),
3199 0 : self.config.ssl_ca_cert.clone(),
3200 0 : )
3201 0 : .map_err(|e| passthrough_api_error(&node, e))?;
3202 :
3203 0 : tracing::info!("Doing time travel recovery for shard {tenant_shard_id}",);
3204 :
3205 0 : client
3206 0 : .tenant_time_travel_remote_storage(
3207 0 : tenant_shard_id,
3208 0 : ×tamp,
3209 0 : &done_if_after,
3210 0 : )
3211 0 : .await
3212 0 : .map_err(|e| {
3213 0 : ApiError::InternalServerError(anyhow::anyhow!(
3214 0 : "Error doing time travel recovery for shard {tenant_shard_id} on node {}: {e}",
3215 0 : node
3216 0 : ))
3217 0 : })?;
3218 : }
3219 : }
3220 0 : Ok(())
3221 0 : }
3222 :
3223 0 : pub(crate) async fn tenant_secondary_download(
3224 0 : &self,
3225 0 : tenant_id: TenantId,
3226 0 : wait: Option<Duration>,
3227 0 : ) -> Result<(StatusCode, SecondaryProgress), ApiError> {
3228 0 : let _tenant_lock = trace_shared_lock(
3229 0 : &self.tenant_op_locks,
3230 0 : tenant_id,
3231 0 : TenantOperations::SecondaryDownload,
3232 0 : )
3233 0 : .await;
3234 :
3235 : // Acquire lock and yield the collection of shard-node tuples which we will send requests onward to
3236 0 : let targets = {
3237 0 : let locked = self.inner.read().unwrap();
3238 0 : let mut targets = Vec::new();
3239 :
3240 0 : for (tenant_shard_id, shard) in
3241 0 : locked.tenants.range(TenantShardId::tenant_range(tenant_id))
3242 : {
3243 0 : for node_id in shard.intent.get_secondary() {
3244 0 : let node = locked
3245 0 : .nodes
3246 0 : .get(node_id)
3247 0 : .expect("Pageservers may not be deleted while referenced");
3248 0 :
3249 0 : targets.push((*tenant_shard_id, node.clone()));
3250 0 : }
3251 : }
3252 0 : targets
3253 0 : };
3254 0 :
3255 0 : // Issue concurrent requests to all shards' locations
3256 0 : let mut futs = FuturesUnordered::new();
3257 0 : for (tenant_shard_id, node) in targets {
3258 0 : let client = PageserverClient::new(
3259 0 : node.get_id(),
3260 0 : node.base_url(),
3261 0 : self.config.pageserver_jwt_token.as_deref(),
3262 0 : self.config.ssl_ca_cert.clone(),
3263 0 : )
3264 0 : .map_err(|e| passthrough_api_error(&node, e))?;
3265 0 : futs.push(async move {
3266 0 : let result = client
3267 0 : .tenant_secondary_download(tenant_shard_id, wait)
3268 0 : .await;
3269 0 : (result, node, tenant_shard_id)
3270 0 : })
3271 : }
3272 :
3273 : // Handle any errors returned by pageservers. This includes cases like this request racing with
3274 : // a scheduling operation, such that the tenant shard we're calling doesn't exist on that pageserver any more, as
3275 : // well as more general cases like 503s, 500s, or timeouts.
3276 0 : let mut aggregate_progress = SecondaryProgress::default();
3277 0 : let mut aggregate_status: Option<StatusCode> = None;
3278 0 : let mut error: Option<mgmt_api::Error> = None;
3279 0 : while let Some((result, node, tenant_shard_id)) = futs.next().await {
3280 0 : match result {
3281 0 : Err(e) => {
3282 0 : // Secondary downloads are always advisory: if something fails, we nevertheless report success, so that whoever
3283 0 : // is calling us will proceed with whatever migration they're doing, albeit with a slightly less warm cache
3284 0 : // than they had hoped for.
3285 0 : tracing::warn!("Secondary download error from pageserver {node}: {e}",);
3286 0 : error = Some(e)
3287 : }
3288 0 : Ok((status_code, progress)) => {
3289 0 : tracing::info!(%tenant_shard_id, "Shard status={status_code} progress: {progress:?}");
3290 0 : aggregate_progress.layers_downloaded += progress.layers_downloaded;
3291 0 : aggregate_progress.layers_total += progress.layers_total;
3292 0 : aggregate_progress.bytes_downloaded += progress.bytes_downloaded;
3293 0 : aggregate_progress.bytes_total += progress.bytes_total;
3294 0 : aggregate_progress.heatmap_mtime =
3295 0 : std::cmp::max(aggregate_progress.heatmap_mtime, progress.heatmap_mtime);
3296 0 : aggregate_status = match aggregate_status {
3297 0 : None => Some(status_code),
3298 0 : Some(StatusCode::OK) => Some(status_code),
3299 0 : Some(cur) => {
3300 0 : // Other status codes (e.g. 202) -- do not overwrite.
3301 0 : Some(cur)
3302 : }
3303 : };
3304 : }
3305 : }
3306 : }
3307 :
3308 : // If any of the shards return 202, indicate our result as 202.
3309 0 : match aggregate_status {
3310 : None => {
3311 0 : match error {
3312 0 : Some(e) => {
3313 0 : // No successes, and an error: surface it
3314 0 : Err(ApiError::Conflict(format!("Error from pageserver: {e}")))
3315 : }
3316 : None => {
3317 : // No shards found
3318 0 : Err(ApiError::NotFound(
3319 0 : anyhow::anyhow!("Tenant {} not found", tenant_id).into(),
3320 0 : ))
3321 : }
3322 : }
3323 : }
3324 0 : Some(aggregate_status) => Ok((aggregate_status, aggregate_progress)),
3325 : }
3326 0 : }
3327 :
3328 0 : pub(crate) async fn tenant_delete(
3329 0 : self: &Arc<Self>,
3330 0 : tenant_id: TenantId,
3331 0 : ) -> Result<StatusCode, ApiError> {
3332 0 : let _tenant_lock =
3333 0 : trace_exclusive_lock(&self.tenant_op_locks, tenant_id, TenantOperations::Delete).await;
3334 :
3335 0 : self.maybe_load_tenant(tenant_id, &_tenant_lock).await?;
3336 :
3337 : // Detach all shards. This also deletes local pageserver shard data.
3338 0 : let (detach_waiters, node) = {
3339 0 : let mut detach_waiters = Vec::new();
3340 0 : let mut locked = self.inner.write().unwrap();
3341 0 : let (nodes, tenants, scheduler) = locked.parts_mut();
3342 0 : for (_, shard) in tenants.range_mut(TenantShardId::tenant_range(tenant_id)) {
3343 : // Update the tenant's intent to remove all attachments
3344 0 : shard.policy = PlacementPolicy::Detached;
3345 0 : shard
3346 0 : .schedule(scheduler, &mut ScheduleContext::default())
3347 0 : .expect("De-scheduling is infallible");
3348 0 : debug_assert!(shard.intent.get_attached().is_none());
3349 0 : debug_assert!(shard.intent.get_secondary().is_empty());
3350 :
3351 0 : if let Some(waiter) =
3352 0 : self.maybe_reconcile_shard(shard, nodes, ReconcilerPriority::High)
3353 0 : {
3354 0 : detach_waiters.push(waiter);
3355 0 : }
3356 : }
3357 :
3358 : // Pick an arbitrary node to use for remote deletions (does not have to be where the tenant
3359 : // was attached, just has to be able to see the S3 content)
3360 0 : let node_id = scheduler.any_available_node()?;
3361 0 : let node = nodes
3362 0 : .get(&node_id)
3363 0 : .expect("Pageservers may not be deleted while lock is active");
3364 0 : (detach_waiters, node.clone())
3365 0 : };
3366 0 :
3367 0 : // This reconcile wait can fail in a few ways:
3368 0 : // A there is a very long queue for the reconciler semaphore
3369 0 : // B some pageserver is failing to handle a detach promptly
3370 0 : // C some pageserver goes offline right at the moment we send it a request.
3371 0 : //
3372 0 : // A and C are transient: the semaphore will eventually become available, and once a node is marked offline
3373 0 : // the next attempt to reconcile will silently skip detaches for an offline node and succeed. If B happens,
3374 0 : // it's a bug, and needs resolving at the pageserver level (we shouldn't just leave attachments behind while
3375 0 : // deleting the underlying data).
3376 0 : self.await_waiters(detach_waiters, RECONCILE_TIMEOUT)
3377 0 : .await?;
3378 :
3379 : // Delete the entire tenant (all shards) from remote storage via a random pageserver.
3380 : // Passing an unsharded tenant ID will cause the pageserver to remove all remote paths with
3381 : // the tenant ID prefix, including all shards (even possibly stale ones).
3382 0 : match node
3383 0 : .with_client_retries(
3384 0 : |client| async move {
3385 0 : client
3386 0 : .tenant_delete(TenantShardId::unsharded(tenant_id))
3387 0 : .await
3388 0 : },
3389 0 : &self.config.pageserver_jwt_token,
3390 0 : &self.config.ssl_ca_cert,
3391 0 : 1,
3392 0 : 3,
3393 0 : RECONCILE_TIMEOUT,
3394 0 : &self.cancel,
3395 0 : )
3396 0 : .await
3397 0 : .unwrap_or(Err(mgmt_api::Error::Cancelled))
3398 : {
3399 0 : Ok(_) => {}
3400 : Err(mgmt_api::Error::Cancelled) => {
3401 0 : return Err(ApiError::ShuttingDown);
3402 : }
3403 0 : Err(e) => {
3404 0 : // This is unexpected: remote deletion should be infallible, unless the object store
3405 0 : // at large is unavailable.
3406 0 : tracing::error!("Error deleting via node {node}: {e}");
3407 0 : return Err(ApiError::InternalServerError(anyhow::anyhow!(e)));
3408 : }
3409 : }
3410 :
3411 : // Fall through: deletion of the tenant on pageservers is complete, we may proceed to drop
3412 : // our in-memory state and database state.
3413 :
3414 : // Ordering: we delete persistent state first: if we then
3415 : // crash, we will drop the in-memory state.
3416 :
3417 : // Drop persistent state.
3418 0 : self.persistence.delete_tenant(tenant_id).await?;
3419 :
3420 : // Drop in-memory state
3421 : {
3422 0 : let mut locked = self.inner.write().unwrap();
3423 0 : let (_nodes, tenants, scheduler) = locked.parts_mut();
3424 :
3425 : // Dereference Scheduler from shards before dropping them
3426 0 : for (_tenant_shard_id, shard) in
3427 0 : tenants.range_mut(TenantShardId::tenant_range(tenant_id))
3428 0 : {
3429 0 : shard.intent.clear(scheduler);
3430 0 : }
3431 :
3432 0 : tenants.retain(|tenant_shard_id, _shard| tenant_shard_id.tenant_id != tenant_id);
3433 0 : tracing::info!(
3434 0 : "Deleted tenant {tenant_id}, now have {} tenants",
3435 0 : locked.tenants.len()
3436 : );
3437 : };
3438 :
3439 : // Delete the tenant from safekeepers (if needed)
3440 0 : self.tenant_delete_safekeepers(tenant_id)
3441 0 : .instrument(tracing::info_span!("tenant_delete_safekeepers", %tenant_id))
3442 0 : .await?;
3443 :
3444 : // Success is represented as 404, to imitate the existing pageserver deletion API
3445 0 : Ok(StatusCode::NOT_FOUND)
3446 0 : }
3447 :
3448 : /// Naming: this configures the storage controller's policies for a tenant, whereas [`Self::tenant_config_set`] is "set the TenantConfig"
3449 : /// for a tenant. The TenantConfig is passed through to pageservers, whereas this function modifies
3450 : /// the tenant's policies (configuration) within the storage controller
3451 0 : pub(crate) async fn tenant_update_policy(
3452 0 : &self,
3453 0 : tenant_id: TenantId,
3454 0 : req: TenantPolicyRequest,
3455 0 : ) -> Result<(), ApiError> {
3456 : // We require an exclusive lock, because we are updating persistent and in-memory state
3457 0 : let _tenant_lock = trace_exclusive_lock(
3458 0 : &self.tenant_op_locks,
3459 0 : tenant_id,
3460 0 : TenantOperations::UpdatePolicy,
3461 0 : )
3462 0 : .await;
3463 :
3464 0 : self.maybe_load_tenant(tenant_id, &_tenant_lock).await?;
3465 :
3466 0 : failpoint_support::sleep_millis_async!("tenant-update-policy-exclusive-lock");
3467 :
3468 : let TenantPolicyRequest {
3469 0 : placement,
3470 0 : mut scheduling,
3471 0 : } = req;
3472 :
3473 0 : if let Some(PlacementPolicy::Detached | PlacementPolicy::Secondary) = placement {
3474 : // When someone configures a tenant to detach, we force the scheduling policy to enable
3475 : // this to take effect.
3476 0 : if scheduling.is_none() {
3477 0 : scheduling = Some(ShardSchedulingPolicy::Active);
3478 0 : }
3479 0 : }
3480 :
3481 0 : self.persistence
3482 0 : .update_tenant_shard(
3483 0 : TenantFilter::Tenant(tenant_id),
3484 0 : placement.clone(),
3485 0 : None,
3486 0 : None,
3487 0 : scheduling,
3488 0 : )
3489 0 : .await?;
3490 :
3491 0 : let mut schedule_context = ScheduleContext::default();
3492 0 : let mut locked = self.inner.write().unwrap();
3493 0 : let (nodes, tenants, scheduler) = locked.parts_mut();
3494 0 : for (shard_id, shard) in tenants.range_mut(TenantShardId::tenant_range(tenant_id)) {
3495 0 : if let Some(placement) = &placement {
3496 0 : shard.policy = placement.clone();
3497 0 :
3498 0 : tracing::info!(tenant_id=%shard_id.tenant_id, shard_id=%shard_id.shard_slug(),
3499 0 : "Updated placement policy to {placement:?}");
3500 0 : }
3501 :
3502 0 : if let Some(scheduling) = &scheduling {
3503 0 : shard.set_scheduling_policy(*scheduling);
3504 0 :
3505 0 : tracing::info!(tenant_id=%shard_id.tenant_id, shard_id=%shard_id.shard_slug(),
3506 0 : "Updated scheduling policy to {scheduling:?}");
3507 0 : }
3508 :
3509 : // In case scheduling is being switched back on, try it now.
3510 0 : shard.schedule(scheduler, &mut schedule_context).ok();
3511 0 : self.maybe_reconcile_shard(shard, nodes, ReconcilerPriority::High);
3512 : }
3513 :
3514 0 : Ok(())
3515 0 : }
3516 :
3517 0 : pub(crate) async fn tenant_timeline_create_pageservers(
3518 0 : &self,
3519 0 : tenant_id: TenantId,
3520 0 : mut create_req: TimelineCreateRequest,
3521 0 : ) -> Result<TimelineInfo, ApiError> {
3522 0 : tracing::info!(
3523 0 : "Creating timeline {}/{}",
3524 : tenant_id,
3525 : create_req.new_timeline_id,
3526 : );
3527 :
3528 0 : self.tenant_remote_mutation(tenant_id, move |mut targets| async move {
3529 0 : if targets.0.is_empty() {
3530 0 : return Err(ApiError::NotFound(
3531 0 : anyhow::anyhow!("Tenant not found").into(),
3532 0 : ));
3533 0 : };
3534 0 :
3535 0 : let (shard_zero_tid, shard_zero_locations) =
3536 0 : targets.0.pop_first().expect("Must have at least one shard");
3537 0 : assert!(shard_zero_tid.is_shard_zero());
3538 :
3539 0 : async fn create_one(
3540 0 : tenant_shard_id: TenantShardId,
3541 0 : locations: ShardMutationLocations,
3542 0 : jwt: Option<String>,
3543 0 : ssl_ca_cert: Option<Certificate>,
3544 0 : create_req: TimelineCreateRequest,
3545 0 : ) -> Result<TimelineInfo, ApiError> {
3546 0 : let latest = locations.latest.node;
3547 0 :
3548 0 : tracing::info!(
3549 0 : "Creating timeline on shard {}/{}, attached to node {latest} in generation {:?}",
3550 : tenant_shard_id,
3551 : create_req.new_timeline_id,
3552 : locations.latest.generation
3553 : );
3554 :
3555 0 : let client =
3556 0 : PageserverClient::new(latest.get_id(), latest.base_url(), jwt.as_deref(), ssl_ca_cert.clone())
3557 0 : .map_err(|e| passthrough_api_error(&latest, e))?;
3558 :
3559 0 : let timeline_info = client
3560 0 : .timeline_create(tenant_shard_id, &create_req)
3561 0 : .await
3562 0 : .map_err(|e| passthrough_api_error(&latest, e))?;
3563 :
3564 : // We propagate timeline creations to all attached locations such that a compute
3565 : // for the new timeline is able to start regardless of the current state of the
3566 : // tenant shard reconciliation.
3567 0 : for location in locations.other {
3568 0 : tracing::info!(
3569 0 : "Creating timeline on shard {}/{}, stale attached to node {} in generation {:?}",
3570 : tenant_shard_id,
3571 : create_req.new_timeline_id,
3572 : location.node,
3573 : location.generation
3574 : );
3575 :
3576 0 : let client = PageserverClient::new(
3577 0 : location.node.get_id(),
3578 0 : location.node.base_url(),
3579 0 : jwt.as_deref(),
3580 0 : ssl_ca_cert.clone(),
3581 0 : )
3582 0 : .map_err(|e| passthrough_api_error(&location.node, e))?;
3583 :
3584 0 : let res = client
3585 0 : .timeline_create(tenant_shard_id, &create_req)
3586 0 : .await;
3587 :
3588 0 : if let Err(e) = res {
3589 0 : match e {
3590 0 : mgmt_api::Error::ApiError(StatusCode::NOT_FOUND, _) => {
3591 0 : // Tenant might have been detached from the stale location,
3592 0 : // so ignore 404s.
3593 0 : },
3594 : _ => {
3595 0 : return Err(passthrough_api_error(&location.node, e));
3596 : }
3597 : }
3598 0 : }
3599 : }
3600 :
3601 0 : Ok(timeline_info)
3602 0 : }
3603 :
3604 : // Because the caller might not provide an explicit LSN, we must do the creation first on a single shard, and then
3605 : // use whatever LSN that shard picked when creating on subsequent shards. We arbitrarily use shard zero as the shard
3606 : // that will get the first creation request, and propagate the LSN to all the >0 shards.
3607 0 : let timeline_info = create_one(
3608 0 : shard_zero_tid,
3609 0 : shard_zero_locations,
3610 0 : self.config.pageserver_jwt_token.clone(),
3611 0 : self.config.ssl_ca_cert.clone(),
3612 0 : create_req.clone(),
3613 0 : )
3614 0 : .await?;
3615 :
3616 : // Propagate the LSN that shard zero picked, if caller didn't provide one
3617 0 : match &mut create_req.mode {
3618 0 : models::TimelineCreateRequestMode::Branch { ancestor_start_lsn, .. } if ancestor_start_lsn.is_none() => {
3619 0 : *ancestor_start_lsn = timeline_info.ancestor_lsn;
3620 0 : },
3621 0 : _ => {}
3622 : }
3623 :
3624 : // Create timeline on remaining shards with number >0
3625 0 : if !targets.0.is_empty() {
3626 : // If we had multiple shards, issue requests for the remainder now.
3627 0 : let jwt = &self.config.pageserver_jwt_token;
3628 0 : self.tenant_for_shards(
3629 0 : targets
3630 0 : .0
3631 0 : .iter()
3632 0 : .map(|t| (*t.0, t.1.latest.node.clone()))
3633 0 : .collect(),
3634 0 : |tenant_shard_id: TenantShardId, _node: Node| {
3635 0 : let create_req = create_req.clone();
3636 0 : let mutation_locations = targets.0.remove(&tenant_shard_id).unwrap();
3637 0 : Box::pin(create_one(
3638 0 : tenant_shard_id,
3639 0 : mutation_locations,
3640 0 : jwt.clone(),
3641 0 : self.config.ssl_ca_cert.clone(),
3642 0 : create_req,
3643 0 : ))
3644 0 : },
3645 0 : )
3646 0 : .await?;
3647 0 : }
3648 :
3649 0 : Ok(timeline_info)
3650 0 : })
3651 0 : .await?
3652 0 : }
3653 :
3654 0 : pub(crate) async fn tenant_timeline_create(
3655 0 : self: &Arc<Self>,
3656 0 : tenant_id: TenantId,
3657 0 : create_req: TimelineCreateRequest,
3658 0 : ) -> Result<TimelineCreateResponseStorcon, ApiError> {
3659 0 : let safekeepers = self.config.timelines_onto_safekeepers;
3660 0 : tracing::info!(
3661 : %safekeepers,
3662 0 : "Creating timeline {}/{}",
3663 : tenant_id,
3664 : create_req.new_timeline_id,
3665 : );
3666 :
3667 0 : let _tenant_lock = trace_shared_lock(
3668 0 : &self.tenant_op_locks,
3669 0 : tenant_id,
3670 0 : TenantOperations::TimelineCreate,
3671 0 : )
3672 0 : .await;
3673 0 : failpoint_support::sleep_millis_async!("tenant-create-timeline-shared-lock");
3674 0 : let create_mode = create_req.mode.clone();
3675 :
3676 0 : let timeline_info = self
3677 0 : .tenant_timeline_create_pageservers(tenant_id, create_req)
3678 0 : .await?;
3679 :
3680 0 : let safekeepers = if safekeepers {
3681 0 : let res = self
3682 0 : .tenant_timeline_create_safekeepers(tenant_id, &timeline_info, create_mode)
3683 0 : .instrument(tracing::info_span!("timeline_create_safekeepers", %tenant_id, timeline_id=%timeline_info.timeline_id))
3684 0 : .await?;
3685 0 : Some(res)
3686 : } else {
3687 0 : None
3688 : };
3689 :
3690 0 : Ok(TimelineCreateResponseStorcon {
3691 0 : timeline_info,
3692 0 : safekeepers,
3693 0 : })
3694 0 : }
3695 :
3696 0 : pub(crate) async fn tenant_timeline_archival_config(
3697 0 : &self,
3698 0 : tenant_id: TenantId,
3699 0 : timeline_id: TimelineId,
3700 0 : req: TimelineArchivalConfigRequest,
3701 0 : ) -> Result<(), ApiError> {
3702 0 : tracing::info!(
3703 0 : "Setting archival config of timeline {tenant_id}/{timeline_id} to '{:?}'",
3704 : req.state
3705 : );
3706 :
3707 0 : let _tenant_lock = trace_shared_lock(
3708 0 : &self.tenant_op_locks,
3709 0 : tenant_id,
3710 0 : TenantOperations::TimelineArchivalConfig,
3711 0 : )
3712 0 : .await;
3713 :
3714 0 : self.tenant_remote_mutation(tenant_id, move |targets| async move {
3715 0 : if targets.0.is_empty() {
3716 0 : return Err(ApiError::NotFound(
3717 0 : anyhow::anyhow!("Tenant not found").into(),
3718 0 : ));
3719 0 : }
3720 0 : async fn config_one(
3721 0 : tenant_shard_id: TenantShardId,
3722 0 : timeline_id: TimelineId,
3723 0 : node: Node,
3724 0 : jwt: Option<String>,
3725 0 : ssl_ca_cert: Option<Certificate>,
3726 0 : req: TimelineArchivalConfigRequest,
3727 0 : ) -> Result<(), ApiError> {
3728 0 : tracing::info!(
3729 0 : "Setting archival config of timeline on shard {tenant_shard_id}/{timeline_id}, attached to node {node}",
3730 : );
3731 :
3732 0 : let client = PageserverClient::new(node.get_id(), node.base_url(), jwt.as_deref(), ssl_ca_cert)
3733 0 : .map_err(|e| passthrough_api_error(&node, e))?;
3734 :
3735 0 : client
3736 0 : .timeline_archival_config(tenant_shard_id, timeline_id, &req)
3737 0 : .await
3738 0 : .map_err(|e| match e {
3739 0 : mgmt_api::Error::ApiError(StatusCode::PRECONDITION_FAILED, msg) => {
3740 0 : ApiError::PreconditionFailed(msg.into_boxed_str())
3741 : }
3742 0 : _ => passthrough_api_error(&node, e),
3743 0 : })
3744 0 : }
3745 :
3746 : // no shard needs to go first/last; the operation should be idempotent
3747 : // TODO: it would be great to ensure that all shards return the same error
3748 0 : let locations = targets.0.iter().map(|t| (*t.0, t.1.latest.node.clone())).collect();
3749 0 : let results = self
3750 0 : .tenant_for_shards(locations, |tenant_shard_id, node| {
3751 0 : futures::FutureExt::boxed(config_one(
3752 0 : tenant_shard_id,
3753 0 : timeline_id,
3754 0 : node,
3755 0 : self.config.pageserver_jwt_token.clone(),
3756 0 : self.config.ssl_ca_cert.clone(),
3757 0 : req.clone(),
3758 0 : ))
3759 0 : })
3760 0 : .await?;
3761 0 : assert!(!results.is_empty(), "must have at least one result");
3762 :
3763 0 : Ok(())
3764 0 : }).await?
3765 0 : }
3766 :
3767 0 : pub(crate) async fn tenant_timeline_detach_ancestor(
3768 0 : &self,
3769 0 : tenant_id: TenantId,
3770 0 : timeline_id: TimelineId,
3771 0 : behavior: Option<DetachBehavior>,
3772 0 : ) -> Result<models::detach_ancestor::AncestorDetached, ApiError> {
3773 0 : tracing::info!("Detaching timeline {tenant_id}/{timeline_id}",);
3774 :
3775 0 : let _tenant_lock = trace_shared_lock(
3776 0 : &self.tenant_op_locks,
3777 0 : tenant_id,
3778 0 : TenantOperations::TimelineDetachAncestor,
3779 0 : )
3780 0 : .await;
3781 :
3782 0 : self.tenant_remote_mutation(tenant_id, move |targets| async move {
3783 0 : if targets.0.is_empty() {
3784 0 : return Err(ApiError::NotFound(
3785 0 : anyhow::anyhow!("Tenant not found").into(),
3786 0 : ));
3787 0 : }
3788 :
3789 0 : async fn detach_one(
3790 0 : tenant_shard_id: TenantShardId,
3791 0 : timeline_id: TimelineId,
3792 0 : node: Node,
3793 0 : jwt: Option<String>,
3794 0 : ssl_ca_cert: Option<Certificate>,
3795 0 : behavior: Option<DetachBehavior>,
3796 0 : ) -> Result<(ShardNumber, models::detach_ancestor::AncestorDetached), ApiError> {
3797 0 : tracing::info!(
3798 0 : "Detaching timeline on shard {tenant_shard_id}/{timeline_id}, attached to node {node}",
3799 : );
3800 :
3801 0 : let client = PageserverClient::new(node.get_id(), node.base_url(), jwt.as_deref(), ssl_ca_cert)
3802 0 : .map_err(|e| passthrough_api_error(&node, e))?;
3803 :
3804 0 : client
3805 0 : .timeline_detach_ancestor(tenant_shard_id, timeline_id, behavior)
3806 0 : .await
3807 0 : .map_err(|e| {
3808 : use mgmt_api::Error;
3809 :
3810 0 : match e {
3811 : // no ancestor (ever)
3812 0 : Error::ApiError(StatusCode::CONFLICT, msg) => ApiError::Conflict(format!(
3813 0 : "{node}: {}",
3814 0 : msg.strip_prefix("Conflict: ").unwrap_or(&msg)
3815 0 : )),
3816 : // too many ancestors
3817 0 : Error::ApiError(StatusCode::BAD_REQUEST, msg) => {
3818 0 : ApiError::BadRequest(anyhow::anyhow!("{node}: {msg}"))
3819 : }
3820 0 : Error::ApiError(StatusCode::INTERNAL_SERVER_ERROR, msg) => {
3821 0 : // avoid turning these into conflicts to remain compatible with
3822 0 : // pageservers, 500 errors are sadly retryable with timeline ancestor
3823 0 : // detach
3824 0 : ApiError::InternalServerError(anyhow::anyhow!("{node}: {msg}"))
3825 : }
3826 : // rest can be mapped as usual
3827 0 : other => passthrough_api_error(&node, other),
3828 : }
3829 0 : })
3830 0 : .map(|res| (tenant_shard_id.shard_number, res))
3831 0 : }
3832 :
3833 : // no shard needs to go first/last; the operation should be idempotent
3834 0 : let locations = targets.0.iter().map(|t| (*t.0, t.1.latest.node.clone())).collect();
3835 0 : let mut results = self
3836 0 : .tenant_for_shards(locations, |tenant_shard_id, node| {
3837 0 : futures::FutureExt::boxed(detach_one(
3838 0 : tenant_shard_id,
3839 0 : timeline_id,
3840 0 : node,
3841 0 : self.config.pageserver_jwt_token.clone(),
3842 0 : self.config.ssl_ca_cert.clone(),
3843 0 : behavior,
3844 0 : ))
3845 0 : })
3846 0 : .await?;
3847 :
3848 0 : let any = results.pop().expect("we must have at least one response");
3849 0 :
3850 0 : let mismatching = results
3851 0 : .iter()
3852 0 : .filter(|(_, res)| res != &any.1)
3853 0 : .collect::<Vec<_>>();
3854 0 : if !mismatching.is_empty() {
3855 : // this can be hit by races which should not happen because operation lock on cplane
3856 0 : let matching = results.len() - mismatching.len();
3857 0 : tracing::error!(
3858 : matching,
3859 : compared_against=?any,
3860 : ?mismatching,
3861 0 : "shards returned different results"
3862 : );
3863 :
3864 0 : return Err(ApiError::InternalServerError(anyhow::anyhow!("pageservers returned mixed results for ancestor detach; manual intervention is required.")));
3865 0 : }
3866 0 :
3867 0 : Ok(any.1)
3868 0 : }).await?
3869 0 : }
3870 :
3871 0 : pub(crate) async fn tenant_timeline_block_unblock_gc(
3872 0 : &self,
3873 0 : tenant_id: TenantId,
3874 0 : timeline_id: TimelineId,
3875 0 : dir: BlockUnblock,
3876 0 : ) -> Result<(), ApiError> {
3877 0 : let _tenant_lock = trace_shared_lock(
3878 0 : &self.tenant_op_locks,
3879 0 : tenant_id,
3880 0 : TenantOperations::TimelineGcBlockUnblock,
3881 0 : )
3882 0 : .await;
3883 :
3884 0 : self.tenant_remote_mutation(tenant_id, move |targets| async move {
3885 0 : if targets.0.is_empty() {
3886 0 : return Err(ApiError::NotFound(
3887 0 : anyhow::anyhow!("Tenant not found").into(),
3888 0 : ));
3889 0 : }
3890 :
3891 0 : async fn do_one(
3892 0 : tenant_shard_id: TenantShardId,
3893 0 : timeline_id: TimelineId,
3894 0 : node: Node,
3895 0 : jwt: Option<String>,
3896 0 : ssl_ca_cert: Option<Certificate>,
3897 0 : dir: BlockUnblock,
3898 0 : ) -> Result<(), ApiError> {
3899 0 : let client = PageserverClient::new(
3900 0 : node.get_id(),
3901 0 : node.base_url(),
3902 0 : jwt.as_deref(),
3903 0 : ssl_ca_cert,
3904 0 : )
3905 0 : .map_err(|e| passthrough_api_error(&node, e))?;
3906 :
3907 0 : client
3908 0 : .timeline_block_unblock_gc(tenant_shard_id, timeline_id, dir)
3909 0 : .await
3910 0 : .map_err(|e| passthrough_api_error(&node, e))
3911 0 : }
3912 :
3913 : // no shard needs to go first/last; the operation should be idempotent
3914 0 : let locations = targets
3915 0 : .0
3916 0 : .iter()
3917 0 : .map(|t| (*t.0, t.1.latest.node.clone()))
3918 0 : .collect();
3919 0 : self.tenant_for_shards(locations, |tenant_shard_id, node| {
3920 0 : futures::FutureExt::boxed(do_one(
3921 0 : tenant_shard_id,
3922 0 : timeline_id,
3923 0 : node,
3924 0 : self.config.pageserver_jwt_token.clone(),
3925 0 : self.config.ssl_ca_cert.clone(),
3926 0 : dir,
3927 0 : ))
3928 0 : })
3929 0 : .await
3930 0 : })
3931 0 : .await??;
3932 0 : Ok(())
3933 0 : }
3934 :
3935 0 : pub(crate) async fn tenant_timeline_download_heatmap_layers(
3936 0 : &self,
3937 0 : tenant_shard_id: TenantShardId,
3938 0 : timeline_id: TimelineId,
3939 0 : concurrency: Option<usize>,
3940 0 : recurse: bool,
3941 0 : ) -> Result<(), ApiError> {
3942 0 : let _tenant_lock = trace_shared_lock(
3943 0 : &self.tenant_op_locks,
3944 0 : tenant_shard_id.tenant_id,
3945 0 : TenantOperations::DownloadHeatmapLayers,
3946 0 : )
3947 0 : .await;
3948 :
3949 0 : let targets = {
3950 0 : let locked = self.inner.read().unwrap();
3951 0 : let mut targets = Vec::new();
3952 :
3953 : // If the request got an unsharded tenant id, then apply
3954 : // the operation to all shards. Otherwise, apply it to a specific shard.
3955 0 : let shards_range = if tenant_shard_id.is_unsharded() {
3956 0 : TenantShardId::tenant_range(tenant_shard_id.tenant_id)
3957 : } else {
3958 0 : tenant_shard_id.range()
3959 : };
3960 :
3961 0 : for (tenant_shard_id, shard) in locked.tenants.range(shards_range) {
3962 0 : if let Some(node_id) = shard.intent.get_attached() {
3963 0 : let node = locked
3964 0 : .nodes
3965 0 : .get(node_id)
3966 0 : .expect("Pageservers may not be deleted while referenced");
3967 0 :
3968 0 : targets.push((*tenant_shard_id, node.clone()));
3969 0 : }
3970 : }
3971 0 : targets
3972 0 : };
3973 0 :
3974 0 : self.tenant_for_shards_api(
3975 0 : targets,
3976 0 : |tenant_shard_id, client| async move {
3977 0 : client
3978 0 : .timeline_download_heatmap_layers(
3979 0 : tenant_shard_id,
3980 0 : timeline_id,
3981 0 : concurrency,
3982 0 : recurse,
3983 0 : )
3984 0 : .await
3985 0 : },
3986 0 : 1,
3987 0 : 1,
3988 0 : SHORT_RECONCILE_TIMEOUT,
3989 0 : &self.cancel,
3990 0 : )
3991 0 : .await;
3992 :
3993 0 : Ok(())
3994 0 : }
3995 :
3996 : /// Helper for concurrently calling a pageserver API on a number of shards, such as timeline creation.
3997 : ///
3998 : /// On success, the returned vector contains exactly the same number of elements as the input `locations`
3999 : /// and returned element at index `i` is the result for `req_fn(op(locations[i])`.
4000 0 : async fn tenant_for_shards<F, R>(
4001 0 : &self,
4002 0 : locations: Vec<(TenantShardId, Node)>,
4003 0 : mut req_fn: F,
4004 0 : ) -> Result<Vec<R>, ApiError>
4005 0 : where
4006 0 : F: FnMut(
4007 0 : TenantShardId,
4008 0 : Node,
4009 0 : )
4010 0 : -> std::pin::Pin<Box<dyn futures::Future<Output = Result<R, ApiError>> + Send>>,
4011 0 : {
4012 0 : let mut futs = FuturesUnordered::new();
4013 0 : let mut results = Vec::with_capacity(locations.len());
4014 :
4015 0 : for (idx, (tenant_shard_id, node)) in locations.into_iter().enumerate() {
4016 0 : let fut = req_fn(tenant_shard_id, node);
4017 0 : futs.push(async move { (idx, fut.await) });
4018 0 : }
4019 :
4020 0 : while let Some((idx, r)) = futs.next().await {
4021 0 : results.push((idx, r?));
4022 : }
4023 :
4024 0 : results.sort_by_key(|(idx, _)| *idx);
4025 0 : Ok(results.into_iter().map(|(_, r)| r).collect())
4026 0 : }
4027 :
4028 : /// Concurrently invoke a pageserver API call on many shards at once.
4029 : ///
4030 : /// The returned Vec has the same length as the `locations` Vec,
4031 : /// and returned element at index `i` is the result for `op(locations[i])`.
4032 0 : pub(crate) async fn tenant_for_shards_api<T, O, F>(
4033 0 : &self,
4034 0 : locations: Vec<(TenantShardId, Node)>,
4035 0 : op: O,
4036 0 : warn_threshold: u32,
4037 0 : max_retries: u32,
4038 0 : timeout: Duration,
4039 0 : cancel: &CancellationToken,
4040 0 : ) -> Vec<mgmt_api::Result<T>>
4041 0 : where
4042 0 : O: Fn(TenantShardId, PageserverClient) -> F + Copy,
4043 0 : F: std::future::Future<Output = mgmt_api::Result<T>>,
4044 0 : {
4045 0 : let mut futs = FuturesUnordered::new();
4046 0 : let mut results = Vec::with_capacity(locations.len());
4047 :
4048 0 : for (idx, (tenant_shard_id, node)) in locations.into_iter().enumerate() {
4049 0 : futs.push(async move {
4050 0 : let r = node
4051 0 : .with_client_retries(
4052 0 : |client| op(tenant_shard_id, client),
4053 0 : &self.config.pageserver_jwt_token,
4054 0 : &self.config.ssl_ca_cert,
4055 0 : warn_threshold,
4056 0 : max_retries,
4057 0 : timeout,
4058 0 : cancel,
4059 0 : )
4060 0 : .await;
4061 0 : (idx, r)
4062 0 : });
4063 0 : }
4064 :
4065 0 : while let Some((idx, r)) = futs.next().await {
4066 0 : results.push((idx, r.unwrap_or(Err(mgmt_api::Error::Cancelled))));
4067 0 : }
4068 :
4069 0 : results.sort_by_key(|(idx, _)| *idx);
4070 0 : results.into_iter().map(|(_, r)| r).collect()
4071 0 : }
4072 :
4073 : /// Helper for safely working with the shards in a tenant remotely on pageservers, for example
4074 : /// when creating and deleting timelines:
4075 : /// - Makes sure shards are attached somewhere if they weren't already
4076 : /// - Looks up the shards and the nodes where they were most recently attached
4077 : /// - Guarantees that after the inner function returns, the shards' generations haven't moved on: this
4078 : /// ensures that the remote operation acted on the most recent generation, and is therefore durable.
4079 0 : async fn tenant_remote_mutation<R, O, F>(
4080 0 : &self,
4081 0 : tenant_id: TenantId,
4082 0 : op: O,
4083 0 : ) -> Result<R, ApiError>
4084 0 : where
4085 0 : O: FnOnce(TenantMutationLocations) -> F,
4086 0 : F: std::future::Future<Output = R>,
4087 0 : {
4088 0 : let mutation_locations = {
4089 0 : let mut locations = TenantMutationLocations::default();
4090 :
4091 : // Load the currently attached pageservers for the latest generation of each shard. This can
4092 : // run concurrently with reconciliations, and it is not guaranteed that the node we find here
4093 : // will still be the latest when we're done: we will check generations again at the end of
4094 : // this function to handle that.
4095 0 : let generations = self.persistence.tenant_generations(tenant_id).await?;
4096 :
4097 0 : if generations
4098 0 : .iter()
4099 0 : .any(|i| i.generation.is_none() || i.generation_pageserver.is_none())
4100 : {
4101 0 : let shard_generations = generations
4102 0 : .into_iter()
4103 0 : .map(|i| (i.tenant_shard_id, (i.generation, i.generation_pageserver)))
4104 0 : .collect::<HashMap<_, _>>();
4105 0 :
4106 0 : // One or more shards has not been attached to a pageserver. Check if this is because it's configured
4107 0 : // to be detached (409: caller should give up), or because it's meant to be attached but isn't yet (503: caller should retry)
4108 0 : let locked = self.inner.read().unwrap();
4109 0 : for (shard_id, shard) in
4110 0 : locked.tenants.range(TenantShardId::tenant_range(tenant_id))
4111 : {
4112 0 : match shard.policy {
4113 : PlacementPolicy::Attached(_) => {
4114 : // This shard is meant to be attached: the caller is not wrong to try and
4115 : // use this function, but we can't service the request right now.
4116 0 : let Some(generation) = shard_generations.get(shard_id) else {
4117 : // This can only happen if there is a split brain controller modifying the database. This should
4118 : // never happen when testing, and if it happens in production we can only log the issue.
4119 0 : debug_assert!(false);
4120 0 : tracing::error!(
4121 0 : "Shard {shard_id} not found in generation state! Is another rogue controller running?"
4122 : );
4123 0 : continue;
4124 : };
4125 0 : let (generation, generation_pageserver) = generation;
4126 0 : if let Some(generation) = generation {
4127 0 : if generation_pageserver.is_none() {
4128 : // This is legitimate only in a very narrow window where the shard was only just configured into
4129 : // Attached mode after being created in Secondary or Detached mode, and it has had its generation
4130 : // set but not yet had a Reconciler run (reconciler is the only thing that sets generation_pageserver).
4131 0 : tracing::warn!(
4132 0 : "Shard {shard_id} generation is set ({generation:?}) but generation_pageserver is None, reconciler not run yet?"
4133 : );
4134 0 : }
4135 : } else {
4136 : // This should never happen: a shard with no generation is only permitted when it was created in some state
4137 : // other than PlacementPolicy::Attached (and generation is always written to DB before setting Attached in memory)
4138 0 : debug_assert!(false);
4139 0 : tracing::error!(
4140 0 : "Shard {shard_id} generation is None, but it is in PlacementPolicy::Attached mode!"
4141 : );
4142 0 : continue;
4143 : }
4144 : }
4145 : PlacementPolicy::Secondary | PlacementPolicy::Detached => {
4146 0 : return Err(ApiError::Conflict(format!(
4147 0 : "Shard {shard_id} tenant has policy {:?}",
4148 0 : shard.policy
4149 0 : )));
4150 : }
4151 : }
4152 : }
4153 :
4154 0 : return Err(ApiError::ResourceUnavailable(
4155 0 : "One or more shards in tenant is not yet attached".into(),
4156 0 : ));
4157 0 : }
4158 0 :
4159 0 : let locked = self.inner.read().unwrap();
4160 : for ShardGenerationState {
4161 0 : tenant_shard_id,
4162 0 : generation,
4163 0 : generation_pageserver,
4164 0 : } in generations
4165 : {
4166 0 : let node_id = generation_pageserver.expect("We checked for None above");
4167 0 : let node = locked
4168 0 : .nodes
4169 0 : .get(&node_id)
4170 0 : .ok_or(ApiError::Conflict(format!(
4171 0 : "Raced with removal of node {node_id}"
4172 0 : )))?;
4173 0 : let generation = generation.expect("Checked above");
4174 0 :
4175 0 : let tenant = locked.tenants.get(&tenant_shard_id);
4176 :
4177 : // TODO(vlad): Abstract the logic that finds stale attached locations
4178 : // from observed state into a [`Service`] method.
4179 0 : let other_locations = match tenant {
4180 0 : Some(tenant) => {
4181 0 : let mut other = tenant.attached_locations();
4182 0 : let latest_location_index =
4183 0 : other.iter().position(|&l| l == (node.get_id(), generation));
4184 0 : if let Some(idx) = latest_location_index {
4185 0 : other.remove(idx);
4186 0 : }
4187 :
4188 0 : other
4189 : }
4190 0 : None => Vec::default(),
4191 : };
4192 :
4193 0 : let location = ShardMutationLocations {
4194 0 : latest: MutationLocation {
4195 0 : node: node.clone(),
4196 0 : generation,
4197 0 : },
4198 0 : other: other_locations
4199 0 : .into_iter()
4200 0 : .filter_map(|(node_id, generation)| {
4201 0 : let node = locked.nodes.get(&node_id)?;
4202 :
4203 0 : Some(MutationLocation {
4204 0 : node: node.clone(),
4205 0 : generation,
4206 0 : })
4207 0 : })
4208 0 : .collect(),
4209 0 : };
4210 0 : locations.0.insert(tenant_shard_id, location);
4211 0 : }
4212 :
4213 0 : locations
4214 : };
4215 :
4216 0 : let result = op(mutation_locations.clone()).await;
4217 :
4218 : // Post-check: are all the generations of all the shards the same as they were initially? This proves that
4219 : // our remote operation executed on the latest generation and is therefore persistent.
4220 : {
4221 0 : let latest_generations = self.persistence.tenant_generations(tenant_id).await?;
4222 0 : if latest_generations
4223 0 : .into_iter()
4224 0 : .map(
4225 0 : |ShardGenerationState {
4226 : tenant_shard_id,
4227 : generation,
4228 : generation_pageserver: _,
4229 0 : }| (tenant_shard_id, generation),
4230 0 : )
4231 0 : .collect::<Vec<_>>()
4232 0 : != mutation_locations
4233 0 : .0
4234 0 : .into_iter()
4235 0 : .map(|i| (i.0, Some(i.1.latest.generation)))
4236 0 : .collect::<Vec<_>>()
4237 : {
4238 : // We raced with something that incremented the generation, and therefore cannot be
4239 : // confident that our actions are persistent (they might have hit an old generation).
4240 : //
4241 : // This is safe but requires a retry: ask the client to do that by giving them a 503 response.
4242 0 : return Err(ApiError::ResourceUnavailable(
4243 0 : "Tenant attachment changed, please retry".into(),
4244 0 : ));
4245 0 : }
4246 0 : }
4247 0 :
4248 0 : Ok(result)
4249 0 : }
4250 :
4251 0 : pub(crate) async fn tenant_timeline_delete(
4252 0 : self: &Arc<Self>,
4253 0 : tenant_id: TenantId,
4254 0 : timeline_id: TimelineId,
4255 0 : ) -> Result<StatusCode, ApiError> {
4256 0 : tracing::info!("Deleting timeline {}/{}", tenant_id, timeline_id,);
4257 0 : let _tenant_lock = trace_shared_lock(
4258 0 : &self.tenant_op_locks,
4259 0 : tenant_id,
4260 0 : TenantOperations::TimelineDelete,
4261 0 : )
4262 0 : .await;
4263 :
4264 0 : let status_code = self.tenant_remote_mutation(tenant_id, move |mut targets| async move {
4265 0 : if targets.0.is_empty() {
4266 0 : return Err(ApiError::NotFound(
4267 0 : anyhow::anyhow!("Tenant not found").into(),
4268 0 : ));
4269 0 : }
4270 0 :
4271 0 : let (shard_zero_tid, shard_zero_locations) = targets.0.pop_first().expect("Must have at least one shard");
4272 0 : assert!(shard_zero_tid.is_shard_zero());
4273 :
4274 0 : async fn delete_one(
4275 0 : tenant_shard_id: TenantShardId,
4276 0 : timeline_id: TimelineId,
4277 0 : node: Node,
4278 0 : jwt: Option<String>,
4279 0 : ssl_ca_cert: Option<Certificate>,
4280 0 : ) -> Result<StatusCode, ApiError> {
4281 0 : tracing::info!(
4282 0 : "Deleting timeline on shard {tenant_shard_id}/{timeline_id}, attached to node {node}",
4283 : );
4284 :
4285 0 : let client = PageserverClient::new(node.get_id(), node.base_url(), jwt.as_deref(), ssl_ca_cert)
4286 0 : .map_err(|e| passthrough_api_error(&node, e))?;
4287 0 : let res = client
4288 0 : .timeline_delete(tenant_shard_id, timeline_id)
4289 0 : .await;
4290 :
4291 0 : match res {
4292 0 : Ok(ok) => Ok(ok),
4293 0 : Err(mgmt_api::Error::ApiError(StatusCode::CONFLICT, _)) => Ok(StatusCode::CONFLICT),
4294 0 : Err(mgmt_api::Error::ApiError(StatusCode::SERVICE_UNAVAILABLE, msg)) => Err(ApiError::ResourceUnavailable(msg.into())),
4295 0 : Err(e) => {
4296 0 : Err(
4297 0 : ApiError::InternalServerError(anyhow::anyhow!(
4298 0 : "Error deleting timeline {timeline_id} on {tenant_shard_id} on node {node}: {e}",
4299 0 : ))
4300 0 : )
4301 : }
4302 : }
4303 0 : }
4304 :
4305 0 : let locations = targets.0.iter().map(|t| (*t.0, t.1.latest.node.clone())).collect();
4306 0 : let statuses = self
4307 0 : .tenant_for_shards(locations, |tenant_shard_id: TenantShardId, node: Node| {
4308 0 : Box::pin(delete_one(
4309 0 : tenant_shard_id,
4310 0 : timeline_id,
4311 0 : node,
4312 0 : self.config.pageserver_jwt_token.clone(),
4313 0 : self.config.ssl_ca_cert.clone(),
4314 0 : ))
4315 0 : })
4316 0 : .await?;
4317 :
4318 : // If any shards >0 haven't finished deletion yet, don't start deletion on shard zero.
4319 : // We return 409 (Conflict) if deletion was already in progress on any of the shards
4320 : // and 202 (Accepted) if deletion was not already in progress on any of the shards.
4321 0 : if statuses.iter().any(|s| s == &StatusCode::CONFLICT) {
4322 0 : return Ok(StatusCode::CONFLICT);
4323 0 : }
4324 0 :
4325 0 : if statuses.iter().any(|s| s != &StatusCode::NOT_FOUND) {
4326 0 : return Ok(StatusCode::ACCEPTED);
4327 0 : }
4328 :
4329 : // Delete shard zero last: this is not strictly necessary, but since a caller's GET on a timeline will be routed
4330 : // to shard zero, it gives a more obvious behavior that a GET returns 404 once the deletion is done.
4331 0 : let shard_zero_status = delete_one(
4332 0 : shard_zero_tid,
4333 0 : timeline_id,
4334 0 : shard_zero_locations.latest.node,
4335 0 : self.config.pageserver_jwt_token.clone(),
4336 0 : self.config.ssl_ca_cert.clone(),
4337 0 : )
4338 0 : .await?;
4339 0 : Ok(shard_zero_status)
4340 0 : }).await?;
4341 :
4342 0 : self.tenant_timeline_delete_safekeepers(tenant_id, timeline_id)
4343 0 : .await?;
4344 :
4345 0 : status_code
4346 0 : }
4347 : /// When you know the TenantId but not a specific shard, and would like to get the node holding shard 0.
4348 0 : pub(crate) async fn tenant_shard0_node(
4349 0 : &self,
4350 0 : tenant_id: TenantId,
4351 0 : ) -> Result<(Node, TenantShardId), ApiError> {
4352 0 : let tenant_shard_id = {
4353 0 : let locked = self.inner.read().unwrap();
4354 0 : let Some((tenant_shard_id, _shard)) = locked
4355 0 : .tenants
4356 0 : .range(TenantShardId::tenant_range(tenant_id))
4357 0 : .next()
4358 : else {
4359 0 : return Err(ApiError::NotFound(
4360 0 : anyhow::anyhow!("Tenant {tenant_id} not found").into(),
4361 0 : ));
4362 : };
4363 :
4364 0 : *tenant_shard_id
4365 0 : };
4366 0 :
4367 0 : self.tenant_shard_node(tenant_shard_id)
4368 0 : .await
4369 0 : .map(|node| (node, tenant_shard_id))
4370 0 : }
4371 :
4372 : /// When you need to send an HTTP request to the pageserver that holds a shard of a tenant, this
4373 : /// function looks up and returns node. If the shard isn't found, returns Err(ApiError::NotFound)
4374 0 : pub(crate) async fn tenant_shard_node(
4375 0 : &self,
4376 0 : tenant_shard_id: TenantShardId,
4377 0 : ) -> Result<Node, ApiError> {
4378 0 : // Look up in-memory state and maybe use the node from there.
4379 0 : {
4380 0 : let locked = self.inner.read().unwrap();
4381 0 : let Some(shard) = locked.tenants.get(&tenant_shard_id) else {
4382 0 : return Err(ApiError::NotFound(
4383 0 : anyhow::anyhow!("Tenant shard {tenant_shard_id} not found").into(),
4384 0 : ));
4385 : };
4386 :
4387 0 : let Some(intent_node_id) = shard.intent.get_attached() else {
4388 0 : tracing::warn!(
4389 0 : tenant_id=%tenant_shard_id.tenant_id, shard_id=%tenant_shard_id.shard_slug(),
4390 0 : "Shard not scheduled (policy {:?}), cannot generate pass-through URL",
4391 : shard.policy
4392 : );
4393 0 : return Err(ApiError::Conflict(
4394 0 : "Cannot call timeline API on non-attached tenant".to_string(),
4395 0 : ));
4396 : };
4397 :
4398 0 : if shard.reconciler.is_none() {
4399 : // Optimization: while no reconcile is in flight, we may trust our in-memory state
4400 : // to tell us which pageserver to use. Otherwise we will fall through and hit the database
4401 0 : let Some(node) = locked.nodes.get(intent_node_id) else {
4402 : // This should never happen
4403 0 : return Err(ApiError::InternalServerError(anyhow::anyhow!(
4404 0 : "Shard refers to nonexistent node"
4405 0 : )));
4406 : };
4407 0 : return Ok(node.clone());
4408 0 : }
4409 : };
4410 :
4411 : // Look up the latest attached pageserver location from the database
4412 : // generation state: this will reflect the progress of any ongoing migration.
4413 : // Note that it is not guaranteed to _stay_ here, our caller must still handle
4414 : // the case where they call through to the pageserver and get a 404.
4415 0 : let db_result = self
4416 0 : .persistence
4417 0 : .tenant_generations(tenant_shard_id.tenant_id)
4418 0 : .await?;
4419 : let Some(ShardGenerationState {
4420 : tenant_shard_id: _,
4421 : generation: _,
4422 0 : generation_pageserver: Some(node_id),
4423 0 : }) = db_result
4424 0 : .into_iter()
4425 0 : .find(|s| s.tenant_shard_id == tenant_shard_id)
4426 : else {
4427 : // This can happen if we raced with a tenant deletion or a shard split. On a retry
4428 : // the caller will either succeed (shard split case), get a proper 404 (deletion case),
4429 : // or a conflict response (case where tenant was detached in background)
4430 0 : return Err(ApiError::ResourceUnavailable(
4431 0 : format!("Shard {tenant_shard_id} not found in database, or is not attached").into(),
4432 0 : ));
4433 : };
4434 0 : let locked = self.inner.read().unwrap();
4435 0 : let Some(node) = locked.nodes.get(&node_id) else {
4436 : // This should never happen
4437 0 : return Err(ApiError::InternalServerError(anyhow::anyhow!(
4438 0 : "Shard refers to nonexistent node"
4439 0 : )));
4440 : };
4441 :
4442 0 : Ok(node.clone())
4443 0 : }
4444 :
4445 0 : pub(crate) fn tenant_locate(
4446 0 : &self,
4447 0 : tenant_id: TenantId,
4448 0 : ) -> Result<TenantLocateResponse, ApiError> {
4449 0 : let locked = self.inner.read().unwrap();
4450 0 : tracing::info!("Locating shards for tenant {tenant_id}");
4451 :
4452 0 : let mut result = Vec::new();
4453 0 : let mut shard_params: Option<ShardParameters> = None;
4454 :
4455 0 : for (tenant_shard_id, shard) in locked.tenants.range(TenantShardId::tenant_range(tenant_id))
4456 : {
4457 0 : let node_id =
4458 0 : shard
4459 0 : .intent
4460 0 : .get_attached()
4461 0 : .ok_or(ApiError::BadRequest(anyhow::anyhow!(
4462 0 : "Cannot locate a tenant that is not attached"
4463 0 : )))?;
4464 :
4465 0 : let node = locked
4466 0 : .nodes
4467 0 : .get(&node_id)
4468 0 : .expect("Pageservers may not be deleted while referenced");
4469 0 :
4470 0 : result.push(node.shard_location(*tenant_shard_id));
4471 0 :
4472 0 : match &shard_params {
4473 0 : None => {
4474 0 : shard_params = Some(ShardParameters {
4475 0 : stripe_size: shard.shard.stripe_size,
4476 0 : count: shard.shard.count,
4477 0 : });
4478 0 : }
4479 0 : Some(params) => {
4480 0 : if params.stripe_size != shard.shard.stripe_size {
4481 : // This should never happen. We enforce at runtime because it's simpler than
4482 : // adding an extra per-tenant data structure to store the things that should be the same
4483 0 : return Err(ApiError::InternalServerError(anyhow::anyhow!(
4484 0 : "Inconsistent shard stripe size parameters!"
4485 0 : )));
4486 0 : }
4487 : }
4488 : }
4489 : }
4490 :
4491 0 : if result.is_empty() {
4492 0 : return Err(ApiError::NotFound(
4493 0 : anyhow::anyhow!("No shards for this tenant ID found").into(),
4494 0 : ));
4495 0 : }
4496 0 : let shard_params = shard_params.expect("result is non-empty, therefore this is set");
4497 0 : tracing::info!(
4498 0 : "Located tenant {} with params {:?} on shards {}",
4499 0 : tenant_id,
4500 0 : shard_params,
4501 0 : result
4502 0 : .iter()
4503 0 : .map(|s| format!("{:?}", s))
4504 0 : .collect::<Vec<_>>()
4505 0 : .join(",")
4506 : );
4507 :
4508 0 : Ok(TenantLocateResponse {
4509 0 : shards: result,
4510 0 : shard_params,
4511 0 : })
4512 0 : }
4513 :
4514 : /// Returns None if the input iterator of shards does not include a shard with number=0
4515 0 : fn tenant_describe_impl<'a>(
4516 0 : &self,
4517 0 : shards: impl Iterator<Item = &'a TenantShard>,
4518 0 : ) -> Option<TenantDescribeResponse> {
4519 0 : let mut shard_zero = None;
4520 0 : let mut describe_shards = Vec::new();
4521 :
4522 0 : for shard in shards {
4523 0 : if shard.tenant_shard_id.is_shard_zero() {
4524 0 : shard_zero = Some(shard);
4525 0 : }
4526 :
4527 0 : describe_shards.push(TenantDescribeResponseShard {
4528 0 : tenant_shard_id: shard.tenant_shard_id,
4529 0 : node_attached: *shard.intent.get_attached(),
4530 0 : node_secondary: shard.intent.get_secondary().to_vec(),
4531 0 : last_error: shard
4532 0 : .last_error
4533 0 : .lock()
4534 0 : .unwrap()
4535 0 : .as_ref()
4536 0 : .map(|e| format!("{e}"))
4537 0 : .unwrap_or("".to_string())
4538 0 : .clone(),
4539 0 : is_reconciling: shard.reconciler.is_some(),
4540 0 : is_pending_compute_notification: shard.pending_compute_notification,
4541 0 : is_splitting: matches!(shard.splitting, SplitState::Splitting),
4542 0 : scheduling_policy: shard.get_scheduling_policy(),
4543 0 : preferred_az_id: shard.preferred_az().map(ToString::to_string),
4544 : })
4545 : }
4546 :
4547 0 : let shard_zero = shard_zero?;
4548 :
4549 0 : Some(TenantDescribeResponse {
4550 0 : tenant_id: shard_zero.tenant_shard_id.tenant_id,
4551 0 : shards: describe_shards,
4552 0 : stripe_size: shard_zero.shard.stripe_size,
4553 0 : policy: shard_zero.policy.clone(),
4554 0 : config: shard_zero.config.clone(),
4555 0 : })
4556 0 : }
4557 :
4558 0 : pub(crate) fn tenant_describe(
4559 0 : &self,
4560 0 : tenant_id: TenantId,
4561 0 : ) -> Result<TenantDescribeResponse, ApiError> {
4562 0 : let locked = self.inner.read().unwrap();
4563 0 :
4564 0 : self.tenant_describe_impl(
4565 0 : locked
4566 0 : .tenants
4567 0 : .range(TenantShardId::tenant_range(tenant_id))
4568 0 : .map(|(_k, v)| v),
4569 0 : )
4570 0 : .ok_or_else(|| ApiError::NotFound(anyhow::anyhow!("Tenant {tenant_id} not found").into()))
4571 0 : }
4572 :
4573 : /// limit & offset are pagination parameters. Since we are walking an in-memory HashMap, `offset` does not
4574 : /// avoid traversing data, it just avoid returning it. This is suitable for our purposes, since our in memory
4575 : /// maps are small enough to traverse fast, our pagination is just to avoid serializing huge JSON responses
4576 : /// in our external API.
4577 0 : pub(crate) fn tenant_list(
4578 0 : &self,
4579 0 : limit: Option<usize>,
4580 0 : start_after: Option<TenantId>,
4581 0 : ) -> Vec<TenantDescribeResponse> {
4582 0 : let locked = self.inner.read().unwrap();
4583 :
4584 : // Apply start_from parameter
4585 0 : let shard_range = match start_after {
4586 0 : None => locked.tenants.range(..),
4587 0 : Some(tenant_id) => locked.tenants.range(
4588 0 : TenantShardId {
4589 0 : tenant_id,
4590 0 : shard_number: ShardNumber(u8::MAX),
4591 0 : shard_count: ShardCount(u8::MAX),
4592 0 : }..,
4593 0 : ),
4594 : };
4595 :
4596 0 : let mut result = Vec::new();
4597 0 : for (_tenant_id, tenant_shards) in &shard_range.group_by(|(id, _shard)| id.tenant_id) {
4598 0 : result.push(
4599 0 : self.tenant_describe_impl(tenant_shards.map(|(_k, v)| v))
4600 0 : .expect("Groups are always non-empty"),
4601 0 : );
4602 :
4603 : // Enforce `limit` parameter
4604 0 : if let Some(limit) = limit {
4605 0 : if result.len() >= limit {
4606 0 : break;
4607 0 : }
4608 0 : }
4609 : }
4610 :
4611 0 : result
4612 0 : }
4613 :
4614 : #[instrument(skip_all, fields(tenant_id=%op.tenant_id))]
4615 : async fn abort_tenant_shard_split(
4616 : &self,
4617 : op: &TenantShardSplitAbort,
4618 : ) -> Result<(), TenantShardSplitAbortError> {
4619 : // Cleaning up a split:
4620 : // - Parent shards are not destroyed during a split, just detached.
4621 : // - Failed pageserver split API calls can leave the remote node with just the parent attached,
4622 : // just the children attached, or both.
4623 : //
4624 : // Therefore our work to do is to:
4625 : // 1. Clean up storage controller's internal state to just refer to parents, no children
4626 : // 2. Call out to pageservers to ensure that children are detached
4627 : // 3. Call out to pageservers to ensure that parents are attached.
4628 : //
4629 : // Crash safety:
4630 : // - If the storage controller stops running during this cleanup *after* clearing the splitting state
4631 : // from our database, then [`Self::startup_reconcile`] will regard child attachments as garbage
4632 : // and detach them.
4633 : // - TODO: If the storage controller stops running during this cleanup *before* clearing the splitting state
4634 : // from our database, then we will re-enter this cleanup routine on startup.
4635 :
4636 : let TenantShardSplitAbort {
4637 : tenant_id,
4638 : new_shard_count,
4639 : new_stripe_size,
4640 : ..
4641 : } = op;
4642 :
4643 : // First abort persistent state, if any exists.
4644 : match self
4645 : .persistence
4646 : .abort_shard_split(*tenant_id, *new_shard_count)
4647 : .await?
4648 : {
4649 : AbortShardSplitStatus::Aborted => {
4650 : // Proceed to roll back any child shards created on pageservers
4651 : }
4652 : AbortShardSplitStatus::Complete => {
4653 : // The split completed (we might hit that path if e.g. our database transaction
4654 : // to write the completion landed in the database, but we dropped connection
4655 : // before seeing the result).
4656 : //
4657 : // We must update in-memory state to reflect the successful split.
4658 : self.tenant_shard_split_commit_inmem(
4659 : *tenant_id,
4660 : *new_shard_count,
4661 : *new_stripe_size,
4662 : );
4663 : return Ok(());
4664 : }
4665 : }
4666 :
4667 : // Clean up in-memory state, and accumulate the list of child locations that need detaching
4668 : let detach_locations: Vec<(Node, TenantShardId)> = {
4669 : let mut detach_locations = Vec::new();
4670 : let mut locked = self.inner.write().unwrap();
4671 : let (nodes, tenants, scheduler) = locked.parts_mut();
4672 :
4673 : for (tenant_shard_id, shard) in
4674 : tenants.range_mut(TenantShardId::tenant_range(op.tenant_id))
4675 : {
4676 : if shard.shard.count == op.new_shard_count {
4677 : // Surprising: the phase of [`Self::do_tenant_shard_split`] which inserts child shards in-memory
4678 : // is infallible, so if we got an error we shouldn't have got that far.
4679 : tracing::warn!(
4680 : "During split abort, child shard {tenant_shard_id} found in-memory"
4681 : );
4682 : continue;
4683 : }
4684 :
4685 : // Add the children of this shard to this list of things to detach
4686 : if let Some(node_id) = shard.intent.get_attached() {
4687 : for child_id in tenant_shard_id.split(*new_shard_count) {
4688 : detach_locations.push((
4689 : nodes
4690 : .get(node_id)
4691 : .expect("Intent references nonexistent node")
4692 : .clone(),
4693 : child_id,
4694 : ));
4695 : }
4696 : } else {
4697 : tracing::warn!(
4698 : "During split abort, shard {tenant_shard_id} has no attached location"
4699 : );
4700 : }
4701 :
4702 : tracing::info!("Restoring parent shard {tenant_shard_id}");
4703 :
4704 : // Drop any intents that refer to unavailable nodes, to enable this abort to proceed even
4705 : // if the original attachment location is offline.
4706 : if let Some(node_id) = shard.intent.get_attached() {
4707 : if !nodes.get(node_id).unwrap().is_available() {
4708 : tracing::info!(
4709 : "Demoting attached intent for {tenant_shard_id} on unavailable node {node_id}"
4710 : );
4711 : shard.intent.demote_attached(scheduler, *node_id);
4712 : }
4713 : }
4714 : for node_id in shard.intent.get_secondary().clone() {
4715 : if !nodes.get(&node_id).unwrap().is_available() {
4716 : tracing::info!(
4717 : "Dropping secondary intent for {tenant_shard_id} on unavailable node {node_id}"
4718 : );
4719 : shard.intent.remove_secondary(scheduler, node_id);
4720 : }
4721 : }
4722 :
4723 : shard.splitting = SplitState::Idle;
4724 : if let Err(e) = shard.schedule(scheduler, &mut ScheduleContext::default()) {
4725 : // If this shard can't be scheduled now (perhaps due to offline nodes or
4726 : // capacity issues), that must not prevent us rolling back a split. In this
4727 : // case it should be eventually scheduled in the background.
4728 : tracing::warn!("Failed to schedule {tenant_shard_id} during shard abort: {e}")
4729 : }
4730 :
4731 : self.maybe_reconcile_shard(shard, nodes, ReconcilerPriority::High);
4732 : }
4733 :
4734 : // We don't expect any new_shard_count shards to exist here, but drop them just in case
4735 0 : tenants.retain(|_id, s| s.shard.count != *new_shard_count);
4736 :
4737 : detach_locations
4738 : };
4739 :
4740 : for (node, child_id) in detach_locations {
4741 : if !node.is_available() {
4742 : // An unavailable node cannot be cleaned up now: to avoid blocking forever, we will permit this, and
4743 : // rely on the reconciliation that happens when a node transitions to Active to clean up. Since we have
4744 : // removed child shards from our in-memory state and database, the reconciliation will implicitly remove
4745 : // them from the node.
4746 : tracing::warn!(
4747 : "Node {node} unavailable, can't clean up during split abort. It will be cleaned up when it is reactivated."
4748 : );
4749 : continue;
4750 : }
4751 :
4752 : // Detach the remote child. If the pageserver split API call is still in progress, this call will get
4753 : // a 503 and retry, up to our limit.
4754 : tracing::info!("Detaching {child_id} on {node}...");
4755 : match node
4756 : .with_client_retries(
4757 0 : |client| async move {
4758 0 : let config = LocationConfig {
4759 0 : mode: LocationConfigMode::Detached,
4760 0 : generation: None,
4761 0 : secondary_conf: None,
4762 0 : shard_number: child_id.shard_number.0,
4763 0 : shard_count: child_id.shard_count.literal(),
4764 0 : // Stripe size and tenant config don't matter when detaching
4765 0 : shard_stripe_size: 0,
4766 0 : tenant_conf: TenantConfig::default(),
4767 0 : };
4768 0 :
4769 0 : client.location_config(child_id, config, None, false).await
4770 0 : },
4771 : &self.config.pageserver_jwt_token,
4772 : &self.config.ssl_ca_cert,
4773 : 1,
4774 : 10,
4775 : Duration::from_secs(5),
4776 : &self.cancel,
4777 : )
4778 : .await
4779 : {
4780 : Some(Ok(_)) => {}
4781 : Some(Err(e)) => {
4782 : // We failed to communicate with the remote node. This is problematic: we may be
4783 : // leaving it with a rogue child shard.
4784 : tracing::warn!(
4785 : "Failed to detach child {child_id} from node {node} during abort"
4786 : );
4787 : return Err(e.into());
4788 : }
4789 : None => {
4790 : // Cancellation: we were shutdown or the node went offline. Shutdown is fine, we'll
4791 : // clean up on restart. The node going offline requires a retry.
4792 : return Err(TenantShardSplitAbortError::Unavailable);
4793 : }
4794 : };
4795 : }
4796 :
4797 : tracing::info!("Successfully aborted split");
4798 : Ok(())
4799 : }
4800 :
4801 : /// Infallible final stage of [`Self::tenant_shard_split`]: update the contents
4802 : /// of the tenant map to reflect the child shards that exist after the split.
4803 0 : fn tenant_shard_split_commit_inmem(
4804 0 : &self,
4805 0 : tenant_id: TenantId,
4806 0 : new_shard_count: ShardCount,
4807 0 : new_stripe_size: Option<ShardStripeSize>,
4808 0 : ) -> (
4809 0 : TenantShardSplitResponse,
4810 0 : Vec<(TenantShardId, NodeId, ShardStripeSize)>,
4811 0 : Vec<ReconcilerWaiter>,
4812 0 : ) {
4813 0 : let mut response = TenantShardSplitResponse {
4814 0 : new_shards: Vec::new(),
4815 0 : };
4816 0 : let mut child_locations = Vec::new();
4817 0 : let mut waiters = Vec::new();
4818 0 :
4819 0 : {
4820 0 : let mut locked = self.inner.write().unwrap();
4821 0 :
4822 0 : let parent_ids = locked
4823 0 : .tenants
4824 0 : .range(TenantShardId::tenant_range(tenant_id))
4825 0 : .map(|(shard_id, _)| *shard_id)
4826 0 : .collect::<Vec<_>>();
4827 0 :
4828 0 : let (nodes, tenants, scheduler) = locked.parts_mut();
4829 0 : for parent_id in parent_ids {
4830 0 : let child_ids = parent_id.split(new_shard_count);
4831 :
4832 0 : let (pageserver, generation, policy, parent_ident, config, preferred_az) = {
4833 0 : let mut old_state = tenants
4834 0 : .remove(&parent_id)
4835 0 : .expect("It was present, we just split it");
4836 0 :
4837 0 : // A non-splitting state is impossible, because [`Self::tenant_shard_split`] holds
4838 0 : // a TenantId lock and passes it through to [`TenantShardSplitAbort`] in case of cleanup:
4839 0 : // nothing else can clear this.
4840 0 : assert!(matches!(old_state.splitting, SplitState::Splitting));
4841 :
4842 0 : let old_attached = old_state.intent.get_attached().unwrap();
4843 0 : old_state.intent.clear(scheduler);
4844 0 : let generation = old_state.generation.expect("Shard must have been attached");
4845 0 : (
4846 0 : old_attached,
4847 0 : generation,
4848 0 : old_state.policy.clone(),
4849 0 : old_state.shard,
4850 0 : old_state.config.clone(),
4851 0 : old_state.preferred_az().cloned(),
4852 0 : )
4853 0 : };
4854 0 :
4855 0 : let mut schedule_context = ScheduleContext::default();
4856 0 : for child in child_ids {
4857 0 : let mut child_shard = parent_ident;
4858 0 : child_shard.number = child.shard_number;
4859 0 : child_shard.count = child.shard_count;
4860 0 : if let Some(stripe_size) = new_stripe_size {
4861 0 : child_shard.stripe_size = stripe_size;
4862 0 : }
4863 :
4864 0 : let mut child_observed: HashMap<NodeId, ObservedStateLocation> = HashMap::new();
4865 0 : child_observed.insert(
4866 0 : pageserver,
4867 0 : ObservedStateLocation {
4868 0 : conf: Some(attached_location_conf(
4869 0 : generation,
4870 0 : &child_shard,
4871 0 : &config,
4872 0 : &policy,
4873 0 : )),
4874 0 : },
4875 0 : );
4876 0 :
4877 0 : let mut child_state =
4878 0 : TenantShard::new(child, child_shard, policy.clone(), preferred_az.clone());
4879 0 : child_state.intent =
4880 0 : IntentState::single(scheduler, Some(pageserver), preferred_az.clone());
4881 0 : child_state.observed = ObservedState {
4882 0 : locations: child_observed,
4883 0 : };
4884 0 : child_state.generation = Some(generation);
4885 0 : child_state.config = config.clone();
4886 0 :
4887 0 : // The child's TenantShard::splitting is intentionally left at the default value of Idle,
4888 0 : // as at this point in the split process we have succeeded and this part is infallible:
4889 0 : // we will never need to do any special recovery from this state.
4890 0 :
4891 0 : child_locations.push((child, pageserver, child_shard.stripe_size));
4892 :
4893 0 : if let Err(e) = child_state.schedule(scheduler, &mut schedule_context) {
4894 : // This is not fatal, because we've implicitly already got an attached
4895 : // location for the child shard. Failure here just means we couldn't
4896 : // find a secondary (e.g. because cluster is overloaded).
4897 0 : tracing::warn!("Failed to schedule child shard {child}: {e}");
4898 0 : }
4899 : // In the background, attach secondary locations for the new shards
4900 0 : if let Some(waiter) = self.maybe_reconcile_shard(
4901 0 : &mut child_state,
4902 0 : nodes,
4903 0 : ReconcilerPriority::High,
4904 0 : ) {
4905 0 : waiters.push(waiter);
4906 0 : }
4907 :
4908 0 : tenants.insert(child, child_state);
4909 0 : response.new_shards.push(child);
4910 : }
4911 : }
4912 0 : (response, child_locations, waiters)
4913 0 : }
4914 0 : }
4915 :
4916 0 : async fn tenant_shard_split_start_secondaries(
4917 0 : &self,
4918 0 : tenant_id: TenantId,
4919 0 : waiters: Vec<ReconcilerWaiter>,
4920 0 : ) {
4921 : // Wait for initial reconcile of child shards, this creates the secondary locations
4922 0 : if let Err(e) = self.await_waiters(waiters, RECONCILE_TIMEOUT).await {
4923 : // This is not a failure to split: it's some issue reconciling the new child shards, perhaps
4924 : // their secondaries couldn't be attached.
4925 0 : tracing::warn!("Failed to reconcile after split: {e}");
4926 0 : return;
4927 0 : }
4928 :
4929 : // Take the state lock to discover the attached & secondary intents for all shards
4930 0 : let (attached, secondary) = {
4931 0 : let locked = self.inner.read().unwrap();
4932 0 : let mut attached = Vec::new();
4933 0 : let mut secondary = Vec::new();
4934 :
4935 0 : for (tenant_shard_id, shard) in
4936 0 : locked.tenants.range(TenantShardId::tenant_range(tenant_id))
4937 : {
4938 0 : let Some(node_id) = shard.intent.get_attached() else {
4939 : // Unexpected. Race with a PlacementPolicy change?
4940 0 : tracing::warn!(
4941 0 : "No attached node on {tenant_shard_id} immediately after shard split!"
4942 : );
4943 0 : continue;
4944 : };
4945 :
4946 0 : let Some(secondary_node_id) = shard.intent.get_secondary().first() else {
4947 : // No secondary location. Nothing for us to do.
4948 0 : continue;
4949 : };
4950 :
4951 0 : let attached_node = locked
4952 0 : .nodes
4953 0 : .get(node_id)
4954 0 : .expect("Pageservers may not be deleted while referenced");
4955 0 :
4956 0 : let secondary_node = locked
4957 0 : .nodes
4958 0 : .get(secondary_node_id)
4959 0 : .expect("Pageservers may not be deleted while referenced");
4960 0 :
4961 0 : attached.push((*tenant_shard_id, attached_node.clone()));
4962 0 : secondary.push((*tenant_shard_id, secondary_node.clone()));
4963 : }
4964 0 : (attached, secondary)
4965 0 : };
4966 0 :
4967 0 : if secondary.is_empty() {
4968 : // No secondary locations; nothing for us to do
4969 0 : return;
4970 0 : }
4971 :
4972 0 : for result in self
4973 0 : .tenant_for_shards_api(
4974 0 : attached,
4975 0 : |tenant_shard_id, client| async move {
4976 0 : client.tenant_heatmap_upload(tenant_shard_id).await
4977 0 : },
4978 0 : 1,
4979 0 : 1,
4980 0 : SHORT_RECONCILE_TIMEOUT,
4981 0 : &self.cancel,
4982 0 : )
4983 0 : .await
4984 : {
4985 0 : if let Err(e) = result {
4986 0 : tracing::warn!("Error calling heatmap upload after shard split: {e}");
4987 0 : return;
4988 0 : }
4989 : }
4990 :
4991 0 : for result in self
4992 0 : .tenant_for_shards_api(
4993 0 : secondary,
4994 0 : |tenant_shard_id, client| async move {
4995 0 : client
4996 0 : .tenant_secondary_download(tenant_shard_id, Some(Duration::ZERO))
4997 0 : .await
4998 0 : },
4999 0 : 1,
5000 0 : 1,
5001 0 : SHORT_RECONCILE_TIMEOUT,
5002 0 : &self.cancel,
5003 0 : )
5004 0 : .await
5005 : {
5006 0 : if let Err(e) = result {
5007 0 : tracing::warn!("Error calling secondary download after shard split: {e}");
5008 0 : return;
5009 0 : }
5010 : }
5011 0 : }
5012 :
5013 0 : pub(crate) async fn tenant_shard_split(
5014 0 : &self,
5015 0 : tenant_id: TenantId,
5016 0 : split_req: TenantShardSplitRequest,
5017 0 : ) -> Result<TenantShardSplitResponse, ApiError> {
5018 : // TODO: return 503 if we get stuck waiting for this lock
5019 : // (issue https://github.com/neondatabase/neon/issues/7108)
5020 0 : let _tenant_lock = trace_exclusive_lock(
5021 0 : &self.tenant_op_locks,
5022 0 : tenant_id,
5023 0 : TenantOperations::ShardSplit,
5024 0 : )
5025 0 : .await;
5026 :
5027 0 : let new_shard_count = ShardCount::new(split_req.new_shard_count);
5028 0 : let new_stripe_size = split_req.new_stripe_size;
5029 :
5030 : // Validate the request and construct parameters. This phase is fallible, but does not require
5031 : // rollback on errors, as it does no I/O and mutates no state.
5032 0 : let shard_split_params = match self.prepare_tenant_shard_split(tenant_id, split_req)? {
5033 0 : ShardSplitAction::NoOp(resp) => return Ok(resp),
5034 0 : ShardSplitAction::Split(params) => params,
5035 : };
5036 :
5037 : // Execute this split: this phase mutates state and does remote I/O on pageservers. If it fails,
5038 : // we must roll back.
5039 0 : let r = self
5040 0 : .do_tenant_shard_split(tenant_id, shard_split_params)
5041 0 : .await;
5042 :
5043 0 : let (response, waiters) = match r {
5044 0 : Ok(r) => r,
5045 0 : Err(e) => {
5046 0 : // Split might be part-done, we must do work to abort it.
5047 0 : tracing::warn!("Enqueuing background abort of split on {tenant_id}");
5048 0 : self.abort_tx
5049 0 : .send(TenantShardSplitAbort {
5050 0 : tenant_id,
5051 0 : new_shard_count,
5052 0 : new_stripe_size,
5053 0 : _tenant_lock,
5054 0 : })
5055 0 : // Ignore error sending: that just means we're shutting down: aborts are ephemeral so it's fine to drop it.
5056 0 : .ok();
5057 0 : return Err(e);
5058 : }
5059 : };
5060 :
5061 : // The split is now complete. As an optimization, we will trigger all the child shards to upload
5062 : // a heatmap immediately, and all their secondary locations to start downloading: this avoids waiting
5063 : // for the background heatmap/download interval before secondaries get warm enough to migrate shards
5064 : // in [`Self::optimize_all`]
5065 0 : self.tenant_shard_split_start_secondaries(tenant_id, waiters)
5066 0 : .await;
5067 0 : Ok(response)
5068 0 : }
5069 :
5070 0 : fn prepare_tenant_shard_split(
5071 0 : &self,
5072 0 : tenant_id: TenantId,
5073 0 : split_req: TenantShardSplitRequest,
5074 0 : ) -> Result<ShardSplitAction, ApiError> {
5075 0 : fail::fail_point!("shard-split-validation", |_| Err(ApiError::BadRequest(
5076 0 : anyhow::anyhow!("failpoint")
5077 0 : )));
5078 :
5079 0 : let mut policy = None;
5080 0 : let mut config = None;
5081 0 : let mut shard_ident = None;
5082 0 : let mut preferred_az_id = None;
5083 : // Validate input, and calculate which shards we will create
5084 0 : let (old_shard_count, targets) =
5085 : {
5086 0 : let locked = self.inner.read().unwrap();
5087 0 :
5088 0 : let pageservers = locked.nodes.clone();
5089 0 :
5090 0 : let mut targets = Vec::new();
5091 0 :
5092 0 : // In case this is a retry, count how many already-split shards we found
5093 0 : let mut children_found = Vec::new();
5094 0 : let mut old_shard_count = None;
5095 :
5096 0 : for (tenant_shard_id, shard) in
5097 0 : locked.tenants.range(TenantShardId::tenant_range(tenant_id))
5098 : {
5099 0 : match shard.shard.count.count().cmp(&split_req.new_shard_count) {
5100 : Ordering::Equal => {
5101 : // Already split this
5102 0 : children_found.push(*tenant_shard_id);
5103 0 : continue;
5104 : }
5105 : Ordering::Greater => {
5106 0 : return Err(ApiError::BadRequest(anyhow::anyhow!(
5107 0 : "Requested count {} but already have shards at count {}",
5108 0 : split_req.new_shard_count,
5109 0 : shard.shard.count.count()
5110 0 : )));
5111 : }
5112 0 : Ordering::Less => {
5113 0 : // Fall through: this shard has lower count than requested,
5114 0 : // is a candidate for splitting.
5115 0 : }
5116 0 : }
5117 0 :
5118 0 : match old_shard_count {
5119 0 : None => old_shard_count = Some(shard.shard.count),
5120 0 : Some(old_shard_count) => {
5121 0 : if old_shard_count != shard.shard.count {
5122 : // We may hit this case if a caller asked for two splits to
5123 : // different sizes, before the first one is complete.
5124 : // e.g. 1->2, 2->4, where the 4 call comes while we have a mixture
5125 : // of shard_count=1 and shard_count=2 shards in the map.
5126 0 : return Err(ApiError::Conflict(
5127 0 : "Cannot split, currently mid-split".to_string(),
5128 0 : ));
5129 0 : }
5130 : }
5131 : }
5132 0 : if policy.is_none() {
5133 0 : policy = Some(shard.policy.clone());
5134 0 : }
5135 0 : if shard_ident.is_none() {
5136 0 : shard_ident = Some(shard.shard);
5137 0 : }
5138 0 : if config.is_none() {
5139 0 : config = Some(shard.config.clone());
5140 0 : }
5141 0 : if preferred_az_id.is_none() {
5142 0 : preferred_az_id = shard.preferred_az().cloned();
5143 0 : }
5144 :
5145 0 : if tenant_shard_id.shard_count.count() == split_req.new_shard_count {
5146 0 : tracing::info!(
5147 0 : "Tenant shard {} already has shard count {}",
5148 : tenant_shard_id,
5149 : split_req.new_shard_count
5150 : );
5151 0 : continue;
5152 0 : }
5153 :
5154 0 : let node_id = shard.intent.get_attached().ok_or(ApiError::BadRequest(
5155 0 : anyhow::anyhow!("Cannot split a tenant that is not attached"),
5156 0 : ))?;
5157 :
5158 0 : let node = pageservers
5159 0 : .get(&node_id)
5160 0 : .expect("Pageservers may not be deleted while referenced");
5161 0 :
5162 0 : targets.push(ShardSplitTarget {
5163 0 : parent_id: *tenant_shard_id,
5164 0 : node: node.clone(),
5165 0 : child_ids: tenant_shard_id
5166 0 : .split(ShardCount::new(split_req.new_shard_count)),
5167 0 : });
5168 : }
5169 :
5170 0 : if targets.is_empty() {
5171 0 : if children_found.len() == split_req.new_shard_count as usize {
5172 0 : return Ok(ShardSplitAction::NoOp(TenantShardSplitResponse {
5173 0 : new_shards: children_found,
5174 0 : }));
5175 : } else {
5176 : // No shards found to split, and no existing children found: the
5177 : // tenant doesn't exist at all.
5178 0 : return Err(ApiError::NotFound(
5179 0 : anyhow::anyhow!("Tenant {} not found", tenant_id).into(),
5180 0 : ));
5181 : }
5182 0 : }
5183 0 :
5184 0 : (old_shard_count, targets)
5185 0 : };
5186 0 :
5187 0 : // unwrap safety: we would have returned above if we didn't find at least one shard to split
5188 0 : let old_shard_count = old_shard_count.unwrap();
5189 0 : let shard_ident = if let Some(new_stripe_size) = split_req.new_stripe_size {
5190 : // This ShardIdentity will be used as the template for all children, so this implicitly
5191 : // applies the new stripe size to the children.
5192 0 : let mut shard_ident = shard_ident.unwrap();
5193 0 : if shard_ident.count.count() > 1 && shard_ident.stripe_size != new_stripe_size {
5194 0 : return Err(ApiError::BadRequest(anyhow::anyhow!(
5195 0 : "Attempted to change stripe size ({:?}->{new_stripe_size:?}) on a tenant with multiple shards",
5196 0 : shard_ident.stripe_size
5197 0 : )));
5198 0 : }
5199 0 :
5200 0 : shard_ident.stripe_size = new_stripe_size;
5201 0 : tracing::info!("applied stripe size {}", shard_ident.stripe_size.0);
5202 0 : shard_ident
5203 : } else {
5204 0 : shard_ident.unwrap()
5205 : };
5206 0 : let policy = policy.unwrap();
5207 0 : let config = config.unwrap();
5208 0 :
5209 0 : Ok(ShardSplitAction::Split(Box::new(ShardSplitParams {
5210 0 : old_shard_count,
5211 0 : new_shard_count: ShardCount::new(split_req.new_shard_count),
5212 0 : new_stripe_size: split_req.new_stripe_size,
5213 0 : targets,
5214 0 : policy,
5215 0 : config,
5216 0 : shard_ident,
5217 0 : preferred_az_id,
5218 0 : })))
5219 0 : }
5220 :
5221 0 : async fn do_tenant_shard_split(
5222 0 : &self,
5223 0 : tenant_id: TenantId,
5224 0 : params: Box<ShardSplitParams>,
5225 0 : ) -> Result<(TenantShardSplitResponse, Vec<ReconcilerWaiter>), ApiError> {
5226 0 : // FIXME: we have dropped self.inner lock, and not yet written anything to the database: another
5227 0 : // request could occur here, deleting or mutating the tenant. begin_shard_split checks that the
5228 0 : // parent shards exist as expected, but it would be neater to do the above pre-checks within the
5229 0 : // same database transaction rather than pre-check in-memory and then maybe-fail the database write.
5230 0 : // (https://github.com/neondatabase/neon/issues/6676)
5231 0 :
5232 0 : let ShardSplitParams {
5233 0 : old_shard_count,
5234 0 : new_shard_count,
5235 0 : new_stripe_size,
5236 0 : mut targets,
5237 0 : policy,
5238 0 : config,
5239 0 : shard_ident,
5240 0 : preferred_az_id,
5241 0 : } = *params;
5242 :
5243 : // Drop any secondary locations: pageservers do not support splitting these, and in any case the
5244 : // end-state for a split tenant will usually be to have secondary locations on different nodes.
5245 : // The reconciliation calls in this block also implicitly cancel+barrier wrt any ongoing reconciliation
5246 : // at the time of split.
5247 0 : let waiters = {
5248 0 : let mut locked = self.inner.write().unwrap();
5249 0 : let mut waiters = Vec::new();
5250 0 : let (nodes, tenants, scheduler) = locked.parts_mut();
5251 0 : for target in &mut targets {
5252 0 : let Some(shard) = tenants.get_mut(&target.parent_id) else {
5253 : // Paranoia check: this shouldn't happen: we have the oplock for this tenant ID.
5254 0 : return Err(ApiError::InternalServerError(anyhow::anyhow!(
5255 0 : "Shard {} not found",
5256 0 : target.parent_id
5257 0 : )));
5258 : };
5259 :
5260 0 : if shard.intent.get_attached() != &Some(target.node.get_id()) {
5261 : // Paranoia check: this shouldn't happen: we have the oplock for this tenant ID.
5262 0 : return Err(ApiError::Conflict(format!(
5263 0 : "Shard {} unexpectedly rescheduled during split",
5264 0 : target.parent_id
5265 0 : )));
5266 0 : }
5267 0 :
5268 0 : // Irrespective of PlacementPolicy, clear secondary locations from intent
5269 0 : shard.intent.clear_secondary(scheduler);
5270 :
5271 : // Run Reconciler to execute detach fo secondary locations.
5272 0 : if let Some(waiter) =
5273 0 : self.maybe_reconcile_shard(shard, nodes, ReconcilerPriority::High)
5274 0 : {
5275 0 : waiters.push(waiter);
5276 0 : }
5277 : }
5278 0 : waiters
5279 0 : };
5280 0 : self.await_waiters(waiters, RECONCILE_TIMEOUT).await?;
5281 :
5282 : // Before creating any new child shards in memory or on the pageservers, persist them: this
5283 : // enables us to ensure that we will always be able to clean up if something goes wrong. This also
5284 : // acts as the protection against two concurrent attempts to split: one of them will get a database
5285 : // error trying to insert the child shards.
5286 0 : let mut child_tsps = Vec::new();
5287 0 : for target in &targets {
5288 0 : let mut this_child_tsps = Vec::new();
5289 0 : for child in &target.child_ids {
5290 0 : let mut child_shard = shard_ident;
5291 0 : child_shard.number = child.shard_number;
5292 0 : child_shard.count = child.shard_count;
5293 0 :
5294 0 : tracing::info!(
5295 0 : "Create child shard persistence with stripe size {}",
5296 : shard_ident.stripe_size.0
5297 : );
5298 :
5299 0 : this_child_tsps.push(TenantShardPersistence {
5300 0 : tenant_id: child.tenant_id.to_string(),
5301 0 : shard_number: child.shard_number.0 as i32,
5302 0 : shard_count: child.shard_count.literal() as i32,
5303 0 : shard_stripe_size: shard_ident.stripe_size.0 as i32,
5304 0 : // Note: this generation is a placeholder, [`Persistence::begin_shard_split`] will
5305 0 : // populate the correct generation as part of its transaction, to protect us
5306 0 : // against racing with changes in the state of the parent.
5307 0 : generation: None,
5308 0 : generation_pageserver: Some(target.node.get_id().0 as i64),
5309 0 : placement_policy: serde_json::to_string(&policy).unwrap(),
5310 0 : config: serde_json::to_string(&config).unwrap(),
5311 0 : splitting: SplitState::Splitting,
5312 0 :
5313 0 : // Scheduling policies and preferred AZ do not carry through to children
5314 0 : scheduling_policy: serde_json::to_string(&ShardSchedulingPolicy::default())
5315 0 : .unwrap(),
5316 0 : preferred_az_id: preferred_az_id.as_ref().map(|az| az.0.clone()),
5317 0 : });
5318 0 : }
5319 :
5320 0 : child_tsps.push((target.parent_id, this_child_tsps));
5321 : }
5322 :
5323 0 : if let Err(e) = self
5324 0 : .persistence
5325 0 : .begin_shard_split(old_shard_count, tenant_id, child_tsps)
5326 0 : .await
5327 : {
5328 0 : match e {
5329 : DatabaseError::Query(diesel::result::Error::DatabaseError(
5330 : DatabaseErrorKind::UniqueViolation,
5331 : _,
5332 : )) => {
5333 : // Inserting a child shard violated a unique constraint: we raced with another call to
5334 : // this function
5335 0 : tracing::warn!("Conflicting attempt to split {tenant_id}: {e}");
5336 0 : return Err(ApiError::Conflict("Tenant is already splitting".into()));
5337 : }
5338 0 : _ => return Err(ApiError::InternalServerError(e.into())),
5339 : }
5340 0 : }
5341 0 : fail::fail_point!("shard-split-post-begin", |_| Err(
5342 0 : ApiError::InternalServerError(anyhow::anyhow!("failpoint"))
5343 0 : ));
5344 :
5345 : // Now that I have persisted the splitting state, apply it in-memory. This is infallible, so
5346 : // callers may assume that if splitting is set in memory, then it was persisted, and if splitting
5347 : // is not set in memory, then it was not persisted.
5348 : {
5349 0 : let mut locked = self.inner.write().unwrap();
5350 0 : for target in &targets {
5351 0 : if let Some(parent_shard) = locked.tenants.get_mut(&target.parent_id) {
5352 0 : parent_shard.splitting = SplitState::Splitting;
5353 0 : // Put the observed state to None, to reflect that it is indeterminate once we start the
5354 0 : // split operation.
5355 0 : parent_shard
5356 0 : .observed
5357 0 : .locations
5358 0 : .insert(target.node.get_id(), ObservedStateLocation { conf: None });
5359 0 : }
5360 : }
5361 : }
5362 :
5363 : // TODO: issue split calls concurrently (this only matters once we're splitting
5364 : // N>1 shards into M shards -- initially we're usually splitting 1 shard into N).
5365 :
5366 0 : for target in &targets {
5367 : let ShardSplitTarget {
5368 0 : parent_id,
5369 0 : node,
5370 0 : child_ids,
5371 0 : } = target;
5372 0 : let client = PageserverClient::new(
5373 0 : node.get_id(),
5374 0 : node.base_url(),
5375 0 : self.config.pageserver_jwt_token.as_deref(),
5376 0 : self.config.ssl_ca_cert.clone(),
5377 0 : )
5378 0 : .map_err(|e| passthrough_api_error(node, e))?;
5379 0 : let response = client
5380 0 : .tenant_shard_split(
5381 0 : *parent_id,
5382 0 : TenantShardSplitRequest {
5383 0 : new_shard_count: new_shard_count.literal(),
5384 0 : new_stripe_size,
5385 0 : },
5386 0 : )
5387 0 : .await
5388 0 : .map_err(|e| ApiError::Conflict(format!("Failed to split {}: {}", parent_id, e)))?;
5389 :
5390 0 : fail::fail_point!("shard-split-post-remote", |_| Err(ApiError::Conflict(
5391 0 : "failpoint".to_string()
5392 0 : )));
5393 :
5394 0 : failpoint_support::sleep_millis_async!("shard-split-post-remote-sleep", &self.cancel);
5395 :
5396 0 : tracing::info!(
5397 0 : "Split {} into {}",
5398 0 : parent_id,
5399 0 : response
5400 0 : .new_shards
5401 0 : .iter()
5402 0 : .map(|s| format!("{:?}", s))
5403 0 : .collect::<Vec<_>>()
5404 0 : .join(",")
5405 : );
5406 :
5407 0 : if &response.new_shards != child_ids {
5408 : // This should never happen: the pageserver should agree with us on how shard splits work.
5409 0 : return Err(ApiError::InternalServerError(anyhow::anyhow!(
5410 0 : "Splitting shard {} resulted in unexpected IDs: {:?} (expected {:?})",
5411 0 : parent_id,
5412 0 : response.new_shards,
5413 0 : child_ids
5414 0 : )));
5415 0 : }
5416 : }
5417 :
5418 : // TODO: if the pageserver restarted concurrently with our split API call,
5419 : // the actual generation of the child shard might differ from the generation
5420 : // we expect it to have. In order for our in-database generation to end up
5421 : // correct, we should carry the child generation back in the response and apply it here
5422 : // in complete_shard_split (and apply the correct generation in memory)
5423 : // (or, we can carry generation in the request and reject the request if
5424 : // it doesn't match, but that requires more retry logic on this side)
5425 :
5426 0 : self.persistence
5427 0 : .complete_shard_split(tenant_id, old_shard_count, new_shard_count)
5428 0 : .await?;
5429 :
5430 0 : fail::fail_point!("shard-split-post-complete", |_| Err(
5431 0 : ApiError::InternalServerError(anyhow::anyhow!("failpoint"))
5432 0 : ));
5433 :
5434 : // Replace all the shards we just split with their children: this phase is infallible.
5435 0 : let (response, child_locations, waiters) =
5436 0 : self.tenant_shard_split_commit_inmem(tenant_id, new_shard_count, new_stripe_size);
5437 0 :
5438 0 : // Send compute notifications for all the new shards
5439 0 : let mut failed_notifications = Vec::new();
5440 0 : for (child_id, child_ps, stripe_size) in child_locations {
5441 0 : if let Err(e) = self
5442 0 : .compute_hook
5443 0 : .notify(
5444 0 : compute_hook::ShardUpdate {
5445 0 : tenant_shard_id: child_id,
5446 0 : node_id: child_ps,
5447 0 : stripe_size,
5448 0 : preferred_az: preferred_az_id.as_ref().map(Cow::Borrowed),
5449 0 : },
5450 0 : &self.cancel,
5451 0 : )
5452 0 : .await
5453 : {
5454 0 : tracing::warn!(
5455 0 : "Failed to update compute of {}->{} during split, proceeding anyway to complete split ({e})",
5456 : child_id,
5457 : child_ps
5458 : );
5459 0 : failed_notifications.push(child_id);
5460 0 : }
5461 : }
5462 :
5463 : // If we failed any compute notifications, make a note to retry later.
5464 0 : if !failed_notifications.is_empty() {
5465 0 : let mut locked = self.inner.write().unwrap();
5466 0 : for failed in failed_notifications {
5467 0 : if let Some(shard) = locked.tenants.get_mut(&failed) {
5468 0 : shard.pending_compute_notification = true;
5469 0 : }
5470 : }
5471 0 : }
5472 :
5473 0 : Ok((response, waiters))
5474 0 : }
5475 :
5476 : /// A graceful migration: update the preferred node and let optimisation handle the migration
5477 : /// in the background (may take a long time as it will fully warm up a location before cutting over)
5478 : ///
5479 : /// Our external API calls this a 'prewarm=true' migration, but internally it isn't a special prewarm step: it's
5480 : /// just a migration that uses the same graceful procedure as our background scheduling optimisations would use.
5481 0 : fn tenant_shard_migrate_with_prewarm(
5482 0 : &self,
5483 0 : migrate_req: &TenantShardMigrateRequest,
5484 0 : shard: &mut TenantShard,
5485 0 : scheduler: &mut Scheduler,
5486 0 : schedule_context: ScheduleContext,
5487 0 : ) -> Result<Option<ScheduleOptimization>, ApiError> {
5488 0 : shard.set_preferred_node(Some(migrate_req.node_id));
5489 0 :
5490 0 : // Generate whatever the initial change to the intent is: this could be creation of a secondary, or
5491 0 : // cutting over to an existing secondary. Caller is responsible for validating this before applying it,
5492 0 : // e.g. by checking secondary is warm enough.
5493 0 : Ok(shard.optimize_attachment(scheduler, &schedule_context))
5494 0 : }
5495 :
5496 : /// Immediate migration: directly update the intent state and kick off a reconciler
5497 0 : fn tenant_shard_migrate_immediate(
5498 0 : &self,
5499 0 : migrate_req: &TenantShardMigrateRequest,
5500 0 : nodes: &Arc<HashMap<NodeId, Node>>,
5501 0 : shard: &mut TenantShard,
5502 0 : scheduler: &mut Scheduler,
5503 0 : ) -> Result<Option<ReconcilerWaiter>, ApiError> {
5504 0 : // Non-graceful migration: update the intent state immediately
5505 0 : let old_attached = *shard.intent.get_attached();
5506 0 : match shard.policy {
5507 0 : PlacementPolicy::Attached(n) => {
5508 0 : // If our new attached node was a secondary, it no longer should be.
5509 0 : shard
5510 0 : .intent
5511 0 : .remove_secondary(scheduler, migrate_req.node_id);
5512 0 :
5513 0 : shard
5514 0 : .intent
5515 0 : .set_attached(scheduler, Some(migrate_req.node_id));
5516 :
5517 : // If we were already attached to something, demote that to a secondary
5518 0 : if let Some(old_attached) = old_attached {
5519 0 : if n > 0 {
5520 : // Remove other secondaries to make room for the location we'll demote
5521 0 : while shard.intent.get_secondary().len() >= n {
5522 0 : shard.intent.pop_secondary(scheduler);
5523 0 : }
5524 :
5525 0 : shard.intent.push_secondary(scheduler, old_attached);
5526 0 : }
5527 0 : }
5528 : }
5529 0 : PlacementPolicy::Secondary => {
5530 0 : shard.intent.clear(scheduler);
5531 0 : shard.intent.push_secondary(scheduler, migrate_req.node_id);
5532 0 : }
5533 : PlacementPolicy::Detached => {
5534 0 : return Err(ApiError::BadRequest(anyhow::anyhow!(
5535 0 : "Cannot migrate a tenant that is PlacementPolicy::Detached: configure it to an attached policy first"
5536 0 : )));
5537 : }
5538 : }
5539 :
5540 0 : tracing::info!("Migrating: new intent {:?}", shard.intent);
5541 0 : shard.sequence = shard.sequence.next();
5542 0 : shard.set_preferred_node(None); // Abort any in-flight graceful migration
5543 0 : Ok(self.maybe_configured_reconcile_shard(
5544 0 : shard,
5545 0 : nodes,
5546 0 : (&migrate_req.migration_config).into(),
5547 0 : ))
5548 0 : }
5549 :
5550 0 : pub(crate) async fn tenant_shard_migrate(
5551 0 : &self,
5552 0 : tenant_shard_id: TenantShardId,
5553 0 : migrate_req: TenantShardMigrateRequest,
5554 0 : ) -> Result<TenantShardMigrateResponse, ApiError> {
5555 : // Depending on whether the migration is a change and whether it's graceful or immediate, we might
5556 : // get a different outcome to handle
5557 : enum MigrationOutcome {
5558 : Optimization(Option<ScheduleOptimization>),
5559 : Reconcile(Option<ReconcilerWaiter>),
5560 : }
5561 :
5562 0 : let outcome = {
5563 0 : let mut locked = self.inner.write().unwrap();
5564 0 : let (nodes, tenants, scheduler) = locked.parts_mut();
5565 :
5566 0 : let Some(node) = nodes.get(&migrate_req.node_id) else {
5567 0 : return Err(ApiError::BadRequest(anyhow::anyhow!(
5568 0 : "Node {} not found",
5569 0 : migrate_req.node_id
5570 0 : )));
5571 : };
5572 :
5573 : // Migration to unavavailable node requires force flag
5574 0 : if !node.is_available() {
5575 0 : if migrate_req.migration_config.override_scheduler {
5576 : // Warn but proceed: the caller may intend to manually adjust the placement of
5577 : // a shard even if the node is down, e.g. if intervening during an incident.
5578 0 : tracing::warn!("Forcibly migrating to unavailable node {node}");
5579 : } else {
5580 0 : tracing::warn!("Node {node} is unavailable, refusing migration");
5581 0 : return Err(ApiError::PreconditionFailed(
5582 0 : format!("Node {node} is unavailable").into_boxed_str(),
5583 0 : ));
5584 : }
5585 0 : }
5586 :
5587 : // Calculate the ScheduleContext for this tenant
5588 0 : let mut schedule_context = ScheduleContext::default();
5589 0 : for (_shard_id, shard) in
5590 0 : tenants.range(TenantShardId::tenant_range(tenant_shard_id.tenant_id))
5591 0 : {
5592 0 : schedule_context.avoid(&shard.intent.all_pageservers());
5593 0 : }
5594 :
5595 : // Look up the specific shard we will migrate
5596 0 : let Some(shard) = tenants.get_mut(&tenant_shard_id) else {
5597 0 : return Err(ApiError::NotFound(
5598 0 : anyhow::anyhow!("Tenant shard not found").into(),
5599 0 : ));
5600 : };
5601 :
5602 : // Migration to a node with unfavorable scheduling score requires a force flag, because it might just
5603 : // be migrated back by the optimiser.
5604 0 : if let Some(better_node) = shard.find_better_location::<AttachedShardTag>(
5605 0 : scheduler,
5606 0 : &schedule_context,
5607 0 : migrate_req.node_id,
5608 0 : &[],
5609 0 : ) {
5610 0 : if !migrate_req.migration_config.override_scheduler {
5611 0 : return Err(ApiError::PreconditionFailed(
5612 0 : "Migration to a worse-scoring node".into(),
5613 0 : ));
5614 : } else {
5615 0 : tracing::info!(
5616 0 : "Migrating to a worse-scoring node {} (optimiser would prefer {better_node})",
5617 : migrate_req.node_id
5618 : );
5619 : }
5620 0 : }
5621 :
5622 0 : if let Some(origin_node_id) = migrate_req.origin_node_id {
5623 0 : if shard.intent.get_attached() != &Some(origin_node_id) {
5624 0 : return Err(ApiError::PreconditionFailed(
5625 0 : format!(
5626 0 : "Migration expected to originate from {} but shard is on {:?}",
5627 0 : origin_node_id,
5628 0 : shard.intent.get_attached()
5629 0 : )
5630 0 : .into(),
5631 0 : ));
5632 0 : }
5633 0 : }
5634 :
5635 0 : if shard.intent.get_attached() == &Some(migrate_req.node_id) {
5636 : // No-op case: we will still proceed to wait for reconciliation in case it is
5637 : // incomplete from an earlier update to the intent.
5638 0 : tracing::info!("Migrating: intent is unchanged {:?}", shard.intent);
5639 :
5640 : // An instruction to migrate to the currently attached node should
5641 : // cancel any pending graceful migration
5642 0 : shard.set_preferred_node(None);
5643 0 :
5644 0 : MigrationOutcome::Reconcile(self.maybe_configured_reconcile_shard(
5645 0 : shard,
5646 0 : nodes,
5647 0 : (&migrate_req.migration_config).into(),
5648 0 : ))
5649 0 : } else if migrate_req.migration_config.prewarm {
5650 0 : MigrationOutcome::Optimization(self.tenant_shard_migrate_with_prewarm(
5651 0 : &migrate_req,
5652 0 : shard,
5653 0 : scheduler,
5654 0 : schedule_context,
5655 0 : )?)
5656 : } else {
5657 0 : MigrationOutcome::Reconcile(self.tenant_shard_migrate_immediate(
5658 0 : &migrate_req,
5659 0 : nodes,
5660 0 : shard,
5661 0 : scheduler,
5662 0 : )?)
5663 : }
5664 : };
5665 :
5666 : // We may need to validate + apply an optimisation, or we may need to just retrive a reconcile waiter
5667 0 : let waiter = match outcome {
5668 0 : MigrationOutcome::Optimization(Some(optimization)) => {
5669 : // Validate and apply the optimization -- this would happen anyway in background reconcile loop, but
5670 : // we might as well do it more promptly as this is a direct external request.
5671 0 : let mut validated = self
5672 0 : .optimize_all_validate(vec![(tenant_shard_id, optimization)])
5673 0 : .await;
5674 0 : if let Some((_shard_id, optimization)) = validated.pop() {
5675 0 : let mut locked = self.inner.write().unwrap();
5676 0 : let (nodes, tenants, scheduler) = locked.parts_mut();
5677 0 : let Some(shard) = tenants.get_mut(&tenant_shard_id) else {
5678 : // Rare but possible: tenant is removed between generating optimisation and validating it.
5679 0 : return Err(ApiError::NotFound(
5680 0 : anyhow::anyhow!("Tenant shard not found").into(),
5681 0 : ));
5682 : };
5683 :
5684 0 : if !shard.apply_optimization(scheduler, optimization) {
5685 : // This can happen but is unusual enough to warn on: something else changed in the shard that made the optimisation stale
5686 : // and therefore not applied.
5687 0 : tracing::warn!(
5688 0 : "Schedule optimisation generated during graceful migration was not applied, shard changed?"
5689 : );
5690 0 : }
5691 0 : self.maybe_configured_reconcile_shard(
5692 0 : shard,
5693 0 : nodes,
5694 0 : (&migrate_req.migration_config).into(),
5695 0 : )
5696 : } else {
5697 0 : None
5698 : }
5699 : }
5700 0 : MigrationOutcome::Optimization(None) => None,
5701 0 : MigrationOutcome::Reconcile(waiter) => waiter,
5702 : };
5703 :
5704 : // Finally, wait for any reconcile we started to complete. In the case of immediate-mode migrations to cold
5705 : // locations, this has a good chance of timing out.
5706 0 : if let Some(waiter) = waiter {
5707 0 : waiter.wait_timeout(RECONCILE_TIMEOUT).await?;
5708 : } else {
5709 0 : tracing::info!("Migration is a no-op");
5710 : }
5711 :
5712 0 : Ok(TenantShardMigrateResponse {})
5713 0 : }
5714 :
5715 0 : pub(crate) async fn tenant_shard_migrate_secondary(
5716 0 : &self,
5717 0 : tenant_shard_id: TenantShardId,
5718 0 : migrate_req: TenantShardMigrateRequest,
5719 0 : ) -> Result<TenantShardMigrateResponse, ApiError> {
5720 0 : let waiter = {
5721 0 : let mut locked = self.inner.write().unwrap();
5722 0 : let (nodes, tenants, scheduler) = locked.parts_mut();
5723 :
5724 0 : let Some(node) = nodes.get(&migrate_req.node_id) else {
5725 0 : return Err(ApiError::BadRequest(anyhow::anyhow!(
5726 0 : "Node {} not found",
5727 0 : migrate_req.node_id
5728 0 : )));
5729 : };
5730 :
5731 0 : if !node.is_available() {
5732 : // Warn but proceed: the caller may intend to manually adjust the placement of
5733 : // a shard even if the node is down, e.g. if intervening during an incident.
5734 0 : tracing::warn!("Migrating to unavailable node {node}");
5735 0 : }
5736 :
5737 0 : let Some(shard) = tenants.get_mut(&tenant_shard_id) else {
5738 0 : return Err(ApiError::NotFound(
5739 0 : anyhow::anyhow!("Tenant shard not found").into(),
5740 0 : ));
5741 : };
5742 :
5743 0 : if shard.intent.get_secondary().len() == 1
5744 0 : && shard.intent.get_secondary()[0] == migrate_req.node_id
5745 : {
5746 0 : tracing::info!(
5747 0 : "Migrating secondary to {node}: intent is unchanged {:?}",
5748 : shard.intent
5749 : );
5750 0 : } else if shard.intent.get_attached() == &Some(migrate_req.node_id) {
5751 0 : tracing::info!(
5752 0 : "Migrating secondary to {node}: already attached where we were asked to create a secondary"
5753 : );
5754 : } else {
5755 0 : let old_secondaries = shard.intent.get_secondary().clone();
5756 0 : for secondary in old_secondaries {
5757 0 : shard.intent.remove_secondary(scheduler, secondary);
5758 0 : }
5759 :
5760 0 : shard.intent.push_secondary(scheduler, migrate_req.node_id);
5761 0 : shard.sequence = shard.sequence.next();
5762 0 : tracing::info!(
5763 0 : "Migrating secondary to {node}: new intent {:?}",
5764 : shard.intent
5765 : );
5766 : }
5767 :
5768 0 : self.maybe_reconcile_shard(shard, nodes, ReconcilerPriority::High)
5769 : };
5770 :
5771 0 : if let Some(waiter) = waiter {
5772 0 : waiter.wait_timeout(RECONCILE_TIMEOUT).await?;
5773 : } else {
5774 0 : tracing::info!("Migration is a no-op");
5775 : }
5776 :
5777 0 : Ok(TenantShardMigrateResponse {})
5778 0 : }
5779 :
5780 : /// 'cancel' in this context means cancel any ongoing reconcile
5781 0 : pub(crate) async fn tenant_shard_cancel_reconcile(
5782 0 : &self,
5783 0 : tenant_shard_id: TenantShardId,
5784 0 : ) -> Result<(), ApiError> {
5785 : // Take state lock and fire the cancellation token, after which we drop lock and wait for any ongoing reconcile to complete
5786 0 : let waiter = {
5787 0 : let locked = self.inner.write().unwrap();
5788 0 : let Some(shard) = locked.tenants.get(&tenant_shard_id) else {
5789 0 : return Err(ApiError::NotFound(
5790 0 : anyhow::anyhow!("Tenant shard not found").into(),
5791 0 : ));
5792 : };
5793 :
5794 0 : let waiter = shard.get_waiter();
5795 0 : match waiter {
5796 : None => {
5797 0 : tracing::info!("Shard does not have an ongoing Reconciler");
5798 0 : return Ok(());
5799 : }
5800 0 : Some(waiter) => {
5801 0 : tracing::info!("Cancelling Reconciler");
5802 0 : shard.cancel_reconciler();
5803 0 : waiter
5804 0 : }
5805 0 : }
5806 0 : };
5807 0 :
5808 0 : // Cancellation should be prompt. If this fails we have still done our job of firing the
5809 0 : // cancellation token, but by returning an ApiError we will indicate to the caller that
5810 0 : // the Reconciler is misbehaving and not respecting the cancellation token
5811 0 : self.await_waiters(vec![waiter], SHORT_RECONCILE_TIMEOUT)
5812 0 : .await?;
5813 :
5814 0 : Ok(())
5815 0 : }
5816 :
5817 : /// This is for debug/support only: we simply drop all state for a tenant, without
5818 : /// detaching or deleting it on pageservers.
5819 0 : pub(crate) async fn tenant_drop(&self, tenant_id: TenantId) -> Result<(), ApiError> {
5820 0 : self.persistence.delete_tenant(tenant_id).await?;
5821 :
5822 0 : let mut locked = self.inner.write().unwrap();
5823 0 : let (_nodes, tenants, scheduler) = locked.parts_mut();
5824 0 : let mut shards = Vec::new();
5825 0 : for (tenant_shard_id, _) in tenants.range(TenantShardId::tenant_range(tenant_id)) {
5826 0 : shards.push(*tenant_shard_id);
5827 0 : }
5828 :
5829 0 : for shard_id in shards {
5830 0 : if let Some(mut shard) = tenants.remove(&shard_id) {
5831 0 : shard.intent.clear(scheduler);
5832 0 : }
5833 : }
5834 :
5835 0 : Ok(())
5836 0 : }
5837 :
5838 : /// This is for debug/support only: assuming tenant data is already present in S3, we "create" a
5839 : /// tenant with a very high generation number so that it will see the existing data.
5840 0 : pub(crate) async fn tenant_import(
5841 0 : &self,
5842 0 : tenant_id: TenantId,
5843 0 : ) -> Result<TenantCreateResponse, ApiError> {
5844 0 : // Pick an arbitrary available pageserver to use for scanning the tenant in remote storage
5845 0 : let maybe_node = {
5846 0 : self.inner
5847 0 : .read()
5848 0 : .unwrap()
5849 0 : .nodes
5850 0 : .values()
5851 0 : .find(|n| n.is_available())
5852 0 : .cloned()
5853 : };
5854 0 : let Some(node) = maybe_node else {
5855 0 : return Err(ApiError::BadRequest(anyhow::anyhow!("No nodes available")));
5856 : };
5857 :
5858 0 : let client = PageserverClient::new(
5859 0 : node.get_id(),
5860 0 : node.base_url(),
5861 0 : self.config.pageserver_jwt_token.as_deref(),
5862 0 : self.config.ssl_ca_cert.clone(),
5863 0 : )
5864 0 : .map_err(|e| passthrough_api_error(&node, e))?;
5865 :
5866 0 : let scan_result = client
5867 0 : .tenant_scan_remote_storage(tenant_id)
5868 0 : .await
5869 0 : .map_err(|e| passthrough_api_error(&node, e))?;
5870 :
5871 : // A post-split tenant may contain a mixture of shard counts in remote storage: pick the highest count.
5872 0 : let Some(shard_count) = scan_result
5873 0 : .shards
5874 0 : .iter()
5875 0 : .map(|s| s.tenant_shard_id.shard_count)
5876 0 : .max()
5877 : else {
5878 0 : return Err(ApiError::NotFound(
5879 0 : anyhow::anyhow!("No shards found").into(),
5880 0 : ));
5881 : };
5882 :
5883 : // Ideally we would set each newly imported shard's generation independently, but for correctness it is sufficient
5884 : // to
5885 0 : let generation = scan_result
5886 0 : .shards
5887 0 : .iter()
5888 0 : .map(|s| s.generation)
5889 0 : .max()
5890 0 : .expect("We already validated >0 shards");
5891 0 :
5892 0 : // FIXME: we have no way to recover the shard stripe size from contents of remote storage: this will
5893 0 : // only work if they were using the default stripe size.
5894 0 : let stripe_size = ShardParameters::DEFAULT_STRIPE_SIZE;
5895 :
5896 0 : let (response, waiters) = self
5897 0 : .do_tenant_create(TenantCreateRequest {
5898 0 : new_tenant_id: TenantShardId::unsharded(tenant_id),
5899 0 : generation,
5900 0 :
5901 0 : shard_parameters: ShardParameters {
5902 0 : count: shard_count,
5903 0 : stripe_size,
5904 0 : },
5905 0 : placement_policy: Some(PlacementPolicy::Attached(0)), // No secondaries, for convenient debug/hacking
5906 0 : config: TenantConfig::default(),
5907 0 : })
5908 0 : .await?;
5909 :
5910 0 : if let Err(e) = self.await_waiters(waiters, SHORT_RECONCILE_TIMEOUT).await {
5911 : // Since this is a debug/support operation, all kinds of weird issues are possible (e.g. this
5912 : // tenant doesn't exist in the control plane), so don't fail the request if it can't fully
5913 : // reconcile, as reconciliation includes notifying compute.
5914 0 : tracing::warn!(%tenant_id, "Reconcile not done yet while importing tenant ({e})");
5915 0 : }
5916 :
5917 0 : Ok(response)
5918 0 : }
5919 :
5920 : /// For debug/support: a full JSON dump of TenantShards. Returns a response so that
5921 : /// we don't have to make TenantShard clonable in the return path.
5922 0 : pub(crate) fn tenants_dump(&self) -> Result<hyper::Response<hyper::Body>, ApiError> {
5923 0 : let serialized = {
5924 0 : let locked = self.inner.read().unwrap();
5925 0 : let result = locked.tenants.values().collect::<Vec<_>>();
5926 0 : serde_json::to_string(&result).map_err(|e| ApiError::InternalServerError(e.into()))?
5927 : };
5928 :
5929 0 : hyper::Response::builder()
5930 0 : .status(hyper::StatusCode::OK)
5931 0 : .header(hyper::header::CONTENT_TYPE, "application/json")
5932 0 : .body(hyper::Body::from(serialized))
5933 0 : .map_err(|e| ApiError::InternalServerError(e.into()))
5934 0 : }
5935 :
5936 : /// Check the consistency of in-memory state vs. persistent state, and check that the
5937 : /// scheduler's statistics are up to date.
5938 : ///
5939 : /// These consistency checks expect an **idle** system. If changes are going on while
5940 : /// we run, then we can falsely indicate a consistency issue. This is sufficient for end-of-test
5941 : /// checks, but not suitable for running continuously in the background in the field.
5942 0 : pub(crate) async fn consistency_check(&self) -> Result<(), ApiError> {
5943 0 : let (mut expect_nodes, mut expect_shards) = {
5944 0 : let locked = self.inner.read().unwrap();
5945 0 :
5946 0 : locked
5947 0 : .scheduler
5948 0 : .consistency_check(locked.nodes.values(), locked.tenants.values())
5949 0 : .context("Scheduler checks")
5950 0 : .map_err(ApiError::InternalServerError)?;
5951 :
5952 0 : let expect_nodes = locked
5953 0 : .nodes
5954 0 : .values()
5955 0 : .map(|n| n.to_persistent())
5956 0 : .collect::<Vec<_>>();
5957 0 :
5958 0 : let expect_shards = locked
5959 0 : .tenants
5960 0 : .values()
5961 0 : .map(|t| t.to_persistent())
5962 0 : .collect::<Vec<_>>();
5963 :
5964 : // This method can only validate the state of an idle system: if a reconcile is in
5965 : // progress, fail out early to avoid giving false errors on state that won't match
5966 : // between database and memory under a ReconcileResult is processed.
5967 0 : for t in locked.tenants.values() {
5968 0 : if t.reconciler.is_some() {
5969 0 : return Err(ApiError::InternalServerError(anyhow::anyhow!(
5970 0 : "Shard {} reconciliation in progress",
5971 0 : t.tenant_shard_id
5972 0 : )));
5973 0 : }
5974 : }
5975 :
5976 0 : (expect_nodes, expect_shards)
5977 : };
5978 :
5979 0 : let mut nodes = self.persistence.list_nodes().await?;
5980 0 : expect_nodes.sort_by_key(|n| n.node_id);
5981 0 : nodes.sort_by_key(|n| n.node_id);
5982 :
5983 : // Errors relating to nodes are deferred so that we don't skip the shard checks below if we have a node error
5984 0 : let node_result = if nodes != expect_nodes {
5985 0 : tracing::error!("Consistency check failed on nodes.");
5986 0 : tracing::error!(
5987 0 : "Nodes in memory: {}",
5988 0 : serde_json::to_string(&expect_nodes)
5989 0 : .map_err(|e| ApiError::InternalServerError(e.into()))?
5990 : );
5991 0 : tracing::error!(
5992 0 : "Nodes in database: {}",
5993 0 : serde_json::to_string(&nodes)
5994 0 : .map_err(|e| ApiError::InternalServerError(e.into()))?
5995 : );
5996 0 : Err(ApiError::InternalServerError(anyhow::anyhow!(
5997 0 : "Node consistency failure"
5998 0 : )))
5999 : } else {
6000 0 : Ok(())
6001 : };
6002 :
6003 0 : let mut persistent_shards = self.persistence.load_active_tenant_shards().await?;
6004 0 : persistent_shards
6005 0 : .sort_by_key(|tsp| (tsp.tenant_id.clone(), tsp.shard_number, tsp.shard_count));
6006 0 :
6007 0 : expect_shards.sort_by_key(|tsp| (tsp.tenant_id.clone(), tsp.shard_number, tsp.shard_count));
6008 :
6009 : // Because JSON contents of persistent tenants might disagree with the fields in current `TenantConfig`
6010 : // definition, we will do an encode/decode cycle to ensure any legacy fields are dropped and any new
6011 : // fields are added, before doing a comparison.
6012 0 : for tsp in &mut persistent_shards {
6013 0 : let config: TenantConfig = serde_json::from_str(&tsp.config)
6014 0 : .map_err(|e| ApiError::InternalServerError(e.into()))?;
6015 0 : tsp.config = serde_json::to_string(&config).expect("Encoding config is infallible");
6016 : }
6017 :
6018 0 : if persistent_shards != expect_shards {
6019 0 : tracing::error!("Consistency check failed on shards.");
6020 :
6021 0 : tracing::error!(
6022 0 : "Shards in memory: {}",
6023 0 : serde_json::to_string(&expect_shards)
6024 0 : .map_err(|e| ApiError::InternalServerError(e.into()))?
6025 : );
6026 0 : tracing::error!(
6027 0 : "Shards in database: {}",
6028 0 : serde_json::to_string(&persistent_shards)
6029 0 : .map_err(|e| ApiError::InternalServerError(e.into()))?
6030 : );
6031 :
6032 : // The total dump log lines above are useful in testing but in the field grafana will
6033 : // usually just drop them because they're so large. So we also do some explicit logging
6034 : // of just the diffs.
6035 0 : let persistent_shards = persistent_shards
6036 0 : .into_iter()
6037 0 : .map(|tsp| (tsp.get_tenant_shard_id().unwrap(), tsp))
6038 0 : .collect::<HashMap<_, _>>();
6039 0 : let expect_shards = expect_shards
6040 0 : .into_iter()
6041 0 : .map(|tsp| (tsp.get_tenant_shard_id().unwrap(), tsp))
6042 0 : .collect::<HashMap<_, _>>();
6043 0 : for (tenant_shard_id, persistent_tsp) in &persistent_shards {
6044 0 : match expect_shards.get(tenant_shard_id) {
6045 : None => {
6046 0 : tracing::error!(
6047 0 : "Shard {} found in database but not in memory",
6048 : tenant_shard_id
6049 : );
6050 : }
6051 0 : Some(expect_tsp) => {
6052 0 : if expect_tsp != persistent_tsp {
6053 0 : tracing::error!(
6054 0 : "Shard {} is inconsistent. In memory: {}, database has: {}",
6055 0 : tenant_shard_id,
6056 0 : serde_json::to_string(expect_tsp).unwrap(),
6057 0 : serde_json::to_string(&persistent_tsp).unwrap()
6058 : );
6059 0 : }
6060 : }
6061 : }
6062 : }
6063 :
6064 : // Having already logged any differences, log any shards that simply aren't present in the database
6065 0 : for (tenant_shard_id, memory_tsp) in &expect_shards {
6066 0 : if !persistent_shards.contains_key(tenant_shard_id) {
6067 0 : tracing::error!(
6068 0 : "Shard {} found in memory but not in database: {}",
6069 0 : tenant_shard_id,
6070 0 : serde_json::to_string(memory_tsp)
6071 0 : .map_err(|e| ApiError::InternalServerError(e.into()))?
6072 : );
6073 0 : }
6074 : }
6075 :
6076 0 : return Err(ApiError::InternalServerError(anyhow::anyhow!(
6077 0 : "Shard consistency failure"
6078 0 : )));
6079 0 : }
6080 0 :
6081 0 : node_result
6082 0 : }
6083 :
6084 : /// For debug/support: a JSON dump of the [`Scheduler`]. Returns a response so that
6085 : /// we don't have to make TenantShard clonable in the return path.
6086 0 : pub(crate) fn scheduler_dump(&self) -> Result<hyper::Response<hyper::Body>, ApiError> {
6087 0 : let serialized = {
6088 0 : let locked = self.inner.read().unwrap();
6089 0 : serde_json::to_string(&locked.scheduler)
6090 0 : .map_err(|e| ApiError::InternalServerError(e.into()))?
6091 : };
6092 :
6093 0 : hyper::Response::builder()
6094 0 : .status(hyper::StatusCode::OK)
6095 0 : .header(hyper::header::CONTENT_TYPE, "application/json")
6096 0 : .body(hyper::Body::from(serialized))
6097 0 : .map_err(|e| ApiError::InternalServerError(e.into()))
6098 0 : }
6099 :
6100 : /// This is for debug/support only: we simply drop all state for a tenant, without
6101 : /// detaching or deleting it on pageservers. We do not try and re-schedule any
6102 : /// tenants that were on this node.
6103 0 : pub(crate) async fn node_drop(&self, node_id: NodeId) -> Result<(), ApiError> {
6104 0 : self.persistence.delete_node(node_id).await?;
6105 :
6106 0 : let mut locked = self.inner.write().unwrap();
6107 :
6108 0 : for shard in locked.tenants.values_mut() {
6109 0 : shard.deref_node(node_id);
6110 0 : shard.observed.locations.remove(&node_id);
6111 0 : }
6112 :
6113 0 : let mut nodes = (*locked.nodes).clone();
6114 0 : nodes.remove(&node_id);
6115 0 : locked.nodes = Arc::new(nodes);
6116 0 : metrics::METRICS_REGISTRY
6117 0 : .metrics_group
6118 0 : .storage_controller_pageserver_nodes
6119 0 : .set(locked.nodes.len() as i64);
6120 0 :
6121 0 : locked.scheduler.node_remove(node_id);
6122 0 :
6123 0 : Ok(())
6124 0 : }
6125 :
6126 : /// If a node has any work on it, it will be rescheduled: this is "clean" in the sense
6127 : /// that we don't leave any bad state behind in the storage controller, but unclean
6128 : /// in the sense that we are not carefully draining the node.
6129 0 : pub(crate) async fn node_delete(&self, node_id: NodeId) -> Result<(), ApiError> {
6130 0 : let _node_lock =
6131 0 : trace_exclusive_lock(&self.node_op_locks, node_id, NodeOperations::Delete).await;
6132 :
6133 : // 1. Atomically update in-memory state:
6134 : // - set the scheduling state to Pause to make subsequent scheduling ops skip it
6135 : // - update shards' intents to exclude the node, and reschedule any shards whose intents we modified.
6136 : // - drop the node from the main nodes map, so that when running reconciles complete they do not
6137 : // re-insert references to this node into the ObservedState of shards
6138 : // - drop the node from the scheduler
6139 : {
6140 0 : let mut locked = self.inner.write().unwrap();
6141 0 : let (nodes, tenants, scheduler) = locked.parts_mut();
6142 0 :
6143 0 : {
6144 0 : let mut nodes_mut = (*nodes).deref().clone();
6145 0 : match nodes_mut.get_mut(&node_id) {
6146 0 : Some(node) => {
6147 0 : // We do not bother setting this in the database, because we're about to delete the row anyway, and
6148 0 : // if we crash it would not be desirable to leave the node paused after a restart.
6149 0 : node.set_scheduling(NodeSchedulingPolicy::Pause);
6150 0 : }
6151 : None => {
6152 0 : tracing::info!(
6153 0 : "Node not found: presuming this is a retry and returning success"
6154 : );
6155 0 : return Ok(());
6156 : }
6157 : }
6158 :
6159 0 : *nodes = Arc::new(nodes_mut);
6160 : }
6161 :
6162 0 : for (_tenant_id, mut schedule_context, shards) in
6163 0 : TenantShardContextIterator::new(tenants, ScheduleMode::Normal)
6164 : {
6165 0 : for shard in shards {
6166 0 : if shard.deref_node(node_id) {
6167 0 : if let Err(e) = shard.schedule(scheduler, &mut schedule_context) {
6168 : // TODO: implement force flag to remove a node even if we can't reschedule
6169 : // a tenant
6170 0 : tracing::error!(
6171 0 : "Refusing to delete node, shard {} can't be rescheduled: {e}",
6172 : shard.tenant_shard_id
6173 : );
6174 0 : return Err(e.into());
6175 : } else {
6176 0 : tracing::info!(
6177 0 : "Rescheduled shard {} away from node during deletion",
6178 : shard.tenant_shard_id
6179 : )
6180 : }
6181 :
6182 0 : self.maybe_reconcile_shard(shard, nodes, ReconcilerPriority::Normal);
6183 0 : }
6184 :
6185 : // Here we remove an existing observed location for the node we're removing, and it will
6186 : // not be re-added by a reconciler's completion because we filter out removed nodes in
6187 : // process_result.
6188 : //
6189 : // Note that we update the shard's observed state _after_ calling maybe_reconcile_shard: that
6190 : // means any reconciles we spawned will know about the node we're deleting, enabling them
6191 : // to do live migrations if it's still online.
6192 0 : shard.observed.locations.remove(&node_id);
6193 : }
6194 : }
6195 :
6196 0 : scheduler.node_remove(node_id);
6197 0 :
6198 0 : {
6199 0 : let mut nodes_mut = (**nodes).clone();
6200 0 : if let Some(mut removed_node) = nodes_mut.remove(&node_id) {
6201 0 : // Ensure that any reconciler holding an Arc<> to this node will
6202 0 : // drop out when trying to RPC to it (setting Offline state sets the
6203 0 : // cancellation token on the Node object).
6204 0 : removed_node.set_availability(NodeAvailability::Offline);
6205 0 : }
6206 0 : *nodes = Arc::new(nodes_mut);
6207 0 : metrics::METRICS_REGISTRY
6208 0 : .metrics_group
6209 0 : .storage_controller_pageserver_nodes
6210 0 : .set(nodes.len() as i64);
6211 0 : }
6212 0 : }
6213 0 :
6214 0 : // Note: some `generation_pageserver` columns on tenant shards in the database may still refer to
6215 0 : // the removed node, as this column means "The pageserver to which this generation was issued", and
6216 0 : // their generations won't get updated until the reconcilers moving them away from this node complete.
6217 0 : // That is safe because in Service::spawn we only use generation_pageserver if it refers to a node
6218 0 : // that exists.
6219 0 :
6220 0 : // 2. Actually delete the node from the database and from in-memory state
6221 0 : tracing::info!("Deleting node from database");
6222 0 : self.persistence.delete_node(node_id).await?;
6223 :
6224 0 : Ok(())
6225 0 : }
6226 :
6227 0 : pub(crate) async fn node_list(&self) -> Result<Vec<Node>, ApiError> {
6228 0 : let nodes = {
6229 0 : self.inner
6230 0 : .read()
6231 0 : .unwrap()
6232 0 : .nodes
6233 0 : .values()
6234 0 : .cloned()
6235 0 : .collect::<Vec<_>>()
6236 0 : };
6237 0 :
6238 0 : Ok(nodes)
6239 0 : }
6240 :
6241 0 : pub(crate) async fn get_node(&self, node_id: NodeId) -> Result<Node, ApiError> {
6242 0 : self.inner
6243 0 : .read()
6244 0 : .unwrap()
6245 0 : .nodes
6246 0 : .get(&node_id)
6247 0 : .cloned()
6248 0 : .ok_or(ApiError::NotFound(
6249 0 : format!("Node {node_id} not registered").into(),
6250 0 : ))
6251 0 : }
6252 :
6253 0 : pub(crate) async fn get_node_shards(
6254 0 : &self,
6255 0 : node_id: NodeId,
6256 0 : ) -> Result<NodeShardResponse, ApiError> {
6257 0 : let locked = self.inner.read().unwrap();
6258 0 : let mut shards = Vec::new();
6259 0 : for (tid, tenant) in locked.tenants.iter() {
6260 0 : let is_intended_secondary = match (
6261 0 : tenant.intent.get_attached() == &Some(node_id),
6262 0 : tenant.intent.get_secondary().contains(&node_id),
6263 0 : ) {
6264 : (true, true) => {
6265 0 : return Err(ApiError::InternalServerError(anyhow::anyhow!(
6266 0 : "{} attached as primary+secondary on the same node",
6267 0 : tid
6268 0 : )));
6269 : }
6270 0 : (true, false) => Some(false),
6271 0 : (false, true) => Some(true),
6272 0 : (false, false) => None,
6273 : };
6274 0 : let is_observed_secondary = if let Some(ObservedStateLocation { conf: Some(conf) }) =
6275 0 : tenant.observed.locations.get(&node_id)
6276 : {
6277 0 : Some(conf.secondary_conf.is_some())
6278 : } else {
6279 0 : None
6280 : };
6281 0 : if is_intended_secondary.is_some() || is_observed_secondary.is_some() {
6282 0 : shards.push(NodeShard {
6283 0 : tenant_shard_id: *tid,
6284 0 : is_intended_secondary,
6285 0 : is_observed_secondary,
6286 0 : });
6287 0 : }
6288 : }
6289 0 : Ok(NodeShardResponse { node_id, shards })
6290 0 : }
6291 :
6292 0 : pub(crate) async fn get_leader(&self) -> DatabaseResult<Option<ControllerPersistence>> {
6293 0 : self.persistence.get_leader().await
6294 0 : }
6295 :
6296 0 : pub(crate) async fn node_register(
6297 0 : &self,
6298 0 : register_req: NodeRegisterRequest,
6299 0 : ) -> Result<(), ApiError> {
6300 0 : let _node_lock = trace_exclusive_lock(
6301 0 : &self.node_op_locks,
6302 0 : register_req.node_id,
6303 0 : NodeOperations::Register,
6304 0 : )
6305 0 : .await;
6306 :
6307 : #[derive(PartialEq)]
6308 : enum RegistrationStatus {
6309 : UpToDate,
6310 : NeedUpdate,
6311 : Mismatched,
6312 : New,
6313 : }
6314 :
6315 0 : let registration_status = {
6316 0 : let locked = self.inner.read().unwrap();
6317 0 : if let Some(node) = locked.nodes.get(®ister_req.node_id) {
6318 0 : if node.registration_match(®ister_req) {
6319 0 : if node.need_update(®ister_req) {
6320 0 : RegistrationStatus::NeedUpdate
6321 : } else {
6322 0 : RegistrationStatus::UpToDate
6323 : }
6324 : } else {
6325 0 : RegistrationStatus::Mismatched
6326 : }
6327 : } else {
6328 0 : RegistrationStatus::New
6329 : }
6330 : };
6331 :
6332 0 : match registration_status {
6333 : RegistrationStatus::UpToDate => {
6334 0 : tracing::info!(
6335 0 : "Node {} re-registered with matching address and is up to date",
6336 : register_req.node_id
6337 : );
6338 :
6339 0 : return Ok(());
6340 : }
6341 : RegistrationStatus::Mismatched => {
6342 : // TODO: decide if we want to allow modifying node addresses without removing and re-adding
6343 : // the node. Safest/simplest thing is to refuse it, and usually we deploy with
6344 : // a fixed address through the lifetime of a node.
6345 0 : tracing::warn!(
6346 0 : "Node {} tried to register with different address",
6347 : register_req.node_id
6348 : );
6349 0 : return Err(ApiError::Conflict(
6350 0 : "Node is already registered with different address".to_string(),
6351 0 : ));
6352 : }
6353 0 : RegistrationStatus::New | RegistrationStatus::NeedUpdate => {
6354 0 : // fallthrough
6355 0 : }
6356 0 : }
6357 0 :
6358 0 : // We do not require that a node is actually online when registered (it will start life
6359 0 : // with it's availability set to Offline), but we _do_ require that its DNS record exists. We're
6360 0 : // therefore not immune to asymmetric L3 connectivity issues, but we are protected against nodes
6361 0 : // that register themselves with a broken DNS config. We check only the HTTP hostname, because
6362 0 : // the postgres hostname might only be resolvable to clients (e.g. if we're on a different VPC than clients).
6363 0 : if tokio::net::lookup_host(format!(
6364 0 : "{}:{}",
6365 0 : register_req.listen_http_addr, register_req.listen_http_port
6366 0 : ))
6367 0 : .await
6368 0 : .is_err()
6369 : {
6370 : // If we have a transient DNS issue, it's up to the caller to retry their registration. Because
6371 : // we can't robustly distinguish between an intermittent issue and a totally bogus DNS situation,
6372 : // we return a soft 503 error, to encourage callers to retry past transient issues.
6373 0 : return Err(ApiError::ResourceUnavailable(
6374 0 : format!(
6375 0 : "Node {} tried to register with unknown DNS name '{}'",
6376 0 : register_req.node_id, register_req.listen_http_addr
6377 0 : )
6378 0 : .into(),
6379 0 : ));
6380 0 : }
6381 0 :
6382 0 : if self.config.use_https_pageserver_api && register_req.listen_https_port.is_none() {
6383 0 : return Err(ApiError::PreconditionFailed(
6384 0 : format!(
6385 0 : "Node {} has no https port, but use_https is enabled",
6386 0 : register_req.node_id
6387 0 : )
6388 0 : .into(),
6389 0 : ));
6390 0 : }
6391 0 :
6392 0 : // Ordering: we must persist the new node _before_ adding it to in-memory state.
6393 0 : // This ensures that before we use it for anything or expose it via any external
6394 0 : // API, it is guaranteed to be available after a restart.
6395 0 : let new_node = Node::new(
6396 0 : register_req.node_id,
6397 0 : register_req.listen_http_addr,
6398 0 : register_req.listen_http_port,
6399 0 : register_req.listen_https_port,
6400 0 : register_req.listen_pg_addr,
6401 0 : register_req.listen_pg_port,
6402 0 : register_req.availability_zone_id.clone(),
6403 0 : self.config.use_https_pageserver_api,
6404 0 : );
6405 0 : let new_node = match new_node {
6406 0 : Ok(new_node) => new_node,
6407 0 : Err(error) => return Err(ApiError::InternalServerError(error)),
6408 : };
6409 :
6410 0 : match registration_status {
6411 0 : RegistrationStatus::New => self.persistence.insert_node(&new_node).await?,
6412 : RegistrationStatus::NeedUpdate => {
6413 0 : self.persistence
6414 0 : .update_node_on_registration(
6415 0 : register_req.node_id,
6416 0 : register_req.listen_https_port,
6417 0 : )
6418 0 : .await?
6419 : }
6420 0 : _ => unreachable!("Other statuses have been processed earlier"),
6421 : }
6422 :
6423 0 : let mut locked = self.inner.write().unwrap();
6424 0 : let mut new_nodes = (*locked.nodes).clone();
6425 0 :
6426 0 : locked.scheduler.node_upsert(&new_node);
6427 0 : new_nodes.insert(register_req.node_id, new_node);
6428 0 :
6429 0 : locked.nodes = Arc::new(new_nodes);
6430 0 :
6431 0 : metrics::METRICS_REGISTRY
6432 0 : .metrics_group
6433 0 : .storage_controller_pageserver_nodes
6434 0 : .set(locked.nodes.len() as i64);
6435 0 :
6436 0 : match registration_status {
6437 : RegistrationStatus::New => {
6438 0 : tracing::info!(
6439 0 : "Registered pageserver {} ({}), now have {} pageservers",
6440 0 : register_req.node_id,
6441 0 : register_req.availability_zone_id,
6442 0 : locked.nodes.len()
6443 : );
6444 : }
6445 : RegistrationStatus::NeedUpdate => {
6446 0 : tracing::info!(
6447 0 : "Re-registered and updated node {} ({})",
6448 : register_req.node_id,
6449 : register_req.availability_zone_id,
6450 : );
6451 : }
6452 0 : _ => unreachable!("Other statuses have been processed earlier"),
6453 : }
6454 0 : Ok(())
6455 0 : }
6456 :
6457 : /// Configure in-memory and persistent state of a node as requested
6458 : ///
6459 : /// Note that this function does not trigger any immediate side effects in response
6460 : /// to the changes. That part is handled by [`Self::handle_node_availability_transition`].
6461 0 : async fn node_state_configure(
6462 0 : &self,
6463 0 : node_id: NodeId,
6464 0 : availability: Option<NodeAvailability>,
6465 0 : scheduling: Option<NodeSchedulingPolicy>,
6466 0 : node_lock: &TracingExclusiveGuard<NodeOperations>,
6467 0 : ) -> Result<AvailabilityTransition, ApiError> {
6468 0 : if let Some(scheduling) = scheduling {
6469 : // Scheduling is a persistent part of Node: we must write updates to the database before
6470 : // applying them in memory
6471 0 : self.persistence
6472 0 : .update_node_scheduling_policy(node_id, scheduling)
6473 0 : .await?;
6474 0 : }
6475 :
6476 : // If we're activating a node, then before setting it active we must reconcile any shard locations
6477 : // on that node, in case it is out of sync, e.g. due to being unavailable during controller startup,
6478 : // by calling [`Self::node_activate_reconcile`]
6479 : //
6480 : // The transition we calculate here remains valid later in the function because we hold the op lock on the node:
6481 : // nothing else can mutate its availability while we run.
6482 0 : let availability_transition = if let Some(input_availability) = availability.as_ref() {
6483 0 : let (activate_node, availability_transition) = {
6484 0 : let locked = self.inner.read().unwrap();
6485 0 : let Some(node) = locked.nodes.get(&node_id) else {
6486 0 : return Err(ApiError::NotFound(
6487 0 : anyhow::anyhow!("Node {} not registered", node_id).into(),
6488 0 : ));
6489 : };
6490 :
6491 0 : (
6492 0 : node.clone(),
6493 0 : node.get_availability_transition(input_availability),
6494 0 : )
6495 : };
6496 :
6497 0 : if matches!(availability_transition, AvailabilityTransition::ToActive) {
6498 0 : self.node_activate_reconcile(activate_node, node_lock)
6499 0 : .await?;
6500 0 : }
6501 0 : availability_transition
6502 : } else {
6503 0 : AvailabilityTransition::Unchanged
6504 : };
6505 :
6506 : // Apply changes from the request to our in-memory state for the Node
6507 0 : let mut locked = self.inner.write().unwrap();
6508 0 : let (nodes, _tenants, scheduler) = locked.parts_mut();
6509 0 :
6510 0 : let mut new_nodes = (**nodes).clone();
6511 :
6512 0 : let Some(node) = new_nodes.get_mut(&node_id) else {
6513 0 : return Err(ApiError::NotFound(
6514 0 : anyhow::anyhow!("Node not registered").into(),
6515 0 : ));
6516 : };
6517 :
6518 0 : if let Some(availability) = availability {
6519 0 : node.set_availability(availability);
6520 0 : }
6521 :
6522 0 : if let Some(scheduling) = scheduling {
6523 0 : node.set_scheduling(scheduling);
6524 0 : }
6525 :
6526 : // Update the scheduler, in case the elegibility of the node for new shards has changed
6527 0 : scheduler.node_upsert(node);
6528 0 :
6529 0 : let new_nodes = Arc::new(new_nodes);
6530 0 : locked.nodes = new_nodes;
6531 0 :
6532 0 : Ok(availability_transition)
6533 0 : }
6534 :
6535 : /// Handle availability transition of one node
6536 : ///
6537 : /// Note that you should first call [`Self::node_state_configure`] to update
6538 : /// the in-memory state referencing that node. If you need to handle more than one transition
6539 : /// consider using [`Self::handle_node_availability_transitions`].
6540 0 : async fn handle_node_availability_transition(
6541 0 : &self,
6542 0 : node_id: NodeId,
6543 0 : transition: AvailabilityTransition,
6544 0 : _node_lock: &TracingExclusiveGuard<NodeOperations>,
6545 0 : ) -> Result<(), ApiError> {
6546 0 : // Modify scheduling state for any Tenants that are affected by a change in the node's availability state.
6547 0 : match transition {
6548 : AvailabilityTransition::ToOffline => {
6549 0 : tracing::info!("Node {} transition to offline", node_id);
6550 :
6551 0 : let mut locked = self.inner.write().unwrap();
6552 0 : let (nodes, tenants, scheduler) = locked.parts_mut();
6553 0 :
6554 0 : let mut tenants_affected: usize = 0;
6555 :
6556 0 : for (_tenant_id, mut schedule_context, shards) in
6557 0 : TenantShardContextIterator::new(tenants, ScheduleMode::Normal)
6558 : {
6559 0 : for tenant_shard in shards {
6560 0 : let tenant_shard_id = tenant_shard.tenant_shard_id;
6561 0 : if let Some(observed_loc) =
6562 0 : tenant_shard.observed.locations.get_mut(&node_id)
6563 0 : {
6564 0 : // When a node goes offline, we set its observed configuration to None, indicating unknown: we will
6565 0 : // not assume our knowledge of the node's configuration is accurate until it comes back online
6566 0 : observed_loc.conf = None;
6567 0 : }
6568 :
6569 0 : if nodes.len() == 1 {
6570 : // Special case for single-node cluster: there is no point trying to reschedule
6571 : // any tenant shards: avoid doing so, in order to avoid spewing warnings about
6572 : // failures to schedule them.
6573 0 : continue;
6574 0 : }
6575 0 :
6576 0 : if !nodes
6577 0 : .values()
6578 0 : .any(|n| matches!(n.may_schedule(), MaySchedule::Yes(_)))
6579 : {
6580 : // Special case for when all nodes are unavailable and/or unschedulable: there is no point
6581 : // trying to reschedule since there's nowhere else to go. Without this
6582 : // branch we incorrectly detach tenants in response to node unavailability.
6583 0 : continue;
6584 0 : }
6585 0 :
6586 0 : if tenant_shard.intent.demote_attached(scheduler, node_id) {
6587 0 : tenant_shard.sequence = tenant_shard.sequence.next();
6588 0 :
6589 0 : match tenant_shard.schedule(scheduler, &mut schedule_context) {
6590 0 : Err(e) => {
6591 0 : // It is possible that some tenants will become unschedulable when too many pageservers
6592 0 : // go offline: in this case there isn't much we can do other than make the issue observable.
6593 0 : // TODO: give TenantShard a scheduling error attribute to be queried later.
6594 0 : tracing::warn!(%tenant_shard_id, "Scheduling error when marking pageserver {} offline: {e}", node_id);
6595 : }
6596 : Ok(()) => {
6597 0 : if self
6598 0 : .maybe_reconcile_shard(
6599 0 : tenant_shard,
6600 0 : nodes,
6601 0 : ReconcilerPriority::Normal,
6602 0 : )
6603 0 : .is_some()
6604 0 : {
6605 0 : tenants_affected += 1;
6606 0 : };
6607 : }
6608 : }
6609 0 : }
6610 : }
6611 : }
6612 0 : tracing::info!(
6613 0 : "Launched {} reconciler tasks for tenants affected by node {} going offline",
6614 : tenants_affected,
6615 : node_id
6616 : )
6617 : }
6618 : AvailabilityTransition::ToActive => {
6619 0 : tracing::info!("Node {} transition to active", node_id);
6620 :
6621 0 : let mut locked = self.inner.write().unwrap();
6622 0 : let (nodes, tenants, _scheduler) = locked.parts_mut();
6623 :
6624 : // When a node comes back online, we must reconcile any tenant that has a None observed
6625 : // location on the node.
6626 0 : for tenant_shard in tenants.values_mut() {
6627 : // If a reconciliation is already in progress, rely on the previous scheduling
6628 : // decision and skip triggering a new reconciliation.
6629 0 : if tenant_shard.reconciler.is_some() {
6630 0 : continue;
6631 0 : }
6632 :
6633 0 : if let Some(observed_loc) = tenant_shard.observed.locations.get_mut(&node_id) {
6634 0 : if observed_loc.conf.is_none() {
6635 0 : self.maybe_reconcile_shard(
6636 0 : tenant_shard,
6637 0 : nodes,
6638 0 : ReconcilerPriority::Normal,
6639 0 : );
6640 0 : }
6641 0 : }
6642 : }
6643 :
6644 : // TODO: in the background, we should balance work back onto this pageserver
6645 : }
6646 : // No action required for the intermediate unavailable state.
6647 : // When we transition into active or offline from the unavailable state,
6648 : // the correct handling above will kick in.
6649 : AvailabilityTransition::ToWarmingUpFromActive => {
6650 0 : tracing::info!("Node {} transition to unavailable from active", node_id);
6651 : }
6652 : AvailabilityTransition::ToWarmingUpFromOffline => {
6653 0 : tracing::info!("Node {} transition to unavailable from offline", node_id);
6654 : }
6655 : AvailabilityTransition::Unchanged => {
6656 0 : tracing::debug!("Node {} no availability change during config", node_id);
6657 : }
6658 : }
6659 :
6660 0 : Ok(())
6661 0 : }
6662 :
6663 : /// Handle availability transition for multiple nodes
6664 : ///
6665 : /// Note that you should first call [`Self::node_state_configure`] for
6666 : /// all nodes being handled here for the handling to use fresh in-memory state.
6667 0 : async fn handle_node_availability_transitions(
6668 0 : &self,
6669 0 : transitions: Vec<(
6670 0 : NodeId,
6671 0 : TracingExclusiveGuard<NodeOperations>,
6672 0 : AvailabilityTransition,
6673 0 : )>,
6674 0 : ) -> Result<(), Vec<(NodeId, ApiError)>> {
6675 0 : let mut errors = Vec::default();
6676 0 : for (node_id, node_lock, transition) in transitions {
6677 0 : let res = self
6678 0 : .handle_node_availability_transition(node_id, transition, &node_lock)
6679 0 : .await;
6680 0 : if let Err(err) = res {
6681 0 : errors.push((node_id, err));
6682 0 : }
6683 : }
6684 :
6685 0 : if errors.is_empty() {
6686 0 : Ok(())
6687 : } else {
6688 0 : Err(errors)
6689 : }
6690 0 : }
6691 :
6692 0 : pub(crate) async fn node_configure(
6693 0 : &self,
6694 0 : node_id: NodeId,
6695 0 : availability: Option<NodeAvailability>,
6696 0 : scheduling: Option<NodeSchedulingPolicy>,
6697 0 : ) -> Result<(), ApiError> {
6698 0 : let node_lock =
6699 0 : trace_exclusive_lock(&self.node_op_locks, node_id, NodeOperations::Configure).await;
6700 :
6701 0 : let transition = self
6702 0 : .node_state_configure(node_id, availability, scheduling, &node_lock)
6703 0 : .await?;
6704 0 : self.handle_node_availability_transition(node_id, transition, &node_lock)
6705 0 : .await
6706 0 : }
6707 :
6708 : /// Wrapper around [`Self::node_configure`] which only allows changes while there is no ongoing
6709 : /// operation for HTTP api.
6710 0 : pub(crate) async fn external_node_configure(
6711 0 : &self,
6712 0 : node_id: NodeId,
6713 0 : availability: Option<NodeAvailability>,
6714 0 : scheduling: Option<NodeSchedulingPolicy>,
6715 0 : ) -> Result<(), ApiError> {
6716 0 : {
6717 0 : let locked = self.inner.read().unwrap();
6718 0 : if let Some(op) = locked.ongoing_operation.as_ref().map(|op| op.operation) {
6719 0 : return Err(ApiError::PreconditionFailed(
6720 0 : format!("Ongoing background operation forbids configuring: {op}").into(),
6721 0 : ));
6722 0 : }
6723 0 : }
6724 0 :
6725 0 : self.node_configure(node_id, availability, scheduling).await
6726 0 : }
6727 :
6728 0 : pub(crate) async fn start_node_drain(
6729 0 : self: &Arc<Self>,
6730 0 : node_id: NodeId,
6731 0 : ) -> Result<(), ApiError> {
6732 0 : let (ongoing_op, node_available, node_policy, schedulable_nodes_count) = {
6733 0 : let locked = self.inner.read().unwrap();
6734 0 : let nodes = &locked.nodes;
6735 0 : let node = nodes.get(&node_id).ok_or(ApiError::NotFound(
6736 0 : anyhow::anyhow!("Node {} not registered", node_id).into(),
6737 0 : ))?;
6738 0 : let schedulable_nodes_count = nodes
6739 0 : .iter()
6740 0 : .filter(|(_, n)| matches!(n.may_schedule(), MaySchedule::Yes(_)))
6741 0 : .count();
6742 0 :
6743 0 : (
6744 0 : locked
6745 0 : .ongoing_operation
6746 0 : .as_ref()
6747 0 : .map(|ongoing| ongoing.operation),
6748 0 : node.is_available(),
6749 0 : node.get_scheduling(),
6750 0 : schedulable_nodes_count,
6751 0 : )
6752 0 : };
6753 :
6754 0 : if let Some(ongoing) = ongoing_op {
6755 0 : return Err(ApiError::PreconditionFailed(
6756 0 : format!("Background operation already ongoing for node: {}", ongoing).into(),
6757 0 : ));
6758 0 : }
6759 0 :
6760 0 : if !node_available {
6761 0 : return Err(ApiError::ResourceUnavailable(
6762 0 : format!("Node {node_id} is currently unavailable").into(),
6763 0 : ));
6764 0 : }
6765 0 :
6766 0 : if schedulable_nodes_count == 0 {
6767 0 : return Err(ApiError::PreconditionFailed(
6768 0 : "No other schedulable nodes to drain to".into(),
6769 0 : ));
6770 0 : }
6771 0 :
6772 0 : match node_policy {
6773 : NodeSchedulingPolicy::Active => {
6774 0 : self.node_configure(node_id, None, Some(NodeSchedulingPolicy::Draining))
6775 0 : .await?;
6776 :
6777 0 : let cancel = self.cancel.child_token();
6778 0 : let gate_guard = self.gate.enter().map_err(|_| ApiError::ShuttingDown)?;
6779 :
6780 0 : self.inner.write().unwrap().ongoing_operation = Some(OperationHandler {
6781 0 : operation: Operation::Drain(Drain { node_id }),
6782 0 : cancel: cancel.clone(),
6783 0 : });
6784 :
6785 0 : let span = tracing::info_span!(parent: None, "drain_node", %node_id);
6786 :
6787 0 : tokio::task::spawn({
6788 0 : let service = self.clone();
6789 0 : let cancel = cancel.clone();
6790 0 : async move {
6791 0 : let _gate_guard = gate_guard;
6792 0 :
6793 0 : scopeguard::defer! {
6794 0 : let prev = service.inner.write().unwrap().ongoing_operation.take();
6795 0 :
6796 0 : if let Some(Operation::Drain(removed_drain)) = prev.map(|h| h.operation) {
6797 0 : assert_eq!(removed_drain.node_id, node_id, "We always take the same operation");
6798 0 : } else {
6799 0 : panic!("We always remove the same operation")
6800 0 : }
6801 0 : }
6802 0 :
6803 0 : tracing::info!("Drain background operation starting");
6804 0 : let res = service.drain_node(node_id, cancel).await;
6805 0 : match res {
6806 : Ok(()) => {
6807 0 : tracing::info!("Drain background operation completed successfully");
6808 : }
6809 : Err(OperationError::Cancelled) => {
6810 0 : tracing::info!("Drain background operation was cancelled");
6811 : }
6812 0 : Err(err) => {
6813 0 : tracing::error!("Drain background operation encountered: {err}")
6814 : }
6815 : }
6816 0 : }
6817 0 : }.instrument(span));
6818 0 : }
6819 : NodeSchedulingPolicy::Draining => {
6820 0 : return Err(ApiError::Conflict(format!(
6821 0 : "Node {node_id} has drain in progress"
6822 0 : )));
6823 : }
6824 0 : policy => {
6825 0 : return Err(ApiError::PreconditionFailed(
6826 0 : format!("Node {node_id} cannot be drained due to {policy:?} policy").into(),
6827 0 : ));
6828 : }
6829 : }
6830 :
6831 0 : Ok(())
6832 0 : }
6833 :
6834 0 : pub(crate) async fn cancel_node_drain(&self, node_id: NodeId) -> Result<(), ApiError> {
6835 0 : let node_available = {
6836 0 : let locked = self.inner.read().unwrap();
6837 0 : let nodes = &locked.nodes;
6838 0 : let node = nodes.get(&node_id).ok_or(ApiError::NotFound(
6839 0 : anyhow::anyhow!("Node {} not registered", node_id).into(),
6840 0 : ))?;
6841 :
6842 0 : node.is_available()
6843 0 : };
6844 0 :
6845 0 : if !node_available {
6846 0 : return Err(ApiError::ResourceUnavailable(
6847 0 : format!("Node {node_id} is currently unavailable").into(),
6848 0 : ));
6849 0 : }
6850 :
6851 0 : if let Some(op_handler) = self.inner.read().unwrap().ongoing_operation.as_ref() {
6852 0 : if let Operation::Drain(drain) = op_handler.operation {
6853 0 : if drain.node_id == node_id {
6854 0 : tracing::info!("Cancelling background drain operation for node {node_id}");
6855 0 : op_handler.cancel.cancel();
6856 0 : return Ok(());
6857 0 : }
6858 0 : }
6859 0 : }
6860 :
6861 0 : Err(ApiError::PreconditionFailed(
6862 0 : format!("Node {node_id} has no drain in progress").into(),
6863 0 : ))
6864 0 : }
6865 :
6866 0 : pub(crate) async fn start_node_fill(self: &Arc<Self>, node_id: NodeId) -> Result<(), ApiError> {
6867 0 : let (ongoing_op, node_available, node_policy, total_nodes_count) = {
6868 0 : let locked = self.inner.read().unwrap();
6869 0 : let nodes = &locked.nodes;
6870 0 : let node = nodes.get(&node_id).ok_or(ApiError::NotFound(
6871 0 : anyhow::anyhow!("Node {} not registered", node_id).into(),
6872 0 : ))?;
6873 :
6874 0 : (
6875 0 : locked
6876 0 : .ongoing_operation
6877 0 : .as_ref()
6878 0 : .map(|ongoing| ongoing.operation),
6879 0 : node.is_available(),
6880 0 : node.get_scheduling(),
6881 0 : nodes.len(),
6882 0 : )
6883 0 : };
6884 :
6885 0 : if let Some(ongoing) = ongoing_op {
6886 0 : return Err(ApiError::PreconditionFailed(
6887 0 : format!("Background operation already ongoing for node: {}", ongoing).into(),
6888 0 : ));
6889 0 : }
6890 0 :
6891 0 : if !node_available {
6892 0 : return Err(ApiError::ResourceUnavailable(
6893 0 : format!("Node {node_id} is currently unavailable").into(),
6894 0 : ));
6895 0 : }
6896 0 :
6897 0 : if total_nodes_count <= 1 {
6898 0 : return Err(ApiError::PreconditionFailed(
6899 0 : "No other nodes to fill from".into(),
6900 0 : ));
6901 0 : }
6902 0 :
6903 0 : match node_policy {
6904 : NodeSchedulingPolicy::Active => {
6905 0 : self.node_configure(node_id, None, Some(NodeSchedulingPolicy::Filling))
6906 0 : .await?;
6907 :
6908 0 : let cancel = self.cancel.child_token();
6909 0 : let gate_guard = self.gate.enter().map_err(|_| ApiError::ShuttingDown)?;
6910 :
6911 0 : self.inner.write().unwrap().ongoing_operation = Some(OperationHandler {
6912 0 : operation: Operation::Fill(Fill { node_id }),
6913 0 : cancel: cancel.clone(),
6914 0 : });
6915 :
6916 0 : let span = tracing::info_span!(parent: None, "fill_node", %node_id);
6917 :
6918 0 : tokio::task::spawn({
6919 0 : let service = self.clone();
6920 0 : let cancel = cancel.clone();
6921 0 : async move {
6922 0 : let _gate_guard = gate_guard;
6923 0 :
6924 0 : scopeguard::defer! {
6925 0 : let prev = service.inner.write().unwrap().ongoing_operation.take();
6926 0 :
6927 0 : if let Some(Operation::Fill(removed_fill)) = prev.map(|h| h.operation) {
6928 0 : assert_eq!(removed_fill.node_id, node_id, "We always take the same operation");
6929 0 : } else {
6930 0 : panic!("We always remove the same operation")
6931 0 : }
6932 0 : }
6933 0 :
6934 0 : tracing::info!("Fill background operation starting");
6935 0 : let res = service.fill_node(node_id, cancel).await;
6936 0 : match res {
6937 : Ok(()) => {
6938 0 : tracing::info!("Fill background operation completed successfully");
6939 : }
6940 : Err(OperationError::Cancelled) => {
6941 0 : tracing::info!("Fill background operation was cancelled");
6942 : }
6943 0 : Err(err) => {
6944 0 : tracing::error!("Fill background operation encountered: {err}")
6945 : }
6946 : }
6947 0 : }
6948 0 : }.instrument(span));
6949 0 : }
6950 : NodeSchedulingPolicy::Filling => {
6951 0 : return Err(ApiError::Conflict(format!(
6952 0 : "Node {node_id} has fill in progress"
6953 0 : )));
6954 : }
6955 0 : policy => {
6956 0 : return Err(ApiError::PreconditionFailed(
6957 0 : format!("Node {node_id} cannot be filled due to {policy:?} policy").into(),
6958 0 : ));
6959 : }
6960 : }
6961 :
6962 0 : Ok(())
6963 0 : }
6964 :
6965 0 : pub(crate) async fn cancel_node_fill(&self, node_id: NodeId) -> Result<(), ApiError> {
6966 0 : let node_available = {
6967 0 : let locked = self.inner.read().unwrap();
6968 0 : let nodes = &locked.nodes;
6969 0 : let node = nodes.get(&node_id).ok_or(ApiError::NotFound(
6970 0 : anyhow::anyhow!("Node {} not registered", node_id).into(),
6971 0 : ))?;
6972 :
6973 0 : node.is_available()
6974 0 : };
6975 0 :
6976 0 : if !node_available {
6977 0 : return Err(ApiError::ResourceUnavailable(
6978 0 : format!("Node {node_id} is currently unavailable").into(),
6979 0 : ));
6980 0 : }
6981 :
6982 0 : if let Some(op_handler) = self.inner.read().unwrap().ongoing_operation.as_ref() {
6983 0 : if let Operation::Fill(fill) = op_handler.operation {
6984 0 : if fill.node_id == node_id {
6985 0 : tracing::info!("Cancelling background drain operation for node {node_id}");
6986 0 : op_handler.cancel.cancel();
6987 0 : return Ok(());
6988 0 : }
6989 0 : }
6990 0 : }
6991 :
6992 0 : Err(ApiError::PreconditionFailed(
6993 0 : format!("Node {node_id} has no fill in progress").into(),
6994 0 : ))
6995 0 : }
6996 :
6997 : /// Like [`Self::maybe_configured_reconcile_shard`], but uses the default reconciler
6998 : /// configuration
6999 0 : fn maybe_reconcile_shard(
7000 0 : &self,
7001 0 : shard: &mut TenantShard,
7002 0 : nodes: &Arc<HashMap<NodeId, Node>>,
7003 0 : priority: ReconcilerPriority,
7004 0 : ) -> Option<ReconcilerWaiter> {
7005 0 : self.maybe_configured_reconcile_shard(shard, nodes, ReconcilerConfig::new(priority))
7006 0 : }
7007 :
7008 : /// Before constructing a Reconciler, acquire semaphore units from the appropriate concurrency limit (depends on priority)
7009 0 : fn get_reconciler_units(
7010 0 : &self,
7011 0 : priority: ReconcilerPriority,
7012 0 : ) -> Result<ReconcileUnits, TryAcquireError> {
7013 0 : let units = match priority {
7014 0 : ReconcilerPriority::Normal => self.reconciler_concurrency.clone().try_acquire_owned(),
7015 : ReconcilerPriority::High => {
7016 0 : match self
7017 0 : .priority_reconciler_concurrency
7018 0 : .clone()
7019 0 : .try_acquire_owned()
7020 : {
7021 0 : Ok(u) => Ok(u),
7022 : Err(TryAcquireError::NoPermits) => {
7023 : // If the high priority semaphore is exhausted, then high priority tasks may steal units from
7024 : // the normal priority semaphore.
7025 0 : self.reconciler_concurrency.clone().try_acquire_owned()
7026 : }
7027 0 : Err(e) => Err(e),
7028 : }
7029 : }
7030 : };
7031 :
7032 0 : units.map(ReconcileUnits::new)
7033 0 : }
7034 :
7035 : /// Wrap [`TenantShard`] reconciliation methods with acquisition of [`Gate`] and [`ReconcileUnits`],
7036 0 : fn maybe_configured_reconcile_shard(
7037 0 : &self,
7038 0 : shard: &mut TenantShard,
7039 0 : nodes: &Arc<HashMap<NodeId, Node>>,
7040 0 : reconciler_config: ReconcilerConfig,
7041 0 : ) -> Option<ReconcilerWaiter> {
7042 0 : let reconcile_needed = shard.get_reconcile_needed(nodes);
7043 :
7044 0 : let reconcile_reason = match reconcile_needed {
7045 0 : ReconcileNeeded::No => return None,
7046 0 : ReconcileNeeded::WaitExisting(waiter) => return Some(waiter),
7047 0 : ReconcileNeeded::Yes(reason) => {
7048 0 : // Fall through to try and acquire units for spawning reconciler
7049 0 : reason
7050 : }
7051 : };
7052 :
7053 0 : let units = match self.get_reconciler_units(reconciler_config.priority) {
7054 0 : Ok(u) => u,
7055 : Err(_) => {
7056 0 : tracing::info!(tenant_id=%shard.tenant_shard_id.tenant_id, shard_id=%shard.tenant_shard_id.shard_slug(),
7057 0 : "Concurrency limited: enqueued for reconcile later");
7058 0 : if !shard.delayed_reconcile {
7059 0 : match self.delayed_reconcile_tx.try_send(shard.tenant_shard_id) {
7060 0 : Err(TrySendError::Closed(_)) => {
7061 0 : // Weird mid-shutdown case?
7062 0 : }
7063 : Err(TrySendError::Full(_)) => {
7064 : // It is safe to skip sending our ID in the channel: we will eventually get retried by the background reconcile task.
7065 0 : tracing::warn!(
7066 0 : "Many shards are waiting to reconcile: delayed_reconcile queue is full"
7067 : );
7068 : }
7069 0 : Ok(()) => {
7070 0 : shard.delayed_reconcile = true;
7071 0 : }
7072 : }
7073 0 : }
7074 :
7075 : // We won't spawn a reconciler, but we will construct a waiter that waits for the shard's sequence
7076 : // number to advance. When this function is eventually called again and succeeds in getting units,
7077 : // it will spawn a reconciler that makes this waiter complete.
7078 0 : return Some(shard.future_reconcile_waiter());
7079 : }
7080 : };
7081 :
7082 0 : let Ok(gate_guard) = self.reconcilers_gate.enter() else {
7083 : // Gate closed: we're shutting down, drop out.
7084 0 : return None;
7085 : };
7086 :
7087 0 : shard.spawn_reconciler(
7088 0 : reconcile_reason,
7089 0 : &self.result_tx,
7090 0 : nodes,
7091 0 : &self.compute_hook,
7092 0 : reconciler_config,
7093 0 : &self.config,
7094 0 : &self.persistence,
7095 0 : units,
7096 0 : gate_guard,
7097 0 : &self.reconcilers_cancel,
7098 0 : )
7099 0 : }
7100 :
7101 : /// Check all tenants for pending reconciliation work, and reconcile those in need.
7102 : /// Additionally, reschedule tenants that require it.
7103 : ///
7104 : /// Returns how many reconciliation tasks were started, or `1` if no reconciles were
7105 : /// spawned but some _would_ have been spawned if `reconciler_concurrency` units where
7106 : /// available. A return value of 0 indicates that everything is fully reconciled already.
7107 0 : fn reconcile_all(&self) -> usize {
7108 0 : let mut locked = self.inner.write().unwrap();
7109 0 : let (nodes, tenants, scheduler) = locked.parts_mut();
7110 0 : let pageservers = nodes.clone();
7111 0 :
7112 0 : // This function is an efficient place to update lazy statistics, since we are walking
7113 0 : // all tenants.
7114 0 : let mut pending_reconciles = 0;
7115 0 : let mut az_violations = 0;
7116 0 :
7117 0 : // If we find any tenants to drop from memory, stash them to offload after
7118 0 : // we're done traversing the map of tenants.
7119 0 : let mut drop_detached_tenants = Vec::new();
7120 0 :
7121 0 : let mut reconciles_spawned = 0;
7122 0 : for shard in tenants.values_mut() {
7123 : // Accumulate scheduling statistics
7124 0 : if let (Some(attached), Some(preferred)) =
7125 0 : (shard.intent.get_attached(), shard.preferred_az())
7126 : {
7127 0 : let node_az = nodes
7128 0 : .get(attached)
7129 0 : .expect("Nodes exist if referenced")
7130 0 : .get_availability_zone_id();
7131 0 : if node_az != preferred {
7132 0 : az_violations += 1;
7133 0 : }
7134 0 : }
7135 :
7136 : // Skip checking if this shard is already enqueued for reconciliation
7137 0 : if shard.delayed_reconcile && self.reconciler_concurrency.available_permits() == 0 {
7138 : // If there is something delayed, then return a nonzero count so that
7139 : // callers like reconcile_all_now do not incorrectly get the impression
7140 : // that the system is in a quiescent state.
7141 0 : reconciles_spawned = std::cmp::max(1, reconciles_spawned);
7142 0 : pending_reconciles += 1;
7143 0 : continue;
7144 0 : }
7145 0 :
7146 0 : // Eventual consistency: if an earlier reconcile job failed, and the shard is still
7147 0 : // dirty, spawn another rone
7148 0 : if self
7149 0 : .maybe_reconcile_shard(shard, &pageservers, ReconcilerPriority::Normal)
7150 0 : .is_some()
7151 0 : {
7152 0 : reconciles_spawned += 1;
7153 0 : } else if shard.delayed_reconcile {
7154 0 : // Shard wanted to reconcile but for some reason couldn't.
7155 0 : pending_reconciles += 1;
7156 0 : }
7157 :
7158 : // If this tenant is detached, try dropping it from memory. This is usually done
7159 : // proactively in [`Self::process_results`], but we do it here to handle the edge
7160 : // case where a reconcile completes while someone else is holding an op lock for the tenant.
7161 0 : if shard.tenant_shard_id.shard_number == ShardNumber(0)
7162 0 : && shard.policy == PlacementPolicy::Detached
7163 : {
7164 0 : if let Some(guard) = self.tenant_op_locks.try_exclusive(
7165 0 : shard.tenant_shard_id.tenant_id,
7166 0 : TenantOperations::DropDetached,
7167 0 : ) {
7168 0 : drop_detached_tenants.push((shard.tenant_shard_id.tenant_id, guard));
7169 0 : }
7170 0 : }
7171 : }
7172 :
7173 : // Some metrics are calculated from SchedulerNode state, update these periodically
7174 0 : scheduler.update_metrics();
7175 :
7176 : // Process any deferred tenant drops
7177 0 : for (tenant_id, guard) in drop_detached_tenants {
7178 0 : self.maybe_drop_tenant(tenant_id, &mut locked, &guard);
7179 0 : }
7180 :
7181 0 : metrics::METRICS_REGISTRY
7182 0 : .metrics_group
7183 0 : .storage_controller_schedule_az_violation
7184 0 : .set(az_violations as i64);
7185 0 :
7186 0 : metrics::METRICS_REGISTRY
7187 0 : .metrics_group
7188 0 : .storage_controller_pending_reconciles
7189 0 : .set(pending_reconciles as i64);
7190 0 :
7191 0 : reconciles_spawned
7192 0 : }
7193 :
7194 : /// `optimize` in this context means identifying shards which have valid scheduled locations, but
7195 : /// could be scheduled somewhere better:
7196 : /// - Cutting over to a secondary if the node with the secondary is more lightly loaded
7197 : /// * e.g. after a node fails then recovers, to move some work back to it
7198 : /// - Cutting over to a secondary if it improves the spread of shard attachments within a tenant
7199 : /// * e.g. after a shard split, the initial attached locations will all be on the node where
7200 : /// we did the split, but are probably better placed elsewhere.
7201 : /// - Creating new secondary locations if it improves the spreading of a sharded tenant
7202 : /// * e.g. after a shard split, some locations will be on the same node (where the split
7203 : /// happened), and will probably be better placed elsewhere.
7204 : ///
7205 : /// To put it more briefly: whereas the scheduler respects soft constraints in a ScheduleContext at
7206 : /// the time of scheduling, this function looks for cases where a better-scoring location is available
7207 : /// according to those same soft constraints.
7208 0 : async fn optimize_all(&self) -> usize {
7209 : // Limit on how many shards' optmizations each call to this function will execute. Combined
7210 : // with the frequency of background calls, this acts as an implicit rate limit that runs a small
7211 : // trickle of optimizations in the background, rather than executing a large number in parallel
7212 : // when a change occurs.
7213 : const MAX_OPTIMIZATIONS_EXEC_PER_PASS: usize = 16;
7214 :
7215 : // Synchronous prepare: scan shards for possible scheduling optimizations
7216 0 : let candidate_work = self.optimize_all_plan();
7217 0 : let candidate_work_len = candidate_work.len();
7218 :
7219 : // Asynchronous validate: I/O to pageservers to make sure shards are in a good state to apply validation
7220 0 : let validated_work = self.optimize_all_validate(candidate_work).await;
7221 :
7222 0 : let was_work_filtered = validated_work.len() != candidate_work_len;
7223 0 :
7224 0 : // Synchronous apply: update the shards' intent states according to validated optimisations
7225 0 : let mut reconciles_spawned = 0;
7226 0 : let mut optimizations_applied = 0;
7227 0 : let mut locked = self.inner.write().unwrap();
7228 0 : let (nodes, tenants, scheduler) = locked.parts_mut();
7229 0 : for (tenant_shard_id, optimization) in validated_work {
7230 0 : let Some(shard) = tenants.get_mut(&tenant_shard_id) else {
7231 : // Shard was dropped between planning and execution;
7232 0 : continue;
7233 : };
7234 0 : tracing::info!(tenant_shard_id=%tenant_shard_id, "Applying optimization: {optimization:?}");
7235 0 : if shard.apply_optimization(scheduler, optimization) {
7236 0 : optimizations_applied += 1;
7237 0 : if self
7238 0 : .maybe_reconcile_shard(shard, nodes, ReconcilerPriority::Normal)
7239 0 : .is_some()
7240 0 : {
7241 0 : reconciles_spawned += 1;
7242 0 : }
7243 0 : }
7244 :
7245 0 : if optimizations_applied >= MAX_OPTIMIZATIONS_EXEC_PER_PASS {
7246 0 : break;
7247 0 : }
7248 : }
7249 :
7250 0 : if was_work_filtered {
7251 0 : // If we filtered any work out during validation, ensure we return a nonzero value to indicate
7252 0 : // to callers that the system is not in a truly quiet state, it's going to do some work as soon
7253 0 : // as these validations start passing.
7254 0 : reconciles_spawned = std::cmp::max(reconciles_spawned, 1);
7255 0 : }
7256 :
7257 0 : reconciles_spawned
7258 0 : }
7259 :
7260 0 : fn optimize_all_plan(&self) -> Vec<(TenantShardId, ScheduleOptimization)> {
7261 : // How many candidate optimizations we will generate, before evaluating them for readniess: setting
7262 : // this higher than the execution limit gives us a chance to execute some work even if the first
7263 : // few optimizations we find are not ready.
7264 : const MAX_OPTIMIZATIONS_PLAN_PER_PASS: usize = 64;
7265 :
7266 0 : let mut work = Vec::new();
7267 0 : let mut locked = self.inner.write().unwrap();
7268 0 : let (_nodes, tenants, scheduler) = locked.parts_mut();
7269 :
7270 : // We are going to plan a bunch of optimisations before applying any of them, so the
7271 : // utilisation stats on nodes will be effectively stale for the >1st optimisation we
7272 : // generate. To avoid this causing unstable migrations/flapping, it's important that the
7273 : // code in TenantShard for finding optimisations uses [`NodeAttachmentSchedulingScore::disregard_utilization`]
7274 : // to ignore the utilisation component of the score.
7275 :
7276 0 : for (_tenant_id, schedule_context, shards) in
7277 0 : TenantShardContextIterator::new(tenants, ScheduleMode::Speculative)
7278 : {
7279 0 : for shard in shards {
7280 0 : if work.len() >= MAX_OPTIMIZATIONS_PLAN_PER_PASS {
7281 0 : break;
7282 0 : }
7283 0 : match shard.get_scheduling_policy() {
7284 0 : ShardSchedulingPolicy::Active => {
7285 0 : // Ok to do optimization
7286 0 : }
7287 0 : ShardSchedulingPolicy::Essential if shard.get_preferred_node().is_some() => {
7288 0 : // Ok to do optimization: we are executing a graceful migration that
7289 0 : // has set preferred_node
7290 0 : }
7291 : ShardSchedulingPolicy::Essential
7292 : | ShardSchedulingPolicy::Pause
7293 : | ShardSchedulingPolicy::Stop => {
7294 : // Policy prevents optimizing this shard.
7295 0 : continue;
7296 : }
7297 : }
7298 :
7299 0 : if !matches!(shard.splitting, SplitState::Idle)
7300 0 : || matches!(shard.policy, PlacementPolicy::Detached)
7301 0 : || shard.reconciler.is_some()
7302 : {
7303 : // Do not start any optimizations while another change to the tenant is ongoing: this
7304 : // is not necessary for correctness, but simplifies operations and implicitly throttles
7305 : // optimization changes to happen in a "trickle" over time.
7306 0 : continue;
7307 0 : }
7308 0 :
7309 0 : // Fast path: we may quickly identify shards that don't have any possible optimisations
7310 0 : if !shard.maybe_optimizable(scheduler, &schedule_context) {
7311 0 : if cfg!(feature = "testing") {
7312 : // Check that maybe_optimizable doesn't disagree with the actual optimization functions.
7313 : // Only do this in testing builds because it is not a correctness-critical check, so we shouldn't
7314 : // panic in prod if we hit this, or spend cycles on it in prod.
7315 0 : assert!(
7316 0 : shard
7317 0 : .optimize_attachment(scheduler, &schedule_context)
7318 0 : .is_none()
7319 0 : );
7320 0 : assert!(
7321 0 : shard
7322 0 : .optimize_secondary(scheduler, &schedule_context)
7323 0 : .is_none()
7324 0 : );
7325 0 : }
7326 0 : continue;
7327 0 : }
7328 :
7329 0 : if let Some(optimization) =
7330 : // If idle, maybe optimize attachments: if a shard has a secondary location that is preferable to
7331 : // its primary location based on soft constraints, cut it over.
7332 0 : shard.optimize_attachment(scheduler, &schedule_context)
7333 : {
7334 0 : tracing::info!(tenant_shard_id=%shard.tenant_shard_id, "Identified optimization for attachment: {optimization:?}");
7335 0 : work.push((shard.tenant_shard_id, optimization));
7336 0 : break;
7337 0 : } else if let Some(optimization) =
7338 : // If idle, maybe optimize secondary locations: if a shard has a secondary location that would be
7339 : // better placed on another node, based on ScheduleContext, then adjust it. This
7340 : // covers cases like after a shard split, where we might have too many shards
7341 : // in the same tenant with secondary locations on the node where they originally split.
7342 0 : shard.optimize_secondary(scheduler, &schedule_context)
7343 : {
7344 0 : tracing::info!(tenant_shard_id=%shard.tenant_shard_id, "Identified optimization for secondary: {optimization:?}");
7345 0 : work.push((shard.tenant_shard_id, optimization));
7346 0 : break;
7347 0 : }
7348 : }
7349 : }
7350 :
7351 0 : work
7352 0 : }
7353 :
7354 0 : async fn optimize_all_validate(
7355 0 : &self,
7356 0 : candidate_work: Vec<(TenantShardId, ScheduleOptimization)>,
7357 0 : ) -> Vec<(TenantShardId, ScheduleOptimization)> {
7358 0 : // Take a clone of the node map to use outside the lock in async validation phase
7359 0 : let validation_nodes = { self.inner.read().unwrap().nodes.clone() };
7360 0 :
7361 0 : let mut want_secondary_status = Vec::new();
7362 0 :
7363 0 : // Validate our plans: this is an async phase where we may do I/O to pageservers to
7364 0 : // check that the state of locations is acceptable to run the optimization, such as
7365 0 : // checking that a secondary location is sufficiently warmed-up to cleanly cut over
7366 0 : // in a live migration.
7367 0 : let mut validated_work = Vec::new();
7368 0 : for (tenant_shard_id, optimization) in candidate_work {
7369 0 : match optimization.action {
7370 : ScheduleOptimizationAction::MigrateAttachment(MigrateAttachment {
7371 : old_attached_node_id: _,
7372 0 : new_attached_node_id,
7373 0 : }) => {
7374 0 : match validation_nodes.get(&new_attached_node_id) {
7375 0 : None => {
7376 0 : // Node was dropped between planning and validation
7377 0 : }
7378 0 : Some(node) => {
7379 0 : if !node.is_available() {
7380 0 : tracing::info!(
7381 0 : "Skipping optimization migration of {tenant_shard_id} to {new_attached_node_id} because node unavailable"
7382 : );
7383 0 : } else {
7384 0 : // Accumulate optimizations that require fetching secondary status, so that we can execute these
7385 0 : // remote API requests concurrently.
7386 0 : want_secondary_status.push((
7387 0 : tenant_shard_id,
7388 0 : node.clone(),
7389 0 : optimization,
7390 0 : ));
7391 0 : }
7392 : }
7393 : }
7394 : }
7395 : ScheduleOptimizationAction::ReplaceSecondary(_)
7396 : | ScheduleOptimizationAction::CreateSecondary(_)
7397 : | ScheduleOptimizationAction::RemoveSecondary(_) => {
7398 : // No extra checks needed to manage secondaries: this does not interrupt client access
7399 0 : validated_work.push((tenant_shard_id, optimization))
7400 : }
7401 : };
7402 : }
7403 :
7404 : // Call into pageserver API to find out if the destination secondary location is warm enough for a reasonably smooth migration: we
7405 : // do this so that we avoid spawning a Reconciler that would have to wait minutes/hours for a destination to warm up: that reconciler
7406 : // would hold a precious reconcile semaphore unit the whole time it was waiting for the destination to warm up.
7407 0 : let results = self
7408 0 : .tenant_for_shards_api(
7409 0 : want_secondary_status
7410 0 : .iter()
7411 0 : .map(|i| (i.0, i.1.clone()))
7412 0 : .collect(),
7413 0 : |tenant_shard_id, client| async move {
7414 0 : client.tenant_secondary_status(tenant_shard_id).await
7415 0 : },
7416 0 : 1,
7417 0 : 1,
7418 0 : SHORT_RECONCILE_TIMEOUT,
7419 0 : &self.cancel,
7420 0 : )
7421 0 : .await;
7422 :
7423 0 : for ((tenant_shard_id, node, optimization), secondary_status) in
7424 0 : want_secondary_status.into_iter().zip(results.into_iter())
7425 : {
7426 0 : match secondary_status {
7427 0 : Err(e) => {
7428 0 : tracing::info!(
7429 0 : "Skipping migration of {tenant_shard_id} to {node}, error querying secondary: {e}"
7430 : );
7431 : }
7432 0 : Ok(progress) => {
7433 : // We require secondary locations to have less than 10GiB of downloads pending before we will use
7434 : // them in an optimization
7435 : const DOWNLOAD_FRESHNESS_THRESHOLD: u64 = 10 * 1024 * 1024 * 1024;
7436 :
7437 0 : if progress.heatmap_mtime.is_none()
7438 0 : || progress.bytes_total < DOWNLOAD_FRESHNESS_THRESHOLD
7439 0 : && progress.bytes_downloaded != progress.bytes_total
7440 0 : || progress.bytes_total - progress.bytes_downloaded
7441 0 : > DOWNLOAD_FRESHNESS_THRESHOLD
7442 : {
7443 0 : tracing::info!(
7444 0 : "Skipping migration of {tenant_shard_id} to {node} because secondary isn't ready: {progress:?}"
7445 : );
7446 :
7447 : #[cfg(feature = "testing")]
7448 0 : if progress.heatmap_mtime.is_none() {
7449 : // No heatmap might mean the attached location has never uploaded one, or that
7450 : // the secondary download hasn't happened yet. This is relatively unusual in the field,
7451 : // but fairly common in tests.
7452 0 : self.kick_secondary_download(tenant_shard_id).await;
7453 0 : }
7454 : } else {
7455 : // Location looks ready: proceed
7456 0 : tracing::info!(
7457 0 : "{tenant_shard_id} secondary on {node} is warm enough for migration: {progress:?}"
7458 : );
7459 0 : validated_work.push((tenant_shard_id, optimization))
7460 : }
7461 : }
7462 : }
7463 : }
7464 :
7465 0 : validated_work
7466 0 : }
7467 :
7468 : /// Some aspects of scheduling optimisation wait for secondary locations to be warm. This
7469 : /// happens on multi-minute timescales in the field, which is fine because optimisation is meant
7470 : /// to be a lazy background thing. However, when testing, it is not practical to wait around, so
7471 : /// we have this helper to move things along faster.
7472 : #[cfg(feature = "testing")]
7473 0 : async fn kick_secondary_download(&self, tenant_shard_id: TenantShardId) {
7474 0 : let (attached_node, secondaries) = {
7475 0 : let locked = self.inner.read().unwrap();
7476 0 : let Some(shard) = locked.tenants.get(&tenant_shard_id) else {
7477 0 : tracing::warn!(
7478 0 : "Skipping kick of secondary download for {tenant_shard_id}: not found"
7479 : );
7480 0 : return;
7481 : };
7482 :
7483 0 : let Some(attached) = shard.intent.get_attached() else {
7484 0 : tracing::warn!(
7485 0 : "Skipping kick of secondary download for {tenant_shard_id}: no attached"
7486 : );
7487 0 : return;
7488 : };
7489 :
7490 0 : let secondaries = shard
7491 0 : .intent
7492 0 : .get_secondary()
7493 0 : .iter()
7494 0 : .map(|n| locked.nodes.get(n).unwrap().clone())
7495 0 : .collect::<Vec<_>>();
7496 0 :
7497 0 : (locked.nodes.get(attached).unwrap().clone(), secondaries)
7498 0 : };
7499 0 :
7500 0 : // Make remote API calls to upload + download heatmaps: we ignore errors because this is just
7501 0 : // a 'kick' to let scheduling optimisation run more promptly.
7502 0 : match attached_node
7503 0 : .with_client_retries(
7504 0 : |client| async move { client.tenant_heatmap_upload(tenant_shard_id).await },
7505 0 : &self.config.pageserver_jwt_token,
7506 0 : &self.config.ssl_ca_cert,
7507 0 : 3,
7508 0 : 10,
7509 0 : SHORT_RECONCILE_TIMEOUT,
7510 0 : &self.cancel,
7511 0 : )
7512 0 : .await
7513 : {
7514 0 : Some(Err(e)) => {
7515 0 : tracing::info!(
7516 0 : "Failed to upload heatmap from {attached_node} for {tenant_shard_id}: {e}"
7517 : );
7518 : }
7519 : None => {
7520 0 : tracing::info!(
7521 0 : "Cancelled while uploading heatmap from {attached_node} for {tenant_shard_id}"
7522 : );
7523 : }
7524 : Some(Ok(_)) => {
7525 0 : tracing::info!(
7526 0 : "Successfully uploaded heatmap from {attached_node} for {tenant_shard_id}"
7527 : );
7528 : }
7529 : }
7530 :
7531 0 : for secondary_node in secondaries {
7532 0 : match secondary_node
7533 0 : .with_client_retries(
7534 0 : |client| async move {
7535 0 : client
7536 0 : .tenant_secondary_download(
7537 0 : tenant_shard_id,
7538 0 : Some(Duration::from_secs(1)),
7539 0 : )
7540 0 : .await
7541 0 : },
7542 0 : &self.config.pageserver_jwt_token,
7543 0 : &self.config.ssl_ca_cert,
7544 0 : 3,
7545 0 : 10,
7546 0 : SHORT_RECONCILE_TIMEOUT,
7547 0 : &self.cancel,
7548 0 : )
7549 0 : .await
7550 : {
7551 0 : Some(Err(e)) => {
7552 0 : tracing::info!(
7553 0 : "Failed to download heatmap from {secondary_node} for {tenant_shard_id}: {e}"
7554 : );
7555 : }
7556 : None => {
7557 0 : tracing::info!(
7558 0 : "Cancelled while downloading heatmap from {secondary_node} for {tenant_shard_id}"
7559 : );
7560 : }
7561 0 : Some(Ok(progress)) => {
7562 0 : tracing::info!(
7563 0 : "Successfully downloaded heatmap from {secondary_node} for {tenant_shard_id}: {progress:?}"
7564 : );
7565 : }
7566 : }
7567 : }
7568 0 : }
7569 :
7570 : /// Asynchronously split a tenant that's eligible for automatic splits:
7571 : ///
7572 : /// * The tenant is unsharded.
7573 : /// * The logical size of its largest timeline exceeds split_threshold.
7574 : /// * The tenant's scheduling policy is active.
7575 : ///
7576 : /// At most one tenant will be split per call: the one with the largest max logical size. It
7577 : /// will split 1 → 8 shards.
7578 : ///
7579 : /// An unsharded tenant will get DEFAULT_STRIPE_SIZE, regardless of what its ShardIdentity says.
7580 : /// A sharded tenant will retain its stripe size, as splits do not allow changing it.
7581 : ///
7582 : /// TODO: consider splitting based on total logical size rather than max logical size.
7583 : ///
7584 : /// TODO: consider spawning multiple splits in parallel: this is only called once every 20
7585 : /// seconds, so a large backlog can take a long time, and if a tenant fails to split it will
7586 : /// block all other splits.
7587 0 : async fn autosplit_tenants(self: &Arc<Self>) {
7588 0 : let Some(split_threshold) = self.config.split_threshold else {
7589 0 : return; // auto-splits are disabled
7590 : };
7591 0 : if split_threshold == 0 {
7592 0 : return;
7593 0 : }
7594 :
7595 : // Fetch the largest eligible shards by logical size.
7596 : const MAX_SHARDS: ShardCount = ShardCount::new(8);
7597 :
7598 0 : let mut top_n = self
7599 0 : .get_top_tenant_shards(&TopTenantShardsRequest {
7600 0 : order_by: TenantSorting::MaxLogicalSize,
7601 0 : limit: 10,
7602 0 : where_shards_lt: Some(MAX_SHARDS),
7603 0 : where_gt: Some(split_threshold),
7604 0 : })
7605 0 : .await;
7606 :
7607 : // Filter out tenants in a prohibiting scheduling mode.
7608 0 : {
7609 0 : let state = self.inner.read().unwrap();
7610 0 : top_n.retain(|i| {
7611 0 : let policy = state.tenants.get(&i.id).map(|s| s.get_scheduling_policy());
7612 0 : policy == Some(ShardSchedulingPolicy::Active)
7613 0 : });
7614 0 : }
7615 :
7616 0 : let Some(split_candidate) = top_n.into_iter().next() else {
7617 0 : debug!("No split-elegible shards found");
7618 0 : return;
7619 : };
7620 :
7621 : // We spawn a task to run this, so it's exactly like some external API client requesting it.
7622 : // We don't want to block the background reconcile loop on this.
7623 0 : info!(
7624 0 : "Auto-splitting tenant for size threshold {split_threshold}: current size {split_candidate:?}"
7625 : );
7626 :
7627 : // Retain the stripe size of sharded tenants, as splits don't allow changing it. Otherwise,
7628 : // use DEFAULT_STRIPE_SIZE for unsharded tenants -- their stripe size doesn't really matter,
7629 : // and if we change the default stripe size we want to use the new default rather than an
7630 : // old, persisted stripe size.
7631 0 : let new_stripe_size = match split_candidate.id.shard_count.count() {
7632 0 : 0 => panic!("invalid shard count 0"),
7633 0 : 1 => Some(ShardParameters::DEFAULT_STRIPE_SIZE),
7634 0 : 2.. => None,
7635 : };
7636 :
7637 0 : let this = self.clone();
7638 0 : tokio::spawn(
7639 0 : async move {
7640 0 : match this
7641 0 : .tenant_shard_split(
7642 0 : split_candidate.id.tenant_id,
7643 0 : TenantShardSplitRequest {
7644 0 : // Always split to the max number of shards: this avoids stepping
7645 0 : // through intervening shard counts and encountering the overhead of a
7646 0 : // split+cleanup each time as a tenant grows, and is not too expensive
7647 0 : // because our max shard count is relatively low anyway. This policy
7648 0 : // will be adjusted in future once we support higher shard count.
7649 0 : new_shard_count: MAX_SHARDS.literal(),
7650 0 : new_stripe_size,
7651 0 : },
7652 0 : )
7653 0 : .await
7654 : {
7655 0 : Ok(_) => info!("Successful auto-split"),
7656 0 : Err(err) => error!("Auto-split failed: {err}"),
7657 : }
7658 0 : }
7659 0 : .instrument(info_span!("auto_split", tenant_id=%split_candidate.id.tenant_id)),
7660 : );
7661 0 : }
7662 :
7663 : /// Fetches the top tenant shards from every node, in descending order of
7664 : /// max logical size. Any node errors will be logged and ignored.
7665 0 : async fn get_top_tenant_shards(
7666 0 : &self,
7667 0 : request: &TopTenantShardsRequest,
7668 0 : ) -> Vec<TopTenantShardItem> {
7669 0 : let nodes = self
7670 0 : .inner
7671 0 : .read()
7672 0 : .unwrap()
7673 0 : .nodes
7674 0 : .values()
7675 0 : .cloned()
7676 0 : .collect_vec();
7677 0 :
7678 0 : let mut futures = FuturesUnordered::new();
7679 0 : for node in nodes {
7680 0 : futures.push(async move {
7681 0 : node.with_client_retries(
7682 0 : |client| async move { client.top_tenant_shards(request.clone()).await },
7683 0 : &self.config.pageserver_jwt_token,
7684 0 : &self.config.ssl_ca_cert,
7685 0 : 3,
7686 0 : 3,
7687 0 : Duration::from_secs(5),
7688 0 : &self.cancel,
7689 0 : )
7690 0 : .await
7691 0 : });
7692 0 : }
7693 :
7694 0 : let mut top = Vec::new();
7695 0 : while let Some(output) = futures.next().await {
7696 0 : match output {
7697 0 : Some(Ok(response)) => top.extend(response.shards),
7698 0 : Some(Err(mgmt_api::Error::Cancelled)) => {}
7699 0 : Some(Err(err)) => warn!("failed to fetch top tenants: {err}"),
7700 0 : None => {} // node is shutting down
7701 : }
7702 : }
7703 :
7704 0 : top.sort_by_key(|i| i.max_logical_size);
7705 0 : top.reverse();
7706 0 : top
7707 0 : }
7708 :
7709 : /// Useful for tests: run whatever work a background [`Self::reconcile_all`] would have done, but
7710 : /// also wait for any generated Reconcilers to complete. Calling this until it returns zero should
7711 : /// put the system into a quiescent state where future background reconciliations won't do anything.
7712 0 : pub(crate) async fn reconcile_all_now(&self) -> Result<usize, ReconcileWaitError> {
7713 0 : let reconciles_spawned = self.reconcile_all();
7714 0 : let reconciles_spawned = if reconciles_spawned == 0 {
7715 : // Only optimize when we are otherwise idle
7716 0 : self.optimize_all().await
7717 : } else {
7718 0 : reconciles_spawned
7719 : };
7720 :
7721 0 : let waiters = {
7722 0 : let mut waiters = Vec::new();
7723 0 : let locked = self.inner.read().unwrap();
7724 0 : for (_tenant_shard_id, shard) in locked.tenants.iter() {
7725 0 : if let Some(waiter) = shard.get_waiter() {
7726 0 : waiters.push(waiter);
7727 0 : }
7728 : }
7729 0 : waiters
7730 0 : };
7731 0 :
7732 0 : let waiter_count = waiters.len();
7733 0 : match self.await_waiters(waiters, RECONCILE_TIMEOUT).await {
7734 0 : Ok(()) => {}
7735 0 : Err(ReconcileWaitError::Failed(_, reconcile_error))
7736 0 : if matches!(*reconcile_error, ReconcileError::Cancel) =>
7737 0 : {
7738 0 : // Ignore reconciler cancel errors: this reconciler might have shut down
7739 0 : // because some other change superceded it. We will return a nonzero number,
7740 0 : // so the caller knows they might have to call again to quiesce the system.
7741 0 : }
7742 0 : Err(e) => {
7743 0 : return Err(e);
7744 : }
7745 : };
7746 :
7747 0 : tracing::info!(
7748 0 : "{} reconciles in reconcile_all, {} waiters",
7749 : reconciles_spawned,
7750 : waiter_count
7751 : );
7752 :
7753 0 : Ok(std::cmp::max(waiter_count, reconciles_spawned))
7754 0 : }
7755 :
7756 0 : async fn stop_reconciliations(&self, reason: StopReconciliationsReason) {
7757 0 : // Cancel all on-going reconciles and wait for them to exit the gate.
7758 0 : tracing::info!("{reason}: cancelling and waiting for in-flight reconciles");
7759 0 : self.reconcilers_cancel.cancel();
7760 0 : self.reconcilers_gate.close().await;
7761 :
7762 : // Signal the background loop in [`Service::process_results`] to exit once
7763 : // it has proccessed the results from all the reconciles we cancelled earlier.
7764 0 : tracing::info!("{reason}: processing results from previously in-flight reconciles");
7765 0 : self.result_tx.send(ReconcileResultRequest::Stop).ok();
7766 0 : self.result_tx.closed().await;
7767 0 : }
7768 :
7769 0 : pub async fn shutdown(&self) {
7770 0 : self.stop_reconciliations(StopReconciliationsReason::ShuttingDown)
7771 0 : .await;
7772 :
7773 : // Background tasks hold gate guards: this notifies them of the cancellation and
7774 : // waits for them all to complete.
7775 0 : tracing::info!("Shutting down: cancelling and waiting for background tasks to exit");
7776 0 : self.cancel.cancel();
7777 0 : self.gate.close().await;
7778 0 : }
7779 :
7780 : /// Spot check the download lag for a secondary location of a shard.
7781 : /// Should be used as a heuristic, since it's not always precise: the
7782 : /// secondary might have not downloaded the new heat map yet and, hence,
7783 : /// is not aware of the lag.
7784 : ///
7785 : /// Returns:
7786 : /// * Ok(None) if the lag could not be determined from the status,
7787 : /// * Ok(Some(_)) if the lag could be determind
7788 : /// * Err on failures to query the pageserver.
7789 0 : async fn secondary_lag(
7790 0 : &self,
7791 0 : secondary: &NodeId,
7792 0 : tenant_shard_id: TenantShardId,
7793 0 : ) -> Result<Option<u64>, mgmt_api::Error> {
7794 0 : let nodes = self.inner.read().unwrap().nodes.clone();
7795 0 : let node = nodes.get(secondary).ok_or(mgmt_api::Error::ApiError(
7796 0 : StatusCode::NOT_FOUND,
7797 0 : format!("Node with id {} not found", secondary),
7798 0 : ))?;
7799 :
7800 0 : match node
7801 0 : .with_client_retries(
7802 0 : |client| async move { client.tenant_secondary_status(tenant_shard_id).await },
7803 0 : &self.config.pageserver_jwt_token,
7804 0 : &self.config.ssl_ca_cert,
7805 0 : 1,
7806 0 : 3,
7807 0 : Duration::from_millis(250),
7808 0 : &self.cancel,
7809 0 : )
7810 0 : .await
7811 : {
7812 0 : Some(Ok(status)) => match status.heatmap_mtime {
7813 0 : Some(_) => Ok(Some(status.bytes_total - status.bytes_downloaded)),
7814 0 : None => Ok(None),
7815 : },
7816 0 : Some(Err(e)) => Err(e),
7817 0 : None => Err(mgmt_api::Error::Cancelled),
7818 : }
7819 0 : }
7820 :
7821 : /// Drain a node by moving the shards attached to it as primaries.
7822 : /// This is a long running operation and it should run as a separate Tokio task.
7823 0 : pub(crate) async fn drain_node(
7824 0 : self: &Arc<Self>,
7825 0 : node_id: NodeId,
7826 0 : cancel: CancellationToken,
7827 0 : ) -> Result<(), OperationError> {
7828 : const MAX_SECONDARY_LAG_BYTES_DEFAULT: u64 = 256 * 1024 * 1024;
7829 0 : let max_secondary_lag_bytes = self
7830 0 : .config
7831 0 : .max_secondary_lag_bytes
7832 0 : .unwrap_or(MAX_SECONDARY_LAG_BYTES_DEFAULT);
7833 :
7834 : // By default, live migrations are generous about the wait time for getting
7835 : // the secondary location up to speed. When draining, give up earlier in order
7836 : // to not stall the operation when a cold secondary is encountered.
7837 : const SECONDARY_WARMUP_TIMEOUT: Duration = Duration::from_secs(20);
7838 : const SECONDARY_DOWNLOAD_REQUEST_TIMEOUT: Duration = Duration::from_secs(5);
7839 0 : let reconciler_config = ReconcilerConfigBuilder::new(ReconcilerPriority::Normal)
7840 0 : .secondary_warmup_timeout(SECONDARY_WARMUP_TIMEOUT)
7841 0 : .secondary_download_request_timeout(SECONDARY_DOWNLOAD_REQUEST_TIMEOUT)
7842 0 : .build();
7843 0 :
7844 0 : let mut waiters = Vec::new();
7845 0 :
7846 0 : let mut tid_iter = TenantShardIterator::new({
7847 0 : let service = self.clone();
7848 0 : move |last_inspected_shard: Option<TenantShardId>| {
7849 0 : let locked = &service.inner.read().unwrap();
7850 0 : let tenants = &locked.tenants;
7851 0 : let entry = match last_inspected_shard {
7852 0 : Some(skip_past) => {
7853 0 : // Skip to the last seen tenant shard id
7854 0 : let mut cursor = tenants.iter().skip_while(|(tid, _)| **tid != skip_past);
7855 0 :
7856 0 : // Skip past the last seen
7857 0 : cursor.nth(1)
7858 : }
7859 0 : None => tenants.first_key_value(),
7860 : };
7861 :
7862 0 : entry.map(|(tid, _)| tid).copied()
7863 0 : }
7864 0 : });
7865 :
7866 0 : while !tid_iter.finished() {
7867 0 : if cancel.is_cancelled() {
7868 0 : match self
7869 0 : .node_configure(node_id, None, Some(NodeSchedulingPolicy::Active))
7870 0 : .await
7871 : {
7872 0 : Ok(()) => return Err(OperationError::Cancelled),
7873 0 : Err(err) => {
7874 0 : return Err(OperationError::FinalizeError(
7875 0 : format!(
7876 0 : "Failed to finalise drain cancel of {} by setting scheduling policy to Active: {}",
7877 0 : node_id, err
7878 0 : )
7879 0 : .into(),
7880 0 : ));
7881 : }
7882 : }
7883 0 : }
7884 0 :
7885 0 : drain_utils::validate_node_state(&node_id, self.inner.read().unwrap().nodes.clone())?;
7886 :
7887 0 : while waiters.len() < MAX_RECONCILES_PER_OPERATION {
7888 0 : let tid = match tid_iter.next() {
7889 0 : Some(tid) => tid,
7890 : None => {
7891 0 : break;
7892 : }
7893 : };
7894 :
7895 0 : let tid_drain = TenantShardDrain {
7896 0 : drained_node: node_id,
7897 0 : tenant_shard_id: tid,
7898 0 : };
7899 :
7900 0 : let dest_node_id = {
7901 0 : let locked = self.inner.read().unwrap();
7902 0 :
7903 0 : match tid_drain
7904 0 : .tenant_shard_eligible_for_drain(&locked.tenants, &locked.scheduler)
7905 : {
7906 0 : Some(node_id) => node_id,
7907 : None => {
7908 0 : continue;
7909 : }
7910 : }
7911 : };
7912 :
7913 0 : match self.secondary_lag(&dest_node_id, tid).await {
7914 0 : Ok(Some(lag)) if lag <= max_secondary_lag_bytes => {
7915 0 : // The secondary is reasonably up to date.
7916 0 : // Migrate to it
7917 0 : }
7918 0 : Ok(Some(lag)) => {
7919 0 : tracing::info!(
7920 0 : tenant_id=%tid.tenant_id, shard_id=%tid.shard_slug(),
7921 0 : "Secondary on node {dest_node_id} is lagging by {lag}. Skipping reconcile."
7922 : );
7923 0 : continue;
7924 : }
7925 : Ok(None) => {
7926 0 : tracing::info!(
7927 0 : tenant_id=%tid.tenant_id, shard_id=%tid.shard_slug(),
7928 0 : "Could not determine lag for secondary on node {dest_node_id}. Skipping reconcile."
7929 : );
7930 0 : continue;
7931 : }
7932 0 : Err(err) => {
7933 0 : tracing::warn!(
7934 0 : tenant_id=%tid.tenant_id, shard_id=%tid.shard_slug(),
7935 0 : "Failed to get secondary lag from node {dest_node_id}. Skipping reconcile: {err}"
7936 : );
7937 0 : continue;
7938 : }
7939 : }
7940 :
7941 : {
7942 0 : let mut locked = self.inner.write().unwrap();
7943 0 : let (nodes, tenants, scheduler) = locked.parts_mut();
7944 0 : let rescheduled = tid_drain.reschedule_to_secondary(
7945 0 : dest_node_id,
7946 0 : tenants,
7947 0 : scheduler,
7948 0 : nodes,
7949 0 : )?;
7950 :
7951 0 : if let Some(tenant_shard) = rescheduled {
7952 0 : let waiter = self.maybe_configured_reconcile_shard(
7953 0 : tenant_shard,
7954 0 : nodes,
7955 0 : reconciler_config,
7956 0 : );
7957 0 : if let Some(some) = waiter {
7958 0 : waiters.push(some);
7959 0 : }
7960 0 : }
7961 : }
7962 : }
7963 :
7964 0 : waiters = self
7965 0 : .await_waiters_remainder(waiters, WAITER_FILL_DRAIN_POLL_TIMEOUT)
7966 0 : .await;
7967 :
7968 0 : failpoint_support::sleep_millis_async!("sleepy-drain-loop", &cancel);
7969 : }
7970 :
7971 0 : while !waiters.is_empty() {
7972 0 : if cancel.is_cancelled() {
7973 0 : match self
7974 0 : .node_configure(node_id, None, Some(NodeSchedulingPolicy::Active))
7975 0 : .await
7976 : {
7977 0 : Ok(()) => return Err(OperationError::Cancelled),
7978 0 : Err(err) => {
7979 0 : return Err(OperationError::FinalizeError(
7980 0 : format!(
7981 0 : "Failed to finalise drain cancel of {} by setting scheduling policy to Active: {}",
7982 0 : node_id, err
7983 0 : )
7984 0 : .into(),
7985 0 : ));
7986 : }
7987 : }
7988 0 : }
7989 0 :
7990 0 : tracing::info!("Awaiting {} pending drain reconciliations", waiters.len());
7991 :
7992 0 : waiters = self
7993 0 : .await_waiters_remainder(waiters, SHORT_RECONCILE_TIMEOUT)
7994 0 : .await;
7995 : }
7996 :
7997 : // At this point we have done the best we could to drain shards from this node.
7998 : // Set the node scheduling policy to `[NodeSchedulingPolicy::PauseForRestart]`
7999 : // to complete the drain.
8000 0 : if let Err(err) = self
8001 0 : .node_configure(node_id, None, Some(NodeSchedulingPolicy::PauseForRestart))
8002 0 : .await
8003 : {
8004 : // This is not fatal. Anything that is polling the node scheduling policy to detect
8005 : // the end of the drain operations will hang, but all such places should enforce an
8006 : // overall timeout. The scheduling policy will be updated upon node re-attach and/or
8007 : // by the counterpart fill operation.
8008 0 : return Err(OperationError::FinalizeError(
8009 0 : format!(
8010 0 : "Failed to finalise drain of {node_id} by setting scheduling policy to PauseForRestart: {err}"
8011 0 : )
8012 0 : .into(),
8013 0 : ));
8014 0 : }
8015 0 :
8016 0 : Ok(())
8017 0 : }
8018 :
8019 : /// Create a node fill plan (pick secondaries to promote), based on:
8020 : /// 1. Shards which have a secondary on this node, and this node is in their home AZ, and are currently attached to a node
8021 : /// outside their home AZ, should be migrated back here.
8022 : /// 2. If after step 1 we have not migrated enough shards for this node to have its fair share of
8023 : /// attached shards, we will promote more shards from the nodes with the most attached shards, unless
8024 : /// those shards have a home AZ that doesn't match the node we're filling.
8025 0 : fn fill_node_plan(&self, node_id: NodeId) -> Vec<TenantShardId> {
8026 0 : let mut locked = self.inner.write().unwrap();
8027 0 : let (nodes, tenants, _scheduler) = locked.parts_mut();
8028 0 :
8029 0 : let node_az = nodes
8030 0 : .get(&node_id)
8031 0 : .expect("Node must exist")
8032 0 : .get_availability_zone_id()
8033 0 : .clone();
8034 0 :
8035 0 : // The tenant shard IDs that we plan to promote from secondary to attached on this node
8036 0 : let mut plan = Vec::new();
8037 0 :
8038 0 : // Collect shards which do not have a preferred AZ & are elegible for moving in stage 2
8039 0 : let mut free_tids_by_node: HashMap<NodeId, Vec<TenantShardId>> = HashMap::new();
8040 0 :
8041 0 : // Don't respect AZ preferences if there is only one AZ. This comes up in tests, but it could
8042 0 : // conceivably come up in real life if deploying a single-AZ region intentionally.
8043 0 : let respect_azs = nodes
8044 0 : .values()
8045 0 : .map(|n| n.get_availability_zone_id())
8046 0 : .unique()
8047 0 : .count()
8048 0 : > 1;
8049 :
8050 : // Step 1: collect all shards that we are required to migrate back to this node because their AZ preference
8051 : // requires it.
8052 0 : for (tsid, tenant_shard) in tenants {
8053 0 : if !tenant_shard.intent.get_secondary().contains(&node_id) {
8054 : // Shard doesn't have a secondary on this node, ignore it.
8055 0 : continue;
8056 0 : }
8057 0 :
8058 0 : // AZ check: when filling nodes after a restart, our intent is to move _back_ the
8059 0 : // shards which belong on this node, not to promote shards whose scheduling preference
8060 0 : // would be on their currently attached node. So will avoid promoting shards whose
8061 0 : // home AZ doesn't match the AZ of the node we're filling.
8062 0 : match tenant_shard.preferred_az() {
8063 0 : _ if !respect_azs => {
8064 0 : if let Some(primary) = tenant_shard.intent.get_attached() {
8065 0 : free_tids_by_node.entry(*primary).or_default().push(*tsid);
8066 0 : }
8067 : }
8068 : None => {
8069 : // Shard doesn't have an AZ preference: it is elegible to be moved, but we
8070 : // will only do so if our target shard count requires it.
8071 0 : if let Some(primary) = tenant_shard.intent.get_attached() {
8072 0 : free_tids_by_node.entry(*primary).or_default().push(*tsid);
8073 0 : }
8074 : }
8075 0 : Some(az) if az == &node_az => {
8076 : // This shard's home AZ is equal to the node we're filling: it should
8077 : // be moved back to this node as part of filling, unless its currently
8078 : // attached location is also in its home AZ.
8079 0 : if let Some(primary) = tenant_shard.intent.get_attached() {
8080 0 : if nodes
8081 0 : .get(primary)
8082 0 : .expect("referenced node must exist")
8083 0 : .get_availability_zone_id()
8084 0 : != tenant_shard
8085 0 : .preferred_az()
8086 0 : .expect("tenant must have an AZ preference")
8087 : {
8088 0 : plan.push(*tsid)
8089 0 : }
8090 : } else {
8091 0 : plan.push(*tsid)
8092 : }
8093 : }
8094 0 : Some(_) => {
8095 0 : // This shard's home AZ is somewhere other than the node we're filling,
8096 0 : // it may not be moved back to this node as part of filling. Ignore it
8097 0 : }
8098 : }
8099 : }
8100 :
8101 : // Step 2: also promote any AZ-agnostic shards as required to achieve the target number of attachments
8102 0 : let fill_requirement = locked.scheduler.compute_fill_requirement(node_id);
8103 0 :
8104 0 : let expected_attached = locked.scheduler.expected_attached_shard_count();
8105 0 : let nodes_by_load = locked.scheduler.nodes_by_attached_shard_count();
8106 0 :
8107 0 : let mut promoted_per_tenant: HashMap<TenantId, usize> = HashMap::new();
8108 :
8109 0 : for (node_id, attached) in nodes_by_load {
8110 0 : let available = locked.nodes.get(&node_id).is_some_and(|n| n.is_available());
8111 0 : if !available {
8112 0 : continue;
8113 0 : }
8114 0 :
8115 0 : if plan.len() >= fill_requirement
8116 0 : || free_tids_by_node.is_empty()
8117 0 : || attached <= expected_attached
8118 : {
8119 0 : break;
8120 0 : }
8121 0 :
8122 0 : let can_take = attached - expected_attached;
8123 0 : let needed = fill_requirement - plan.len();
8124 0 : let mut take = std::cmp::min(can_take, needed);
8125 0 :
8126 0 : let mut remove_node = false;
8127 0 : while take > 0 {
8128 0 : match free_tids_by_node.get_mut(&node_id) {
8129 0 : Some(tids) => match tids.pop() {
8130 0 : Some(tid) => {
8131 0 : let max_promote_for_tenant = std::cmp::max(
8132 0 : tid.shard_count.count() as usize / locked.nodes.len(),
8133 0 : 1,
8134 0 : );
8135 0 : let promoted = promoted_per_tenant.entry(tid.tenant_id).or_default();
8136 0 : if *promoted < max_promote_for_tenant {
8137 0 : plan.push(tid);
8138 0 : *promoted += 1;
8139 0 : take -= 1;
8140 0 : }
8141 : }
8142 : None => {
8143 0 : remove_node = true;
8144 0 : break;
8145 : }
8146 : },
8147 : None => {
8148 0 : break;
8149 : }
8150 : }
8151 : }
8152 :
8153 0 : if remove_node {
8154 0 : free_tids_by_node.remove(&node_id);
8155 0 : }
8156 : }
8157 :
8158 0 : plan
8159 0 : }
8160 :
8161 : /// Fill a node by promoting its secondaries until the cluster is balanced
8162 : /// with regards to attached shard counts. Note that this operation only
8163 : /// makes sense as a counterpart to the drain implemented in [`Service::drain_node`].
8164 : /// This is a long running operation and it should run as a separate Tokio task.
8165 0 : pub(crate) async fn fill_node(
8166 0 : &self,
8167 0 : node_id: NodeId,
8168 0 : cancel: CancellationToken,
8169 0 : ) -> Result<(), OperationError> {
8170 : const SECONDARY_WARMUP_TIMEOUT: Duration = Duration::from_secs(20);
8171 : const SECONDARY_DOWNLOAD_REQUEST_TIMEOUT: Duration = Duration::from_secs(5);
8172 0 : let reconciler_config = ReconcilerConfigBuilder::new(ReconcilerPriority::Normal)
8173 0 : .secondary_warmup_timeout(SECONDARY_WARMUP_TIMEOUT)
8174 0 : .secondary_download_request_timeout(SECONDARY_DOWNLOAD_REQUEST_TIMEOUT)
8175 0 : .build();
8176 0 :
8177 0 : let mut tids_to_promote = self.fill_node_plan(node_id);
8178 0 : let mut waiters = Vec::new();
8179 :
8180 : // Execute the plan we've composed above. Before aplying each move from the plan,
8181 : // we validate to ensure that it has not gone stale in the meantime.
8182 0 : while !tids_to_promote.is_empty() {
8183 0 : if cancel.is_cancelled() {
8184 0 : match self
8185 0 : .node_configure(node_id, None, Some(NodeSchedulingPolicy::Active))
8186 0 : .await
8187 : {
8188 0 : Ok(()) => return Err(OperationError::Cancelled),
8189 0 : Err(err) => {
8190 0 : return Err(OperationError::FinalizeError(
8191 0 : format!(
8192 0 : "Failed to finalise drain cancel of {} by setting scheduling policy to Active: {}",
8193 0 : node_id, err
8194 0 : )
8195 0 : .into(),
8196 0 : ));
8197 : }
8198 : }
8199 0 : }
8200 0 :
8201 0 : {
8202 0 : let mut locked = self.inner.write().unwrap();
8203 0 : let (nodes, tenants, scheduler) = locked.parts_mut();
8204 :
8205 0 : let node = nodes.get(&node_id).ok_or(OperationError::NodeStateChanged(
8206 0 : format!("node {node_id} was removed").into(),
8207 0 : ))?;
8208 :
8209 0 : let current_policy = node.get_scheduling();
8210 0 : if !matches!(current_policy, NodeSchedulingPolicy::Filling) {
8211 : // TODO(vlad): maybe cancel pending reconciles before erroring out. need to think
8212 : // about it
8213 0 : return Err(OperationError::NodeStateChanged(
8214 0 : format!("node {node_id} changed state to {current_policy:?}").into(),
8215 0 : ));
8216 0 : }
8217 :
8218 0 : while waiters.len() < MAX_RECONCILES_PER_OPERATION {
8219 0 : if let Some(tid) = tids_to_promote.pop() {
8220 0 : if let Some(tenant_shard) = tenants.get_mut(&tid) {
8221 : // If the node being filled is not a secondary anymore,
8222 : // skip the promotion.
8223 0 : if !tenant_shard.intent.get_secondary().contains(&node_id) {
8224 0 : continue;
8225 0 : }
8226 0 :
8227 0 : let previously_attached_to = *tenant_shard.intent.get_attached();
8228 0 : match tenant_shard.reschedule_to_secondary(Some(node_id), scheduler) {
8229 0 : Err(e) => {
8230 0 : tracing::warn!(
8231 0 : tenant_id=%tid.tenant_id, shard_id=%tid.shard_slug(),
8232 0 : "Scheduling error when filling pageserver {} : {e}", node_id
8233 : );
8234 : }
8235 : Ok(()) => {
8236 0 : tracing::info!(
8237 0 : tenant_id=%tid.tenant_id, shard_id=%tid.shard_slug(),
8238 0 : "Rescheduled shard while filling node {}: {:?} -> {}",
8239 : node_id,
8240 : previously_attached_to,
8241 : node_id
8242 : );
8243 :
8244 0 : if let Some(waiter) = self.maybe_configured_reconcile_shard(
8245 0 : tenant_shard,
8246 0 : nodes,
8247 0 : reconciler_config,
8248 0 : ) {
8249 0 : waiters.push(waiter);
8250 0 : }
8251 : }
8252 : }
8253 0 : }
8254 : } else {
8255 0 : break;
8256 : }
8257 : }
8258 : }
8259 :
8260 0 : waiters = self
8261 0 : .await_waiters_remainder(waiters, WAITER_FILL_DRAIN_POLL_TIMEOUT)
8262 0 : .await;
8263 : }
8264 :
8265 0 : while !waiters.is_empty() {
8266 0 : if cancel.is_cancelled() {
8267 0 : match self
8268 0 : .node_configure(node_id, None, Some(NodeSchedulingPolicy::Active))
8269 0 : .await
8270 : {
8271 0 : Ok(()) => return Err(OperationError::Cancelled),
8272 0 : Err(err) => {
8273 0 : return Err(OperationError::FinalizeError(
8274 0 : format!(
8275 0 : "Failed to finalise drain cancel of {} by setting scheduling policy to Active: {}",
8276 0 : node_id, err
8277 0 : )
8278 0 : .into(),
8279 0 : ));
8280 : }
8281 : }
8282 0 : }
8283 0 :
8284 0 : tracing::info!("Awaiting {} pending fill reconciliations", waiters.len());
8285 :
8286 0 : waiters = self
8287 0 : .await_waiters_remainder(waiters, SHORT_RECONCILE_TIMEOUT)
8288 0 : .await;
8289 : }
8290 :
8291 0 : if let Err(err) = self
8292 0 : .node_configure(node_id, None, Some(NodeSchedulingPolicy::Active))
8293 0 : .await
8294 : {
8295 : // This isn't a huge issue since the filling process starts upon request. However, it
8296 : // will prevent the next drain from starting. The only case in which this can fail
8297 : // is database unavailability. Such a case will require manual intervention.
8298 0 : return Err(OperationError::FinalizeError(
8299 0 : format!("Failed to finalise fill of {node_id} by setting scheduling policy to Active: {err}")
8300 0 : .into(),
8301 0 : ));
8302 0 : }
8303 0 :
8304 0 : Ok(())
8305 0 : }
8306 :
8307 : /// Updates scrubber metadata health check results.
8308 0 : pub(crate) async fn metadata_health_update(
8309 0 : &self,
8310 0 : update_req: MetadataHealthUpdateRequest,
8311 0 : ) -> Result<(), ApiError> {
8312 0 : let now = chrono::offset::Utc::now();
8313 0 : let (healthy_records, unhealthy_records) = {
8314 0 : let locked = self.inner.read().unwrap();
8315 0 : let healthy_records = update_req
8316 0 : .healthy_tenant_shards
8317 0 : .into_iter()
8318 0 : // Retain only health records associated with tenant shards managed by storage controller.
8319 0 : .filter(|tenant_shard_id| locked.tenants.contains_key(tenant_shard_id))
8320 0 : .map(|tenant_shard_id| MetadataHealthPersistence::new(tenant_shard_id, true, now))
8321 0 : .collect();
8322 0 : let unhealthy_records = update_req
8323 0 : .unhealthy_tenant_shards
8324 0 : .into_iter()
8325 0 : .filter(|tenant_shard_id| locked.tenants.contains_key(tenant_shard_id))
8326 0 : .map(|tenant_shard_id| MetadataHealthPersistence::new(tenant_shard_id, false, now))
8327 0 : .collect();
8328 0 :
8329 0 : (healthy_records, unhealthy_records)
8330 0 : };
8331 0 :
8332 0 : self.persistence
8333 0 : .update_metadata_health_records(healthy_records, unhealthy_records, now)
8334 0 : .await?;
8335 0 : Ok(())
8336 0 : }
8337 :
8338 : /// Lists the tenant shards that has unhealthy metadata status.
8339 0 : pub(crate) async fn metadata_health_list_unhealthy(
8340 0 : &self,
8341 0 : ) -> Result<Vec<TenantShardId>, ApiError> {
8342 0 : let result = self
8343 0 : .persistence
8344 0 : .list_unhealthy_metadata_health_records()
8345 0 : .await?
8346 0 : .iter()
8347 0 : .map(|p| p.get_tenant_shard_id().unwrap())
8348 0 : .collect();
8349 0 :
8350 0 : Ok(result)
8351 0 : }
8352 :
8353 : /// Lists the tenant shards that have not been scrubbed for some duration.
8354 0 : pub(crate) async fn metadata_health_list_outdated(
8355 0 : &self,
8356 0 : not_scrubbed_for: Duration,
8357 0 : ) -> Result<Vec<MetadataHealthRecord>, ApiError> {
8358 0 : let earlier = chrono::offset::Utc::now() - not_scrubbed_for;
8359 0 : let result = self
8360 0 : .persistence
8361 0 : .list_outdated_metadata_health_records(earlier)
8362 0 : .await?
8363 0 : .into_iter()
8364 0 : .map(|record| record.into())
8365 0 : .collect();
8366 0 : Ok(result)
8367 0 : }
8368 :
8369 0 : pub(crate) fn get_leadership_status(&self) -> LeadershipStatus {
8370 0 : self.inner.read().unwrap().get_leadership_status()
8371 0 : }
8372 :
8373 0 : pub(crate) async fn step_down(&self) -> GlobalObservedState {
8374 0 : tracing::info!("Received step down request from peer");
8375 0 : failpoint_support::sleep_millis_async!("sleep-on-step-down-handling");
8376 :
8377 0 : self.inner.write().unwrap().step_down();
8378 0 : // TODO: would it make sense to have a time-out for this?
8379 0 : self.stop_reconciliations(StopReconciliationsReason::SteppingDown)
8380 0 : .await;
8381 :
8382 0 : let mut global_observed = GlobalObservedState::default();
8383 0 : let locked = self.inner.read().unwrap();
8384 0 : for (tid, tenant_shard) in locked.tenants.iter() {
8385 0 : global_observed
8386 0 : .0
8387 0 : .insert(*tid, tenant_shard.observed.clone());
8388 0 : }
8389 :
8390 0 : global_observed
8391 0 : }
8392 :
8393 0 : pub(crate) async fn update_shards_preferred_azs(
8394 0 : &self,
8395 0 : req: ShardsPreferredAzsRequest,
8396 0 : ) -> Result<ShardsPreferredAzsResponse, ApiError> {
8397 0 : let preferred_azs = req.preferred_az_ids.into_iter().collect::<Vec<_>>();
8398 0 : let updated = self
8399 0 : .persistence
8400 0 : .set_tenant_shard_preferred_azs(preferred_azs)
8401 0 : .await
8402 0 : .map_err(|err| {
8403 0 : ApiError::InternalServerError(anyhow::anyhow!(
8404 0 : "Failed to persist preferred AZs: {err}"
8405 0 : ))
8406 0 : })?;
8407 :
8408 0 : let mut updated_in_mem_and_db = Vec::default();
8409 0 :
8410 0 : let mut locked = self.inner.write().unwrap();
8411 0 : let state = locked.deref_mut();
8412 0 : for (tid, az_id) in updated {
8413 0 : let shard = state.tenants.get_mut(&tid);
8414 0 : if let Some(shard) = shard {
8415 0 : shard.set_preferred_az(&mut state.scheduler, az_id);
8416 0 : updated_in_mem_and_db.push(tid);
8417 0 : }
8418 : }
8419 :
8420 0 : Ok(ShardsPreferredAzsResponse {
8421 0 : updated: updated_in_mem_and_db,
8422 0 : })
8423 0 : }
8424 : }
|
