Line data Source code
1 : use std::collections::HashMap;
2 : use std::fmt::Display;
3 : use std::sync::Arc;
4 : use std::time::Duration;
5 :
6 : use anyhow::{Context, anyhow};
7 : use futures::StreamExt;
8 : use futures::future::Either;
9 : use pageserver_api::shard::ShardIdentity;
10 : use postgres_backend::{CopyStreamHandlerEnd, PostgresBackend};
11 : use postgres_ffi::waldecoder::{WalDecodeError, WalStreamDecoder};
12 : use postgres_ffi::{PgMajorVersion, get_current_timestamp};
13 : use pq_proto::{BeMessage, InterpretedWalRecordsBody, WalSndKeepAlive};
14 : use tokio::io::{AsyncRead, AsyncWrite};
15 : use tokio::sync::mpsc::error::SendError;
16 : use tokio::task::JoinHandle;
17 : use tokio::time::MissedTickBehavior;
18 : use tracing::{Instrument, error, info, info_span};
19 : use utils::critical_timeline;
20 : use utils::lsn::Lsn;
21 : use utils::postgres_client::{Compression, InterpretedFormat};
22 : use wal_decoder::models::{InterpretedWalRecord, InterpretedWalRecords};
23 : use wal_decoder::wire_format::ToWireFormat;
24 :
25 : use crate::metrics::WAL_READERS;
26 : use crate::send_wal::{EndWatchView, WalSenderGuard};
27 : use crate::timeline::WalResidentTimeline;
28 : use crate::wal_reader_stream::{StreamingWalReader, WalBytes};
29 :
30 : /// Identifier used to differentiate between senders of the same
31 : /// shard.
32 : ///
33 : /// In the steady state there's only one, but two pageservers may
34 : /// temporarily have the same shard attached and attempt to ingest
35 : /// WAL for it. See also [`ShardSenderId`].
36 : #[derive(Hash, Eq, PartialEq, Copy, Clone)]
37 : struct SenderId(u8);
38 :
39 : impl SenderId {
40 6 : fn first() -> Self {
41 6 : SenderId(0)
42 6 : }
43 :
44 2 : fn next(&self) -> Self {
45 2 : SenderId(self.0.checked_add(1).expect("few senders"))
46 2 : }
47 : }
48 :
49 : #[derive(Hash, Eq, PartialEq)]
50 : struct ShardSenderId {
51 : shard: ShardIdentity,
52 : sender_id: SenderId,
53 : }
54 :
55 : impl Display for ShardSenderId {
56 0 : fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
57 0 : write!(f, "{}{}", self.sender_id.0, self.shard.shard_slug())
58 0 : }
59 : }
60 :
61 : impl ShardSenderId {
62 877 : fn new(shard: ShardIdentity, sender_id: SenderId) -> Self {
63 877 : ShardSenderId { shard, sender_id }
64 877 : }
65 :
66 0 : fn shard(&self) -> ShardIdentity {
67 0 : self.shard
68 0 : }
69 : }
70 :
71 : /// Shard-aware fan-out interpreted record reader.
72 : /// Reads WAL from disk, decodes it, intepretets it, and sends
73 : /// it to any [`InterpretedWalSender`] connected to it.
74 : /// Each [`InterpretedWalSender`] corresponds to one shard
75 : /// and gets interpreted records concerning that shard only.
76 : pub(crate) struct InterpretedWalReader {
77 : wal_stream: StreamingWalReader,
78 : shard_senders: HashMap<ShardIdentity, smallvec::SmallVec<[ShardSenderState; 1]>>,
79 : shard_notification_rx: Option<tokio::sync::mpsc::UnboundedReceiver<AttachShardNotification>>,
80 : state: Arc<std::sync::RwLock<InterpretedWalReaderState>>,
81 : pg_version: PgMajorVersion,
82 : }
83 :
84 : /// A handle for [`InterpretedWalReader`] which allows for interacting with it
85 : /// when it runs as a separate tokio task.
86 : #[derive(Debug)]
87 : pub(crate) struct InterpretedWalReaderHandle {
88 : join_handle: JoinHandle<Result<(), InterpretedWalReaderError>>,
89 : state: Arc<std::sync::RwLock<InterpretedWalReaderState>>,
90 : shard_notification_tx: tokio::sync::mpsc::UnboundedSender<AttachShardNotification>,
91 : }
92 :
93 : struct ShardSenderState {
94 : sender_id: SenderId,
95 : tx: tokio::sync::mpsc::Sender<Batch>,
96 : next_record_lsn: Lsn,
97 : }
98 :
99 : /// State of [`InterpretedWalReader`] visible outside of the task running it.
100 : #[derive(Debug)]
101 : pub(crate) enum InterpretedWalReaderState {
102 : Running {
103 : current_position: Lsn,
104 : /// Tracks the start of the PG WAL LSN from which the current batch of
105 : /// interpreted records originated.
106 : current_batch_wal_start: Option<Lsn>,
107 : },
108 : Done,
109 : }
110 :
111 : pub(crate) struct Batch {
112 : wal_end_lsn: Lsn,
113 : available_wal_end_lsn: Lsn,
114 : records: InterpretedWalRecords,
115 : }
116 :
117 : #[derive(thiserror::Error, Debug)]
118 : pub enum InterpretedWalReaderError {
119 : /// Handler initiates the end of streaming.
120 : #[error("decode error: {0}")]
121 : Decode(#[from] WalDecodeError),
122 : #[error("read or interpret error: {0}")]
123 : ReadOrInterpret(#[from] anyhow::Error),
124 : #[error("wal stream closed")]
125 : WalStreamClosed,
126 : }
127 :
128 : enum CurrentPositionUpdate {
129 : Reset { from: Lsn, to: Lsn },
130 : NotReset(Lsn),
131 : }
132 :
133 : impl CurrentPositionUpdate {
134 0 : fn current_position(&self) -> Lsn {
135 0 : match self {
136 0 : CurrentPositionUpdate::Reset { from: _, to } => *to,
137 0 : CurrentPositionUpdate::NotReset(lsn) => *lsn,
138 : }
139 0 : }
140 :
141 0 : fn previous_position(&self) -> Lsn {
142 0 : match self {
143 0 : CurrentPositionUpdate::Reset { from, to: _ } => *from,
144 0 : CurrentPositionUpdate::NotReset(lsn) => *lsn,
145 : }
146 0 : }
147 : }
148 :
149 : impl InterpretedWalReaderState {
150 6 : fn current_position(&self) -> Option<Lsn> {
151 6 : match self {
152 : InterpretedWalReaderState::Running {
153 3 : current_position, ..
154 3 : } => Some(*current_position),
155 3 : InterpretedWalReaderState::Done => None,
156 : }
157 6 : }
158 :
159 : #[cfg(test)]
160 50 : fn current_batch_wal_start(&self) -> Option<Lsn> {
161 50 : match self {
162 : InterpretedWalReaderState::Running {
163 50 : current_batch_wal_start,
164 : ..
165 50 : } => *current_batch_wal_start,
166 0 : InterpretedWalReaderState::Done => None,
167 : }
168 50 : }
169 :
170 : // Reset the current position of the WAL reader if the requested starting position
171 : // of the new shard is smaller than the current value.
172 4 : fn maybe_reset(&mut self, new_shard_start_pos: Lsn) -> CurrentPositionUpdate {
173 4 : match self {
174 : InterpretedWalReaderState::Running {
175 4 : current_position,
176 4 : current_batch_wal_start,
177 : } => {
178 4 : if new_shard_start_pos < *current_position {
179 3 : let from = *current_position;
180 3 : *current_position = new_shard_start_pos;
181 3 : *current_batch_wal_start = None;
182 3 : CurrentPositionUpdate::Reset {
183 3 : from,
184 3 : to: *current_position,
185 3 : }
186 : } else {
187 : // Edge case: The new shard is at the same current position as
188 : // the reader. Note that the current position is WAL record aligned,
189 : // so the reader might have done some partial reads and updated the
190 : // batch start. If that's the case, adjust the batch start to match
191 : // starting position of the new shard. It can lead to some shards
192 : // seeing overlaps, but in that case the actual record LSNs are checked
193 : // which should be fine based on the filtering logic.
194 1 : if let Some(start) = current_batch_wal_start {
195 0 : *start = std::cmp::min(*start, new_shard_start_pos);
196 1 : }
197 1 : CurrentPositionUpdate::NotReset(*current_position)
198 : }
199 : }
200 : InterpretedWalReaderState::Done => {
201 0 : panic!("maybe_reset called on finished reader")
202 : }
203 : }
204 4 : }
205 :
206 50 : fn update_current_batch_wal_start(&mut self, lsn: Lsn) {
207 50 : match self {
208 : InterpretedWalReaderState::Running {
209 50 : current_batch_wal_start,
210 : ..
211 : } => {
212 50 : if current_batch_wal_start.is_none() {
213 6 : *current_batch_wal_start = Some(lsn);
214 44 : }
215 : }
216 : InterpretedWalReaderState::Done => {
217 0 : panic!("update_current_batch_wal_start called on finished reader")
218 : }
219 : }
220 50 : }
221 :
222 41 : fn replace_current_batch_wal_start(&mut self, with: Lsn) -> Lsn {
223 41 : match self {
224 : InterpretedWalReaderState::Running {
225 41 : current_batch_wal_start,
226 : ..
227 41 : } => current_batch_wal_start.replace(with).unwrap(),
228 : InterpretedWalReaderState::Done => {
229 0 : panic!("take_current_batch_wal_start called on finished reader")
230 : }
231 : }
232 41 : }
233 :
234 41 : fn update_current_position(&mut self, lsn: Lsn) {
235 41 : match self {
236 : InterpretedWalReaderState::Running {
237 41 : current_position, ..
238 41 : } => {
239 41 : *current_position = lsn;
240 41 : }
241 : InterpretedWalReaderState::Done => {
242 0 : panic!("update_current_position called on finished reader")
243 : }
244 : }
245 41 : }
246 : }
247 :
248 : pub(crate) struct AttachShardNotification {
249 : shard_id: ShardIdentity,
250 : sender: tokio::sync::mpsc::Sender<Batch>,
251 : start_pos: Lsn,
252 : }
253 :
254 : impl InterpretedWalReader {
255 : /// Spawn the reader in a separate tokio task and return a handle
256 3 : pub(crate) fn spawn(
257 3 : wal_stream: StreamingWalReader,
258 3 : start_pos: Lsn,
259 3 : tx: tokio::sync::mpsc::Sender<Batch>,
260 3 : shard: ShardIdentity,
261 3 : pg_version: PgMajorVersion,
262 3 : appname: &Option<String>,
263 3 : ) -> InterpretedWalReaderHandle {
264 3 : let state = Arc::new(std::sync::RwLock::new(InterpretedWalReaderState::Running {
265 3 : current_position: start_pos,
266 3 : current_batch_wal_start: None,
267 3 : }));
268 :
269 3 : let (shard_notification_tx, shard_notification_rx) = tokio::sync::mpsc::unbounded_channel();
270 :
271 3 : let ttid = wal_stream.ttid;
272 :
273 3 : let reader = InterpretedWalReader {
274 3 : wal_stream,
275 3 : shard_senders: HashMap::from([(
276 3 : shard,
277 3 : smallvec::smallvec![ShardSenderState {
278 0 : sender_id: SenderId::first(),
279 0 : tx,
280 0 : next_record_lsn: start_pos,
281 0 : }],
282 : )]),
283 3 : shard_notification_rx: Some(shard_notification_rx),
284 3 : state: state.clone(),
285 3 : pg_version,
286 : };
287 :
288 3 : let metric = WAL_READERS
289 3 : .get_metric_with_label_values(&["task", appname.as_deref().unwrap_or("safekeeper")])
290 3 : .unwrap();
291 :
292 3 : let join_handle = tokio::task::spawn(
293 3 : async move {
294 3 : metric.inc();
295 3 : scopeguard::defer! {
296 : metric.dec();
297 : }
298 :
299 3 : reader
300 3 : .run_impl(start_pos)
301 3 : .await
302 0 : .inspect_err(|err| match err {
303 : // TODO: we may want to differentiate these errors further.
304 : InterpretedWalReaderError::Decode(_) => {
305 0 : critical_timeline!(
306 0 : ttid.tenant_id,
307 0 : ttid.timeline_id,
308 0 : "failed to read WAL record: {err:?}"
309 : );
310 : }
311 0 : err => error!("failed to read WAL record: {err}"),
312 0 : })
313 0 : }
314 3 : .instrument(info_span!("interpreted wal reader")),
315 : );
316 :
317 3 : InterpretedWalReaderHandle {
318 3 : join_handle,
319 3 : state,
320 3 : shard_notification_tx,
321 3 : }
322 3 : }
323 :
324 : /// Construct the reader without spawning anything
325 : /// Callers should drive the future returned by [`Self::run`].
326 1 : pub(crate) fn new(
327 1 : wal_stream: StreamingWalReader,
328 1 : start_pos: Lsn,
329 1 : tx: tokio::sync::mpsc::Sender<Batch>,
330 1 : shard: ShardIdentity,
331 1 : pg_version: PgMajorVersion,
332 1 : shard_notification_rx: Option<
333 1 : tokio::sync::mpsc::UnboundedReceiver<AttachShardNotification>,
334 1 : >,
335 1 : ) -> InterpretedWalReader {
336 1 : let state = Arc::new(std::sync::RwLock::new(InterpretedWalReaderState::Running {
337 1 : current_position: start_pos,
338 1 : current_batch_wal_start: None,
339 1 : }));
340 :
341 : InterpretedWalReader {
342 1 : wal_stream,
343 1 : shard_senders: HashMap::from([(
344 1 : shard,
345 1 : smallvec::smallvec![ShardSenderState {
346 0 : sender_id: SenderId::first(),
347 0 : tx,
348 0 : next_record_lsn: start_pos,
349 0 : }],
350 : )]),
351 1 : shard_notification_rx,
352 1 : state: state.clone(),
353 1 : pg_version,
354 : }
355 1 : }
356 :
357 : /// Entry point for future (polling) based wal reader.
358 1 : pub(crate) async fn run(
359 1 : self,
360 1 : start_pos: Lsn,
361 1 : appname: &Option<String>,
362 1 : ) -> Result<(), CopyStreamHandlerEnd> {
363 1 : let metric = WAL_READERS
364 1 : .get_metric_with_label_values(&["future", appname.as_deref().unwrap_or("safekeeper")])
365 1 : .unwrap();
366 :
367 1 : metric.inc();
368 1 : scopeguard::defer! {
369 : metric.dec();
370 : }
371 :
372 1 : let ttid = self.wal_stream.ttid;
373 1 : match self.run_impl(start_pos).await {
374 0 : Err(err @ InterpretedWalReaderError::Decode(_)) => {
375 0 : critical_timeline!(
376 0 : ttid.tenant_id,
377 0 : ttid.timeline_id,
378 0 : "failed to decode WAL record: {err:?}"
379 : );
380 : }
381 0 : Err(err) => error!("failed to read WAL record: {err}"),
382 0 : Ok(()) => info!("interpreted wal reader exiting"),
383 : }
384 :
385 0 : Err(CopyStreamHandlerEnd::Other(anyhow!(
386 0 : "interpreted wal reader finished"
387 0 : )))
388 0 : }
389 :
390 : /// Send interpreted WAL to one or more [`InterpretedWalSender`]s
391 : /// Stops when an error is encountered or when the [`InterpretedWalReaderHandle`]
392 : /// goes out of scope.
393 4 : async fn run_impl(mut self, start_pos: Lsn) -> Result<(), InterpretedWalReaderError> {
394 4 : let defer_state = self.state.clone();
395 4 : scopeguard::defer! {
396 : *defer_state.write().unwrap() = InterpretedWalReaderState::Done;
397 : }
398 :
399 4 : let mut wal_decoder = WalStreamDecoder::new(start_pos, self.pg_version);
400 :
401 : loop {
402 58 : tokio::select! {
403 : // Main branch for reading WAL and forwarding it
404 58 : wal_or_reset = self.wal_stream.next() => {
405 50 : let wal = wal_or_reset.map(|wor| wor.get_wal().expect("reset handled in select branch below"));
406 : let WalBytes {
407 50 : wal,
408 50 : wal_start_lsn,
409 50 : wal_end_lsn,
410 50 : available_wal_end_lsn,
411 50 : } = match wal {
412 50 : Some(some) => some.map_err(InterpretedWalReaderError::ReadOrInterpret)?,
413 : None => {
414 : // [`StreamingWalReader::next`] is an endless stream of WAL.
415 : // It shouldn't ever finish unless it panicked or became internally
416 : // inconsistent.
417 0 : return Result::Err(InterpretedWalReaderError::WalStreamClosed);
418 : }
419 : };
420 :
421 50 : self.state.write().unwrap().update_current_batch_wal_start(wal_start_lsn);
422 :
423 50 : wal_decoder.feed_bytes(&wal);
424 :
425 : // Deserialize and interpret WAL records from this batch of WAL.
426 : // Interpreted records for each shard are collected separately.
427 50 : let shard_ids = self.shard_senders.keys().copied().collect::<Vec<_>>();
428 50 : let mut records_by_sender: HashMap<ShardSenderId, Vec<InterpretedWalRecord>> = HashMap::new();
429 50 : let mut max_next_record_lsn = None;
430 50 : let mut max_end_record_lsn = None;
431 656 : while let Some((next_record_lsn, recdata)) = wal_decoder.poll_decode()?
432 : {
433 606 : assert!(next_record_lsn.is_aligned());
434 606 : max_next_record_lsn = Some(next_record_lsn);
435 606 : max_end_record_lsn = Some(wal_decoder.lsn());
436 :
437 606 : let interpreted = InterpretedWalRecord::from_bytes_filtered(
438 606 : recdata,
439 606 : &shard_ids,
440 606 : next_record_lsn,
441 606 : self.pg_version,
442 : )
443 606 : .with_context(|| "Failed to interpret WAL")?;
444 :
445 1412 : for (shard, record) in interpreted {
446 : // Shard zero needs to track the start LSN of the latest record
447 : // in adition to the LSN of the next record to ingest. The former
448 : // is included in basebackup persisted by the compute in WAL.
449 806 : if !shard.is_shard_zero() && record.is_empty() {
450 200 : continue;
451 606 : }
452 :
453 606 : let mut states_iter = self.shard_senders
454 606 : .get(&shard)
455 606 : .expect("keys collected above")
456 606 : .iter()
457 1002 : .filter(|state| record.next_record_lsn > state.next_record_lsn)
458 606 : .peekable();
459 996 : while let Some(state) = states_iter.next() {
460 796 : let shard_sender_id = ShardSenderId::new(shard, state.sender_id);
461 :
462 : // The most commont case is one sender per shard. Peek and break to avoid the
463 : // clone in that situation.
464 796 : if states_iter.peek().is_none() {
465 406 : records_by_sender.entry(shard_sender_id).or_default().push(record);
466 406 : break;
467 390 : } else {
468 390 : records_by_sender.entry(shard_sender_id).or_default().push(record.clone());
469 390 : }
470 : }
471 : }
472 : }
473 :
474 50 : let max_next_record_lsn = match max_next_record_lsn {
475 41 : Some(lsn) => lsn,
476 : None => {
477 9 : continue;
478 : }
479 : };
480 :
481 : // Update the current position such that new receivers can decide
482 : // whether to attach to us or spawn a new WAL reader.
483 41 : let batch_wal_start_lsn = {
484 41 : let mut guard = self.state.write().unwrap();
485 41 : guard.update_current_position(max_next_record_lsn);
486 41 : guard.replace_current_batch_wal_start(max_end_record_lsn.unwrap())
487 : };
488 :
489 : // Send interpreted records downstream. Anything that has already been seen
490 : // by a shard is filtered out.
491 41 : let mut shard_senders_to_remove = Vec::new();
492 96 : for (shard, states) in &mut self.shard_senders {
493 136 : for state in states {
494 81 : let shard_sender_id = ShardSenderId::new(*shard, state.sender_id);
495 :
496 81 : let batch = if max_next_record_lsn > state.next_record_lsn {
497 : // This batch contains at least one record that this shard has not
498 : // seen yet.
499 67 : let records = records_by_sender.remove(&shard_sender_id).unwrap_or_default();
500 :
501 67 : InterpretedWalRecords {
502 67 : records,
503 67 : next_record_lsn: max_next_record_lsn,
504 67 : raw_wal_start_lsn: Some(batch_wal_start_lsn),
505 67 : }
506 14 : } else if wal_end_lsn > state.next_record_lsn {
507 : // All the records in this batch were seen by the shard
508 : // However, the batch maps to a chunk of WAL that the
509 : // shard has not yet seen. Notify it of the start LSN
510 : // of the PG WAL chunk such that it doesn't look like a gap.
511 0 : InterpretedWalRecords {
512 0 : records: Vec::default(),
513 0 : next_record_lsn: state.next_record_lsn,
514 0 : raw_wal_start_lsn: Some(batch_wal_start_lsn),
515 0 : }
516 : } else {
517 : // The shard has seen this chunk of WAL before. Skip it.
518 14 : continue;
519 : };
520 :
521 67 : let res = state.tx.send(Batch {
522 67 : wal_end_lsn,
523 67 : available_wal_end_lsn,
524 67 : records: batch,
525 67 : }).await;
526 :
527 67 : if res.is_err() {
528 0 : shard_senders_to_remove.push(shard_sender_id);
529 67 : } else {
530 67 : state.next_record_lsn = std::cmp::max(state.next_record_lsn, max_next_record_lsn);
531 67 : }
532 : }
533 : }
534 :
535 : // Clean up any shard senders that have dropped out.
536 : // This is inefficient, but such events are rare (connection to PS termination)
537 : // and the number of subscriptions on the same shards very small (only one
538 : // for the steady state).
539 41 : for to_remove in shard_senders_to_remove {
540 0 : let shard_senders = self.shard_senders.get_mut(&to_remove.shard()).expect("saw it above");
541 0 : if let Some(idx) = shard_senders.iter().position(|s| s.sender_id == to_remove.sender_id) {
542 0 : shard_senders.remove(idx);
543 0 : tracing::info!("Removed shard sender {}", to_remove);
544 0 : }
545 :
546 0 : if shard_senders.is_empty() {
547 0 : self.shard_senders.remove(&to_remove.shard());
548 0 : }
549 : }
550 : },
551 : // Listen for new shards that want to attach to this reader.
552 : // If the reader is not running as a task, then this is not supported
553 : // (see the pending branch below).
554 58 : notification = match self.shard_notification_rx.as_mut() {
555 58 : Some(rx) => Either::Left(rx.recv()),
556 0 : None => Either::Right(std::future::pending())
557 : } => {
558 4 : if let Some(n) = notification {
559 4 : let AttachShardNotification { shard_id, sender, start_pos } = n;
560 :
561 : // Update internal and external state, then reset the WAL stream
562 : // if required.
563 4 : let senders = self.shard_senders.entry(shard_id).or_default();
564 4 : let new_sender_id = match senders.last() {
565 2 : Some(sender) => sender.sender_id.next(),
566 2 : None => SenderId::first()
567 : };
568 :
569 4 : senders.push(ShardSenderState { sender_id: new_sender_id, tx: sender, next_record_lsn: start_pos});
570 :
571 : // If the shard is subscribing below the current position the we need
572 : // to update the cursor that tracks where we are at in the WAL
573 : // ([`Self::state`]) and reset the WAL stream itself
574 : // (`[Self::wal_stream`]). This must be done atomically from the POV of
575 : // anything outside the select statement.
576 4 : let position_reset = self.state.write().unwrap().maybe_reset(start_pos);
577 4 : match position_reset {
578 3 : CurrentPositionUpdate::Reset { from: _, to } => {
579 3 : self.wal_stream.reset(to).await;
580 3 : wal_decoder = WalStreamDecoder::new(to, self.pg_version);
581 : },
582 1 : CurrentPositionUpdate::NotReset(_) => {}
583 : };
584 :
585 4 : tracing::info!(
586 0 : "Added shard sender {} with start_pos={} previous_pos={} current_pos={}",
587 0 : ShardSenderId::new(shard_id, new_sender_id),
588 : start_pos,
589 0 : position_reset.previous_position(),
590 0 : position_reset.current_position(),
591 : );
592 0 : }
593 : }
594 : }
595 : }
596 0 : }
597 :
598 : #[cfg(test)]
599 1 : fn state(&self) -> Arc<std::sync::RwLock<InterpretedWalReaderState>> {
600 1 : self.state.clone()
601 1 : }
602 : }
603 :
604 : impl InterpretedWalReaderHandle {
605 : /// Fan-out the reader by attaching a new shard to it
606 3 : pub(crate) fn fanout(
607 3 : &self,
608 3 : shard_id: ShardIdentity,
609 3 : sender: tokio::sync::mpsc::Sender<Batch>,
610 3 : start_pos: Lsn,
611 3 : ) -> Result<(), SendError<AttachShardNotification>> {
612 3 : self.shard_notification_tx.send(AttachShardNotification {
613 3 : shard_id,
614 3 : sender,
615 3 : start_pos,
616 3 : })
617 3 : }
618 :
619 : /// Get the current WAL position of the reader
620 6 : pub(crate) fn current_position(&self) -> Option<Lsn> {
621 6 : self.state.read().unwrap().current_position()
622 6 : }
623 :
624 6 : pub(crate) fn abort(&self) {
625 6 : self.join_handle.abort()
626 6 : }
627 : }
628 :
629 : impl Drop for InterpretedWalReaderHandle {
630 3 : fn drop(&mut self) {
631 3 : tracing::info!("Aborting interpreted wal reader");
632 3 : self.abort()
633 3 : }
634 : }
635 :
636 : pub(crate) struct InterpretedWalSender<'a, IO> {
637 : pub(crate) format: InterpretedFormat,
638 : pub(crate) compression: Option<Compression>,
639 : pub(crate) appname: Option<String>,
640 :
641 : pub(crate) tli: WalResidentTimeline,
642 : pub(crate) start_lsn: Lsn,
643 :
644 : pub(crate) pgb: &'a mut PostgresBackend<IO>,
645 : pub(crate) end_watch_view: EndWatchView,
646 : pub(crate) wal_sender_guard: Arc<WalSenderGuard>,
647 : pub(crate) rx: tokio::sync::mpsc::Receiver<Batch>,
648 : }
649 :
650 : impl<IO: AsyncRead + AsyncWrite + Unpin> InterpretedWalSender<'_, IO> {
651 : /// Send interpreted WAL records over the network.
652 : /// Also manages keep-alives if nothing was sent for a while.
653 0 : pub(crate) async fn run(mut self) -> Result<(), CopyStreamHandlerEnd> {
654 0 : let mut keepalive_ticker = tokio::time::interval(Duration::from_secs(1));
655 0 : keepalive_ticker.set_missed_tick_behavior(MissedTickBehavior::Skip);
656 0 : keepalive_ticker.reset();
657 :
658 0 : let mut wal_position = self.start_lsn;
659 :
660 : loop {
661 0 : tokio::select! {
662 0 : batch = self.rx.recv() => {
663 0 : let batch = match batch {
664 0 : Some(b) => b,
665 : None => {
666 0 : return Result::Err(
667 0 : CopyStreamHandlerEnd::Other(anyhow!("Interpreted WAL reader exited early"))
668 0 : );
669 : }
670 : };
671 :
672 0 : wal_position = batch.wal_end_lsn;
673 :
674 0 : let buf = batch
675 0 : .records
676 0 : .to_wire(self.format, self.compression)
677 0 : .await
678 0 : .with_context(|| "Failed to serialize interpreted WAL")
679 0 : .map_err(CopyStreamHandlerEnd::from)?;
680 :
681 : // Reset the keep alive ticker since we are sending something
682 : // over the wire now.
683 0 : keepalive_ticker.reset();
684 :
685 0 : self.pgb
686 0 : .write_message(&BeMessage::InterpretedWalRecords(InterpretedWalRecordsBody {
687 0 : streaming_lsn: batch.wal_end_lsn.0,
688 0 : commit_lsn: batch.available_wal_end_lsn.0,
689 0 : data: &buf,
690 0 : })).await?;
691 : }
692 : // Send a periodic keep alive when the connection has been idle for a while.
693 : // Since we've been idle, also check if we can stop streaming.
694 0 : _ = keepalive_ticker.tick() => {
695 0 : if let Some(remote_consistent_lsn) = self.wal_sender_guard
696 0 : .walsenders()
697 0 : .get_ws_remote_consistent_lsn(self.wal_sender_guard.id())
698 : {
699 0 : if self.tli.should_walsender_stop(remote_consistent_lsn).await {
700 : // Stop streaming if the receivers are caught up and
701 : // there's no active compute. This causes the loop in
702 : // [`crate::send_interpreted_wal::InterpretedWalSender::run`]
703 : // to exit and terminate the WAL stream.
704 0 : break;
705 0 : }
706 0 : }
707 :
708 0 : self.pgb
709 0 : .write_message(&BeMessage::KeepAlive(WalSndKeepAlive {
710 0 : wal_end: self.end_watch_view.get().0,
711 0 : timestamp: get_current_timestamp(),
712 0 : request_reply: true,
713 0 : }))
714 0 : .await?;
715 : },
716 : }
717 : }
718 :
719 0 : Err(CopyStreamHandlerEnd::ServerInitiated(format!(
720 0 : "ending streaming to {:?} at {}, receiver is caughtup and there is no computes",
721 0 : self.appname, wal_position,
722 0 : )))
723 0 : }
724 : }
725 : #[cfg(test)]
726 : mod tests {
727 : use std::collections::HashMap;
728 : use std::str::FromStr;
729 : use std::time::Duration;
730 :
731 : use pageserver_api::shard::{ShardIdentity, ShardStripeSize};
732 : use postgres_ffi::{MAX_SEND_SIZE, PgMajorVersion};
733 : use tokio::sync::mpsc::error::TryRecvError;
734 : use utils::id::{NodeId, TenantTimelineId};
735 : use utils::lsn::Lsn;
736 : use utils::shard::{ShardCount, ShardNumber};
737 :
738 : use crate::send_interpreted_wal::{AttachShardNotification, Batch, InterpretedWalReader};
739 : use crate::test_utils::Env;
740 : use crate::wal_reader_stream::StreamingWalReader;
741 :
742 : #[tokio::test]
743 1 : async fn test_interpreted_wal_reader_fanout() {
744 1 : let _ = env_logger::builder().is_test(true).try_init();
745 :
746 : const SIZE: usize = 8 * 1024;
747 : const MSG_COUNT: usize = 200;
748 : const PG_VERSION: PgMajorVersion = PgMajorVersion::PG17;
749 : const SHARD_COUNT: u8 = 2;
750 :
751 1 : let start_lsn = Lsn::from_str("0/149FD18").unwrap();
752 1 : let env = Env::new(true).unwrap();
753 1 : let tli = env
754 1 : .make_timeline(NodeId(1), TenantTimelineId::generate(), start_lsn)
755 1 : .await
756 1 : .unwrap();
757 :
758 1 : let resident_tli = tli.wal_residence_guard().await.unwrap();
759 1 : let end_watch = Env::write_wal(tli, start_lsn, SIZE, MSG_COUNT, c"neon-file:", None)
760 1 : .await
761 1 : .unwrap();
762 1 : let end_pos = end_watch.get();
763 :
764 1 : tracing::info!("Doing first round of reads ...");
765 :
766 1 : let streaming_wal_reader = StreamingWalReader::new(
767 1 : resident_tli,
768 1 : None,
769 1 : start_lsn,
770 1 : end_pos,
771 1 : end_watch,
772 : MAX_SEND_SIZE,
773 : );
774 :
775 1 : let shard_0 = ShardIdentity::new(
776 1 : ShardNumber(0),
777 1 : ShardCount(SHARD_COUNT),
778 1 : ShardStripeSize::default(),
779 : )
780 1 : .unwrap();
781 :
782 1 : let shard_1 = ShardIdentity::new(
783 1 : ShardNumber(1),
784 1 : ShardCount(SHARD_COUNT),
785 1 : ShardStripeSize::default(),
786 : )
787 1 : .unwrap();
788 :
789 1 : let mut shards = HashMap::new();
790 :
791 3 : for shard_number in 0..SHARD_COUNT {
792 2 : let shard_id = ShardIdentity::new(
793 2 : ShardNumber(shard_number),
794 2 : ShardCount(SHARD_COUNT),
795 2 : ShardStripeSize::default(),
796 2 : )
797 2 : .unwrap();
798 2 : let (tx, rx) = tokio::sync::mpsc::channel::<Batch>(MSG_COUNT * 2);
799 2 : shards.insert(shard_id, (Some(tx), Some(rx)));
800 2 : }
801 :
802 1 : let shard_0_tx = shards.get_mut(&shard_0).unwrap().0.take().unwrap();
803 1 : let mut shard_0_rx = shards.get_mut(&shard_0).unwrap().1.take().unwrap();
804 :
805 1 : let handle = InterpretedWalReader::spawn(
806 1 : streaming_wal_reader,
807 1 : start_lsn,
808 1 : shard_0_tx,
809 1 : shard_0,
810 : PG_VERSION,
811 1 : &Some("pageserver".to_string()),
812 : );
813 :
814 1 : tracing::info!("Reading all WAL with only shard 0 attached ...");
815 :
816 1 : let mut shard_0_interpreted_records = Vec::new();
817 13 : while let Some(batch) = shard_0_rx.recv().await {
818 13 : shard_0_interpreted_records.push(batch.records);
819 13 : if batch.wal_end_lsn == batch.available_wal_end_lsn {
820 1 : break;
821 12 : }
822 : }
823 :
824 1 : let shard_1_tx = shards.get_mut(&shard_1).unwrap().0.take().unwrap();
825 1 : let mut shard_1_rx = shards.get_mut(&shard_1).unwrap().1.take().unwrap();
826 :
827 1 : tracing::info!("Attaching shard 1 to the reader at start of WAL");
828 1 : handle.fanout(shard_1, shard_1_tx, start_lsn).unwrap();
829 :
830 1 : tracing::info!("Reading all WAL with shard 0 and shard 1 attached ...");
831 :
832 1 : let mut shard_1_interpreted_records = Vec::new();
833 13 : while let Some(batch) = shard_1_rx.recv().await {
834 13 : shard_1_interpreted_records.push(batch.records);
835 13 : if batch.wal_end_lsn == batch.available_wal_end_lsn {
836 1 : break;
837 12 : }
838 : }
839 :
840 : // This test uses logical messages. Those only go to shard 0. Check that the
841 : // filtering worked and shard 1 did not get any.
842 1 : assert!(
843 1 : shard_1_interpreted_records
844 1 : .iter()
845 13 : .all(|recs| recs.records.is_empty())
846 : );
847 :
848 : // Shard 0 should not receive anything more since the reader is
849 : // going through wal that it has already processed.
850 1 : let res = shard_0_rx.try_recv();
851 1 : if let Ok(ref ok) = res {
852 0 : tracing::error!(
853 0 : "Shard 0 received batch: wal_end_lsn={} available_wal_end_lsn={}",
854 : ok.wal_end_lsn,
855 : ok.available_wal_end_lsn
856 : );
857 1 : }
858 1 : assert!(matches!(res, Err(TryRecvError::Empty)));
859 :
860 : // Check that the next records lsns received by the two shards match up.
861 1 : let shard_0_next_lsns = shard_0_interpreted_records
862 1 : .iter()
863 1 : .map(|recs| recs.next_record_lsn)
864 1 : .collect::<Vec<_>>();
865 1 : let shard_1_next_lsns = shard_1_interpreted_records
866 1 : .iter()
867 1 : .map(|recs| recs.next_record_lsn)
868 1 : .collect::<Vec<_>>();
869 1 : assert_eq!(shard_0_next_lsns, shard_1_next_lsns);
870 :
871 1 : handle.abort();
872 1 : let mut done = false;
873 2 : for _ in 0..5 {
874 2 : if handle.current_position().is_none() {
875 1 : done = true;
876 1 : break;
877 1 : }
878 1 : tokio::time::sleep(Duration::from_millis(1)).await;
879 1 : }
880 1 :
881 1 : assert!(done);
882 1 : }
883 :
884 : #[tokio::test]
885 1 : async fn test_interpreted_wal_reader_same_shard_fanout() {
886 1 : let _ = env_logger::builder().is_test(true).try_init();
887 :
888 : const SIZE: usize = 8 * 1024;
889 : const MSG_COUNT: usize = 200;
890 : const PG_VERSION: PgMajorVersion = PgMajorVersion::PG17;
891 : const SHARD_COUNT: u8 = 2;
892 :
893 1 : let start_lsn = Lsn::from_str("0/149FD18").unwrap();
894 1 : let env = Env::new(true).unwrap();
895 1 : let tli = env
896 1 : .make_timeline(NodeId(1), TenantTimelineId::generate(), start_lsn)
897 1 : .await
898 1 : .unwrap();
899 :
900 1 : let resident_tli = tli.wal_residence_guard().await.unwrap();
901 1 : let mut next_record_lsns = Vec::default();
902 1 : let end_watch = Env::write_wal(
903 1 : tli,
904 1 : start_lsn,
905 1 : SIZE,
906 1 : MSG_COUNT,
907 1 : c"neon-file:",
908 1 : Some(&mut next_record_lsns),
909 1 : )
910 1 : .await
911 1 : .unwrap();
912 1 : let end_pos = end_watch.get();
913 :
914 1 : let streaming_wal_reader = StreamingWalReader::new(
915 1 : resident_tli,
916 1 : None,
917 1 : start_lsn,
918 1 : end_pos,
919 1 : end_watch,
920 : MAX_SEND_SIZE,
921 : );
922 :
923 1 : let shard_0 = ShardIdentity::new(
924 1 : ShardNumber(0),
925 1 : ShardCount(SHARD_COUNT),
926 1 : ShardStripeSize::default(),
927 : )
928 1 : .unwrap();
929 :
930 : struct Sender {
931 : tx: Option<tokio::sync::mpsc::Sender<Batch>>,
932 : rx: tokio::sync::mpsc::Receiver<Batch>,
933 : shard: ShardIdentity,
934 : start_lsn: Lsn,
935 : received_next_record_lsns: Vec<Lsn>,
936 : }
937 :
938 : impl Sender {
939 3 : fn new(start_lsn: Lsn, shard: ShardIdentity) -> Self {
940 3 : let (tx, rx) = tokio::sync::mpsc::channel::<Batch>(MSG_COUNT * 2);
941 3 : Self {
942 3 : tx: Some(tx),
943 3 : rx,
944 3 : shard,
945 3 : start_lsn,
946 3 : received_next_record_lsns: Vec::default(),
947 3 : }
948 3 : }
949 : }
950 :
951 1 : assert!(next_record_lsns.len() > 7);
952 1 : let start_lsns = vec![
953 1 : next_record_lsns[5],
954 1 : next_record_lsns[1],
955 1 : next_record_lsns[3],
956 : ];
957 1 : let mut senders = start_lsns
958 1 : .into_iter()
959 3 : .map(|lsn| Sender::new(lsn, shard_0))
960 1 : .collect::<Vec<_>>();
961 :
962 1 : let first_sender = senders.first_mut().unwrap();
963 1 : let handle = InterpretedWalReader::spawn(
964 1 : streaming_wal_reader,
965 1 : first_sender.start_lsn,
966 1 : first_sender.tx.take().unwrap(),
967 1 : first_sender.shard,
968 : PG_VERSION,
969 1 : &Some("pageserver".to_string()),
970 : );
971 :
972 2 : for sender in senders.iter_mut().skip(1) {
973 2 : handle
974 2 : .fanout(sender.shard, sender.tx.take().unwrap(), sender.start_lsn)
975 2 : .unwrap();
976 2 : }
977 :
978 3 : for sender in senders.iter_mut() {
979 : loop {
980 39 : let batch = sender.rx.recv().await.unwrap();
981 39 : tracing::info!(
982 0 : "Sender with start_lsn={} received batch ending at {} with {} records",
983 : sender.start_lsn,
984 : batch.wal_end_lsn,
985 0 : batch.records.records.len()
986 : );
987 :
988 627 : for rec in batch.records.records {
989 588 : sender.received_next_record_lsns.push(rec.next_record_lsn);
990 588 : }
991 :
992 39 : if batch.wal_end_lsn == batch.available_wal_end_lsn {
993 3 : break;
994 36 : }
995 : }
996 : }
997 :
998 1 : handle.abort();
999 1 : let mut done = false;
1000 2 : for _ in 0..5 {
1001 2 : if handle.current_position().is_none() {
1002 1 : done = true;
1003 1 : break;
1004 1 : }
1005 1 : tokio::time::sleep(Duration::from_millis(1)).await;
1006 : }
1007 :
1008 1 : assert!(done);
1009 :
1010 4 : for sender in senders {
1011 3 : tracing::info!(
1012 1 : "Validating records received by sender with start_lsn={}",
1013 1 : sender.start_lsn
1014 1 : );
1015 1 :
1016 3 : assert!(sender.received_next_record_lsns.is_sorted());
1017 3 : let expected = next_record_lsns
1018 3 : .iter()
1019 600 : .filter(|lsn| **lsn > sender.start_lsn)
1020 3 : .copied()
1021 3 : .collect::<Vec<_>>();
1022 3 : assert_eq!(sender.received_next_record_lsns, expected);
1023 1 : }
1024 1 : }
1025 :
1026 : #[tokio::test]
1027 1 : async fn test_batch_start_tracking_on_reset() {
1028 : // When the WAL stream is reset to an older LSN,
1029 : // the current batch start LSN should be invalidated.
1030 : // This test constructs such a scenario:
1031 : // 1. Shard 0 is reading somewhere ahead
1032 : // 2. Reader reads some WAL, but does not decode a full record (partial read)
1033 : // 3. Shard 1 attaches to the reader and resets it to an older LSN
1034 : // 4. Shard 1 should get the correct batch WAL start LSN
1035 1 : let _ = env_logger::builder().is_test(true).try_init();
1036 :
1037 : const SIZE: usize = 64 * 1024;
1038 : const MSG_COUNT: usize = 10;
1039 : const PG_VERSION: PgMajorVersion = PgMajorVersion::PG17;
1040 : const SHARD_COUNT: u8 = 2;
1041 : const WAL_READER_BATCH_SIZE: usize = 8192;
1042 :
1043 1 : let start_lsn = Lsn::from_str("0/149FD18").unwrap();
1044 1 : let env = Env::new(true).unwrap();
1045 1 : let mut next_record_lsns = Vec::default();
1046 1 : let tli = env
1047 1 : .make_timeline(NodeId(1), TenantTimelineId::generate(), start_lsn)
1048 1 : .await
1049 1 : .unwrap();
1050 :
1051 1 : let resident_tli = tli.wal_residence_guard().await.unwrap();
1052 1 : let end_watch = Env::write_wal(
1053 1 : tli,
1054 1 : start_lsn,
1055 1 : SIZE,
1056 1 : MSG_COUNT,
1057 1 : c"neon-file:",
1058 1 : Some(&mut next_record_lsns),
1059 1 : )
1060 1 : .await
1061 1 : .unwrap();
1062 :
1063 1 : assert!(next_record_lsns.len() > 3);
1064 1 : let shard_0_start_lsn = next_record_lsns[3];
1065 :
1066 1 : let end_pos = end_watch.get();
1067 :
1068 1 : let streaming_wal_reader = StreamingWalReader::new(
1069 1 : resident_tli,
1070 1 : None,
1071 1 : shard_0_start_lsn,
1072 1 : end_pos,
1073 1 : end_watch,
1074 : WAL_READER_BATCH_SIZE,
1075 : );
1076 :
1077 1 : let shard_0 = ShardIdentity::new(
1078 1 : ShardNumber(0),
1079 1 : ShardCount(SHARD_COUNT),
1080 1 : ShardStripeSize::default(),
1081 : )
1082 1 : .unwrap();
1083 :
1084 1 : let shard_1 = ShardIdentity::new(
1085 1 : ShardNumber(1),
1086 1 : ShardCount(SHARD_COUNT),
1087 1 : ShardStripeSize::default(),
1088 : )
1089 1 : .unwrap();
1090 :
1091 1 : let mut shards = HashMap::new();
1092 :
1093 3 : for shard_number in 0..SHARD_COUNT {
1094 2 : let shard_id = ShardIdentity::new(
1095 2 : ShardNumber(shard_number),
1096 2 : ShardCount(SHARD_COUNT),
1097 2 : ShardStripeSize::default(),
1098 2 : )
1099 2 : .unwrap();
1100 2 : let (tx, rx) = tokio::sync::mpsc::channel::<Batch>(MSG_COUNT * 2);
1101 2 : shards.insert(shard_id, (Some(tx), Some(rx)));
1102 2 : }
1103 :
1104 1 : let shard_0_tx = shards.get_mut(&shard_0).unwrap().0.take().unwrap();
1105 :
1106 1 : let (shard_notification_tx, shard_notification_rx) = tokio::sync::mpsc::unbounded_channel();
1107 :
1108 1 : let reader = InterpretedWalReader::new(
1109 1 : streaming_wal_reader,
1110 1 : shard_0_start_lsn,
1111 1 : shard_0_tx,
1112 1 : shard_0,
1113 : PG_VERSION,
1114 1 : Some(shard_notification_rx),
1115 : );
1116 :
1117 1 : let reader_state = reader.state();
1118 1 : let mut reader_fut = std::pin::pin!(reader.run(shard_0_start_lsn, &None));
1119 : loop {
1120 50 : let poll = futures::poll!(reader_fut.as_mut());
1121 50 : assert!(poll.is_pending());
1122 :
1123 50 : let guard = reader_state.read().unwrap();
1124 50 : if guard.current_batch_wal_start().is_some() {
1125 1 : break;
1126 49 : }
1127 : }
1128 :
1129 1 : shard_notification_tx
1130 1 : .send(AttachShardNotification {
1131 1 : shard_id: shard_1,
1132 1 : sender: shards.get_mut(&shard_1).unwrap().0.take().unwrap(),
1133 1 : start_pos: start_lsn,
1134 1 : })
1135 1 : .unwrap();
1136 :
1137 1 : let mut shard_1_rx = shards.get_mut(&shard_1).unwrap().1.take().unwrap();
1138 1 : loop {
1139 70 : let poll = futures::poll!(reader_fut.as_mut());
1140 70 : assert!(poll.is_pending());
1141 1 :
1142 70 : let try_recv_res = shard_1_rx.try_recv();
1143 69 : match try_recv_res {
1144 1 : Ok(batch) => {
1145 1 : assert_eq!(batch.records.raw_wal_start_lsn.unwrap(), start_lsn);
1146 1 : break;
1147 1 : }
1148 69 : Err(tokio::sync::mpsc::error::TryRecvError::Empty) => {}
1149 1 : Err(tokio::sync::mpsc::error::TryRecvError::Disconnected) => {
1150 1 : unreachable!();
1151 1 : }
1152 1 : }
1153 1 : }
1154 1 : }
1155 :
1156 : #[tokio::test]
1157 1 : async fn test_shard_zero_does_not_skip_empty_records() {
1158 1 : let _ = env_logger::builder().is_test(true).try_init();
1159 :
1160 : const SIZE: usize = 8 * 1024;
1161 : const MSG_COUNT: usize = 10;
1162 : const PG_VERSION: PgMajorVersion = PgMajorVersion::PG17;
1163 :
1164 1 : let start_lsn = Lsn::from_str("0/149FD18").unwrap();
1165 1 : let env = Env::new(true).unwrap();
1166 1 : let tli = env
1167 1 : .make_timeline(NodeId(1), TenantTimelineId::generate(), start_lsn)
1168 1 : .await
1169 1 : .unwrap();
1170 :
1171 1 : let resident_tli = tli.wal_residence_guard().await.unwrap();
1172 1 : let mut next_record_lsns = Vec::new();
1173 1 : let end_watch = Env::write_wal(
1174 1 : tli,
1175 1 : start_lsn,
1176 1 : SIZE,
1177 1 : MSG_COUNT,
1178 1 : // This is a logical message prefix that is not persisted to key value storage.
1179 1 : // We use it in order to validate that shard zero receives emtpy interpreted records.
1180 1 : c"test:",
1181 1 : Some(&mut next_record_lsns),
1182 1 : )
1183 1 : .await
1184 1 : .unwrap();
1185 1 : let end_pos = end_watch.get();
1186 :
1187 1 : let streaming_wal_reader = StreamingWalReader::new(
1188 1 : resident_tli,
1189 1 : None,
1190 1 : start_lsn,
1191 1 : end_pos,
1192 1 : end_watch,
1193 : MAX_SEND_SIZE,
1194 : );
1195 :
1196 1 : let shard = ShardIdentity::unsharded();
1197 1 : let (records_tx, mut records_rx) = tokio::sync::mpsc::channel::<Batch>(MSG_COUNT * 2);
1198 :
1199 1 : let handle = InterpretedWalReader::spawn(
1200 1 : streaming_wal_reader,
1201 1 : start_lsn,
1202 1 : records_tx,
1203 1 : shard,
1204 : PG_VERSION,
1205 1 : &Some("pageserver".to_string()),
1206 : );
1207 :
1208 1 : let mut interpreted_records = Vec::new();
1209 1 : while let Some(batch) = records_rx.recv().await {
1210 1 : interpreted_records.push(batch.records);
1211 1 : if batch.wal_end_lsn == batch.available_wal_end_lsn {
1212 1 : break;
1213 0 : }
1214 : }
1215 :
1216 1 : let received_next_record_lsns = interpreted_records
1217 1 : .into_iter()
1218 1 : .flat_map(|b| b.records)
1219 1 : .map(|rec| rec.next_record_lsn)
1220 1 : .collect::<Vec<_>>();
1221 :
1222 : // By default this also includes the start LSN. Trim it since it shouldn't be received.
1223 1 : let next_record_lsns = next_record_lsns.into_iter().skip(1).collect::<Vec<_>>();
1224 :
1225 1 : assert_eq!(received_next_record_lsns, next_record_lsns);
1226 :
1227 1 : handle.abort();
1228 1 : let mut done = false;
1229 2 : for _ in 0..5 {
1230 2 : if handle.current_position().is_none() {
1231 1 : done = true;
1232 1 : break;
1233 1 : }
1234 1 : tokio::time::sleep(Duration::from_millis(1)).await;
1235 1 : }
1236 1 :
1237 1 : assert!(done);
1238 1 : }
1239 : }
|
