Line data Source code
1 : use std::collections::HashSet;
2 : use std::str::FromStr;
3 : use std::sync::Arc;
4 : use std::time::Duration;
5 :
6 : use super::safekeeper_reconciler::ScheduleRequest;
7 : use crate::heartbeater::SafekeeperState;
8 : use crate::metrics;
9 : use crate::persistence::{
10 : DatabaseError, SafekeeperTimelineOpKind, TimelinePendingOpPersistence, TimelinePersistence,
11 : };
12 : use crate::safekeeper::Safekeeper;
13 : use crate::timeline_import::TimelineImportFinalizeError;
14 : use anyhow::Context;
15 : use http_utils::error::ApiError;
16 : use pageserver_api::controller_api::{
17 : SafekeeperDescribeResponse, SkSchedulingPolicy, TimelineImportRequest,
18 : };
19 : use pageserver_api::models::{SafekeeperInfo, SafekeepersInfo, TimelineInfo};
20 : use safekeeper_api::membership::{MemberSet, SafekeeperId};
21 : use tokio::task::JoinSet;
22 : use tokio_util::sync::CancellationToken;
23 : use utils::id::{NodeId, TenantId, TimelineId};
24 : use utils::logging::SecretString;
25 : use utils::lsn::Lsn;
26 :
27 : use super::Service;
28 :
29 : impl Service {
30 : /// Timeline creation on safekeepers
31 : ///
32 : /// Returns `Ok(left)` if the timeline has been created on a quorum of safekeepers,
33 : /// where `left` contains the list of safekeepers that didn't have a successful response.
34 : /// Assumes tenant lock is held while calling this function.
35 0 : pub(super) async fn tenant_timeline_create_safekeepers_quorum(
36 0 : &self,
37 0 : tenant_id: TenantId,
38 0 : timeline_id: TimelineId,
39 0 : pg_version: u32,
40 0 : timeline_persistence: &TimelinePersistence,
41 0 : ) -> Result<Vec<NodeId>, ApiError> {
42 0 : // If quorum is reached, return if we are outside of a specified timeout
43 0 : let jwt = self
44 0 : .config
45 0 : .safekeeper_jwt_token
46 0 : .clone()
47 0 : .map(SecretString::from);
48 0 : let mut joinset = JoinSet::new();
49 0 :
50 0 : // Prepare membership::Configuration from choosen safekeepers.
51 0 : let safekeepers = {
52 0 : let locked = self.inner.read().unwrap();
53 0 : locked.safekeepers.clone()
54 0 : };
55 0 :
56 0 : let mut members = Vec::new();
57 0 : for sk_id in timeline_persistence.sk_set.iter() {
58 0 : let sk_id = NodeId(*sk_id as u64);
59 0 : let Some(safekeeper) = safekeepers.get(&sk_id) else {
60 0 : return Err(ApiError::InternalServerError(anyhow::anyhow!(
61 0 : "couldn't find entry for safekeeper with id {sk_id}"
62 0 : )))?;
63 : };
64 0 : members.push(SafekeeperId {
65 0 : id: sk_id,
66 0 : host: safekeeper.skp.host.clone(),
67 0 : pg_port: safekeeper.skp.port as u16,
68 0 : });
69 : }
70 0 : let mset = MemberSet::new(members).map_err(ApiError::InternalServerError)?;
71 0 : let mconf = safekeeper_api::membership::Configuration::new(mset);
72 0 :
73 0 : let req = safekeeper_api::models::TimelineCreateRequest {
74 0 : commit_lsn: None,
75 0 : mconf,
76 0 : pg_version,
77 0 : start_lsn: timeline_persistence.start_lsn.0,
78 0 : system_id: None,
79 0 : tenant_id,
80 0 : timeline_id,
81 0 : wal_seg_size: None,
82 0 : };
83 : const SK_CREATE_TIMELINE_RECONCILE_TIMEOUT: Duration = Duration::from_secs(30);
84 0 : for sk in timeline_persistence.sk_set.iter() {
85 0 : let sk_id = NodeId(*sk as u64);
86 0 : let safekeepers = safekeepers.clone();
87 0 : let http_client = self.http_client.clone();
88 0 : let jwt = jwt.clone();
89 0 : let req = req.clone();
90 0 : joinset.spawn(async move {
91 0 : // Unwrap is fine as we already would have returned error above
92 0 : let sk_p = safekeepers.get(&sk_id).unwrap();
93 0 : let res = sk_p
94 0 : .with_client_retries(
95 0 : |client| {
96 0 : let req = req.clone();
97 0 : async move { client.create_timeline(&req).await }
98 0 : },
99 0 : &http_client,
100 0 : &jwt,
101 0 : 3,
102 0 : 3,
103 0 : SK_CREATE_TIMELINE_RECONCILE_TIMEOUT,
104 0 : &CancellationToken::new(),
105 0 : )
106 0 : .await;
107 0 : (sk_id, sk_p.skp.host.clone(), res)
108 0 : });
109 0 : }
110 : // After we have built the joinset, we now wait for the tasks to complete,
111 : // but with a specified timeout to make sure we return swiftly, either with
112 : // a failure or success.
113 0 : let reconcile_deadline = tokio::time::Instant::now() + SK_CREATE_TIMELINE_RECONCILE_TIMEOUT;
114 0 :
115 0 : // Wait until all tasks finish or timeout is hit, whichever occurs
116 0 : // first.
117 0 : let mut reconcile_results = Vec::new();
118 : loop {
119 0 : if let Ok(res) = tokio::time::timeout_at(reconcile_deadline, joinset.join_next()).await
120 : {
121 0 : let Some(res) = res else { break };
122 0 : match res {
123 0 : Ok(res) => {
124 0 : tracing::info!(
125 0 : "response from safekeeper id:{} at {}: {:?}",
126 : res.0,
127 : res.1,
128 : res.2
129 : );
130 0 : reconcile_results.push(res);
131 : }
132 0 : Err(join_err) => {
133 0 : tracing::info!("join_err for task in joinset: {join_err}");
134 : }
135 : }
136 : } else {
137 0 : tracing::info!(
138 0 : "timeout for creation call after {} responses",
139 0 : reconcile_results.len()
140 : );
141 0 : break;
142 : }
143 : }
144 :
145 : // Now check now if quorum was reached in reconcile_results.
146 0 : let total_result_count = reconcile_results.len();
147 0 : let remaining = reconcile_results
148 0 : .into_iter()
149 0 : .filter_map(|res| res.2.is_err().then_some(res.0))
150 0 : .collect::<Vec<_>>();
151 0 : tracing::info!(
152 0 : "Got {} non-successful responses from initial creation request of total {total_result_count} responses",
153 0 : remaining.len()
154 : );
155 0 : let target_sk_count = timeline_persistence.sk_set.len();
156 0 : let quorum_size = match target_sk_count {
157 : 0 => {
158 0 : return Err(ApiError::InternalServerError(anyhow::anyhow!(
159 0 : "timeline configured without any safekeepers",
160 0 : )));
161 : }
162 : 1 | 2 => {
163 : #[cfg(feature = "testing")]
164 : {
165 : // In test settings, it is allowed to have one or two safekeepers
166 0 : target_sk_count
167 : }
168 : #[cfg(not(feature = "testing"))]
169 : {
170 : // The region is misconfigured: we need at least three safekeepers to be configured
171 : // in order to schedule work to them
172 : tracing::warn!(
173 : "couldn't find at least 3 safekeepers for timeline, found: {:?}",
174 : timeline_persistence.sk_set
175 : );
176 : return Err(ApiError::InternalServerError(anyhow::anyhow!(
177 : "couldn't find at least 3 safekeepers to put timeline to"
178 : )));
179 : }
180 : }
181 0 : _ => target_sk_count / 2 + 1,
182 : };
183 0 : let success_count = target_sk_count - remaining.len();
184 0 : if success_count < quorum_size {
185 : // Failure
186 0 : return Err(ApiError::InternalServerError(anyhow::anyhow!(
187 0 : "not enough successful reconciliations to reach quorum size: {success_count} of {quorum_size} of total {target_sk_count}"
188 0 : )));
189 0 : }
190 0 :
191 0 : Ok(remaining)
192 0 : }
193 :
194 : /// Create timeline in controller database and on safekeepers.
195 : /// `timeline_info` is result of timeline creation on pageserver.
196 : ///
197 : /// All actions must be idempotent as the call is retried until success. It
198 : /// tries to create timeline in the db and on at least majority of
199 : /// safekeepers + queue creation for safekeepers which missed it in the db
200 : /// for infinite retries; after that, call returns Ok.
201 : ///
202 : /// The idea is that once this is reached as long as we have alive majority
203 : /// of safekeepers it is expected to get eventually operational as storcon
204 : /// will be able to seed timeline on nodes which missed creation by making
205 : /// pull_timeline from peers. On the other hand we don't want to fail
206 : /// timeline creation if one safekeeper is down.
207 0 : pub(super) async fn tenant_timeline_create_safekeepers(
208 0 : self: &Arc<Self>,
209 0 : tenant_id: TenantId,
210 0 : timeline_info: &TimelineInfo,
211 0 : ) -> Result<SafekeepersInfo, ApiError> {
212 0 : let timeline_id = timeline_info.timeline_id;
213 0 : let pg_version = timeline_info.pg_version * 10000;
214 0 : // Initially start_lsn is determined by last_record_lsn in pageserver
215 0 : // response as it does initdb. However, later we persist it and in sk
216 0 : // creation calls replace with the value from the timeline row if it
217 0 : // previously existed as on retries in theory endpoint might have
218 0 : // already written some data and advanced last_record_lsn, while we want
219 0 : // safekeepers to have consistent start_lsn.
220 0 : let start_lsn = timeline_info.last_record_lsn;
221 :
222 : // Choose initial set of safekeepers respecting affinity
223 0 : let sks = self.safekeepers_for_new_timeline().await?;
224 0 : let sks_persistence = sks.iter().map(|sk| sk.id.0 as i64).collect::<Vec<_>>();
225 0 : // Add timeline to db
226 0 : let mut timeline_persist = TimelinePersistence {
227 0 : tenant_id: tenant_id.to_string(),
228 0 : timeline_id: timeline_id.to_string(),
229 0 : start_lsn: start_lsn.into(),
230 0 : generation: 1,
231 0 : sk_set: sks_persistence.clone(),
232 0 : new_sk_set: None,
233 0 : cplane_notified_generation: 0,
234 0 : deleted_at: None,
235 0 : };
236 0 : let inserted = self
237 0 : .persistence
238 0 : .insert_timeline(timeline_persist.clone())
239 0 : .await?;
240 0 : if !inserted {
241 0 : if let Some(existent_persist) = self
242 0 : .persistence
243 0 : .get_timeline(tenant_id, timeline_id)
244 0 : .await?
245 0 : {
246 0 : // Replace with what we have in the db, to get stuff like the generation right.
247 0 : // We do still repeat the http calls to the safekeepers. After all, we could have
248 0 : // crashed right after the wrote to the DB.
249 0 : timeline_persist = existent_persist;
250 0 : } else {
251 0 : return Err(ApiError::InternalServerError(anyhow::anyhow!(
252 0 : "insertion said timeline already in db, but looking it up, it was gone"
253 0 : )));
254 : }
255 0 : }
256 : // Create the timeline on a quorum of safekeepers
257 0 : let remaining = self
258 0 : .tenant_timeline_create_safekeepers_quorum(
259 0 : tenant_id,
260 0 : timeline_id,
261 0 : pg_version,
262 0 : &timeline_persist,
263 0 : )
264 0 : .await?;
265 :
266 : // For the remaining safekeepers, take care of their reconciliation asynchronously
267 0 : for &remaining_id in remaining.iter() {
268 0 : let pending_op = TimelinePendingOpPersistence {
269 0 : tenant_id: tenant_id.to_string(),
270 0 : timeline_id: timeline_id.to_string(),
271 0 : generation: timeline_persist.generation,
272 0 : op_kind: crate::persistence::SafekeeperTimelineOpKind::Pull,
273 0 : sk_id: remaining_id.0 as i64,
274 0 : };
275 0 : tracing::info!("writing pending op for sk id {remaining_id}");
276 0 : self.persistence.insert_pending_op(pending_op).await?;
277 : }
278 0 : if !remaining.is_empty() {
279 0 : let locked = self.inner.read().unwrap();
280 0 : for remaining_id in remaining {
281 0 : let Some(sk) = locked.safekeepers.get(&remaining_id) else {
282 0 : return Err(ApiError::InternalServerError(anyhow::anyhow!(
283 0 : "Couldn't find safekeeper with id {remaining_id}"
284 0 : )));
285 : };
286 0 : let Ok(host_list) = sks
287 0 : .iter()
288 0 : .map(|sk| {
289 0 : Ok((
290 0 : sk.id,
291 0 : locked
292 0 : .safekeepers
293 0 : .get(&sk.id)
294 0 : .ok_or_else(|| {
295 0 : ApiError::InternalServerError(anyhow::anyhow!(
296 0 : "Couldn't find safekeeper with id {} to pull from",
297 0 : sk.id
298 0 : ))
299 0 : })?
300 0 : .base_url(),
301 : ))
302 0 : })
303 0 : .collect::<Result<_, ApiError>>()
304 : else {
305 0 : continue;
306 : };
307 0 : let req = ScheduleRequest {
308 0 : safekeeper: Box::new(sk.clone()),
309 0 : host_list,
310 0 : tenant_id,
311 0 : timeline_id: Some(timeline_id),
312 0 : generation: timeline_persist.generation as u32,
313 0 : kind: crate::persistence::SafekeeperTimelineOpKind::Pull,
314 0 : };
315 0 : locked.safekeeper_reconcilers.schedule_request(req);
316 : }
317 0 : }
318 :
319 0 : Ok(SafekeepersInfo {
320 0 : generation: timeline_persist.generation as u32,
321 0 : safekeepers: sks,
322 0 : tenant_id,
323 0 : timeline_id,
324 0 : })
325 0 : }
326 :
327 0 : pub(crate) async fn tenant_timeline_create_safekeepers_until_success(
328 0 : self: &Arc<Self>,
329 0 : tenant_id: TenantId,
330 0 : timeline_info: TimelineInfo,
331 0 : ) -> Result<(), TimelineImportFinalizeError> {
332 : const BACKOFF: Duration = Duration::from_secs(5);
333 :
334 : loop {
335 0 : if self.cancel.is_cancelled() {
336 0 : return Err(TimelineImportFinalizeError::ShuttingDown);
337 0 : }
338 :
339 0 : let res = self
340 0 : .tenant_timeline_create_safekeepers(tenant_id, &timeline_info)
341 0 : .await;
342 :
343 0 : match res {
344 : Ok(_) => {
345 0 : tracing::info!("Timeline created on safekeepers");
346 0 : break;
347 : }
348 0 : Err(err) => {
349 0 : tracing::error!("Failed to create timeline on safekeepers: {err}");
350 0 : tokio::select! {
351 0 : _ = self.cancel.cancelled() => {
352 0 : return Err(TimelineImportFinalizeError::ShuttingDown);
353 : },
354 0 : _ = tokio::time::sleep(BACKOFF) => {}
355 : };
356 : }
357 : }
358 : }
359 :
360 0 : Ok(())
361 0 : }
362 :
363 : /// Directly insert the timeline into the database without reconciling it with safekeepers.
364 : ///
365 : /// Useful if the timeline already exists on the specified safekeepers,
366 : /// but we want to make it storage controller managed.
367 0 : pub(crate) async fn timeline_import(&self, req: TimelineImportRequest) -> Result<(), ApiError> {
368 0 : let persistence = TimelinePersistence {
369 0 : tenant_id: req.tenant_id.to_string(),
370 0 : timeline_id: req.timeline_id.to_string(),
371 0 : start_lsn: Lsn::INVALID.into(),
372 0 : generation: 1,
373 0 : sk_set: req.sk_set.iter().map(|sk_id| sk_id.0 as i64).collect(),
374 0 : new_sk_set: None,
375 0 : cplane_notified_generation: 1,
376 0 : deleted_at: None,
377 0 : };
378 0 : let inserted = self.persistence.insert_timeline(persistence).await?;
379 0 : if inserted {
380 0 : tracing::info!("imported timeline into db");
381 : } else {
382 0 : tracing::info!("didn't import timeline into db, as it is already present in db");
383 : }
384 0 : Ok(())
385 0 : }
386 :
387 : /// Perform timeline deletion on safekeepers. Will return success: we persist the deletion into the reconciler.
388 0 : pub(super) async fn tenant_timeline_delete_safekeepers(
389 0 : self: &Arc<Self>,
390 0 : tenant_id: TenantId,
391 0 : timeline_id: TimelineId,
392 0 : ) -> Result<(), ApiError> {
393 0 : let tl = self
394 0 : .persistence
395 0 : .get_timeline(tenant_id, timeline_id)
396 0 : .await?;
397 0 : let Some(tl) = tl else {
398 0 : tracing::info!(
399 0 : "timeline {tenant_id}/{timeline_id} doesn't exist in timelines table, no deletions on safekeepers needed"
400 : );
401 0 : return Ok(());
402 : };
403 0 : self.persistence
404 0 : .timeline_set_deleted_at(tenant_id, timeline_id)
405 0 : .await?;
406 0 : let all_sks = tl
407 0 : .new_sk_set
408 0 : .iter()
409 0 : .flatten()
410 0 : .chain(tl.sk_set.iter())
411 0 : .collect::<HashSet<_>>();
412 :
413 : // Schedule reconciliations
414 0 : for &sk_id in all_sks.iter() {
415 0 : let pending_op = TimelinePendingOpPersistence {
416 0 : tenant_id: tenant_id.to_string(),
417 0 : timeline_id: timeline_id.to_string(),
418 0 : generation: i32::MAX,
419 0 : op_kind: SafekeeperTimelineOpKind::Delete,
420 0 : sk_id: *sk_id,
421 0 : };
422 0 : tracing::info!("writing pending op for sk id {sk_id}");
423 0 : self.persistence.insert_pending_op(pending_op).await?;
424 : }
425 : {
426 0 : let locked = self.inner.read().unwrap();
427 0 : for sk_id in all_sks {
428 0 : let sk_id = NodeId(*sk_id as u64);
429 0 : let Some(sk) = locked.safekeepers.get(&sk_id) else {
430 0 : return Err(ApiError::InternalServerError(anyhow::anyhow!(
431 0 : "Couldn't find safekeeper with id {sk_id}"
432 0 : )));
433 : };
434 :
435 0 : let req = ScheduleRequest {
436 0 : safekeeper: Box::new(sk.clone()),
437 0 : // we don't use this for this kind, put a dummy value
438 0 : host_list: Vec::new(),
439 0 : tenant_id,
440 0 : timeline_id: Some(timeline_id),
441 0 : generation: tl.generation as u32,
442 0 : kind: SafekeeperTimelineOpKind::Delete,
443 0 : };
444 0 : locked.safekeeper_reconcilers.schedule_request(req);
445 : }
446 : }
447 0 : Ok(())
448 0 : }
449 :
450 : /// Perform tenant deletion on safekeepers.
451 0 : pub(super) async fn tenant_delete_safekeepers(
452 0 : self: &Arc<Self>,
453 0 : tenant_id: TenantId,
454 0 : ) -> Result<(), ApiError> {
455 0 : let timeline_list = self
456 0 : .persistence
457 0 : .list_timelines_for_tenant(tenant_id)
458 0 : .await?;
459 :
460 0 : if timeline_list.is_empty() {
461 : // Early exit: the tenant is either empty or not migrated to the storcon yet
462 0 : tracing::info!("Skipping tenant delete as the timeline doesn't exist in db");
463 0 : return Ok(());
464 0 : }
465 :
466 0 : let timeline_list = timeline_list
467 0 : .into_iter()
468 0 : .map(|timeline| {
469 0 : let timeline_id = TimelineId::from_str(&timeline.timeline_id)
470 0 : .context("timeline id loaded from db")
471 0 : .map_err(ApiError::InternalServerError)?;
472 0 : Ok((timeline_id, timeline))
473 0 : })
474 0 : .collect::<Result<Vec<_>, ApiError>>()?;
475 :
476 : // Remove pending ops from db, and set `deleted_at`.
477 : // We cancel them in a later iteration once we hold the state lock.
478 0 : for (timeline_id, _timeline) in timeline_list.iter() {
479 0 : self.persistence
480 0 : .remove_pending_ops_for_timeline(tenant_id, Some(*timeline_id))
481 0 : .await?;
482 0 : self.persistence
483 0 : .timeline_set_deleted_at(tenant_id, *timeline_id)
484 0 : .await?;
485 : }
486 :
487 : // The list of safekeepers that have any of the timelines
488 0 : let mut sk_list = HashSet::new();
489 :
490 : // List all pending ops for all timelines, cancel them
491 0 : for (_timeline_id, timeline) in timeline_list.iter() {
492 0 : let sk_iter = timeline
493 0 : .sk_set
494 0 : .iter()
495 0 : .chain(timeline.new_sk_set.iter().flatten())
496 0 : .map(|id| NodeId(*id as u64));
497 0 : sk_list.extend(sk_iter);
498 0 : }
499 :
500 0 : for &sk_id in sk_list.iter() {
501 0 : let pending_op = TimelinePendingOpPersistence {
502 0 : tenant_id: tenant_id.to_string(),
503 0 : timeline_id: String::new(),
504 0 : generation: i32::MAX,
505 0 : op_kind: SafekeeperTimelineOpKind::Delete,
506 0 : sk_id: sk_id.0 as i64,
507 0 : };
508 0 : tracing::info!("writing pending op for sk id {sk_id}");
509 0 : self.persistence.insert_pending_op(pending_op).await?;
510 : }
511 :
512 0 : let mut locked = self.inner.write().unwrap();
513 :
514 0 : for (timeline_id, _timeline) in timeline_list.iter() {
515 0 : for sk_id in sk_list.iter() {
516 0 : locked
517 0 : .safekeeper_reconcilers
518 0 : .cancel_reconciles_for_timeline(*sk_id, tenant_id, Some(*timeline_id));
519 0 : }
520 : }
521 :
522 : // unwrap is safe: we return above for an empty timeline list
523 0 : let max_generation = timeline_list
524 0 : .iter()
525 0 : .map(|(_tl_id, tl)| tl.generation as u32)
526 0 : .max()
527 0 : .unwrap();
528 :
529 0 : for sk_id in sk_list {
530 0 : let Some(safekeeper) = locked.safekeepers.get(&sk_id) else {
531 0 : tracing::warn!("Couldn't find safekeeper with id {sk_id}");
532 0 : continue;
533 : };
534 : // Add pending op for tenant deletion
535 0 : let req = ScheduleRequest {
536 0 : generation: max_generation,
537 0 : host_list: Vec::new(),
538 0 : kind: SafekeeperTimelineOpKind::Delete,
539 0 : safekeeper: Box::new(safekeeper.clone()),
540 0 : tenant_id,
541 0 : timeline_id: None,
542 0 : };
543 0 : locked.safekeeper_reconcilers.schedule_request(req);
544 : }
545 0 : Ok(())
546 0 : }
547 :
548 : /// Choose safekeepers for the new timeline: 3 in different azs.
549 0 : pub(crate) async fn safekeepers_for_new_timeline(
550 0 : &self,
551 0 : ) -> Result<Vec<SafekeeperInfo>, ApiError> {
552 0 : let mut all_safekeepers = {
553 0 : let locked = self.inner.read().unwrap();
554 0 : locked
555 0 : .safekeepers
556 0 : .iter()
557 0 : .filter_map(|sk| {
558 0 : if sk.1.scheduling_policy() != SkSchedulingPolicy::Active {
559 : // If we don't want to schedule stuff onto the safekeeper, respect that.
560 0 : return None;
561 0 : }
562 0 : let utilization_opt = if let SafekeeperState::Available {
563 : last_seen_at: _,
564 0 : utilization,
565 0 : } = sk.1.availability()
566 : {
567 0 : Some(utilization)
568 : } else {
569 : // non-available safekeepers still get a chance for new timelines,
570 : // but put them last in the list.
571 0 : None
572 : };
573 0 : let info = SafekeeperInfo {
574 0 : hostname: sk.1.skp.host.clone(),
575 0 : id: NodeId(sk.1.skp.id as u64),
576 0 : };
577 0 : Some((utilization_opt, info, sk.1.skp.availability_zone_id.clone()))
578 0 : })
579 0 : .collect::<Vec<_>>()
580 0 : };
581 0 : all_safekeepers.sort_by_key(|sk| {
582 0 : (
583 0 : sk.0.as_ref()
584 0 : .map(|ut| ut.timeline_count)
585 0 : .unwrap_or(u64::MAX),
586 0 : // Use the id to decide on equal scores for reliability
587 0 : sk.1.id.0,
588 0 : )
589 0 : });
590 : // Number of safekeepers in different AZs we are looking for
591 0 : let wanted_count = match all_safekeepers.len() {
592 : 0 => {
593 0 : return Err(ApiError::InternalServerError(anyhow::anyhow!(
594 0 : "couldn't find any active safekeeper for new timeline",
595 0 : )));
596 : }
597 : // Have laxer requirements on testig mode as we don't want to
598 : // spin up three safekeepers for every single test
599 : #[cfg(feature = "testing")]
600 0 : 1 | 2 => all_safekeepers.len(),
601 0 : _ => 3,
602 : };
603 0 : let mut sks = Vec::new();
604 0 : let mut azs = HashSet::new();
605 0 : for (_sk_util, sk_info, az_id) in all_safekeepers.iter() {
606 0 : if !azs.insert(az_id) {
607 0 : continue;
608 0 : }
609 0 : sks.push(sk_info.clone());
610 0 : if sks.len() == wanted_count {
611 0 : break;
612 0 : }
613 : }
614 0 : if sks.len() == wanted_count {
615 0 : Ok(sks)
616 : } else {
617 0 : Err(ApiError::InternalServerError(anyhow::anyhow!(
618 0 : "couldn't find {wanted_count} safekeepers in different AZs for new timeline (found: {}, total active: {})",
619 0 : sks.len(),
620 0 : all_safekeepers.len(),
621 0 : )))
622 : }
623 0 : }
624 :
625 0 : pub(crate) async fn safekeepers_list(
626 0 : &self,
627 0 : ) -> Result<Vec<SafekeeperDescribeResponse>, DatabaseError> {
628 0 : let locked = self.inner.read().unwrap();
629 0 : let mut list = locked
630 0 : .safekeepers
631 0 : .iter()
632 0 : .map(|sk| sk.1.describe_response())
633 0 : .collect::<Result<Vec<_>, _>>()?;
634 0 : list.sort_by_key(|v| v.id);
635 0 : Ok(list)
636 0 : }
637 :
638 0 : pub(crate) async fn get_safekeeper(
639 0 : &self,
640 0 : id: i64,
641 0 : ) -> Result<SafekeeperDescribeResponse, DatabaseError> {
642 0 : let locked = self.inner.read().unwrap();
643 0 : let sk = locked
644 0 : .safekeepers
645 0 : .get(&NodeId(id as u64))
646 0 : .ok_or(diesel::result::Error::NotFound)?;
647 0 : sk.describe_response()
648 0 : }
649 :
650 0 : pub(crate) async fn upsert_safekeeper(
651 0 : self: &Arc<Service>,
652 0 : record: crate::persistence::SafekeeperUpsert,
653 0 : ) -> Result<(), ApiError> {
654 0 : let node_id = NodeId(record.id as u64);
655 0 : let use_https = self.config.use_https_safekeeper_api;
656 0 :
657 0 : if use_https && record.https_port.is_none() {
658 0 : return Err(ApiError::PreconditionFailed(
659 0 : format!(
660 0 : "cannot upsert safekeeper {node_id}: \
661 0 : https is enabled, but https port is not specified"
662 0 : )
663 0 : .into(),
664 0 : ));
665 0 : }
666 0 :
667 0 : self.persistence.safekeeper_upsert(record.clone()).await?;
668 : {
669 0 : let mut locked = self.inner.write().unwrap();
670 0 : let mut safekeepers = (*locked.safekeepers).clone();
671 0 : match safekeepers.entry(node_id) {
672 0 : std::collections::hash_map::Entry::Occupied(mut entry) => entry
673 0 : .get_mut()
674 0 : .update_from_record(record)
675 0 : .expect("all preconditions should be checked before upsert to database"),
676 0 : std::collections::hash_map::Entry::Vacant(entry) => {
677 0 : entry.insert(
678 0 : Safekeeper::from_persistence(
679 0 : crate::persistence::SafekeeperPersistence::from_upsert(
680 0 : record,
681 0 : SkSchedulingPolicy::Pause,
682 0 : ),
683 0 : CancellationToken::new(),
684 0 : use_https,
685 0 : )
686 0 : .expect("all preconditions should be checked before upsert to database"),
687 0 : );
688 0 : }
689 : }
690 0 : locked
691 0 : .safekeeper_reconcilers
692 0 : .start_reconciler(node_id, self);
693 0 : locked.safekeepers = Arc::new(safekeepers);
694 0 : metrics::METRICS_REGISTRY
695 0 : .metrics_group
696 0 : .storage_controller_safekeeper_nodes
697 0 : .set(locked.safekeepers.len() as i64);
698 0 : metrics::METRICS_REGISTRY
699 0 : .metrics_group
700 0 : .storage_controller_https_safekeeper_nodes
701 0 : .set(
702 0 : locked
703 0 : .safekeepers
704 0 : .values()
705 0 : .filter(|s| s.has_https_port())
706 0 : .count() as i64,
707 0 : );
708 0 : }
709 0 : Ok(())
710 0 : }
711 :
712 0 : pub(crate) async fn set_safekeeper_scheduling_policy(
713 0 : self: &Arc<Service>,
714 0 : id: i64,
715 0 : scheduling_policy: SkSchedulingPolicy,
716 0 : ) -> Result<(), DatabaseError> {
717 0 : self.persistence
718 0 : .set_safekeeper_scheduling_policy(id, scheduling_policy)
719 0 : .await?;
720 0 : let node_id = NodeId(id as u64);
721 0 : // After the change has been persisted successfully, update the in-memory state
722 0 : {
723 0 : let mut locked = self.inner.write().unwrap();
724 0 : let mut safekeepers = (*locked.safekeepers).clone();
725 0 : let sk = safekeepers
726 0 : .get_mut(&node_id)
727 0 : .ok_or(DatabaseError::Logical("Not found".to_string()))?;
728 0 : sk.set_scheduling_policy(scheduling_policy);
729 0 :
730 0 : match scheduling_policy {
731 0 : SkSchedulingPolicy::Active => {
732 0 : locked
733 0 : .safekeeper_reconcilers
734 0 : .start_reconciler(node_id, self);
735 0 : }
736 0 : SkSchedulingPolicy::Decomissioned | SkSchedulingPolicy::Pause => {
737 0 : locked.safekeeper_reconcilers.stop_reconciler(node_id);
738 0 : }
739 : }
740 :
741 0 : locked.safekeepers = Arc::new(safekeepers);
742 0 : }
743 0 : Ok(())
744 0 : }
745 : }
|
