Line data Source code
1 : use std::collections::BTreeMap;
2 : use std::ops::Range;
3 :
4 : use tracing::info;
5 :
6 : use super::layer_coverage::LayerCoverageTuple;
7 : use crate::tenant::storage_layer::PersistentLayerDesc;
8 :
9 : /// Layers in this module are identified and indexed by this data.
10 : ///
11 : /// This is a helper struct to enable sorting layers by lsn.start.
12 : ///
13 : /// These three values are enough to uniquely identify a layer, since
14 : /// a layer is obligated to contain all contents within range, so two
15 : /// deltas (or images) with the same range have identical content.
16 : #[derive(Debug, PartialEq, Eq, Clone)]
17 : pub struct LayerKey {
18 : // TODO I use i128 and u64 because it was easy for prototyping,
19 : // testing, and benchmarking. If we can use the Lsn and Key
20 : // types without overhead that would be preferable.
21 : pub key: Range<i128>,
22 : pub lsn: Range<u64>,
23 : pub is_image: bool,
24 : }
25 :
26 : impl PartialOrd for LayerKey {
27 0 : fn partial_cmp(&self, other: &Self) -> Option<std::cmp::Ordering> {
28 0 : Some(self.cmp(other))
29 0 : }
30 : }
31 :
32 : impl Ord for LayerKey {
33 74596 : fn cmp(&self, other: &Self) -> std::cmp::Ordering {
34 : // NOTE we really care about comparing by lsn.start first
35 74596 : self.lsn
36 74596 : .start
37 74596 : .cmp(&other.lsn.start)
38 74596 : .then(self.lsn.end.cmp(&other.lsn.end))
39 74596 : .then(self.key.start.cmp(&other.key.start))
40 74596 : .then(self.key.end.cmp(&other.key.end))
41 74596 : .then(self.is_image.cmp(&other.is_image))
42 74596 : }
43 : }
44 :
45 : impl From<&PersistentLayerDesc> for LayerKey {
46 2754 : fn from(layer: &PersistentLayerDesc) -> Self {
47 2754 : let kr = layer.get_key_range();
48 2754 : let lr = layer.get_lsn_range();
49 2754 : LayerKey {
50 2754 : key: kr.start.to_i128()..kr.end.to_i128(),
51 2754 : lsn: lr.start.0..lr.end.0,
52 2754 : is_image: !layer.is_incremental(),
53 2754 : }
54 2754 : }
55 : }
56 :
57 : /// Efficiently queryable layer coverage for each LSN.
58 : ///
59 : /// Allows answering layer map queries very efficiently,
60 : /// but doesn't allow retroactive insertion, which is
61 : /// sometimes necessary. See BufferedHistoricLayerCoverage.
62 : pub struct HistoricLayerCoverage<Value> {
63 : /// The latest state
64 : head: LayerCoverageTuple<Value>,
65 :
66 : /// TODO: this could be an ordered vec using binary search.
67 : /// We push into this map everytime we add a layer, so might see some benefit
68 : /// All previous states
69 : historic: BTreeMap<u64, LayerCoverageTuple<Value>>,
70 : }
71 :
72 : impl<T: Clone> Default for HistoricLayerCoverage<T> {
73 0 : fn default() -> Self {
74 0 : Self::new()
75 0 : }
76 : }
77 :
78 : impl<Value: Clone> HistoricLayerCoverage<Value> {
79 247 : pub fn new() -> Self {
80 247 : Self {
81 247 : head: LayerCoverageTuple::default(),
82 247 : historic: BTreeMap::default(),
83 247 : }
84 247 : }
85 :
86 : /// Add a layer
87 : ///
88 : /// Panics if new layer has older lsn.start than an existing layer.
89 : /// See BufferedHistoricLayerCoverage for a more general insertion method.
90 2684 : pub fn insert(&mut self, layer_key: LayerKey, value: Value) {
91 : // It's only a persistent map, not a retroactive one
92 2684 : if let Some(last_entry) = self.historic.iter().next_back() {
93 2453 : let last_lsn = last_entry.0;
94 2453 : if layer_key.lsn.start < *last_lsn {
95 0 : panic!("unexpected retroactive insert");
96 2453 : }
97 231 : }
98 :
99 : // Insert into data structure
100 2684 : let target = if layer_key.is_image {
101 1075 : &mut self.head.image_coverage
102 : } else {
103 1609 : &mut self.head.delta_coverage
104 : };
105 :
106 2684 : target.insert(layer_key.key, layer_key.lsn.clone(), value);
107 :
108 : // Remember history. Clone is O(1)
109 2684 : self.historic.insert(layer_key.lsn.start, self.head.clone());
110 2684 : }
111 :
112 : /// Query at a particular LSN, inclusive
113 657923 : pub fn get_version(&self, lsn: u64) -> Option<&LayerCoverageTuple<Value>> {
114 657923 : match self.historic.range(..=lsn).next_back() {
115 489649 : Some((_, v)) => Some(v),
116 168274 : None => None,
117 : }
118 657923 : }
119 :
120 : /// Remove all entries after a certain LSN (inclusive)
121 753 : pub fn trim(&mut self, begin: &u64) {
122 753 : self.historic.split_off(begin);
123 753 : self.head = self
124 753 : .historic
125 753 : .iter()
126 753 : .next_back()
127 753 : .map(|(_, v)| v.clone())
128 753 : .unwrap_or_default();
129 753 : }
130 : }
131 :
132 : /// This is the most basic test that demonstrates intended usage.
133 : /// All layers in this test have height 1.
134 : #[test]
135 1 : fn test_persistent_simple() {
136 1 : let mut map = HistoricLayerCoverage::<String>::new();
137 1 : map.insert(
138 1 : LayerKey {
139 1 : key: 0..5,
140 1 : lsn: 100..101,
141 1 : is_image: true,
142 1 : },
143 1 : "Layer 1".to_string(),
144 : );
145 1 : map.insert(
146 1 : LayerKey {
147 1 : key: 3..9,
148 1 : lsn: 110..111,
149 1 : is_image: true,
150 1 : },
151 1 : "Layer 2".to_string(),
152 : );
153 1 : map.insert(
154 1 : LayerKey {
155 1 : key: 5..6,
156 1 : lsn: 120..121,
157 1 : is_image: true,
158 1 : },
159 1 : "Layer 3".to_string(),
160 : );
161 :
162 : // After Layer 1 insertion
163 1 : let version = map.get_version(105).unwrap();
164 1 : assert_eq!(version.image_coverage.query(1), Some("Layer 1".to_string()));
165 1 : assert_eq!(version.image_coverage.query(4), Some("Layer 1".to_string()));
166 :
167 : // After Layer 2 insertion
168 1 : let version = map.get_version(115).unwrap();
169 1 : assert_eq!(version.image_coverage.query(4), Some("Layer 2".to_string()));
170 1 : assert_eq!(version.image_coverage.query(8), Some("Layer 2".to_string()));
171 1 : assert_eq!(version.image_coverage.query(11), None);
172 :
173 : // After Layer 3 insertion
174 1 : let version = map.get_version(125).unwrap();
175 1 : assert_eq!(version.image_coverage.query(4), Some("Layer 2".to_string()));
176 1 : assert_eq!(version.image_coverage.query(5), Some("Layer 3".to_string()));
177 1 : assert_eq!(version.image_coverage.query(7), Some("Layer 2".to_string()));
178 1 : }
179 :
180 : /// Cover simple off-by-one edge cases
181 : #[test]
182 1 : fn test_off_by_one() {
183 1 : let mut map = HistoricLayerCoverage::<String>::new();
184 1 : map.insert(
185 1 : LayerKey {
186 1 : key: 3..5,
187 1 : lsn: 100..110,
188 1 : is_image: true,
189 1 : },
190 1 : "Layer 1".to_string(),
191 : );
192 :
193 : // Check different LSNs
194 1 : let version = map.get_version(99);
195 1 : assert!(version.is_none());
196 1 : let version = map.get_version(100).unwrap();
197 1 : assert_eq!(version.image_coverage.query(4), Some("Layer 1".to_string()));
198 1 : let version = map.get_version(110).unwrap();
199 1 : assert_eq!(version.image_coverage.query(4), Some("Layer 1".to_string()));
200 :
201 : // Check different keys
202 1 : let version = map.get_version(105).unwrap();
203 1 : assert_eq!(version.image_coverage.query(2), None);
204 1 : assert_eq!(version.image_coverage.query(3), Some("Layer 1".to_string()));
205 1 : assert_eq!(version.image_coverage.query(4), Some("Layer 1".to_string()));
206 1 : assert_eq!(version.image_coverage.query(5), None);
207 1 : }
208 :
209 : /// White-box regression test, checking for incorrect removal of node at key.end
210 : #[test]
211 1 : fn test_regression() {
212 1 : let mut map = HistoricLayerCoverage::<String>::new();
213 1 : map.insert(
214 1 : LayerKey {
215 1 : key: 0..5,
216 1 : lsn: 0..5,
217 1 : is_image: false,
218 1 : },
219 1 : "Layer 1".to_string(),
220 : );
221 1 : map.insert(
222 1 : LayerKey {
223 1 : key: 0..5,
224 1 : lsn: 1..2,
225 1 : is_image: false,
226 1 : },
227 1 : "Layer 2".to_string(),
228 : );
229 :
230 : // If an insertion operation improperly deletes the endpoint of a previous layer
231 : // (which is more likely to happen with layers that collide on key.end), we will
232 : // end up with an infinite layer, covering the entire keyspace. Here we assert
233 : // that there's no layer at key 100 because we didn't insert any layer there.
234 1 : let version = map.get_version(100).unwrap();
235 1 : assert_eq!(version.delta_coverage.query(100), None);
236 1 : }
237 :
238 : /// Cover edge cases where layers begin or end on the same key
239 : #[test]
240 1 : fn test_key_collision() {
241 1 : let mut map = HistoricLayerCoverage::<String>::new();
242 :
243 1 : map.insert(
244 1 : LayerKey {
245 1 : key: 3..5,
246 1 : lsn: 100..110,
247 1 : is_image: true,
248 1 : },
249 1 : "Layer 10".to_string(),
250 : );
251 1 : map.insert(
252 1 : LayerKey {
253 1 : key: 5..8,
254 1 : lsn: 100..110,
255 1 : is_image: true,
256 1 : },
257 1 : "Layer 11".to_string(),
258 : );
259 1 : map.insert(
260 1 : LayerKey {
261 1 : key: 3..4,
262 1 : lsn: 200..210,
263 1 : is_image: true,
264 1 : },
265 1 : "Layer 20".to_string(),
266 : );
267 :
268 : // Check after layer 11
269 1 : let version = map.get_version(105).unwrap();
270 1 : assert_eq!(version.image_coverage.query(2), None);
271 1 : assert_eq!(
272 1 : version.image_coverage.query(3),
273 1 : Some("Layer 10".to_string())
274 : );
275 1 : assert_eq!(
276 1 : version.image_coverage.query(5),
277 1 : Some("Layer 11".to_string())
278 : );
279 1 : assert_eq!(
280 1 : version.image_coverage.query(7),
281 1 : Some("Layer 11".to_string())
282 : );
283 1 : assert_eq!(version.image_coverage.query(8), None);
284 :
285 : // Check after layer 20
286 1 : let version = map.get_version(205).unwrap();
287 1 : assert_eq!(version.image_coverage.query(2), None);
288 1 : assert_eq!(
289 1 : version.image_coverage.query(3),
290 1 : Some("Layer 20".to_string())
291 : );
292 1 : assert_eq!(
293 1 : version.image_coverage.query(5),
294 1 : Some("Layer 11".to_string())
295 : );
296 1 : assert_eq!(
297 1 : version.image_coverage.query(7),
298 1 : Some("Layer 11".to_string())
299 : );
300 1 : assert_eq!(version.image_coverage.query(8), None);
301 1 : }
302 :
303 : /// Test when rectangles have nontrivial height and possibly overlap
304 : #[test]
305 1 : fn test_persistent_overlapping() {
306 1 : let mut map = HistoricLayerCoverage::<String>::new();
307 :
308 : // Add 3 key-disjoint layers with varying LSN ranges
309 1 : map.insert(
310 1 : LayerKey {
311 1 : key: 1..2,
312 1 : lsn: 100..200,
313 1 : is_image: true,
314 1 : },
315 1 : "Layer 1".to_string(),
316 : );
317 1 : map.insert(
318 1 : LayerKey {
319 1 : key: 4..5,
320 1 : lsn: 110..200,
321 1 : is_image: true,
322 1 : },
323 1 : "Layer 2".to_string(),
324 : );
325 1 : map.insert(
326 1 : LayerKey {
327 1 : key: 7..8,
328 1 : lsn: 120..300,
329 1 : is_image: true,
330 1 : },
331 1 : "Layer 3".to_string(),
332 : );
333 :
334 : // Add wide and short layer
335 1 : map.insert(
336 1 : LayerKey {
337 1 : key: 0..9,
338 1 : lsn: 130..199,
339 1 : is_image: true,
340 1 : },
341 1 : "Layer 4".to_string(),
342 : );
343 :
344 : // Add wide layer taller than some
345 1 : map.insert(
346 1 : LayerKey {
347 1 : key: 0..9,
348 1 : lsn: 140..201,
349 1 : is_image: true,
350 1 : },
351 1 : "Layer 5".to_string(),
352 : );
353 :
354 : // Add wide layer taller than all
355 1 : map.insert(
356 1 : LayerKey {
357 1 : key: 0..9,
358 1 : lsn: 150..301,
359 1 : is_image: true,
360 1 : },
361 1 : "Layer 6".to_string(),
362 : );
363 :
364 : // After layer 4 insertion
365 1 : let version = map.get_version(135).unwrap();
366 1 : assert_eq!(version.image_coverage.query(0), Some("Layer 4".to_string()));
367 1 : assert_eq!(version.image_coverage.query(1), Some("Layer 1".to_string()));
368 1 : assert_eq!(version.image_coverage.query(2), Some("Layer 4".to_string()));
369 1 : assert_eq!(version.image_coverage.query(4), Some("Layer 2".to_string()));
370 1 : assert_eq!(version.image_coverage.query(5), Some("Layer 4".to_string()));
371 1 : assert_eq!(version.image_coverage.query(7), Some("Layer 3".to_string()));
372 1 : assert_eq!(version.image_coverage.query(8), Some("Layer 4".to_string()));
373 :
374 : // After layer 5 insertion
375 1 : let version = map.get_version(145).unwrap();
376 1 : assert_eq!(version.image_coverage.query(0), Some("Layer 5".to_string()));
377 1 : assert_eq!(version.image_coverage.query(1), Some("Layer 5".to_string()));
378 1 : assert_eq!(version.image_coverage.query(2), Some("Layer 5".to_string()));
379 1 : assert_eq!(version.image_coverage.query(4), Some("Layer 5".to_string()));
380 1 : assert_eq!(version.image_coverage.query(5), Some("Layer 5".to_string()));
381 1 : assert_eq!(version.image_coverage.query(7), Some("Layer 3".to_string()));
382 1 : assert_eq!(version.image_coverage.query(8), Some("Layer 5".to_string()));
383 :
384 : // After layer 6 insertion
385 1 : let version = map.get_version(155).unwrap();
386 1 : assert_eq!(version.image_coverage.query(0), Some("Layer 6".to_string()));
387 1 : assert_eq!(version.image_coverage.query(1), Some("Layer 6".to_string()));
388 1 : assert_eq!(version.image_coverage.query(2), Some("Layer 6".to_string()));
389 1 : assert_eq!(version.image_coverage.query(4), Some("Layer 6".to_string()));
390 1 : assert_eq!(version.image_coverage.query(5), Some("Layer 6".to_string()));
391 1 : assert_eq!(version.image_coverage.query(7), Some("Layer 6".to_string()));
392 1 : assert_eq!(version.image_coverage.query(8), Some("Layer 6".to_string()));
393 1 : }
394 :
395 : /// Wrapper for HistoricLayerCoverage that allows us to hack around the lack
396 : /// of support for retroactive insertion by rebuilding the map since the
397 : /// change.
398 : ///
399 : /// Why is this needed? We most often insert new layers with newer LSNs,
400 : /// but during compaction we create layers with non-latest LSN, and during
401 : /// GC we delete historic layers.
402 : ///
403 : /// Even though rebuilding is an expensive (N log N) solution to the problem,
404 : /// it's not critical since we do something equally expensive just to decide
405 : /// whether or not to create new image layers.
406 : /// TODO It's not expensive but it's not great to hold a layer map write lock
407 : /// for that long.
408 : ///
409 : /// If this becomes an actual bottleneck, one solution would be to build a
410 : /// segment tree that holds PersistentLayerMaps. Though this would mean that
411 : /// we take an additional log(N) performance hit for queries, which will probably
412 : /// still be more critical.
413 : ///
414 : /// See this for more on persistent and retroactive techniques:
415 : /// <https://www.youtube.com/watch?v=WqCWghETNDc&t=581s>
416 : pub struct BufferedHistoricLayerCoverage<Value> {
417 : /// A persistent layer map that we rebuild when we need to retroactively update
418 : historic_coverage: HistoricLayerCoverage<Value>,
419 :
420 : /// We buffer insertion into the PersistentLayerMap to decrease the number of rebuilds.
421 : buffer: BTreeMap<LayerKey, Option<Value>>,
422 :
423 : /// All current layers. This is not used for search. Only to make rebuilds easier.
424 : // TODO: This map is never cleared. Rebuilds could use the post-trim last entry of
425 : // [`Self::historic_coverage`] instead of doubling memory usage.
426 : // [`Self::len`]: can require rebuild and serve from latest historic
427 : // [`Self::iter`]: already requires rebuild => can serve from latest historic
428 : layers: BTreeMap<LayerKey, Value>,
429 : }
430 :
431 : impl<T: std::fmt::Debug> std::fmt::Debug for BufferedHistoricLayerCoverage<T> {
432 0 : fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
433 0 : f.debug_struct("RetroactiveLayerMap")
434 0 : .field("buffer", &self.buffer)
435 0 : .field("layers", &self.layers)
436 0 : .finish()
437 0 : }
438 : }
439 :
440 : impl<T: Clone> Default for BufferedHistoricLayerCoverage<T> {
441 240 : fn default() -> Self {
442 240 : Self::new()
443 240 : }
444 : }
445 :
446 : impl<Value: Clone> BufferedHistoricLayerCoverage<Value> {
447 242 : pub fn new() -> Self {
448 242 : Self {
449 242 : historic_coverage: HistoricLayerCoverage::<Value>::new(),
450 242 : buffer: BTreeMap::new(),
451 242 : layers: BTreeMap::new(),
452 242 : }
453 242 : }
454 :
455 2499 : pub fn insert(&mut self, layer_key: LayerKey, value: Value) {
456 2499 : self.buffer.insert(layer_key, Some(value));
457 2499 : }
458 :
459 262 : pub fn remove(&mut self, layer_key: LayerKey) {
460 262 : self.buffer.insert(layer_key, None);
461 262 : }
462 :
463 831 : pub fn rebuild(&mut self) {
464 : // Find the first LSN that needs to be rebuilt
465 831 : let rebuild_since: u64 = match self.buffer.iter().next() {
466 753 : Some((LayerKey { lsn, .. }, _)) => lsn.start,
467 78 : None => return, // No need to rebuild if buffer is empty
468 : };
469 :
470 : // Apply buffered updates to self.layers
471 753 : let num_updates = self.buffer.len();
472 2761 : self.buffer.retain(|layer_key, layer| {
473 2761 : match layer {
474 2499 : Some(l) => {
475 2499 : self.layers.insert(layer_key.clone(), l.clone());
476 2499 : }
477 262 : None => {
478 262 : self.layers.remove(layer_key);
479 262 : }
480 : };
481 2761 : false
482 2761 : });
483 :
484 : // Rebuild
485 753 : let mut num_inserted = 0;
486 753 : self.historic_coverage.trim(&rebuild_since);
487 2669 : for (layer_key, layer) in self.layers.range(
488 753 : LayerKey {
489 753 : lsn: rebuild_since..0,
490 753 : key: 0..0,
491 753 : is_image: false,
492 753 : }..,
493 2669 : ) {
494 2669 : self.historic_coverage
495 2669 : .insert(layer_key.clone(), layer.clone());
496 2669 : num_inserted += 1;
497 2669 : }
498 :
499 : // TODO maybe only warn if ratio is at least 10
500 753 : info!(
501 0 : "Rebuilt layer map. Did {} insertions to process a batch of {} updates.",
502 : num_inserted, num_updates,
503 : )
504 831 : }
505 :
506 : /// Iterate all the layers
507 2220 : pub fn iter(&self) -> impl ExactSizeIterator<Item = Value> {
508 : // NOTE we can actually perform this without rebuilding,
509 : // but it's not necessary for now.
510 2220 : if !self.buffer.is_empty() {
511 0 : panic!("rebuild pls")
512 2220 : }
513 :
514 2220 : self.layers.values().cloned()
515 2220 : }
516 :
517 : /// Return a reference to a queryable map, assuming all updates
518 : /// have already been processed using self.rebuild()
519 657906 : pub fn get(&self) -> anyhow::Result<&HistoricLayerCoverage<Value>> {
520 : // NOTE we error here instead of implicitly rebuilding because
521 : // rebuilding is somewhat expensive.
522 : // TODO maybe implicitly rebuild and log/sentry an error?
523 657906 : if !self.buffer.is_empty() {
524 0 : anyhow::bail!("rebuild required")
525 657906 : }
526 :
527 657906 : Ok(&self.historic_coverage)
528 657906 : }
529 :
530 250 : pub(crate) fn len(&self) -> usize {
531 250 : self.layers.len()
532 250 : }
533 : }
534 :
535 : #[test]
536 1 : fn test_retroactive_regression_1() {
537 1 : let mut map = BufferedHistoricLayerCoverage::new();
538 :
539 1 : map.insert(
540 1 : LayerKey {
541 1 : key: 0..21267647932558653966460912964485513215,
542 1 : lsn: 23761336..23761457,
543 1 : is_image: false,
544 1 : },
545 1 : "sdfsdfs".to_string(),
546 : );
547 :
548 1 : map.rebuild();
549 :
550 1 : let version = map.get().unwrap().get_version(23761457).unwrap();
551 1 : assert_eq!(
552 1 : version.delta_coverage.query(100),
553 1 : Some("sdfsdfs".to_string())
554 : );
555 1 : }
556 :
557 : #[test]
558 1 : fn test_retroactive_simple() {
559 1 : let mut map = BufferedHistoricLayerCoverage::new();
560 :
561 : // Append some images in increasing LSN order
562 1 : map.insert(
563 1 : LayerKey {
564 1 : key: 0..5,
565 1 : lsn: 100..101,
566 1 : is_image: true,
567 1 : },
568 1 : "Image 1".to_string(),
569 : );
570 1 : map.insert(
571 1 : LayerKey {
572 1 : key: 3..9,
573 1 : lsn: 110..111,
574 1 : is_image: true,
575 1 : },
576 1 : "Image 2".to_string(),
577 : );
578 1 : map.insert(
579 1 : LayerKey {
580 1 : key: 4..6,
581 1 : lsn: 120..121,
582 1 : is_image: true,
583 1 : },
584 1 : "Image 3".to_string(),
585 : );
586 1 : map.insert(
587 1 : LayerKey {
588 1 : key: 8..9,
589 1 : lsn: 120..121,
590 1 : is_image: true,
591 1 : },
592 1 : "Image 4".to_string(),
593 : );
594 :
595 : // Add a delta layer out of order
596 1 : map.insert(
597 1 : LayerKey {
598 1 : key: 2..5,
599 1 : lsn: 105..106,
600 1 : is_image: false,
601 1 : },
602 1 : "Delta 1".to_string(),
603 : );
604 :
605 : // Rebuild so we can start querying
606 1 : map.rebuild();
607 :
608 : {
609 1 : let map = map.get().expect("rebuilt");
610 :
611 1 : let version = map.get_version(90);
612 1 : assert!(version.is_none());
613 1 : let version = map.get_version(102).unwrap();
614 1 : assert_eq!(version.image_coverage.query(4), Some("Image 1".to_string()));
615 :
616 1 : let version = map.get_version(107).unwrap();
617 1 : assert_eq!(version.image_coverage.query(4), Some("Image 1".to_string()));
618 1 : assert_eq!(version.delta_coverage.query(4), Some("Delta 1".to_string()));
619 :
620 1 : let version = map.get_version(115).unwrap();
621 1 : assert_eq!(version.image_coverage.query(4), Some("Image 2".to_string()));
622 :
623 1 : let version = map.get_version(125).unwrap();
624 1 : assert_eq!(version.image_coverage.query(4), Some("Image 3".to_string()));
625 : }
626 :
627 : // Remove Image 3
628 1 : map.remove(LayerKey {
629 1 : key: 4..6,
630 1 : lsn: 120..121,
631 1 : is_image: true,
632 1 : });
633 1 : map.rebuild();
634 :
635 : {
636 : // Check deletion worked
637 1 : let map = map.get().expect("rebuilt");
638 1 : let version = map.get_version(125).unwrap();
639 1 : assert_eq!(version.image_coverage.query(4), Some("Image 2".to_string()));
640 1 : assert_eq!(version.image_coverage.query(8), Some("Image 4".to_string()));
641 : }
642 1 : }
|
