Line data Source code
1 : pub mod chaos_injector;
2 : mod context_iterator;
3 :
4 : use hyper::Uri;
5 : use safekeeper_api::models::SafekeeperUtilization;
6 : use std::{
7 : borrow::Cow,
8 : cmp::Ordering,
9 : collections::{BTreeMap, HashMap, HashSet},
10 : error::Error,
11 : ops::Deref,
12 : path::PathBuf,
13 : str::FromStr,
14 : sync::Arc,
15 : time::{Duration, Instant},
16 : };
17 :
18 : use crate::{
19 : background_node_operations::{
20 : Drain, Fill, Operation, OperationError, OperationHandler, MAX_RECONCILES_PER_OPERATION,
21 : },
22 : compute_hook::{self, NotifyError},
23 : drain_utils::{self, TenantShardDrain, TenantShardIterator},
24 : heartbeater::SafekeeperState,
25 : id_lock_map::{trace_exclusive_lock, trace_shared_lock, IdLockMap, TracingExclusiveGuard},
26 : leadership::Leadership,
27 : metrics,
28 : peer_client::GlobalObservedState,
29 : persistence::{
30 : AbortShardSplitStatus, ControllerPersistence, DatabaseResult, MetadataHealthPersistence,
31 : ShardGenerationState, TenantFilter,
32 : },
33 : reconciler::{
34 : ReconcileError, ReconcileUnits, ReconcilerConfig, ReconcilerConfigBuilder,
35 : ReconcilerPriority,
36 : },
37 : safekeeper::Safekeeper,
38 : scheduler::{MaySchedule, ScheduleContext, ScheduleError, ScheduleMode},
39 : tenant_shard::{
40 : MigrateAttachment, ObservedStateDelta, ReconcileNeeded, ReconcilerStatus,
41 : ScheduleOptimization, ScheduleOptimizationAction,
42 : },
43 : };
44 : use anyhow::Context;
45 : use control_plane::storage_controller::{
46 : AttachHookRequest, AttachHookResponse, InspectRequest, InspectResponse,
47 : };
48 : use diesel::result::DatabaseErrorKind;
49 : use futures::{stream::FuturesUnordered, StreamExt};
50 : use itertools::Itertools;
51 : use pageserver_api::{
52 : controller_api::{
53 : AvailabilityZone, MetadataHealthRecord, MetadataHealthUpdateRequest, NodeAvailability,
54 : NodeRegisterRequest, NodeSchedulingPolicy, NodeShard, NodeShardResponse, PlacementPolicy,
55 : SafekeeperDescribeResponse, ShardSchedulingPolicy, ShardsPreferredAzsRequest,
56 : ShardsPreferredAzsResponse, SkSchedulingPolicy, TenantCreateRequest, TenantCreateResponse,
57 : TenantCreateResponseShard, TenantDescribeResponse, TenantDescribeResponseShard,
58 : TenantLocateResponse, TenantPolicyRequest, TenantShardMigrateRequest,
59 : TenantShardMigrateResponse,
60 : },
61 : models::{
62 : SecondaryProgress, TenantConfigPatchRequest, TenantConfigRequest,
63 : TimelineArchivalConfigRequest, TopTenantShardsRequest,
64 : },
65 : };
66 : use reqwest::StatusCode;
67 : use tracing::{instrument, Instrument};
68 :
69 : use crate::pageserver_client::PageserverClient;
70 : use http_utils::error::ApiError;
71 : use pageserver_api::{
72 : models::{
73 : self, LocationConfig, LocationConfigListResponse, LocationConfigMode,
74 : PageserverUtilization, ShardParameters, TenantConfig, TenantLocationConfigRequest,
75 : TenantLocationConfigResponse, TenantShardLocation, TenantShardSplitRequest,
76 : TenantShardSplitResponse, TenantTimeTravelRequest, TimelineCreateRequest, TimelineInfo,
77 : },
78 : shard::{ShardCount, ShardIdentity, ShardNumber, ShardStripeSize, TenantShardId},
79 : upcall_api::{
80 : ReAttachRequest, ReAttachResponse, ReAttachResponseTenant, ValidateRequest,
81 : ValidateResponse, ValidateResponseTenant,
82 : },
83 : };
84 : use pageserver_client::{mgmt_api, BlockUnblock};
85 : use tokio::sync::{mpsc::error::TrySendError, TryAcquireError};
86 : use tokio_util::sync::CancellationToken;
87 : use utils::{
88 : completion::Barrier,
89 : failpoint_support,
90 : generation::Generation,
91 : id::{NodeId, TenantId, TimelineId},
92 : pausable_failpoint,
93 : sync::gate::Gate,
94 : };
95 :
96 : use crate::{
97 : compute_hook::ComputeHook,
98 : heartbeater::{Heartbeater, PageserverState},
99 : node::{AvailabilityTransition, Node},
100 : persistence::{split_state::SplitState, DatabaseError, Persistence, TenantShardPersistence},
101 : reconciler::attached_location_conf,
102 : scheduler::Scheduler,
103 : tenant_shard::{
104 : IntentState, ObservedState, ObservedStateLocation, ReconcileResult, ReconcileWaitError,
105 : ReconcilerWaiter, TenantShard,
106 : },
107 : };
108 :
109 : use context_iterator::TenantShardContextIterator;
110 :
111 : const WAITER_FILL_DRAIN_POLL_TIMEOUT: Duration = Duration::from_millis(500);
112 :
113 : // For operations that should be quick, like attaching a new tenant
114 : const SHORT_RECONCILE_TIMEOUT: Duration = Duration::from_secs(5);
115 :
116 : // For operations that might be slow, like migrating a tenant with
117 : // some data in it.
118 : pub const RECONCILE_TIMEOUT: Duration = Duration::from_secs(30);
119 :
120 : // If we receive a call using Secondary mode initially, it will omit generation. We will initialize
121 : // tenant shards into this generation, and as long as it remains in this generation, we will accept
122 : // input generation from future requests as authoritative.
123 : const INITIAL_GENERATION: Generation = Generation::new(0);
124 :
125 : /// How long [`Service::startup_reconcile`] is allowed to take before it should give
126 : /// up on unresponsive pageservers and proceed.
127 : pub(crate) const STARTUP_RECONCILE_TIMEOUT: Duration = Duration::from_secs(30);
128 :
129 : /// How long a node may be unresponsive to heartbeats before we declare it offline.
130 : /// This must be long enough to cover node restarts as well as normal operations: in future
131 : pub const MAX_OFFLINE_INTERVAL_DEFAULT: Duration = Duration::from_secs(30);
132 :
133 : /// How long a node may be unresponsive to heartbeats during start up before we declare it
134 : /// offline.
135 : ///
136 : /// This is much more lenient than [`MAX_OFFLINE_INTERVAL_DEFAULT`] since the pageserver's
137 : /// handling of the re-attach response may take a long time and blocks heartbeats from
138 : /// being handled on the pageserver side.
139 : pub const MAX_WARMING_UP_INTERVAL_DEFAULT: Duration = Duration::from_secs(300);
140 :
141 : /// How often to send heartbeats to registered nodes?
142 : pub const HEARTBEAT_INTERVAL_DEFAULT: Duration = Duration::from_secs(5);
143 :
144 : /// How long is too long for a reconciliation?
145 : pub const LONG_RECONCILE_THRESHOLD_DEFAULT: Duration = Duration::from_secs(120);
146 :
147 : #[derive(Clone, strum_macros::Display)]
148 : enum TenantOperations {
149 : Create,
150 : LocationConfig,
151 : ConfigSet,
152 : ConfigPatch,
153 : TimeTravelRemoteStorage,
154 : Delete,
155 : UpdatePolicy,
156 : ShardSplit,
157 : SecondaryDownload,
158 : TimelineCreate,
159 : TimelineDelete,
160 : AttachHook,
161 : TimelineArchivalConfig,
162 : TimelineDetachAncestor,
163 : TimelineGcBlockUnblock,
164 : DropDetached,
165 : DownloadHeatmapLayers,
166 : }
167 :
168 : #[derive(Clone, strum_macros::Display)]
169 : enum NodeOperations {
170 : Register,
171 : Configure,
172 : Delete,
173 : }
174 :
175 : /// The leadership status for the storage controller process.
176 : /// Allowed transitions are:
177 : /// 1. Leader -> SteppedDown
178 : /// 2. Candidate -> Leader
179 : #[derive(
180 : Eq,
181 : PartialEq,
182 : Copy,
183 : Clone,
184 : strum_macros::Display,
185 0 : strum_macros::EnumIter,
186 : measured::FixedCardinalityLabel,
187 : )]
188 : #[strum(serialize_all = "snake_case")]
189 : pub(crate) enum LeadershipStatus {
190 : /// This is the steady state where the storage controller can produce
191 : /// side effects in the cluster.
192 : Leader,
193 : /// We've been notified to step down by another candidate. No reconciliations
194 : /// take place in this state.
195 : SteppedDown,
196 : /// Initial state for a new storage controller instance. Will attempt to assume leadership.
197 : #[allow(unused)]
198 : Candidate,
199 : }
200 :
201 : pub const RECONCILER_CONCURRENCY_DEFAULT: usize = 128;
202 : pub const PRIORITY_RECONCILER_CONCURRENCY_DEFAULT: usize = 256;
203 :
204 : // Depth of the channel used to enqueue shards for reconciliation when they can't do it immediately.
205 : // This channel is finite-size to avoid using excessive memory if we get into a state where reconciles are finishing more slowly
206 : // than they're being pushed onto the queue.
207 : const MAX_DELAYED_RECONCILES: usize = 10000;
208 :
209 : // Top level state available to all HTTP handlers
210 : struct ServiceState {
211 : leadership_status: LeadershipStatus,
212 :
213 : tenants: BTreeMap<TenantShardId, TenantShard>,
214 :
215 : nodes: Arc<HashMap<NodeId, Node>>,
216 :
217 : safekeepers: Arc<HashMap<NodeId, Safekeeper>>,
218 :
219 : scheduler: Scheduler,
220 :
221 : /// Ongoing background operation on the cluster if any is running.
222 : /// Note that only one such operation may run at any given time,
223 : /// hence the type choice.
224 : ongoing_operation: Option<OperationHandler>,
225 :
226 : /// Queue of tenants who are waiting for concurrency limits to permit them to reconcile
227 : delayed_reconcile_rx: tokio::sync::mpsc::Receiver<TenantShardId>,
228 : }
229 :
230 : /// Transform an error from a pageserver into an error to return to callers of a storage
231 : /// controller API.
232 0 : fn passthrough_api_error(node: &Node, e: mgmt_api::Error) -> ApiError {
233 0 : match e {
234 0 : mgmt_api::Error::SendRequest(e) => {
235 0 : // Presume errors sending requests are connectivity/availability issues
236 0 : ApiError::ResourceUnavailable(format!("{node} error sending request: {e}").into())
237 : }
238 0 : mgmt_api::Error::ReceiveErrorBody(str) => {
239 0 : // Presume errors receiving body are connectivity/availability issues
240 0 : ApiError::ResourceUnavailable(
241 0 : format!("{node} error receiving error body: {str}").into(),
242 0 : )
243 : }
244 0 : mgmt_api::Error::ReceiveBody(err) if err.is_decode() => {
245 0 : // Return 500 for decoding errors.
246 0 : ApiError::InternalServerError(anyhow::Error::from(err).context("error decoding body"))
247 : }
248 0 : mgmt_api::Error::ReceiveBody(err) => {
249 0 : // Presume errors receiving body are connectivity/availability issues except for decoding errors
250 0 : let src_str = err.source().map(|e| e.to_string()).unwrap_or_default();
251 0 : ApiError::ResourceUnavailable(
252 0 : format!("{node} error receiving error body: {err} {}", src_str).into(),
253 0 : )
254 : }
255 0 : mgmt_api::Error::ApiError(StatusCode::NOT_FOUND, msg) => {
256 0 : ApiError::NotFound(anyhow::anyhow!(format!("{node}: {msg}")).into())
257 : }
258 0 : mgmt_api::Error::ApiError(StatusCode::SERVICE_UNAVAILABLE, msg) => {
259 0 : ApiError::ResourceUnavailable(format!("{node}: {msg}").into())
260 : }
261 0 : mgmt_api::Error::ApiError(status @ StatusCode::UNAUTHORIZED, msg)
262 0 : | mgmt_api::Error::ApiError(status @ StatusCode::FORBIDDEN, msg) => {
263 : // Auth errors talking to a pageserver are not auth errors for the caller: they are
264 : // internal server errors, showing that something is wrong with the pageserver or
265 : // storage controller's auth configuration.
266 0 : ApiError::InternalServerError(anyhow::anyhow!("{node} {status}: {msg}"))
267 : }
268 0 : mgmt_api::Error::ApiError(status @ StatusCode::TOO_MANY_REQUESTS, msg) => {
269 0 : // Pass through 429 errors: if pageserver is asking us to wait + retry, we in
270 0 : // turn ask our clients to wait + retry
271 0 : ApiError::Conflict(format!("{node} {status}: {status} {msg}"))
272 : }
273 0 : mgmt_api::Error::ApiError(status, msg) => {
274 0 : // Presume general case of pageserver API errors is that we tried to do something
275 0 : // that can't be done right now.
276 0 : ApiError::Conflict(format!("{node} {status}: {status} {msg}"))
277 : }
278 0 : mgmt_api::Error::Cancelled => ApiError::ShuttingDown,
279 : }
280 0 : }
281 :
282 : impl ServiceState {
283 0 : fn new(
284 0 : nodes: HashMap<NodeId, Node>,
285 0 : safekeepers: HashMap<NodeId, Safekeeper>,
286 0 : tenants: BTreeMap<TenantShardId, TenantShard>,
287 0 : scheduler: Scheduler,
288 0 : delayed_reconcile_rx: tokio::sync::mpsc::Receiver<TenantShardId>,
289 0 : initial_leadership_status: LeadershipStatus,
290 0 : ) -> Self {
291 0 : metrics::update_leadership_status(initial_leadership_status);
292 0 :
293 0 : Self {
294 0 : leadership_status: initial_leadership_status,
295 0 : tenants,
296 0 : nodes: Arc::new(nodes),
297 0 : safekeepers: Arc::new(safekeepers),
298 0 : scheduler,
299 0 : ongoing_operation: None,
300 0 : delayed_reconcile_rx,
301 0 : }
302 0 : }
303 :
304 0 : fn parts_mut(
305 0 : &mut self,
306 0 : ) -> (
307 0 : &mut Arc<HashMap<NodeId, Node>>,
308 0 : &mut BTreeMap<TenantShardId, TenantShard>,
309 0 : &mut Scheduler,
310 0 : ) {
311 0 : (&mut self.nodes, &mut self.tenants, &mut self.scheduler)
312 0 : }
313 :
314 : #[allow(clippy::type_complexity)]
315 0 : fn parts_mut_sk(
316 0 : &mut self,
317 0 : ) -> (
318 0 : &mut Arc<HashMap<NodeId, Node>>,
319 0 : &mut Arc<HashMap<NodeId, Safekeeper>>,
320 0 : &mut BTreeMap<TenantShardId, TenantShard>,
321 0 : &mut Scheduler,
322 0 : ) {
323 0 : (
324 0 : &mut self.nodes,
325 0 : &mut self.safekeepers,
326 0 : &mut self.tenants,
327 0 : &mut self.scheduler,
328 0 : )
329 0 : }
330 :
331 0 : fn get_leadership_status(&self) -> LeadershipStatus {
332 0 : self.leadership_status
333 0 : }
334 :
335 0 : fn step_down(&mut self) {
336 0 : self.leadership_status = LeadershipStatus::SteppedDown;
337 0 : metrics::update_leadership_status(self.leadership_status);
338 0 : }
339 :
340 0 : fn become_leader(&mut self) {
341 0 : self.leadership_status = LeadershipStatus::Leader;
342 0 : metrics::update_leadership_status(self.leadership_status);
343 0 : }
344 : }
345 :
346 : #[derive(Clone)]
347 : pub struct Config {
348 : // All pageservers managed by one instance of this service must have
349 : // the same public key. This JWT token will be used to authenticate
350 : // this service to the pageservers it manages.
351 : pub jwt_token: Option<String>,
352 :
353 : // This JWT token will be used to authenticate this service to the control plane.
354 : pub control_plane_jwt_token: Option<String>,
355 :
356 : // This JWT token will be used to authenticate with other storage controller instances
357 : pub peer_jwt_token: Option<String>,
358 :
359 : /// Where the compute hook should send notifications of pageserver attachment locations
360 : /// (this URL points to the control plane in prod). If this is None, the compute hook will
361 : /// assume it is running in a test environment and try to update neon_local.
362 : pub compute_hook_url: Option<String>,
363 :
364 : /// Grace period within which a pageserver does not respond to heartbeats, but is still
365 : /// considered active. Once the grace period elapses, the next heartbeat failure will
366 : /// mark the pagseserver offline.
367 : pub max_offline_interval: Duration,
368 :
369 : /// Extended grace period within which pageserver may not respond to heartbeats.
370 : /// This extended grace period kicks in after the node has been drained for restart
371 : /// and/or upon handling the re-attach request from a node.
372 : pub max_warming_up_interval: Duration,
373 :
374 : /// How many normal-priority Reconcilers may be spawned concurrently
375 : pub reconciler_concurrency: usize,
376 :
377 : /// How many high-priority Reconcilers may be spawned concurrently
378 : pub priority_reconciler_concurrency: usize,
379 :
380 : /// How large must a shard grow in bytes before we split it?
381 : /// None disables auto-splitting.
382 : pub split_threshold: Option<u64>,
383 :
384 : // TODO: make this cfg(feature = "testing")
385 : pub neon_local_repo_dir: Option<PathBuf>,
386 :
387 : // Maximum acceptable download lag for the secondary location
388 : // while draining a node. If the secondary location is lagging
389 : // by more than the configured amount, then the secondary is not
390 : // upgraded to primary.
391 : pub max_secondary_lag_bytes: Option<u64>,
392 :
393 : pub heartbeat_interval: Duration,
394 :
395 : pub address_for_peers: Option<Uri>,
396 :
397 : pub start_as_candidate: bool,
398 :
399 : pub http_service_port: i32,
400 :
401 : pub long_reconcile_threshold: Duration,
402 : }
403 :
404 : impl From<DatabaseError> for ApiError {
405 0 : fn from(err: DatabaseError) -> ApiError {
406 0 : match err {
407 0 : DatabaseError::Query(e) => ApiError::InternalServerError(e.into()),
408 : // FIXME: ApiError doesn't have an Unavailable variant, but ShuttingDown maps to 503.
409 : DatabaseError::Connection(_) | DatabaseError::ConnectionPool(_) => {
410 0 : ApiError::ShuttingDown
411 : }
412 0 : DatabaseError::Logical(reason) | DatabaseError::Migration(reason) => {
413 0 : ApiError::InternalServerError(anyhow::anyhow!(reason))
414 : }
415 : }
416 0 : }
417 : }
418 :
419 : enum InitialShardScheduleOutcome {
420 : Scheduled(TenantCreateResponseShard),
421 : NotScheduled,
422 : ShardScheduleError(ScheduleError),
423 : }
424 :
425 : pub struct Service {
426 : inner: Arc<std::sync::RwLock<ServiceState>>,
427 : config: Config,
428 : persistence: Arc<Persistence>,
429 : compute_hook: Arc<ComputeHook>,
430 : result_tx: tokio::sync::mpsc::UnboundedSender<ReconcileResultRequest>,
431 :
432 : heartbeater_ps: Heartbeater<Node, PageserverState>,
433 : heartbeater_sk: Heartbeater<Safekeeper, SafekeeperState>,
434 :
435 : // Channel for background cleanup from failed operations that require cleanup, such as shard split
436 : abort_tx: tokio::sync::mpsc::UnboundedSender<TenantShardSplitAbort>,
437 :
438 : // Locking on a tenant granularity (covers all shards in the tenant):
439 : // - Take exclusively for rare operations that mutate the tenant's persistent state (e.g. create/delete/split)
440 : // - Take in shared mode for operations that need the set of shards to stay the same to complete reliably (e.g. timeline CRUD)
441 : tenant_op_locks: IdLockMap<TenantId, TenantOperations>,
442 :
443 : // Locking for node-mutating operations: take exclusively for operations that modify the node's persistent state, or
444 : // that transition it to/from Active.
445 : node_op_locks: IdLockMap<NodeId, NodeOperations>,
446 :
447 : // Limit how many Reconcilers we will spawn concurrently for normal-priority tasks such as background reconciliations
448 : // and reconciliation on startup.
449 : reconciler_concurrency: Arc<tokio::sync::Semaphore>,
450 :
451 : // Limit how many Reconcilers we will spawn concurrently for high-priority tasks such as tenant/timeline CRUD, which
452 : // a human user might be waiting for.
453 : priority_reconciler_concurrency: Arc<tokio::sync::Semaphore>,
454 :
455 : /// Queue of tenants who are waiting for concurrency limits to permit them to reconcile
456 : /// Send into this queue to promptly attempt to reconcile this shard next time units are available.
457 : ///
458 : /// Note that this state logically lives inside ServiceState, but carrying Sender here makes the code simpler
459 : /// by avoiding needing a &mut ref to something inside the ServiceState. This could be optimized to
460 : /// use a VecDeque instead of a channel to reduce synchronization overhead, at the cost of some code complexity.
461 : delayed_reconcile_tx: tokio::sync::mpsc::Sender<TenantShardId>,
462 :
463 : // Process shutdown will fire this token
464 : cancel: CancellationToken,
465 :
466 : // Child token of [`Service::cancel`] used by reconcilers
467 : reconcilers_cancel: CancellationToken,
468 :
469 : // Background tasks will hold this gate
470 : gate: Gate,
471 :
472 : // Reconcilers background tasks will hold this gate
473 : reconcilers_gate: Gate,
474 :
475 : /// This waits for initial reconciliation with pageservers to complete. Until this barrier
476 : /// passes, it isn't safe to do any actions that mutate tenants.
477 : pub(crate) startup_complete: Barrier,
478 : }
479 :
480 : impl From<ReconcileWaitError> for ApiError {
481 0 : fn from(value: ReconcileWaitError) -> Self {
482 0 : match value {
483 0 : ReconcileWaitError::Shutdown => ApiError::ShuttingDown,
484 0 : e @ ReconcileWaitError::Timeout(_) => ApiError::Timeout(format!("{e}").into()),
485 0 : e @ ReconcileWaitError::Failed(..) => ApiError::InternalServerError(anyhow::anyhow!(e)),
486 : }
487 0 : }
488 : }
489 :
490 : impl From<OperationError> for ApiError {
491 0 : fn from(value: OperationError) -> Self {
492 0 : match value {
493 0 : OperationError::NodeStateChanged(err) | OperationError::FinalizeError(err) => {
494 0 : ApiError::InternalServerError(anyhow::anyhow!(err))
495 : }
496 0 : OperationError::Cancelled => ApiError::Conflict("Operation was cancelled".into()),
497 : }
498 0 : }
499 : }
500 :
501 : #[allow(clippy::large_enum_variant)]
502 : enum TenantCreateOrUpdate {
503 : Create(TenantCreateRequest),
504 : Update(Vec<ShardUpdate>),
505 : }
506 :
507 : struct ShardSplitParams {
508 : old_shard_count: ShardCount,
509 : new_shard_count: ShardCount,
510 : new_stripe_size: Option<ShardStripeSize>,
511 : targets: Vec<ShardSplitTarget>,
512 : policy: PlacementPolicy,
513 : config: TenantConfig,
514 : shard_ident: ShardIdentity,
515 : preferred_az_id: Option<AvailabilityZone>,
516 : }
517 :
518 : // When preparing for a shard split, we may either choose to proceed with the split,
519 : // or find that the work is already done and return NoOp.
520 : enum ShardSplitAction {
521 : Split(Box<ShardSplitParams>),
522 : NoOp(TenantShardSplitResponse),
523 : }
524 :
525 : // A parent shard which will be split
526 : struct ShardSplitTarget {
527 : parent_id: TenantShardId,
528 : node: Node,
529 : child_ids: Vec<TenantShardId>,
530 : }
531 :
532 : /// When we tenant shard split operation fails, we may not be able to clean up immediately, because nodes
533 : /// might not be available. We therefore use a queue of abort operations processed in the background.
534 : struct TenantShardSplitAbort {
535 : tenant_id: TenantId,
536 : /// The target values from the request that failed
537 : new_shard_count: ShardCount,
538 : new_stripe_size: Option<ShardStripeSize>,
539 : /// Until this abort op is complete, no other operations may be done on the tenant
540 : _tenant_lock: TracingExclusiveGuard<TenantOperations>,
541 : }
542 :
543 : #[derive(thiserror::Error, Debug)]
544 : enum TenantShardSplitAbortError {
545 : #[error(transparent)]
546 : Database(#[from] DatabaseError),
547 : #[error(transparent)]
548 : Remote(#[from] mgmt_api::Error),
549 : #[error("Unavailable")]
550 : Unavailable,
551 : }
552 :
553 : struct ShardUpdate {
554 : tenant_shard_id: TenantShardId,
555 : placement_policy: PlacementPolicy,
556 : tenant_config: TenantConfig,
557 :
558 : /// If this is None, generation is not updated.
559 : generation: Option<Generation>,
560 :
561 : /// If this is None, scheduling policy is not updated.
562 : scheduling_policy: Option<ShardSchedulingPolicy>,
563 : }
564 :
565 : enum StopReconciliationsReason {
566 : ShuttingDown,
567 : SteppingDown,
568 : }
569 :
570 : impl std::fmt::Display for StopReconciliationsReason {
571 0 : fn fmt(&self, writer: &mut std::fmt::Formatter) -> std::fmt::Result {
572 0 : let s = match self {
573 0 : Self::ShuttingDown => "Shutting down",
574 0 : Self::SteppingDown => "Stepping down",
575 : };
576 0 : write!(writer, "{}", s)
577 0 : }
578 : }
579 :
580 : pub(crate) enum ReconcileResultRequest {
581 : ReconcileResult(ReconcileResult),
582 : Stop,
583 : }
584 :
585 : #[derive(Clone)]
586 : struct MutationLocation {
587 : node: Node,
588 : generation: Generation,
589 : }
590 :
591 : #[derive(Clone)]
592 : struct ShardMutationLocations {
593 : latest: MutationLocation,
594 : other: Vec<MutationLocation>,
595 : }
596 :
597 : #[derive(Default, Clone)]
598 : struct TenantMutationLocations(BTreeMap<TenantShardId, ShardMutationLocations>);
599 :
600 : impl Service {
601 0 : pub fn get_config(&self) -> &Config {
602 0 : &self.config
603 0 : }
604 :
605 : /// Called once on startup, this function attempts to contact all pageservers to build an up-to-date
606 : /// view of the world, and determine which pageservers are responsive.
607 : #[instrument(skip_all)]
608 : async fn startup_reconcile(
609 : self: &Arc<Service>,
610 : current_leader: Option<ControllerPersistence>,
611 : leader_step_down_state: Option<GlobalObservedState>,
612 : bg_compute_notify_result_tx: tokio::sync::mpsc::Sender<
613 : Result<(), (TenantShardId, NotifyError)>,
614 : >,
615 : ) {
616 : // Startup reconciliation does I/O to other services: whether they
617 : // are responsive or not, we should aim to finish within our deadline, because:
618 : // - If we don't, a k8s readiness hook watching /ready will kill us.
619 : // - While we're waiting for startup reconciliation, we are not fully
620 : // available for end user operations like creating/deleting tenants and timelines.
621 : //
622 : // We set multiple deadlines to break up the time available between the phases of work: this is
623 : // arbitrary, but avoids a situation where the first phase could burn our entire timeout period.
624 : let start_at = Instant::now();
625 : let node_scan_deadline = start_at
626 : .checked_add(STARTUP_RECONCILE_TIMEOUT / 2)
627 : .expect("Reconcile timeout is a modest constant");
628 :
629 : let observed = if let Some(state) = leader_step_down_state {
630 : tracing::info!(
631 : "Using observed state received from leader at {}",
632 : current_leader.as_ref().unwrap().address
633 : );
634 :
635 : state
636 : } else {
637 : self.build_global_observed_state(node_scan_deadline).await
638 : };
639 :
640 : // Accumulate a list of any tenant locations that ought to be detached
641 : let mut cleanup = Vec::new();
642 :
643 : // Send initial heartbeat requests to all nodes loaded from the database
644 : let all_nodes = {
645 : let locked = self.inner.read().unwrap();
646 : locked.nodes.clone()
647 : };
648 : let (mut nodes_online, mut sks_online) =
649 : self.initial_heartbeat_round(all_nodes.keys()).await;
650 :
651 : // List of tenants for which we will attempt to notify compute of their location at startup
652 : let mut compute_notifications = Vec::new();
653 :
654 : // Populate intent and observed states for all tenants, based on reported state on pageservers
655 : tracing::info!("Populating tenant shards' states from initial pageserver scan...");
656 : let shard_count = {
657 : let mut locked = self.inner.write().unwrap();
658 : let (nodes, safekeepers, tenants, scheduler) = locked.parts_mut_sk();
659 :
660 : // Mark nodes online if they responded to us: nodes are offline by default after a restart.
661 : let mut new_nodes = (**nodes).clone();
662 : for (node_id, node) in new_nodes.iter_mut() {
663 : if let Some(utilization) = nodes_online.remove(node_id) {
664 : node.set_availability(NodeAvailability::Active(utilization));
665 : scheduler.node_upsert(node);
666 : }
667 : }
668 : *nodes = Arc::new(new_nodes);
669 :
670 : let mut new_sks = (**safekeepers).clone();
671 : for (node_id, node) in new_sks.iter_mut() {
672 : if let Some((utilization, last_seen_at)) = sks_online.remove(node_id) {
673 : node.set_availability(SafekeeperState::Available {
674 : utilization,
675 : last_seen_at,
676 : });
677 : }
678 : }
679 : *safekeepers = Arc::new(new_sks);
680 :
681 : for (tenant_shard_id, observed_state) in observed.0 {
682 : let Some(tenant_shard) = tenants.get_mut(&tenant_shard_id) else {
683 : for node_id in observed_state.locations.keys() {
684 : cleanup.push((tenant_shard_id, *node_id));
685 : }
686 :
687 : continue;
688 : };
689 :
690 : tenant_shard.observed = observed_state;
691 : }
692 :
693 : // Populate each tenant's intent state
694 : let mut schedule_context = ScheduleContext::default();
695 : for (tenant_shard_id, tenant_shard) in tenants.iter_mut() {
696 : if tenant_shard_id.shard_number == ShardNumber(0) {
697 : // Reset scheduling context each time we advance to the next Tenant
698 : schedule_context = ScheduleContext::default();
699 : }
700 :
701 : tenant_shard.intent_from_observed(scheduler);
702 : if let Err(e) = tenant_shard.schedule(scheduler, &mut schedule_context) {
703 : // Non-fatal error: we are unable to properly schedule the tenant, perhaps because
704 : // not enough pageservers are available. The tenant may well still be available
705 : // to clients.
706 : tracing::error!("Failed to schedule tenant {tenant_shard_id} at startup: {e}");
707 : } else {
708 : // If we're both intending and observed to be attached at a particular node, we will
709 : // emit a compute notification for this. In the case where our observed state does not
710 : // yet match our intent, we will eventually reconcile, and that will emit a compute notification.
711 : if let Some(attached_at) = tenant_shard.stably_attached() {
712 : compute_notifications.push(compute_hook::ShardUpdate {
713 : tenant_shard_id: *tenant_shard_id,
714 : node_id: attached_at,
715 : stripe_size: tenant_shard.shard.stripe_size,
716 : preferred_az: tenant_shard
717 : .preferred_az()
718 0 : .map(|az| Cow::Owned(az.clone())),
719 : });
720 : }
721 : }
722 : }
723 :
724 : tenants.len()
725 : };
726 :
727 : // Before making any obeservable changes to the cluster, persist self
728 : // as leader in database and memory.
729 : let leadership = Leadership::new(
730 : self.persistence.clone(),
731 : self.config.clone(),
732 : self.cancel.child_token(),
733 : );
734 :
735 : if let Err(e) = leadership.become_leader(current_leader).await {
736 : tracing::error!("Failed to persist self as leader: {e}. Aborting start-up ...");
737 : std::process::exit(1);
738 : }
739 :
740 : self.inner.write().unwrap().become_leader();
741 :
742 : // TODO: if any tenant's intent now differs from its loaded generation_pageserver, we should clear that
743 : // generation_pageserver in the database.
744 :
745 : // Emit compute hook notifications for all tenants which are already stably attached. Other tenants
746 : // will emit compute hook notifications when they reconcile.
747 : //
748 : // Ordering: our calls to notify_background synchronously establish a relative order for these notifications vs. any later
749 : // calls into the ComputeHook for the same tenant: we can leave these to run to completion in the background and any later
750 : // calls will be correctly ordered wrt these.
751 : //
752 : // Concurrency: we call notify_background for all tenants, which will create O(N) tokio tasks, but almost all of them
753 : // will just wait on the ComputeHook::API_CONCURRENCY semaphore immediately, so very cheap until they get that semaphore
754 : // unit and start doing I/O.
755 : tracing::info!(
756 : "Sending {} compute notifications",
757 : compute_notifications.len()
758 : );
759 : self.compute_hook.notify_background(
760 : compute_notifications,
761 : bg_compute_notify_result_tx.clone(),
762 : &self.cancel,
763 : );
764 :
765 : // Finally, now that the service is up and running, launch reconcile operations for any tenants
766 : // which require it: under normal circumstances this should only include tenants that were in some
767 : // transient state before we restarted, or any tenants whose compute hooks failed above.
768 : tracing::info!("Checking for shards in need of reconciliation...");
769 : let reconcile_tasks = self.reconcile_all();
770 : // We will not wait for these reconciliation tasks to run here: we're now done with startup and
771 : // normal operations may proceed.
772 :
773 : // Clean up any tenants that were found on pageservers but are not known to us. Do this in the
774 : // background because it does not need to complete in order to proceed with other work.
775 : if !cleanup.is_empty() {
776 : tracing::info!("Cleaning up {} locations in the background", cleanup.len());
777 : tokio::task::spawn({
778 : let cleanup_self = self.clone();
779 0 : async move { cleanup_self.cleanup_locations(cleanup).await }
780 : });
781 : }
782 :
783 : tracing::info!("Startup complete, spawned {reconcile_tasks} reconciliation tasks ({shard_count} shards total)");
784 : }
785 :
786 0 : async fn initial_heartbeat_round<'a>(
787 0 : &self,
788 0 : node_ids: impl Iterator<Item = &'a NodeId>,
789 0 : ) -> (
790 0 : HashMap<NodeId, PageserverUtilization>,
791 0 : HashMap<NodeId, (SafekeeperUtilization, Instant)>,
792 0 : ) {
793 0 : assert!(!self.startup_complete.is_ready());
794 :
795 0 : let all_nodes = {
796 0 : let locked = self.inner.read().unwrap();
797 0 : locked.nodes.clone()
798 0 : };
799 0 :
800 0 : let mut nodes_to_heartbeat = HashMap::new();
801 0 : for node_id in node_ids {
802 0 : match all_nodes.get(node_id) {
803 0 : Some(node) => {
804 0 : nodes_to_heartbeat.insert(*node_id, node.clone());
805 0 : }
806 : None => {
807 0 : tracing::warn!("Node {node_id} was removed during start-up");
808 : }
809 : }
810 : }
811 :
812 0 : let all_sks = {
813 0 : let locked = self.inner.read().unwrap();
814 0 : locked.safekeepers.clone()
815 0 : };
816 0 :
817 0 : tracing::info!("Sending initial heartbeats...");
818 : // Put a small, but reasonable timeout to get the initial heartbeats of the safekeepers to avoid a storage controller downtime
819 : const SK_TIMEOUT: Duration = Duration::from_secs(5);
820 0 : let (res_ps, res_sk) = tokio::join!(
821 0 : self.heartbeater_ps.heartbeat(Arc::new(nodes_to_heartbeat)),
822 0 : tokio::time::timeout(SK_TIMEOUT, self.heartbeater_sk.heartbeat(all_sks))
823 0 : );
824 :
825 0 : let mut online_nodes = HashMap::new();
826 0 : if let Ok(deltas) = res_ps {
827 0 : for (node_id, status) in deltas.0 {
828 0 : match status {
829 0 : PageserverState::Available { utilization, .. } => {
830 0 : online_nodes.insert(node_id, utilization);
831 0 : }
832 0 : PageserverState::Offline => {}
833 : PageserverState::WarmingUp { .. } => {
834 0 : unreachable!("Nodes are never marked warming-up during startup reconcile")
835 : }
836 : }
837 : }
838 0 : }
839 :
840 0 : let mut online_sks = HashMap::new();
841 0 : if let Ok(Ok(deltas)) = res_sk {
842 0 : for (node_id, status) in deltas.0 {
843 0 : match status {
844 : SafekeeperState::Available {
845 0 : utilization,
846 0 : last_seen_at,
847 0 : } => {
848 0 : online_sks.insert(node_id, (utilization, last_seen_at));
849 0 : }
850 0 : SafekeeperState::Offline => {}
851 : }
852 : }
853 0 : }
854 :
855 0 : (online_nodes, online_sks)
856 0 : }
857 :
858 : /// Used during [`Self::startup_reconcile`]: issue GETs to all nodes concurrently, with a deadline.
859 : ///
860 : /// The result includes only nodes which responded within the deadline
861 0 : async fn scan_node_locations(
862 0 : &self,
863 0 : deadline: Instant,
864 0 : ) -> HashMap<NodeId, LocationConfigListResponse> {
865 0 : let nodes = {
866 0 : let locked = self.inner.read().unwrap();
867 0 : locked.nodes.clone()
868 0 : };
869 0 :
870 0 : let mut node_results = HashMap::new();
871 0 :
872 0 : let mut node_list_futs = FuturesUnordered::new();
873 0 :
874 0 : tracing::info!("Scanning shards on {} nodes...", nodes.len());
875 0 : for node in nodes.values() {
876 0 : node_list_futs.push({
877 0 : async move {
878 0 : tracing::info!("Scanning shards on node {node}...");
879 0 : let timeout = Duration::from_secs(5);
880 0 : let response = node
881 0 : .with_client_retries(
882 0 : |client| async move { client.list_location_config().await },
883 0 : &self.config.jwt_token,
884 0 : 1,
885 0 : 5,
886 0 : timeout,
887 0 : &self.cancel,
888 0 : )
889 0 : .await;
890 0 : (node.get_id(), response)
891 0 : }
892 0 : });
893 0 : }
894 :
895 : loop {
896 0 : let (node_id, result) = tokio::select! {
897 0 : next = node_list_futs.next() => {
898 0 : match next {
899 0 : Some(result) => result,
900 : None =>{
901 : // We got results for all our nodes
902 0 : break;
903 : }
904 :
905 : }
906 : },
907 0 : _ = tokio::time::sleep(deadline.duration_since(Instant::now())) => {
908 : // Give up waiting for anyone who hasn't responded: we will yield the results that we have
909 0 : tracing::info!("Reached deadline while waiting for nodes to respond to location listing requests");
910 0 : break;
911 : }
912 : };
913 :
914 0 : let Some(list_response) = result else {
915 0 : tracing::info!("Shutdown during startup_reconcile");
916 0 : break;
917 : };
918 :
919 0 : match list_response {
920 0 : Err(e) => {
921 0 : tracing::warn!("Could not scan node {} ({e})", node_id);
922 : }
923 0 : Ok(listing) => {
924 0 : node_results.insert(node_id, listing);
925 0 : }
926 : }
927 : }
928 :
929 0 : node_results
930 0 : }
931 :
932 0 : async fn build_global_observed_state(&self, deadline: Instant) -> GlobalObservedState {
933 0 : let node_listings = self.scan_node_locations(deadline).await;
934 0 : let mut observed = GlobalObservedState::default();
935 :
936 0 : for (node_id, location_confs) in node_listings {
937 0 : tracing::info!(
938 0 : "Received {} shard statuses from pageserver {}",
939 0 : location_confs.tenant_shards.len(),
940 : node_id
941 : );
942 :
943 0 : for (tid, location_conf) in location_confs.tenant_shards {
944 0 : let entry = observed.0.entry(tid).or_default();
945 0 : entry.locations.insert(
946 0 : node_id,
947 0 : ObservedStateLocation {
948 0 : conf: location_conf,
949 0 : },
950 0 : );
951 0 : }
952 : }
953 :
954 0 : observed
955 0 : }
956 :
957 : /// Used during [`Self::startup_reconcile`]: detach a list of unknown-to-us tenants from pageservers.
958 : ///
959 : /// This is safe to run in the background, because if we don't have this TenantShardId in our map of
960 : /// tenants, then it is probably something incompletely deleted before: we will not fight with any
961 : /// other task trying to attach it.
962 : #[instrument(skip_all)]
963 : async fn cleanup_locations(&self, cleanup: Vec<(TenantShardId, NodeId)>) {
964 : let nodes = self.inner.read().unwrap().nodes.clone();
965 :
966 : for (tenant_shard_id, node_id) in cleanup {
967 : // A node reported a tenant_shard_id which is unknown to us: detach it.
968 : let Some(node) = nodes.get(&node_id) else {
969 : // This is legitimate; we run in the background and [`Self::startup_reconcile`] might have identified
970 : // a location to clean up on a node that has since been removed.
971 : tracing::info!(
972 : "Not cleaning up location {node_id}/{tenant_shard_id}: node not found"
973 : );
974 : continue;
975 : };
976 :
977 : if self.cancel.is_cancelled() {
978 : break;
979 : }
980 :
981 : let client = PageserverClient::new(
982 : node.get_id(),
983 : node.base_url(),
984 : self.config.jwt_token.as_deref(),
985 : );
986 : match client
987 : .location_config(
988 : tenant_shard_id,
989 : LocationConfig {
990 : mode: LocationConfigMode::Detached,
991 : generation: None,
992 : secondary_conf: None,
993 : shard_number: tenant_shard_id.shard_number.0,
994 : shard_count: tenant_shard_id.shard_count.literal(),
995 : shard_stripe_size: 0,
996 : tenant_conf: models::TenantConfig::default(),
997 : },
998 : None,
999 : false,
1000 : )
1001 : .await
1002 : {
1003 : Ok(()) => {
1004 : tracing::info!(
1005 : "Detached unknown shard {tenant_shard_id} on pageserver {node_id}"
1006 : );
1007 : }
1008 : Err(e) => {
1009 : // Non-fatal error: leaving a tenant shard behind that we are not managing shouldn't
1010 : // break anything.
1011 : tracing::error!(
1012 : "Failed to detach unknkown shard {tenant_shard_id} on pageserver {node_id}: {e}"
1013 : );
1014 : }
1015 : }
1016 : }
1017 : }
1018 :
1019 : /// Long running background task that periodically wakes up and looks for shards that need
1020 : /// reconciliation. Reconciliation is fallible, so any reconciliation tasks that fail during
1021 : /// e.g. a tenant create/attach/migrate must eventually be retried: this task is responsible
1022 : /// for those retries.
1023 : #[instrument(skip_all)]
1024 : async fn background_reconcile(self: &Arc<Self>) {
1025 : self.startup_complete.clone().wait().await;
1026 :
1027 : const BACKGROUND_RECONCILE_PERIOD: Duration = Duration::from_secs(20);
1028 : let mut interval = tokio::time::interval(BACKGROUND_RECONCILE_PERIOD);
1029 : while !self.reconcilers_cancel.is_cancelled() {
1030 : tokio::select! {
1031 : _ = interval.tick() => {
1032 : let reconciles_spawned = self.reconcile_all();
1033 : if reconciles_spawned == 0 {
1034 : // Run optimizer only when we didn't find any other work to do
1035 : self.optimize_all().await;
1036 : }
1037 : // Always attempt autosplits. Sharding is crucial for bulk ingest performance, so we
1038 : // must be responsive when new projects begin ingesting and reach the threshold.
1039 : self.autosplit_tenants().await;
1040 : }
1041 : _ = self.reconcilers_cancel.cancelled() => return
1042 : }
1043 : }
1044 : }
1045 : #[instrument(skip_all)]
1046 : async fn spawn_heartbeat_driver(&self) {
1047 : self.startup_complete.clone().wait().await;
1048 :
1049 : let mut interval = tokio::time::interval(self.config.heartbeat_interval);
1050 : while !self.cancel.is_cancelled() {
1051 : tokio::select! {
1052 : _ = interval.tick() => { }
1053 : _ = self.cancel.cancelled() => return
1054 : };
1055 :
1056 : let nodes = {
1057 : let locked = self.inner.read().unwrap();
1058 : locked.nodes.clone()
1059 : };
1060 :
1061 : let safekeepers = {
1062 : let locked = self.inner.read().unwrap();
1063 : locked.safekeepers.clone()
1064 : };
1065 :
1066 : const SK_TIMEOUT: Duration = Duration::from_secs(3);
1067 : let (res_ps, res_sk) = tokio::join!(
1068 : self.heartbeater_ps.heartbeat(nodes),
1069 : tokio::time::timeout(SK_TIMEOUT, self.heartbeater_sk.heartbeat(safekeepers))
1070 : );
1071 :
1072 : if let Ok(deltas) = res_ps {
1073 : let mut to_handle = Vec::default();
1074 :
1075 : for (node_id, state) in deltas.0 {
1076 : let new_availability = match state {
1077 : PageserverState::Available { utilization, .. } => {
1078 : NodeAvailability::Active(utilization)
1079 : }
1080 : PageserverState::WarmingUp { started_at } => {
1081 : NodeAvailability::WarmingUp(started_at)
1082 : }
1083 : PageserverState::Offline => {
1084 : // The node might have been placed in the WarmingUp state
1085 : // while the heartbeat round was on-going. Hence, filter out
1086 : // offline transitions for WarmingUp nodes that are still within
1087 : // their grace period.
1088 : if let Ok(NodeAvailability::WarmingUp(started_at)) = self
1089 : .get_node(node_id)
1090 : .await
1091 : .as_ref()
1092 0 : .map(|n| n.get_availability())
1093 : {
1094 : let now = Instant::now();
1095 : if now - *started_at >= self.config.max_warming_up_interval {
1096 : NodeAvailability::Offline
1097 : } else {
1098 : NodeAvailability::WarmingUp(*started_at)
1099 : }
1100 : } else {
1101 : NodeAvailability::Offline
1102 : }
1103 : }
1104 : };
1105 :
1106 : let node_lock = trace_exclusive_lock(
1107 : &self.node_op_locks,
1108 : node_id,
1109 : NodeOperations::Configure,
1110 : )
1111 : .await;
1112 :
1113 : pausable_failpoint!("heartbeat-pre-node-state-configure");
1114 :
1115 : // This is the code path for geniune availability transitions (i.e node
1116 : // goes unavailable and/or comes back online).
1117 : let res = self
1118 : .node_state_configure(node_id, Some(new_availability), None, &node_lock)
1119 : .await;
1120 :
1121 : match res {
1122 : Ok(transition) => {
1123 : // Keep hold of the lock until the availability transitions
1124 : // have been handled in
1125 : // [`Service::handle_node_availability_transitions`] in order avoid
1126 : // racing with [`Service::external_node_configure`].
1127 : to_handle.push((node_id, node_lock, transition));
1128 : }
1129 : Err(ApiError::NotFound(_)) => {
1130 : // This should be rare, but legitimate since the heartbeats are done
1131 : // on a snapshot of the nodes.
1132 : tracing::info!("Node {} was not found after heartbeat round", node_id);
1133 : }
1134 : Err(ApiError::ShuttingDown) => {
1135 : // No-op: we're shutting down, no need to try and update any nodes' statuses
1136 : }
1137 : Err(err) => {
1138 : // Transition to active involves reconciling: if a node responds to a heartbeat then
1139 : // becomes unavailable again, we may get an error here.
1140 : tracing::error!(
1141 : "Failed to update node state {} after heartbeat round: {}",
1142 : node_id,
1143 : err
1144 : );
1145 : }
1146 : }
1147 : }
1148 :
1149 : // We collected all the transitions above and now we handle them.
1150 : let res = self.handle_node_availability_transitions(to_handle).await;
1151 : if let Err(errs) = res {
1152 : for (node_id, err) in errs {
1153 : match err {
1154 : ApiError::NotFound(_) => {
1155 : // This should be rare, but legitimate since the heartbeats are done
1156 : // on a snapshot of the nodes.
1157 : tracing::info!(
1158 : "Node {} was not found after heartbeat round",
1159 : node_id
1160 : );
1161 : }
1162 : err => {
1163 : tracing::error!(
1164 : "Failed to handle availability transition for {} after heartbeat round: {}",
1165 : node_id,
1166 : err
1167 : );
1168 : }
1169 : }
1170 : }
1171 : }
1172 : }
1173 : if let Ok(Ok(deltas)) = res_sk {
1174 : let mut locked = self.inner.write().unwrap();
1175 : let mut safekeepers = (*locked.safekeepers).clone();
1176 : for (id, state) in deltas.0 {
1177 : let Some(sk) = safekeepers.get_mut(&id) else {
1178 : tracing::info!("Couldn't update safekeeper safekeeper state for id {id} from heartbeat={state:?}");
1179 : continue;
1180 : };
1181 : sk.set_availability(state);
1182 : }
1183 : locked.safekeepers = Arc::new(safekeepers);
1184 : }
1185 : }
1186 : }
1187 :
1188 : /// Apply the contents of a [`ReconcileResult`] to our in-memory state: if the reconciliation
1189 : /// was successful and intent hasn't changed since the Reconciler was spawned, this will update
1190 : /// the observed state of the tenant such that subsequent calls to [`TenantShard::get_reconcile_needed`]
1191 : /// will indicate that reconciliation is not needed.
1192 : #[instrument(skip_all, fields(
1193 : seq=%result.sequence,
1194 : tenant_id=%result.tenant_shard_id.tenant_id,
1195 : shard_id=%result.tenant_shard_id.shard_slug(),
1196 : ))]
1197 : fn process_result(&self, result: ReconcileResult) {
1198 : let mut locked = self.inner.write().unwrap();
1199 : let (nodes, tenants, _scheduler) = locked.parts_mut();
1200 : let Some(tenant) = tenants.get_mut(&result.tenant_shard_id) else {
1201 : // A reconciliation result might race with removing a tenant: drop results for
1202 : // tenants that aren't in our map.
1203 : return;
1204 : };
1205 :
1206 : // Usually generation should only be updated via this path, so the max() isn't
1207 : // needed, but it is used to handle out-of-band updates via. e.g. test hook.
1208 : tenant.generation = std::cmp::max(tenant.generation, result.generation);
1209 :
1210 : // If the reconciler signals that it failed to notify compute, set this state on
1211 : // the shard so that a future [`TenantShard::maybe_reconcile`] will try again.
1212 : tenant.pending_compute_notification = result.pending_compute_notification;
1213 :
1214 : // Let the TenantShard know it is idle.
1215 : tenant.reconcile_complete(result.sequence);
1216 :
1217 : // In case a node was deleted while this reconcile is in flight, filter it out of the update we will
1218 : // make to the tenant
1219 0 : let deltas = result.observed_deltas.into_iter().flat_map(|delta| {
1220 : // In case a node was deleted while this reconcile is in flight, filter it out of the update we will
1221 : // make to the tenant
1222 0 : let node = nodes.get(delta.node_id())?;
1223 :
1224 0 : if node.is_available() {
1225 0 : return Some(delta);
1226 0 : }
1227 0 :
1228 0 : // In case a node became unavailable concurrently with the reconcile, observed
1229 0 : // locations on it are now uncertain. By convention, set them to None in order
1230 0 : // for them to get refreshed when the node comes back online.
1231 0 : Some(ObservedStateDelta::Upsert(Box::new((
1232 0 : node.get_id(),
1233 0 : ObservedStateLocation { conf: None },
1234 0 : ))))
1235 0 : });
1236 :
1237 : match result.result {
1238 : Ok(()) => {
1239 : tenant.apply_observed_deltas(deltas);
1240 : tenant.waiter.advance(result.sequence);
1241 : }
1242 : Err(e) => {
1243 : match e {
1244 : ReconcileError::Cancel => {
1245 : tracing::info!("Reconciler was cancelled");
1246 : }
1247 : ReconcileError::Remote(mgmt_api::Error::Cancelled) => {
1248 : // This might be due to the reconciler getting cancelled, or it might
1249 : // be due to the `Node` being marked offline.
1250 : tracing::info!("Reconciler cancelled during pageserver API call");
1251 : }
1252 : _ => {
1253 : tracing::warn!("Reconcile error: {}", e);
1254 : }
1255 : }
1256 :
1257 : // Ordering: populate last_error before advancing error_seq,
1258 : // so that waiters will see the correct error after waiting.
1259 : tenant.set_last_error(result.sequence, e);
1260 :
1261 : // Skip deletions on reconcile failures
1262 : let upsert_deltas =
1263 0 : deltas.filter(|delta| matches!(delta, ObservedStateDelta::Upsert(_)));
1264 : tenant.apply_observed_deltas(upsert_deltas);
1265 : }
1266 : }
1267 :
1268 : // If we just finished detaching all shards for a tenant, it might be time to drop it from memory.
1269 : if tenant.policy == PlacementPolicy::Detached {
1270 : // We may only drop a tenant from memory while holding the exclusive lock on the tenant ID: this protects us
1271 : // from concurrent execution wrt a request handler that might expect the tenant to remain in memory for the
1272 : // duration of the request.
1273 : let guard = self.tenant_op_locks.try_exclusive(
1274 : tenant.tenant_shard_id.tenant_id,
1275 : TenantOperations::DropDetached,
1276 : );
1277 : if let Some(guard) = guard {
1278 : self.maybe_drop_tenant(tenant.tenant_shard_id.tenant_id, &mut locked, &guard);
1279 : }
1280 : }
1281 :
1282 : // Maybe some other work can proceed now that this job finished.
1283 : //
1284 : // Only bother with this if we have some semaphore units available in the normal-priority semaphore (these
1285 : // reconciles are scheduled at `[ReconcilerPriority::Normal]`).
1286 : if self.reconciler_concurrency.available_permits() > 0 {
1287 : while let Ok(tenant_shard_id) = locked.delayed_reconcile_rx.try_recv() {
1288 : let (nodes, tenants, _scheduler) = locked.parts_mut();
1289 : if let Some(shard) = tenants.get_mut(&tenant_shard_id) {
1290 : shard.delayed_reconcile = false;
1291 : self.maybe_reconcile_shard(shard, nodes, ReconcilerPriority::Normal);
1292 : }
1293 :
1294 : if self.reconciler_concurrency.available_permits() == 0 {
1295 : break;
1296 : }
1297 : }
1298 : }
1299 : }
1300 :
1301 0 : async fn process_results(
1302 0 : &self,
1303 0 : mut result_rx: tokio::sync::mpsc::UnboundedReceiver<ReconcileResultRequest>,
1304 0 : mut bg_compute_hook_result_rx: tokio::sync::mpsc::Receiver<
1305 0 : Result<(), (TenantShardId, NotifyError)>,
1306 0 : >,
1307 0 : ) {
1308 : loop {
1309 : // Wait for the next result, or for cancellation
1310 0 : tokio::select! {
1311 0 : r = result_rx.recv() => {
1312 0 : match r {
1313 0 : Some(ReconcileResultRequest::ReconcileResult(result)) => {self.process_result(result);},
1314 0 : None | Some(ReconcileResultRequest::Stop) => {break;}
1315 : }
1316 : }
1317 0 : _ = async{
1318 0 : match bg_compute_hook_result_rx.recv().await {
1319 0 : Some(result) => {
1320 0 : if let Err((tenant_shard_id, notify_error)) = result {
1321 0 : tracing::warn!("Marking shard {tenant_shard_id} for notification retry, due to error {notify_error}");
1322 0 : let mut locked = self.inner.write().unwrap();
1323 0 : if let Some(shard) = locked.tenants.get_mut(&tenant_shard_id) {
1324 0 : shard.pending_compute_notification = true;
1325 0 : }
1326 :
1327 0 : }
1328 : },
1329 : None => {
1330 : // This channel is dead, but we don't want to terminate the outer loop{}: just wait for shutdown
1331 0 : self.cancel.cancelled().await;
1332 : }
1333 : }
1334 0 : } => {},
1335 0 : _ = self.cancel.cancelled() => {
1336 0 : break;
1337 : }
1338 : };
1339 : }
1340 0 : }
1341 :
1342 0 : async fn process_aborts(
1343 0 : &self,
1344 0 : mut abort_rx: tokio::sync::mpsc::UnboundedReceiver<TenantShardSplitAbort>,
1345 0 : ) {
1346 : loop {
1347 : // Wait for the next result, or for cancellation
1348 0 : let op = tokio::select! {
1349 0 : r = abort_rx.recv() => {
1350 0 : match r {
1351 0 : Some(op) => {op},
1352 0 : None => {break;}
1353 : }
1354 : }
1355 0 : _ = self.cancel.cancelled() => {
1356 0 : break;
1357 : }
1358 : };
1359 :
1360 : // Retry until shutdown: we must keep this request object alive until it is properly
1361 : // processed, as it holds a lock guard that prevents other operations trying to do things
1362 : // to the tenant while it is in a weird part-split state.
1363 0 : while !self.cancel.is_cancelled() {
1364 0 : match self.abort_tenant_shard_split(&op).await {
1365 0 : Ok(_) => break,
1366 0 : Err(e) => {
1367 0 : tracing::warn!(
1368 0 : "Failed to abort shard split on {}, will retry: {e}",
1369 : op.tenant_id
1370 : );
1371 :
1372 : // If a node is unavailable, we hope that it has been properly marked Offline
1373 : // when we retry, so that the abort op will succeed. If the abort op is failing
1374 : // for some other reason, we will keep retrying forever, or until a human notices
1375 : // and does something about it (either fixing a pageserver or restarting the controller).
1376 0 : tokio::time::timeout(Duration::from_secs(5), self.cancel.cancelled())
1377 0 : .await
1378 0 : .ok();
1379 : }
1380 : }
1381 : }
1382 : }
1383 0 : }
1384 :
1385 0 : pub async fn spawn(config: Config, persistence: Arc<Persistence>) -> anyhow::Result<Arc<Self>> {
1386 0 : let (result_tx, result_rx) = tokio::sync::mpsc::unbounded_channel();
1387 0 : let (abort_tx, abort_rx) = tokio::sync::mpsc::unbounded_channel();
1388 0 :
1389 0 : let leadership_cancel = CancellationToken::new();
1390 0 : let leadership = Leadership::new(persistence.clone(), config.clone(), leadership_cancel);
1391 0 : let (leader, leader_step_down_state) = leadership.step_down_current_leader().await?;
1392 :
1393 : // Apply the migrations **after** the current leader has stepped down
1394 : // (or we've given up waiting for it), but **before** reading from the
1395 : // database. The only exception is reading the current leader before
1396 : // migrating.
1397 0 : persistence.migration_run().await?;
1398 :
1399 0 : tracing::info!("Loading nodes from database...");
1400 0 : let nodes = persistence
1401 0 : .list_nodes()
1402 0 : .await?
1403 0 : .into_iter()
1404 0 : .map(Node::from_persistent)
1405 0 : .collect::<Vec<_>>();
1406 0 : let nodes: HashMap<NodeId, Node> = nodes.into_iter().map(|n| (n.get_id(), n)).collect();
1407 0 : tracing::info!("Loaded {} nodes from database.", nodes.len());
1408 0 : metrics::METRICS_REGISTRY
1409 0 : .metrics_group
1410 0 : .storage_controller_pageserver_nodes
1411 0 : .set(nodes.len() as i64);
1412 0 :
1413 0 : tracing::info!("Loading safekeepers from database...");
1414 0 : let safekeepers = persistence
1415 0 : .list_safekeepers()
1416 0 : .await?
1417 0 : .into_iter()
1418 0 : .map(|skp| Safekeeper::from_persistence(skp, CancellationToken::new()))
1419 0 : .collect::<Vec<_>>();
1420 0 : let safekeepers: HashMap<NodeId, Safekeeper> =
1421 0 : safekeepers.into_iter().map(|n| (n.get_id(), n)).collect();
1422 0 : tracing::info!("Loaded {} safekeepers from database.", safekeepers.len());
1423 :
1424 0 : tracing::info!("Loading shards from database...");
1425 0 : let mut tenant_shard_persistence = persistence.load_active_tenant_shards().await?;
1426 0 : tracing::info!(
1427 0 : "Loaded {} shards from database.",
1428 0 : tenant_shard_persistence.len()
1429 : );
1430 :
1431 : // If any shard splits were in progress, reset the database state to abort them
1432 0 : let mut tenant_shard_count_min_max: HashMap<TenantId, (ShardCount, ShardCount)> =
1433 0 : HashMap::new();
1434 0 : for tsp in &mut tenant_shard_persistence {
1435 0 : let shard = tsp.get_shard_identity()?;
1436 0 : let tenant_shard_id = tsp.get_tenant_shard_id()?;
1437 0 : let entry = tenant_shard_count_min_max
1438 0 : .entry(tenant_shard_id.tenant_id)
1439 0 : .or_insert_with(|| (shard.count, shard.count));
1440 0 : entry.0 = std::cmp::min(entry.0, shard.count);
1441 0 : entry.1 = std::cmp::max(entry.1, shard.count);
1442 0 : }
1443 :
1444 0 : for (tenant_id, (count_min, count_max)) in tenant_shard_count_min_max {
1445 0 : if count_min != count_max {
1446 : // Aborting the split in the database and dropping the child shards is sufficient: the reconciliation in
1447 : // [`Self::startup_reconcile`] will implicitly drop the child shards on remote pageservers, or they'll
1448 : // be dropped later in [`Self::node_activate_reconcile`] if it isn't available right now.
1449 0 : tracing::info!("Aborting shard split {tenant_id} {count_min:?} -> {count_max:?}");
1450 0 : let abort_status = persistence.abort_shard_split(tenant_id, count_max).await?;
1451 :
1452 : // We may never see the Complete status here: if the split was complete, we wouldn't have
1453 : // identified this tenant has having mismatching min/max counts.
1454 0 : assert!(matches!(abort_status, AbortShardSplitStatus::Aborted));
1455 :
1456 : // Clear the splitting status in-memory, to reflect that we just aborted in the database
1457 0 : tenant_shard_persistence.iter_mut().for_each(|tsp| {
1458 0 : // Set idle split state on those shards that we will retain.
1459 0 : let tsp_tenant_id = TenantId::from_str(tsp.tenant_id.as_str()).unwrap();
1460 0 : if tsp_tenant_id == tenant_id
1461 0 : && tsp.get_shard_identity().unwrap().count == count_min
1462 0 : {
1463 0 : tsp.splitting = SplitState::Idle;
1464 0 : } else if tsp_tenant_id == tenant_id {
1465 : // Leave the splitting state on the child shards: this will be used next to
1466 : // drop them.
1467 0 : tracing::info!(
1468 0 : "Shard {tsp_tenant_id} will be dropped after shard split abort",
1469 : );
1470 0 : }
1471 0 : });
1472 0 :
1473 0 : // Drop shards for this tenant which we didn't just mark idle (i.e. child shards of the aborted split)
1474 0 : tenant_shard_persistence.retain(|tsp| {
1475 0 : TenantId::from_str(tsp.tenant_id.as_str()).unwrap() != tenant_id
1476 0 : || tsp.splitting == SplitState::Idle
1477 0 : });
1478 0 : }
1479 : }
1480 :
1481 0 : let mut tenants = BTreeMap::new();
1482 0 :
1483 0 : let mut scheduler = Scheduler::new(nodes.values());
1484 :
1485 : #[cfg(feature = "testing")]
1486 : {
1487 : use pageserver_api::controller_api::AvailabilityZone;
1488 :
1489 : // Hack: insert scheduler state for all nodes referenced by shards, as compatibility
1490 : // tests only store the shards, not the nodes. The nodes will be loaded shortly
1491 : // after when pageservers start up and register.
1492 0 : let mut node_ids = HashSet::new();
1493 0 : for tsp in &tenant_shard_persistence {
1494 0 : if let Some(node_id) = tsp.generation_pageserver {
1495 0 : node_ids.insert(node_id);
1496 0 : }
1497 : }
1498 0 : for node_id in node_ids {
1499 0 : tracing::info!("Creating node {} in scheduler for tests", node_id);
1500 0 : let node = Node::new(
1501 0 : NodeId(node_id as u64),
1502 0 : "".to_string(),
1503 0 : 123,
1504 0 : "".to_string(),
1505 0 : 123,
1506 0 : AvailabilityZone("test_az".to_string()),
1507 0 : );
1508 0 :
1509 0 : scheduler.node_upsert(&node);
1510 : }
1511 : }
1512 0 : for tsp in tenant_shard_persistence {
1513 0 : let tenant_shard_id = tsp.get_tenant_shard_id()?;
1514 :
1515 : // We will populate intent properly later in [`Self::startup_reconcile`], initially populate
1516 : // it with what we can infer: the node for which a generation was most recently issued.
1517 0 : let mut intent = IntentState::new(
1518 0 : tsp.preferred_az_id
1519 0 : .as_ref()
1520 0 : .map(|az| AvailabilityZone(az.clone())),
1521 0 : );
1522 0 : if let Some(generation_pageserver) = tsp.generation_pageserver.map(|n| NodeId(n as u64))
1523 : {
1524 0 : if nodes.contains_key(&generation_pageserver) {
1525 0 : intent.set_attached(&mut scheduler, Some(generation_pageserver));
1526 0 : } else {
1527 : // If a node was removed before being completely drained, it is legal for it to leave behind a `generation_pageserver` referring
1528 : // to a non-existent node, because node deletion doesn't block on completing the reconciliations that will issue new generations
1529 : // on different pageservers.
1530 0 : tracing::warn!("Tenant shard {tenant_shard_id} references non-existent node {generation_pageserver} in database, will be rescheduled");
1531 : }
1532 0 : }
1533 0 : let new_tenant = TenantShard::from_persistent(tsp, intent)?;
1534 :
1535 0 : tenants.insert(tenant_shard_id, new_tenant);
1536 : }
1537 :
1538 0 : let (startup_completion, startup_complete) = utils::completion::channel();
1539 0 :
1540 0 : // This channel is continuously consumed by process_results, so doesn't need to be very large.
1541 0 : let (bg_compute_notify_result_tx, bg_compute_notify_result_rx) =
1542 0 : tokio::sync::mpsc::channel(512);
1543 0 :
1544 0 : let (delayed_reconcile_tx, delayed_reconcile_rx) =
1545 0 : tokio::sync::mpsc::channel(MAX_DELAYED_RECONCILES);
1546 0 :
1547 0 : let cancel = CancellationToken::new();
1548 0 : let reconcilers_cancel = cancel.child_token();
1549 0 :
1550 0 : let heartbeater_ps = Heartbeater::new(
1551 0 : config.jwt_token.clone(),
1552 0 : config.max_offline_interval,
1553 0 : config.max_warming_up_interval,
1554 0 : cancel.clone(),
1555 0 : );
1556 0 :
1557 0 : let heartbeater_sk = Heartbeater::new(
1558 0 : config.jwt_token.clone(),
1559 0 : config.max_offline_interval,
1560 0 : config.max_warming_up_interval,
1561 0 : cancel.clone(),
1562 0 : );
1563 :
1564 0 : let initial_leadership_status = if config.start_as_candidate {
1565 0 : LeadershipStatus::Candidate
1566 : } else {
1567 0 : LeadershipStatus::Leader
1568 : };
1569 :
1570 0 : let this = Arc::new(Self {
1571 0 : inner: Arc::new(std::sync::RwLock::new(ServiceState::new(
1572 0 : nodes,
1573 0 : safekeepers,
1574 0 : tenants,
1575 0 : scheduler,
1576 0 : delayed_reconcile_rx,
1577 0 : initial_leadership_status,
1578 0 : ))),
1579 0 : config: config.clone(),
1580 0 : persistence,
1581 0 : compute_hook: Arc::new(ComputeHook::new(config.clone())),
1582 0 : result_tx,
1583 0 : heartbeater_ps,
1584 0 : heartbeater_sk,
1585 0 : reconciler_concurrency: Arc::new(tokio::sync::Semaphore::new(
1586 0 : config.reconciler_concurrency,
1587 0 : )),
1588 0 : priority_reconciler_concurrency: Arc::new(tokio::sync::Semaphore::new(
1589 0 : config.priority_reconciler_concurrency,
1590 0 : )),
1591 0 : delayed_reconcile_tx,
1592 0 : abort_tx,
1593 0 : startup_complete: startup_complete.clone(),
1594 0 : cancel,
1595 0 : reconcilers_cancel,
1596 0 : gate: Gate::default(),
1597 0 : reconcilers_gate: Gate::default(),
1598 0 : tenant_op_locks: Default::default(),
1599 0 : node_op_locks: Default::default(),
1600 0 : });
1601 0 :
1602 0 : let result_task_this = this.clone();
1603 0 : tokio::task::spawn(async move {
1604 : // Block shutdown until we're done (we must respect self.cancel)
1605 0 : if let Ok(_gate) = result_task_this.gate.enter() {
1606 0 : result_task_this
1607 0 : .process_results(result_rx, bg_compute_notify_result_rx)
1608 0 : .await
1609 0 : }
1610 0 : });
1611 0 :
1612 0 : tokio::task::spawn({
1613 0 : let this = this.clone();
1614 0 : async move {
1615 : // Block shutdown until we're done (we must respect self.cancel)
1616 0 : if let Ok(_gate) = this.gate.enter() {
1617 0 : this.process_aborts(abort_rx).await
1618 0 : }
1619 0 : }
1620 0 : });
1621 0 :
1622 0 : tokio::task::spawn({
1623 0 : let this = this.clone();
1624 0 : async move {
1625 0 : if let Ok(_gate) = this.gate.enter() {
1626 : loop {
1627 0 : tokio::select! {
1628 0 : _ = this.cancel.cancelled() => {
1629 0 : break;
1630 : },
1631 0 : _ = tokio::time::sleep(Duration::from_secs(60)) => {}
1632 0 : };
1633 0 : this.tenant_op_locks.housekeeping();
1634 : }
1635 0 : }
1636 0 : }
1637 0 : });
1638 0 :
1639 0 : tokio::task::spawn({
1640 0 : let this = this.clone();
1641 0 : // We will block the [`Service::startup_complete`] barrier until [`Self::startup_reconcile`]
1642 0 : // is done.
1643 0 : let startup_completion = startup_completion.clone();
1644 0 : async move {
1645 : // Block shutdown until we're done (we must respect self.cancel)
1646 0 : let Ok(_gate) = this.gate.enter() else {
1647 0 : return;
1648 : };
1649 :
1650 0 : this.startup_reconcile(leader, leader_step_down_state, bg_compute_notify_result_tx)
1651 0 : .await;
1652 :
1653 0 : drop(startup_completion);
1654 0 : }
1655 0 : });
1656 0 :
1657 0 : tokio::task::spawn({
1658 0 : let this = this.clone();
1659 0 : let startup_complete = startup_complete.clone();
1660 0 : async move {
1661 0 : startup_complete.wait().await;
1662 0 : this.background_reconcile().await;
1663 0 : }
1664 0 : });
1665 0 :
1666 0 : tokio::task::spawn({
1667 0 : let this = this.clone();
1668 0 : let startup_complete = startup_complete.clone();
1669 0 : async move {
1670 0 : startup_complete.wait().await;
1671 0 : this.spawn_heartbeat_driver().await;
1672 0 : }
1673 0 : });
1674 0 :
1675 0 : Ok(this)
1676 0 : }
1677 :
1678 0 : pub(crate) async fn attach_hook(
1679 0 : &self,
1680 0 : attach_req: AttachHookRequest,
1681 0 : ) -> anyhow::Result<AttachHookResponse> {
1682 0 : let _tenant_lock = trace_exclusive_lock(
1683 0 : &self.tenant_op_locks,
1684 0 : attach_req.tenant_shard_id.tenant_id,
1685 0 : TenantOperations::AttachHook,
1686 0 : )
1687 0 : .await;
1688 :
1689 : // This is a test hook. To enable using it on tenants that were created directly with
1690 : // the pageserver API (not via this service), we will auto-create any missing tenant
1691 : // shards with default state.
1692 0 : let insert = {
1693 0 : match self
1694 0 : .maybe_load_tenant(attach_req.tenant_shard_id.tenant_id, &_tenant_lock)
1695 0 : .await
1696 : {
1697 0 : Ok(_) => false,
1698 0 : Err(ApiError::NotFound(_)) => true,
1699 0 : Err(e) => return Err(e.into()),
1700 : }
1701 : };
1702 :
1703 0 : if insert {
1704 0 : let tsp = TenantShardPersistence {
1705 0 : tenant_id: attach_req.tenant_shard_id.tenant_id.to_string(),
1706 0 : shard_number: attach_req.tenant_shard_id.shard_number.0 as i32,
1707 0 : shard_count: attach_req.tenant_shard_id.shard_count.literal() as i32,
1708 0 : shard_stripe_size: 0,
1709 0 : generation: attach_req.generation_override.or(Some(0)),
1710 0 : generation_pageserver: None,
1711 0 : placement_policy: serde_json::to_string(&PlacementPolicy::Attached(0)).unwrap(),
1712 0 : config: serde_json::to_string(&TenantConfig::default()).unwrap(),
1713 0 : splitting: SplitState::default(),
1714 0 : scheduling_policy: serde_json::to_string(&ShardSchedulingPolicy::default())
1715 0 : .unwrap(),
1716 0 : preferred_az_id: None,
1717 0 : };
1718 0 :
1719 0 : match self.persistence.insert_tenant_shards(vec![tsp]).await {
1720 0 : Err(e) => match e {
1721 : DatabaseError::Query(diesel::result::Error::DatabaseError(
1722 : DatabaseErrorKind::UniqueViolation,
1723 : _,
1724 : )) => {
1725 0 : tracing::info!(
1726 0 : "Raced with another request to insert tenant {}",
1727 : attach_req.tenant_shard_id
1728 : )
1729 : }
1730 0 : _ => return Err(e.into()),
1731 : },
1732 : Ok(()) => {
1733 0 : tracing::info!("Inserted shard {} in database", attach_req.tenant_shard_id);
1734 :
1735 0 : let mut locked = self.inner.write().unwrap();
1736 0 : locked.tenants.insert(
1737 0 : attach_req.tenant_shard_id,
1738 0 : TenantShard::new(
1739 0 : attach_req.tenant_shard_id,
1740 0 : ShardIdentity::unsharded(),
1741 0 : PlacementPolicy::Attached(0),
1742 0 : None,
1743 0 : ),
1744 0 : );
1745 0 : tracing::info!("Inserted shard {} in memory", attach_req.tenant_shard_id);
1746 : }
1747 : }
1748 0 : }
1749 :
1750 0 : let new_generation = if let Some(req_node_id) = attach_req.node_id {
1751 0 : let maybe_tenant_conf = {
1752 0 : let locked = self.inner.write().unwrap();
1753 0 : locked
1754 0 : .tenants
1755 0 : .get(&attach_req.tenant_shard_id)
1756 0 : .map(|t| t.config.clone())
1757 0 : };
1758 0 :
1759 0 : match maybe_tenant_conf {
1760 0 : Some(conf) => {
1761 0 : let new_generation = self
1762 0 : .persistence
1763 0 : .increment_generation(attach_req.tenant_shard_id, req_node_id)
1764 0 : .await?;
1765 :
1766 : // Persist the placement policy update. This is required
1767 : // when we reattaching a detached tenant.
1768 0 : self.persistence
1769 0 : .update_tenant_shard(
1770 0 : TenantFilter::Shard(attach_req.tenant_shard_id),
1771 0 : Some(PlacementPolicy::Attached(0)),
1772 0 : Some(conf),
1773 0 : None,
1774 0 : None,
1775 0 : )
1776 0 : .await?;
1777 0 : Some(new_generation)
1778 : }
1779 : None => {
1780 0 : anyhow::bail!("Attach hook handling raced with tenant removal")
1781 : }
1782 : }
1783 : } else {
1784 0 : self.persistence.detach(attach_req.tenant_shard_id).await?;
1785 0 : None
1786 : };
1787 :
1788 0 : let mut locked = self.inner.write().unwrap();
1789 0 : let (_nodes, tenants, scheduler) = locked.parts_mut();
1790 0 :
1791 0 : let tenant_shard = tenants
1792 0 : .get_mut(&attach_req.tenant_shard_id)
1793 0 : .expect("Checked for existence above");
1794 :
1795 0 : if let Some(new_generation) = new_generation {
1796 0 : tenant_shard.generation = Some(new_generation);
1797 0 : tenant_shard.policy = PlacementPolicy::Attached(0);
1798 0 : } else {
1799 : // This is a detach notification. We must update placement policy to avoid re-attaching
1800 : // during background scheduling/reconciliation, or during storage controller restart.
1801 0 : assert!(attach_req.node_id.is_none());
1802 0 : tenant_shard.policy = PlacementPolicy::Detached;
1803 : }
1804 :
1805 0 : if let Some(attaching_pageserver) = attach_req.node_id.as_ref() {
1806 0 : tracing::info!(
1807 : tenant_id = %attach_req.tenant_shard_id,
1808 : ps_id = %attaching_pageserver,
1809 : generation = ?tenant_shard.generation,
1810 0 : "issuing",
1811 : );
1812 0 : } else if let Some(ps_id) = tenant_shard.intent.get_attached() {
1813 0 : tracing::info!(
1814 : tenant_id = %attach_req.tenant_shard_id,
1815 : %ps_id,
1816 : generation = ?tenant_shard.generation,
1817 0 : "dropping",
1818 : );
1819 : } else {
1820 0 : tracing::info!(
1821 : tenant_id = %attach_req.tenant_shard_id,
1822 0 : "no-op: tenant already has no pageserver");
1823 : }
1824 0 : tenant_shard
1825 0 : .intent
1826 0 : .set_attached(scheduler, attach_req.node_id);
1827 0 :
1828 0 : tracing::info!(
1829 0 : "attach_hook: tenant {} set generation {:?}, pageserver {}",
1830 0 : attach_req.tenant_shard_id,
1831 0 : tenant_shard.generation,
1832 0 : // TODO: this is an odd number of 0xf's
1833 0 : attach_req.node_id.unwrap_or(utils::id::NodeId(0xfffffff))
1834 : );
1835 :
1836 : // Trick the reconciler into not doing anything for this tenant: this helps
1837 : // tests that manually configure a tenant on the pagesrever, and then call this
1838 : // attach hook: they don't want background reconciliation to modify what they
1839 : // did to the pageserver.
1840 : #[cfg(feature = "testing")]
1841 : {
1842 0 : if let Some(node_id) = attach_req.node_id {
1843 0 : tenant_shard.observed.locations = HashMap::from([(
1844 0 : node_id,
1845 0 : ObservedStateLocation {
1846 0 : conf: Some(attached_location_conf(
1847 0 : tenant_shard.generation.unwrap(),
1848 0 : &tenant_shard.shard,
1849 0 : &tenant_shard.config,
1850 0 : &PlacementPolicy::Attached(0),
1851 0 : )),
1852 0 : },
1853 0 : )]);
1854 0 : } else {
1855 0 : tenant_shard.observed.locations.clear();
1856 0 : }
1857 : }
1858 :
1859 0 : Ok(AttachHookResponse {
1860 0 : gen: attach_req
1861 0 : .node_id
1862 0 : .map(|_| tenant_shard.generation.expect("Test hook, not used on tenants that are mid-onboarding with a NULL generation").into().unwrap()),
1863 0 : })
1864 0 : }
1865 :
1866 0 : pub(crate) fn inspect(&self, inspect_req: InspectRequest) -> InspectResponse {
1867 0 : let locked = self.inner.read().unwrap();
1868 0 :
1869 0 : let tenant_shard = locked.tenants.get(&inspect_req.tenant_shard_id);
1870 0 :
1871 0 : InspectResponse {
1872 0 : attachment: tenant_shard.and_then(|s| {
1873 0 : s.intent
1874 0 : .get_attached()
1875 0 : .map(|ps| (s.generation.expect("Test hook, not used on tenants that are mid-onboarding with a NULL generation").into().unwrap(), ps))
1876 0 : }),
1877 0 : }
1878 0 : }
1879 :
1880 : // When the availability state of a node transitions to active, we must do a full reconciliation
1881 : // of LocationConfigs on that node. This is because while a node was offline:
1882 : // - we might have proceeded through startup_reconcile without checking for extraneous LocationConfigs on this node
1883 : // - aborting a tenant shard split might have left rogue child shards behind on this node.
1884 : //
1885 : // This function must complete _before_ setting a `Node` to Active: once it is set to Active, other
1886 : // Reconcilers might communicate with the node, and these must not overlap with the work we do in
1887 : // this function.
1888 : //
1889 : // The reconciliation logic in here is very similar to what [`Self::startup_reconcile`] does, but
1890 : // for written for a single node rather than as a batch job for all nodes.
1891 : #[tracing::instrument(skip_all, fields(node_id=%node.get_id()))]
1892 : async fn node_activate_reconcile(
1893 : &self,
1894 : mut node: Node,
1895 : _lock: &TracingExclusiveGuard<NodeOperations>,
1896 : ) -> Result<(), ApiError> {
1897 : // This Node is a mutable local copy: we will set it active so that we can use its
1898 : // API client to reconcile with the node. The Node in [`Self::nodes`] will get updated
1899 : // later.
1900 : node.set_availability(NodeAvailability::Active(PageserverUtilization::full()));
1901 :
1902 : let configs = match node
1903 : .with_client_retries(
1904 0 : |client| async move { client.list_location_config().await },
1905 : &self.config.jwt_token,
1906 : 1,
1907 : 5,
1908 : SHORT_RECONCILE_TIMEOUT,
1909 : &self.cancel,
1910 : )
1911 : .await
1912 : {
1913 : None => {
1914 : // We're shutting down (the Node's cancellation token can't have fired, because
1915 : // we're the only scope that has a reference to it, and we didn't fire it).
1916 : return Err(ApiError::ShuttingDown);
1917 : }
1918 : Some(Err(e)) => {
1919 : // This node didn't succeed listing its locations: it may not proceed to active state
1920 : // as it is apparently unavailable.
1921 : return Err(ApiError::PreconditionFailed(
1922 : format!("Failed to query node location configs, cannot activate ({e})").into(),
1923 : ));
1924 : }
1925 : Some(Ok(configs)) => configs,
1926 : };
1927 : tracing::info!("Loaded {} LocationConfigs", configs.tenant_shards.len());
1928 :
1929 : let mut cleanup = Vec::new();
1930 : {
1931 : let mut locked = self.inner.write().unwrap();
1932 :
1933 : for (tenant_shard_id, observed_loc) in configs.tenant_shards {
1934 : let Some(tenant_shard) = locked.tenants.get_mut(&tenant_shard_id) else {
1935 : cleanup.push(tenant_shard_id);
1936 : continue;
1937 : };
1938 : tenant_shard
1939 : .observed
1940 : .locations
1941 : .insert(node.get_id(), ObservedStateLocation { conf: observed_loc });
1942 : }
1943 : }
1944 :
1945 : for tenant_shard_id in cleanup {
1946 : tracing::info!("Detaching {tenant_shard_id}");
1947 : match node
1948 : .with_client_retries(
1949 0 : |client| async move {
1950 0 : let config = LocationConfig {
1951 0 : mode: LocationConfigMode::Detached,
1952 0 : generation: None,
1953 0 : secondary_conf: None,
1954 0 : shard_number: tenant_shard_id.shard_number.0,
1955 0 : shard_count: tenant_shard_id.shard_count.literal(),
1956 0 : shard_stripe_size: 0,
1957 0 : tenant_conf: models::TenantConfig::default(),
1958 0 : };
1959 0 : client
1960 0 : .location_config(tenant_shard_id, config, None, false)
1961 0 : .await
1962 0 : },
1963 : &self.config.jwt_token,
1964 : 1,
1965 : 5,
1966 : SHORT_RECONCILE_TIMEOUT,
1967 : &self.cancel,
1968 : )
1969 : .await
1970 : {
1971 : None => {
1972 : // We're shutting down (the Node's cancellation token can't have fired, because
1973 : // we're the only scope that has a reference to it, and we didn't fire it).
1974 : return Err(ApiError::ShuttingDown);
1975 : }
1976 : Some(Err(e)) => {
1977 : // Do not let the node proceed to Active state if it is not responsive to requests
1978 : // to detach. This could happen if e.g. a shutdown bug in the pageserver is preventing
1979 : // detach completing: we should not let this node back into the set of nodes considered
1980 : // okay for scheduling.
1981 : return Err(ApiError::Conflict(format!(
1982 : "Node {node} failed to detach {tenant_shard_id}: {e}"
1983 : )));
1984 : }
1985 : Some(Ok(_)) => {}
1986 : };
1987 : }
1988 :
1989 : Ok(())
1990 : }
1991 :
1992 0 : pub(crate) async fn re_attach(
1993 0 : &self,
1994 0 : reattach_req: ReAttachRequest,
1995 0 : ) -> Result<ReAttachResponse, ApiError> {
1996 0 : if let Some(register_req) = reattach_req.register {
1997 0 : self.node_register(register_req).await?;
1998 0 : }
1999 :
2000 : // Ordering: we must persist generation number updates before making them visible in the in-memory state
2001 0 : let incremented_generations = self.persistence.re_attach(reattach_req.node_id).await?;
2002 :
2003 0 : tracing::info!(
2004 : node_id=%reattach_req.node_id,
2005 0 : "Incremented {} tenant shards' generations",
2006 0 : incremented_generations.len()
2007 : );
2008 :
2009 : // Apply the updated generation to our in-memory state, and
2010 : // gather discover secondary locations.
2011 0 : let mut locked = self.inner.write().unwrap();
2012 0 : let (nodes, tenants, scheduler) = locked.parts_mut();
2013 0 :
2014 0 : let mut response = ReAttachResponse {
2015 0 : tenants: Vec::new(),
2016 0 : };
2017 :
2018 : // TODO: cancel/restart any running reconciliation for this tenant, it might be trying
2019 : // to call location_conf API with an old generation. Wait for cancellation to complete
2020 : // before responding to this request. Requires well implemented CancellationToken logic
2021 : // all the way to where we call location_conf. Even then, there can still be a location_conf
2022 : // request in flight over the network: TODO handle that by making location_conf API refuse
2023 : // to go backward in generations.
2024 :
2025 : // Scan through all shards, applying updates for ones where we updated generation
2026 : // and identifying shards that intend to have a secondary location on this node.
2027 0 : for (tenant_shard_id, shard) in tenants {
2028 0 : if let Some(new_gen) = incremented_generations.get(tenant_shard_id) {
2029 0 : let new_gen = *new_gen;
2030 0 : response.tenants.push(ReAttachResponseTenant {
2031 0 : id: *tenant_shard_id,
2032 0 : gen: Some(new_gen.into().unwrap()),
2033 0 : // A tenant is only put into multi or stale modes in the middle of a [`Reconciler::live_migrate`]
2034 0 : // execution. If a pageserver is restarted during that process, then the reconcile pass will
2035 0 : // fail, and start from scratch, so it doesn't make sense for us to try and preserve
2036 0 : // the stale/multi states at this point.
2037 0 : mode: LocationConfigMode::AttachedSingle,
2038 0 : });
2039 0 :
2040 0 : shard.generation = std::cmp::max(shard.generation, Some(new_gen));
2041 0 : if let Some(observed) = shard.observed.locations.get_mut(&reattach_req.node_id) {
2042 : // Why can we update `observed` even though we're not sure our response will be received
2043 : // by the pageserver? Because the pageserver will not proceed with startup until
2044 : // it has processed response: if it loses it, we'll see another request and increment
2045 : // generation again, avoiding any uncertainty about dirtiness of tenant's state.
2046 0 : if let Some(conf) = observed.conf.as_mut() {
2047 0 : conf.generation = new_gen.into();
2048 0 : }
2049 0 : } else {
2050 0 : // This node has no observed state for the shard: perhaps it was offline
2051 0 : // when the pageserver restarted. Insert a None, so that the Reconciler
2052 0 : // will be prompted to learn the location's state before it makes changes.
2053 0 : shard
2054 0 : .observed
2055 0 : .locations
2056 0 : .insert(reattach_req.node_id, ObservedStateLocation { conf: None });
2057 0 : }
2058 0 : } else if shard.intent.get_secondary().contains(&reattach_req.node_id) {
2059 0 : // Ordering: pageserver will not accept /location_config requests until it has
2060 0 : // finished processing the response from re-attach. So we can update our in-memory state
2061 0 : // now, and be confident that we are not stamping on the result of some later location config.
2062 0 : // TODO: however, we are not strictly ordered wrt ReconcileResults queue,
2063 0 : // so we might update observed state here, and then get over-written by some racing
2064 0 : // ReconcileResult. The impact is low however, since we have set state on pageserver something
2065 0 : // that matches intent, so worst case if we race then we end up doing a spurious reconcile.
2066 0 :
2067 0 : response.tenants.push(ReAttachResponseTenant {
2068 0 : id: *tenant_shard_id,
2069 0 : gen: None,
2070 0 : mode: LocationConfigMode::Secondary,
2071 0 : });
2072 0 :
2073 0 : // We must not update observed, because we have no guarantee that our
2074 0 : // response will be received by the pageserver. This could leave it
2075 0 : // falsely dirty, but the resulting reconcile should be idempotent.
2076 0 : }
2077 : }
2078 :
2079 : // We consider a node Active once we have composed a re-attach response, but we
2080 : // do not call [`Self::node_activate_reconcile`]: the handling of the re-attach response
2081 : // implicitly synchronizes the LocationConfigs on the node.
2082 : //
2083 : // Setting a node active unblocks any Reconcilers that might write to the location config API,
2084 : // but those requests will not be accepted by the node until it has finished processing
2085 : // the re-attach response.
2086 : //
2087 : // Additionally, reset the nodes scheduling policy to match the conditional update done
2088 : // in [`Persistence::re_attach`].
2089 0 : if let Some(node) = nodes.get(&reattach_req.node_id) {
2090 0 : let reset_scheduling = matches!(
2091 0 : node.get_scheduling(),
2092 : NodeSchedulingPolicy::PauseForRestart
2093 : | NodeSchedulingPolicy::Draining
2094 : | NodeSchedulingPolicy::Filling
2095 : );
2096 :
2097 0 : let mut new_nodes = (**nodes).clone();
2098 0 : if let Some(node) = new_nodes.get_mut(&reattach_req.node_id) {
2099 0 : if reset_scheduling {
2100 0 : node.set_scheduling(NodeSchedulingPolicy::Active);
2101 0 : }
2102 :
2103 0 : tracing::info!("Marking {} warming-up on reattach", reattach_req.node_id);
2104 0 : node.set_availability(NodeAvailability::WarmingUp(std::time::Instant::now()));
2105 0 :
2106 0 : scheduler.node_upsert(node);
2107 0 : let new_nodes = Arc::new(new_nodes);
2108 0 : *nodes = new_nodes;
2109 : } else {
2110 0 : tracing::error!(
2111 0 : "Reattaching node {} was removed while processing the request",
2112 : reattach_req.node_id
2113 : );
2114 : }
2115 0 : }
2116 :
2117 0 : Ok(response)
2118 0 : }
2119 :
2120 0 : pub(crate) async fn validate(
2121 0 : &self,
2122 0 : validate_req: ValidateRequest,
2123 0 : ) -> Result<ValidateResponse, DatabaseError> {
2124 : // Fast in-memory check: we may reject validation on anything that doesn't match our
2125 : // in-memory generation for a shard
2126 0 : let in_memory_result = {
2127 0 : let mut in_memory_result = Vec::new();
2128 0 : let locked = self.inner.read().unwrap();
2129 0 : for req_tenant in validate_req.tenants {
2130 0 : if let Some(tenant_shard) = locked.tenants.get(&req_tenant.id) {
2131 0 : let valid = tenant_shard.generation == Some(Generation::new(req_tenant.gen));
2132 0 : tracing::info!(
2133 0 : "handle_validate: {}(gen {}): valid={valid} (latest {:?})",
2134 : req_tenant.id,
2135 : req_tenant.gen,
2136 : tenant_shard.generation
2137 : );
2138 :
2139 0 : in_memory_result.push((req_tenant.id, Generation::new(req_tenant.gen), valid));
2140 : } else {
2141 : // This is legal: for example during a shard split the pageserver may still
2142 : // have deletions in its queue from the old pre-split shard, or after deletion
2143 : // of a tenant that was busy with compaction/gc while being deleted.
2144 0 : tracing::info!(
2145 0 : "Refusing deletion validation for missing shard {}",
2146 : req_tenant.id
2147 : );
2148 : }
2149 : }
2150 :
2151 0 : in_memory_result
2152 : };
2153 :
2154 : // Database calls to confirm validity for anything that passed the in-memory check. We must do this
2155 : // in case of controller split-brain, where some other controller process might have incremented the generation.
2156 0 : let db_generations = self
2157 0 : .persistence
2158 0 : .shard_generations(in_memory_result.iter().filter_map(|i| {
2159 0 : if i.2 {
2160 0 : Some(&i.0)
2161 : } else {
2162 0 : None
2163 : }
2164 0 : }))
2165 0 : .await?;
2166 0 : let db_generations = db_generations.into_iter().collect::<HashMap<_, _>>();
2167 0 :
2168 0 : let mut response = ValidateResponse {
2169 0 : tenants: Vec::new(),
2170 0 : };
2171 0 : for (tenant_shard_id, validate_generation, valid) in in_memory_result.into_iter() {
2172 0 : let valid = if valid {
2173 0 : let db_generation = db_generations.get(&tenant_shard_id);
2174 0 : db_generation == Some(&Some(validate_generation))
2175 : } else {
2176 : // If in-memory state says it's invalid, trust that. It's always safe to fail a validation, at worst
2177 : // this prevents a pageserver from cleaning up an object in S3.
2178 0 : false
2179 : };
2180 :
2181 0 : response.tenants.push(ValidateResponseTenant {
2182 0 : id: tenant_shard_id,
2183 0 : valid,
2184 0 : })
2185 : }
2186 :
2187 0 : Ok(response)
2188 0 : }
2189 :
2190 0 : pub(crate) async fn tenant_create(
2191 0 : &self,
2192 0 : create_req: TenantCreateRequest,
2193 0 : ) -> Result<TenantCreateResponse, ApiError> {
2194 0 : let tenant_id = create_req.new_tenant_id.tenant_id;
2195 :
2196 : // Exclude any concurrent attempts to create/access the same tenant ID
2197 0 : let _tenant_lock = trace_exclusive_lock(
2198 0 : &self.tenant_op_locks,
2199 0 : create_req.new_tenant_id.tenant_id,
2200 0 : TenantOperations::Create,
2201 0 : )
2202 0 : .await;
2203 0 : let (response, waiters) = self.do_tenant_create(create_req).await?;
2204 :
2205 0 : if let Err(e) = self.await_waiters(waiters, RECONCILE_TIMEOUT).await {
2206 : // Avoid deadlock: reconcile may fail while notifying compute, if the cloud control plane refuses to
2207 : // accept compute notifications while it is in the process of creating. Reconciliation will
2208 : // be retried in the background.
2209 0 : tracing::warn!(%tenant_id, "Reconcile not done yet while creating tenant ({e})");
2210 0 : }
2211 0 : Ok(response)
2212 0 : }
2213 :
2214 0 : pub(crate) async fn do_tenant_create(
2215 0 : &self,
2216 0 : create_req: TenantCreateRequest,
2217 0 : ) -> Result<(TenantCreateResponse, Vec<ReconcilerWaiter>), ApiError> {
2218 0 : let placement_policy = create_req
2219 0 : .placement_policy
2220 0 : .clone()
2221 0 : // As a default, zero secondaries is convenient for tests that don't choose a policy.
2222 0 : .unwrap_or(PlacementPolicy::Attached(0));
2223 :
2224 : // This service expects to handle sharding itself: it is an error to try and directly create
2225 : // a particular shard here.
2226 0 : let tenant_id = if !create_req.new_tenant_id.is_unsharded() {
2227 0 : return Err(ApiError::BadRequest(anyhow::anyhow!(
2228 0 : "Attempted to create a specific shard, this API is for creating the whole tenant"
2229 0 : )));
2230 : } else {
2231 0 : create_req.new_tenant_id.tenant_id
2232 0 : };
2233 0 :
2234 0 : tracing::info!(
2235 0 : "Creating tenant {}, shard_count={:?}",
2236 : create_req.new_tenant_id,
2237 : create_req.shard_parameters.count,
2238 : );
2239 :
2240 0 : let create_ids = (0..create_req.shard_parameters.count.count())
2241 0 : .map(|i| TenantShardId {
2242 0 : tenant_id,
2243 0 : shard_number: ShardNumber(i),
2244 0 : shard_count: create_req.shard_parameters.count,
2245 0 : })
2246 0 : .collect::<Vec<_>>();
2247 :
2248 : // If the caller specifies a None generation, it means "start from default". This is different
2249 : // to [`Self::tenant_location_config`], where a None generation is used to represent
2250 : // an incompletely-onboarded tenant.
2251 0 : let initial_generation = if matches!(placement_policy, PlacementPolicy::Secondary) {
2252 0 : tracing::info!(
2253 0 : "tenant_create: secondary mode, generation is_some={}",
2254 0 : create_req.generation.is_some()
2255 : );
2256 0 : create_req.generation.map(Generation::new)
2257 : } else {
2258 0 : tracing::info!(
2259 0 : "tenant_create: not secondary mode, generation is_some={}",
2260 0 : create_req.generation.is_some()
2261 : );
2262 0 : Some(
2263 0 : create_req
2264 0 : .generation
2265 0 : .map(Generation::new)
2266 0 : .unwrap_or(INITIAL_GENERATION),
2267 0 : )
2268 : };
2269 :
2270 0 : let preferred_az_id = {
2271 0 : let locked = self.inner.read().unwrap();
2272 : // Idempotency: take the existing value if the tenant already exists
2273 0 : if let Some(shard) = locked.tenants.get(create_ids.first().unwrap()) {
2274 0 : shard.preferred_az().cloned()
2275 : } else {
2276 0 : locked.scheduler.get_az_for_new_tenant()
2277 : }
2278 : };
2279 :
2280 : // Ordering: we persist tenant shards before creating them on the pageserver. This enables a caller
2281 : // to clean up after themselves by issuing a tenant deletion if something goes wrong and we restart
2282 : // during the creation, rather than risking leaving orphan objects in S3.
2283 0 : let persist_tenant_shards = create_ids
2284 0 : .iter()
2285 0 : .map(|tenant_shard_id| TenantShardPersistence {
2286 0 : tenant_id: tenant_shard_id.tenant_id.to_string(),
2287 0 : shard_number: tenant_shard_id.shard_number.0 as i32,
2288 0 : shard_count: tenant_shard_id.shard_count.literal() as i32,
2289 0 : shard_stripe_size: create_req.shard_parameters.stripe_size.0 as i32,
2290 0 : generation: initial_generation.map(|g| g.into().unwrap() as i32),
2291 0 : // The pageserver is not known until scheduling happens: we will set this column when
2292 0 : // incrementing the generation the first time we attach to a pageserver.
2293 0 : generation_pageserver: None,
2294 0 : placement_policy: serde_json::to_string(&placement_policy).unwrap(),
2295 0 : config: serde_json::to_string(&create_req.config).unwrap(),
2296 0 : splitting: SplitState::default(),
2297 0 : scheduling_policy: serde_json::to_string(&ShardSchedulingPolicy::default())
2298 0 : .unwrap(),
2299 0 : preferred_az_id: preferred_az_id.as_ref().map(|az| az.to_string()),
2300 0 : })
2301 0 : .collect();
2302 0 :
2303 0 : match self
2304 0 : .persistence
2305 0 : .insert_tenant_shards(persist_tenant_shards)
2306 0 : .await
2307 : {
2308 0 : Ok(_) => {}
2309 : Err(DatabaseError::Query(diesel::result::Error::DatabaseError(
2310 : DatabaseErrorKind::UniqueViolation,
2311 : _,
2312 : ))) => {
2313 : // Unique key violation: this is probably a retry. Because the shard count is part of the unique key,
2314 : // if we see a unique key violation it means that the creation request's shard count matches the previous
2315 : // creation's shard count.
2316 0 : tracing::info!("Tenant shards already present in database, proceeding with idempotent creation...");
2317 : }
2318 : // Any other database error is unexpected and a bug.
2319 0 : Err(e) => return Err(ApiError::InternalServerError(anyhow::anyhow!(e))),
2320 : };
2321 :
2322 0 : let mut schedule_context = ScheduleContext::default();
2323 0 : let mut schedule_error = None;
2324 0 : let mut response_shards = Vec::new();
2325 0 : for tenant_shard_id in create_ids {
2326 0 : tracing::info!("Creating shard {tenant_shard_id}...");
2327 :
2328 0 : let outcome = self
2329 0 : .do_initial_shard_scheduling(
2330 0 : tenant_shard_id,
2331 0 : initial_generation,
2332 0 : &create_req.shard_parameters,
2333 0 : create_req.config.clone(),
2334 0 : placement_policy.clone(),
2335 0 : preferred_az_id.as_ref(),
2336 0 : &mut schedule_context,
2337 0 : )
2338 0 : .await;
2339 :
2340 0 : match outcome {
2341 0 : InitialShardScheduleOutcome::Scheduled(resp) => response_shards.push(resp),
2342 0 : InitialShardScheduleOutcome::NotScheduled => {}
2343 0 : InitialShardScheduleOutcome::ShardScheduleError(err) => {
2344 0 : schedule_error = Some(err);
2345 0 : }
2346 : }
2347 : }
2348 :
2349 : // If we failed to schedule shards, then they are still created in the controller,
2350 : // but we return an error to the requester to avoid a silent failure when someone
2351 : // tries to e.g. create a tenant whose placement policy requires more nodes than
2352 : // are present in the system. We do this here rather than in the above loop, to
2353 : // avoid situations where we only create a subset of shards in the tenant.
2354 0 : if let Some(e) = schedule_error {
2355 0 : return Err(ApiError::Conflict(format!(
2356 0 : "Failed to schedule shard(s): {e}"
2357 0 : )));
2358 0 : }
2359 0 :
2360 0 : let waiters = {
2361 0 : let mut locked = self.inner.write().unwrap();
2362 0 : let (nodes, tenants, _scheduler) = locked.parts_mut();
2363 0 : let config = ReconcilerConfigBuilder::new(ReconcilerPriority::High)
2364 0 : .tenant_creation_hint(true)
2365 0 : .build();
2366 0 : tenants
2367 0 : .range_mut(TenantShardId::tenant_range(tenant_id))
2368 0 : .filter_map(|(_shard_id, shard)| {
2369 0 : self.maybe_configured_reconcile_shard(shard, nodes, config)
2370 0 : })
2371 0 : .collect::<Vec<_>>()
2372 0 : };
2373 0 :
2374 0 : Ok((
2375 0 : TenantCreateResponse {
2376 0 : shards: response_shards,
2377 0 : },
2378 0 : waiters,
2379 0 : ))
2380 0 : }
2381 :
2382 : /// Helper for tenant creation that does the scheduling for an individual shard. Covers both the
2383 : /// case of a new tenant and a pre-existing one.
2384 : #[allow(clippy::too_many_arguments)]
2385 0 : async fn do_initial_shard_scheduling(
2386 0 : &self,
2387 0 : tenant_shard_id: TenantShardId,
2388 0 : initial_generation: Option<Generation>,
2389 0 : shard_params: &ShardParameters,
2390 0 : config: TenantConfig,
2391 0 : placement_policy: PlacementPolicy,
2392 0 : preferred_az_id: Option<&AvailabilityZone>,
2393 0 : schedule_context: &mut ScheduleContext,
2394 0 : ) -> InitialShardScheduleOutcome {
2395 0 : let mut locked = self.inner.write().unwrap();
2396 0 : let (_nodes, tenants, scheduler) = locked.parts_mut();
2397 :
2398 : use std::collections::btree_map::Entry;
2399 0 : match tenants.entry(tenant_shard_id) {
2400 0 : Entry::Occupied(mut entry) => {
2401 0 : tracing::info!("Tenant shard {tenant_shard_id} already exists while creating");
2402 :
2403 0 : if let Err(err) = entry.get_mut().schedule(scheduler, schedule_context) {
2404 0 : return InitialShardScheduleOutcome::ShardScheduleError(err);
2405 0 : }
2406 :
2407 0 : if let Some(node_id) = entry.get().intent.get_attached() {
2408 0 : let generation = entry
2409 0 : .get()
2410 0 : .generation
2411 0 : .expect("Generation is set when in attached mode");
2412 0 : InitialShardScheduleOutcome::Scheduled(TenantCreateResponseShard {
2413 0 : shard_id: tenant_shard_id,
2414 0 : node_id: *node_id,
2415 0 : generation: generation.into().unwrap(),
2416 0 : })
2417 : } else {
2418 0 : InitialShardScheduleOutcome::NotScheduled
2419 : }
2420 : }
2421 0 : Entry::Vacant(entry) => {
2422 0 : let state = entry.insert(TenantShard::new(
2423 0 : tenant_shard_id,
2424 0 : ShardIdentity::from_params(tenant_shard_id.shard_number, shard_params),
2425 0 : placement_policy,
2426 0 : preferred_az_id.cloned(),
2427 0 : ));
2428 0 :
2429 0 : state.generation = initial_generation;
2430 0 : state.config = config;
2431 0 : if let Err(e) = state.schedule(scheduler, schedule_context) {
2432 0 : return InitialShardScheduleOutcome::ShardScheduleError(e);
2433 0 : }
2434 :
2435 : // Only include shards in result if we are attaching: the purpose
2436 : // of the response is to tell the caller where the shards are attached.
2437 0 : if let Some(node_id) = state.intent.get_attached() {
2438 0 : let generation = state
2439 0 : .generation
2440 0 : .expect("Generation is set when in attached mode");
2441 0 : InitialShardScheduleOutcome::Scheduled(TenantCreateResponseShard {
2442 0 : shard_id: tenant_shard_id,
2443 0 : node_id: *node_id,
2444 0 : generation: generation.into().unwrap(),
2445 0 : })
2446 : } else {
2447 0 : InitialShardScheduleOutcome::NotScheduled
2448 : }
2449 : }
2450 : }
2451 0 : }
2452 :
2453 : /// Helper for functions that reconcile a number of shards, and would like to do a timeout-bounded
2454 : /// wait for reconciliation to complete before responding.
2455 0 : async fn await_waiters(
2456 0 : &self,
2457 0 : waiters: Vec<ReconcilerWaiter>,
2458 0 : timeout: Duration,
2459 0 : ) -> Result<(), ReconcileWaitError> {
2460 0 : let deadline = Instant::now().checked_add(timeout).unwrap();
2461 0 : for waiter in waiters {
2462 0 : let timeout = deadline.duration_since(Instant::now());
2463 0 : waiter.wait_timeout(timeout).await?;
2464 : }
2465 :
2466 0 : Ok(())
2467 0 : }
2468 :
2469 : /// Same as [`Service::await_waiters`], but returns the waiters which are still
2470 : /// in progress
2471 0 : async fn await_waiters_remainder(
2472 0 : &self,
2473 0 : waiters: Vec<ReconcilerWaiter>,
2474 0 : timeout: Duration,
2475 0 : ) -> Vec<ReconcilerWaiter> {
2476 0 : let deadline = Instant::now().checked_add(timeout).unwrap();
2477 0 : for waiter in waiters.iter() {
2478 0 : let timeout = deadline.duration_since(Instant::now());
2479 0 : let _ = waiter.wait_timeout(timeout).await;
2480 : }
2481 :
2482 0 : waiters
2483 0 : .into_iter()
2484 0 : .filter(|waiter| matches!(waiter.get_status(), ReconcilerStatus::InProgress))
2485 0 : .collect::<Vec<_>>()
2486 0 : }
2487 :
2488 : /// Part of [`Self::tenant_location_config`]: dissect an incoming location config request,
2489 : /// and transform it into either a tenant creation of a series of shard updates.
2490 : ///
2491 : /// If the incoming request makes no changes, a [`TenantCreateOrUpdate::Update`] result will
2492 : /// still be returned.
2493 0 : fn tenant_location_config_prepare(
2494 0 : &self,
2495 0 : tenant_id: TenantId,
2496 0 : req: TenantLocationConfigRequest,
2497 0 : ) -> TenantCreateOrUpdate {
2498 0 : let mut updates = Vec::new();
2499 0 : let mut locked = self.inner.write().unwrap();
2500 0 : let (nodes, tenants, _scheduler) = locked.parts_mut();
2501 0 : let tenant_shard_id = TenantShardId::unsharded(tenant_id);
2502 :
2503 : // Use location config mode as an indicator of policy.
2504 0 : let placement_policy = match req.config.mode {
2505 0 : LocationConfigMode::Detached => PlacementPolicy::Detached,
2506 0 : LocationConfigMode::Secondary => PlacementPolicy::Secondary,
2507 : LocationConfigMode::AttachedMulti
2508 : | LocationConfigMode::AttachedSingle
2509 : | LocationConfigMode::AttachedStale => {
2510 0 : if nodes.len() > 1 {
2511 0 : PlacementPolicy::Attached(1)
2512 : } else {
2513 : // Convenience for dev/test: if we just have one pageserver, import
2514 : // tenants into non-HA mode so that scheduling will succeed.
2515 0 : PlacementPolicy::Attached(0)
2516 : }
2517 : }
2518 : };
2519 :
2520 : // Ordinarily we do not update scheduling policy, but when making major changes
2521 : // like detaching or demoting to secondary-only, we need to force the scheduling
2522 : // mode to Active, or the caller's expected outcome (detach it) will not happen.
2523 0 : let scheduling_policy = match req.config.mode {
2524 : LocationConfigMode::Detached | LocationConfigMode::Secondary => {
2525 : // Special case: when making major changes like detaching or demoting to secondary-only,
2526 : // we need to force the scheduling mode to Active, or nothing will happen.
2527 0 : Some(ShardSchedulingPolicy::Active)
2528 : }
2529 : LocationConfigMode::AttachedMulti
2530 : | LocationConfigMode::AttachedSingle
2531 : | LocationConfigMode::AttachedStale => {
2532 : // While attached, continue to respect whatever the existing scheduling mode is.
2533 0 : None
2534 : }
2535 : };
2536 :
2537 0 : let mut create = true;
2538 0 : for (shard_id, shard) in tenants.range_mut(TenantShardId::tenant_range(tenant_id)) {
2539 : // Saw an existing shard: this is not a creation
2540 0 : create = false;
2541 :
2542 : // Shards may have initially been created by a Secondary request, where we
2543 : // would have left generation as None.
2544 : //
2545 : // We only update generation the first time we see an attached-mode request,
2546 : // and if there is no existing generation set. The caller is responsible for
2547 : // ensuring that no non-storage-controller pageserver ever uses a higher
2548 : // generation than they passed in here.
2549 : use LocationConfigMode::*;
2550 0 : let set_generation = match req.config.mode {
2551 0 : AttachedMulti | AttachedSingle | AttachedStale if shard.generation.is_none() => {
2552 0 : req.config.generation.map(Generation::new)
2553 : }
2554 0 : _ => None,
2555 : };
2556 :
2557 0 : updates.push(ShardUpdate {
2558 0 : tenant_shard_id: *shard_id,
2559 0 : placement_policy: placement_policy.clone(),
2560 0 : tenant_config: req.config.tenant_conf.clone(),
2561 0 : generation: set_generation,
2562 0 : scheduling_policy,
2563 0 : });
2564 : }
2565 :
2566 0 : if create {
2567 : use LocationConfigMode::*;
2568 0 : let generation = match req.config.mode {
2569 0 : AttachedMulti | AttachedSingle | AttachedStale => req.config.generation,
2570 : // If a caller provided a generation in a non-attached request, ignore it
2571 : // and leave our generation as None: this enables a subsequent update to set
2572 : // the generation when setting an attached mode for the first time.
2573 0 : _ => None,
2574 : };
2575 :
2576 0 : TenantCreateOrUpdate::Create(
2577 0 : // Synthesize a creation request
2578 0 : TenantCreateRequest {
2579 0 : new_tenant_id: tenant_shard_id,
2580 0 : generation,
2581 0 : shard_parameters: ShardParameters {
2582 0 : count: tenant_shard_id.shard_count,
2583 0 : // We only import un-sharded or single-sharded tenants, so stripe
2584 0 : // size can be made up arbitrarily here.
2585 0 : stripe_size: ShardParameters::DEFAULT_STRIPE_SIZE,
2586 0 : },
2587 0 : placement_policy: Some(placement_policy),
2588 0 : config: req.config.tenant_conf,
2589 0 : },
2590 0 : )
2591 : } else {
2592 0 : assert!(!updates.is_empty());
2593 0 : TenantCreateOrUpdate::Update(updates)
2594 : }
2595 0 : }
2596 :
2597 : /// For APIs that might act on tenants with [`PlacementPolicy::Detached`], first check if
2598 : /// the tenant is present in memory. If not, load it from the database. If it is found
2599 : /// in neither location, return a NotFound error.
2600 : ///
2601 : /// Caller must demonstrate they hold a lock guard, as otherwise two callers might try and load
2602 : /// it at the same time, or we might race with [`Self::maybe_drop_tenant`]
2603 0 : async fn maybe_load_tenant(
2604 0 : &self,
2605 0 : tenant_id: TenantId,
2606 0 : _guard: &TracingExclusiveGuard<TenantOperations>,
2607 0 : ) -> Result<(), ApiError> {
2608 : // Check if the tenant is present in memory, and select an AZ to use when loading
2609 : // if we will load it.
2610 0 : let load_in_az = {
2611 0 : let locked = self.inner.read().unwrap();
2612 0 : let existing = locked
2613 0 : .tenants
2614 0 : .range(TenantShardId::tenant_range(tenant_id))
2615 0 : .next();
2616 0 :
2617 0 : // If the tenant is not present in memory, we expect to load it from database,
2618 0 : // so let's figure out what AZ to load it into while we have self.inner locked.
2619 0 : if existing.is_none() {
2620 0 : locked
2621 0 : .scheduler
2622 0 : .get_az_for_new_tenant()
2623 0 : .ok_or(ApiError::BadRequest(anyhow::anyhow!(
2624 0 : "No AZ with nodes found to load tenant"
2625 0 : )))?
2626 : } else {
2627 : // We already have this tenant in memory
2628 0 : return Ok(());
2629 : }
2630 : };
2631 :
2632 0 : let tenant_shards = self.persistence.load_tenant(tenant_id).await?;
2633 0 : if tenant_shards.is_empty() {
2634 0 : return Err(ApiError::NotFound(
2635 0 : anyhow::anyhow!("Tenant {} not found", tenant_id).into(),
2636 0 : ));
2637 0 : }
2638 0 :
2639 0 : // Update the persistent shards with the AZ that we are about to apply to in-memory state
2640 0 : self.persistence
2641 0 : .set_tenant_shard_preferred_azs(
2642 0 : tenant_shards
2643 0 : .iter()
2644 0 : .map(|t| {
2645 0 : (
2646 0 : t.get_tenant_shard_id().expect("Corrupt shard in database"),
2647 0 : Some(load_in_az.clone()),
2648 0 : )
2649 0 : })
2650 0 : .collect(),
2651 0 : )
2652 0 : .await?;
2653 :
2654 0 : let mut locked = self.inner.write().unwrap();
2655 0 : tracing::info!(
2656 0 : "Loaded {} shards for tenant {}",
2657 0 : tenant_shards.len(),
2658 : tenant_id
2659 : );
2660 :
2661 0 : locked.tenants.extend(tenant_shards.into_iter().map(|p| {
2662 0 : let intent = IntentState::new(Some(load_in_az.clone()));
2663 0 : let shard =
2664 0 : TenantShard::from_persistent(p, intent).expect("Corrupt shard row in database");
2665 0 :
2666 0 : // Sanity check: when loading on-demand, we should always be loaded something Detached
2667 0 : debug_assert!(shard.policy == PlacementPolicy::Detached);
2668 0 : if shard.policy != PlacementPolicy::Detached {
2669 0 : tracing::error!(
2670 0 : "Tenant shard {} loaded on-demand, but has non-Detached policy {:?}",
2671 : shard.tenant_shard_id,
2672 : shard.policy
2673 : );
2674 0 : }
2675 :
2676 0 : (shard.tenant_shard_id, shard)
2677 0 : }));
2678 0 :
2679 0 : Ok(())
2680 0 : }
2681 :
2682 : /// If all shards for a tenant are detached, and in a fully quiescent state (no observed locations on pageservers),
2683 : /// and have no reconciler running, then we can drop the tenant from memory. It will be reloaded on-demand
2684 : /// if we are asked to attach it again (see [`Self::maybe_load_tenant`]).
2685 : ///
2686 : /// Caller must demonstrate they hold a lock guard, as otherwise it is unsafe to drop a tenant from
2687 : /// memory while some other function might assume it continues to exist while not holding the lock on Self::inner.
2688 0 : fn maybe_drop_tenant(
2689 0 : &self,
2690 0 : tenant_id: TenantId,
2691 0 : locked: &mut std::sync::RwLockWriteGuard<ServiceState>,
2692 0 : _guard: &TracingExclusiveGuard<TenantOperations>,
2693 0 : ) {
2694 0 : let mut tenant_shards = locked.tenants.range(TenantShardId::tenant_range(tenant_id));
2695 0 : if tenant_shards.all(|(_id, shard)| {
2696 0 : shard.policy == PlacementPolicy::Detached
2697 0 : && shard.reconciler.is_none()
2698 0 : && shard.observed.is_empty()
2699 0 : }) {
2700 0 : let keys = locked
2701 0 : .tenants
2702 0 : .range(TenantShardId::tenant_range(tenant_id))
2703 0 : .map(|(id, _)| id)
2704 0 : .copied()
2705 0 : .collect::<Vec<_>>();
2706 0 : for key in keys {
2707 0 : tracing::info!("Dropping detached tenant shard {} from memory", key);
2708 0 : locked.tenants.remove(&key);
2709 : }
2710 0 : }
2711 0 : }
2712 :
2713 : /// This API is used by the cloud control plane to migrate unsharded tenants that it created
2714 : /// directly with pageservers into this service.
2715 : ///
2716 : /// Cloud control plane MUST NOT continue issuing GENERATION NUMBERS for this tenant once it
2717 : /// has attempted to call this API. Failure to oblige to this rule may lead to S3 corruption.
2718 : /// Think of the first attempt to call this API as a transfer of absolute authority over the
2719 : /// tenant's source of generation numbers.
2720 : ///
2721 : /// The mode in this request coarse-grained control of tenants:
2722 : /// - Call with mode Attached* to upsert the tenant.
2723 : /// - Call with mode Secondary to either onboard a tenant without attaching it, or
2724 : /// to set an existing tenant to PolicyMode::Secondary
2725 : /// - Call with mode Detached to switch to PolicyMode::Detached
2726 0 : pub(crate) async fn tenant_location_config(
2727 0 : &self,
2728 0 : tenant_shard_id: TenantShardId,
2729 0 : req: TenantLocationConfigRequest,
2730 0 : ) -> Result<TenantLocationConfigResponse, ApiError> {
2731 : // We require an exclusive lock, because we are updating both persistent and in-memory state
2732 0 : let _tenant_lock = trace_exclusive_lock(
2733 0 : &self.tenant_op_locks,
2734 0 : tenant_shard_id.tenant_id,
2735 0 : TenantOperations::LocationConfig,
2736 0 : )
2737 0 : .await;
2738 :
2739 0 : let tenant_id = if !tenant_shard_id.is_unsharded() {
2740 0 : return Err(ApiError::BadRequest(anyhow::anyhow!(
2741 0 : "This API is for importing single-sharded or unsharded tenants"
2742 0 : )));
2743 : } else {
2744 0 : tenant_shard_id.tenant_id
2745 0 : };
2746 0 :
2747 0 : // In case we are waking up a Detached tenant
2748 0 : match self.maybe_load_tenant(tenant_id, &_tenant_lock).await {
2749 0 : Ok(()) | Err(ApiError::NotFound(_)) => {
2750 0 : // This is a creation or an update
2751 0 : }
2752 0 : Err(e) => {
2753 0 : return Err(e);
2754 : }
2755 : };
2756 :
2757 : // First check if this is a creation or an update
2758 0 : let create_or_update = self.tenant_location_config_prepare(tenant_id, req);
2759 0 :
2760 0 : let mut result = TenantLocationConfigResponse {
2761 0 : shards: Vec::new(),
2762 0 : stripe_size: None,
2763 0 : };
2764 0 : let waiters = match create_or_update {
2765 0 : TenantCreateOrUpdate::Create(create_req) => {
2766 0 : let (create_resp, waiters) = self.do_tenant_create(create_req).await?;
2767 0 : result.shards = create_resp
2768 0 : .shards
2769 0 : .into_iter()
2770 0 : .map(|s| TenantShardLocation {
2771 0 : node_id: s.node_id,
2772 0 : shard_id: s.shard_id,
2773 0 : })
2774 0 : .collect();
2775 0 : waiters
2776 : }
2777 0 : TenantCreateOrUpdate::Update(updates) => {
2778 0 : // Persist updates
2779 0 : // Ordering: write to the database before applying changes in-memory, so that
2780 0 : // we will not appear time-travel backwards on a restart.
2781 0 :
2782 0 : let mut schedule_context = ScheduleContext::default();
2783 : for ShardUpdate {
2784 0 : tenant_shard_id,
2785 0 : placement_policy,
2786 0 : tenant_config,
2787 0 : generation,
2788 0 : scheduling_policy,
2789 0 : } in &updates
2790 : {
2791 0 : self.persistence
2792 0 : .update_tenant_shard(
2793 0 : TenantFilter::Shard(*tenant_shard_id),
2794 0 : Some(placement_policy.clone()),
2795 0 : Some(tenant_config.clone()),
2796 0 : *generation,
2797 0 : *scheduling_policy,
2798 0 : )
2799 0 : .await?;
2800 : }
2801 :
2802 : // Apply updates in-memory
2803 0 : let mut waiters = Vec::new();
2804 0 : {
2805 0 : let mut locked = self.inner.write().unwrap();
2806 0 : let (nodes, tenants, scheduler) = locked.parts_mut();
2807 :
2808 : for ShardUpdate {
2809 0 : tenant_shard_id,
2810 0 : placement_policy,
2811 0 : tenant_config,
2812 0 : generation: update_generation,
2813 0 : scheduling_policy,
2814 0 : } in updates
2815 : {
2816 0 : let Some(shard) = tenants.get_mut(&tenant_shard_id) else {
2817 0 : tracing::warn!("Shard {tenant_shard_id} removed while updating");
2818 0 : continue;
2819 : };
2820 :
2821 : // Update stripe size
2822 0 : if result.stripe_size.is_none() && shard.shard.count.count() > 1 {
2823 0 : result.stripe_size = Some(shard.shard.stripe_size);
2824 0 : }
2825 :
2826 0 : shard.policy = placement_policy;
2827 0 : shard.config = tenant_config;
2828 0 : if let Some(generation) = update_generation {
2829 0 : shard.generation = Some(generation);
2830 0 : }
2831 :
2832 0 : if let Some(scheduling_policy) = scheduling_policy {
2833 0 : shard.set_scheduling_policy(scheduling_policy);
2834 0 : }
2835 :
2836 0 : shard.schedule(scheduler, &mut schedule_context)?;
2837 :
2838 0 : let maybe_waiter =
2839 0 : self.maybe_reconcile_shard(shard, nodes, ReconcilerPriority::High);
2840 0 : if let Some(waiter) = maybe_waiter {
2841 0 : waiters.push(waiter);
2842 0 : }
2843 :
2844 0 : if let Some(node_id) = shard.intent.get_attached() {
2845 0 : result.shards.push(TenantShardLocation {
2846 0 : shard_id: tenant_shard_id,
2847 0 : node_id: *node_id,
2848 0 : })
2849 0 : }
2850 : }
2851 : }
2852 0 : waiters
2853 : }
2854 : };
2855 :
2856 0 : if let Err(e) = self.await_waiters(waiters, SHORT_RECONCILE_TIMEOUT).await {
2857 : // Do not treat a reconcile error as fatal: we have already applied any requested
2858 : // Intent changes, and the reconcile can fail for external reasons like unavailable
2859 : // compute notification API. In these cases, it is important that we do not
2860 : // cause the cloud control plane to retry forever on this API.
2861 0 : tracing::warn!(
2862 0 : "Failed to reconcile after /location_config: {e}, returning success anyway"
2863 : );
2864 0 : }
2865 :
2866 : // Logging the full result is useful because it lets us cross-check what the cloud control
2867 : // plane's tenant_shards table should contain.
2868 0 : tracing::info!("Complete, returning {result:?}");
2869 :
2870 0 : Ok(result)
2871 0 : }
2872 :
2873 0 : pub(crate) async fn tenant_config_patch(
2874 0 : &self,
2875 0 : req: TenantConfigPatchRequest,
2876 0 : ) -> Result<(), ApiError> {
2877 0 : let _tenant_lock = trace_exclusive_lock(
2878 0 : &self.tenant_op_locks,
2879 0 : req.tenant_id,
2880 0 : TenantOperations::ConfigPatch,
2881 0 : )
2882 0 : .await;
2883 :
2884 0 : let tenant_id = req.tenant_id;
2885 0 : let patch = req.config;
2886 0 :
2887 0 : self.maybe_load_tenant(tenant_id, &_tenant_lock).await?;
2888 :
2889 0 : let base = {
2890 0 : let locked = self.inner.read().unwrap();
2891 0 : let shards = locked
2892 0 : .tenants
2893 0 : .range(TenantShardId::tenant_range(req.tenant_id));
2894 0 :
2895 0 : let mut configs = shards.map(|(_sid, shard)| &shard.config).peekable();
2896 :
2897 0 : let first = match configs.peek() {
2898 0 : Some(first) => (*first).clone(),
2899 : None => {
2900 0 : return Err(ApiError::NotFound(
2901 0 : anyhow::anyhow!("Tenant {} not found", req.tenant_id).into(),
2902 0 : ));
2903 : }
2904 : };
2905 :
2906 0 : if !configs.all_equal() {
2907 0 : tracing::error!("Tenant configs for {} are mismatched. ", req.tenant_id);
2908 : // This can't happen because we atomically update the database records
2909 : // of all shards to the new value in [`Self::set_tenant_config_and_reconcile`].
2910 0 : return Err(ApiError::InternalServerError(anyhow::anyhow!(
2911 0 : "Tenant configs for {} are mismatched",
2912 0 : req.tenant_id
2913 0 : )));
2914 0 : }
2915 0 :
2916 0 : first
2917 0 : };
2918 0 :
2919 0 : let updated_config = base.apply_patch(patch);
2920 0 : self.set_tenant_config_and_reconcile(tenant_id, updated_config)
2921 0 : .await
2922 0 : }
2923 :
2924 0 : pub(crate) async fn tenant_config_set(&self, req: TenantConfigRequest) -> Result<(), ApiError> {
2925 : // We require an exclusive lock, because we are updating persistent and in-memory state
2926 0 : let _tenant_lock = trace_exclusive_lock(
2927 0 : &self.tenant_op_locks,
2928 0 : req.tenant_id,
2929 0 : TenantOperations::ConfigSet,
2930 0 : )
2931 0 : .await;
2932 :
2933 0 : self.maybe_load_tenant(req.tenant_id, &_tenant_lock).await?;
2934 :
2935 0 : self.set_tenant_config_and_reconcile(req.tenant_id, req.config)
2936 0 : .await
2937 0 : }
2938 :
2939 0 : async fn set_tenant_config_and_reconcile(
2940 0 : &self,
2941 0 : tenant_id: TenantId,
2942 0 : config: TenantConfig,
2943 0 : ) -> Result<(), ApiError> {
2944 0 : self.persistence
2945 0 : .update_tenant_shard(
2946 0 : TenantFilter::Tenant(tenant_id),
2947 0 : None,
2948 0 : Some(config.clone()),
2949 0 : None,
2950 0 : None,
2951 0 : )
2952 0 : .await?;
2953 :
2954 0 : let waiters = {
2955 0 : let mut waiters = Vec::new();
2956 0 : let mut locked = self.inner.write().unwrap();
2957 0 : let (nodes, tenants, _scheduler) = locked.parts_mut();
2958 0 : for (_shard_id, shard) in tenants.range_mut(TenantShardId::tenant_range(tenant_id)) {
2959 0 : shard.config = config.clone();
2960 0 : if let Some(waiter) =
2961 0 : self.maybe_reconcile_shard(shard, nodes, ReconcilerPriority::High)
2962 0 : {
2963 0 : waiters.push(waiter);
2964 0 : }
2965 : }
2966 0 : waiters
2967 : };
2968 :
2969 0 : if let Err(e) = self.await_waiters(waiters, SHORT_RECONCILE_TIMEOUT).await {
2970 : // Treat this as success because we have stored the configuration. If e.g.
2971 : // a node was unavailable at this time, it should not stop us accepting a
2972 : // configuration change.
2973 0 : tracing::warn!(%tenant_id, "Accepted configuration update but reconciliation failed: {e}");
2974 0 : }
2975 :
2976 0 : Ok(())
2977 0 : }
2978 :
2979 0 : pub(crate) fn tenant_config_get(
2980 0 : &self,
2981 0 : tenant_id: TenantId,
2982 0 : ) -> Result<HashMap<&str, serde_json::Value>, ApiError> {
2983 0 : let config = {
2984 0 : let locked = self.inner.read().unwrap();
2985 0 :
2986 0 : match locked
2987 0 : .tenants
2988 0 : .range(TenantShardId::tenant_range(tenant_id))
2989 0 : .next()
2990 : {
2991 0 : Some((_tenant_shard_id, shard)) => shard.config.clone(),
2992 : None => {
2993 0 : return Err(ApiError::NotFound(
2994 0 : anyhow::anyhow!("Tenant not found").into(),
2995 0 : ))
2996 : }
2997 : }
2998 : };
2999 :
3000 : // Unlike the pageserver, we do not have a set of global defaults: the config is
3001 : // entirely per-tenant. Therefore the distinction between `tenant_specific_overrides`
3002 : // and `effective_config` in the response is meaningless, but we retain that syntax
3003 : // in order to remain compatible with the pageserver API.
3004 :
3005 0 : let response = HashMap::from([
3006 : (
3007 : "tenant_specific_overrides",
3008 0 : serde_json::to_value(&config)
3009 0 : .context("serializing tenant specific overrides")
3010 0 : .map_err(ApiError::InternalServerError)?,
3011 : ),
3012 : (
3013 0 : "effective_config",
3014 0 : serde_json::to_value(&config)
3015 0 : .context("serializing effective config")
3016 0 : .map_err(ApiError::InternalServerError)?,
3017 : ),
3018 : ]);
3019 :
3020 0 : Ok(response)
3021 0 : }
3022 :
3023 0 : pub(crate) async fn tenant_time_travel_remote_storage(
3024 0 : &self,
3025 0 : time_travel_req: &TenantTimeTravelRequest,
3026 0 : tenant_id: TenantId,
3027 0 : timestamp: Cow<'_, str>,
3028 0 : done_if_after: Cow<'_, str>,
3029 0 : ) -> Result<(), ApiError> {
3030 0 : let _tenant_lock = trace_exclusive_lock(
3031 0 : &self.tenant_op_locks,
3032 0 : tenant_id,
3033 0 : TenantOperations::TimeTravelRemoteStorage,
3034 0 : )
3035 0 : .await;
3036 :
3037 0 : let node = {
3038 0 : let mut locked = self.inner.write().unwrap();
3039 : // Just a sanity check to prevent misuse: the API expects that the tenant is fully
3040 : // detached everywhere, and nothing writes to S3 storage. Here, we verify that,
3041 : // but only at the start of the process, so it's really just to prevent operator
3042 : // mistakes.
3043 0 : for (shard_id, shard) in locked.tenants.range(TenantShardId::tenant_range(tenant_id)) {
3044 0 : if shard.intent.get_attached().is_some() || !shard.intent.get_secondary().is_empty()
3045 : {
3046 0 : return Err(ApiError::InternalServerError(anyhow::anyhow!(
3047 0 : "We want tenant to be attached in shard with tenant_shard_id={shard_id}"
3048 0 : )));
3049 0 : }
3050 0 : let maybe_attached = shard
3051 0 : .observed
3052 0 : .locations
3053 0 : .iter()
3054 0 : .filter_map(|(node_id, observed_location)| {
3055 0 : observed_location
3056 0 : .conf
3057 0 : .as_ref()
3058 0 : .map(|loc| (node_id, observed_location, loc.mode))
3059 0 : })
3060 0 : .find(|(_, _, mode)| *mode != LocationConfigMode::Detached);
3061 0 : if let Some((node_id, _observed_location, mode)) = maybe_attached {
3062 0 : return Err(ApiError::InternalServerError(anyhow::anyhow!("We observed attached={mode:?} tenant in node_id={node_id} shard with tenant_shard_id={shard_id}")));
3063 0 : }
3064 : }
3065 0 : let scheduler = &mut locked.scheduler;
3066 : // Right now we only perform the operation on a single node without parallelization
3067 : // TODO fan out the operation to multiple nodes for better performance
3068 0 : let node_id = scheduler.any_available_node()?;
3069 0 : let node = locked
3070 0 : .nodes
3071 0 : .get(&node_id)
3072 0 : .expect("Pageservers may not be deleted while lock is active");
3073 0 : node.clone()
3074 0 : };
3075 0 :
3076 0 : // The shard count is encoded in the remote storage's URL, so we need to handle all historically used shard counts
3077 0 : let mut counts = time_travel_req
3078 0 : .shard_counts
3079 0 : .iter()
3080 0 : .copied()
3081 0 : .collect::<HashSet<_>>()
3082 0 : .into_iter()
3083 0 : .collect::<Vec<_>>();
3084 0 : counts.sort_unstable();
3085 :
3086 0 : for count in counts {
3087 0 : let shard_ids = (0..count.count())
3088 0 : .map(|i| TenantShardId {
3089 0 : tenant_id,
3090 0 : shard_number: ShardNumber(i),
3091 0 : shard_count: count,
3092 0 : })
3093 0 : .collect::<Vec<_>>();
3094 0 : for tenant_shard_id in shard_ids {
3095 0 : let client = PageserverClient::new(
3096 0 : node.get_id(),
3097 0 : node.base_url(),
3098 0 : self.config.jwt_token.as_deref(),
3099 0 : );
3100 0 :
3101 0 : tracing::info!("Doing time travel recovery for shard {tenant_shard_id}",);
3102 :
3103 0 : client
3104 0 : .tenant_time_travel_remote_storage(
3105 0 : tenant_shard_id,
3106 0 : ×tamp,
3107 0 : &done_if_after,
3108 0 : )
3109 0 : .await
3110 0 : .map_err(|e| {
3111 0 : ApiError::InternalServerError(anyhow::anyhow!(
3112 0 : "Error doing time travel recovery for shard {tenant_shard_id} on node {}: {e}",
3113 0 : node
3114 0 : ))
3115 0 : })?;
3116 : }
3117 : }
3118 0 : Ok(())
3119 0 : }
3120 :
3121 0 : pub(crate) async fn tenant_secondary_download(
3122 0 : &self,
3123 0 : tenant_id: TenantId,
3124 0 : wait: Option<Duration>,
3125 0 : ) -> Result<(StatusCode, SecondaryProgress), ApiError> {
3126 0 : let _tenant_lock = trace_shared_lock(
3127 0 : &self.tenant_op_locks,
3128 0 : tenant_id,
3129 0 : TenantOperations::SecondaryDownload,
3130 0 : )
3131 0 : .await;
3132 :
3133 : // Acquire lock and yield the collection of shard-node tuples which we will send requests onward to
3134 0 : let targets = {
3135 0 : let locked = self.inner.read().unwrap();
3136 0 : let mut targets = Vec::new();
3137 :
3138 0 : for (tenant_shard_id, shard) in
3139 0 : locked.tenants.range(TenantShardId::tenant_range(tenant_id))
3140 : {
3141 0 : for node_id in shard.intent.get_secondary() {
3142 0 : let node = locked
3143 0 : .nodes
3144 0 : .get(node_id)
3145 0 : .expect("Pageservers may not be deleted while referenced");
3146 0 :
3147 0 : targets.push((*tenant_shard_id, node.clone()));
3148 0 : }
3149 : }
3150 0 : targets
3151 0 : };
3152 0 :
3153 0 : // Issue concurrent requests to all shards' locations
3154 0 : let mut futs = FuturesUnordered::new();
3155 0 : for (tenant_shard_id, node) in targets {
3156 0 : let client = PageserverClient::new(
3157 0 : node.get_id(),
3158 0 : node.base_url(),
3159 0 : self.config.jwt_token.as_deref(),
3160 0 : );
3161 0 : futs.push(async move {
3162 0 : let result = client
3163 0 : .tenant_secondary_download(tenant_shard_id, wait)
3164 0 : .await;
3165 0 : (result, node, tenant_shard_id)
3166 0 : })
3167 : }
3168 :
3169 : // Handle any errors returned by pageservers. This includes cases like this request racing with
3170 : // a scheduling operation, such that the tenant shard we're calling doesn't exist on that pageserver any more, as
3171 : // well as more general cases like 503s, 500s, or timeouts.
3172 0 : let mut aggregate_progress = SecondaryProgress::default();
3173 0 : let mut aggregate_status: Option<StatusCode> = None;
3174 0 : let mut error: Option<mgmt_api::Error> = None;
3175 0 : while let Some((result, node, tenant_shard_id)) = futs.next().await {
3176 0 : match result {
3177 0 : Err(e) => {
3178 0 : // Secondary downloads are always advisory: if something fails, we nevertheless report success, so that whoever
3179 0 : // is calling us will proceed with whatever migration they're doing, albeit with a slightly less warm cache
3180 0 : // than they had hoped for.
3181 0 : tracing::warn!("Secondary download error from pageserver {node}: {e}",);
3182 0 : error = Some(e)
3183 : }
3184 0 : Ok((status_code, progress)) => {
3185 0 : tracing::info!(%tenant_shard_id, "Shard status={status_code} progress: {progress:?}");
3186 0 : aggregate_progress.layers_downloaded += progress.layers_downloaded;
3187 0 : aggregate_progress.layers_total += progress.layers_total;
3188 0 : aggregate_progress.bytes_downloaded += progress.bytes_downloaded;
3189 0 : aggregate_progress.bytes_total += progress.bytes_total;
3190 0 : aggregate_progress.heatmap_mtime =
3191 0 : std::cmp::max(aggregate_progress.heatmap_mtime, progress.heatmap_mtime);
3192 0 : aggregate_status = match aggregate_status {
3193 0 : None => Some(status_code),
3194 0 : Some(StatusCode::OK) => Some(status_code),
3195 0 : Some(cur) => {
3196 0 : // Other status codes (e.g. 202) -- do not overwrite.
3197 0 : Some(cur)
3198 : }
3199 : };
3200 : }
3201 : }
3202 : }
3203 :
3204 : // If any of the shards return 202, indicate our result as 202.
3205 0 : match aggregate_status {
3206 : None => {
3207 0 : match error {
3208 0 : Some(e) => {
3209 0 : // No successes, and an error: surface it
3210 0 : Err(ApiError::Conflict(format!("Error from pageserver: {e}")))
3211 : }
3212 : None => {
3213 : // No shards found
3214 0 : Err(ApiError::NotFound(
3215 0 : anyhow::anyhow!("Tenant {} not found", tenant_id).into(),
3216 0 : ))
3217 : }
3218 : }
3219 : }
3220 0 : Some(aggregate_status) => Ok((aggregate_status, aggregate_progress)),
3221 : }
3222 0 : }
3223 :
3224 0 : pub(crate) async fn tenant_delete(&self, tenant_id: TenantId) -> Result<StatusCode, ApiError> {
3225 0 : let _tenant_lock =
3226 0 : trace_exclusive_lock(&self.tenant_op_locks, tenant_id, TenantOperations::Delete).await;
3227 :
3228 0 : self.maybe_load_tenant(tenant_id, &_tenant_lock).await?;
3229 :
3230 : // Detach all shards. This also deletes local pageserver shard data.
3231 0 : let (detach_waiters, node) = {
3232 0 : let mut detach_waiters = Vec::new();
3233 0 : let mut locked = self.inner.write().unwrap();
3234 0 : let (nodes, tenants, scheduler) = locked.parts_mut();
3235 0 : for (_, shard) in tenants.range_mut(TenantShardId::tenant_range(tenant_id)) {
3236 : // Update the tenant's intent to remove all attachments
3237 0 : shard.policy = PlacementPolicy::Detached;
3238 0 : shard
3239 0 : .schedule(scheduler, &mut ScheduleContext::default())
3240 0 : .expect("De-scheduling is infallible");
3241 0 : debug_assert!(shard.intent.get_attached().is_none());
3242 0 : debug_assert!(shard.intent.get_secondary().is_empty());
3243 :
3244 0 : if let Some(waiter) =
3245 0 : self.maybe_reconcile_shard(shard, nodes, ReconcilerPriority::High)
3246 0 : {
3247 0 : detach_waiters.push(waiter);
3248 0 : }
3249 : }
3250 :
3251 : // Pick an arbitrary node to use for remote deletions (does not have to be where the tenant
3252 : // was attached, just has to be able to see the S3 content)
3253 0 : let node_id = scheduler.any_available_node()?;
3254 0 : let node = nodes
3255 0 : .get(&node_id)
3256 0 : .expect("Pageservers may not be deleted while lock is active");
3257 0 : (detach_waiters, node.clone())
3258 0 : };
3259 0 :
3260 0 : // This reconcile wait can fail in a few ways:
3261 0 : // A there is a very long queue for the reconciler semaphore
3262 0 : // B some pageserver is failing to handle a detach promptly
3263 0 : // C some pageserver goes offline right at the moment we send it a request.
3264 0 : //
3265 0 : // A and C are transient: the semaphore will eventually become available, and once a node is marked offline
3266 0 : // the next attempt to reconcile will silently skip detaches for an offline node and succeed. If B happens,
3267 0 : // it's a bug, and needs resolving at the pageserver level (we shouldn't just leave attachments behind while
3268 0 : // deleting the underlying data).
3269 0 : self.await_waiters(detach_waiters, RECONCILE_TIMEOUT)
3270 0 : .await?;
3271 :
3272 : // Delete the entire tenant (all shards) from remote storage via a random pageserver.
3273 : // Passing an unsharded tenant ID will cause the pageserver to remove all remote paths with
3274 : // the tenant ID prefix, including all shards (even possibly stale ones).
3275 0 : match node
3276 0 : .with_client_retries(
3277 0 : |client| async move {
3278 0 : client
3279 0 : .tenant_delete(TenantShardId::unsharded(tenant_id))
3280 0 : .await
3281 0 : },
3282 0 : &self.config.jwt_token,
3283 0 : 1,
3284 0 : 3,
3285 0 : RECONCILE_TIMEOUT,
3286 0 : &self.cancel,
3287 0 : )
3288 0 : .await
3289 0 : .unwrap_or(Err(mgmt_api::Error::Cancelled))
3290 : {
3291 0 : Ok(_) => {}
3292 : Err(mgmt_api::Error::Cancelled) => {
3293 0 : return Err(ApiError::ShuttingDown);
3294 : }
3295 0 : Err(e) => {
3296 0 : // This is unexpected: remote deletion should be infallible, unless the object store
3297 0 : // at large is unavailable.
3298 0 : tracing::error!("Error deleting via node {node}: {e}");
3299 0 : return Err(ApiError::InternalServerError(anyhow::anyhow!(e)));
3300 : }
3301 : }
3302 :
3303 : // Fall through: deletion of the tenant on pageservers is complete, we may proceed to drop
3304 : // our in-memory state and database state.
3305 :
3306 : // Ordering: we delete persistent state first: if we then
3307 : // crash, we will drop the in-memory state.
3308 :
3309 : // Drop persistent state.
3310 0 : self.persistence.delete_tenant(tenant_id).await?;
3311 :
3312 : // Drop in-memory state
3313 : {
3314 0 : let mut locked = self.inner.write().unwrap();
3315 0 : let (_nodes, tenants, scheduler) = locked.parts_mut();
3316 :
3317 : // Dereference Scheduler from shards before dropping them
3318 0 : for (_tenant_shard_id, shard) in
3319 0 : tenants.range_mut(TenantShardId::tenant_range(tenant_id))
3320 0 : {
3321 0 : shard.intent.clear(scheduler);
3322 0 : }
3323 :
3324 0 : tenants.retain(|tenant_shard_id, _shard| tenant_shard_id.tenant_id != tenant_id);
3325 0 : tracing::info!(
3326 0 : "Deleted tenant {tenant_id}, now have {} tenants",
3327 0 : locked.tenants.len()
3328 : );
3329 : };
3330 :
3331 : // Success is represented as 404, to imitate the existing pageserver deletion API
3332 0 : Ok(StatusCode::NOT_FOUND)
3333 0 : }
3334 :
3335 : /// Naming: this configures the storage controller's policies for a tenant, whereas [`Self::tenant_config_set`] is "set the TenantConfig"
3336 : /// for a tenant. The TenantConfig is passed through to pageservers, whereas this function modifies
3337 : /// the tenant's policies (configuration) within the storage controller
3338 0 : pub(crate) async fn tenant_update_policy(
3339 0 : &self,
3340 0 : tenant_id: TenantId,
3341 0 : req: TenantPolicyRequest,
3342 0 : ) -> Result<(), ApiError> {
3343 : // We require an exclusive lock, because we are updating persistent and in-memory state
3344 0 : let _tenant_lock = trace_exclusive_lock(
3345 0 : &self.tenant_op_locks,
3346 0 : tenant_id,
3347 0 : TenantOperations::UpdatePolicy,
3348 0 : )
3349 0 : .await;
3350 :
3351 0 : self.maybe_load_tenant(tenant_id, &_tenant_lock).await?;
3352 :
3353 0 : failpoint_support::sleep_millis_async!("tenant-update-policy-exclusive-lock");
3354 :
3355 : let TenantPolicyRequest {
3356 0 : placement,
3357 0 : mut scheduling,
3358 0 : } = req;
3359 :
3360 0 : if let Some(PlacementPolicy::Detached | PlacementPolicy::Secondary) = placement {
3361 : // When someone configures a tenant to detach, we force the scheduling policy to enable
3362 : // this to take effect.
3363 0 : if scheduling.is_none() {
3364 0 : scheduling = Some(ShardSchedulingPolicy::Active);
3365 0 : }
3366 0 : }
3367 :
3368 0 : self.persistence
3369 0 : .update_tenant_shard(
3370 0 : TenantFilter::Tenant(tenant_id),
3371 0 : placement.clone(),
3372 0 : None,
3373 0 : None,
3374 0 : scheduling,
3375 0 : )
3376 0 : .await?;
3377 :
3378 0 : let mut schedule_context = ScheduleContext::default();
3379 0 : let mut locked = self.inner.write().unwrap();
3380 0 : let (nodes, tenants, scheduler) = locked.parts_mut();
3381 0 : for (shard_id, shard) in tenants.range_mut(TenantShardId::tenant_range(tenant_id)) {
3382 0 : if let Some(placement) = &placement {
3383 0 : shard.policy = placement.clone();
3384 0 :
3385 0 : tracing::info!(tenant_id=%shard_id.tenant_id, shard_id=%shard_id.shard_slug(),
3386 0 : "Updated placement policy to {placement:?}");
3387 0 : }
3388 :
3389 0 : if let Some(scheduling) = &scheduling {
3390 0 : shard.set_scheduling_policy(*scheduling);
3391 0 :
3392 0 : tracing::info!(tenant_id=%shard_id.tenant_id, shard_id=%shard_id.shard_slug(),
3393 0 : "Updated scheduling policy to {scheduling:?}");
3394 0 : }
3395 :
3396 : // In case scheduling is being switched back on, try it now.
3397 0 : shard.schedule(scheduler, &mut schedule_context).ok();
3398 0 : self.maybe_reconcile_shard(shard, nodes, ReconcilerPriority::High);
3399 : }
3400 :
3401 0 : Ok(())
3402 0 : }
3403 :
3404 0 : pub(crate) async fn tenant_timeline_create(
3405 0 : &self,
3406 0 : tenant_id: TenantId,
3407 0 : mut create_req: TimelineCreateRequest,
3408 0 : ) -> Result<TimelineInfo, ApiError> {
3409 0 : tracing::info!(
3410 0 : "Creating timeline {}/{}",
3411 : tenant_id,
3412 : create_req.new_timeline_id,
3413 : );
3414 :
3415 0 : let _tenant_lock = trace_shared_lock(
3416 0 : &self.tenant_op_locks,
3417 0 : tenant_id,
3418 0 : TenantOperations::TimelineCreate,
3419 0 : )
3420 0 : .await;
3421 0 : failpoint_support::sleep_millis_async!("tenant-create-timeline-shared-lock");
3422 :
3423 0 : self.tenant_remote_mutation(tenant_id, move |mut targets| async move {
3424 0 : if targets.0.is_empty() {
3425 0 : return Err(ApiError::NotFound(
3426 0 : anyhow::anyhow!("Tenant not found").into(),
3427 0 : ));
3428 0 : };
3429 0 :
3430 0 : let (shard_zero_tid, shard_zero_locations) =
3431 0 : targets.0.pop_first().expect("Must have at least one shard");
3432 0 : assert!(shard_zero_tid.is_shard_zero());
3433 :
3434 0 : async fn create_one(
3435 0 : tenant_shard_id: TenantShardId,
3436 0 : locations: ShardMutationLocations,
3437 0 : jwt: Option<String>,
3438 0 : create_req: TimelineCreateRequest,
3439 0 : ) -> Result<TimelineInfo, ApiError> {
3440 0 : let latest = locations.latest.node;
3441 0 :
3442 0 : tracing::info!(
3443 0 : "Creating timeline on shard {}/{}, attached to node {latest} in generation {:?}",
3444 : tenant_shard_id,
3445 : create_req.new_timeline_id,
3446 : locations.latest.generation
3447 : );
3448 :
3449 0 : let client =
3450 0 : PageserverClient::new(latest.get_id(), latest.base_url(), jwt.as_deref());
3451 :
3452 0 : let timeline_info = client
3453 0 : .timeline_create(tenant_shard_id, &create_req)
3454 0 : .await
3455 0 : .map_err(|e| passthrough_api_error(&latest, e))?;
3456 :
3457 : // We propagate timeline creations to all attached locations such that a compute
3458 : // for the new timeline is able to start regardless of the current state of the
3459 : // tenant shard reconciliation.
3460 0 : for location in locations.other {
3461 0 : tracing::info!(
3462 0 : "Creating timeline on shard {}/{}, stale attached to node {} in generation {:?}",
3463 : tenant_shard_id,
3464 : create_req.new_timeline_id,
3465 : location.node,
3466 : location.generation
3467 : );
3468 :
3469 0 : let client = PageserverClient::new(
3470 0 : location.node.get_id(),
3471 0 : location.node.base_url(),
3472 0 : jwt.as_deref(),
3473 0 : );
3474 :
3475 0 : let res = client
3476 0 : .timeline_create(tenant_shard_id, &create_req)
3477 0 : .await;
3478 :
3479 0 : if let Err(e) = res {
3480 0 : match e {
3481 0 : mgmt_api::Error::ApiError(StatusCode::NOT_FOUND, _) => {
3482 0 : // Tenant might have been detached from the stale location,
3483 0 : // so ignore 404s.
3484 0 : },
3485 : _ => {
3486 0 : return Err(passthrough_api_error(&location.node, e));
3487 : }
3488 : }
3489 0 : }
3490 : }
3491 :
3492 0 : Ok(timeline_info)
3493 0 : }
3494 :
3495 : // Because the caller might not provide an explicit LSN, we must do the creation first on a single shard, and then
3496 : // use whatever LSN that shard picked when creating on subsequent shards. We arbitrarily use shard zero as the shard
3497 : // that will get the first creation request, and propagate the LSN to all the >0 shards.
3498 0 : let timeline_info = create_one(
3499 0 : shard_zero_tid,
3500 0 : shard_zero_locations,
3501 0 : self.config.jwt_token.clone(),
3502 0 : create_req.clone(),
3503 0 : )
3504 0 : .await?;
3505 :
3506 : // Propagate the LSN that shard zero picked, if caller didn't provide one
3507 0 : match &mut create_req.mode {
3508 0 : models::TimelineCreateRequestMode::Branch { ancestor_start_lsn, .. } if ancestor_start_lsn.is_none() => {
3509 0 : *ancestor_start_lsn = timeline_info.ancestor_lsn;
3510 0 : },
3511 0 : _ => {}
3512 : }
3513 :
3514 : // Create timeline on remaining shards with number >0
3515 0 : if !targets.0.is_empty() {
3516 : // If we had multiple shards, issue requests for the remainder now.
3517 0 : let jwt = &self.config.jwt_token;
3518 0 : self.tenant_for_shards(
3519 0 : targets
3520 0 : .0
3521 0 : .iter()
3522 0 : .map(|t| (*t.0, t.1.latest.node.clone()))
3523 0 : .collect(),
3524 0 : |tenant_shard_id: TenantShardId, _node: Node| {
3525 0 : let create_req = create_req.clone();
3526 0 : let mutation_locations = targets.0.remove(&tenant_shard_id).unwrap();
3527 0 : Box::pin(create_one(
3528 0 : tenant_shard_id,
3529 0 : mutation_locations,
3530 0 : jwt.clone(),
3531 0 : create_req,
3532 0 : ))
3533 0 : },
3534 0 : )
3535 0 : .await?;
3536 0 : }
3537 :
3538 0 : Ok(timeline_info)
3539 0 : })
3540 0 : .await?
3541 0 : }
3542 :
3543 0 : pub(crate) async fn tenant_timeline_archival_config(
3544 0 : &self,
3545 0 : tenant_id: TenantId,
3546 0 : timeline_id: TimelineId,
3547 0 : req: TimelineArchivalConfigRequest,
3548 0 : ) -> Result<(), ApiError> {
3549 0 : tracing::info!(
3550 0 : "Setting archival config of timeline {tenant_id}/{timeline_id} to '{:?}'",
3551 : req.state
3552 : );
3553 :
3554 0 : let _tenant_lock = trace_shared_lock(
3555 0 : &self.tenant_op_locks,
3556 0 : tenant_id,
3557 0 : TenantOperations::TimelineArchivalConfig,
3558 0 : )
3559 0 : .await;
3560 :
3561 0 : self.tenant_remote_mutation(tenant_id, move |targets| async move {
3562 0 : if targets.0.is_empty() {
3563 0 : return Err(ApiError::NotFound(
3564 0 : anyhow::anyhow!("Tenant not found").into(),
3565 0 : ));
3566 0 : }
3567 0 : async fn config_one(
3568 0 : tenant_shard_id: TenantShardId,
3569 0 : timeline_id: TimelineId,
3570 0 : node: Node,
3571 0 : jwt: Option<String>,
3572 0 : req: TimelineArchivalConfigRequest,
3573 0 : ) -> Result<(), ApiError> {
3574 0 : tracing::info!(
3575 0 : "Setting archival config of timeline on shard {tenant_shard_id}/{timeline_id}, attached to node {node}",
3576 : );
3577 :
3578 0 : let client = PageserverClient::new(node.get_id(), node.base_url(), jwt.as_deref());
3579 0 :
3580 0 : client
3581 0 : .timeline_archival_config(tenant_shard_id, timeline_id, &req)
3582 0 : .await
3583 0 : .map_err(|e| match e {
3584 0 : mgmt_api::Error::ApiError(StatusCode::PRECONDITION_FAILED, msg) => {
3585 0 : ApiError::PreconditionFailed(msg.into_boxed_str())
3586 : }
3587 0 : _ => passthrough_api_error(&node, e),
3588 0 : })
3589 0 : }
3590 :
3591 : // no shard needs to go first/last; the operation should be idempotent
3592 : // TODO: it would be great to ensure that all shards return the same error
3593 0 : let locations = targets.0.iter().map(|t| (*t.0, t.1.latest.node.clone())).collect();
3594 0 : let results = self
3595 0 : .tenant_for_shards(locations, |tenant_shard_id, node| {
3596 0 : futures::FutureExt::boxed(config_one(
3597 0 : tenant_shard_id,
3598 0 : timeline_id,
3599 0 : node,
3600 0 : self.config.jwt_token.clone(),
3601 0 : req.clone(),
3602 0 : ))
3603 0 : })
3604 0 : .await?;
3605 0 : assert!(!results.is_empty(), "must have at least one result");
3606 :
3607 0 : Ok(())
3608 0 : }).await?
3609 0 : }
3610 :
3611 0 : pub(crate) async fn tenant_timeline_detach_ancestor(
3612 0 : &self,
3613 0 : tenant_id: TenantId,
3614 0 : timeline_id: TimelineId,
3615 0 : ) -> Result<models::detach_ancestor::AncestorDetached, ApiError> {
3616 0 : tracing::info!("Detaching timeline {tenant_id}/{timeline_id}",);
3617 :
3618 0 : let _tenant_lock = trace_shared_lock(
3619 0 : &self.tenant_op_locks,
3620 0 : tenant_id,
3621 0 : TenantOperations::TimelineDetachAncestor,
3622 0 : )
3623 0 : .await;
3624 :
3625 0 : self.tenant_remote_mutation(tenant_id, move |targets| async move {
3626 0 : if targets.0.is_empty() {
3627 0 : return Err(ApiError::NotFound(
3628 0 : anyhow::anyhow!("Tenant not found").into(),
3629 0 : ));
3630 0 : }
3631 :
3632 0 : async fn detach_one(
3633 0 : tenant_shard_id: TenantShardId,
3634 0 : timeline_id: TimelineId,
3635 0 : node: Node,
3636 0 : jwt: Option<String>,
3637 0 : ) -> Result<(ShardNumber, models::detach_ancestor::AncestorDetached), ApiError> {
3638 0 : tracing::info!(
3639 0 : "Detaching timeline on shard {tenant_shard_id}/{timeline_id}, attached to node {node}",
3640 : );
3641 :
3642 0 : let client = PageserverClient::new(node.get_id(), node.base_url(), jwt.as_deref());
3643 0 :
3644 0 : client
3645 0 : .timeline_detach_ancestor(tenant_shard_id, timeline_id)
3646 0 : .await
3647 0 : .map_err(|e| {
3648 : use mgmt_api::Error;
3649 :
3650 0 : match e {
3651 : // no ancestor (ever)
3652 0 : Error::ApiError(StatusCode::CONFLICT, msg) => ApiError::Conflict(format!(
3653 0 : "{node}: {}",
3654 0 : msg.strip_prefix("Conflict: ").unwrap_or(&msg)
3655 0 : )),
3656 : // too many ancestors
3657 0 : Error::ApiError(StatusCode::BAD_REQUEST, msg) => {
3658 0 : ApiError::BadRequest(anyhow::anyhow!("{node}: {msg}"))
3659 : }
3660 0 : Error::ApiError(StatusCode::INTERNAL_SERVER_ERROR, msg) => {
3661 0 : // avoid turning these into conflicts to remain compatible with
3662 0 : // pageservers, 500 errors are sadly retryable with timeline ancestor
3663 0 : // detach
3664 0 : ApiError::InternalServerError(anyhow::anyhow!("{node}: {msg}"))
3665 : }
3666 : // rest can be mapped as usual
3667 0 : other => passthrough_api_error(&node, other),
3668 : }
3669 0 : })
3670 0 : .map(|res| (tenant_shard_id.shard_number, res))
3671 0 : }
3672 :
3673 : // no shard needs to go first/last; the operation should be idempotent
3674 0 : let locations = targets.0.iter().map(|t| (*t.0, t.1.latest.node.clone())).collect();
3675 0 : let mut results = self
3676 0 : .tenant_for_shards(locations, |tenant_shard_id, node| {
3677 0 : futures::FutureExt::boxed(detach_one(
3678 0 : tenant_shard_id,
3679 0 : timeline_id,
3680 0 : node,
3681 0 : self.config.jwt_token.clone(),
3682 0 : ))
3683 0 : })
3684 0 : .await?;
3685 :
3686 0 : let any = results.pop().expect("we must have at least one response");
3687 0 :
3688 0 : let mismatching = results
3689 0 : .iter()
3690 0 : .filter(|(_, res)| res != &any.1)
3691 0 : .collect::<Vec<_>>();
3692 0 : if !mismatching.is_empty() {
3693 : // this can be hit by races which should not happen because operation lock on cplane
3694 0 : let matching = results.len() - mismatching.len();
3695 0 : tracing::error!(
3696 : matching,
3697 : compared_against=?any,
3698 : ?mismatching,
3699 0 : "shards returned different results"
3700 : );
3701 :
3702 0 : return Err(ApiError::InternalServerError(anyhow::anyhow!("pageservers returned mixed results for ancestor detach; manual intervention is required.")));
3703 0 : }
3704 0 :
3705 0 : Ok(any.1)
3706 0 : }).await?
3707 0 : }
3708 :
3709 0 : pub(crate) async fn tenant_timeline_block_unblock_gc(
3710 0 : &self,
3711 0 : tenant_id: TenantId,
3712 0 : timeline_id: TimelineId,
3713 0 : dir: BlockUnblock,
3714 0 : ) -> Result<(), ApiError> {
3715 0 : let _tenant_lock = trace_shared_lock(
3716 0 : &self.tenant_op_locks,
3717 0 : tenant_id,
3718 0 : TenantOperations::TimelineGcBlockUnblock,
3719 0 : )
3720 0 : .await;
3721 :
3722 0 : self.tenant_remote_mutation(tenant_id, move |targets| async move {
3723 0 : if targets.0.is_empty() {
3724 0 : return Err(ApiError::NotFound(
3725 0 : anyhow::anyhow!("Tenant not found").into(),
3726 0 : ));
3727 0 : }
3728 :
3729 0 : async fn do_one(
3730 0 : tenant_shard_id: TenantShardId,
3731 0 : timeline_id: TimelineId,
3732 0 : node: Node,
3733 0 : jwt: Option<String>,
3734 0 : dir: BlockUnblock,
3735 0 : ) -> Result<(), ApiError> {
3736 0 : let client = PageserverClient::new(node.get_id(), node.base_url(), jwt.as_deref());
3737 0 :
3738 0 : client
3739 0 : .timeline_block_unblock_gc(tenant_shard_id, timeline_id, dir)
3740 0 : .await
3741 0 : .map_err(|e| passthrough_api_error(&node, e))
3742 0 : }
3743 :
3744 : // no shard needs to go first/last; the operation should be idempotent
3745 0 : let locations = targets
3746 0 : .0
3747 0 : .iter()
3748 0 : .map(|t| (*t.0, t.1.latest.node.clone()))
3749 0 : .collect();
3750 0 : self.tenant_for_shards(locations, |tenant_shard_id, node| {
3751 0 : futures::FutureExt::boxed(do_one(
3752 0 : tenant_shard_id,
3753 0 : timeline_id,
3754 0 : node,
3755 0 : self.config.jwt_token.clone(),
3756 0 : dir,
3757 0 : ))
3758 0 : })
3759 0 : .await
3760 0 : })
3761 0 : .await??;
3762 0 : Ok(())
3763 0 : }
3764 :
3765 0 : pub(crate) async fn tenant_timeline_download_heatmap_layers(
3766 0 : &self,
3767 0 : tenant_shard_id: TenantShardId,
3768 0 : timeline_id: TimelineId,
3769 0 : concurrency: Option<usize>,
3770 0 : ) -> Result<(), ApiError> {
3771 0 : let _tenant_lock = trace_shared_lock(
3772 0 : &self.tenant_op_locks,
3773 0 : tenant_shard_id.tenant_id,
3774 0 : TenantOperations::DownloadHeatmapLayers,
3775 0 : )
3776 0 : .await;
3777 :
3778 0 : let targets = {
3779 0 : let locked = self.inner.read().unwrap();
3780 0 : let mut targets = Vec::new();
3781 :
3782 : // If the request got an unsharded tenant id, then apply
3783 : // the operation to all shards. Otherwise, apply it to a specific shard.
3784 0 : let shards_range = if tenant_shard_id.is_unsharded() {
3785 0 : TenantShardId::tenant_range(tenant_shard_id.tenant_id)
3786 : } else {
3787 0 : tenant_shard_id.range()
3788 : };
3789 :
3790 0 : for (tenant_shard_id, shard) in locked.tenants.range(shards_range) {
3791 0 : if let Some(node_id) = shard.intent.get_attached() {
3792 0 : let node = locked
3793 0 : .nodes
3794 0 : .get(node_id)
3795 0 : .expect("Pageservers may not be deleted while referenced");
3796 0 :
3797 0 : targets.push((*tenant_shard_id, node.clone()));
3798 0 : }
3799 : }
3800 0 : targets
3801 0 : };
3802 0 :
3803 0 : self.tenant_for_shards_api(
3804 0 : targets,
3805 0 : |tenant_shard_id, client| async move {
3806 0 : client
3807 0 : .timeline_download_heatmap_layers(tenant_shard_id, timeline_id, concurrency)
3808 0 : .await
3809 0 : },
3810 0 : 1,
3811 0 : 1,
3812 0 : SHORT_RECONCILE_TIMEOUT,
3813 0 : &self.cancel,
3814 0 : )
3815 0 : .await;
3816 :
3817 0 : Ok(())
3818 0 : }
3819 :
3820 : /// Helper for concurrently calling a pageserver API on a number of shards, such as timeline creation.
3821 : ///
3822 : /// On success, the returned vector contains exactly the same number of elements as the input `locations`.
3823 0 : async fn tenant_for_shards<F, R>(
3824 0 : &self,
3825 0 : locations: Vec<(TenantShardId, Node)>,
3826 0 : mut req_fn: F,
3827 0 : ) -> Result<Vec<R>, ApiError>
3828 0 : where
3829 0 : F: FnMut(
3830 0 : TenantShardId,
3831 0 : Node,
3832 0 : )
3833 0 : -> std::pin::Pin<Box<dyn futures::Future<Output = Result<R, ApiError>> + Send>>,
3834 0 : {
3835 0 : let mut futs = FuturesUnordered::new();
3836 0 : let mut results = Vec::with_capacity(locations.len());
3837 :
3838 0 : for (tenant_shard_id, node) in locations {
3839 0 : futs.push(req_fn(tenant_shard_id, node));
3840 0 : }
3841 :
3842 0 : while let Some(r) = futs.next().await {
3843 0 : results.push(r?);
3844 : }
3845 :
3846 0 : Ok(results)
3847 0 : }
3848 :
3849 : /// Concurrently invoke a pageserver API call on many shards at once
3850 0 : pub(crate) async fn tenant_for_shards_api<T, O, F>(
3851 0 : &self,
3852 0 : locations: Vec<(TenantShardId, Node)>,
3853 0 : op: O,
3854 0 : warn_threshold: u32,
3855 0 : max_retries: u32,
3856 0 : timeout: Duration,
3857 0 : cancel: &CancellationToken,
3858 0 : ) -> Vec<mgmt_api::Result<T>>
3859 0 : where
3860 0 : O: Fn(TenantShardId, PageserverClient) -> F + Copy,
3861 0 : F: std::future::Future<Output = mgmt_api::Result<T>>,
3862 0 : {
3863 0 : let mut futs = FuturesUnordered::new();
3864 0 : let mut results = Vec::with_capacity(locations.len());
3865 :
3866 0 : for (tenant_shard_id, node) in locations {
3867 0 : futs.push(async move {
3868 0 : node.with_client_retries(
3869 0 : |client| op(tenant_shard_id, client),
3870 0 : &self.config.jwt_token,
3871 0 : warn_threshold,
3872 0 : max_retries,
3873 0 : timeout,
3874 0 : cancel,
3875 0 : )
3876 0 : .await
3877 0 : });
3878 0 : }
3879 :
3880 0 : while let Some(r) = futs.next().await {
3881 0 : let r = r.unwrap_or(Err(mgmt_api::Error::Cancelled));
3882 0 : results.push(r);
3883 0 : }
3884 :
3885 0 : results
3886 0 : }
3887 :
3888 : /// Helper for safely working with the shards in a tenant remotely on pageservers, for example
3889 : /// when creating and deleting timelines:
3890 : /// - Makes sure shards are attached somewhere if they weren't already
3891 : /// - Looks up the shards and the nodes where they were most recently attached
3892 : /// - Guarantees that after the inner function returns, the shards' generations haven't moved on: this
3893 : /// ensures that the remote operation acted on the most recent generation, and is therefore durable.
3894 0 : async fn tenant_remote_mutation<R, O, F>(
3895 0 : &self,
3896 0 : tenant_id: TenantId,
3897 0 : op: O,
3898 0 : ) -> Result<R, ApiError>
3899 0 : where
3900 0 : O: FnOnce(TenantMutationLocations) -> F,
3901 0 : F: std::future::Future<Output = R>,
3902 0 : {
3903 0 : let mutation_locations = {
3904 0 : let mut locations = TenantMutationLocations::default();
3905 :
3906 : // Load the currently attached pageservers for the latest generation of each shard. This can
3907 : // run concurrently with reconciliations, and it is not guaranteed that the node we find here
3908 : // will still be the latest when we're done: we will check generations again at the end of
3909 : // this function to handle that.
3910 0 : let generations = self.persistence.tenant_generations(tenant_id).await?;
3911 :
3912 0 : if generations
3913 0 : .iter()
3914 0 : .any(|i| i.generation.is_none() || i.generation_pageserver.is_none())
3915 : {
3916 0 : let shard_generations = generations
3917 0 : .into_iter()
3918 0 : .map(|i| (i.tenant_shard_id, (i.generation, i.generation_pageserver)))
3919 0 : .collect::<HashMap<_, _>>();
3920 0 :
3921 0 : // One or more shards has not been attached to a pageserver. Check if this is because it's configured
3922 0 : // to be detached (409: caller should give up), or because it's meant to be attached but isn't yet (503: caller should retry)
3923 0 : let locked = self.inner.read().unwrap();
3924 0 : for (shard_id, shard) in
3925 0 : locked.tenants.range(TenantShardId::tenant_range(tenant_id))
3926 : {
3927 0 : match shard.policy {
3928 : PlacementPolicy::Attached(_) => {
3929 : // This shard is meant to be attached: the caller is not wrong to try and
3930 : // use this function, but we can't service the request right now.
3931 0 : let Some(generation) = shard_generations.get(shard_id) else {
3932 : // This can only happen if there is a split brain controller modifying the database. This should
3933 : // never happen when testing, and if it happens in production we can only log the issue.
3934 0 : debug_assert!(false);
3935 0 : tracing::error!("Shard {shard_id} not found in generation state! Is another rogue controller running?");
3936 0 : continue;
3937 : };
3938 0 : let (generation, generation_pageserver) = generation;
3939 0 : if let Some(generation) = generation {
3940 0 : if generation_pageserver.is_none() {
3941 : // This is legitimate only in a very narrow window where the shard was only just configured into
3942 : // Attached mode after being created in Secondary or Detached mode, and it has had its generation
3943 : // set but not yet had a Reconciler run (reconciler is the only thing that sets generation_pageserver).
3944 0 : tracing::warn!("Shard {shard_id} generation is set ({generation:?}) but generation_pageserver is None, reconciler not run yet?");
3945 0 : }
3946 : } else {
3947 : // This should never happen: a shard with no generation is only permitted when it was created in some state
3948 : // other than PlacementPolicy::Attached (and generation is always written to DB before setting Attached in memory)
3949 0 : debug_assert!(false);
3950 0 : tracing::error!("Shard {shard_id} generation is None, but it is in PlacementPolicy::Attached mode!");
3951 0 : continue;
3952 : }
3953 : }
3954 : PlacementPolicy::Secondary | PlacementPolicy::Detached => {
3955 0 : return Err(ApiError::Conflict(format!(
3956 0 : "Shard {shard_id} tenant has policy {:?}",
3957 0 : shard.policy
3958 0 : )));
3959 : }
3960 : }
3961 : }
3962 :
3963 0 : return Err(ApiError::ResourceUnavailable(
3964 0 : "One or more shards in tenant is not yet attached".into(),
3965 0 : ));
3966 0 : }
3967 0 :
3968 0 : let locked = self.inner.read().unwrap();
3969 : for ShardGenerationState {
3970 0 : tenant_shard_id,
3971 0 : generation,
3972 0 : generation_pageserver,
3973 0 : } in generations
3974 : {
3975 0 : let node_id = generation_pageserver.expect("We checked for None above");
3976 0 : let node = locked
3977 0 : .nodes
3978 0 : .get(&node_id)
3979 0 : .ok_or(ApiError::Conflict(format!(
3980 0 : "Raced with removal of node {node_id}"
3981 0 : )))?;
3982 0 : let generation = generation.expect("Checked above");
3983 0 :
3984 0 : let tenant = locked.tenants.get(&tenant_shard_id);
3985 :
3986 : // TODO(vlad): Abstract the logic that finds stale attached locations
3987 : // from observed state into a [`Service`] method.
3988 0 : let other_locations = match tenant {
3989 0 : Some(tenant) => {
3990 0 : let mut other = tenant.attached_locations();
3991 0 : let latest_location_index =
3992 0 : other.iter().position(|&l| l == (node.get_id(), generation));
3993 0 : if let Some(idx) = latest_location_index {
3994 0 : other.remove(idx);
3995 0 : }
3996 :
3997 0 : other
3998 : }
3999 0 : None => Vec::default(),
4000 : };
4001 :
4002 0 : let location = ShardMutationLocations {
4003 0 : latest: MutationLocation {
4004 0 : node: node.clone(),
4005 0 : generation,
4006 0 : },
4007 0 : other: other_locations
4008 0 : .into_iter()
4009 0 : .filter_map(|(node_id, generation)| {
4010 0 : let node = locked.nodes.get(&node_id)?;
4011 :
4012 0 : Some(MutationLocation {
4013 0 : node: node.clone(),
4014 0 : generation,
4015 0 : })
4016 0 : })
4017 0 : .collect(),
4018 0 : };
4019 0 : locations.0.insert(tenant_shard_id, location);
4020 0 : }
4021 :
4022 0 : locations
4023 : };
4024 :
4025 0 : let result = op(mutation_locations.clone()).await;
4026 :
4027 : // Post-check: are all the generations of all the shards the same as they were initially? This proves that
4028 : // our remote operation executed on the latest generation and is therefore persistent.
4029 : {
4030 0 : let latest_generations = self.persistence.tenant_generations(tenant_id).await?;
4031 0 : if latest_generations
4032 0 : .into_iter()
4033 0 : .map(
4034 0 : |ShardGenerationState {
4035 : tenant_shard_id,
4036 : generation,
4037 : generation_pageserver: _,
4038 0 : }| (tenant_shard_id, generation),
4039 0 : )
4040 0 : .collect::<Vec<_>>()
4041 0 : != mutation_locations
4042 0 : .0
4043 0 : .into_iter()
4044 0 : .map(|i| (i.0, Some(i.1.latest.generation)))
4045 0 : .collect::<Vec<_>>()
4046 : {
4047 : // We raced with something that incremented the generation, and therefore cannot be
4048 : // confident that our actions are persistent (they might have hit an old generation).
4049 : //
4050 : // This is safe but requires a retry: ask the client to do that by giving them a 503 response.
4051 0 : return Err(ApiError::ResourceUnavailable(
4052 0 : "Tenant attachment changed, please retry".into(),
4053 0 : ));
4054 0 : }
4055 0 : }
4056 0 :
4057 0 : Ok(result)
4058 0 : }
4059 :
4060 0 : pub(crate) async fn tenant_timeline_delete(
4061 0 : &self,
4062 0 : tenant_id: TenantId,
4063 0 : timeline_id: TimelineId,
4064 0 : ) -> Result<StatusCode, ApiError> {
4065 0 : tracing::info!("Deleting timeline {}/{}", tenant_id, timeline_id,);
4066 0 : let _tenant_lock = trace_shared_lock(
4067 0 : &self.tenant_op_locks,
4068 0 : tenant_id,
4069 0 : TenantOperations::TimelineDelete,
4070 0 : )
4071 0 : .await;
4072 :
4073 0 : self.tenant_remote_mutation(tenant_id, move |mut targets| async move {
4074 0 : if targets.0.is_empty() {
4075 0 : return Err(ApiError::NotFound(
4076 0 : anyhow::anyhow!("Tenant not found").into(),
4077 0 : ));
4078 0 : }
4079 0 :
4080 0 : let (shard_zero_tid, shard_zero_locations) = targets.0.pop_first().expect("Must have at least one shard");
4081 0 : assert!(shard_zero_tid.is_shard_zero());
4082 :
4083 0 : async fn delete_one(
4084 0 : tenant_shard_id: TenantShardId,
4085 0 : timeline_id: TimelineId,
4086 0 : node: Node,
4087 0 : jwt: Option<String>,
4088 0 : ) -> Result<StatusCode, ApiError> {
4089 0 : tracing::info!(
4090 0 : "Deleting timeline on shard {tenant_shard_id}/{timeline_id}, attached to node {node}",
4091 : );
4092 :
4093 0 : let client = PageserverClient::new(node.get_id(), node.base_url(), jwt.as_deref());
4094 0 : let res = client
4095 0 : .timeline_delete(tenant_shard_id, timeline_id)
4096 0 : .await;
4097 :
4098 0 : match res {
4099 0 : Ok(ok) => Ok(ok),
4100 0 : Err(mgmt_api::Error::ApiError(StatusCode::CONFLICT, _)) => Ok(StatusCode::CONFLICT),
4101 0 : Err(mgmt_api::Error::ApiError(StatusCode::SERVICE_UNAVAILABLE, msg)) => Err(ApiError::ResourceUnavailable(msg.into())),
4102 0 : Err(e) => {
4103 0 : Err(
4104 0 : ApiError::InternalServerError(anyhow::anyhow!(
4105 0 : "Error deleting timeline {timeline_id} on {tenant_shard_id} on node {node}: {e}",
4106 0 : ))
4107 0 : )
4108 : }
4109 : }
4110 0 : }
4111 :
4112 0 : let locations = targets.0.iter().map(|t| (*t.0, t.1.latest.node.clone())).collect();
4113 0 : let statuses = self
4114 0 : .tenant_for_shards(locations, |tenant_shard_id: TenantShardId, node: Node| {
4115 0 : Box::pin(delete_one(
4116 0 : tenant_shard_id,
4117 0 : timeline_id,
4118 0 : node,
4119 0 : self.config.jwt_token.clone(),
4120 0 : ))
4121 0 : })
4122 0 : .await?;
4123 :
4124 : // If any shards >0 haven't finished deletion yet, don't start deletion on shard zero.
4125 : // We return 409 (Conflict) if deletion was already in progress on any of the shards
4126 : // and 202 (Accepted) if deletion was not already in progress on any of the shards.
4127 0 : if statuses.iter().any(|s| s == &StatusCode::CONFLICT) {
4128 0 : return Ok(StatusCode::CONFLICT);
4129 0 : }
4130 0 :
4131 0 : if statuses.iter().any(|s| s != &StatusCode::NOT_FOUND) {
4132 0 : return Ok(StatusCode::ACCEPTED);
4133 0 : }
4134 :
4135 : // Delete shard zero last: this is not strictly necessary, but since a caller's GET on a timeline will be routed
4136 : // to shard zero, it gives a more obvious behavior that a GET returns 404 once the deletion is done.
4137 0 : let shard_zero_status = delete_one(
4138 0 : shard_zero_tid,
4139 0 : timeline_id,
4140 0 : shard_zero_locations.latest.node,
4141 0 : self.config.jwt_token.clone(),
4142 0 : )
4143 0 : .await?;
4144 0 : Ok(shard_zero_status)
4145 0 : }).await?
4146 0 : }
4147 :
4148 : /// When you need to send an HTTP request to the pageserver that holds shard0 of a tenant, this
4149 : /// function looks up and returns node. If the tenant isn't found, returns Err(ApiError::NotFound)
4150 0 : pub(crate) async fn tenant_shard0_node(
4151 0 : &self,
4152 0 : tenant_id: TenantId,
4153 0 : ) -> Result<(Node, TenantShardId), ApiError> {
4154 0 : // Look up in-memory state and maybe use the node from there.
4155 0 : {
4156 0 : let locked = self.inner.read().unwrap();
4157 0 : let Some((tenant_shard_id, shard)) = locked
4158 0 : .tenants
4159 0 : .range(TenantShardId::tenant_range(tenant_id))
4160 0 : .next()
4161 : else {
4162 0 : return Err(ApiError::NotFound(
4163 0 : anyhow::anyhow!("Tenant {tenant_id} not found").into(),
4164 0 : ));
4165 : };
4166 :
4167 0 : let Some(intent_node_id) = shard.intent.get_attached() else {
4168 0 : tracing::warn!(
4169 0 : tenant_id=%tenant_shard_id.tenant_id, shard_id=%tenant_shard_id.shard_slug(),
4170 0 : "Shard not scheduled (policy {:?}), cannot generate pass-through URL",
4171 : shard.policy
4172 : );
4173 0 : return Err(ApiError::Conflict(
4174 0 : "Cannot call timeline API on non-attached tenant".to_string(),
4175 0 : ));
4176 : };
4177 :
4178 0 : if shard.reconciler.is_none() {
4179 : // Optimization: while no reconcile is in flight, we may trust our in-memory state
4180 : // to tell us which pageserver to use. Otherwise we will fall through and hit the database
4181 0 : let Some(node) = locked.nodes.get(intent_node_id) else {
4182 : // This should never happen
4183 0 : return Err(ApiError::InternalServerError(anyhow::anyhow!(
4184 0 : "Shard refers to nonexistent node"
4185 0 : )));
4186 : };
4187 0 : return Ok((node.clone(), *tenant_shard_id));
4188 0 : }
4189 : };
4190 :
4191 : // Look up the latest attached pageserver location from the database
4192 : // generation state: this will reflect the progress of any ongoing migration.
4193 : // Note that it is not guaranteed to _stay_ here, our caller must still handle
4194 : // the case where they call through to the pageserver and get a 404.
4195 0 : let db_result = self.persistence.tenant_generations(tenant_id).await?;
4196 : let Some(ShardGenerationState {
4197 0 : tenant_shard_id,
4198 0 : generation: _,
4199 0 : generation_pageserver: Some(node_id),
4200 0 : }) = db_result.first()
4201 : else {
4202 : // This can happen if we raced with a tenant deletion or a shard split. On a retry
4203 : // the caller will either succeed (shard split case), get a proper 404 (deletion case),
4204 : // or a conflict response (case where tenant was detached in background)
4205 0 : return Err(ApiError::ResourceUnavailable(
4206 0 : "Shard {} not found in database, or is not attached".into(),
4207 0 : ));
4208 : };
4209 0 : let locked = self.inner.read().unwrap();
4210 0 : let Some(node) = locked.nodes.get(node_id) else {
4211 : // This should never happen
4212 0 : return Err(ApiError::InternalServerError(anyhow::anyhow!(
4213 0 : "Shard refers to nonexistent node"
4214 0 : )));
4215 : };
4216 :
4217 0 : Ok((node.clone(), *tenant_shard_id))
4218 0 : }
4219 :
4220 0 : pub(crate) fn tenant_locate(
4221 0 : &self,
4222 0 : tenant_id: TenantId,
4223 0 : ) -> Result<TenantLocateResponse, ApiError> {
4224 0 : let locked = self.inner.read().unwrap();
4225 0 : tracing::info!("Locating shards for tenant {tenant_id}");
4226 :
4227 0 : let mut result = Vec::new();
4228 0 : let mut shard_params: Option<ShardParameters> = None;
4229 :
4230 0 : for (tenant_shard_id, shard) in locked.tenants.range(TenantShardId::tenant_range(tenant_id))
4231 : {
4232 0 : let node_id =
4233 0 : shard
4234 0 : .intent
4235 0 : .get_attached()
4236 0 : .ok_or(ApiError::BadRequest(anyhow::anyhow!(
4237 0 : "Cannot locate a tenant that is not attached"
4238 0 : )))?;
4239 :
4240 0 : let node = locked
4241 0 : .nodes
4242 0 : .get(&node_id)
4243 0 : .expect("Pageservers may not be deleted while referenced");
4244 0 :
4245 0 : result.push(node.shard_location(*tenant_shard_id));
4246 0 :
4247 0 : match &shard_params {
4248 0 : None => {
4249 0 : shard_params = Some(ShardParameters {
4250 0 : stripe_size: shard.shard.stripe_size,
4251 0 : count: shard.shard.count,
4252 0 : });
4253 0 : }
4254 0 : Some(params) => {
4255 0 : if params.stripe_size != shard.shard.stripe_size {
4256 : // This should never happen. We enforce at runtime because it's simpler than
4257 : // adding an extra per-tenant data structure to store the things that should be the same
4258 0 : return Err(ApiError::InternalServerError(anyhow::anyhow!(
4259 0 : "Inconsistent shard stripe size parameters!"
4260 0 : )));
4261 0 : }
4262 : }
4263 : }
4264 : }
4265 :
4266 0 : if result.is_empty() {
4267 0 : return Err(ApiError::NotFound(
4268 0 : anyhow::anyhow!("No shards for this tenant ID found").into(),
4269 0 : ));
4270 0 : }
4271 0 : let shard_params = shard_params.expect("result is non-empty, therefore this is set");
4272 0 : tracing::info!(
4273 0 : "Located tenant {} with params {:?} on shards {}",
4274 0 : tenant_id,
4275 0 : shard_params,
4276 0 : result
4277 0 : .iter()
4278 0 : .map(|s| format!("{:?}", s))
4279 0 : .collect::<Vec<_>>()
4280 0 : .join(",")
4281 : );
4282 :
4283 0 : Ok(TenantLocateResponse {
4284 0 : shards: result,
4285 0 : shard_params,
4286 0 : })
4287 0 : }
4288 :
4289 : /// Returns None if the input iterator of shards does not include a shard with number=0
4290 0 : fn tenant_describe_impl<'a>(
4291 0 : &self,
4292 0 : shards: impl Iterator<Item = &'a TenantShard>,
4293 0 : ) -> Option<TenantDescribeResponse> {
4294 0 : let mut shard_zero = None;
4295 0 : let mut describe_shards = Vec::new();
4296 :
4297 0 : for shard in shards {
4298 0 : if shard.tenant_shard_id.is_shard_zero() {
4299 0 : shard_zero = Some(shard);
4300 0 : }
4301 :
4302 0 : describe_shards.push(TenantDescribeResponseShard {
4303 0 : tenant_shard_id: shard.tenant_shard_id,
4304 0 : node_attached: *shard.intent.get_attached(),
4305 0 : node_secondary: shard.intent.get_secondary().to_vec(),
4306 0 : last_error: shard
4307 0 : .last_error
4308 0 : .lock()
4309 0 : .unwrap()
4310 0 : .as_ref()
4311 0 : .map(|e| format!("{e}"))
4312 0 : .unwrap_or("".to_string())
4313 0 : .clone(),
4314 0 : is_reconciling: shard.reconciler.is_some(),
4315 0 : is_pending_compute_notification: shard.pending_compute_notification,
4316 0 : is_splitting: matches!(shard.splitting, SplitState::Splitting),
4317 0 : scheduling_policy: *shard.get_scheduling_policy(),
4318 0 : preferred_az_id: shard.preferred_az().map(ToString::to_string),
4319 : })
4320 : }
4321 :
4322 0 : let shard_zero = shard_zero?;
4323 :
4324 0 : Some(TenantDescribeResponse {
4325 0 : tenant_id: shard_zero.tenant_shard_id.tenant_id,
4326 0 : shards: describe_shards,
4327 0 : stripe_size: shard_zero.shard.stripe_size,
4328 0 : policy: shard_zero.policy.clone(),
4329 0 : config: shard_zero.config.clone(),
4330 0 : })
4331 0 : }
4332 :
4333 0 : pub(crate) fn tenant_describe(
4334 0 : &self,
4335 0 : tenant_id: TenantId,
4336 0 : ) -> Result<TenantDescribeResponse, ApiError> {
4337 0 : let locked = self.inner.read().unwrap();
4338 0 :
4339 0 : self.tenant_describe_impl(
4340 0 : locked
4341 0 : .tenants
4342 0 : .range(TenantShardId::tenant_range(tenant_id))
4343 0 : .map(|(_k, v)| v),
4344 0 : )
4345 0 : .ok_or_else(|| ApiError::NotFound(anyhow::anyhow!("Tenant {tenant_id} not found").into()))
4346 0 : }
4347 :
4348 : /// limit & offset are pagination parameters. Since we are walking an in-memory HashMap, `offset` does not
4349 : /// avoid traversing data, it just avoid returning it. This is suitable for our purposes, since our in memory
4350 : /// maps are small enough to traverse fast, our pagination is just to avoid serializing huge JSON responses
4351 : /// in our external API.
4352 0 : pub(crate) fn tenant_list(
4353 0 : &self,
4354 0 : limit: Option<usize>,
4355 0 : start_after: Option<TenantId>,
4356 0 : ) -> Vec<TenantDescribeResponse> {
4357 0 : let locked = self.inner.read().unwrap();
4358 :
4359 : // Apply start_from parameter
4360 0 : let shard_range = match start_after {
4361 0 : None => locked.tenants.range(..),
4362 0 : Some(tenant_id) => locked.tenants.range(
4363 0 : TenantShardId {
4364 0 : tenant_id,
4365 0 : shard_number: ShardNumber(u8::MAX),
4366 0 : shard_count: ShardCount(u8::MAX),
4367 0 : }..,
4368 0 : ),
4369 : };
4370 :
4371 0 : let mut result = Vec::new();
4372 0 : for (_tenant_id, tenant_shards) in &shard_range.group_by(|(id, _shard)| id.tenant_id) {
4373 0 : result.push(
4374 0 : self.tenant_describe_impl(tenant_shards.map(|(_k, v)| v))
4375 0 : .expect("Groups are always non-empty"),
4376 0 : );
4377 :
4378 : // Enforce `limit` parameter
4379 0 : if let Some(limit) = limit {
4380 0 : if result.len() >= limit {
4381 0 : break;
4382 0 : }
4383 0 : }
4384 : }
4385 :
4386 0 : result
4387 0 : }
4388 :
4389 : #[instrument(skip_all, fields(tenant_id=%op.tenant_id))]
4390 : async fn abort_tenant_shard_split(
4391 : &self,
4392 : op: &TenantShardSplitAbort,
4393 : ) -> Result<(), TenantShardSplitAbortError> {
4394 : // Cleaning up a split:
4395 : // - Parent shards are not destroyed during a split, just detached.
4396 : // - Failed pageserver split API calls can leave the remote node with just the parent attached,
4397 : // just the children attached, or both.
4398 : //
4399 : // Therefore our work to do is to:
4400 : // 1. Clean up storage controller's internal state to just refer to parents, no children
4401 : // 2. Call out to pageservers to ensure that children are detached
4402 : // 3. Call out to pageservers to ensure that parents are attached.
4403 : //
4404 : // Crash safety:
4405 : // - If the storage controller stops running during this cleanup *after* clearing the splitting state
4406 : // from our database, then [`Self::startup_reconcile`] will regard child attachments as garbage
4407 : // and detach them.
4408 : // - TODO: If the storage controller stops running during this cleanup *before* clearing the splitting state
4409 : // from our database, then we will re-enter this cleanup routine on startup.
4410 :
4411 : let TenantShardSplitAbort {
4412 : tenant_id,
4413 : new_shard_count,
4414 : new_stripe_size,
4415 : ..
4416 : } = op;
4417 :
4418 : // First abort persistent state, if any exists.
4419 : match self
4420 : .persistence
4421 : .abort_shard_split(*tenant_id, *new_shard_count)
4422 : .await?
4423 : {
4424 : AbortShardSplitStatus::Aborted => {
4425 : // Proceed to roll back any child shards created on pageservers
4426 : }
4427 : AbortShardSplitStatus::Complete => {
4428 : // The split completed (we might hit that path if e.g. our database transaction
4429 : // to write the completion landed in the database, but we dropped connection
4430 : // before seeing the result).
4431 : //
4432 : // We must update in-memory state to reflect the successful split.
4433 : self.tenant_shard_split_commit_inmem(
4434 : *tenant_id,
4435 : *new_shard_count,
4436 : *new_stripe_size,
4437 : );
4438 : return Ok(());
4439 : }
4440 : }
4441 :
4442 : // Clean up in-memory state, and accumulate the list of child locations that need detaching
4443 : let detach_locations: Vec<(Node, TenantShardId)> = {
4444 : let mut detach_locations = Vec::new();
4445 : let mut locked = self.inner.write().unwrap();
4446 : let (nodes, tenants, scheduler) = locked.parts_mut();
4447 :
4448 : for (tenant_shard_id, shard) in
4449 : tenants.range_mut(TenantShardId::tenant_range(op.tenant_id))
4450 : {
4451 : if shard.shard.count == op.new_shard_count {
4452 : // Surprising: the phase of [`Self::do_tenant_shard_split`] which inserts child shards in-memory
4453 : // is infallible, so if we got an error we shouldn't have got that far.
4454 : tracing::warn!(
4455 : "During split abort, child shard {tenant_shard_id} found in-memory"
4456 : );
4457 : continue;
4458 : }
4459 :
4460 : // Add the children of this shard to this list of things to detach
4461 : if let Some(node_id) = shard.intent.get_attached() {
4462 : for child_id in tenant_shard_id.split(*new_shard_count) {
4463 : detach_locations.push((
4464 : nodes
4465 : .get(node_id)
4466 : .expect("Intent references nonexistent node")
4467 : .clone(),
4468 : child_id,
4469 : ));
4470 : }
4471 : } else {
4472 : tracing::warn!(
4473 : "During split abort, shard {tenant_shard_id} has no attached location"
4474 : );
4475 : }
4476 :
4477 : tracing::info!("Restoring parent shard {tenant_shard_id}");
4478 :
4479 : // Drop any intents that refer to unavailable nodes, to enable this abort to proceed even
4480 : // if the original attachment location is offline.
4481 : if let Some(node_id) = shard.intent.get_attached() {
4482 : if !nodes.get(node_id).unwrap().is_available() {
4483 : tracing::info!("Demoting attached intent for {tenant_shard_id} on unavailable node {node_id}");
4484 : shard.intent.demote_attached(scheduler, *node_id);
4485 : }
4486 : }
4487 : for node_id in shard.intent.get_secondary().clone() {
4488 : if !nodes.get(&node_id).unwrap().is_available() {
4489 : tracing::info!("Dropping secondary intent for {tenant_shard_id} on unavailable node {node_id}");
4490 : shard.intent.remove_secondary(scheduler, node_id);
4491 : }
4492 : }
4493 :
4494 : shard.splitting = SplitState::Idle;
4495 : if let Err(e) = shard.schedule(scheduler, &mut ScheduleContext::default()) {
4496 : // If this shard can't be scheduled now (perhaps due to offline nodes or
4497 : // capacity issues), that must not prevent us rolling back a split. In this
4498 : // case it should be eventually scheduled in the background.
4499 : tracing::warn!("Failed to schedule {tenant_shard_id} during shard abort: {e}")
4500 : }
4501 :
4502 : self.maybe_reconcile_shard(shard, nodes, ReconcilerPriority::High);
4503 : }
4504 :
4505 : // We don't expect any new_shard_count shards to exist here, but drop them just in case
4506 0 : tenants.retain(|_id, s| s.shard.count != *new_shard_count);
4507 :
4508 : detach_locations
4509 : };
4510 :
4511 : for (node, child_id) in detach_locations {
4512 : if !node.is_available() {
4513 : // An unavailable node cannot be cleaned up now: to avoid blocking forever, we will permit this, and
4514 : // rely on the reconciliation that happens when a node transitions to Active to clean up. Since we have
4515 : // removed child shards from our in-memory state and database, the reconciliation will implicitly remove
4516 : // them from the node.
4517 : tracing::warn!("Node {node} unavailable, can't clean up during split abort. It will be cleaned up when it is reactivated.");
4518 : continue;
4519 : }
4520 :
4521 : // Detach the remote child. If the pageserver split API call is still in progress, this call will get
4522 : // a 503 and retry, up to our limit.
4523 : tracing::info!("Detaching {child_id} on {node}...");
4524 : match node
4525 : .with_client_retries(
4526 0 : |client| async move {
4527 0 : let config = LocationConfig {
4528 0 : mode: LocationConfigMode::Detached,
4529 0 : generation: None,
4530 0 : secondary_conf: None,
4531 0 : shard_number: child_id.shard_number.0,
4532 0 : shard_count: child_id.shard_count.literal(),
4533 0 : // Stripe size and tenant config don't matter when detaching
4534 0 : shard_stripe_size: 0,
4535 0 : tenant_conf: TenantConfig::default(),
4536 0 : };
4537 0 :
4538 0 : client.location_config(child_id, config, None, false).await
4539 0 : },
4540 : &self.config.jwt_token,
4541 : 1,
4542 : 10,
4543 : Duration::from_secs(5),
4544 : &self.cancel,
4545 : )
4546 : .await
4547 : {
4548 : Some(Ok(_)) => {}
4549 : Some(Err(e)) => {
4550 : // We failed to communicate with the remote node. This is problematic: we may be
4551 : // leaving it with a rogue child shard.
4552 : tracing::warn!(
4553 : "Failed to detach child {child_id} from node {node} during abort"
4554 : );
4555 : return Err(e.into());
4556 : }
4557 : None => {
4558 : // Cancellation: we were shutdown or the node went offline. Shutdown is fine, we'll
4559 : // clean up on restart. The node going offline requires a retry.
4560 : return Err(TenantShardSplitAbortError::Unavailable);
4561 : }
4562 : };
4563 : }
4564 :
4565 : tracing::info!("Successfully aborted split");
4566 : Ok(())
4567 : }
4568 :
4569 : /// Infallible final stage of [`Self::tenant_shard_split`]: update the contents
4570 : /// of the tenant map to reflect the child shards that exist after the split.
4571 0 : fn tenant_shard_split_commit_inmem(
4572 0 : &self,
4573 0 : tenant_id: TenantId,
4574 0 : new_shard_count: ShardCount,
4575 0 : new_stripe_size: Option<ShardStripeSize>,
4576 0 : ) -> (
4577 0 : TenantShardSplitResponse,
4578 0 : Vec<(TenantShardId, NodeId, ShardStripeSize)>,
4579 0 : Vec<ReconcilerWaiter>,
4580 0 : ) {
4581 0 : let mut response = TenantShardSplitResponse {
4582 0 : new_shards: Vec::new(),
4583 0 : };
4584 0 : let mut child_locations = Vec::new();
4585 0 : let mut waiters = Vec::new();
4586 0 :
4587 0 : {
4588 0 : let mut locked = self.inner.write().unwrap();
4589 0 :
4590 0 : let parent_ids = locked
4591 0 : .tenants
4592 0 : .range(TenantShardId::tenant_range(tenant_id))
4593 0 : .map(|(shard_id, _)| *shard_id)
4594 0 : .collect::<Vec<_>>();
4595 0 :
4596 0 : let (nodes, tenants, scheduler) = locked.parts_mut();
4597 0 : for parent_id in parent_ids {
4598 0 : let child_ids = parent_id.split(new_shard_count);
4599 :
4600 0 : let (pageserver, generation, policy, parent_ident, config, preferred_az) = {
4601 0 : let mut old_state = tenants
4602 0 : .remove(&parent_id)
4603 0 : .expect("It was present, we just split it");
4604 0 :
4605 0 : // A non-splitting state is impossible, because [`Self::tenant_shard_split`] holds
4606 0 : // a TenantId lock and passes it through to [`TenantShardSplitAbort`] in case of cleanup:
4607 0 : // nothing else can clear this.
4608 0 : assert!(matches!(old_state.splitting, SplitState::Splitting));
4609 :
4610 0 : let old_attached = old_state.intent.get_attached().unwrap();
4611 0 : old_state.intent.clear(scheduler);
4612 0 : let generation = old_state.generation.expect("Shard must have been attached");
4613 0 : (
4614 0 : old_attached,
4615 0 : generation,
4616 0 : old_state.policy.clone(),
4617 0 : old_state.shard,
4618 0 : old_state.config.clone(),
4619 0 : old_state.preferred_az().cloned(),
4620 0 : )
4621 0 : };
4622 0 :
4623 0 : let mut schedule_context = ScheduleContext::default();
4624 0 : for child in child_ids {
4625 0 : let mut child_shard = parent_ident;
4626 0 : child_shard.number = child.shard_number;
4627 0 : child_shard.count = child.shard_count;
4628 0 : if let Some(stripe_size) = new_stripe_size {
4629 0 : child_shard.stripe_size = stripe_size;
4630 0 : }
4631 :
4632 0 : let mut child_observed: HashMap<NodeId, ObservedStateLocation> = HashMap::new();
4633 0 : child_observed.insert(
4634 0 : pageserver,
4635 0 : ObservedStateLocation {
4636 0 : conf: Some(attached_location_conf(
4637 0 : generation,
4638 0 : &child_shard,
4639 0 : &config,
4640 0 : &policy,
4641 0 : )),
4642 0 : },
4643 0 : );
4644 0 :
4645 0 : let mut child_state =
4646 0 : TenantShard::new(child, child_shard, policy.clone(), preferred_az.clone());
4647 0 : child_state.intent =
4648 0 : IntentState::single(scheduler, Some(pageserver), preferred_az.clone());
4649 0 : child_state.observed = ObservedState {
4650 0 : locations: child_observed,
4651 0 : };
4652 0 : child_state.generation = Some(generation);
4653 0 : child_state.config = config.clone();
4654 0 :
4655 0 : // The child's TenantShard::splitting is intentionally left at the default value of Idle,
4656 0 : // as at this point in the split process we have succeeded and this part is infallible:
4657 0 : // we will never need to do any special recovery from this state.
4658 0 :
4659 0 : child_locations.push((child, pageserver, child_shard.stripe_size));
4660 :
4661 0 : if let Err(e) = child_state.schedule(scheduler, &mut schedule_context) {
4662 : // This is not fatal, because we've implicitly already got an attached
4663 : // location for the child shard. Failure here just means we couldn't
4664 : // find a secondary (e.g. because cluster is overloaded).
4665 0 : tracing::warn!("Failed to schedule child shard {child}: {e}");
4666 0 : }
4667 : // In the background, attach secondary locations for the new shards
4668 0 : if let Some(waiter) = self.maybe_reconcile_shard(
4669 0 : &mut child_state,
4670 0 : nodes,
4671 0 : ReconcilerPriority::High,
4672 0 : ) {
4673 0 : waiters.push(waiter);
4674 0 : }
4675 :
4676 0 : tenants.insert(child, child_state);
4677 0 : response.new_shards.push(child);
4678 : }
4679 : }
4680 0 : (response, child_locations, waiters)
4681 0 : }
4682 0 : }
4683 :
4684 0 : async fn tenant_shard_split_start_secondaries(
4685 0 : &self,
4686 0 : tenant_id: TenantId,
4687 0 : waiters: Vec<ReconcilerWaiter>,
4688 0 : ) {
4689 : // Wait for initial reconcile of child shards, this creates the secondary locations
4690 0 : if let Err(e) = self.await_waiters(waiters, RECONCILE_TIMEOUT).await {
4691 : // This is not a failure to split: it's some issue reconciling the new child shards, perhaps
4692 : // their secondaries couldn't be attached.
4693 0 : tracing::warn!("Failed to reconcile after split: {e}");
4694 0 : return;
4695 0 : }
4696 :
4697 : // Take the state lock to discover the attached & secondary intents for all shards
4698 0 : let (attached, secondary) = {
4699 0 : let locked = self.inner.read().unwrap();
4700 0 : let mut attached = Vec::new();
4701 0 : let mut secondary = Vec::new();
4702 :
4703 0 : for (tenant_shard_id, shard) in
4704 0 : locked.tenants.range(TenantShardId::tenant_range(tenant_id))
4705 : {
4706 0 : let Some(node_id) = shard.intent.get_attached() else {
4707 : // Unexpected. Race with a PlacementPolicy change?
4708 0 : tracing::warn!(
4709 0 : "No attached node on {tenant_shard_id} immediately after shard split!"
4710 : );
4711 0 : continue;
4712 : };
4713 :
4714 0 : let Some(secondary_node_id) = shard.intent.get_secondary().first() else {
4715 : // No secondary location. Nothing for us to do.
4716 0 : continue;
4717 : };
4718 :
4719 0 : let attached_node = locked
4720 0 : .nodes
4721 0 : .get(node_id)
4722 0 : .expect("Pageservers may not be deleted while referenced");
4723 0 :
4724 0 : let secondary_node = locked
4725 0 : .nodes
4726 0 : .get(secondary_node_id)
4727 0 : .expect("Pageservers may not be deleted while referenced");
4728 0 :
4729 0 : attached.push((*tenant_shard_id, attached_node.clone()));
4730 0 : secondary.push((*tenant_shard_id, secondary_node.clone()));
4731 : }
4732 0 : (attached, secondary)
4733 0 : };
4734 0 :
4735 0 : if secondary.is_empty() {
4736 : // No secondary locations; nothing for us to do
4737 0 : return;
4738 0 : }
4739 :
4740 0 : for result in self
4741 0 : .tenant_for_shards_api(
4742 0 : attached,
4743 0 : |tenant_shard_id, client| async move {
4744 0 : client.tenant_heatmap_upload(tenant_shard_id).await
4745 0 : },
4746 0 : 1,
4747 0 : 1,
4748 0 : SHORT_RECONCILE_TIMEOUT,
4749 0 : &self.cancel,
4750 0 : )
4751 0 : .await
4752 : {
4753 0 : if let Err(e) = result {
4754 0 : tracing::warn!("Error calling heatmap upload after shard split: {e}");
4755 0 : return;
4756 0 : }
4757 : }
4758 :
4759 0 : for result in self
4760 0 : .tenant_for_shards_api(
4761 0 : secondary,
4762 0 : |tenant_shard_id, client| async move {
4763 0 : client
4764 0 : .tenant_secondary_download(tenant_shard_id, Some(Duration::ZERO))
4765 0 : .await
4766 0 : },
4767 0 : 1,
4768 0 : 1,
4769 0 : SHORT_RECONCILE_TIMEOUT,
4770 0 : &self.cancel,
4771 0 : )
4772 0 : .await
4773 : {
4774 0 : if let Err(e) = result {
4775 0 : tracing::warn!("Error calling secondary download after shard split: {e}");
4776 0 : return;
4777 0 : }
4778 : }
4779 0 : }
4780 :
4781 0 : pub(crate) async fn tenant_shard_split(
4782 0 : &self,
4783 0 : tenant_id: TenantId,
4784 0 : split_req: TenantShardSplitRequest,
4785 0 : ) -> Result<TenantShardSplitResponse, ApiError> {
4786 : // TODO: return 503 if we get stuck waiting for this lock
4787 : // (issue https://github.com/neondatabase/neon/issues/7108)
4788 0 : let _tenant_lock = trace_exclusive_lock(
4789 0 : &self.tenant_op_locks,
4790 0 : tenant_id,
4791 0 : TenantOperations::ShardSplit,
4792 0 : )
4793 0 : .await;
4794 :
4795 0 : let new_shard_count = ShardCount::new(split_req.new_shard_count);
4796 0 : let new_stripe_size = split_req.new_stripe_size;
4797 :
4798 : // Validate the request and construct parameters. This phase is fallible, but does not require
4799 : // rollback on errors, as it does no I/O and mutates no state.
4800 0 : let shard_split_params = match self.prepare_tenant_shard_split(tenant_id, split_req)? {
4801 0 : ShardSplitAction::NoOp(resp) => return Ok(resp),
4802 0 : ShardSplitAction::Split(params) => params,
4803 : };
4804 :
4805 : // Execute this split: this phase mutates state and does remote I/O on pageservers. If it fails,
4806 : // we must roll back.
4807 0 : let r = self
4808 0 : .do_tenant_shard_split(tenant_id, shard_split_params)
4809 0 : .await;
4810 :
4811 0 : let (response, waiters) = match r {
4812 0 : Ok(r) => r,
4813 0 : Err(e) => {
4814 0 : // Split might be part-done, we must do work to abort it.
4815 0 : tracing::warn!("Enqueuing background abort of split on {tenant_id}");
4816 0 : self.abort_tx
4817 0 : .send(TenantShardSplitAbort {
4818 0 : tenant_id,
4819 0 : new_shard_count,
4820 0 : new_stripe_size,
4821 0 : _tenant_lock,
4822 0 : })
4823 0 : // Ignore error sending: that just means we're shutting down: aborts are ephemeral so it's fine to drop it.
4824 0 : .ok();
4825 0 : return Err(e);
4826 : }
4827 : };
4828 :
4829 : // The split is now complete. As an optimization, we will trigger all the child shards to upload
4830 : // a heatmap immediately, and all their secondary locations to start downloading: this avoids waiting
4831 : // for the background heatmap/download interval before secondaries get warm enough to migrate shards
4832 : // in [`Self::optimize_all`]
4833 0 : self.tenant_shard_split_start_secondaries(tenant_id, waiters)
4834 0 : .await;
4835 0 : Ok(response)
4836 0 : }
4837 :
4838 0 : fn prepare_tenant_shard_split(
4839 0 : &self,
4840 0 : tenant_id: TenantId,
4841 0 : split_req: TenantShardSplitRequest,
4842 0 : ) -> Result<ShardSplitAction, ApiError> {
4843 0 : fail::fail_point!("shard-split-validation", |_| Err(ApiError::BadRequest(
4844 0 : anyhow::anyhow!("failpoint")
4845 0 : )));
4846 :
4847 0 : let mut policy = None;
4848 0 : let mut config = None;
4849 0 : let mut shard_ident = None;
4850 0 : let mut preferred_az_id = None;
4851 : // Validate input, and calculate which shards we will create
4852 0 : let (old_shard_count, targets) =
4853 : {
4854 0 : let locked = self.inner.read().unwrap();
4855 0 :
4856 0 : let pageservers = locked.nodes.clone();
4857 0 :
4858 0 : let mut targets = Vec::new();
4859 0 :
4860 0 : // In case this is a retry, count how many already-split shards we found
4861 0 : let mut children_found = Vec::new();
4862 0 : let mut old_shard_count = None;
4863 :
4864 0 : for (tenant_shard_id, shard) in
4865 0 : locked.tenants.range(TenantShardId::tenant_range(tenant_id))
4866 : {
4867 0 : match shard.shard.count.count().cmp(&split_req.new_shard_count) {
4868 : Ordering::Equal => {
4869 : // Already split this
4870 0 : children_found.push(*tenant_shard_id);
4871 0 : continue;
4872 : }
4873 : Ordering::Greater => {
4874 0 : return Err(ApiError::BadRequest(anyhow::anyhow!(
4875 0 : "Requested count {} but already have shards at count {}",
4876 0 : split_req.new_shard_count,
4877 0 : shard.shard.count.count()
4878 0 : )));
4879 : }
4880 0 : Ordering::Less => {
4881 0 : // Fall through: this shard has lower count than requested,
4882 0 : // is a candidate for splitting.
4883 0 : }
4884 0 : }
4885 0 :
4886 0 : match old_shard_count {
4887 0 : None => old_shard_count = Some(shard.shard.count),
4888 0 : Some(old_shard_count) => {
4889 0 : if old_shard_count != shard.shard.count {
4890 : // We may hit this case if a caller asked for two splits to
4891 : // different sizes, before the first one is complete.
4892 : // e.g. 1->2, 2->4, where the 4 call comes while we have a mixture
4893 : // of shard_count=1 and shard_count=2 shards in the map.
4894 0 : return Err(ApiError::Conflict(
4895 0 : "Cannot split, currently mid-split".to_string(),
4896 0 : ));
4897 0 : }
4898 : }
4899 : }
4900 0 : if policy.is_none() {
4901 0 : policy = Some(shard.policy.clone());
4902 0 : }
4903 0 : if shard_ident.is_none() {
4904 0 : shard_ident = Some(shard.shard);
4905 0 : }
4906 0 : if config.is_none() {
4907 0 : config = Some(shard.config.clone());
4908 0 : }
4909 0 : if preferred_az_id.is_none() {
4910 0 : preferred_az_id = shard.preferred_az().cloned();
4911 0 : }
4912 :
4913 0 : if tenant_shard_id.shard_count.count() == split_req.new_shard_count {
4914 0 : tracing::info!(
4915 0 : "Tenant shard {} already has shard count {}",
4916 : tenant_shard_id,
4917 : split_req.new_shard_count
4918 : );
4919 0 : continue;
4920 0 : }
4921 :
4922 0 : let node_id = shard.intent.get_attached().ok_or(ApiError::BadRequest(
4923 0 : anyhow::anyhow!("Cannot split a tenant that is not attached"),
4924 0 : ))?;
4925 :
4926 0 : let node = pageservers
4927 0 : .get(&node_id)
4928 0 : .expect("Pageservers may not be deleted while referenced");
4929 0 :
4930 0 : targets.push(ShardSplitTarget {
4931 0 : parent_id: *tenant_shard_id,
4932 0 : node: node.clone(),
4933 0 : child_ids: tenant_shard_id
4934 0 : .split(ShardCount::new(split_req.new_shard_count)),
4935 0 : });
4936 : }
4937 :
4938 0 : if targets.is_empty() {
4939 0 : if children_found.len() == split_req.new_shard_count as usize {
4940 0 : return Ok(ShardSplitAction::NoOp(TenantShardSplitResponse {
4941 0 : new_shards: children_found,
4942 0 : }));
4943 : } else {
4944 : // No shards found to split, and no existing children found: the
4945 : // tenant doesn't exist at all.
4946 0 : return Err(ApiError::NotFound(
4947 0 : anyhow::anyhow!("Tenant {} not found", tenant_id).into(),
4948 0 : ));
4949 : }
4950 0 : }
4951 0 :
4952 0 : (old_shard_count, targets)
4953 0 : };
4954 0 :
4955 0 : // unwrap safety: we would have returned above if we didn't find at least one shard to split
4956 0 : let old_shard_count = old_shard_count.unwrap();
4957 0 : let shard_ident = if let Some(new_stripe_size) = split_req.new_stripe_size {
4958 : // This ShardIdentity will be used as the template for all children, so this implicitly
4959 : // applies the new stripe size to the children.
4960 0 : let mut shard_ident = shard_ident.unwrap();
4961 0 : if shard_ident.count.count() > 1 && shard_ident.stripe_size != new_stripe_size {
4962 0 : return Err(ApiError::BadRequest(anyhow::anyhow!("Attempted to change stripe size ({:?}->{new_stripe_size:?}) on a tenant with multiple shards", shard_ident.stripe_size)));
4963 0 : }
4964 0 :
4965 0 : shard_ident.stripe_size = new_stripe_size;
4966 0 : tracing::info!("applied stripe size {}", shard_ident.stripe_size.0);
4967 0 : shard_ident
4968 : } else {
4969 0 : shard_ident.unwrap()
4970 : };
4971 0 : let policy = policy.unwrap();
4972 0 : let config = config.unwrap();
4973 0 :
4974 0 : Ok(ShardSplitAction::Split(Box::new(ShardSplitParams {
4975 0 : old_shard_count,
4976 0 : new_shard_count: ShardCount::new(split_req.new_shard_count),
4977 0 : new_stripe_size: split_req.new_stripe_size,
4978 0 : targets,
4979 0 : policy,
4980 0 : config,
4981 0 : shard_ident,
4982 0 : preferred_az_id,
4983 0 : })))
4984 0 : }
4985 :
4986 0 : async fn do_tenant_shard_split(
4987 0 : &self,
4988 0 : tenant_id: TenantId,
4989 0 : params: Box<ShardSplitParams>,
4990 0 : ) -> Result<(TenantShardSplitResponse, Vec<ReconcilerWaiter>), ApiError> {
4991 0 : // FIXME: we have dropped self.inner lock, and not yet written anything to the database: another
4992 0 : // request could occur here, deleting or mutating the tenant. begin_shard_split checks that the
4993 0 : // parent shards exist as expected, but it would be neater to do the above pre-checks within the
4994 0 : // same database transaction rather than pre-check in-memory and then maybe-fail the database write.
4995 0 : // (https://github.com/neondatabase/neon/issues/6676)
4996 0 :
4997 0 : let ShardSplitParams {
4998 0 : old_shard_count,
4999 0 : new_shard_count,
5000 0 : new_stripe_size,
5001 0 : mut targets,
5002 0 : policy,
5003 0 : config,
5004 0 : shard_ident,
5005 0 : preferred_az_id,
5006 0 : } = *params;
5007 :
5008 : // Drop any secondary locations: pageservers do not support splitting these, and in any case the
5009 : // end-state for a split tenant will usually be to have secondary locations on different nodes.
5010 : // The reconciliation calls in this block also implicitly cancel+barrier wrt any ongoing reconciliation
5011 : // at the time of split.
5012 0 : let waiters = {
5013 0 : let mut locked = self.inner.write().unwrap();
5014 0 : let mut waiters = Vec::new();
5015 0 : let (nodes, tenants, scheduler) = locked.parts_mut();
5016 0 : for target in &mut targets {
5017 0 : let Some(shard) = tenants.get_mut(&target.parent_id) else {
5018 : // Paranoia check: this shouldn't happen: we have the oplock for this tenant ID.
5019 0 : return Err(ApiError::InternalServerError(anyhow::anyhow!(
5020 0 : "Shard {} not found",
5021 0 : target.parent_id
5022 0 : )));
5023 : };
5024 :
5025 0 : if shard.intent.get_attached() != &Some(target.node.get_id()) {
5026 : // Paranoia check: this shouldn't happen: we have the oplock for this tenant ID.
5027 0 : return Err(ApiError::Conflict(format!(
5028 0 : "Shard {} unexpectedly rescheduled during split",
5029 0 : target.parent_id
5030 0 : )));
5031 0 : }
5032 0 :
5033 0 : // Irrespective of PlacementPolicy, clear secondary locations from intent
5034 0 : shard.intent.clear_secondary(scheduler);
5035 :
5036 : // Run Reconciler to execute detach fo secondary locations.
5037 0 : if let Some(waiter) =
5038 0 : self.maybe_reconcile_shard(shard, nodes, ReconcilerPriority::High)
5039 0 : {
5040 0 : waiters.push(waiter);
5041 0 : }
5042 : }
5043 0 : waiters
5044 0 : };
5045 0 : self.await_waiters(waiters, RECONCILE_TIMEOUT).await?;
5046 :
5047 : // Before creating any new child shards in memory or on the pageservers, persist them: this
5048 : // enables us to ensure that we will always be able to clean up if something goes wrong. This also
5049 : // acts as the protection against two concurrent attempts to split: one of them will get a database
5050 : // error trying to insert the child shards.
5051 0 : let mut child_tsps = Vec::new();
5052 0 : for target in &targets {
5053 0 : let mut this_child_tsps = Vec::new();
5054 0 : for child in &target.child_ids {
5055 0 : let mut child_shard = shard_ident;
5056 0 : child_shard.number = child.shard_number;
5057 0 : child_shard.count = child.shard_count;
5058 0 :
5059 0 : tracing::info!(
5060 0 : "Create child shard persistence with stripe size {}",
5061 : shard_ident.stripe_size.0
5062 : );
5063 :
5064 0 : this_child_tsps.push(TenantShardPersistence {
5065 0 : tenant_id: child.tenant_id.to_string(),
5066 0 : shard_number: child.shard_number.0 as i32,
5067 0 : shard_count: child.shard_count.literal() as i32,
5068 0 : shard_stripe_size: shard_ident.stripe_size.0 as i32,
5069 0 : // Note: this generation is a placeholder, [`Persistence::begin_shard_split`] will
5070 0 : // populate the correct generation as part of its transaction, to protect us
5071 0 : // against racing with changes in the state of the parent.
5072 0 : generation: None,
5073 0 : generation_pageserver: Some(target.node.get_id().0 as i64),
5074 0 : placement_policy: serde_json::to_string(&policy).unwrap(),
5075 0 : config: serde_json::to_string(&config).unwrap(),
5076 0 : splitting: SplitState::Splitting,
5077 0 :
5078 0 : // Scheduling policies and preferred AZ do not carry through to children
5079 0 : scheduling_policy: serde_json::to_string(&ShardSchedulingPolicy::default())
5080 0 : .unwrap(),
5081 0 : preferred_az_id: preferred_az_id.as_ref().map(|az| az.0.clone()),
5082 0 : });
5083 0 : }
5084 :
5085 0 : child_tsps.push((target.parent_id, this_child_tsps));
5086 : }
5087 :
5088 0 : if let Err(e) = self
5089 0 : .persistence
5090 0 : .begin_shard_split(old_shard_count, tenant_id, child_tsps)
5091 0 : .await
5092 : {
5093 0 : match e {
5094 : DatabaseError::Query(diesel::result::Error::DatabaseError(
5095 : DatabaseErrorKind::UniqueViolation,
5096 : _,
5097 : )) => {
5098 : // Inserting a child shard violated a unique constraint: we raced with another call to
5099 : // this function
5100 0 : tracing::warn!("Conflicting attempt to split {tenant_id}: {e}");
5101 0 : return Err(ApiError::Conflict("Tenant is already splitting".into()));
5102 : }
5103 0 : _ => return Err(ApiError::InternalServerError(e.into())),
5104 : }
5105 0 : }
5106 0 : fail::fail_point!("shard-split-post-begin", |_| Err(
5107 0 : ApiError::InternalServerError(anyhow::anyhow!("failpoint"))
5108 0 : ));
5109 :
5110 : // Now that I have persisted the splitting state, apply it in-memory. This is infallible, so
5111 : // callers may assume that if splitting is set in memory, then it was persisted, and if splitting
5112 : // is not set in memory, then it was not persisted.
5113 : {
5114 0 : let mut locked = self.inner.write().unwrap();
5115 0 : for target in &targets {
5116 0 : if let Some(parent_shard) = locked.tenants.get_mut(&target.parent_id) {
5117 0 : parent_shard.splitting = SplitState::Splitting;
5118 0 : // Put the observed state to None, to reflect that it is indeterminate once we start the
5119 0 : // split operation.
5120 0 : parent_shard
5121 0 : .observed
5122 0 : .locations
5123 0 : .insert(target.node.get_id(), ObservedStateLocation { conf: None });
5124 0 : }
5125 : }
5126 : }
5127 :
5128 : // TODO: issue split calls concurrently (this only matters once we're splitting
5129 : // N>1 shards into M shards -- initially we're usually splitting 1 shard into N).
5130 :
5131 0 : for target in &targets {
5132 : let ShardSplitTarget {
5133 0 : parent_id,
5134 0 : node,
5135 0 : child_ids,
5136 0 : } = target;
5137 0 : let client = PageserverClient::new(
5138 0 : node.get_id(),
5139 0 : node.base_url(),
5140 0 : self.config.jwt_token.as_deref(),
5141 0 : );
5142 0 : let response = client
5143 0 : .tenant_shard_split(
5144 0 : *parent_id,
5145 0 : TenantShardSplitRequest {
5146 0 : new_shard_count: new_shard_count.literal(),
5147 0 : new_stripe_size,
5148 0 : },
5149 0 : )
5150 0 : .await
5151 0 : .map_err(|e| ApiError::Conflict(format!("Failed to split {}: {}", parent_id, e)))?;
5152 :
5153 0 : fail::fail_point!("shard-split-post-remote", |_| Err(ApiError::Conflict(
5154 0 : "failpoint".to_string()
5155 0 : )));
5156 :
5157 0 : failpoint_support::sleep_millis_async!("shard-split-post-remote-sleep", &self.cancel);
5158 :
5159 0 : tracing::info!(
5160 0 : "Split {} into {}",
5161 0 : parent_id,
5162 0 : response
5163 0 : .new_shards
5164 0 : .iter()
5165 0 : .map(|s| format!("{:?}", s))
5166 0 : .collect::<Vec<_>>()
5167 0 : .join(",")
5168 : );
5169 :
5170 0 : if &response.new_shards != child_ids {
5171 : // This should never happen: the pageserver should agree with us on how shard splits work.
5172 0 : return Err(ApiError::InternalServerError(anyhow::anyhow!(
5173 0 : "Splitting shard {} resulted in unexpected IDs: {:?} (expected {:?})",
5174 0 : parent_id,
5175 0 : response.new_shards,
5176 0 : child_ids
5177 0 : )));
5178 0 : }
5179 : }
5180 :
5181 : // TODO: if the pageserver restarted concurrently with our split API call,
5182 : // the actual generation of the child shard might differ from the generation
5183 : // we expect it to have. In order for our in-database generation to end up
5184 : // correct, we should carry the child generation back in the response and apply it here
5185 : // in complete_shard_split (and apply the correct generation in memory)
5186 : // (or, we can carry generation in the request and reject the request if
5187 : // it doesn't match, but that requires more retry logic on this side)
5188 :
5189 0 : self.persistence
5190 0 : .complete_shard_split(tenant_id, old_shard_count)
5191 0 : .await?;
5192 :
5193 0 : fail::fail_point!("shard-split-post-complete", |_| Err(
5194 0 : ApiError::InternalServerError(anyhow::anyhow!("failpoint"))
5195 0 : ));
5196 :
5197 : // Replace all the shards we just split with their children: this phase is infallible.
5198 0 : let (response, child_locations, waiters) =
5199 0 : self.tenant_shard_split_commit_inmem(tenant_id, new_shard_count, new_stripe_size);
5200 0 :
5201 0 : // Send compute notifications for all the new shards
5202 0 : let mut failed_notifications = Vec::new();
5203 0 : for (child_id, child_ps, stripe_size) in child_locations {
5204 0 : if let Err(e) = self
5205 0 : .compute_hook
5206 0 : .notify(
5207 0 : compute_hook::ShardUpdate {
5208 0 : tenant_shard_id: child_id,
5209 0 : node_id: child_ps,
5210 0 : stripe_size,
5211 0 : preferred_az: preferred_az_id.as_ref().map(Cow::Borrowed),
5212 0 : },
5213 0 : &self.cancel,
5214 0 : )
5215 0 : .await
5216 : {
5217 0 : tracing::warn!("Failed to update compute of {}->{} during split, proceeding anyway to complete split ({e})",
5218 : child_id, child_ps);
5219 0 : failed_notifications.push(child_id);
5220 0 : }
5221 : }
5222 :
5223 : // If we failed any compute notifications, make a note to retry later.
5224 0 : if !failed_notifications.is_empty() {
5225 0 : let mut locked = self.inner.write().unwrap();
5226 0 : for failed in failed_notifications {
5227 0 : if let Some(shard) = locked.tenants.get_mut(&failed) {
5228 0 : shard.pending_compute_notification = true;
5229 0 : }
5230 : }
5231 0 : }
5232 :
5233 0 : Ok((response, waiters))
5234 0 : }
5235 :
5236 0 : pub(crate) async fn tenant_shard_migrate(
5237 0 : &self,
5238 0 : tenant_shard_id: TenantShardId,
5239 0 : migrate_req: TenantShardMigrateRequest,
5240 0 : ) -> Result<TenantShardMigrateResponse, ApiError> {
5241 0 : let waiter = {
5242 0 : let mut locked = self.inner.write().unwrap();
5243 0 : let (nodes, tenants, scheduler) = locked.parts_mut();
5244 :
5245 0 : let Some(node) = nodes.get(&migrate_req.node_id) else {
5246 0 : return Err(ApiError::BadRequest(anyhow::anyhow!(
5247 0 : "Node {} not found",
5248 0 : migrate_req.node_id
5249 0 : )));
5250 : };
5251 :
5252 0 : if !node.is_available() {
5253 : // Warn but proceed: the caller may intend to manually adjust the placement of
5254 : // a shard even if the node is down, e.g. if intervening during an incident.
5255 0 : tracing::warn!("Migrating to unavailable node {node}");
5256 0 : }
5257 :
5258 0 : let Some(shard) = tenants.get_mut(&tenant_shard_id) else {
5259 0 : return Err(ApiError::NotFound(
5260 0 : anyhow::anyhow!("Tenant shard not found").into(),
5261 0 : ));
5262 : };
5263 :
5264 0 : if shard.intent.get_attached() == &Some(migrate_req.node_id) {
5265 : // No-op case: we will still proceed to wait for reconciliation in case it is
5266 : // incomplete from an earlier update to the intent.
5267 0 : tracing::info!("Migrating: intent is unchanged {:?}", shard.intent);
5268 : } else {
5269 0 : let old_attached = *shard.intent.get_attached();
5270 0 :
5271 0 : match shard.policy {
5272 0 : PlacementPolicy::Attached(n) => {
5273 0 : // If our new attached node was a secondary, it no longer should be.
5274 0 : shard.intent.remove_secondary(scheduler, migrate_req.node_id);
5275 0 :
5276 0 : shard.intent.set_attached(scheduler, Some(migrate_req.node_id));
5277 :
5278 : // If we were already attached to something, demote that to a secondary
5279 0 : if let Some(old_attached) = old_attached {
5280 0 : if n > 0 {
5281 : // Remove other secondaries to make room for the location we'll demote
5282 0 : while shard.intent.get_secondary().len() >= n {
5283 0 : shard.intent.pop_secondary(scheduler);
5284 0 : }
5285 :
5286 0 : shard.intent.push_secondary(scheduler, old_attached);
5287 0 : }
5288 0 : }
5289 : }
5290 0 : PlacementPolicy::Secondary => {
5291 0 : shard.intent.clear(scheduler);
5292 0 : shard.intent.push_secondary(scheduler, migrate_req.node_id);
5293 0 : }
5294 : PlacementPolicy::Detached => {
5295 0 : return Err(ApiError::BadRequest(anyhow::anyhow!(
5296 0 : "Cannot migrate a tenant that is PlacementPolicy::Detached: configure it to an attached policy first"
5297 0 : )))
5298 : }
5299 : }
5300 :
5301 0 : tracing::info!("Migrating: new intent {:?}", shard.intent);
5302 0 : shard.sequence = shard.sequence.next();
5303 : }
5304 :
5305 0 : let reconciler_config = match migrate_req.migration_config {
5306 0 : Some(cfg) => (&cfg).into(),
5307 0 : None => ReconcilerConfig::new(ReconcilerPriority::High),
5308 : };
5309 :
5310 0 : self.maybe_configured_reconcile_shard(shard, nodes, reconciler_config)
5311 : };
5312 :
5313 0 : if let Some(waiter) = waiter {
5314 0 : waiter.wait_timeout(RECONCILE_TIMEOUT).await?;
5315 : } else {
5316 0 : tracing::info!("Migration is a no-op");
5317 : }
5318 :
5319 0 : Ok(TenantShardMigrateResponse {})
5320 0 : }
5321 :
5322 0 : pub(crate) async fn tenant_shard_migrate_secondary(
5323 0 : &self,
5324 0 : tenant_shard_id: TenantShardId,
5325 0 : migrate_req: TenantShardMigrateRequest,
5326 0 : ) -> Result<TenantShardMigrateResponse, ApiError> {
5327 0 : let waiter = {
5328 0 : let mut locked = self.inner.write().unwrap();
5329 0 : let (nodes, tenants, scheduler) = locked.parts_mut();
5330 :
5331 0 : let Some(node) = nodes.get(&migrate_req.node_id) else {
5332 0 : return Err(ApiError::BadRequest(anyhow::anyhow!(
5333 0 : "Node {} not found",
5334 0 : migrate_req.node_id
5335 0 : )));
5336 : };
5337 :
5338 0 : if !node.is_available() {
5339 : // Warn but proceed: the caller may intend to manually adjust the placement of
5340 : // a shard even if the node is down, e.g. if intervening during an incident.
5341 0 : tracing::warn!("Migrating to unavailable node {node}");
5342 0 : }
5343 :
5344 0 : let Some(shard) = tenants.get_mut(&tenant_shard_id) else {
5345 0 : return Err(ApiError::NotFound(
5346 0 : anyhow::anyhow!("Tenant shard not found").into(),
5347 0 : ));
5348 : };
5349 :
5350 0 : if shard.intent.get_secondary().len() == 1
5351 0 : && shard.intent.get_secondary()[0] == migrate_req.node_id
5352 : {
5353 0 : tracing::info!(
5354 0 : "Migrating secondary to {node}: intent is unchanged {:?}",
5355 : shard.intent
5356 : );
5357 0 : } else if shard.intent.get_attached() == &Some(migrate_req.node_id) {
5358 0 : tracing::info!("Migrating secondary to {node}: already attached where we were asked to create a secondary");
5359 : } else {
5360 0 : let old_secondaries = shard.intent.get_secondary().clone();
5361 0 : for secondary in old_secondaries {
5362 0 : shard.intent.remove_secondary(scheduler, secondary);
5363 0 : }
5364 :
5365 0 : shard.intent.push_secondary(scheduler, migrate_req.node_id);
5366 0 : shard.sequence = shard.sequence.next();
5367 0 : tracing::info!(
5368 0 : "Migrating secondary to {node}: new intent {:?}",
5369 : shard.intent
5370 : );
5371 : }
5372 :
5373 0 : self.maybe_reconcile_shard(shard, nodes, ReconcilerPriority::High)
5374 : };
5375 :
5376 0 : if let Some(waiter) = waiter {
5377 0 : waiter.wait_timeout(RECONCILE_TIMEOUT).await?;
5378 : } else {
5379 0 : tracing::info!("Migration is a no-op");
5380 : }
5381 :
5382 0 : Ok(TenantShardMigrateResponse {})
5383 0 : }
5384 :
5385 : /// 'cancel' in this context means cancel any ongoing reconcile
5386 0 : pub(crate) async fn tenant_shard_cancel_reconcile(
5387 0 : &self,
5388 0 : tenant_shard_id: TenantShardId,
5389 0 : ) -> Result<(), ApiError> {
5390 : // Take state lock and fire the cancellation token, after which we drop lock and wait for any ongoing reconcile to complete
5391 0 : let waiter = {
5392 0 : let locked = self.inner.write().unwrap();
5393 0 : let Some(shard) = locked.tenants.get(&tenant_shard_id) else {
5394 0 : return Err(ApiError::NotFound(
5395 0 : anyhow::anyhow!("Tenant shard not found").into(),
5396 0 : ));
5397 : };
5398 :
5399 0 : let waiter = shard.get_waiter();
5400 0 : match waiter {
5401 : None => {
5402 0 : tracing::info!("Shard does not have an ongoing Reconciler");
5403 0 : return Ok(());
5404 : }
5405 0 : Some(waiter) => {
5406 0 : tracing::info!("Cancelling Reconciler");
5407 0 : shard.cancel_reconciler();
5408 0 : waiter
5409 0 : }
5410 0 : }
5411 0 : };
5412 0 :
5413 0 : // Cancellation should be prompt. If this fails we have still done our job of firing the
5414 0 : // cancellation token, but by returning an ApiError we will indicate to the caller that
5415 0 : // the Reconciler is misbehaving and not respecting the cancellation token
5416 0 : self.await_waiters(vec![waiter], SHORT_RECONCILE_TIMEOUT)
5417 0 : .await?;
5418 :
5419 0 : Ok(())
5420 0 : }
5421 :
5422 : /// This is for debug/support only: we simply drop all state for a tenant, without
5423 : /// detaching or deleting it on pageservers.
5424 0 : pub(crate) async fn tenant_drop(&self, tenant_id: TenantId) -> Result<(), ApiError> {
5425 0 : self.persistence.delete_tenant(tenant_id).await?;
5426 :
5427 0 : let mut locked = self.inner.write().unwrap();
5428 0 : let (_nodes, tenants, scheduler) = locked.parts_mut();
5429 0 : let mut shards = Vec::new();
5430 0 : for (tenant_shard_id, _) in tenants.range(TenantShardId::tenant_range(tenant_id)) {
5431 0 : shards.push(*tenant_shard_id);
5432 0 : }
5433 :
5434 0 : for shard_id in shards {
5435 0 : if let Some(mut shard) = tenants.remove(&shard_id) {
5436 0 : shard.intent.clear(scheduler);
5437 0 : }
5438 : }
5439 :
5440 0 : Ok(())
5441 0 : }
5442 :
5443 : /// This is for debug/support only: assuming tenant data is already present in S3, we "create" a
5444 : /// tenant with a very high generation number so that it will see the existing data.
5445 0 : pub(crate) async fn tenant_import(
5446 0 : &self,
5447 0 : tenant_id: TenantId,
5448 0 : ) -> Result<TenantCreateResponse, ApiError> {
5449 0 : // Pick an arbitrary available pageserver to use for scanning the tenant in remote storage
5450 0 : let maybe_node = {
5451 0 : self.inner
5452 0 : .read()
5453 0 : .unwrap()
5454 0 : .nodes
5455 0 : .values()
5456 0 : .find(|n| n.is_available())
5457 0 : .cloned()
5458 : };
5459 0 : let Some(node) = maybe_node else {
5460 0 : return Err(ApiError::BadRequest(anyhow::anyhow!("No nodes available")));
5461 : };
5462 :
5463 0 : let client = PageserverClient::new(
5464 0 : node.get_id(),
5465 0 : node.base_url(),
5466 0 : self.config.jwt_token.as_deref(),
5467 0 : );
5468 :
5469 0 : let scan_result = client
5470 0 : .tenant_scan_remote_storage(tenant_id)
5471 0 : .await
5472 0 : .map_err(|e| passthrough_api_error(&node, e))?;
5473 :
5474 : // A post-split tenant may contain a mixture of shard counts in remote storage: pick the highest count.
5475 0 : let Some(shard_count) = scan_result
5476 0 : .shards
5477 0 : .iter()
5478 0 : .map(|s| s.tenant_shard_id.shard_count)
5479 0 : .max()
5480 : else {
5481 0 : return Err(ApiError::NotFound(
5482 0 : anyhow::anyhow!("No shards found").into(),
5483 0 : ));
5484 : };
5485 :
5486 : // Ideally we would set each newly imported shard's generation independently, but for correctness it is sufficient
5487 : // to
5488 0 : let generation = scan_result
5489 0 : .shards
5490 0 : .iter()
5491 0 : .map(|s| s.generation)
5492 0 : .max()
5493 0 : .expect("We already validated >0 shards");
5494 0 :
5495 0 : // FIXME: we have no way to recover the shard stripe size from contents of remote storage: this will
5496 0 : // only work if they were using the default stripe size.
5497 0 : let stripe_size = ShardParameters::DEFAULT_STRIPE_SIZE;
5498 :
5499 0 : let (response, waiters) = self
5500 0 : .do_tenant_create(TenantCreateRequest {
5501 0 : new_tenant_id: TenantShardId::unsharded(tenant_id),
5502 0 : generation,
5503 0 :
5504 0 : shard_parameters: ShardParameters {
5505 0 : count: shard_count,
5506 0 : stripe_size,
5507 0 : },
5508 0 : placement_policy: Some(PlacementPolicy::Attached(0)), // No secondaries, for convenient debug/hacking
5509 0 : config: TenantConfig::default(),
5510 0 : })
5511 0 : .await?;
5512 :
5513 0 : if let Err(e) = self.await_waiters(waiters, SHORT_RECONCILE_TIMEOUT).await {
5514 : // Since this is a debug/support operation, all kinds of weird issues are possible (e.g. this
5515 : // tenant doesn't exist in the control plane), so don't fail the request if it can't fully
5516 : // reconcile, as reconciliation includes notifying compute.
5517 0 : tracing::warn!(%tenant_id, "Reconcile not done yet while importing tenant ({e})");
5518 0 : }
5519 :
5520 0 : Ok(response)
5521 0 : }
5522 :
5523 : /// For debug/support: a full JSON dump of TenantShards. Returns a response so that
5524 : /// we don't have to make TenantShard clonable in the return path.
5525 0 : pub(crate) fn tenants_dump(&self) -> Result<hyper::Response<hyper::Body>, ApiError> {
5526 0 : let serialized = {
5527 0 : let locked = self.inner.read().unwrap();
5528 0 : let result = locked.tenants.values().collect::<Vec<_>>();
5529 0 : serde_json::to_string(&result).map_err(|e| ApiError::InternalServerError(e.into()))?
5530 : };
5531 :
5532 0 : hyper::Response::builder()
5533 0 : .status(hyper::StatusCode::OK)
5534 0 : .header(hyper::header::CONTENT_TYPE, "application/json")
5535 0 : .body(hyper::Body::from(serialized))
5536 0 : .map_err(|e| ApiError::InternalServerError(e.into()))
5537 0 : }
5538 :
5539 : /// Check the consistency of in-memory state vs. persistent state, and check that the
5540 : /// scheduler's statistics are up to date.
5541 : ///
5542 : /// These consistency checks expect an **idle** system. If changes are going on while
5543 : /// we run, then we can falsely indicate a consistency issue. This is sufficient for end-of-test
5544 : /// checks, but not suitable for running continuously in the background in the field.
5545 0 : pub(crate) async fn consistency_check(&self) -> Result<(), ApiError> {
5546 0 : let (mut expect_nodes, mut expect_shards) = {
5547 0 : let locked = self.inner.read().unwrap();
5548 0 :
5549 0 : locked
5550 0 : .scheduler
5551 0 : .consistency_check(locked.nodes.values(), locked.tenants.values())
5552 0 : .context("Scheduler checks")
5553 0 : .map_err(ApiError::InternalServerError)?;
5554 :
5555 0 : let expect_nodes = locked
5556 0 : .nodes
5557 0 : .values()
5558 0 : .map(|n| n.to_persistent())
5559 0 : .collect::<Vec<_>>();
5560 0 :
5561 0 : let expect_shards = locked
5562 0 : .tenants
5563 0 : .values()
5564 0 : .map(|t| t.to_persistent())
5565 0 : .collect::<Vec<_>>();
5566 :
5567 : // This method can only validate the state of an idle system: if a reconcile is in
5568 : // progress, fail out early to avoid giving false errors on state that won't match
5569 : // between database and memory under a ReconcileResult is processed.
5570 0 : for t in locked.tenants.values() {
5571 0 : if t.reconciler.is_some() {
5572 0 : return Err(ApiError::InternalServerError(anyhow::anyhow!(
5573 0 : "Shard {} reconciliation in progress",
5574 0 : t.tenant_shard_id
5575 0 : )));
5576 0 : }
5577 : }
5578 :
5579 0 : (expect_nodes, expect_shards)
5580 : };
5581 :
5582 0 : let mut nodes = self.persistence.list_nodes().await?;
5583 0 : expect_nodes.sort_by_key(|n| n.node_id);
5584 0 : nodes.sort_by_key(|n| n.node_id);
5585 :
5586 : // Errors relating to nodes are deferred so that we don't skip the shard checks below if we have a node error
5587 0 : let node_result = if nodes != expect_nodes {
5588 0 : tracing::error!("Consistency check failed on nodes.");
5589 0 : tracing::error!(
5590 0 : "Nodes in memory: {}",
5591 0 : serde_json::to_string(&expect_nodes)
5592 0 : .map_err(|e| ApiError::InternalServerError(e.into()))?
5593 : );
5594 0 : tracing::error!(
5595 0 : "Nodes in database: {}",
5596 0 : serde_json::to_string(&nodes)
5597 0 : .map_err(|e| ApiError::InternalServerError(e.into()))?
5598 : );
5599 0 : Err(ApiError::InternalServerError(anyhow::anyhow!(
5600 0 : "Node consistency failure"
5601 0 : )))
5602 : } else {
5603 0 : Ok(())
5604 : };
5605 :
5606 0 : let mut persistent_shards = self.persistence.load_active_tenant_shards().await?;
5607 0 : persistent_shards
5608 0 : .sort_by_key(|tsp| (tsp.tenant_id.clone(), tsp.shard_number, tsp.shard_count));
5609 0 :
5610 0 : expect_shards.sort_by_key(|tsp| (tsp.tenant_id.clone(), tsp.shard_number, tsp.shard_count));
5611 :
5612 : // Because JSON contents of persistent tenants might disagree with the fields in current `TenantConfig`
5613 : // definition, we will do an encode/decode cycle to ensure any legacy fields are dropped and any new
5614 : // fields are added, before doing a comparison.
5615 0 : for tsp in &mut persistent_shards {
5616 0 : let config: TenantConfig = serde_json::from_str(&tsp.config)
5617 0 : .map_err(|e| ApiError::InternalServerError(e.into()))?;
5618 0 : tsp.config = serde_json::to_string(&config).expect("Encoding config is infallible");
5619 : }
5620 :
5621 0 : if persistent_shards != expect_shards {
5622 0 : tracing::error!("Consistency check failed on shards.");
5623 :
5624 0 : tracing::error!(
5625 0 : "Shards in memory: {}",
5626 0 : serde_json::to_string(&expect_shards)
5627 0 : .map_err(|e| ApiError::InternalServerError(e.into()))?
5628 : );
5629 0 : tracing::error!(
5630 0 : "Shards in database: {}",
5631 0 : serde_json::to_string(&persistent_shards)
5632 0 : .map_err(|e| ApiError::InternalServerError(e.into()))?
5633 : );
5634 :
5635 : // The total dump log lines above are useful in testing but in the field grafana will
5636 : // usually just drop them because they're so large. So we also do some explicit logging
5637 : // of just the diffs.
5638 0 : let persistent_shards = persistent_shards
5639 0 : .into_iter()
5640 0 : .map(|tsp| (tsp.get_tenant_shard_id().unwrap(), tsp))
5641 0 : .collect::<HashMap<_, _>>();
5642 0 : let expect_shards = expect_shards
5643 0 : .into_iter()
5644 0 : .map(|tsp| (tsp.get_tenant_shard_id().unwrap(), tsp))
5645 0 : .collect::<HashMap<_, _>>();
5646 0 : for (tenant_shard_id, persistent_tsp) in &persistent_shards {
5647 0 : match expect_shards.get(tenant_shard_id) {
5648 : None => {
5649 0 : tracing::error!(
5650 0 : "Shard {} found in database but not in memory",
5651 : tenant_shard_id
5652 : );
5653 : }
5654 0 : Some(expect_tsp) => {
5655 0 : if expect_tsp != persistent_tsp {
5656 0 : tracing::error!(
5657 0 : "Shard {} is inconsistent. In memory: {}, database has: {}",
5658 0 : tenant_shard_id,
5659 0 : serde_json::to_string(expect_tsp).unwrap(),
5660 0 : serde_json::to_string(&persistent_tsp).unwrap()
5661 : );
5662 0 : }
5663 : }
5664 : }
5665 : }
5666 :
5667 : // Having already logged any differences, log any shards that simply aren't present in the database
5668 0 : for (tenant_shard_id, memory_tsp) in &expect_shards {
5669 0 : if !persistent_shards.contains_key(tenant_shard_id) {
5670 0 : tracing::error!(
5671 0 : "Shard {} found in memory but not in database: {}",
5672 0 : tenant_shard_id,
5673 0 : serde_json::to_string(memory_tsp)
5674 0 : .map_err(|e| ApiError::InternalServerError(e.into()))?
5675 : );
5676 0 : }
5677 : }
5678 :
5679 0 : return Err(ApiError::InternalServerError(anyhow::anyhow!(
5680 0 : "Shard consistency failure"
5681 0 : )));
5682 0 : }
5683 0 :
5684 0 : node_result
5685 0 : }
5686 :
5687 : /// For debug/support: a JSON dump of the [`Scheduler`]. Returns a response so that
5688 : /// we don't have to make TenantShard clonable in the return path.
5689 0 : pub(crate) fn scheduler_dump(&self) -> Result<hyper::Response<hyper::Body>, ApiError> {
5690 0 : let serialized = {
5691 0 : let locked = self.inner.read().unwrap();
5692 0 : serde_json::to_string(&locked.scheduler)
5693 0 : .map_err(|e| ApiError::InternalServerError(e.into()))?
5694 : };
5695 :
5696 0 : hyper::Response::builder()
5697 0 : .status(hyper::StatusCode::OK)
5698 0 : .header(hyper::header::CONTENT_TYPE, "application/json")
5699 0 : .body(hyper::Body::from(serialized))
5700 0 : .map_err(|e| ApiError::InternalServerError(e.into()))
5701 0 : }
5702 :
5703 : /// This is for debug/support only: we simply drop all state for a tenant, without
5704 : /// detaching or deleting it on pageservers. We do not try and re-schedule any
5705 : /// tenants that were on this node.
5706 0 : pub(crate) async fn node_drop(&self, node_id: NodeId) -> Result<(), ApiError> {
5707 0 : self.persistence.delete_node(node_id).await?;
5708 :
5709 0 : let mut locked = self.inner.write().unwrap();
5710 :
5711 0 : for shard in locked.tenants.values_mut() {
5712 0 : shard.deref_node(node_id);
5713 0 : shard.observed.locations.remove(&node_id);
5714 0 : }
5715 :
5716 0 : let mut nodes = (*locked.nodes).clone();
5717 0 : nodes.remove(&node_id);
5718 0 : locked.nodes = Arc::new(nodes);
5719 0 : metrics::METRICS_REGISTRY
5720 0 : .metrics_group
5721 0 : .storage_controller_pageserver_nodes
5722 0 : .set(locked.nodes.len() as i64);
5723 0 :
5724 0 : locked.scheduler.node_remove(node_id);
5725 0 :
5726 0 : Ok(())
5727 0 : }
5728 :
5729 : /// If a node has any work on it, it will be rescheduled: this is "clean" in the sense
5730 : /// that we don't leave any bad state behind in the storage controller, but unclean
5731 : /// in the sense that we are not carefully draining the node.
5732 0 : pub(crate) async fn node_delete(&self, node_id: NodeId) -> Result<(), ApiError> {
5733 0 : let _node_lock =
5734 0 : trace_exclusive_lock(&self.node_op_locks, node_id, NodeOperations::Delete).await;
5735 :
5736 : // 1. Atomically update in-memory state:
5737 : // - set the scheduling state to Pause to make subsequent scheduling ops skip it
5738 : // - update shards' intents to exclude the node, and reschedule any shards whose intents we modified.
5739 : // - drop the node from the main nodes map, so that when running reconciles complete they do not
5740 : // re-insert references to this node into the ObservedState of shards
5741 : // - drop the node from the scheduler
5742 : {
5743 0 : let mut locked = self.inner.write().unwrap();
5744 0 : let (nodes, tenants, scheduler) = locked.parts_mut();
5745 0 :
5746 0 : {
5747 0 : let mut nodes_mut = (*nodes).deref().clone();
5748 0 : match nodes_mut.get_mut(&node_id) {
5749 0 : Some(node) => {
5750 0 : // We do not bother setting this in the database, because we're about to delete the row anyway, and
5751 0 : // if we crash it would not be desirable to leave the node paused after a restart.
5752 0 : node.set_scheduling(NodeSchedulingPolicy::Pause);
5753 0 : }
5754 : None => {
5755 0 : tracing::info!(
5756 0 : "Node not found: presuming this is a retry and returning success"
5757 : );
5758 0 : return Ok(());
5759 : }
5760 : }
5761 :
5762 0 : *nodes = Arc::new(nodes_mut);
5763 : }
5764 :
5765 0 : for (_tenant_id, mut schedule_context, shards) in
5766 0 : TenantShardContextIterator::new(tenants, ScheduleMode::Normal)
5767 : {
5768 0 : for shard in shards {
5769 0 : if shard.deref_node(node_id) {
5770 0 : if let Err(e) = shard.schedule(scheduler, &mut schedule_context) {
5771 : // TODO: implement force flag to remove a node even if we can't reschedule
5772 : // a tenant
5773 0 : tracing::error!(
5774 0 : "Refusing to delete node, shard {} can't be rescheduled: {e}",
5775 : shard.tenant_shard_id
5776 : );
5777 0 : return Err(e.into());
5778 : } else {
5779 0 : tracing::info!(
5780 0 : "Rescheduled shard {} away from node during deletion",
5781 : shard.tenant_shard_id
5782 : )
5783 : }
5784 :
5785 0 : self.maybe_reconcile_shard(shard, nodes, ReconcilerPriority::Normal);
5786 0 : }
5787 :
5788 : // Here we remove an existing observed location for the node we're removing, and it will
5789 : // not be re-added by a reconciler's completion because we filter out removed nodes in
5790 : // process_result.
5791 : //
5792 : // Note that we update the shard's observed state _after_ calling maybe_reconcile_shard: that
5793 : // means any reconciles we spawned will know about the node we're deleting, enabling them
5794 : // to do live migrations if it's still online.
5795 0 : shard.observed.locations.remove(&node_id);
5796 : }
5797 : }
5798 :
5799 0 : scheduler.node_remove(node_id);
5800 0 :
5801 0 : {
5802 0 : let mut nodes_mut = (**nodes).clone();
5803 0 : if let Some(mut removed_node) = nodes_mut.remove(&node_id) {
5804 0 : // Ensure that any reconciler holding an Arc<> to this node will
5805 0 : // drop out when trying to RPC to it (setting Offline state sets the
5806 0 : // cancellation token on the Node object).
5807 0 : removed_node.set_availability(NodeAvailability::Offline);
5808 0 : }
5809 0 : *nodes = Arc::new(nodes_mut);
5810 0 : metrics::METRICS_REGISTRY
5811 0 : .metrics_group
5812 0 : .storage_controller_pageserver_nodes
5813 0 : .set(nodes.len() as i64);
5814 0 : }
5815 0 : }
5816 0 :
5817 0 : // Note: some `generation_pageserver` columns on tenant shards in the database may still refer to
5818 0 : // the removed node, as this column means "The pageserver to which this generation was issued", and
5819 0 : // their generations won't get updated until the reconcilers moving them away from this node complete.
5820 0 : // That is safe because in Service::spawn we only use generation_pageserver if it refers to a node
5821 0 : // that exists.
5822 0 :
5823 0 : // 2. Actually delete the node from the database and from in-memory state
5824 0 : tracing::info!("Deleting node from database");
5825 0 : self.persistence.delete_node(node_id).await?;
5826 :
5827 0 : Ok(())
5828 0 : }
5829 :
5830 0 : pub(crate) async fn node_list(&self) -> Result<Vec<Node>, ApiError> {
5831 0 : let nodes = {
5832 0 : self.inner
5833 0 : .read()
5834 0 : .unwrap()
5835 0 : .nodes
5836 0 : .values()
5837 0 : .cloned()
5838 0 : .collect::<Vec<_>>()
5839 0 : };
5840 0 :
5841 0 : Ok(nodes)
5842 0 : }
5843 :
5844 0 : pub(crate) async fn get_node(&self, node_id: NodeId) -> Result<Node, ApiError> {
5845 0 : self.inner
5846 0 : .read()
5847 0 : .unwrap()
5848 0 : .nodes
5849 0 : .get(&node_id)
5850 0 : .cloned()
5851 0 : .ok_or(ApiError::NotFound(
5852 0 : format!("Node {node_id} not registered").into(),
5853 0 : ))
5854 0 : }
5855 :
5856 0 : pub(crate) async fn get_node_shards(
5857 0 : &self,
5858 0 : node_id: NodeId,
5859 0 : ) -> Result<NodeShardResponse, ApiError> {
5860 0 : let locked = self.inner.read().unwrap();
5861 0 : let mut shards = Vec::new();
5862 0 : for (tid, tenant) in locked.tenants.iter() {
5863 0 : let is_intended_secondary = match (
5864 0 : tenant.intent.get_attached() == &Some(node_id),
5865 0 : tenant.intent.get_secondary().contains(&node_id),
5866 0 : ) {
5867 : (true, true) => {
5868 0 : return Err(ApiError::InternalServerError(anyhow::anyhow!(
5869 0 : "{} attached as primary+secondary on the same node",
5870 0 : tid
5871 0 : )))
5872 : }
5873 0 : (true, false) => Some(false),
5874 0 : (false, true) => Some(true),
5875 0 : (false, false) => None,
5876 : };
5877 0 : let is_observed_secondary = if let Some(ObservedStateLocation { conf: Some(conf) }) =
5878 0 : tenant.observed.locations.get(&node_id)
5879 : {
5880 0 : Some(conf.secondary_conf.is_some())
5881 : } else {
5882 0 : None
5883 : };
5884 0 : if is_intended_secondary.is_some() || is_observed_secondary.is_some() {
5885 0 : shards.push(NodeShard {
5886 0 : tenant_shard_id: *tid,
5887 0 : is_intended_secondary,
5888 0 : is_observed_secondary,
5889 0 : });
5890 0 : }
5891 : }
5892 0 : Ok(NodeShardResponse { node_id, shards })
5893 0 : }
5894 :
5895 0 : pub(crate) async fn get_leader(&self) -> DatabaseResult<Option<ControllerPersistence>> {
5896 0 : self.persistence.get_leader().await
5897 0 : }
5898 :
5899 0 : pub(crate) async fn node_register(
5900 0 : &self,
5901 0 : register_req: NodeRegisterRequest,
5902 0 : ) -> Result<(), ApiError> {
5903 0 : let _node_lock = trace_exclusive_lock(
5904 0 : &self.node_op_locks,
5905 0 : register_req.node_id,
5906 0 : NodeOperations::Register,
5907 0 : )
5908 0 : .await;
5909 :
5910 : enum RegistrationStatus {
5911 : Matched,
5912 : Mismatched,
5913 : New,
5914 : }
5915 :
5916 0 : let registration_status = {
5917 0 : let locked = self.inner.read().unwrap();
5918 0 : if let Some(node) = locked.nodes.get(®ister_req.node_id) {
5919 0 : if node.registration_match(®ister_req) {
5920 0 : RegistrationStatus::Matched
5921 : } else {
5922 0 : RegistrationStatus::Mismatched
5923 : }
5924 : } else {
5925 0 : RegistrationStatus::New
5926 : }
5927 : };
5928 :
5929 0 : match registration_status {
5930 : RegistrationStatus::Matched => {
5931 0 : tracing::info!(
5932 0 : "Node {} re-registered with matching address",
5933 : register_req.node_id
5934 : );
5935 :
5936 0 : return Ok(());
5937 : }
5938 : RegistrationStatus::Mismatched => {
5939 : // TODO: decide if we want to allow modifying node addresses without removing and re-adding
5940 : // the node. Safest/simplest thing is to refuse it, and usually we deploy with
5941 : // a fixed address through the lifetime of a node.
5942 0 : tracing::warn!(
5943 0 : "Node {} tried to register with different address",
5944 : register_req.node_id
5945 : );
5946 0 : return Err(ApiError::Conflict(
5947 0 : "Node is already registered with different address".to_string(),
5948 0 : ));
5949 : }
5950 0 : RegistrationStatus::New => {
5951 0 : // fallthrough
5952 0 : }
5953 0 : }
5954 0 :
5955 0 : // We do not require that a node is actually online when registered (it will start life
5956 0 : // with it's availability set to Offline), but we _do_ require that its DNS record exists. We're
5957 0 : // therefore not immune to asymmetric L3 connectivity issues, but we are protected against nodes
5958 0 : // that register themselves with a broken DNS config. We check only the HTTP hostname, because
5959 0 : // the postgres hostname might only be resolvable to clients (e.g. if we're on a different VPC than clients).
5960 0 : if tokio::net::lookup_host(format!(
5961 0 : "{}:{}",
5962 0 : register_req.listen_http_addr, register_req.listen_http_port
5963 0 : ))
5964 0 : .await
5965 0 : .is_err()
5966 : {
5967 : // If we have a transient DNS issue, it's up to the caller to retry their registration. Because
5968 : // we can't robustly distinguish between an intermittent issue and a totally bogus DNS situation,
5969 : // we return a soft 503 error, to encourage callers to retry past transient issues.
5970 0 : return Err(ApiError::ResourceUnavailable(
5971 0 : format!(
5972 0 : "Node {} tried to register with unknown DNS name '{}'",
5973 0 : register_req.node_id, register_req.listen_http_addr
5974 0 : )
5975 0 : .into(),
5976 0 : ));
5977 0 : }
5978 0 :
5979 0 : // Ordering: we must persist the new node _before_ adding it to in-memory state.
5980 0 : // This ensures that before we use it for anything or expose it via any external
5981 0 : // API, it is guaranteed to be available after a restart.
5982 0 : let new_node = Node::new(
5983 0 : register_req.node_id,
5984 0 : register_req.listen_http_addr,
5985 0 : register_req.listen_http_port,
5986 0 : register_req.listen_pg_addr,
5987 0 : register_req.listen_pg_port,
5988 0 : register_req.availability_zone_id.clone(),
5989 0 : );
5990 0 :
5991 0 : // TODO: idempotency if the node already exists in the database
5992 0 : self.persistence.insert_node(&new_node).await?;
5993 :
5994 0 : let mut locked = self.inner.write().unwrap();
5995 0 : let mut new_nodes = (*locked.nodes).clone();
5996 0 :
5997 0 : locked.scheduler.node_upsert(&new_node);
5998 0 : new_nodes.insert(register_req.node_id, new_node);
5999 0 :
6000 0 : locked.nodes = Arc::new(new_nodes);
6001 0 :
6002 0 : metrics::METRICS_REGISTRY
6003 0 : .metrics_group
6004 0 : .storage_controller_pageserver_nodes
6005 0 : .set(locked.nodes.len() as i64);
6006 0 :
6007 0 : tracing::info!(
6008 0 : "Registered pageserver {} ({}), now have {} pageservers",
6009 0 : register_req.node_id,
6010 0 : register_req.availability_zone_id,
6011 0 : locked.nodes.len()
6012 : );
6013 0 : Ok(())
6014 0 : }
6015 :
6016 : /// Configure in-memory and persistent state of a node as requested
6017 : ///
6018 : /// Note that this function does not trigger any immediate side effects in response
6019 : /// to the changes. That part is handled by [`Self::handle_node_availability_transition`].
6020 0 : async fn node_state_configure(
6021 0 : &self,
6022 0 : node_id: NodeId,
6023 0 : availability: Option<NodeAvailability>,
6024 0 : scheduling: Option<NodeSchedulingPolicy>,
6025 0 : node_lock: &TracingExclusiveGuard<NodeOperations>,
6026 0 : ) -> Result<AvailabilityTransition, ApiError> {
6027 0 : if let Some(scheduling) = scheduling {
6028 : // Scheduling is a persistent part of Node: we must write updates to the database before
6029 : // applying them in memory
6030 0 : self.persistence.update_node(node_id, scheduling).await?;
6031 0 : }
6032 :
6033 : // If we're activating a node, then before setting it active we must reconcile any shard locations
6034 : // on that node, in case it is out of sync, e.g. due to being unavailable during controller startup,
6035 : // by calling [`Self::node_activate_reconcile`]
6036 : //
6037 : // The transition we calculate here remains valid later in the function because we hold the op lock on the node:
6038 : // nothing else can mutate its availability while we run.
6039 0 : let availability_transition = if let Some(input_availability) = availability.as_ref() {
6040 0 : let (activate_node, availability_transition) = {
6041 0 : let locked = self.inner.read().unwrap();
6042 0 : let Some(node) = locked.nodes.get(&node_id) else {
6043 0 : return Err(ApiError::NotFound(
6044 0 : anyhow::anyhow!("Node {} not registered", node_id).into(),
6045 0 : ));
6046 : };
6047 :
6048 0 : (
6049 0 : node.clone(),
6050 0 : node.get_availability_transition(input_availability),
6051 0 : )
6052 : };
6053 :
6054 0 : if matches!(availability_transition, AvailabilityTransition::ToActive) {
6055 0 : self.node_activate_reconcile(activate_node, node_lock)
6056 0 : .await?;
6057 0 : }
6058 0 : availability_transition
6059 : } else {
6060 0 : AvailabilityTransition::Unchanged
6061 : };
6062 :
6063 : // Apply changes from the request to our in-memory state for the Node
6064 0 : let mut locked = self.inner.write().unwrap();
6065 0 : let (nodes, _tenants, scheduler) = locked.parts_mut();
6066 0 :
6067 0 : let mut new_nodes = (**nodes).clone();
6068 :
6069 0 : let Some(node) = new_nodes.get_mut(&node_id) else {
6070 0 : return Err(ApiError::NotFound(
6071 0 : anyhow::anyhow!("Node not registered").into(),
6072 0 : ));
6073 : };
6074 :
6075 0 : if let Some(availability) = availability {
6076 0 : node.set_availability(availability);
6077 0 : }
6078 :
6079 0 : if let Some(scheduling) = scheduling {
6080 0 : node.set_scheduling(scheduling);
6081 0 : }
6082 :
6083 : // Update the scheduler, in case the elegibility of the node for new shards has changed
6084 0 : scheduler.node_upsert(node);
6085 0 :
6086 0 : let new_nodes = Arc::new(new_nodes);
6087 0 : locked.nodes = new_nodes;
6088 0 :
6089 0 : Ok(availability_transition)
6090 0 : }
6091 :
6092 : /// Handle availability transition of one node
6093 : ///
6094 : /// Note that you should first call [`Self::node_state_configure`] to update
6095 : /// the in-memory state referencing that node. If you need to handle more than one transition
6096 : /// consider using [`Self::handle_node_availability_transitions`].
6097 0 : async fn handle_node_availability_transition(
6098 0 : &self,
6099 0 : node_id: NodeId,
6100 0 : transition: AvailabilityTransition,
6101 0 : _node_lock: &TracingExclusiveGuard<NodeOperations>,
6102 0 : ) -> Result<(), ApiError> {
6103 0 : // Modify scheduling state for any Tenants that are affected by a change in the node's availability state.
6104 0 : match transition {
6105 : AvailabilityTransition::ToOffline => {
6106 0 : tracing::info!("Node {} transition to offline", node_id);
6107 :
6108 0 : let mut locked = self.inner.write().unwrap();
6109 0 : let (nodes, tenants, scheduler) = locked.parts_mut();
6110 0 :
6111 0 : let mut tenants_affected: usize = 0;
6112 :
6113 0 : for (_tenant_id, mut schedule_context, shards) in
6114 0 : TenantShardContextIterator::new(tenants, ScheduleMode::Normal)
6115 : {
6116 0 : for tenant_shard in shards {
6117 0 : let tenant_shard_id = tenant_shard.tenant_shard_id;
6118 0 : if let Some(observed_loc) =
6119 0 : tenant_shard.observed.locations.get_mut(&node_id)
6120 0 : {
6121 0 : // When a node goes offline, we set its observed configuration to None, indicating unknown: we will
6122 0 : // not assume our knowledge of the node's configuration is accurate until it comes back online
6123 0 : observed_loc.conf = None;
6124 0 : }
6125 :
6126 0 : if nodes.len() == 1 {
6127 : // Special case for single-node cluster: there is no point trying to reschedule
6128 : // any tenant shards: avoid doing so, in order to avoid spewing warnings about
6129 : // failures to schedule them.
6130 0 : continue;
6131 0 : }
6132 0 :
6133 0 : if !nodes
6134 0 : .values()
6135 0 : .any(|n| matches!(n.may_schedule(), MaySchedule::Yes(_)))
6136 : {
6137 : // Special case for when all nodes are unavailable and/or unschedulable: there is no point
6138 : // trying to reschedule since there's nowhere else to go. Without this
6139 : // branch we incorrectly detach tenants in response to node unavailability.
6140 0 : continue;
6141 0 : }
6142 0 :
6143 0 : if tenant_shard.intent.demote_attached(scheduler, node_id) {
6144 0 : tenant_shard.sequence = tenant_shard.sequence.next();
6145 0 :
6146 0 : match tenant_shard.schedule(scheduler, &mut schedule_context) {
6147 0 : Err(e) => {
6148 0 : // It is possible that some tenants will become unschedulable when too many pageservers
6149 0 : // go offline: in this case there isn't much we can do other than make the issue observable.
6150 0 : // TODO: give TenantShard a scheduling error attribute to be queried later.
6151 0 : tracing::warn!(%tenant_shard_id, "Scheduling error when marking pageserver {} offline: {e}", node_id);
6152 : }
6153 : Ok(()) => {
6154 0 : if self
6155 0 : .maybe_reconcile_shard(
6156 0 : tenant_shard,
6157 0 : nodes,
6158 0 : ReconcilerPriority::Normal,
6159 0 : )
6160 0 : .is_some()
6161 0 : {
6162 0 : tenants_affected += 1;
6163 0 : };
6164 : }
6165 : }
6166 0 : }
6167 : }
6168 : }
6169 0 : tracing::info!(
6170 0 : "Launched {} reconciler tasks for tenants affected by node {} going offline",
6171 : tenants_affected,
6172 : node_id
6173 : )
6174 : }
6175 : AvailabilityTransition::ToActive => {
6176 0 : tracing::info!("Node {} transition to active", node_id);
6177 :
6178 0 : let mut locked = self.inner.write().unwrap();
6179 0 : let (nodes, tenants, _scheduler) = locked.parts_mut();
6180 :
6181 : // When a node comes back online, we must reconcile any tenant that has a None observed
6182 : // location on the node.
6183 0 : for tenant_shard in tenants.values_mut() {
6184 : // If a reconciliation is already in progress, rely on the previous scheduling
6185 : // decision and skip triggering a new reconciliation.
6186 0 : if tenant_shard.reconciler.is_some() {
6187 0 : continue;
6188 0 : }
6189 :
6190 0 : if let Some(observed_loc) = tenant_shard.observed.locations.get_mut(&node_id) {
6191 0 : if observed_loc.conf.is_none() {
6192 0 : self.maybe_reconcile_shard(
6193 0 : tenant_shard,
6194 0 : nodes,
6195 0 : ReconcilerPriority::Normal,
6196 0 : );
6197 0 : }
6198 0 : }
6199 : }
6200 :
6201 : // TODO: in the background, we should balance work back onto this pageserver
6202 : }
6203 : // No action required for the intermediate unavailable state.
6204 : // When we transition into active or offline from the unavailable state,
6205 : // the correct handling above will kick in.
6206 : AvailabilityTransition::ToWarmingUpFromActive => {
6207 0 : tracing::info!("Node {} transition to unavailable from active", node_id);
6208 : }
6209 : AvailabilityTransition::ToWarmingUpFromOffline => {
6210 0 : tracing::info!("Node {} transition to unavailable from offline", node_id);
6211 : }
6212 : AvailabilityTransition::Unchanged => {
6213 0 : tracing::debug!("Node {} no availability change during config", node_id);
6214 : }
6215 : }
6216 :
6217 0 : Ok(())
6218 0 : }
6219 :
6220 : /// Handle availability transition for multiple nodes
6221 : ///
6222 : /// Note that you should first call [`Self::node_state_configure`] for
6223 : /// all nodes being handled here for the handling to use fresh in-memory state.
6224 0 : async fn handle_node_availability_transitions(
6225 0 : &self,
6226 0 : transitions: Vec<(
6227 0 : NodeId,
6228 0 : TracingExclusiveGuard<NodeOperations>,
6229 0 : AvailabilityTransition,
6230 0 : )>,
6231 0 : ) -> Result<(), Vec<(NodeId, ApiError)>> {
6232 0 : let mut errors = Vec::default();
6233 0 : for (node_id, node_lock, transition) in transitions {
6234 0 : let res = self
6235 0 : .handle_node_availability_transition(node_id, transition, &node_lock)
6236 0 : .await;
6237 0 : if let Err(err) = res {
6238 0 : errors.push((node_id, err));
6239 0 : }
6240 : }
6241 :
6242 0 : if errors.is_empty() {
6243 0 : Ok(())
6244 : } else {
6245 0 : Err(errors)
6246 : }
6247 0 : }
6248 :
6249 0 : pub(crate) async fn node_configure(
6250 0 : &self,
6251 0 : node_id: NodeId,
6252 0 : availability: Option<NodeAvailability>,
6253 0 : scheduling: Option<NodeSchedulingPolicy>,
6254 0 : ) -> Result<(), ApiError> {
6255 0 : let node_lock =
6256 0 : trace_exclusive_lock(&self.node_op_locks, node_id, NodeOperations::Configure).await;
6257 :
6258 0 : let transition = self
6259 0 : .node_state_configure(node_id, availability, scheduling, &node_lock)
6260 0 : .await?;
6261 0 : self.handle_node_availability_transition(node_id, transition, &node_lock)
6262 0 : .await
6263 0 : }
6264 :
6265 : /// Wrapper around [`Self::node_configure`] which only allows changes while there is no ongoing
6266 : /// operation for HTTP api.
6267 0 : pub(crate) async fn external_node_configure(
6268 0 : &self,
6269 0 : node_id: NodeId,
6270 0 : availability: Option<NodeAvailability>,
6271 0 : scheduling: Option<NodeSchedulingPolicy>,
6272 0 : ) -> Result<(), ApiError> {
6273 0 : {
6274 0 : let locked = self.inner.read().unwrap();
6275 0 : if let Some(op) = locked.ongoing_operation.as_ref().map(|op| op.operation) {
6276 0 : return Err(ApiError::PreconditionFailed(
6277 0 : format!("Ongoing background operation forbids configuring: {op}").into(),
6278 0 : ));
6279 0 : }
6280 0 : }
6281 0 :
6282 0 : self.node_configure(node_id, availability, scheduling).await
6283 0 : }
6284 :
6285 0 : pub(crate) async fn start_node_drain(
6286 0 : self: &Arc<Self>,
6287 0 : node_id: NodeId,
6288 0 : ) -> Result<(), ApiError> {
6289 0 : let (ongoing_op, node_available, node_policy, schedulable_nodes_count) = {
6290 0 : let locked = self.inner.read().unwrap();
6291 0 : let nodes = &locked.nodes;
6292 0 : let node = nodes.get(&node_id).ok_or(ApiError::NotFound(
6293 0 : anyhow::anyhow!("Node {} not registered", node_id).into(),
6294 0 : ))?;
6295 0 : let schedulable_nodes_count = nodes
6296 0 : .iter()
6297 0 : .filter(|(_, n)| matches!(n.may_schedule(), MaySchedule::Yes(_)))
6298 0 : .count();
6299 0 :
6300 0 : (
6301 0 : locked
6302 0 : .ongoing_operation
6303 0 : .as_ref()
6304 0 : .map(|ongoing| ongoing.operation),
6305 0 : node.is_available(),
6306 0 : node.get_scheduling(),
6307 0 : schedulable_nodes_count,
6308 0 : )
6309 0 : };
6310 :
6311 0 : if let Some(ongoing) = ongoing_op {
6312 0 : return Err(ApiError::PreconditionFailed(
6313 0 : format!("Background operation already ongoing for node: {}", ongoing).into(),
6314 0 : ));
6315 0 : }
6316 0 :
6317 0 : if !node_available {
6318 0 : return Err(ApiError::ResourceUnavailable(
6319 0 : format!("Node {node_id} is currently unavailable").into(),
6320 0 : ));
6321 0 : }
6322 0 :
6323 0 : if schedulable_nodes_count == 0 {
6324 0 : return Err(ApiError::PreconditionFailed(
6325 0 : "No other schedulable nodes to drain to".into(),
6326 0 : ));
6327 0 : }
6328 0 :
6329 0 : match node_policy {
6330 : NodeSchedulingPolicy::Active => {
6331 0 : self.node_configure(node_id, None, Some(NodeSchedulingPolicy::Draining))
6332 0 : .await?;
6333 :
6334 0 : let cancel = self.cancel.child_token();
6335 0 : let gate_guard = self.gate.enter().map_err(|_| ApiError::ShuttingDown)?;
6336 :
6337 0 : self.inner.write().unwrap().ongoing_operation = Some(OperationHandler {
6338 0 : operation: Operation::Drain(Drain { node_id }),
6339 0 : cancel: cancel.clone(),
6340 0 : });
6341 :
6342 0 : let span = tracing::info_span!(parent: None, "drain_node", %node_id);
6343 :
6344 0 : tokio::task::spawn({
6345 0 : let service = self.clone();
6346 0 : let cancel = cancel.clone();
6347 0 : async move {
6348 0 : let _gate_guard = gate_guard;
6349 0 :
6350 0 : scopeguard::defer! {
6351 0 : let prev = service.inner.write().unwrap().ongoing_operation.take();
6352 0 :
6353 0 : if let Some(Operation::Drain(removed_drain)) = prev.map(|h| h.operation) {
6354 0 : assert_eq!(removed_drain.node_id, node_id, "We always take the same operation");
6355 0 : } else {
6356 0 : panic!("We always remove the same operation")
6357 0 : }
6358 0 : }
6359 0 :
6360 0 : tracing::info!("Drain background operation starting");
6361 0 : let res = service.drain_node(node_id, cancel).await;
6362 0 : match res {
6363 : Ok(()) => {
6364 0 : tracing::info!("Drain background operation completed successfully");
6365 : }
6366 : Err(OperationError::Cancelled) => {
6367 0 : tracing::info!("Drain background operation was cancelled");
6368 : }
6369 0 : Err(err) => {
6370 0 : tracing::error!("Drain background operation encountered: {err}")
6371 : }
6372 : }
6373 0 : }
6374 0 : }.instrument(span));
6375 0 : }
6376 : NodeSchedulingPolicy::Draining => {
6377 0 : return Err(ApiError::Conflict(format!(
6378 0 : "Node {node_id} has drain in progress"
6379 0 : )));
6380 : }
6381 0 : policy => {
6382 0 : return Err(ApiError::PreconditionFailed(
6383 0 : format!("Node {node_id} cannot be drained due to {policy:?} policy").into(),
6384 0 : ));
6385 : }
6386 : }
6387 :
6388 0 : Ok(())
6389 0 : }
6390 :
6391 0 : pub(crate) async fn cancel_node_drain(&self, node_id: NodeId) -> Result<(), ApiError> {
6392 0 : let node_available = {
6393 0 : let locked = self.inner.read().unwrap();
6394 0 : let nodes = &locked.nodes;
6395 0 : let node = nodes.get(&node_id).ok_or(ApiError::NotFound(
6396 0 : anyhow::anyhow!("Node {} not registered", node_id).into(),
6397 0 : ))?;
6398 :
6399 0 : node.is_available()
6400 0 : };
6401 0 :
6402 0 : if !node_available {
6403 0 : return Err(ApiError::ResourceUnavailable(
6404 0 : format!("Node {node_id} is currently unavailable").into(),
6405 0 : ));
6406 0 : }
6407 :
6408 0 : if let Some(op_handler) = self.inner.read().unwrap().ongoing_operation.as_ref() {
6409 0 : if let Operation::Drain(drain) = op_handler.operation {
6410 0 : if drain.node_id == node_id {
6411 0 : tracing::info!("Cancelling background drain operation for node {node_id}");
6412 0 : op_handler.cancel.cancel();
6413 0 : return Ok(());
6414 0 : }
6415 0 : }
6416 0 : }
6417 :
6418 0 : Err(ApiError::PreconditionFailed(
6419 0 : format!("Node {node_id} has no drain in progress").into(),
6420 0 : ))
6421 0 : }
6422 :
6423 0 : pub(crate) async fn start_node_fill(self: &Arc<Self>, node_id: NodeId) -> Result<(), ApiError> {
6424 0 : let (ongoing_op, node_available, node_policy, total_nodes_count) = {
6425 0 : let locked = self.inner.read().unwrap();
6426 0 : let nodes = &locked.nodes;
6427 0 : let node = nodes.get(&node_id).ok_or(ApiError::NotFound(
6428 0 : anyhow::anyhow!("Node {} not registered", node_id).into(),
6429 0 : ))?;
6430 :
6431 0 : (
6432 0 : locked
6433 0 : .ongoing_operation
6434 0 : .as_ref()
6435 0 : .map(|ongoing| ongoing.operation),
6436 0 : node.is_available(),
6437 0 : node.get_scheduling(),
6438 0 : nodes.len(),
6439 0 : )
6440 0 : };
6441 :
6442 0 : if let Some(ongoing) = ongoing_op {
6443 0 : return Err(ApiError::PreconditionFailed(
6444 0 : format!("Background operation already ongoing for node: {}", ongoing).into(),
6445 0 : ));
6446 0 : }
6447 0 :
6448 0 : if !node_available {
6449 0 : return Err(ApiError::ResourceUnavailable(
6450 0 : format!("Node {node_id} is currently unavailable").into(),
6451 0 : ));
6452 0 : }
6453 0 :
6454 0 : if total_nodes_count <= 1 {
6455 0 : return Err(ApiError::PreconditionFailed(
6456 0 : "No other nodes to fill from".into(),
6457 0 : ));
6458 0 : }
6459 0 :
6460 0 : match node_policy {
6461 : NodeSchedulingPolicy::Active => {
6462 0 : self.node_configure(node_id, None, Some(NodeSchedulingPolicy::Filling))
6463 0 : .await?;
6464 :
6465 0 : let cancel = self.cancel.child_token();
6466 0 : let gate_guard = self.gate.enter().map_err(|_| ApiError::ShuttingDown)?;
6467 :
6468 0 : self.inner.write().unwrap().ongoing_operation = Some(OperationHandler {
6469 0 : operation: Operation::Fill(Fill { node_id }),
6470 0 : cancel: cancel.clone(),
6471 0 : });
6472 :
6473 0 : let span = tracing::info_span!(parent: None, "fill_node", %node_id);
6474 :
6475 0 : tokio::task::spawn({
6476 0 : let service = self.clone();
6477 0 : let cancel = cancel.clone();
6478 0 : async move {
6479 0 : let _gate_guard = gate_guard;
6480 0 :
6481 0 : scopeguard::defer! {
6482 0 : let prev = service.inner.write().unwrap().ongoing_operation.take();
6483 0 :
6484 0 : if let Some(Operation::Fill(removed_fill)) = prev.map(|h| h.operation) {
6485 0 : assert_eq!(removed_fill.node_id, node_id, "We always take the same operation");
6486 0 : } else {
6487 0 : panic!("We always remove the same operation")
6488 0 : }
6489 0 : }
6490 0 :
6491 0 : tracing::info!("Fill background operation starting");
6492 0 : let res = service.fill_node(node_id, cancel).await;
6493 0 : match res {
6494 : Ok(()) => {
6495 0 : tracing::info!("Fill background operation completed successfully");
6496 : }
6497 : Err(OperationError::Cancelled) => {
6498 0 : tracing::info!("Fill background operation was cancelled");
6499 : }
6500 0 : Err(err) => {
6501 0 : tracing::error!("Fill background operation encountered: {err}")
6502 : }
6503 : }
6504 0 : }
6505 0 : }.instrument(span));
6506 0 : }
6507 : NodeSchedulingPolicy::Filling => {
6508 0 : return Err(ApiError::Conflict(format!(
6509 0 : "Node {node_id} has fill in progress"
6510 0 : )));
6511 : }
6512 0 : policy => {
6513 0 : return Err(ApiError::PreconditionFailed(
6514 0 : format!("Node {node_id} cannot be filled due to {policy:?} policy").into(),
6515 0 : ));
6516 : }
6517 : }
6518 :
6519 0 : Ok(())
6520 0 : }
6521 :
6522 0 : pub(crate) async fn cancel_node_fill(&self, node_id: NodeId) -> Result<(), ApiError> {
6523 0 : let node_available = {
6524 0 : let locked = self.inner.read().unwrap();
6525 0 : let nodes = &locked.nodes;
6526 0 : let node = nodes.get(&node_id).ok_or(ApiError::NotFound(
6527 0 : anyhow::anyhow!("Node {} not registered", node_id).into(),
6528 0 : ))?;
6529 :
6530 0 : node.is_available()
6531 0 : };
6532 0 :
6533 0 : if !node_available {
6534 0 : return Err(ApiError::ResourceUnavailable(
6535 0 : format!("Node {node_id} is currently unavailable").into(),
6536 0 : ));
6537 0 : }
6538 :
6539 0 : if let Some(op_handler) = self.inner.read().unwrap().ongoing_operation.as_ref() {
6540 0 : if let Operation::Fill(fill) = op_handler.operation {
6541 0 : if fill.node_id == node_id {
6542 0 : tracing::info!("Cancelling background drain operation for node {node_id}");
6543 0 : op_handler.cancel.cancel();
6544 0 : return Ok(());
6545 0 : }
6546 0 : }
6547 0 : }
6548 :
6549 0 : Err(ApiError::PreconditionFailed(
6550 0 : format!("Node {node_id} has no fill in progress").into(),
6551 0 : ))
6552 0 : }
6553 :
6554 : /// Like [`Self::maybe_configured_reconcile_shard`], but uses the default reconciler
6555 : /// configuration
6556 0 : fn maybe_reconcile_shard(
6557 0 : &self,
6558 0 : shard: &mut TenantShard,
6559 0 : nodes: &Arc<HashMap<NodeId, Node>>,
6560 0 : priority: ReconcilerPriority,
6561 0 : ) -> Option<ReconcilerWaiter> {
6562 0 : self.maybe_configured_reconcile_shard(shard, nodes, ReconcilerConfig::new(priority))
6563 0 : }
6564 :
6565 : /// Before constructing a Reconciler, acquire semaphore units from the appropriate concurrency limit (depends on priority)
6566 0 : fn get_reconciler_units(
6567 0 : &self,
6568 0 : priority: ReconcilerPriority,
6569 0 : ) -> Result<ReconcileUnits, TryAcquireError> {
6570 0 : let units = match priority {
6571 0 : ReconcilerPriority::Normal => self.reconciler_concurrency.clone().try_acquire_owned(),
6572 : ReconcilerPriority::High => {
6573 0 : match self
6574 0 : .priority_reconciler_concurrency
6575 0 : .clone()
6576 0 : .try_acquire_owned()
6577 : {
6578 0 : Ok(u) => Ok(u),
6579 : Err(TryAcquireError::NoPermits) => {
6580 : // If the high priority semaphore is exhausted, then high priority tasks may steal units from
6581 : // the normal priority semaphore.
6582 0 : self.reconciler_concurrency.clone().try_acquire_owned()
6583 : }
6584 0 : Err(e) => Err(e),
6585 : }
6586 : }
6587 : };
6588 :
6589 0 : units.map(ReconcileUnits::new)
6590 0 : }
6591 :
6592 : /// Wrap [`TenantShard`] reconciliation methods with acquisition of [`Gate`] and [`ReconcileUnits`],
6593 0 : fn maybe_configured_reconcile_shard(
6594 0 : &self,
6595 0 : shard: &mut TenantShard,
6596 0 : nodes: &Arc<HashMap<NodeId, Node>>,
6597 0 : reconciler_config: ReconcilerConfig,
6598 0 : ) -> Option<ReconcilerWaiter> {
6599 0 : let reconcile_needed = shard.get_reconcile_needed(nodes);
6600 0 :
6601 0 : match reconcile_needed {
6602 0 : ReconcileNeeded::No => return None,
6603 0 : ReconcileNeeded::WaitExisting(waiter) => return Some(waiter),
6604 0 : ReconcileNeeded::Yes => {
6605 0 : // Fall through to try and acquire units for spawning reconciler
6606 0 : }
6607 : };
6608 :
6609 0 : let units = match self.get_reconciler_units(reconciler_config.priority) {
6610 0 : Ok(u) => u,
6611 : Err(_) => {
6612 0 : tracing::info!(tenant_id=%shard.tenant_shard_id.tenant_id, shard_id=%shard.tenant_shard_id.shard_slug(),
6613 0 : "Concurrency limited: enqueued for reconcile later");
6614 0 : if !shard.delayed_reconcile {
6615 0 : match self.delayed_reconcile_tx.try_send(shard.tenant_shard_id) {
6616 0 : Err(TrySendError::Closed(_)) => {
6617 0 : // Weird mid-shutdown case?
6618 0 : }
6619 : Err(TrySendError::Full(_)) => {
6620 : // It is safe to skip sending our ID in the channel: we will eventually get retried by the background reconcile task.
6621 0 : tracing::warn!(
6622 0 : "Many shards are waiting to reconcile: delayed_reconcile queue is full"
6623 : );
6624 : }
6625 0 : Ok(()) => {
6626 0 : shard.delayed_reconcile = true;
6627 0 : }
6628 : }
6629 0 : }
6630 :
6631 : // We won't spawn a reconciler, but we will construct a waiter that waits for the shard's sequence
6632 : // number to advance. When this function is eventually called again and succeeds in getting units,
6633 : // it will spawn a reconciler that makes this waiter complete.
6634 0 : return Some(shard.future_reconcile_waiter());
6635 : }
6636 : };
6637 :
6638 0 : let Ok(gate_guard) = self.reconcilers_gate.enter() else {
6639 : // Gate closed: we're shutting down, drop out.
6640 0 : return None;
6641 : };
6642 :
6643 0 : shard.spawn_reconciler(
6644 0 : &self.result_tx,
6645 0 : nodes,
6646 0 : &self.compute_hook,
6647 0 : reconciler_config,
6648 0 : &self.config,
6649 0 : &self.persistence,
6650 0 : units,
6651 0 : gate_guard,
6652 0 : &self.reconcilers_cancel,
6653 0 : )
6654 0 : }
6655 :
6656 : /// Check all tenants for pending reconciliation work, and reconcile those in need.
6657 : /// Additionally, reschedule tenants that require it.
6658 : ///
6659 : /// Returns how many reconciliation tasks were started, or `1` if no reconciles were
6660 : /// spawned but some _would_ have been spawned if `reconciler_concurrency` units where
6661 : /// available. A return value of 0 indicates that everything is fully reconciled already.
6662 0 : fn reconcile_all(&self) -> usize {
6663 0 : let mut locked = self.inner.write().unwrap();
6664 0 : let (nodes, tenants, scheduler) = locked.parts_mut();
6665 0 : let pageservers = nodes.clone();
6666 0 :
6667 0 : // This function is an efficient place to update lazy statistics, since we are walking
6668 0 : // all tenants.
6669 0 : let mut pending_reconciles = 0;
6670 0 : let mut az_violations = 0;
6671 0 :
6672 0 : // If we find any tenants to drop from memory, stash them to offload after
6673 0 : // we're done traversing the map of tenants.
6674 0 : let mut drop_detached_tenants = Vec::new();
6675 0 :
6676 0 : let mut reconciles_spawned = 0;
6677 0 : for shard in tenants.values_mut() {
6678 : // Accumulate scheduling statistics
6679 0 : if let (Some(attached), Some(preferred)) =
6680 0 : (shard.intent.get_attached(), shard.preferred_az())
6681 : {
6682 0 : let node_az = nodes
6683 0 : .get(attached)
6684 0 : .expect("Nodes exist if referenced")
6685 0 : .get_availability_zone_id();
6686 0 : if node_az != preferred {
6687 0 : az_violations += 1;
6688 0 : }
6689 0 : }
6690 :
6691 : // Skip checking if this shard is already enqueued for reconciliation
6692 0 : if shard.delayed_reconcile && self.reconciler_concurrency.available_permits() == 0 {
6693 : // If there is something delayed, then return a nonzero count so that
6694 : // callers like reconcile_all_now do not incorrectly get the impression
6695 : // that the system is in a quiescent state.
6696 0 : reconciles_spawned = std::cmp::max(1, reconciles_spawned);
6697 0 : pending_reconciles += 1;
6698 0 : continue;
6699 0 : }
6700 0 :
6701 0 : // Eventual consistency: if an earlier reconcile job failed, and the shard is still
6702 0 : // dirty, spawn another rone
6703 0 : if self
6704 0 : .maybe_reconcile_shard(shard, &pageservers, ReconcilerPriority::Normal)
6705 0 : .is_some()
6706 0 : {
6707 0 : reconciles_spawned += 1;
6708 0 : } else if shard.delayed_reconcile {
6709 0 : // Shard wanted to reconcile but for some reason couldn't.
6710 0 : pending_reconciles += 1;
6711 0 : }
6712 :
6713 : // If this tenant is detached, try dropping it from memory. This is usually done
6714 : // proactively in [`Self::process_results`], but we do it here to handle the edge
6715 : // case where a reconcile completes while someone else is holding an op lock for the tenant.
6716 0 : if shard.tenant_shard_id.shard_number == ShardNumber(0)
6717 0 : && shard.policy == PlacementPolicy::Detached
6718 : {
6719 0 : if let Some(guard) = self.tenant_op_locks.try_exclusive(
6720 0 : shard.tenant_shard_id.tenant_id,
6721 0 : TenantOperations::DropDetached,
6722 0 : ) {
6723 0 : drop_detached_tenants.push((shard.tenant_shard_id.tenant_id, guard));
6724 0 : }
6725 0 : }
6726 : }
6727 :
6728 : // Some metrics are calculated from SchedulerNode state, update these periodically
6729 0 : scheduler.update_metrics();
6730 :
6731 : // Process any deferred tenant drops
6732 0 : for (tenant_id, guard) in drop_detached_tenants {
6733 0 : self.maybe_drop_tenant(tenant_id, &mut locked, &guard);
6734 0 : }
6735 :
6736 0 : metrics::METRICS_REGISTRY
6737 0 : .metrics_group
6738 0 : .storage_controller_schedule_az_violation
6739 0 : .set(az_violations as i64);
6740 0 :
6741 0 : metrics::METRICS_REGISTRY
6742 0 : .metrics_group
6743 0 : .storage_controller_pending_reconciles
6744 0 : .set(pending_reconciles as i64);
6745 0 :
6746 0 : reconciles_spawned
6747 0 : }
6748 :
6749 : /// `optimize` in this context means identifying shards which have valid scheduled locations, but
6750 : /// could be scheduled somewhere better:
6751 : /// - Cutting over to a secondary if the node with the secondary is more lightly loaded
6752 : /// * e.g. after a node fails then recovers, to move some work back to it
6753 : /// - Cutting over to a secondary if it improves the spread of shard attachments within a tenant
6754 : /// * e.g. after a shard split, the initial attached locations will all be on the node where
6755 : /// we did the split, but are probably better placed elsewhere.
6756 : /// - Creating new secondary locations if it improves the spreading of a sharded tenant
6757 : /// * e.g. after a shard split, some locations will be on the same node (where the split
6758 : /// happened), and will probably be better placed elsewhere.
6759 : ///
6760 : /// To put it more briefly: whereas the scheduler respects soft constraints in a ScheduleContext at
6761 : /// the time of scheduling, this function looks for cases where a better-scoring location is available
6762 : /// according to those same soft constraints.
6763 0 : async fn optimize_all(&self) -> usize {
6764 : // Limit on how many shards' optmizations each call to this function will execute. Combined
6765 : // with the frequency of background calls, this acts as an implicit rate limit that runs a small
6766 : // trickle of optimizations in the background, rather than executing a large number in parallel
6767 : // when a change occurs.
6768 : const MAX_OPTIMIZATIONS_EXEC_PER_PASS: usize = 2;
6769 :
6770 : // Synchronous prepare: scan shards for possible scheduling optimizations
6771 0 : let candidate_work = self.optimize_all_plan();
6772 0 : let candidate_work_len = candidate_work.len();
6773 :
6774 : // Asynchronous validate: I/O to pageservers to make sure shards are in a good state to apply validation
6775 0 : let validated_work = self.optimize_all_validate(candidate_work).await;
6776 :
6777 0 : let was_work_filtered = validated_work.len() != candidate_work_len;
6778 0 :
6779 0 : // Synchronous apply: update the shards' intent states according to validated optimisations
6780 0 : let mut reconciles_spawned = 0;
6781 0 : let mut optimizations_applied = 0;
6782 0 : let mut locked = self.inner.write().unwrap();
6783 0 : let (nodes, tenants, scheduler) = locked.parts_mut();
6784 0 : for (tenant_shard_id, optimization) in validated_work {
6785 0 : let Some(shard) = tenants.get_mut(&tenant_shard_id) else {
6786 : // Shard was dropped between planning and execution;
6787 0 : continue;
6788 : };
6789 0 : tracing::info!(tenant_shard_id=%tenant_shard_id, "Applying optimization: {optimization:?}");
6790 0 : if shard.apply_optimization(scheduler, optimization) {
6791 0 : optimizations_applied += 1;
6792 0 : if self
6793 0 : .maybe_reconcile_shard(shard, nodes, ReconcilerPriority::Normal)
6794 0 : .is_some()
6795 0 : {
6796 0 : reconciles_spawned += 1;
6797 0 : }
6798 0 : }
6799 :
6800 0 : if optimizations_applied >= MAX_OPTIMIZATIONS_EXEC_PER_PASS {
6801 0 : break;
6802 0 : }
6803 : }
6804 :
6805 0 : if was_work_filtered {
6806 0 : // If we filtered any work out during validation, ensure we return a nonzero value to indicate
6807 0 : // to callers that the system is not in a truly quiet state, it's going to do some work as soon
6808 0 : // as these validations start passing.
6809 0 : reconciles_spawned = std::cmp::max(reconciles_spawned, 1);
6810 0 : }
6811 :
6812 0 : reconciles_spawned
6813 0 : }
6814 :
6815 0 : fn optimize_all_plan(&self) -> Vec<(TenantShardId, ScheduleOptimization)> {
6816 : // How many candidate optimizations we will generate, before evaluating them for readniess: setting
6817 : // this higher than the execution limit gives us a chance to execute some work even if the first
6818 : // few optimizations we find are not ready.
6819 : const MAX_OPTIMIZATIONS_PLAN_PER_PASS: usize = 8;
6820 :
6821 0 : let mut work = Vec::new();
6822 0 : let mut locked = self.inner.write().unwrap();
6823 0 : let (_nodes, tenants, scheduler) = locked.parts_mut();
6824 :
6825 : // We are going to plan a bunch of optimisations before applying any of them, so the
6826 : // utilisation stats on nodes will be effectively stale for the >1st optimisation we
6827 : // generate. To avoid this causing unstable migrations/flapping, it's important that the
6828 : // code in TenantShard for finding optimisations uses [`NodeAttachmentSchedulingScore::disregard_utilization`]
6829 : // to ignore the utilisation component of the score.
6830 :
6831 0 : for (_tenant_id, schedule_context, shards) in
6832 0 : TenantShardContextIterator::new(tenants, ScheduleMode::Speculative)
6833 : {
6834 0 : for shard in shards {
6835 0 : if work.len() >= MAX_OPTIMIZATIONS_PLAN_PER_PASS {
6836 0 : break;
6837 0 : }
6838 0 : match shard.get_scheduling_policy() {
6839 0 : ShardSchedulingPolicy::Active => {
6840 0 : // Ok to do optimization
6841 0 : }
6842 : ShardSchedulingPolicy::Essential
6843 : | ShardSchedulingPolicy::Pause
6844 : | ShardSchedulingPolicy::Stop => {
6845 : // Policy prevents optimizing this shard.
6846 0 : continue;
6847 : }
6848 : }
6849 :
6850 0 : if !matches!(shard.splitting, SplitState::Idle)
6851 0 : || matches!(shard.policy, PlacementPolicy::Detached)
6852 0 : || shard.reconciler.is_some()
6853 : {
6854 : // Do not start any optimizations while another change to the tenant is ongoing: this
6855 : // is not necessary for correctness, but simplifies operations and implicitly throttles
6856 : // optimization changes to happen in a "trickle" over time.
6857 0 : continue;
6858 0 : }
6859 0 :
6860 0 : // Fast path: we may quickly identify shards that don't have any possible optimisations
6861 0 : if !shard.maybe_optimizable(scheduler, &schedule_context) {
6862 0 : if cfg!(feature = "testing") {
6863 : // Check that maybe_optimizable doesn't disagree with the actual optimization functions.
6864 : // Only do this in testing builds because it is not a correctness-critical check, so we shouldn't
6865 : // panic in prod if we hit this, or spend cycles on it in prod.
6866 0 : assert!(shard
6867 0 : .optimize_attachment(scheduler, &schedule_context)
6868 0 : .is_none());
6869 0 : assert!(shard
6870 0 : .optimize_secondary(scheduler, &schedule_context)
6871 0 : .is_none());
6872 0 : }
6873 0 : continue;
6874 0 : }
6875 :
6876 0 : if let Some(optimization) =
6877 : // If idle, maybe optimize attachments: if a shard has a secondary location that is preferable to
6878 : // its primary location based on soft constraints, cut it over.
6879 0 : shard.optimize_attachment(scheduler, &schedule_context)
6880 : {
6881 0 : tracing::info!(tenant_shard_id=%shard.tenant_shard_id, "Identified optimization for attachment: {optimization:?}");
6882 0 : work.push((shard.tenant_shard_id, optimization));
6883 0 : break;
6884 0 : } else if let Some(optimization) =
6885 : // If idle, maybe optimize secondary locations: if a shard has a secondary location that would be
6886 : // better placed on another node, based on ScheduleContext, then adjust it. This
6887 : // covers cases like after a shard split, where we might have too many shards
6888 : // in the same tenant with secondary locations on the node where they originally split.
6889 0 : shard.optimize_secondary(scheduler, &schedule_context)
6890 : {
6891 0 : tracing::info!(tenant_shard_id=%shard.tenant_shard_id, "Identified optimization for secondary: {optimization:?}");
6892 0 : work.push((shard.tenant_shard_id, optimization));
6893 0 : break;
6894 0 : }
6895 : }
6896 : }
6897 :
6898 0 : work
6899 0 : }
6900 :
6901 0 : async fn optimize_all_validate(
6902 0 : &self,
6903 0 : candidate_work: Vec<(TenantShardId, ScheduleOptimization)>,
6904 0 : ) -> Vec<(TenantShardId, ScheduleOptimization)> {
6905 0 : // Take a clone of the node map to use outside the lock in async validation phase
6906 0 : let validation_nodes = { self.inner.read().unwrap().nodes.clone() };
6907 0 :
6908 0 : let mut want_secondary_status = Vec::new();
6909 0 :
6910 0 : // Validate our plans: this is an async phase where we may do I/O to pageservers to
6911 0 : // check that the state of locations is acceptable to run the optimization, such as
6912 0 : // checking that a secondary location is sufficiently warmed-up to cleanly cut over
6913 0 : // in a live migration.
6914 0 : let mut validated_work = Vec::new();
6915 0 : for (tenant_shard_id, optimization) in candidate_work {
6916 0 : match optimization.action {
6917 : ScheduleOptimizationAction::MigrateAttachment(MigrateAttachment {
6918 : old_attached_node_id: _,
6919 0 : new_attached_node_id,
6920 0 : }) => {
6921 0 : match validation_nodes.get(&new_attached_node_id) {
6922 0 : None => {
6923 0 : // Node was dropped between planning and validation
6924 0 : }
6925 0 : Some(node) => {
6926 0 : if !node.is_available() {
6927 0 : tracing::info!("Skipping optimization migration of {tenant_shard_id} to {new_attached_node_id} because node unavailable");
6928 0 : } else {
6929 0 : // Accumulate optimizations that require fetching secondary status, so that we can execute these
6930 0 : // remote API requests concurrently.
6931 0 : want_secondary_status.push((
6932 0 : tenant_shard_id,
6933 0 : node.clone(),
6934 0 : optimization,
6935 0 : ));
6936 0 : }
6937 : }
6938 : }
6939 : }
6940 : ScheduleOptimizationAction::ReplaceSecondary(_)
6941 : | ScheduleOptimizationAction::CreateSecondary(_)
6942 : | ScheduleOptimizationAction::RemoveSecondary(_) => {
6943 : // No extra checks needed to manage secondaries: this does not interrupt client access
6944 0 : validated_work.push((tenant_shard_id, optimization))
6945 : }
6946 : };
6947 : }
6948 :
6949 : // Call into pageserver API to find out if the destination secondary location is warm enough for a reasonably smooth migration: we
6950 : // do this so that we avoid spawning a Reconciler that would have to wait minutes/hours for a destination to warm up: that reconciler
6951 : // would hold a precious reconcile semaphore unit the whole time it was waiting for the destination to warm up.
6952 0 : let results = self
6953 0 : .tenant_for_shards_api(
6954 0 : want_secondary_status
6955 0 : .iter()
6956 0 : .map(|i| (i.0, i.1.clone()))
6957 0 : .collect(),
6958 0 : |tenant_shard_id, client| async move {
6959 0 : client.tenant_secondary_status(tenant_shard_id).await
6960 0 : },
6961 0 : 1,
6962 0 : 1,
6963 0 : SHORT_RECONCILE_TIMEOUT,
6964 0 : &self.cancel,
6965 0 : )
6966 0 : .await;
6967 :
6968 0 : for ((tenant_shard_id, node, optimization), secondary_status) in
6969 0 : want_secondary_status.into_iter().zip(results.into_iter())
6970 : {
6971 0 : match secondary_status {
6972 0 : Err(e) => {
6973 0 : tracing::info!("Skipping migration of {tenant_shard_id} to {node}, error querying secondary: {e}");
6974 : }
6975 0 : Ok(progress) => {
6976 : // We require secondary locations to have less than 10GiB of downloads pending before we will use
6977 : // them in an optimization
6978 : const DOWNLOAD_FRESHNESS_THRESHOLD: u64 = 10 * 1024 * 1024 * 1024;
6979 :
6980 0 : if progress.heatmap_mtime.is_none()
6981 0 : || progress.bytes_total < DOWNLOAD_FRESHNESS_THRESHOLD
6982 0 : && progress.bytes_downloaded != progress.bytes_total
6983 0 : || progress.bytes_total - progress.bytes_downloaded
6984 0 : > DOWNLOAD_FRESHNESS_THRESHOLD
6985 : {
6986 0 : tracing::info!("Skipping migration of {tenant_shard_id} to {node} because secondary isn't ready: {progress:?}");
6987 :
6988 : #[cfg(feature = "testing")]
6989 0 : if progress.heatmap_mtime.is_none() {
6990 : // No heatmap might mean the attached location has never uploaded one, or that
6991 : // the secondary download hasn't happened yet. This is relatively unusual in the field,
6992 : // but fairly common in tests.
6993 0 : self.kick_secondary_download(tenant_shard_id).await;
6994 0 : }
6995 : } else {
6996 : // Location looks ready: proceed
6997 0 : tracing::info!(
6998 0 : "{tenant_shard_id} secondary on {node} is warm enough for migration: {progress:?}"
6999 : );
7000 0 : validated_work.push((tenant_shard_id, optimization))
7001 : }
7002 : }
7003 : }
7004 : }
7005 :
7006 0 : validated_work
7007 0 : }
7008 :
7009 : /// Some aspects of scheduling optimisation wait for secondary locations to be warm. This
7010 : /// happens on multi-minute timescales in the field, which is fine because optimisation is meant
7011 : /// to be a lazy background thing. However, when testing, it is not practical to wait around, so
7012 : /// we have this helper to move things along faster.
7013 : #[cfg(feature = "testing")]
7014 0 : async fn kick_secondary_download(&self, tenant_shard_id: TenantShardId) {
7015 0 : let (attached_node, secondaries) = {
7016 0 : let locked = self.inner.read().unwrap();
7017 0 : let Some(shard) = locked.tenants.get(&tenant_shard_id) else {
7018 0 : tracing::warn!(
7019 0 : "Skipping kick of secondary download for {tenant_shard_id}: not found"
7020 : );
7021 0 : return;
7022 : };
7023 :
7024 0 : let Some(attached) = shard.intent.get_attached() else {
7025 0 : tracing::warn!(
7026 0 : "Skipping kick of secondary download for {tenant_shard_id}: no attached"
7027 : );
7028 0 : return;
7029 : };
7030 :
7031 0 : let secondaries = shard
7032 0 : .intent
7033 0 : .get_secondary()
7034 0 : .iter()
7035 0 : .map(|n| locked.nodes.get(n).unwrap().clone())
7036 0 : .collect::<Vec<_>>();
7037 0 :
7038 0 : (locked.nodes.get(attached).unwrap().clone(), secondaries)
7039 0 : };
7040 0 :
7041 0 : // Make remote API calls to upload + download heatmaps: we ignore errors because this is just
7042 0 : // a 'kick' to let scheduling optimisation run more promptly.
7043 0 : match attached_node
7044 0 : .with_client_retries(
7045 0 : |client| async move { client.tenant_heatmap_upload(tenant_shard_id).await },
7046 0 : &self.config.jwt_token,
7047 0 : 3,
7048 0 : 10,
7049 0 : SHORT_RECONCILE_TIMEOUT,
7050 0 : &self.cancel,
7051 0 : )
7052 0 : .await
7053 : {
7054 0 : Some(Err(e)) => {
7055 0 : tracing::info!(
7056 0 : "Failed to upload heatmap from {attached_node} for {tenant_shard_id}: {e}"
7057 : );
7058 : }
7059 : None => {
7060 0 : tracing::info!(
7061 0 : "Cancelled while uploading heatmap from {attached_node} for {tenant_shard_id}"
7062 : );
7063 : }
7064 : Some(Ok(_)) => {
7065 0 : tracing::info!(
7066 0 : "Successfully uploaded heatmap from {attached_node} for {tenant_shard_id}"
7067 : );
7068 : }
7069 : }
7070 :
7071 0 : for secondary_node in secondaries {
7072 0 : match secondary_node
7073 0 : .with_client_retries(
7074 0 : |client| async move {
7075 0 : client
7076 0 : .tenant_secondary_download(
7077 0 : tenant_shard_id,
7078 0 : Some(Duration::from_secs(1)),
7079 0 : )
7080 0 : .await
7081 0 : },
7082 0 : &self.config.jwt_token,
7083 0 : 3,
7084 0 : 10,
7085 0 : SHORT_RECONCILE_TIMEOUT,
7086 0 : &self.cancel,
7087 0 : )
7088 0 : .await
7089 : {
7090 0 : Some(Err(e)) => {
7091 0 : tracing::info!(
7092 0 : "Failed to download heatmap from {secondary_node} for {tenant_shard_id}: {e}"
7093 : );
7094 : }
7095 : None => {
7096 0 : tracing::info!("Cancelled while downloading heatmap from {secondary_node} for {tenant_shard_id}");
7097 : }
7098 0 : Some(Ok(progress)) => {
7099 0 : tracing::info!("Successfully downloaded heatmap from {secondary_node} for {tenant_shard_id}: {progress:?}");
7100 : }
7101 : }
7102 : }
7103 0 : }
7104 :
7105 : /// Look for shards which are oversized and in need of splitting
7106 0 : async fn autosplit_tenants(self: &Arc<Self>) {
7107 0 : let Some(split_threshold) = self.config.split_threshold else {
7108 : // Auto-splitting is disabled
7109 0 : return;
7110 : };
7111 :
7112 0 : let nodes = self.inner.read().unwrap().nodes.clone();
7113 :
7114 : const SPLIT_TO_MAX: ShardCount = ShardCount::new(8);
7115 :
7116 0 : let mut top_n = Vec::new();
7117 0 :
7118 0 : // Call into each node to look for big tenants
7119 0 : let top_n_request = TopTenantShardsRequest {
7120 0 : // We currently split based on logical size, for simplicity: logical size is a signal of
7121 0 : // the user's intent to run a large database, whereas physical/resident size can be symptoms
7122 0 : // of compaction issues. Eventually we should switch to using resident size to bound the
7123 0 : // disk space impact of one shard.
7124 0 : order_by: models::TenantSorting::MaxLogicalSize,
7125 0 : limit: 10,
7126 0 : where_shards_lt: Some(SPLIT_TO_MAX),
7127 0 : where_gt: Some(split_threshold),
7128 0 : };
7129 0 : for node in nodes.values() {
7130 0 : let request_ref = &top_n_request;
7131 0 : match node
7132 0 : .with_client_retries(
7133 0 : |client| async move {
7134 0 : let request = request_ref.clone();
7135 0 : client.top_tenant_shards(request.clone()).await
7136 0 : },
7137 0 : &self.config.jwt_token,
7138 0 : 3,
7139 0 : 3,
7140 0 : Duration::from_secs(5),
7141 0 : &self.cancel,
7142 0 : )
7143 0 : .await
7144 : {
7145 0 : Some(Ok(node_top_n)) => {
7146 0 : top_n.extend(node_top_n.shards.into_iter());
7147 0 : }
7148 : Some(Err(mgmt_api::Error::Cancelled)) => {
7149 0 : continue;
7150 : }
7151 0 : Some(Err(e)) => {
7152 0 : tracing::warn!("Failed to fetch top N tenants from {node}: {e}");
7153 0 : continue;
7154 : }
7155 : None => {
7156 : // Node is shutting down
7157 0 : continue;
7158 : }
7159 : };
7160 : }
7161 :
7162 : // Pick the biggest tenant to split first
7163 0 : top_n.sort_by_key(|i| i.resident_size);
7164 0 :
7165 0 : // Filter out tenants in a prohibiting scheduling mode
7166 0 : {
7167 0 : let locked = self.inner.read().unwrap();
7168 0 : top_n.retain(|i| {
7169 0 : if let Some(shard) = locked.tenants.get(&i.id) {
7170 0 : matches!(shard.get_scheduling_policy(), ShardSchedulingPolicy::Active)
7171 : } else {
7172 0 : false
7173 : }
7174 0 : });
7175 0 : }
7176 :
7177 0 : let Some(split_candidate) = top_n.into_iter().next() else {
7178 0 : tracing::debug!("No split-elegible shards found");
7179 0 : return;
7180 : };
7181 :
7182 : // We spawn a task to run this, so it's exactly like some external API client requesting it. We don't
7183 : // want to block the background reconcile loop on this.
7184 0 : tracing::info!("Auto-splitting tenant for size threshold {split_threshold}: current size {split_candidate:?}");
7185 :
7186 0 : let this = self.clone();
7187 0 : tokio::spawn(
7188 0 : async move {
7189 0 : match this
7190 0 : .tenant_shard_split(
7191 0 : split_candidate.id.tenant_id,
7192 0 : TenantShardSplitRequest {
7193 0 : // Always split to the max number of shards: this avoids stepping through
7194 0 : // intervening shard counts and encountering the overrhead of a split+cleanup
7195 0 : // each time as a tenant grows, and is not too expensive because our max shard
7196 0 : // count is relatively low anyway.
7197 0 : // This policy will be adjusted in future once we support higher shard count.
7198 0 : new_shard_count: SPLIT_TO_MAX.literal(),
7199 0 : new_stripe_size: Some(ShardParameters::DEFAULT_STRIPE_SIZE),
7200 0 : },
7201 0 : )
7202 0 : .await
7203 : {
7204 : Ok(_) => {
7205 0 : tracing::info!("Successful auto-split");
7206 : }
7207 0 : Err(e) => {
7208 0 : tracing::error!("Auto-split failed: {e}");
7209 : }
7210 : }
7211 0 : }
7212 0 : .instrument(tracing::info_span!("auto_split", tenant_id=%split_candidate.id.tenant_id)),
7213 : );
7214 0 : }
7215 :
7216 : /// Useful for tests: run whatever work a background [`Self::reconcile_all`] would have done, but
7217 : /// also wait for any generated Reconcilers to complete. Calling this until it returns zero should
7218 : /// put the system into a quiescent state where future background reconciliations won't do anything.
7219 0 : pub(crate) async fn reconcile_all_now(&self) -> Result<usize, ReconcileWaitError> {
7220 0 : let reconciles_spawned = self.reconcile_all();
7221 0 : let reconciles_spawned = if reconciles_spawned == 0 {
7222 : // Only optimize when we are otherwise idle
7223 0 : self.optimize_all().await
7224 : } else {
7225 0 : reconciles_spawned
7226 : };
7227 :
7228 0 : let waiters = {
7229 0 : let mut waiters = Vec::new();
7230 0 : let locked = self.inner.read().unwrap();
7231 0 : for (_tenant_shard_id, shard) in locked.tenants.iter() {
7232 0 : if let Some(waiter) = shard.get_waiter() {
7233 0 : waiters.push(waiter);
7234 0 : }
7235 : }
7236 0 : waiters
7237 0 : };
7238 0 :
7239 0 : let waiter_count = waiters.len();
7240 0 : match self.await_waiters(waiters, RECONCILE_TIMEOUT).await {
7241 0 : Ok(()) => {}
7242 0 : Err(ReconcileWaitError::Failed(_, reconcile_error))
7243 0 : if matches!(*reconcile_error, ReconcileError::Cancel) =>
7244 0 : {
7245 0 : // Ignore reconciler cancel errors: this reconciler might have shut down
7246 0 : // because some other change superceded it. We will return a nonzero number,
7247 0 : // so the caller knows they might have to call again to quiesce the system.
7248 0 : }
7249 0 : Err(e) => {
7250 0 : return Err(e);
7251 : }
7252 : };
7253 :
7254 0 : tracing::info!(
7255 0 : "{} reconciles in reconcile_all, {} waiters",
7256 : reconciles_spawned,
7257 : waiter_count
7258 : );
7259 :
7260 0 : Ok(std::cmp::max(waiter_count, reconciles_spawned))
7261 0 : }
7262 :
7263 0 : async fn stop_reconciliations(&self, reason: StopReconciliationsReason) {
7264 0 : // Cancel all on-going reconciles and wait for them to exit the gate.
7265 0 : tracing::info!("{reason}: cancelling and waiting for in-flight reconciles");
7266 0 : self.reconcilers_cancel.cancel();
7267 0 : self.reconcilers_gate.close().await;
7268 :
7269 : // Signal the background loop in [`Service::process_results`] to exit once
7270 : // it has proccessed the results from all the reconciles we cancelled earlier.
7271 0 : tracing::info!("{reason}: processing results from previously in-flight reconciles");
7272 0 : self.result_tx.send(ReconcileResultRequest::Stop).ok();
7273 0 : self.result_tx.closed().await;
7274 0 : }
7275 :
7276 0 : pub async fn shutdown(&self) {
7277 0 : self.stop_reconciliations(StopReconciliationsReason::ShuttingDown)
7278 0 : .await;
7279 :
7280 : // Background tasks hold gate guards: this notifies them of the cancellation and
7281 : // waits for them all to complete.
7282 0 : tracing::info!("Shutting down: cancelling and waiting for background tasks to exit");
7283 0 : self.cancel.cancel();
7284 0 : self.gate.close().await;
7285 0 : }
7286 :
7287 : /// Spot check the download lag for a secondary location of a shard.
7288 : /// Should be used as a heuristic, since it's not always precise: the
7289 : /// secondary might have not downloaded the new heat map yet and, hence,
7290 : /// is not aware of the lag.
7291 : ///
7292 : /// Returns:
7293 : /// * Ok(None) if the lag could not be determined from the status,
7294 : /// * Ok(Some(_)) if the lag could be determind
7295 : /// * Err on failures to query the pageserver.
7296 0 : async fn secondary_lag(
7297 0 : &self,
7298 0 : secondary: &NodeId,
7299 0 : tenant_shard_id: TenantShardId,
7300 0 : ) -> Result<Option<u64>, mgmt_api::Error> {
7301 0 : let nodes = self.inner.read().unwrap().nodes.clone();
7302 0 : let node = nodes.get(secondary).ok_or(mgmt_api::Error::ApiError(
7303 0 : StatusCode::NOT_FOUND,
7304 0 : format!("Node with id {} not found", secondary),
7305 0 : ))?;
7306 :
7307 0 : match node
7308 0 : .with_client_retries(
7309 0 : |client| async move { client.tenant_secondary_status(tenant_shard_id).await },
7310 0 : &self.config.jwt_token,
7311 0 : 1,
7312 0 : 3,
7313 0 : Duration::from_millis(250),
7314 0 : &self.cancel,
7315 0 : )
7316 0 : .await
7317 : {
7318 0 : Some(Ok(status)) => match status.heatmap_mtime {
7319 0 : Some(_) => Ok(Some(status.bytes_total - status.bytes_downloaded)),
7320 0 : None => Ok(None),
7321 : },
7322 0 : Some(Err(e)) => Err(e),
7323 0 : None => Err(mgmt_api::Error::Cancelled),
7324 : }
7325 0 : }
7326 :
7327 : /// Drain a node by moving the shards attached to it as primaries.
7328 : /// This is a long running operation and it should run as a separate Tokio task.
7329 0 : pub(crate) async fn drain_node(
7330 0 : self: &Arc<Self>,
7331 0 : node_id: NodeId,
7332 0 : cancel: CancellationToken,
7333 0 : ) -> Result<(), OperationError> {
7334 : const MAX_SECONDARY_LAG_BYTES_DEFAULT: u64 = 256 * 1024 * 1024;
7335 0 : let max_secondary_lag_bytes = self
7336 0 : .config
7337 0 : .max_secondary_lag_bytes
7338 0 : .unwrap_or(MAX_SECONDARY_LAG_BYTES_DEFAULT);
7339 :
7340 : // By default, live migrations are generous about the wait time for getting
7341 : // the secondary location up to speed. When draining, give up earlier in order
7342 : // to not stall the operation when a cold secondary is encountered.
7343 : const SECONDARY_WARMUP_TIMEOUT: Duration = Duration::from_secs(20);
7344 : const SECONDARY_DOWNLOAD_REQUEST_TIMEOUT: Duration = Duration::from_secs(5);
7345 0 : let reconciler_config = ReconcilerConfigBuilder::new(ReconcilerPriority::Normal)
7346 0 : .secondary_warmup_timeout(SECONDARY_WARMUP_TIMEOUT)
7347 0 : .secondary_download_request_timeout(SECONDARY_DOWNLOAD_REQUEST_TIMEOUT)
7348 0 : .build();
7349 0 :
7350 0 : let mut waiters = Vec::new();
7351 0 :
7352 0 : let mut tid_iter = TenantShardIterator::new({
7353 0 : let service = self.clone();
7354 0 : move |last_inspected_shard: Option<TenantShardId>| {
7355 0 : let locked = &service.inner.read().unwrap();
7356 0 : let tenants = &locked.tenants;
7357 0 : let entry = match last_inspected_shard {
7358 0 : Some(skip_past) => {
7359 0 : // Skip to the last seen tenant shard id
7360 0 : let mut cursor = tenants.iter().skip_while(|(tid, _)| **tid != skip_past);
7361 0 :
7362 0 : // Skip past the last seen
7363 0 : cursor.nth(1)
7364 : }
7365 0 : None => tenants.first_key_value(),
7366 : };
7367 :
7368 0 : entry.map(|(tid, _)| tid).copied()
7369 0 : }
7370 0 : });
7371 :
7372 0 : while !tid_iter.finished() {
7373 0 : if cancel.is_cancelled() {
7374 0 : match self
7375 0 : .node_configure(node_id, None, Some(NodeSchedulingPolicy::Active))
7376 0 : .await
7377 : {
7378 0 : Ok(()) => return Err(OperationError::Cancelled),
7379 0 : Err(err) => {
7380 0 : return Err(OperationError::FinalizeError(
7381 0 : format!(
7382 0 : "Failed to finalise drain cancel of {} by setting scheduling policy to Active: {}",
7383 0 : node_id, err
7384 0 : )
7385 0 : .into(),
7386 0 : ));
7387 : }
7388 : }
7389 0 : }
7390 0 :
7391 0 : drain_utils::validate_node_state(&node_id, self.inner.read().unwrap().nodes.clone())?;
7392 :
7393 0 : while waiters.len() < MAX_RECONCILES_PER_OPERATION {
7394 0 : let tid = match tid_iter.next() {
7395 0 : Some(tid) => tid,
7396 : None => {
7397 0 : break;
7398 : }
7399 : };
7400 :
7401 0 : let tid_drain = TenantShardDrain {
7402 0 : drained_node: node_id,
7403 0 : tenant_shard_id: tid,
7404 0 : };
7405 :
7406 0 : let dest_node_id = {
7407 0 : let locked = self.inner.read().unwrap();
7408 0 :
7409 0 : match tid_drain
7410 0 : .tenant_shard_eligible_for_drain(&locked.tenants, &locked.scheduler)
7411 : {
7412 0 : Some(node_id) => node_id,
7413 : None => {
7414 0 : continue;
7415 : }
7416 : }
7417 : };
7418 :
7419 0 : match self.secondary_lag(&dest_node_id, tid).await {
7420 0 : Ok(Some(lag)) if lag <= max_secondary_lag_bytes => {
7421 0 : // The secondary is reasonably up to date.
7422 0 : // Migrate to it
7423 0 : }
7424 0 : Ok(Some(lag)) => {
7425 0 : tracing::info!(
7426 0 : tenant_id=%tid.tenant_id, shard_id=%tid.shard_slug(),
7427 0 : "Secondary on node {dest_node_id} is lagging by {lag}. Skipping reconcile."
7428 : );
7429 0 : continue;
7430 : }
7431 : Ok(None) => {
7432 0 : tracing::info!(
7433 0 : tenant_id=%tid.tenant_id, shard_id=%tid.shard_slug(),
7434 0 : "Could not determine lag for secondary on node {dest_node_id}. Skipping reconcile."
7435 : );
7436 0 : continue;
7437 : }
7438 0 : Err(err) => {
7439 0 : tracing::warn!(
7440 0 : tenant_id=%tid.tenant_id, shard_id=%tid.shard_slug(),
7441 0 : "Failed to get secondary lag from node {dest_node_id}. Skipping reconcile: {err}"
7442 : );
7443 0 : continue;
7444 : }
7445 : }
7446 :
7447 : {
7448 0 : let mut locked = self.inner.write().unwrap();
7449 0 : let (nodes, tenants, scheduler) = locked.parts_mut();
7450 0 : let rescheduled = tid_drain.reschedule_to_secondary(
7451 0 : dest_node_id,
7452 0 : tenants,
7453 0 : scheduler,
7454 0 : nodes,
7455 0 : )?;
7456 :
7457 0 : if let Some(tenant_shard) = rescheduled {
7458 0 : let waiter = self.maybe_configured_reconcile_shard(
7459 0 : tenant_shard,
7460 0 : nodes,
7461 0 : reconciler_config,
7462 0 : );
7463 0 : if let Some(some) = waiter {
7464 0 : waiters.push(some);
7465 0 : }
7466 0 : }
7467 : }
7468 : }
7469 :
7470 0 : waiters = self
7471 0 : .await_waiters_remainder(waiters, WAITER_FILL_DRAIN_POLL_TIMEOUT)
7472 0 : .await;
7473 :
7474 0 : failpoint_support::sleep_millis_async!("sleepy-drain-loop", &cancel);
7475 : }
7476 :
7477 0 : while !waiters.is_empty() {
7478 0 : if cancel.is_cancelled() {
7479 0 : match self
7480 0 : .node_configure(node_id, None, Some(NodeSchedulingPolicy::Active))
7481 0 : .await
7482 : {
7483 0 : Ok(()) => return Err(OperationError::Cancelled),
7484 0 : Err(err) => {
7485 0 : return Err(OperationError::FinalizeError(
7486 0 : format!(
7487 0 : "Failed to finalise drain cancel of {} by setting scheduling policy to Active: {}",
7488 0 : node_id, err
7489 0 : )
7490 0 : .into(),
7491 0 : ));
7492 : }
7493 : }
7494 0 : }
7495 0 :
7496 0 : tracing::info!("Awaiting {} pending drain reconciliations", waiters.len());
7497 :
7498 0 : waiters = self
7499 0 : .await_waiters_remainder(waiters, SHORT_RECONCILE_TIMEOUT)
7500 0 : .await;
7501 : }
7502 :
7503 : // At this point we have done the best we could to drain shards from this node.
7504 : // Set the node scheduling policy to `[NodeSchedulingPolicy::PauseForRestart]`
7505 : // to complete the drain.
7506 0 : if let Err(err) = self
7507 0 : .node_configure(node_id, None, Some(NodeSchedulingPolicy::PauseForRestart))
7508 0 : .await
7509 : {
7510 : // This is not fatal. Anything that is polling the node scheduling policy to detect
7511 : // the end of the drain operations will hang, but all such places should enforce an
7512 : // overall timeout. The scheduling policy will be updated upon node re-attach and/or
7513 : // by the counterpart fill operation.
7514 0 : return Err(OperationError::FinalizeError(
7515 0 : format!(
7516 0 : "Failed to finalise drain of {node_id} by setting scheduling policy to PauseForRestart: {err}"
7517 0 : )
7518 0 : .into(),
7519 0 : ));
7520 0 : }
7521 0 :
7522 0 : Ok(())
7523 0 : }
7524 :
7525 : /// Create a node fill plan (pick secondaries to promote), based on:
7526 : /// 1. Shards which have a secondary on this node, and this node is in their home AZ, and are currently attached to a node
7527 : /// outside their home AZ, should be migrated back here.
7528 : /// 2. If after step 1 we have not migrated enough shards for this node to have its fair share of
7529 : /// attached shards, we will promote more shards from the nodes with the most attached shards, unless
7530 : /// those shards have a home AZ that doesn't match the node we're filling.
7531 0 : fn fill_node_plan(&self, node_id: NodeId) -> Vec<TenantShardId> {
7532 0 : let mut locked = self.inner.write().unwrap();
7533 0 : let (nodes, tenants, _scheduler) = locked.parts_mut();
7534 0 :
7535 0 : let node_az = nodes
7536 0 : .get(&node_id)
7537 0 : .expect("Node must exist")
7538 0 : .get_availability_zone_id()
7539 0 : .clone();
7540 0 :
7541 0 : // The tenant shard IDs that we plan to promote from secondary to attached on this node
7542 0 : let mut plan = Vec::new();
7543 0 :
7544 0 : // Collect shards which do not have a preferred AZ & are elegible for moving in stage 2
7545 0 : let mut free_tids_by_node: HashMap<NodeId, Vec<TenantShardId>> = HashMap::new();
7546 0 :
7547 0 : // Don't respect AZ preferences if there is only one AZ. This comes up in tests, but it could
7548 0 : // conceivably come up in real life if deploying a single-AZ region intentionally.
7549 0 : let respect_azs = nodes
7550 0 : .values()
7551 0 : .map(|n| n.get_availability_zone_id())
7552 0 : .unique()
7553 0 : .count()
7554 0 : > 1;
7555 :
7556 : // Step 1: collect all shards that we are required to migrate back to this node because their AZ preference
7557 : // requires it.
7558 0 : for (tsid, tenant_shard) in tenants {
7559 0 : if !tenant_shard.intent.get_secondary().contains(&node_id) {
7560 : // Shard doesn't have a secondary on this node, ignore it.
7561 0 : continue;
7562 0 : }
7563 0 :
7564 0 : // AZ check: when filling nodes after a restart, our intent is to move _back_ the
7565 0 : // shards which belong on this node, not to promote shards whose scheduling preference
7566 0 : // would be on their currently attached node. So will avoid promoting shards whose
7567 0 : // home AZ doesn't match the AZ of the node we're filling.
7568 0 : match tenant_shard.preferred_az() {
7569 0 : _ if !respect_azs => {
7570 0 : if let Some(primary) = tenant_shard.intent.get_attached() {
7571 0 : free_tids_by_node.entry(*primary).or_default().push(*tsid);
7572 0 : }
7573 : }
7574 : None => {
7575 : // Shard doesn't have an AZ preference: it is elegible to be moved, but we
7576 : // will only do so if our target shard count requires it.
7577 0 : if let Some(primary) = tenant_shard.intent.get_attached() {
7578 0 : free_tids_by_node.entry(*primary).or_default().push(*tsid);
7579 0 : }
7580 : }
7581 0 : Some(az) if az == &node_az => {
7582 : // This shard's home AZ is equal to the node we're filling: it should
7583 : // be moved back to this node as part of filling, unless its currently
7584 : // attached location is also in its home AZ.
7585 0 : if let Some(primary) = tenant_shard.intent.get_attached() {
7586 0 : if nodes
7587 0 : .get(primary)
7588 0 : .expect("referenced node must exist")
7589 0 : .get_availability_zone_id()
7590 0 : != tenant_shard
7591 0 : .preferred_az()
7592 0 : .expect("tenant must have an AZ preference")
7593 : {
7594 0 : plan.push(*tsid)
7595 0 : }
7596 : } else {
7597 0 : plan.push(*tsid)
7598 : }
7599 : }
7600 0 : Some(_) => {
7601 0 : // This shard's home AZ is somewhere other than the node we're filling,
7602 0 : // it may not be moved back to this node as part of filling. Ignore it
7603 0 : }
7604 : }
7605 : }
7606 :
7607 : // Step 2: also promote any AZ-agnostic shards as required to achieve the target number of attachments
7608 0 : let fill_requirement = locked.scheduler.compute_fill_requirement(node_id);
7609 0 :
7610 0 : let expected_attached = locked.scheduler.expected_attached_shard_count();
7611 0 : let nodes_by_load = locked.scheduler.nodes_by_attached_shard_count();
7612 0 :
7613 0 : let mut promoted_per_tenant: HashMap<TenantId, usize> = HashMap::new();
7614 :
7615 0 : for (node_id, attached) in nodes_by_load {
7616 0 : let available = locked.nodes.get(&node_id).is_some_and(|n| n.is_available());
7617 0 : if !available {
7618 0 : continue;
7619 0 : }
7620 0 :
7621 0 : if plan.len() >= fill_requirement
7622 0 : || free_tids_by_node.is_empty()
7623 0 : || attached <= expected_attached
7624 : {
7625 0 : break;
7626 0 : }
7627 0 :
7628 0 : let can_take = attached - expected_attached;
7629 0 : let needed = fill_requirement - plan.len();
7630 0 : let mut take = std::cmp::min(can_take, needed);
7631 0 :
7632 0 : let mut remove_node = false;
7633 0 : while take > 0 {
7634 0 : match free_tids_by_node.get_mut(&node_id) {
7635 0 : Some(tids) => match tids.pop() {
7636 0 : Some(tid) => {
7637 0 : let max_promote_for_tenant = std::cmp::max(
7638 0 : tid.shard_count.count() as usize / locked.nodes.len(),
7639 0 : 1,
7640 0 : );
7641 0 : let promoted = promoted_per_tenant.entry(tid.tenant_id).or_default();
7642 0 : if *promoted < max_promote_for_tenant {
7643 0 : plan.push(tid);
7644 0 : *promoted += 1;
7645 0 : take -= 1;
7646 0 : }
7647 : }
7648 : None => {
7649 0 : remove_node = true;
7650 0 : break;
7651 : }
7652 : },
7653 : None => {
7654 0 : break;
7655 : }
7656 : }
7657 : }
7658 :
7659 0 : if remove_node {
7660 0 : free_tids_by_node.remove(&node_id);
7661 0 : }
7662 : }
7663 :
7664 0 : plan
7665 0 : }
7666 :
7667 : /// Fill a node by promoting its secondaries until the cluster is balanced
7668 : /// with regards to attached shard counts. Note that this operation only
7669 : /// makes sense as a counterpart to the drain implemented in [`Service::drain_node`].
7670 : /// This is a long running operation and it should run as a separate Tokio task.
7671 0 : pub(crate) async fn fill_node(
7672 0 : &self,
7673 0 : node_id: NodeId,
7674 0 : cancel: CancellationToken,
7675 0 : ) -> Result<(), OperationError> {
7676 : const SECONDARY_WARMUP_TIMEOUT: Duration = Duration::from_secs(20);
7677 : const SECONDARY_DOWNLOAD_REQUEST_TIMEOUT: Duration = Duration::from_secs(5);
7678 0 : let reconciler_config = ReconcilerConfigBuilder::new(ReconcilerPriority::Normal)
7679 0 : .secondary_warmup_timeout(SECONDARY_WARMUP_TIMEOUT)
7680 0 : .secondary_download_request_timeout(SECONDARY_DOWNLOAD_REQUEST_TIMEOUT)
7681 0 : .build();
7682 0 :
7683 0 : let mut tids_to_promote = self.fill_node_plan(node_id);
7684 0 : let mut waiters = Vec::new();
7685 :
7686 : // Execute the plan we've composed above. Before aplying each move from the plan,
7687 : // we validate to ensure that it has not gone stale in the meantime.
7688 0 : while !tids_to_promote.is_empty() {
7689 0 : if cancel.is_cancelled() {
7690 0 : match self
7691 0 : .node_configure(node_id, None, Some(NodeSchedulingPolicy::Active))
7692 0 : .await
7693 : {
7694 0 : Ok(()) => return Err(OperationError::Cancelled),
7695 0 : Err(err) => {
7696 0 : return Err(OperationError::FinalizeError(
7697 0 : format!(
7698 0 : "Failed to finalise drain cancel of {} by setting scheduling policy to Active: {}",
7699 0 : node_id, err
7700 0 : )
7701 0 : .into(),
7702 0 : ));
7703 : }
7704 : }
7705 0 : }
7706 0 :
7707 0 : {
7708 0 : let mut locked = self.inner.write().unwrap();
7709 0 : let (nodes, tenants, scheduler) = locked.parts_mut();
7710 :
7711 0 : let node = nodes.get(&node_id).ok_or(OperationError::NodeStateChanged(
7712 0 : format!("node {node_id} was removed").into(),
7713 0 : ))?;
7714 :
7715 0 : let current_policy = node.get_scheduling();
7716 0 : if !matches!(current_policy, NodeSchedulingPolicy::Filling) {
7717 : // TODO(vlad): maybe cancel pending reconciles before erroring out. need to think
7718 : // about it
7719 0 : return Err(OperationError::NodeStateChanged(
7720 0 : format!("node {node_id} changed state to {current_policy:?}").into(),
7721 0 : ));
7722 0 : }
7723 :
7724 0 : while waiters.len() < MAX_RECONCILES_PER_OPERATION {
7725 0 : if let Some(tid) = tids_to_promote.pop() {
7726 0 : if let Some(tenant_shard) = tenants.get_mut(&tid) {
7727 : // If the node being filled is not a secondary anymore,
7728 : // skip the promotion.
7729 0 : if !tenant_shard.intent.get_secondary().contains(&node_id) {
7730 0 : continue;
7731 0 : }
7732 0 :
7733 0 : let previously_attached_to = *tenant_shard.intent.get_attached();
7734 0 : match tenant_shard.reschedule_to_secondary(Some(node_id), scheduler) {
7735 0 : Err(e) => {
7736 0 : tracing::warn!(
7737 0 : tenant_id=%tid.tenant_id, shard_id=%tid.shard_slug(),
7738 0 : "Scheduling error when filling pageserver {} : {e}", node_id
7739 : );
7740 : }
7741 : Ok(()) => {
7742 0 : tracing::info!(
7743 0 : tenant_id=%tid.tenant_id, shard_id=%tid.shard_slug(),
7744 0 : "Rescheduled shard while filling node {}: {:?} -> {}",
7745 : node_id,
7746 : previously_attached_to,
7747 : node_id
7748 : );
7749 :
7750 0 : if let Some(waiter) = self.maybe_configured_reconcile_shard(
7751 0 : tenant_shard,
7752 0 : nodes,
7753 0 : reconciler_config,
7754 0 : ) {
7755 0 : waiters.push(waiter);
7756 0 : }
7757 : }
7758 : }
7759 0 : }
7760 : } else {
7761 0 : break;
7762 : }
7763 : }
7764 : }
7765 :
7766 0 : waiters = self
7767 0 : .await_waiters_remainder(waiters, WAITER_FILL_DRAIN_POLL_TIMEOUT)
7768 0 : .await;
7769 : }
7770 :
7771 0 : while !waiters.is_empty() {
7772 0 : if cancel.is_cancelled() {
7773 0 : match self
7774 0 : .node_configure(node_id, None, Some(NodeSchedulingPolicy::Active))
7775 0 : .await
7776 : {
7777 0 : Ok(()) => return Err(OperationError::Cancelled),
7778 0 : Err(err) => {
7779 0 : return Err(OperationError::FinalizeError(
7780 0 : format!(
7781 0 : "Failed to finalise drain cancel of {} by setting scheduling policy to Active: {}",
7782 0 : node_id, err
7783 0 : )
7784 0 : .into(),
7785 0 : ));
7786 : }
7787 : }
7788 0 : }
7789 0 :
7790 0 : tracing::info!("Awaiting {} pending fill reconciliations", waiters.len());
7791 :
7792 0 : waiters = self
7793 0 : .await_waiters_remainder(waiters, SHORT_RECONCILE_TIMEOUT)
7794 0 : .await;
7795 : }
7796 :
7797 0 : if let Err(err) = self
7798 0 : .node_configure(node_id, None, Some(NodeSchedulingPolicy::Active))
7799 0 : .await
7800 : {
7801 : // This isn't a huge issue since the filling process starts upon request. However, it
7802 : // will prevent the next drain from starting. The only case in which this can fail
7803 : // is database unavailability. Such a case will require manual intervention.
7804 0 : return Err(OperationError::FinalizeError(
7805 0 : format!("Failed to finalise fill of {node_id} by setting scheduling policy to Active: {err}")
7806 0 : .into(),
7807 0 : ));
7808 0 : }
7809 0 :
7810 0 : Ok(())
7811 0 : }
7812 :
7813 : /// Updates scrubber metadata health check results.
7814 0 : pub(crate) async fn metadata_health_update(
7815 0 : &self,
7816 0 : update_req: MetadataHealthUpdateRequest,
7817 0 : ) -> Result<(), ApiError> {
7818 0 : let now = chrono::offset::Utc::now();
7819 0 : let (healthy_records, unhealthy_records) = {
7820 0 : let locked = self.inner.read().unwrap();
7821 0 : let healthy_records = update_req
7822 0 : .healthy_tenant_shards
7823 0 : .into_iter()
7824 0 : // Retain only health records associated with tenant shards managed by storage controller.
7825 0 : .filter(|tenant_shard_id| locked.tenants.contains_key(tenant_shard_id))
7826 0 : .map(|tenant_shard_id| MetadataHealthPersistence::new(tenant_shard_id, true, now))
7827 0 : .collect();
7828 0 : let unhealthy_records = update_req
7829 0 : .unhealthy_tenant_shards
7830 0 : .into_iter()
7831 0 : .filter(|tenant_shard_id| locked.tenants.contains_key(tenant_shard_id))
7832 0 : .map(|tenant_shard_id| MetadataHealthPersistence::new(tenant_shard_id, false, now))
7833 0 : .collect();
7834 0 :
7835 0 : (healthy_records, unhealthy_records)
7836 0 : };
7837 0 :
7838 0 : self.persistence
7839 0 : .update_metadata_health_records(healthy_records, unhealthy_records, now)
7840 0 : .await?;
7841 0 : Ok(())
7842 0 : }
7843 :
7844 : /// Lists the tenant shards that has unhealthy metadata status.
7845 0 : pub(crate) async fn metadata_health_list_unhealthy(
7846 0 : &self,
7847 0 : ) -> Result<Vec<TenantShardId>, ApiError> {
7848 0 : let result = self
7849 0 : .persistence
7850 0 : .list_unhealthy_metadata_health_records()
7851 0 : .await?
7852 0 : .iter()
7853 0 : .map(|p| p.get_tenant_shard_id().unwrap())
7854 0 : .collect();
7855 0 :
7856 0 : Ok(result)
7857 0 : }
7858 :
7859 : /// Lists the tenant shards that have not been scrubbed for some duration.
7860 0 : pub(crate) async fn metadata_health_list_outdated(
7861 0 : &self,
7862 0 : not_scrubbed_for: Duration,
7863 0 : ) -> Result<Vec<MetadataHealthRecord>, ApiError> {
7864 0 : let earlier = chrono::offset::Utc::now() - not_scrubbed_for;
7865 0 : let result = self
7866 0 : .persistence
7867 0 : .list_outdated_metadata_health_records(earlier)
7868 0 : .await?
7869 0 : .into_iter()
7870 0 : .map(|record| record.into())
7871 0 : .collect();
7872 0 : Ok(result)
7873 0 : }
7874 :
7875 0 : pub(crate) fn get_leadership_status(&self) -> LeadershipStatus {
7876 0 : self.inner.read().unwrap().get_leadership_status()
7877 0 : }
7878 :
7879 0 : pub(crate) async fn step_down(&self) -> GlobalObservedState {
7880 0 : tracing::info!("Received step down request from peer");
7881 0 : failpoint_support::sleep_millis_async!("sleep-on-step-down-handling");
7882 :
7883 0 : self.inner.write().unwrap().step_down();
7884 0 : // TODO: would it make sense to have a time-out for this?
7885 0 : self.stop_reconciliations(StopReconciliationsReason::SteppingDown)
7886 0 : .await;
7887 :
7888 0 : let mut global_observed = GlobalObservedState::default();
7889 0 : let locked = self.inner.read().unwrap();
7890 0 : for (tid, tenant_shard) in locked.tenants.iter() {
7891 0 : global_observed
7892 0 : .0
7893 0 : .insert(*tid, tenant_shard.observed.clone());
7894 0 : }
7895 :
7896 0 : global_observed
7897 0 : }
7898 :
7899 0 : pub(crate) async fn safekeepers_list(
7900 0 : &self,
7901 0 : ) -> Result<Vec<SafekeeperDescribeResponse>, DatabaseError> {
7902 0 : let locked = self.inner.read().unwrap();
7903 0 : let mut list = locked
7904 0 : .safekeepers
7905 0 : .iter()
7906 0 : .map(|sk| sk.1.describe_response())
7907 0 : .collect::<Result<Vec<_>, _>>()?;
7908 0 : list.sort_by_key(|v| v.id);
7909 0 : Ok(list)
7910 0 : }
7911 :
7912 0 : pub(crate) async fn get_safekeeper(
7913 0 : &self,
7914 0 : id: i64,
7915 0 : ) -> Result<SafekeeperDescribeResponse, DatabaseError> {
7916 0 : let locked = self.inner.read().unwrap();
7917 0 : let sk = locked
7918 0 : .safekeepers
7919 0 : .get(&NodeId(id as u64))
7920 0 : .ok_or(diesel::result::Error::NotFound)?;
7921 0 : sk.describe_response()
7922 0 : }
7923 :
7924 0 : pub(crate) async fn upsert_safekeeper(
7925 0 : &self,
7926 0 : record: crate::persistence::SafekeeperUpsert,
7927 0 : ) -> Result<(), DatabaseError> {
7928 0 : let node_id = NodeId(record.id as u64);
7929 0 : self.persistence.safekeeper_upsert(record.clone()).await?;
7930 : {
7931 0 : let mut locked = self.inner.write().unwrap();
7932 0 : let mut safekeepers = (*locked.safekeepers).clone();
7933 0 : match safekeepers.entry(node_id) {
7934 0 : std::collections::hash_map::Entry::Occupied(mut entry) => {
7935 0 : entry.get_mut().update_from_record(record);
7936 0 : }
7937 0 : std::collections::hash_map::Entry::Vacant(entry) => {
7938 0 : entry.insert(Safekeeper::from_persistence(
7939 0 : crate::persistence::SafekeeperPersistence::from_upsert(
7940 0 : record,
7941 0 : SkSchedulingPolicy::Pause,
7942 0 : ),
7943 0 : CancellationToken::new(),
7944 0 : ));
7945 0 : }
7946 : }
7947 0 : locked.safekeepers = Arc::new(safekeepers);
7948 0 : }
7949 0 : Ok(())
7950 0 : }
7951 :
7952 0 : pub(crate) async fn set_safekeeper_scheduling_policy(
7953 0 : &self,
7954 0 : id: i64,
7955 0 : scheduling_policy: SkSchedulingPolicy,
7956 0 : ) -> Result<(), DatabaseError> {
7957 0 : self.persistence
7958 0 : .set_safekeeper_scheduling_policy(id, scheduling_policy)
7959 0 : .await?;
7960 0 : let node_id = NodeId(id as u64);
7961 0 : // After the change has been persisted successfully, update the in-memory state
7962 0 : {
7963 0 : let mut locked = self.inner.write().unwrap();
7964 0 : let mut safekeepers = (*locked.safekeepers).clone();
7965 0 : let sk = safekeepers
7966 0 : .get_mut(&node_id)
7967 0 : .ok_or(DatabaseError::Logical("Not found".to_string()))?;
7968 0 : sk.set_scheduling_policy(scheduling_policy);
7969 0 :
7970 0 : locked.safekeepers = Arc::new(safekeepers);
7971 0 : }
7972 0 : Ok(())
7973 0 : }
7974 :
7975 0 : pub(crate) async fn update_shards_preferred_azs(
7976 0 : &self,
7977 0 : req: ShardsPreferredAzsRequest,
7978 0 : ) -> Result<ShardsPreferredAzsResponse, ApiError> {
7979 0 : let preferred_azs = req.preferred_az_ids.into_iter().collect::<Vec<_>>();
7980 0 : let updated = self
7981 0 : .persistence
7982 0 : .set_tenant_shard_preferred_azs(preferred_azs)
7983 0 : .await
7984 0 : .map_err(|err| {
7985 0 : ApiError::InternalServerError(anyhow::anyhow!(
7986 0 : "Failed to persist preferred AZs: {err}"
7987 0 : ))
7988 0 : })?;
7989 :
7990 0 : let mut updated_in_mem_and_db = Vec::default();
7991 0 :
7992 0 : let mut locked = self.inner.write().unwrap();
7993 0 : for (tid, az_id) in updated {
7994 0 : let shard = locked.tenants.get_mut(&tid);
7995 0 : if let Some(shard) = shard {
7996 0 : shard.set_preferred_az(az_id);
7997 0 : updated_in_mem_and_db.push(tid);
7998 0 : }
7999 : }
8000 :
8001 0 : Ok(ShardsPreferredAzsResponse {
8002 0 : updated: updated_in_mem_and_db,
8003 0 : })
8004 0 : }
8005 : }
|
